RE: [PATCH v5] app/eventdev: add crypto producer mode

Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Wednesday, February 16, 2022 12:39 PM > To: Gujjar, Abhinandan S > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Subject: RE: [PATCH v5] app/eventdev: add crypto producer mode > > >> > >> In crypto producer mode, producer

[PATCH v2] net/ice/base: support E824S and E825 devices

Add support for E824S and E825 family devices. Signed-off-by: Robin Zhang --- doc/guides/rel_notes/release_22_03.rst | 4 drivers/net/ice/base/ice_common.c | 6 ++ drivers/net/ice/base/ice_devids.h | 13 + drivers/net/ice/ice_ethdev.c | 6 ++ 4 fil

RE: [PATCH v5] app/eventdev: add crypto producer mode

>> >> In crypto producer mode, producer core enqueues cryptodev with software >> generated crypto ops and worker core dequeues crypto completion events >> from the eventdev. Event crypto metadata used for above processing is pre- >> populated in each crypto session. >> >> Parameter --prod_type_cryp

[RFC 2/2] examples/vhost: use API to check inflight packets

From: Xuan Ding In async data path, call rte_vhost_async_get_inflight_thread_unsafe() API to directly return the number of inflight packets instead of maintaining a local variable. Signed-off-by: Xuan Ding --- examples/vhost/main.c | 28 +++- examples/vhost/main.h | 1

[RFC 1/2] vhost: add unsafe API to check inflight packets

From: Xuan Ding In async data path, when vring state changes or device is destroyed, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets for a vhost queue without using any lock. Signed-off-by: Xua

[RFC 0/2] add unsafe API to get inflight packets

From: Xuan Ding This patchset introduces an unsafe API to get the number of inflight packets in DMA engine in some situations. Like vring state changes or device is destroyed. Compared with rte_vhost_async_get_inflight(), this is a lock free version. Xuan Ding (2): vhost: add unsafe API to che

RE: [PATCH v5] app/eventdev: add crypto producer mode

Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Tuesday, February 15, 2022 10:27 PM > To: dev@dpdk.org; jer...@marvell.com > Cc: Shijith Thotton ; Gujjar, Abhinandan S > > Subject: [PATCH v5] app/eventdev: add crypto producer mode > > In crypto producer mode, producer c

[PATCH v4 2/2] vhost: fix physical address mapping

From: Xuan Ding When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 (

[PATCH v4 1/2] vhost: fix field naming in guest page struct

From: Xuan Ding This patch renames the host_phys_addr to host_iova in guest_page struct. The host_phys_addr is iova, it depends on the DPDK IOVA mode. Fixes: e246896178e6 ("vhost: get guest/host physical address mappings") Cc: sta...@dpdk.org Signed-off-by: Xuan Ding Reviewed-by: Maxime Coquel

[PATCH v4 0/2] vhost: fix async address mapping

From: Xuan Ding This patchset fixes the issue of incorrect DMA mapping in PA mode. Due to the ambiguity of host_phys_addr naming in the guest page struct, rename it to host_iova. v4: * Fix the patch timezone. v3: * Fix some format issues. v2: * Change the order of patch. Xuan Ding (2): vhos

RE: [PATCH] app/testpmd: format dump information of module EEPROM

Hi Ferruh, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, February 15, 2022 11:08 PM > To: Zhang, RobinX ; dev@dpdk.org; Zhang, Qi Z > ; Yigit, Ferruh > Cc: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > Guo, Junfeng ; Yang, SteveX > ; David Marchand > Subjec

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

Hi Zidane, I40e used UDP dst port 4789 for Vxlan. BR, Beilei From: Raja Zidane Sent: Tuesday, February 15, 2022 10:31 PM To: Singh, Aman Deep ; Matan Azrad ; Yigit, Ferruh ; dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z Cc: sta...@dpdk.org Subject: RE: [PATCH] app/testpmd: fix GENEVE parsing in c

[RFC 2/2] treewide: replace zero-length array with flex array

Apply the coccinelle strip to find/fix use of zero length arrays at end of structures. Signed-off-by: Stephen Hemminger --- app/test/test_table_tables.c | 2 +- drivers/bus/dpaa/include/netcfg.h | 4 ++-- drivers/common/cnxk/roc_se.h | 2 +- drivers/

[RFC 1/2] devtools: add script to check for zero length array

Use the same script as Linux kernel to find and replace zero length arrays at end of structures. Flexible arrays were introduced in C99 and help catch some obvious errors (like incorrect sizeof). Signed-off-by: Stephen Hemminger --- devtools/cocci/zerolengtharray.cocci | 17 + 1

[RFC 0/2] Eliminate zero length arrays in DPDK

Yet another case of applying Linux kernel best practices to DPDK. Flexible arrays are supported by Clang, GCC and Microsoft compilers (part of C99). Stephen Hemminger (2): devtools: add script to check for zero length array treewide: replace zero-length array with flex array app/test/test_ta

[PATCH v3 6/7] net/ark: add memory write barriers in critical code paths

Add memory write barriers for read and wait status functions in ddm, udm and mpu. Signed-off-by: John Miller --- drivers/net/ark/ark_ddm.c | 1 + drivers/net/ark/ark_mpu.c | 1 + drivers/net/ark/ark_udm.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/net/ark/ark_ddm.c b/drivers/n

[PATCH v3 7/7] net/ark: add performance optimizations

Added software register writes for hw optimization and performance fixes. Signed-off-by: John Miller --- drivers/net/ark/ark_udm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ark/ark_udm.c b/drivers/net/ark/ark_udm.c index cb3cf5c941..9ebed89627 100644 --- a/drivers/net/ark

[PATCH v3 5/7] net/ark: support chunk DMA transfers

Add support for chunk DMA transfers. Chunk mpu transfer use 64 objects (512 byte) to maintain memory read alignment. Align mpu memory allocation to be at 512 byte boundaries. Reduce force-close allocation from 1 objects to 64 objects. Signed-off-by: John Miller --- drivers/net/ark/ark_eth

[PATCH v3 4/7] net/ark: packet generator and checker status update

Configuration status updates for internal packet checker and generator. Signed-off-by: John Miller --- drivers/net/ark/ark_pktchkr.c | 2 +- drivers/net/ark/ark_pktgen.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark/ark_pk

[PATCH v3 3/7] net/ark: support arbitrary mbuf size

Added arbitrary mbuf size per queue capability. Updated ARK_UDM_CONST3 value to reflect the version number read from the HW that is required to support this change. Signed-off-by: John Miller --- drivers/net/ark/ark_ethdev.c| 8 drivers/net/ark/ark_ethdev_rx.c | 23

[PATCH v3 2/7] net/ark: add support for new devices

Add two new supported device ID's. Add documentation for new devices. Signed-off-by: John Miller --- v3: - Split patch and added documentation --- doc/guides/nics/ark.rst | 2 ++ drivers/net/ark/ark_ethdev.c | 4 2 files changed, 6 insertions(+) diff --git a/doc/guides/nics/ark.rst b

[PATCH v3 1/7] net/ark: add device capabilities record

Add a device capabilities record for supported features. Certain variants require that PCIe read-requests be correctly throttled. This is called "rqpacing" in Arkville, and has to do with credit and flow control on certain Arkville implementations. Signed-off-by: John Miller --- v2: - Improved c

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

15/02/2022 19:51, Singh, Aman Deep: > On 2/11/2022 10:58 PM, Thomas Monjalon wrote: > > 11/02/2022 09:07, Singh, Aman Deep: > >> On 2/10/2022 9:00 PM, Thomas Monjalon wrote: > >>> 10/02/2022 14:26, Singh, Aman Deep: > On 2/4/2022 1:17 PM, Thomas Monjalon wrote: > > 04/02/2022 07:13, Singh,

Re: [PATCH] net/virtio: include ipv4 cksum to support cksum offload capability

Adding Olivier who, iirc, worked on those offloads a long time ago. On Fri, Jan 7, 2022 at 12:54 PM Harold Huang wrote: > > Device cksum offload capability usually include ipv4 cksum, tcp and udp > cksum offload capability. The application such as OVS usually negotiate > with the drive like this

Re: [PATCH v2] kni: fix use-after-free when kni release

On 2/14/2022 6:41 PM, Ferruh Yigit wrote: On 2/9/2022 7:35 AM, Min Hu (Connor) wrote: From: Huisong Li The "kni_dev" is the private data of the "net_device" in kni, and allocated with the "net_device" by calling "alloc_netdev()". The "net_device" is freed by calling "free_netdev()" when kni re

Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace

On 2/11/2022 10:58 PM, Thomas Monjalon wrote: 11/02/2022 09:07, Singh, Aman Deep: On 2/10/2022 9:00 PM, Thomas Monjalon wrote: 10/02/2022 14:26, Singh, Aman Deep: On 2/4/2022 1:17 PM, Thomas Monjalon wrote: 04/02/2022 07:13, Singh, Aman Deep: Hi Thomas On 2/3/2022 2:31 AM, Thomas Monjalon

Re: [PATCH 00/11] add missing C++ guards

On Tue, Feb 15, 2022 at 05:08:06PM +, Brian Dooley wrote: > Public header files were missing 'extern "C"' guards. > This set adds them in. > > Brian Dooley (11): > eal: fix missing C++ guards > telemetry: fix missing C++ guards > ethdev: fix missing C++ guards > metrics: fix missing C+

[PATCH 0/3] extend C++ compatibility checks

This set expands upon existing checks for C++ compatibility, adding in checks for both the SDK headers and a basic check for the presence of 'extern "C"' guards in each file. Depends-on: series-21685 ("add missing C++ guards") Bruce Richardson (3): ethdev: fix missing cast for C++ compatibilit

[PATCH 3/3] buildtools/chkincs: add checks for missing C++ guards

Simply compiling a C header with a C++ compiler is not enough to flag missing 'extern "C"' guards. To catch missing guards, we can just use a simple grep for the 'extern "C"' part, and error out if any files have a miss. Signed-off-by: Bruce Richardson --- Depends-on: series-21685 ("add missing

[PATCH 2/3] buildtools/chkincs: check sdk headers for C++ compatibility

With a one-line change to the lib meson.build file we can add the sdk headers to the list of files to be checked using the chkincs binary. Unfortunately, many of those sdk header depend upon headers in the PCI and vdev bus drivers, so we need to update chkincs build to ensure those dependencies are

[PATCH 1/3] ethdev: fix missing cast for C++ compatibility

C++ does not allow implicit conversion to/from void*, so we need an explicit cast to allow the driver sdk header to be included from C++ code. Signed-off-by: Bruce Richardson --- lib/ethdev/ethdev_pci.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/ethdev_pc

[PATCH 11/11] cryptodev: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers") Cc: tho...@monjalon.net Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/cryptodev/cr

[PATCH 10/11] bpf: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers") Cc: tho...@monjalon.net Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/bpf/bpf_def.

[PATCH 09/11] vhost: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: d7280c9fffcb ("vhost: support selective datapath") Fixes: 78639d54563a ("vhost: introduce async enqueue registration API") Fixes: 3bb595ecd682 ("vhost/crypto: add

[PATCH 08/11] kni: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: 3fc5ca2f6352 ("kni: initial import") Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/kni/rte_kni_common.h | 8 1 file changed, 8 insertions(+)

[PATCH 07/11] eventdev: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: dc39e2f359b5 ("eventdev: add ring structure for events") Fixes: 7a3357205755 ("lib: remove C++ include guard from private headers") Cc: bruce.richard...@intel.com

[PATCH 06/11] compressdev: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: ed7dd94f7f66 ("compressdev: add basic device management") Cc: fiona.tr...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/compressdev/rte_comp

[PATCH 05/11] acl: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: dc276b5780c2 ("acl: new library") Cc: konstantin.anan...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/acl/rte_acl_osdep.h | 8 1 f

[PATCH 04/11] metrics: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") Cc: ciara.po...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/metrics/rte

[PATCH 03/11] ethdev: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: 7a3f27cbf59b ("ethdev: add access to specific device info") Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") Fixes: 7f0a669e7b04 ("ethdev: add allocation hel

[PATCH 02/11] telemetry: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") Cc: ciara.po...@intel.com Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- lib/telemetry/rte_telemetry.h

[PATCH 01/11] eal: fix missing C++ guards

Some public header files were missing 'extern "C"' C++ guards, and couldnt be used by C++ applications. Add the missing guards. Fixes: af75078fece3 ("first public release") Fixes: 7f3aa0863903 ("eal: introduce bit operations API") Fixes: 166a743c53fa ("compat: add infrastructure to support symbol

[PATCH 00/11] add missing C++ guards

Public header files were missing 'extern "C"' guards. This set adds them in. Brian Dooley (11): eal: fix missing C++ guards telemetry: fix missing C++ guards ethdev: fix missing C++ guards metrics: fix missing C++ guards acl: fix missing C++ guards compressdev: fix missing C++ guards

[PATCH v5] app/eventdev: add crypto producer mode

In crypto producer mode, producer core enqueues cryptodev with software generated crypto ops and worker core dequeues crypto completion events from the eventdev. Event crypto metadata used for above processing is pre-populated in each crypto session. Parameter --prod_type_cryptodev can be used to

RE: [PATCH v2] eventdev/eth_rx: fix queue config get logic

Looks good. Thanks! Acked-by: Jay Jayatheerthan -Jay > -Original Message- > From: Naga Harish K, S V > Sent: Monday, February 14, 2022 10:40 PM > To: Jayatheerthan, Jay ; jer...@marvell.com > Cc: dev@dpdk.org > Subject: [PATCH v2] eventdev/eth_rx: fix queue config get logic > > remo

Re: [PATCH v2] net/failsafe: link_update request crashing at boot

On 2/14/2022 10:24 PM, Stephen Hemminger wrote: On Mon, 14 Feb 2022 13:09:19 + Vipul Ashri wrote: PORT 0 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, driver_type = 16) PORT 0 is polling for link-change, interrupts disabled [DPDK] tap_flow_create(): Kernel refused

RE: [PATCH v4] app/eventdev: add crypto producer mode

Hi Shijith, > -Original Message- > From: Shijith Thotton > Sent: Tuesday, February 15, 2022 9:39 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Jerin Jacob Kollanukkaran > Subject: RE: [PATCH v4] app/eventdev: add crypto producer mode > > Hi Abhinandan, > > >> > >> In crypto producer

Re: [PATCH v2] net/failsafe: link_update request crashing at boot

On 11/22/2021 3:53 PM, Gaëtan Rivet wrote: Could describe in more detail the execution? In particular, setting the EAL log-level to debug with the option: ' --log-level pmd.net.failsafe:debug' for example while using testpmd or your DPDK app. It should show ethdev level accesses to the sub-device

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

Thomas Monjalon writes: > 15/02/2022 14:55, Ray Kinsella: >> Ray Kinsella writes: >> > Thomas Monjalon writes: >> >> 14/02/2022 17:06, Ray Kinsella: >> >>> Thomas Monjalon writes: >> >>> > 14/02/2022 11:16, Ray Kinsella: >> >>> >> Ray Kinsella writes: >> >>> >> > Thomas Monjalon writes: >>

RE: [PATCH v4] app/eventdev: add crypto producer mode

Hi Abhinandan, >> >> In crypto producer mode, producer core enqueues cryptodev with software >> generated crypto ops and worker core dequeues crypto completion events >> from the eventdev. Event crypto metadata used for above processing is pre- >> populated in each crypto session. >> >> Parameter

Re: [PATCH] net/iavf: fix segmentation offload buffer size

On 2/15/2022 12:48 PM, Ferruh Yigit wrote: On 2/15/2022 12:44 PM, Ferruh Yigit wrote: On 2/15/2022 12:30 PM, Nicolau, Radu wrote: On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu N

[PATCH v2] net/iavf: fix segmentation offload buffer size

This fix commit ff8b8bcd2ebe, which resulted in incorrect buffer size being computed for non IPses TSO packets. Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition") Signed-off-by: Radu Nicolau --- v2: reworked it to fix the initial issue instead of just reverting ff8b8bcd2ebe d

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

On Tue, Feb 15, 2022 at 02:50:48PM +0100, Karl Bonde Torp wrote: > On Tue, 15 Feb 2022 at 12:27, Bruce Richardson > wrote: > > > > On Tue, Feb 15, 2022 at 12:07:55PM +0100, Karl Bonde Torp wrote: > > > On Mon, 14 Feb 2022 at 14:48, Bruce Richardson > > > wrote: > > > > > > > > On Mon, Feb 14, 202

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > When building with Meson 0.61.1 on FreeBSD some archives become > corrupted. This can be avoided by using 'llvm-ar' instead of 'ar'. > > Signed-off-by: Karl Bonde Torp > --- > buildtools/meson.build | 3 +++ > 1 file changed, 3 i

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

On Thu, Feb 10, 2022 at 6:01 PM Gaetan Rivet wrote: > > The function rte_devargs_parse() previously was safe to call with > non-initialized devargs structure as parameter. > > When adding the support for the global device syntax, > this assumption was broken. Restore it by forcing memset as part o

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

15/02/2022 14:55, Ray Kinsella: > Ray Kinsella writes: > > Thomas Monjalon writes: > >> 14/02/2022 17:06, Ray Kinsella: > >>> Thomas Monjalon writes: > >>> > 14/02/2022 11:16, Ray Kinsella: > >>> >> Ray Kinsella writes: > >>> >> > Thomas Monjalon writes: > >>> >> >> We never know how this enum

Re: [PATCH] app/testpmd: format dump information of module EEPROM

15/02/2022 14:28, Ferruh Yigit: > On 2/15/2022 10:18 AM, Robin Zhang wrote: > > This patch add a format specific information of different module eeprom. > > The format support for SFP(Small Formfactor Pluggable)/SFP+ > > /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on > > SFF(Small

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

Hi Raja Zidane, On 2/15/2022 8:01 PM, Raja Zidane wrote: Hi all, reviving the discussion. @Beilei Xing could you please provide info on what UDP destination ports are used for VxLan by i40 driver? if its just the default then we can remove "RTE_ETH_IS_TUNNEL_PK

RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

Hi all, reviving the discussion. @Beilei Xing could you please provide info on what UDP destination ports are used for VxLan by i40 driver? if its just the default then we can remove "RTE_ETH_IS_TUNNEL_PKT(pkt_type) == 0" From: Singh, Aman Deep Sent: Monday, Janua

Re: [dpdk-dev] [PATCH v2 0/3] fixes for ixgbe/txgbe/iavf

On 2/15/2022 1:01 PM, Yunjian Wang wrote: This series include three fixes patches for ixgbe/txgbe/iavf. --- v2: * update patch 1/3 code styles suggested by Haiyue Wang Yunjian Wang (3): net/ixgbe: set pointer to NULL after free net/txgbe: set pointer to NULL after free net/iavf: set

Re: [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build

Thank you for the review! On Tue, 2022-02-15 at 13:55 +, Ferruh Yigit wrote: > On 2/15/2022 12:55 PM, spin...@cesnet.cz wrote: > > From: Martin Spinler > > > > This series introduces standard RX timestamp offload flag support > > together with multiple MAC addresses support for NFB devices.

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

Ray Kinsella writes: > Thomas Monjalon writes: > >> 14/02/2022 17:06, Ray Kinsella: >>> Thomas Monjalon writes: >>> > 14/02/2022 11:16, Ray Kinsella: >>> >> Ray Kinsella writes: >>> >> > Thomas Monjalon writes: >>> >> >> 02/02/2022 12:44, Ray Kinsella: >>> >> >>> Ferruh Yigit writes: >>> >

Re: [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build

On 2/15/2022 12:55 PM, spin...@cesnet.cz wrote: From: Martin Spinler This series introduces standard RX timestamp offload flag support together with multiple MAC addresses support for NFB devices. Also fixes a promisc/multicast switch issue and minor annoyances. --- v2: * Removed libfdt depe

Re: [PATCH] build: fix build on FreeBSD with Meson 0.61.1

On Tue, 15 Feb 2022 at 12:27, Bruce Richardson wrote: > > On Tue, Feb 15, 2022 at 12:07:55PM +0100, Karl Bonde Torp wrote: > > On Mon, 14 Feb 2022 at 14:48, Bruce Richardson > > wrote: > > > > > > On Mon, Feb 14, 2022 at 12:43:13PM +0100, Karl Bonde Torp wrote: > > > > When building with Meson 0.

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

On Tue, Feb 15, 2022, at 13:51, Ferruh Yigit wrote: > On 2/10/2022 5:01 PM, Gaetan Rivet wrote: >> The function rte_devargs_parse() previously was safe to call with >> non-initialized devargs structure as parameter. >> >> When adding the support for the global device syntax, >> this assumption was

Re: [PATCH] app/testpmd: format dump information of module EEPROM

On 2/15/2022 10:18 AM, Robin Zhang wrote: This patch add a format specific information of different module eeprom. The format support for SFP(Small Formfactor Pluggable)/SFP+ /QSFP+(Quad Small Formfactor Pluggable)/QSFP28 modules based on SFF(Small Form Factor) Committee specifications SFF-8079/S

Re: [PATCH 6/6] drivers/nfb: add support for more MAC addresses

On Mon, 2022-02-14 at 17:54 +, Ferruh Yigit wrote: > > > > @@ -530,7 +577,7 @@ nfb_eth_dev_init(struct rte_eth_dev *dev) > > > > eth_addr_init.addr_bytes[1] = eth_addr.addr_bytes[1]; > > > > eth_addr_init.addr_bytes[2] = eth_addr.addr_bytes[2]; > > > >     > > > > - nfb_e

Re: [PATCH] net/enic: fix dereference before null check

On 2/14/2022 8:46 PM, John Daley wrote: This patch fixes an issue found by coverity. It checks for a possible null value of "error" before dereferencing it. CID: 375064: Dereference after null check Either the check against null is unnecessary, or there may be a null pointer dereference. Coveri

[PATCH v2 5/5] net/nfb: add support for more MAC addresses

From: Martin Spinler Extend the eth_dev_ops by add/remove MAC address functions. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev.c | 90 ++-- 1 file changed, 77 insertions(+), 13 deletions(-) diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/

[PATCH v2 4/5] net/nfb: fix multicast/promiscuous mode switching

From: Martin Spinler In the firmware, the promisc mode overrides the multicast mode. So when the promisc mode is turned off, driver must check if the multicast mode was active before and conditionally reactivate it. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Cc: cer...@netcope.com C

[PATCH v2 3/5] net/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag

From: Martin Spinler Rewrite the RX timestamp setup code to use standard offload flag. Signed-off-by: Martin Spinler --- doc/guides/nics/nfb.rst | 8 ++ drivers/net/nfb/nfb.h| 3 +- drivers/net/nfb/nfb_ethdev.c | 19 - drivers/net/nfb/nfb_rx.c | 53 --

[PATCH v2 2/5] net/nfb: do not report zero-sized TX burst

From: Martin Spinler Zero-sized TX burst floods the log no more. Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_tx.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h index d3cbe3e6b3..910020e9e9 100644 --- a/driv

[PATCH v2 1/5] net/nfb: fix array indexes in deinit functions

From: Martin Spinler The indexes in the for cycle were wrongly used and the code accessed outside of the rxmac/txmac array. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Cc: cer...@netcope.com Cc: sta...@dpdk.org Signed-off-by: Martin Spinler --- drivers/net/nfb/nfb_ethdev.c | 14 +++

[PATCH v2 0/5] net/nfb: add missing libfdt dependency for build

From: Martin Spinler This series introduces standard RX timestamp offload flag support together with multiple MAC addresses support for NFB devices. Also fixes a promisc/multicast switch issue and minor annoyances. --- v2: * Removed libfdt dependency patch from series, is needless. * Added the

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

On 2/10/2022 5:01 PM, Gaetan Rivet wrote: The function rte_devargs_parse() previously was safe to call with non-initialized devargs structure as parameter. When adding the support for the global device syntax, this assumption was broken. Restore it by forcing memset as part of the call itself.

Re: [PATCH] net/iavf: fix segmentation offload buffer size

On 2/15/2022 12:44 PM, Ferruh Yigit wrote: On 2/15/2022 12:30 PM, Nicolau, Radu wrote: On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2eb

Re: [PATCH] net/iavf: fix segmentation offload buffer size

On 2/15/2022 12:30 PM, Nicolau, Radu wrote: On 2/15/2022 11:19 AM, Ferruh Yigit wrote: On 2/15/2022 10:47 AM, Nicolau, Radu wrote: On 2/15/2022 10:06 AM, Ferruh Yigit wrote: On 2/10/2022 1:09 PM, Radu Nicolau wrote: This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size b

[PATCH v9 50/50] acl: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/acl/rte_acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c index 4e693b2488..a61c3ba188 100644 --- a/lib/acl/rte_acl.c +++ b/lib/acl/rte_acl.c @

[PATCH v9 49/50] cryptodev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cryptodev/cryptodev_pmd.h | 4 lib/cryptodev/rte_cryptodev.c | 11 --- lib/cryptodev/rte_cryptodev.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/lib/cryptodev/cry

[PATCH v9 46/50] cmdline: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline.c| 2 -- lib/cmdline/cmdline_parse.c | 3 --- lib/cmdline/cmdline_parse_portlist.c | 3 --- lib/cmdline/cmdline_parse_string.c | 4 lib/cmdl

[PATCH v9 48/50] bbdev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bbdev/rte_bbdev.c | 4 lib/bbdev/rte_bbdev.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 7f353d4f7e..aaee7b7872 100644

[PATCH v9 47/50] bpf: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bpf/bpf.c | 4 lib/bpf/bpf_exec.c | 6 -- lib/bpf/bpf_jit_x86.c | 5 - lib/bpf/bpf_load.c | 8 lib/bpf/bpf_pkt.c | 12 lib/bpf

[PATCH v9 45/50] compressdev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/compressdev/rte_comp.c| 1 - lib/compressdev/rte_comp.h| 1 - lib/compressdev/rte_compressdev.c | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/compress

[PATCH v9 44/50] distributor: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: David Hunt --- lib/distributor/rte_distributor.c | 2 -- lib/distributor/rte_distributor_match_sse.c | 2 -- lib/distributor/rte_distributor_single.c| 2 -- 3 files change

[PATCH v9 43/50] dmadev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/dmadev/rte_dmadev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 4abe79c536..ad9e7a0975 100644 --- a/lib/dmadev/rte_dmadev.h +

[PATCH v9 42/50] efd: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/efd/rte_efd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..560cd78961 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.

[PATCH v9 41/50] eventdev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eventdev/rte_event_ring.c | 6 -- lib/eventdev/rte_event_ring.h | 2 -- lib/eventdev/rte_event_timer_adapter.c | 5 - lib/eventdev/rte_event_timer_adapter.h |

[PATCH v9 40/50] fib: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/fib/dir24_8.c | 4 lib/fib/rte_fib.c | 2 -- lib/fib/rte_fib.h | 1 - lib/fib/rte_fib6.c | 2 -- lib/fib/rte_fib6.h | 1 - lib/fib/trie.c | 5 - lib/fib/trie.h | 2 --

[PATCH v9 39/50] flow_classify: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/flow_classify/rte_flow_classify.c | 3 --- lib/flow_classify/rte_flow_classify.h | 4 lib/flow_classify/rte_flow_classify_parse.c | 1 - lib/flow_classify/rte_flow_classif

[PATCH v9 38/50] gpudev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index ce92d63257..55a087bfb6 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v9 37/50] graph: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/graph/graph_debug.c| 2 -- lib/graph/graph_ops.c | 1 - lib/graph/graph_populate.c | 2 -- lib/graph/node.c | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/grap

[PATCH v9 36/50] gro: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gro/gro_tcp4.c | 1 - lib/gro/gro_tcp4.h | 2 -- lib/gro/gro_udp4.c | 1 - lib/gro/gro_udp4.h | 2 -- lib/gro/gro_vxlan_tcp4.c | 1 - lib/gro/gro_vxlan_udp4.c | 1 -

[PATCH v9 35/50] hash: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 4 lib/hash/rte_fbk_hash.c| 6 -- lib/hash/rte_fbk_hash.h| 1 - lib/hash/rte_thash.c | 1 - lib/hash/rte_thash.h | 1 - 5 files change

[PATCH v9 34/50] ip_frag: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/rte_ip_frag_common.c | 1 - lib/ip_frag/rte_ipv4_fragmentation.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_fra

[PATCH v9 33/50] ipsec: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ipsec/esp_inb.c | 1 - lib/ipsec/esp_outb.c | 1 - lib/ipsec/ipsec_sad.c | 1 - lib/ipsec/sa.c| 3 --- lib/ipsec/sa.h| 1 - 5 files changed, 7 deletions(-) diff --git a

[PATCH v9 32/50] jobstats: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index 9b8fde5d55..af565a14ea 100644 --- a/lib/jobsta

[PATCH v9 31/50] kni: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kni/rte_kni.c | 2 -- lib/kni/rte_kni.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index fc8f0e7b5a..7971c56bb4 100644 --- a/lib/kni/rte_kn

[PATCH v9 30/50] latencystats: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/latencystats/rte_latencystats.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index ab8db7a139..8985a377

[PATCH v9 29/50] lpm: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/lpm/rte_lpm.c | 7 --- lib/lpm/rte_lpm.h | 4 lib/lpm/rte_lpm6.c | 7 --- lib/lpm/rte_lpm6.h | 1 - 4 files changed, 19 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lp

[PATCH v9 28/50] mbuf: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mbuf/rte_mbuf.c | 11 --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/rte_mbuf_dyn.h | 2 -- lib/mbuf/rte_mbuf_pool_ops.c | 1 - lib/mbuf/rte_mbuf_pool_ops.h |

  1   2   >