Re: [PATCH 5/5] eventdev: fix compilation with clang C++ builds

2022-03-11 Thread Stephen Hemminger
On Fri, 11 Mar 2022 20:05:23 + Bruce Richardson wrote: > When compiling on FreeBSD with clang and include checking enabled, > errors are emitted due to differences in how empty structs/unions are > handled in C and C++, as C++ structs cannot have zero size. > > ../lib/eventdev/rte_eventdev.h

[PATCH v3] net/mlx5: handle MPRQ incompatibility with external buffers

2022-03-11 Thread Alexander Kozyrev
Multi-Packet Rx queue uses PMD-managed buffers to store packets. These buffers are externally attached to user mbufs. This conflicts with the feature that allows using user-managed externally attached buffers in an application. Fall back to SPRQ in case external buffers mempool is configured. Add t

[Bug 945] [DPDK. 22.03-rc2] net/mlx5 - Failed to import device for fd=0; Operation Not Supported

2022-03-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=945 David Christensen (d...@linux.vnet.ibm.com) changed: What|Removed |Added Resolution|--- |FIXED St

[PATCH 2/2] doc/freebsd_gsg: update DPDK build section

2022-03-11 Thread Bruce Richardson
Some minor updates for the section on builing DPDK in the GSG: * update Python 3.7 package name to the 3.8 version * note that the pyelftools needs to be tied to the python version * drop reference to jansson library for legacy telemetry * replace special characters for (R) Signed-off-by: Bruce R

[PATCH 1/2] doc/freebsd_gsg: add driver guides to document list

2022-03-11 Thread Bruce Richardson
The document roadmap section was missing any mention of the individual drivers guides which are important for users. Add them to list. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_gsg/intro.rst | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/guides/fr

[PATCH 5/5] eventdev: fix compilation with clang C++ builds

2022-03-11 Thread Bruce Richardson
When compiling on FreeBSD with clang and include checking enabled, errors are emitted due to differences in how empty structs/unions are handled in C and C++, as C++ structs cannot have zero size. ../lib/eventdev/rte_eventdev.h:992:2: error: union has size 0 in C, non-zero size in C++ Since the

[PATCH 4/5] cryptodev: fix compilation with clang C++ builds

2022-03-11 Thread Bruce Richardson
When compiling on FreeBSD with clang and include checking enabled, errors are emitted due to differences in how empty structs/unions are handled in C and C++, as C++ structs cannot have zero size. ../lib/cryptodev/rte_crypto.h:127:2: error: union has size 0 in C, non-zero size in C++ Since the c

[PATCH 3/5] compressdev: fix missing space in header

2022-03-11 Thread Bruce Richardson
Building with clang on FreeBSD with chkincs enabled, we get the following error about a missing space: ../lib/compressdev/rte_compressdev_internal.h:25:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal] rte_log(RT

[PATCH 2/5] compressdev: separate out driver-only headers

2022-03-11 Thread Bruce Richardson
The headers rte_compressdev_pmd.h and rte_compressdev_internal.h are, as the filenames suggest, headers for building drivers using the compressdev APIs. As such they should be marked as "driver_sdk_headers" rather than just "headers" in the meson.build file. Signed-off-by: Bruce Richardson --- l

[PATCH 1/5] eal/freebsd: add missing C++ include guards

2022-03-11 Thread Bruce Richardson
Add mising 'extern "C"' to file. Fixes: 428eb983f5f7 ("eal: add OS specific header file") Signed-off-by: Bruce Richardson --- lib/eal/freebsd/include/rte_os.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/eal/freebsd/include/rte_os.h b/lib/eal/freebsd/include/rte_os.h index 9d

[PATCH 0/5] build fixes on FreeBSD

2022-03-11 Thread Bruce Richardson
This set contains a number of fixes, most of which are for build issues discovered when compiling on FreeBSD with clang. Bruce Richardson (5): eal/freebsd: add missing C++ include guards compressdev: separate out driver-only headers compressdev: fix missing space in header cryptodev: fix c

Re: UDP-GRO not working

2022-03-11 Thread Stephen Hemminger
On Thu, 10 Mar 2022 12:49:04 + Kumara Parameshwaran wrote: > Hi , > > I tried using the UDP GRO feature in DPDK recently and it did not see > working. I understand the GRO for UDP is applicable only for fragmented > packets, there is the following check in gro_udp4.c > /* > * Don't process

Re: [PATCH v1] sched: enable/disable TC OV at runtime

2022-03-11 Thread Stephen Hemminger
On Fri, 11 Mar 2022 06:24:35 + "Ajmera, Megha" wrote: > > > > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index > > > ec74bee939..1d05089d00 100644 > > > --- a/lib/sched/rte_sched.c > > > +++ b/lib/sched/rte_sched.c > > > @@ -155,6 +155,7 @@ struct rte_sched_subport { > >

[PATCH] net/af_xdp: fix shared umem fill queue reserve

2022-03-11 Thread Ciara Loftus
Commit 81fe6720f84f ("net/af_xdp: reserve fill queue before socket create") moves the fill queue reserve logic to before the creation of the socket in order to suppress kernel logs like: XSK buffer pool does not provide enough addresses to fill 2047 buffers on Rx ring 0 However, for queues that s

Re: [PATCH] app/testpmd: fix GTP header parsing in csum FWD engine

2022-03-11 Thread Singh, Aman Deep
Looks good to me. On 3/10/2022 7:50 PM, Gregory Etelson wrote: GTP header can be followed by an optional 32 bits extension. GTP notifies about the extension presence through the E, S or PN header bits. Csum GTP header parser did not check the extension bits value. The patch updates GTP header

RE: [PATCH] net/af_xdp: fix custom program loading with multiple queues

2022-03-11 Thread Loftus, Ciara
> > 10/03/2022 09:49, Loftus, Ciara: > > > When the PMD is configured to load a custom XDP program, it sets > > > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from > > > loading its default XDP program. However, when queue_count is set to > > > greater than 1, this flag is only set f

Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-11 Thread Ferruh Yigit
On 3/11/2022 7:04 AM, Liu, KevinX wrote: message moved down, please do not top post -Original Message- From: Zhang, Yuying Sent: 2022年3月3日 14:30 To: Zhang, Qi Z ; Liu, KevinX ; dev Cc: Yang, Qiming ; Yang, SteveX ; Yigit, Ferruh ; Xing, Beilei ; Li, Xiaoyun ; dpdk stable Subject: RE:

[RFC v2 2/2] example/vhost: support to clear in-flight packets for async dequeue

2022-03-11 Thread Yuan Wang
This patch allows vring_state_changed() to clear in-flight dequeue packets. Signed-off-by: Yuan Wang --- examples/vhost/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index d26e40ab73..04e7821322 100644 --- a/examples/vhost/main.c +++ b

[RFC v2 1/2] vhost: support clear in-flight packets for async dequeue

2022-03-11 Thread Yuan Wang
rte_vhost_clear_queue_thread_unsafe() supports to clear in-flight packets for async enqueue only. But after supporting async dequeue, this API should support async dequeue too. This patch also adds the thread-safe version of this API, the difference between the two API is that thread safety uses l

[RFC v2 0/2] support to clear in-flight packets for async

2022-03-11 Thread Yuan Wang
These patches support to clear in-flight packets for async dequeue and introduce thread-safe version of this function. note: The patches depend on the following patches (http://patches.dpdk.org/project/dpdk/patch/20220310065407.17145-2-xuan.d...@intel.com/) (http://patches.dpdk.org/project/dpdk/pa

Re: [PATCH] app/testpmd: fixed using strtoull with 64-bit variables

2022-03-11 Thread Singh, Aman Deep
On 3/10/2022 11:20 PM, Adham Masarwah wrote: Replaced using strtoul with strtoull when converting to 64-bit mask field. In Windows strtoul returns 32-bit values which cause an issue with show RSS reta. Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table") Cc:sta...@dpdk.org

Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-11 Thread Singh, Aman Deep
On 3/11/2022 1:42 PM, Liu, KevinX wrote: -Original Message- From: Singh, Aman Deep Sent: 2022年3月11日 16:02 To: Liu, KevinX; Zhang, Qi Z; dev; Yigit, Ferruh Cc: Yang, Qiming; Yang, SteveX ; Xing, Beilei; Li, Xiaoyun ; dpdk stable; Zhang, Yuying Subject: Re: [PATCH v2 2/2] app/testpmd: fi

[PATCH] net/vhost: fix access to freed memory

2022-03-11 Thread Yuan Wang
This patch fixes heap-use-after-free reported by ASan. It is possible for the rte_vhost_dequeue_burst() to access the vq is freed when numa_realloc() gets called in the device running state. The control plane will set the vq->access_lock to protected the vq from the data plane. Unfortunately the l

UDP-GRO not working

2022-03-11 Thread Kumara Parameshwaran
Hi , I tried using the UDP GRO feature in DPDK recently and it did not see working. I understand the GRO for UDP is applicable only for fragmented packets, there is the following check in gro_udp4.c /* * Don't process non-fragment packet. */ if (!is_ipv4_fragment(ipv4_hdr)) return -1; There lo

RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-11 Thread Liu, KevinX
> -Original Message- > From: Singh, Aman Deep > Sent: 2022年3月11日 16:02 > To: Liu, KevinX ; Zhang, Qi Z ; > dev ; Yigit, Ferruh > Cc: Yang, Qiming ; Yang, SteveX > ; Xing, Beilei ; Li, Xiaoyun > ; dpdk stable ; Zhang, Yuying > > Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksu

Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments

2022-03-11 Thread Singh, Aman Deep
Hi Kevin, On 3/11/2022 12:34 PM, Liu, KevinX wrote: Hi, Ferruh Yuying has already reviewed it days ago. If you can, I hope you can change the status as soon as possible and try to merge the code in RC4. Thank you. -Original Message- From: Zhang, Yuying Sent: 2022年3月3日 14:30 To: Zhan

Re: [PATCH] net/af_xdp: fix custom program loading with multiple queues

2022-03-11 Thread Thomas Monjalon
10/03/2022 09:49, Loftus, Ciara: > > When the PMD is configured to load a custom XDP program, it sets > > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from > > loading its default XDP program. However, when queue_count is set to > > greater than 1, this flag is only set for the first