Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.2 - ends June 8th

2022-05-11 Thread Paul Knight
OASIS members and other interested parties, OASIS and the OASIS Virtual I/O Device (VIRTIO) TC are pleased to announce that Virtual I/O Device (VIRTIO) Version 1.2 is now available for public review and comment. Specification Overview: This document describes the specifications of the 'virtio' f

Re: [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API

2022-05-11 Thread Tyler Retzlaff
On Tue, May 10, 2022 at 10:52:34PM +0100, Konstantin Ananyev wrote: > 07/05/2022 20:47, Morten Brørup пишет: > >>From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru] > >>Sent: Saturday, 7 May 2022 15.58 > >> > >>Hi Morten, > >> > From: Konstantin Ananyev [mailto:konstantin.v.anan...

RE: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-05-11 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 11 May 2022 00.02 > > (apologies for the late response, this one slipped my mind) > > Appreciate if others could weigh their opinions. > > > > > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.

Re: [PATCH 0/5] vhost: introduce per-virtqueue stats API

2022-05-11 Thread Maxime Coquelin
On 5/10/22 22:17, Maxime Coquelin wrote: This series introduces a new Vhost API that provides per-virtqueue statistics to the application. It will be generally useful, but initial motivation for this series was to be able to get to get virtqueues stats when Virtio RSS feature will be supported

Re: [PATCH] app/testpmd: perform SW IP checksum for GRO packets

2022-05-11 Thread David Marchand
On Wed, May 11, 2022 at 3:40 AM Wenwu Ma wrote: > > The GRO library doesn't re-calculate checksums for > merged packets. If users want the merged packets to > have correct IP checksums, they should select HW IP > checksum calculation for the port which the merged > packets are transmitted to. But

Re: [PATCH v2] vhost: add runtime locking check in unsafe APIs

2022-05-11 Thread David Marchand
On Wed, May 11, 2022 at 8:58 AM Maxime Coquelin wrote: > > This patch adds runtime checks in unsafe Vhost async APIs, > to ensure the access lock is taken. > > The detection won't work every time, as another thread > could take the lock, but it would help to detect misuse > of these unsafe API. >

RE: [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API

2022-05-11 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 11 May 2022 09.17 > > On Tue, May 10, 2022 at 10:52:34PM +0100, Konstantin Ananyev wrote: > > 07/05/2022 20:47, Morten Brørup пишет: > > >>From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru] > > >>Sent: Sa

Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports

2022-05-11 Thread Subendu Santra
Agreed. I will change it to uint64_t and send it for review. Thanks for your help. Regards, Subendu. On Wed, May 11, 2022 at 1:32 AM Stephen Hemminger wrote: > > On Tue, 10 May 2022 14:39:05 +0530 > Subendu Santra wrote: > > > Hi Stephen, Thomas, > > > > On a related note w.r.to commit 1dd6cff

RE: [PATCH v2] vhost: add runtime locking check in unsafe APIs

2022-05-11 Thread Hu, Jiayu
> -Original Message- > From: David Marchand > Sent: Wednesday, May 11, 2022 3:35 PM > To: Maxime Coquelin > Cc: dev ; Xia, Chenbo ; Ding, Xuan > ; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil > Subject: Re: [PATCH v2] vhost: add runtime locking check in unsafe APIs > > On Wed, May 11, 2

[PATCH v2] net/ice: fix DCF state checking mechanism

2022-05-11 Thread peng1x . zhang
From: Peng Zhang DCF state previous checking mechanism can not fully detect DCF state whether is on or not,so PMD will report uncorrect error code in some cases and mislead user.Fix DCF state checking mechanism which will mention user resource temporarily unavailable when DCF state is not on. Fi

RE: [PATCH V4] net/mlx5: support ESP SPI match and RSS hash

2022-05-11 Thread Matan Azrad
From: Raja Zidane > In packets with ESP header, The Inner IP will be encrypted, and its fields > cannot > be used for RSS hashing. So, ESP packets can be hashed only by the outer IP > layer. > So, when using RSS on ESP packets, hashing may not be efficient, because the > fields used by the hash

RE: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 9 May 2022 14.31 > > 09/05/2022 14:24, Stanisław Kardach: > > On Fri, May 6, 2022 at 11:13 AM David Marchand > > > wrote: > > > About the new "Sponsored-by" tag, it should not raise warnings in > the > > > CI if we agree on its

[PATCH v1 0/2] ICE ddp download tool

2022-05-11 Thread Steve Yang
Support dump ice PF ddp package via testpmd command line. Add command line: ddp dump Parameters: the PF Port ID dumped package profile file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd> ddp dump 0 current

[PATCH v1 1/2] net/ice: support dump ice ddp package

2022-05-11 Thread Steve Yang
Send the AQ command to acquire ice ddp package, and dump the binary to output file. Export rte dump package API (rte_pmd_ice_dump_package) for application. Signed-off-by: Steve Yang --- drivers/net/ice/ice_ddp_package.c | 418 ++ drivers/net/ice/ice_ethdev.c |

[PATCH v1 2/2] app/testpmd: support dump_pkg command for ice

2022-05-11 Thread Steve Yang
Support dump ice PF ddp package via testpmd command line. Add command line: ddp dump Parameters: the PF Port ID dumped package profile file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd> ddp dump 0 current

RE: [PATCH v2] net/iavf: fix segfaults when calling API after VF reset failed

2022-05-11 Thread Huang, Peng
> -Original Message- > From: Yiding Zhou > Sent: Wednesday, April 27, 2022 11:25 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Yang, Qiming ; Zhang, Qi Z > ; sta...@dpdk.org; Zhou, YidingX > > Subject: [PATCH v2] net/iavf: fix segfaults when calling API after VF reset > f

RE: [PATCH] app/testpmd: perform SW IP checksum for GRO packets

2022-05-11 Thread Ma, WenwuX
> -Original Message- > From: David Marchand > Sent: 2022年5月11日 15:28 > To: Ma, WenwuX > Cc: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > dev ; Hu, Jiayu ; Wang, Yinan > ; He, Xingguang > Subject: Re: [PATCH] app/testpmd: perform SW IP checksum for GRO > packets > > On Wed, May

[PATCH v1] net/ice/base: support source interface FLG of switch filter

2022-05-11 Thread Yuying Zhang
The tx/rx packets are dropped when creating drop any rule since the recipe doesn't contain direction flag matching. This patch enables the packet flag which represents the direction of source interface to slove the issue. Signed-off-by: Yuying Zhang --- drivers/net/ice/base/ice_protocol_type.h |

[PATCH] common/cnxk: add cnf10kb support

2022-05-11 Thread Harman Kalra
Support for cnf10kb soc by adding its PCI device ID Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_constants.h | 1 + drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/mempool/cnxk/cnxk_mempool.c | 2 ++ drivers/net/cnxk/cn10k_ethdev.c | 3 +++ 4 files changed, 8 insertions(+) di

Re: [PATCH 1/1] test/ring: remove excessive inlining

2022-05-11 Thread Bruce Richardson
On Tue, May 10, 2022 at 11:23:53PM +, Honnappa Nagarahalli wrote: > + Bruce, Stephen > > > > > > > Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause the > > compiled code to grow extensively when compiled with no optimization > > (-O0 or -Og). This is default in the meso

RE: [PATCH v2 0/3] doc: build on Windows

2022-05-11 Thread Varghese, Vipin
[AMD Official Use Only - General] Hi Dmitry, Thank you for allowing me to try these changes on both Linux & Windows. I was facing some hurdles in both environments. On Linux I was facing ``` Traceback (most recent call last): File "/home/amd/vipin/dpdk/test/dpdk/doc/api/generate_doxyg

[PATCH v2] app/testpmd: perform SW IP checksum for GRO/GSO packets

2022-05-11 Thread Wenwu Ma
The GRO/GSO library doesn't re-calculate checksums for merged/fragmented packets. If users want the packets to have correct IP checksums, they should select HW IP checksum calculation for the port which the packets are transmitted to. But if the port doesn't support HW IP checksum, users may perfor

Re: [PATCH v3 3/5] app/testpmd: fix port status of slave device

2022-05-11 Thread Ferruh Yigit
On 5/11/2022 3:16 AM, Min Hu (Connor) wrote: <...> @@ -609,8 +658,25 @@ eth_dev_start_mp(uint16_t port_id)   static int   eth_dev_stop_mp(uint16_t port_id)   { -    if (is_proc_primary()) -    return rte_eth_dev_stop(port_id); +    int ret; + +    if (is_proc_primary()) { +    ret = rte_

Re: [PATCH 09/11] test/ring: disable problematic tests for RISC-V

2022-05-11 Thread Stanisław Kardach
On Wed, May 11, 2022 at 1:28 AM Honnappa Nagarahalli wrote: > > > > > > > When compiling for RISC-V in debug mode the large amount of inlining in > > test_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c) leads > > to > > large loop bodies. This causes 'goto' and 'for' loop PC-rel

RE: [PATCH v1] net/mlx5: fix quit assert when no meter green action

2022-05-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Thursday, April 14, 2022 10:55 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Bing Zhao > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v1] net/mlx5: fix quit assert when no meter green action > > When

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-11 Thread Stanisław Kardach
On Wed, May 11, 2022 at 10:09 AM Morten Brørup wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, 9 May 2022 14.31 > > > > 09/05/2022 14:24, Stanisław Kardach: > > > On Fri, May 6, 2022 at 11:13 AM David Marchand > > > > > wrote: > > > > About the new "Sponsored-by

Re: [PATCH v2 0/3] doc: build on Windows

2022-05-11 Thread Dmitry Kozlyuk
Hi Vipin, 2022-05-11 09:34 (UTC+), Varghese, Vipin: > For Windows I faced > > ``` > [528/682] Generating doc/guides/html_guides with a custom command > FAILED: doc/guides/html > "C:\Program Files\Meson\meson.exe" "runpython" > "../buildtools/call-sphinx-build.py" > "C:/Users/Administrator/A

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-11 Thread Thomas Monjalon
11/05/2022 12:28, Stanisław Kardach: > On Wed, May 11, 2022 at 10:09 AM Morten Brørup > wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 09/05/2022 14:24, Stanisław Kardach: > > > > On Fri, May 6, 2022 at 11:13 AM David Marchand wrote: > > > > > About the new "Sponsored-by" t

[PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni()

2022-05-11 Thread mingli.yu
From: Mingli Yu The netif_rx_ni is removed in below commit after kernel upgraded to 5.18, so change accordingly to fix the gap. 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni(). Signed-off-by: Mingli Yu --- kernel/linux/kni/kni_net.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH 1/1] examples/l3fwd: fix scalar LPM compilation

2022-05-11 Thread David Marchand
Hello Stanislaw, On Tue, May 10, 2022 at 1:59 PM Stanislaw Kardach wrote: > > The lpm_process_event_pkt() can either process a packet using an > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) > path or a scalar one. The choice is however done using an ifdef > pre-processo

RE: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Wednesday, May 11, 2022 2:57 AM > To: Yang, Qiming ; Wu, Wenjun1 > ; Zhao1, Wei ; Xiao Zhang > ; Xiaolong Ye ; Lunyuan Cui > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate >

RE: [PATCH v1] net/iavf: fix resource leak issue

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Tuesday, May 10, 2022 8:54 AM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: Wu, Wenjun1 > Subject: [PATCH v1] net/iavf: fix resource leak issue > > This patch fixes resource leak issue reported by coverity. > >

Re: [PATCH 1/1] test/hash: report non HTM numbers for single r/w

2022-05-11 Thread David Marchand
On Wed, May 11, 2022 at 12:10 AM Wang, Yipeng1 wrote: > > From: Stanislaw Kardach > > > > In hash_readwrite_perf_autotest a single read and write operation is > > benchmarked for both HTM and non HTM cases. However the result > > summary only shows the HTM value. Therefore add the non HTM value f

Re: [PATCH v2 0/2] Enable ASan in GHA

2022-05-11 Thread David Marchand
On Thu, May 5, 2022 at 11:30 AM David Marchand wrote: > > Now that rte_malloc instrumentations are fixed, we can enable ASan in > GHA. > There are still some unit tests (relying on multiprocess) that can't > reliably run with ASan enabled. Those unit tests are skipped. > > -- > David Marchand > >

[PATCH v2 0/2] add partial SGL support to AESNI_MB

2022-05-11 Thread Ciara Power
This patchset adds SGL support for GCM and CHACHA20-POLY1305 algorithms, using the IPSec-MB JOB API. Supported SGL types: - INPLACE SGL - OOP SGL IN, LB OUT - OOP SGL IN, SGL OUT The SGL Feature Flags for AESNI_MB PMD are not added, as it does not yet support SGL for all other algorithms. ---

[PATCH v2 1/2] crypto/ipsec_mb: add GCM SGL support to aesni-mb

2022-05-11 Thread Ciara Power
Add SGL support for GCM algorithm through JOB API. This change supports IN-PLACE SGL, OOP SGL IN and LB OUT, and OOP SGL IN and SGL OUT. Feature flags are not added, as the PMD does not yet support SGL for all other algorithms. If an SGL op for an unsupported algorithm is being processed, a NULL

[PATCH v2 2/2] crypto/ipsec_mb: add chachapoly SGL support to aesni-mb

2022-05-11 Thread Ciara Power
Add SGL support for chacha20_poly1305 algorithm through JOB API. Supports IN-PLACE SGL, OOP SGL IN and LB OUT, and OOP SGL IN and SGL OUT. Feature flags not added, as the PMD does not support SGL for all other algorithms. Signed-off-by: Ciara Power --- v2: - Chacha context was moved to qp_da

RE: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb

2022-05-11 Thread Power, Ciara
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Sunday 8 May 2022 15:40 > To: Power, Ciara ; dev@dpdk.org > Cc: Zhang, Roy Fan ; Ji, Kai > Subject: RE: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb > > Hi Ciara, > > > > -Original Message- >

Re: Softnic test failed + questions

2022-05-11 Thread Maxime Ramiara
EDIT : The tutorial that I followed to test SoftNIC ( https://doc.dpdk.org/guides-19.02/nics/softnic.html) is appropriate for DPDK 19.02 but not for the newer versions like 19.11.12, the one I use. We found out something : " sudo ./dpdk-testpmd --vdev 'net_softnic0,firmware=./firmware.cli,cpu_id=0

[PATCH] test/crypto: add null check for ZUC authentication op

2022-05-11 Thread Ciara Power
Check if the returned op is NULL because of failure, before using it and causing a segmentation fault. Fixes: 4c99481 ("app/test: add ZUC") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 d

[PATCH] sched: enable CMAN at runtime

2022-05-11 Thread Marcin Danilewicz
Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Signed-off-by: Marcin Danilewicz --- config/rte_config.h | 3 - drivers/net/softnic/rte_eth_so

RE: [PATCH 1/5] vhost: add per-virtqueue statistics support

2022-05-11 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 11, 2022 4:17 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; i.maxim...@ovn.org > Cc: Maxime Coquelin > Subject: [PATCH 1/5] vhost: add per-virtqueue statistics support > > This patch introduces new AP

RE: [PATCH 4/5] vhost: add statistics for IOTLB

2022-05-11 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 11, 2022 4:17 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; i.maxim...@ovn.org > Cc: Maxime Coquelin > Subject: [PATCH 4/5] vhost: add statistics for IOTLB > > This patch adds statistics for IOTLB hit

RE: [PATCH 5/5] vhost: add statistics for in-flight packets

2022-05-11 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 11, 2022 4:17 AM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; i.maxim...@ovn.org > Cc: Maxime Coquelin > Subject: [PATCH 5/5] vhost: add statistics for in-flight packets > > This patch adds statistics f

RE: [PATCH v2] vhost: add runtime locking check in unsafe APIs

2022-05-11 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 11, 2022 2:59 PM > To: dev@dpdk.org; Xia, Chenbo ; Ding, Xuan > ; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2] vhost: add runtime locking check in un

[PATCH] net/mlx5: fix build with clang 14

2022-05-11 Thread Ali Alnubani
Use fgets instead of fscanf to resolve the following warning reported by clang 14.0.0 in Fedora 37 (Rawhide): drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error: 'fscanf' may overflow; destination buffer in argument 3 has size 16, but the corresponding specifier may require size 17 [-Wer

Re: [PATCH] net/mlx5: fix build with clang 14

2022-05-11 Thread David Marchand
On Wed, May 11, 2022 at 3:59 PM Ali Alnubani wrote: > > Use fgets instead of fscanf to resolve the following warning > reported by clang 14.0.0 in Fedora 37 (Rawhide): > > drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error: > 'fscanf' may overflow; destination buffer in argument 3 has size 1

Re: [PATCH v3 0/5] bugfix for bonding

2022-05-11 Thread Ferruh Yigit
On 5/3/2022 11:02 AM, Min Hu (Connor) wrote: Fix some bonding related bug for bonding PMD and testpmd. Huisong Li (4): net/bonding: fix non-active slaves aren't stopped net/bonding: fix non-terminable while loop app/testpmd: fix port status of slave device app/testpmd: fix slave devi

Re: [PATCH 1/1] examples/l3fwd: fix scalar LPM compilation

2022-05-11 Thread Stanisław Kardach
On Wed, May 11, 2022 at 1:39 PM David Marchand wrote: > Based on the vector specific implemtations of process_packet in this > example, this code could be replaced with a call to rfc1812_process(). > Eth macs updates can be moved prior to rfc1812_process. > > What do you think of (untested): That

Re: [PATCH v8 2/2] hash: unify crc32 selection for x86 and Arm

2022-05-11 Thread David Marchand
On Wed, May 4, 2022 at 4:53 AM Wang, Yipeng1 wrote: > > static inline void > > rte_hash_crc_set_alg(uint8_t alg) > > { > > + crc32_alg = CRC32_SW; > > > > + if (alg == CRC32_SW) > > + return; > > > > + if (!(alg & CRC32_SSE42_x64)) > > + RTE_LOG(WARNING, HASH

RE: [PATCH v7 03/18] vhost: add vhost msg support

2022-05-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 03/18] vhost: add vhost msg support Title better be: vhost: add vhost msg support for get/

RE: [PATCH] test/crypto: add null check for ZUC authentication op

2022-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Power, Ciara > Sent: Wednesday, May 11, 2022 2:29 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Ji, Kai ; > Power, Ciara ; De Lara Guarch, Pablo > ; sta...@dpdk.org; Akhil Goyal > > Subject: [PATCH] test/crypto: add null check for ZUC authentication op > >

RE: Does ACL support field size of 8 bytes?

2022-05-11 Thread Ido Goshen
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, 26 April 2022 20:57 > To: Ido Goshen ; us...@dpdk.org; > dev@dpdk.org > Cc: Konstantin Ananyev > Subject: RE: Does ACL support field size of 8 bytes? > > > Hi Ido, > > > I've lots of good experience with ACL but can't

RE: [PATCH v2] net/ice/base: enable FDIR support for IPV6_NETX_PROTO

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Jie1X > Sent: Saturday, May 7, 2022 5:14 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; Yang, Qiming > ; Zhang, Qi Z ; Wang, Jie1X > > Subject: [PATCH v2] net/ice/base: enable FDIR support for IPV6_NETX_PROTO > > To support the new DDP and be compatible

RE: [PATCH v7 05/18] vdpa/ifc: add vDPA interrupt for blk device

2022-05-11 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 05/18] vdpa/ifc: add vDPA interrupt for blk device > > For the block device type, we use o

Re: [PATCH 1/1] test/ring: remove excessive inlining

2022-05-11 Thread Stanisław Kardach
On Wed, May 11, 2022 at 1:24 AM Honnappa Nagarahalli wrote: > Is there a bug report created for this? Is it possible to add a link to the > bug report? I have found a bug for a similar issue (with "if" conditional): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93062 I'll add it in v2.

Re: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices

2022-05-11 Thread Thomas Monjalon
11/05/2022 13:43, Zhang, Qi Z: > From: Jeff Daly > > > > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the SFP > > cage on these cards) is not asserted to avoid incorrectly reporting link up > > when > > the SFP's laser is turned off. > > > > ff8162cb957 limited this worka

Re: [PATCH v1] net/iavf: fix resource leak issue

2022-05-11 Thread Thomas Monjalon
11/05/2022 13:46, Zhang, Qi Z: > From: Wu, Wenjun1 > > > > This patch fixes resource leak issue reported by coverity. > > > > Coverity issue: 378017 > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration") > > > > Signed-off-by: Wenjun Wu > > Acked-by: Qi Zhang > > Applied to

Re: [PATCH v2] net/ice/base: enable FDIR support for IPV6_NETX_PROTO

2022-05-11 Thread Thomas Monjalon
11/05/2022 16:31, Zhang, Qi Z: > From: Wang, Jie1X > > > > To support the new DDP and be compatible with the old version DDP file, API > > function 'check_ddp_support_proto_id' is added to detect if the required > > protocol ID is supported by the current DDP file. > > > > Add new protocol ID IP

[PATCH v2 1/1] examples/l3fwd: fix scalar LPM compilation

2022-05-11 Thread Stanislaw Kardach
The lpm_process_event_pkt() can either process a packet using an architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) path or a scalar one. The choice is however done using an ifdef pre-processor macro. Because of that the scalar version was apparently not widely excersized/compi

RE: [PATCH v2] net/ice/base: enable FDIR support for IPV6_NETX_PROTO

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 11, 2022 10:55 PM > To: Wang, Jie1X ; Zhang, Qi Z > Cc: dev@dpdk.org; Yang, SteveX ; Yang, Qiming > > Subject: Re: [PATCH v2] net/ice/base: enable FDIR support for > IPV6_NETX_PROTO > > 11/05/2022 16:31, Zhang, Qi Z:

[PATCH v2 1/1] test/ring: remove excessive inlining

2022-05-11 Thread Stanislaw Kardach
Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause the compiled code to grow extensively when compiled with no optimization (-O0 or -Og). This is default in the meson's debug configuration. This can collide with compiler bugs and cause issues during linking of unit tests where th

RE: [PATCH v1] net/iavf: fix resource leak issue

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 11, 2022 10:52 PM > To: Wu, Wenjun1 ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > 11/05/2022 13:46, Zhang, Qi Z: > > From: Wu, Wenjun1

RE: [PATCH v2 0/2] add partial SGL support to AESNI_MB

2022-05-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Power, Ciara > Sent: Wednesday, May 11, 2022 1:31 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Ji, Kai ; De > Lara Guarch, Pablo ; Power, Ciara > > Subject: [PATCH v2 0/2] add partial SGL support to AESNI_MB > > This patchset adds SGL support for GCM and C

Re: [PATCH v2 1/1] test/ring: remove excessive inlining

2022-05-11 Thread Bruce Richardson
On Wed, May 11, 2022 at 05:07:25PM +0200, Stanislaw Kardach wrote: > Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause > the compiled code to grow extensively when compiled with no optimization > (-O0 or -Og). This is default in the meson's debug configuration. This > can collid

Re: [PATCH] libpcapng: fix timestamp wrapping in output files

2022-05-11 Thread Stephen Hemminger
On Sat, 7 May 2022 17:12:36 +0100 Quentin Armitage wrote: > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > seconds after pcap_init is called when using a TSC with a frequency > of 2.5GHz. > > To avoid the overflow, reread the time and TSC once > delta * NSEC_PER_SEC > (1 <<

[PATCH 1/1] test/pmd_perf: handling of unknown connection speed

2022-05-11 Thread Heinrich Schuchardt
When running DPDK in QEMU it cannot determine the connection speed. pmd_perf_autotest treats this as if the connection speed where UNIT32_MAX Mbps: RTE>>pmd_perf_autotest Start PMD RXTX cycles cost test. Allocated mbuf pool on socket 0 CONFIG RXD=1024 TXD=1024 Performance test

[PATCH v2] net/mlx5: fix build with clang 14

2022-05-11 Thread Ali Alnubani
Use fgets instead of fscanf to resolve the following warning reported by clang 14.0.0 in Fedora 37 (Rawhide): drivers/net/mlx5/linux/mlx5_ethdev_os.c:1137:52: error: 'fscanf' may overflow; destination buffer in argument 3 has size 16, but the corresponding specifier may require size 17 [-Wer

Re: [PATCH] libpcapng: fix timestamp wrapping in output files

2022-05-11 Thread Stephen Hemminger
On Sat, 7 May 2022 17:12:36 +0100 Quentin Armitage wrote: > In pcap_tsc_to_ns(), delta * NSEC_PER_SEC will overflow approx 8 > seconds after pcap_init is called when using a TSC with a frequency > of 2.5GHz. > > To avoid the overflow, reread the time and TSC once > delta * NSEC_PER_SEC > (1 <<

RE: [PATCH v2 1/1] test/ring: remove excessive inlining

2022-05-11 Thread Honnappa Nagarahalli
> > Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause the > compiled code to grow extensively when compiled with no optimization > (-O0 or -Og). This is default in the meson's debug configuration. This can > collide > with compiler bugs and cause issues during linking of unit

RE: [PATCH 1/1] examples/ipsec-secgw: create lookaside sessions at init

2022-05-11 Thread Akhil Goyal
> Subject: [PATCH 1/1] examples/ipsec-secgw: create lookaside sessions at init > > In event lookaside mode same session could be handled with multiple > cores, and session creation in datapath will cause situation where > multiple cores will try to create same session simultaneously. > To avoid su

RE: [PATCH v4 1/7] examples/ipsec-secgw: move fast path helper functions

2022-05-11 Thread Akhil Goyal
> Subject: [PATCH v4 1/7] examples/ipsec-secgw: move fast path helper functions > > Move fast path helper functions to header file for easy access. > > Signed-off-by: Nithin Dabilpuram > Acked-by: Akhil Goyal > --- > v4: > - Fix NULL pointer access in patch 7/7's inline protocol single sa worke

RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory access

2022-05-11 Thread Akhil Goyal
> > rte_flow_validate and rte_flow_create not always initialize flow error. > > Using error.message in some error cases will cause read from uninitialized > > memory. > > > > Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow director") > > > > Signed-off-by: Volodymyr Fialko > > --- > > e

RE: [PATCH] examples/ipsec-secgw: destroy lookaside sessions

2022-05-11 Thread Akhil Goyal
> > Lookaside mode also creates security and crypto sessions that needs to > be destroyed after they are no longer used. > > Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory access

2022-05-11 Thread Akhil Goyal
> -Original Message- > From: Akhil Goyal > Sent: Thursday, May 12, 2022 1:06 AM > To: Anoob Joseph ; Volodymyr Fialko > ; dev@dpdk.org; Radu Nicolau > > Cc: Jerin Jacob Kollanukkaran ; Volodymyr Fialko > > Subject: RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory > acce

RE: [PATCH] examples/ipsec-secgw: fix promiscuous mode option

2022-05-11 Thread Akhil Goyal
> > Currently default value of promiscuous mode flag is true and > > even there is command line argument to set it to true. > > So it never is in non-promiscuous mode. Fix it by > > changing default value to false. > > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")

RE: [EXT] [PATCH] crypto/mlx5: support plaintext keys

2022-05-11 Thread Akhil Goyal
> Using crypto devs requires the user to log in and the supplied DEK to be > encrypted with a KEK (keys encryption key). > KEK is burned once on the nic, along with credentials for users, > and for a user to log in, he is needed to supply his creds wrapped with > the KEK. > A device comes out of th

RE: [PATCH v2 1/1] crypto/cnxk: enable 3des-cbc secure capability

2022-05-11 Thread Akhil Goyal
> Subject: [PATCH v2 1/1] crypto/cnxk: enable 3des-cbc secure capability > > Patch enables 3DES-CBC secure capability of crypto device. > > Signed-off-by: Vamsi Attunuru > Acked-by: Akhil Goyal Applied to dpdk-next-crypto

RE: [PATCH] test/crypto: add null check for ZUC authentication op

2022-05-11 Thread Akhil Goyal
> > Subject: [PATCH] test/crypto: add null check for ZUC authentication op > > > > Check if the returned op is NULL because of failure, before using it and > > causing > a > > segmentation fault. > > > > Fixes: 4c99481 ("app/test: add ZUC") > > Cc: pablo.de.lara.gua...@intel.com > > Cc: sta...@dpd

RE: rte_bus_probe() does not exit on error

2022-05-11 Thread McDaniel, Timothy
Thanks for the reply, Thomas. For us, our request is to terminate if a command line syntax error is detected. I understand that this would break backward compatibility, so perhaps we can look at addressing the issue at the next appropriate release. Thanks, Tim > -Original Message- >

Re: [PATCH v1] net/iavf: fix resource leak issue

2022-05-11 Thread Thomas Monjalon
11/05/2022 17:31, Zhang, Qi Z: > From: Thomas Monjalon > > 11/05/2022 13:46, Zhang, Qi Z: > > > From: Wu, Wenjun1 > > > > > > > > This patch fixes resource leak issue reported by coverity. > > > > > > > > Coverity issue: 378017 > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configura

Re: [PATCH v4] app/testpmd: fix port status of slave device

2022-05-11 Thread Konstantin Ananyev
From: Huisong Li Starting or stopping a bonded port also starts or stops all active slaves under the bonded port. If this port is a bonded device, we need to modify the port status of all slaves. Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in bonding") Cc: sta...@dpdk.org

Re: [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API

2022-05-11 Thread Konstantin Ananyev
11/05/2022 08:17, Tyler Retzlaff пишет: On Tue, May 10, 2022 at 10:52:34PM +0100, Konstantin Ananyev wrote: 07/05/2022 20:47, Morten Brørup пишет: From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru] Sent: Saturday, 7 May 2022 15.58 Hi Morten, From: Konstantin Ananyev [mailto:kon

Re: [PATCH v1 2/5] net/i40e: enable direct rearm mode

2022-05-11 Thread Konstantin Ananyev
For i40e driver, enable direct re-arm mode. This patch supports the case of mapping Rx/Tx queues from the same single lcore. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- drivers/net/i40e/i40e_rxtx.h

Re: [PATCH v1 4/5] net/i40e: add direct rearm mode internal API

2022-05-11 Thread Konstantin Ananyev
20/04/2022 09:16, Feifei Wang пишет: For direct rearm mode, add two internal functions. One is to enable direct rearm mode in Rx queue. The other is to map Tx queue with Rx queue to make Rx queue take buffers from the specific Tx queue. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei

Re: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-05-11 Thread Konstantin Ananyev
20/04/2022 09:16, Feifei Wang пишет: Enable direct rearm mode. The mapping is decided in the data plane based on the first packet received. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd_lpm

Re: [PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-05-11 Thread Konstantin Ananyev
Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The receive side allocates 32 buffers and stores them in the receive sid

RE: [PATCH v1] net/iavf: fix resource leak issue

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, May 12, 2022 5:17 AM > To: Wu, Wenjun1 ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > 11/05/2022 17:31, Zhang, Qi Z: > > From: Thomas Monjal

[PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets

2022-05-11 Thread Wenwu Ma
The GRO/GSO library doesn't re-calculate checksums for merged/fragmented packets. If users want the packets to have correct IP checksums, they should select HW IP checksum calculation for the port which the packets are transmitted to. But if the port doesn't support HW IP checksum, users may perfor

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-05-11 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Wednesday, April 13, 2022 1:42 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Stephen Douthit ; Wang, > Haiyue > Subject: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug > > Currently the ixgbe driver does not ID any SFP

RE: [PATCH v3] app/testpmd: perform SW IP checksum for GRO/GSO packets

2022-05-11 Thread Hu, Jiayu
> -Original Message- > From: Ma, WenwuX > Sent: Thursday, May 12, 2022 9:08 AM > To: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; > He, Xingguang ; Ma, WenwuX > ; sta...@dpdk.org > Subject: [PATCH v3] app/testpmd: perform SW IP checksu

[PATCH v2 0/2] ICE ddp download tool

2022-05-11 Thread Steve Yang
Support dump ice PF ddp package via testpmd command line. Add command line: ddp dump Parameters: the PF Port ID dumped package profile file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd> ddp dump 0 current

[PATCH v2 1/2] net/ice: support dump ice ddp package

2022-05-11 Thread Steve Yang
Send the AQ command to acquire ice ddp package, and dump the binary to output file. Export rte dump package API (rte_pmd_ice_dump_package) for application. Signed-off-by: Steve Yang --- drivers/net/ice/ice_ddp_package.c | 418 ++ drivers/net/ice/ice_ethdev.c |

[PATCH v2 2/2] app/testpmd: support dump_pkg command for ice

2022-05-11 Thread Steve Yang
Support dump ice PF ddp package via testpmd command line. Add command line: ddp dump Parameters: the PF Port ID dumped package profile file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd> ddp dump 0 current

[PATCH v5] fix mbuf release function point corrupt in multi-process

2022-05-11 Thread Ke Zhang
In the multiple process environment, the subprocess operates on the shared memory and changes the function pointer of the main process, resulting in the failure to find the address of the function when main process releasing, resulting in crash. Signed-off-by: Ke Zhang --- drivers/net/iavf/iavf_

[PATCH v3] net/iavf: fix segfaults when calling API after VF reset failed

2022-05-11 Thread Yiding Zhou
Some pointers will be set to NULL when iavf_dev_reset() failed, for example vf->vf_res, vf->vsi_res vf->rss_key and etc. APIs access these NULL pointers will trigger segfault. This patch adds closed flag to indicate that the VF is closed, and rejects API calls in this state to avoid coredump. Fix

RE: [PATCH v7 05/18] vdpa/ifc: add vDPA interrupt for blk device

2022-05-11 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. Sure, I will use your commit log suggestion, and I will also change subject to "vdpa/ifc: add vDPA interrupt relay for blk device" > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, May 11, 2022 10:36 PM > To: Pei, Andy ; dev@dpdk.org > Cc: max

RE: [PATCH v7 03/18] vhost: add vhost msg support

2022-05-11 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, May 11, 2022 10:24 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 03/18] vhost: add vhost msg support > > > -Orig

[PATCH v5] fix mbuf release function point corrupt in multi-process

2022-05-11 Thread Ke Zhang
In the multiple process environment, the subprocess operates on the shared memory and changes the function pointer of the main process, resulting in the failure to find the address of the function when main process releasing, resulting in crash. Signed-off-by: Ke Zhang --- drivers/net/iavf/iavf_