Re: [PATCH v3 1/8] eal: add initial support for RISC-V architecture

2022-05-12 Thread Heinrich Schuchardt
On 5/10/22 17:48, Stanislaw Kardach wrote: From: Michal Mazurek Add all necessary elements for DPDK to compile and run EAL on SiFive Freedom U740 SoC which is based on SiFive U74-MC (ISA: rv64imafdc) core complex. This includes: - EAL library implementation for rv64imafdc ISA. - meson buil

Re: [PATCH v6] eal: add seqlock

2022-05-12 Thread Mattias Rönnblom
On 2022-05-09 05:48, Stephen Hemminger wrote: On Sun, 8 May 2022 21:40:58 +0200 Mattias Rönnblom wrote: I think would be good to have the sequence count (read side only) like the kernel and sequence lock (sequence count + spinlock) as separate things. That way the application could use sequen

RE: [PATCH v2] net/i40e: fix max frame size config at port level

2022-05-12 Thread Zhang, Yuying
Hi Wenxuan, > -Original Message- > From: Wu, WenxuanX > Sent: Wednesday, May 11, 2022 12:05 PM > To: Xing, Beilei ; Zhang, Yuying > ; dev@dpdk.org > Cc: Wu, WenxuanX ; Zhou, YidingX > ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix max frame size config at port level > > From: Wenx

RE: [PATCH v7 07/18] vhost: add API to get vDPA device type

2022-05-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. My reply is inline. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:14 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 07/18] vhost: add API to get vDPA

[PATCH v1] app/testpmd: fix metering and policing command for rfc4115

2022-05-12 Thread Shun Hao
Add CLI command support for metering and policing of trtcm_rfc4115. Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing") Cc: sta...@dpdk.org Signed-off-by: Shun Hao Acked-by: Matan Azard --- app/test-pmd/cmdline.c | 1 + 1 file changed, 1 insertion(+) diff --git a/a

RE: [PATCH v6 5/5] examples/vhost: support async dequeue data path

2022-05-12 Thread Ding, Xuan
> -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 11:27 AM > To: Ding, Xuan ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > lian...@liangbit.com; Ma, WenwuX ; Wang, > YuanX > Subject: RE: [PATCH v6 5/5] examples/vhost:

RE: [PATCH v7 06/18] vdpa/ifc: add block device SW live-migration

2022-05-12 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. Your suggestion is good. I will fix in next version. > -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 8:55 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 0

RE: [PATCH v6 5/5] examples/vhost: support async dequeue data path

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Friday, May 13, 2022 10:51 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > lian...@liangbit.com; Ding, Xuan ; Ma, WenwuX > ; Wang, YuanX > Subject: [PATCH v6 5/5] examples/

RE: [PATCH v7 18/18] vhost: make sure each queue callfd is configured

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 18/18] vhost: make sure each queue callfd is configured > > During the vhost data path bui

RE: [PATCH v7 17/18] vdpa/ifc: blk device pause without no inflight IO

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 17/18] vdpa/ifc: blk device pause without no inflight > IO > > When virtio blk device is p

RE: [PATCH v7 16/18] vdpa/ifc/base: access correct register for blk device

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 16/18] vdpa/ifc/base: access correct register for blk > device > > 1.last_avail_idx is low

[PATCH v6 5/5] examples/vhost: support async dequeue data path

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch adds the use case for async dequeue API. Vswitch can leverage DMA device to accelerate vhost async dequeue path. Signed-off-by: Wenwu Ma Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- doc/guides/sample_ap

[PATCH v6 4/5] vhost: support async dequeue for split ring

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, a new API rte_vhost_async_try_dequeue_burst() is introduced. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.r

[PATCH v6 3/5] vhost: merge sync and async descriptor to mbuf filling

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch refactors copy_desc_to_mbuf() used by the sync path to support both sync and async descriptor to mbuf filling. Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c | 48 ++

RE: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct > > Add is_blk flag to ifcvf_hw, and i

[PATCH v6 2/5] vhost: prepare async for descriptor to mbuf refactoring

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch refactors vhost async enqueue path and dequeue path to use the same function async_fill_seg() for preparing batch elements, which simplifies the code without performance degradation. Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- l

[PATCH v6 1/5] vhost: prepare sync for descriptor to mbuf refactoring

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch extracts the descriptors to buffers filling from copy_desc_to_mbuf() into a dedicated function. Besides, enqueue and dequeue path are refactored to use the same function sync_fill_seg() for preparing batch elements, which simplifies the code without performance degradat

[PATCH v6 0/5] vhost: support async dequeue data path

2022-05-12 Thread xuan . ding
From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch set implements vhost async dequeue data path for split ring. The code is based on latest enqueue changes [1]. This p

RE: [PATCH v7 14/18] vdpa/ifc: add interrupt and handle for virtio blk

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 14/18] vdpa/ifc: add interrupt and handle for virtio > blk Better be: vdpa/ifc: add interr

RE: [PATCH v5 4/5] vhost: support async dequeue for split ring

2022-05-12 Thread Ding, Xuan
> -Original Message- > From: Stephen Hemminger > Sent: Friday, May 13, 2022 10:24 AM > To: Ding, Xuan > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > lian...@liangbit.com; Wang, YuanX > Subject: Re: [PATCH v5 4/5] vhost: s

Re: [PATCH v5 4/5] vhost: support async dequeue for split ring

2022-05-12 Thread Stephen Hemminger
On Fri, 13 May 2022 02:00:21 + xuan.d...@intel.com wrote: > > +/** > + * This function tries to receive packets from the guest with offloading > + * copies to the async channel. The packets that are transfer completed > + * are returned in "pkts". The other packets that their copies are subm

[PATCH v5 5/5] examples/vhost: support async dequeue data path

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch adds the use case for async dequeue API. Vswitch can leverage DMA device to accelerate vhost async dequeue path. Signed-off-by: Wenwu Ma Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- doc/guides/sample_ap

[PATCH v5 4/5] vhost: support async dequeue for split ring

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, a new API rte_vhost_async_try_dequeue_burst() is introduced. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.r

[PATCH v5 3/5] vhost: merge sync and async descriptor to mbuf filling

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch refactors copy_desc_to_mbuf() used by the sync path to support both sync and async descriptor to mbuf filling. Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c | 48 ++

[PATCH v5 2/5] vhost: prepare async for descriptor to mbuf refactoring

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch refactors vhost async enqueue path and dequeue path to use the same function async_fill_seg() for preparing batch elements, which simplifies the code without performance degradation. Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- l

[PATCH v5 1/5] vhost: prepare sync for descriptor to mbuf refactoring

2022-05-12 Thread xuan . ding
From: Xuan Ding This patch extracts the descriptors to buffers filling from copy_desc_to_mbuf() into a dedicated function. Besides, enqueue and dequeue path are refactored to use the same function sync_fill_seg() for preparing batch elements, which simplifies the code without performance degradat

[PATCH v5 0/5] vhost: support async dequeue data path

2022-05-12 Thread xuan . ding
From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch set implements vhost async dequeue data path for split ring. The code is based on latest enqueue changes [1]. This p

Re: [PATCH v5] fix mbuf release function point corrupt in multi-process

2022-05-12 Thread Stephen Hemminger
On Fri, 13 May 2022 01:34:02 + "Zhang, Ke1X" wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, May 13, 2022 1:27 AM > > To: Zhang, Ke1X > > Cc: Li, Xiaoyun ; Wu, Jingjing > > ; > > Xing, Beilei ; dev@dpdk.org > > Subject: Re: [PATCH v5] fix mbuf release fu

RE: [PATCH v5] fix mbuf release function point corrupt in multi-process

2022-05-12 Thread Zhang, Ke1X
> -Original Message- > From: Stephen Hemminger > Sent: Friday, May 13, 2022 1:27 AM > To: Zhang, Ke1X > Cc: Li, Xiaoyun ; Wu, Jingjing ; > Xing, Beilei ; dev@dpdk.org > Subject: Re: [PATCH v5] fix mbuf release function point corrupt in multi- > process > > On Thu, 12 May 2022 05:57:19

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-12 Thread Heinrich Schuchardt
On 5/12/22 15:56, Stanisław Kardach wrote: On Thu, May 12, 2022 at 11:46 AM Heinrich Schuchardt wrote: The above failures for performance tests without a bound NIC can be reproduced on x86_64. So this is not RISC-V specific. With both ports of an Intel Corporation Ethernet Controller 10-Gi

Re: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices

2022-05-12 Thread Thomas Monjalon
12/05/2022 19:01, Jeff Daly: > From: Thomas Monjalon > > 11/05/2022 13:43, Zhang, Qi Z: > > > From: Jeff Daly > > > > > > > > 1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to > > > > the SFP cage on these cards) is not asserted to avoid incorrectly > > > > reporting link up whe

Re: [PATCH v5] fix mbuf release function point corrupt in multi-process

2022-05-12 Thread Stephen Hemminger
On Thu, 12 May 2022 05:57:19 + Ke Zhang wrote: > > -static const struct iavf_rxq_ops def_rxq_ops = { > - .release_mbufs = release_rxq_mbufs, > +static > +struct iavf_rxq_ops iavf_rxq_release_mbufs_ops[] = { > + [IAVF_REL_MBUFS_DEFAULT].release_mbufs = release_rxq_mbufs, > + [IAV

[PATCH v5 7/8] net/vmxnet3: set packet type for fragmented packet

2022-05-12 Thread Pankaj Gupta
The packet type is set even if it is a fragmented packet Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 + 1 file changed, 17 insertions(+) diff --

[PATCH v5 6/8] net/vmxnet3: advertise RETA size in device info

2022-05-12 Thread Pankaj Gupta
Currently the driver assumes that the size of the reta table is four times the number of Rx queues at multiple places. However, it sets it to four times the maximum number of queues (4 * 32 = 128) when it first initializes the device. Change the other uses to use the stored value, not the assumed d

[PATCH v5 8/8] Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")

2022-05-12 Thread Pankaj Gupta
Fix merge error in initialization for rxDataRing feature. Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/driver

[PATCH v5 5/8] net/vmxnet3: version 6

2022-05-12 Thread Pankaj Gupta
vmxnet3 version 6 supports some new features, including but not limited to: - Increased max MTU up to 9190 - Increased max number of queues, both for Rx and Tx - Removes power-of-two limitations - Extended interrupt structures, required implementation for additional number of queues Tested, usin

[PATCH v5 4/8] net/vmxnet3: report HW version on FW version get

2022-05-12 Thread Pankaj Gupta
Implement fw_version_get API for vmxnet3 Align addition order in vmxnet3_eth_dev_ops with eth_dev_ops Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 35 +

[PATCH v5 1/8] net/vmxnet3: add V5 support

2022-05-12 Thread Pankaj Gupta
Add VMXNET3 v5 support Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 +-- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 2 files changed, 7 insertions(+), 2 dele

[PATCH v5 3/8] net/vmxnet3: add Rx queue usage count utility

2022-05-12 Thread Pankaj Gupta
Count the number of entries in the Rx queue for debugging. Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2 Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +++ drivers/

[PATCH v5 2/8] net/vmxnet3: implement RETA query and RETA update

2022-05-12 Thread Pankaj Gupta
Add RETA query and RETA update support for VMXNET3 Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 67 1 file changed, 67 insertions(+) d

[PATCH v5 0/8] vmxnet3 version V5 and V6

2022-05-12 Thread Pankaj Gupta
v5: Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c User RETA instead of reta in commit message Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c v4: Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge er

RE: [PATCH] net/ixgbe: Limit SDP3 check of TX_DISABLE to appropriate devices

2022-05-12 Thread Jeff Daly
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 11, 2022 10:51 AM > To: Jeff Daly ; Zhang, Qi Z > Cc: Yang, Qiming ; Wu, Wenjun1 > ; Zhao1, Wei ; Xiao Zhang > ; Xiaolong Ye ; Lunyuan Cui > ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/ixgbe: Limit SDP3

Re: [PATCH 0/2] bugfix for testpmd

2022-05-12 Thread Ferruh Yigit
On 4/25/2022 7:52 AM, Min Hu (Connor) wrote: Hi, Ferruh, what do you think of this patch? 在 2022/4/6 16:45, Min Hu (Connor) 写道: This patch set contains two bugfixes for testpmd. Huisong Li (1):    app/testpmd: fix incorrect MTU verification Min Hu (Connor) (1):    app/testpmd: fix stats

Re: [PATCH 2/2] app/testpmd: fix incorrect MTU verification

2022-05-12 Thread Ferruh Yigit
On 4/26/2022 2:38 AM, lihuisong (C) wrote: 在 2022/4/26 0:25, Singh, Aman Deep 写道: On 4/6/2022 2:15 PM, Min Hu (Connor) wrote: From: Huisong Li The macro RTE_ETHER_MIN_LEN isn't the minimum value of MTU. But testpmd used it when execute 'port config mtu 0 xx' cmd. This patch fix it. Fixes:

RE: [PATCH] dmadev: clarify visibility of completed jobs

2022-05-12 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 12 May 2022 17.11 > > Clarify that once an operation has completed, the output of that > operation is visible to all cores. > > Signed-off-by: Bruce Richardson > --- Since I can't confirm that all hardware guarantees

Re: [PATCH v3 8/8] ci: add RISCV64 cross compilation job

2022-05-12 Thread Stanisław Kardach
On Thu, 12 May 2022, 17:47 Aaron Conole, wrote: > Stanislaw Kardach writes: > > > Checks cross-compilation using Ubuntu 20.04 x86. > > > > Signed-off-by: David Marchand > > Signed-off-by: Stanislaw Kardach > > --- > > .ci/linux-build.sh | 4 > > .github/workflows/build.yml | 11

Re: [PATCH v3 8/8] ci: add RISCV64 cross compilation job

2022-05-12 Thread Aaron Conole
Stanislaw Kardach writes: > Checks cross-compilation using Ubuntu 20.04 x86. > > Signed-off-by: David Marchand > Signed-off-by: Stanislaw Kardach > --- > .ci/linux-build.sh | 4 > .github/workflows/build.yml | 11 ++- > 2 files changed, 14 insertions(+), 1 deletion(-) S

[PATCH] dmadev: clarify visibility of completed jobs

2022-05-12 Thread Bruce Richardson
Clarify that once an operation has completed, the output of that operation is visible to all cores. Signed-off-by: Bruce Richardson --- This follows on from the discussion on-list[1]. Owing to the lack of replies stating that hardware doesn't guarantee this property, I'm taking the optimistic vi

RE: [PATCH V5] net/mlx5: support ESP SPI match and RSS hash

2022-05-12 Thread Matan Azrad
From: Raja Zidane > In packets with ESP header, The Inner IP will be encrypted, and its fields > cannot be used for RSS hashing. So, ESP packets can be hashed only by the > outer IP layer. > So, when using RSS on ESP packets, hashing may not be efficient, because > the fields used by the hash fu

Re: [PATCH v2 0/2] fix RSS bugs

2022-05-12 Thread Ferruh Yigit
On 4/6/2022 7:56 AM, Min Hu (Connor) wrote: This patch contains following patches: ethdev: fix enabling RSS behavior inconsistent net/hns3: remove unnecessary RSS switch Huisong Li (2): ethdev: fix enabling RSS behavior inconsistent net/hns3: remove unnecessary RSS switch Series applied

Re: [PATCH v2 1/2] ethdev: fix enabling RSS behavior inconsistent

2022-05-12 Thread Ferruh Yigit
On 4/6/2022 7:57 AM, Min Hu (Connor) wrote: From: Huisong Li The RTE_ETH_MQ_RX_RSS_FLAG flag is a switch to enable RSS. If the flag is not set in dev_configure, RSS will be not configured and enabled. However, RSS hash and reta can still be configured by ethdev ops to enable RSS if the flag isn'

Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-05-12 Thread Ferruh Yigit
On 3/9/2022 9:55 AM, Ori Kam wrote: Hi Lihusiong, -Original Message- From: lihuisong (C) Sent: Wednesday, March 9, 2022 10:03 AM Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior 在 2022/3/3 10:47, lihuisong (C) 写道: Hi, Ori, 在 2022/3/2 22:07, Ori Kam 写道: Hi L

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-12 Thread Stanisław Kardach
On Thu, May 12, 2022 at 11:46 AM Heinrich Schuchardt wrote: > The above failures for performance tests without a bound NIC can be > reproduced on x86_64. So this is not RISC-V specific. > > With both ports of an Intel Corporation Ethernet Controller 10-Gigabit > X540-AT2 bound to the sfio-pci dri

RE: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from hardware

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 13/18] vdpa/ifc: read virtio max queues from hardware > > Original code max_queues is set

RE: [PATCH v7 12/18] vdpa/ifc: add some log at vDPA launch before qemu connect

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 12/18] vdpa/ifc: add some log at vDPA launch before > qemu connect Title can be: vdpa/ifc

RE: [PATCH v7 11/18] vdpa/ifc: add set vring state for blk device

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 11/18] vdpa/ifc: add set vring state for blk device > > Set_vring_state op is mandatory, a

RE: [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc driver

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Xia, Chenbo > Sent: Thursday, May 12, 2022 9:22 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc > driver > > > -Original Message-

RE: [PATCH v7 09/18] examples/vdpa: add vDPA blk support in example

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 09/18] examples/vdpa: add vDPA blk support in example Better be: examples/vdpa: add virtio

RE: [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc driver

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 08/18] vdpa/ifc: add get device type ops to ifc driver > > Add get device type ops to ifc

RE: [PATCH v7 07/18] vhost: add API to get vDPA device type

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 07/18] vhost: add API to get vDPA device type > > Vhost backend of different devices have

[PATCH v6 3/3] test/threads: add unit test for thread API

2022-05-12 Thread Tyler Retzlaff
Establish unit test for testing thread api. Initial unit tests for rte_thread_{get,set}_affinity_by_id(). Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/meson.build| 2 ++ app/test/test_threads.c | 81 + 2 files chan

[PATCH v6 2/3] eal: implement functions for get/set thread affinity

2022-05-12 Thread Tyler Retzlaff
Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Windows error codes are translated to errno-style error codes. The possible return values are chosen so that we have as much semantic compatibility between platform

[PATCH v6 1/3] eal: add basic thread ID and current thread identifier API

2022-05-12 Thread Tyler Retzlaff
Provide a portable type-safe thread identifier. Provide rte_thread_self for obtaining current thread identifier. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk --- lib/eal/include/rte_thread.h | 22 ++ lib/eal/unix/rte_thread.c| 13

[PATCH v6 0/3] add eal functions for thread affinity and self

2022-05-12 Thread Tyler Retzlaff
this series provides basic dependencies for additional eal thread api additions. series includes * basic platform error number conversion. * function to get current thread identifier. * functions to get and set affinity with platform agnostic thread identifier. * minimal unit test of get and set

[PATCH v2] sched: enable CMAN at runtime

2022-05-12 Thread Marcin Danilewicz
Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Log: v2 change in rte_sched.h to avoid ABI breakage. Signed-off-by: Marcin Danilewicz --- config/rte_config.h

RE: [PATCH v7 06/18] vdpa/ifc: add block device SW live-migration

2022-05-12 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Wednesday, April 27, 2022 4:30 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v7 06/18] vdpa/ifc: add block device SW live-migration > > Add SW live-migration support to b

[PATCH v5 7/7] test-eventdev: support asym ops for crypto adapter

2022-05-12 Thread Akhil Goyal
Test eventdev app is updated to add new option for asymmetric crypto ops for event crypto adapter. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar Acked-by: Anoob Joseph --- app/test-eventdev/evt_common.h | 2 + app/test-eventdev/evt_options.c | 17 ++

[PATCH v5 6/7] test/event: add asymmetric cases for crypto adapter

2022-05-12 Thread Akhil Goyal
Test app is updated to add cases for asymmetric crypto sessions for event crypto adapter. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar Acked-by: Anoob Joseph --- app/test/test_event_crypto_adapter.c | 499 ++- 1 file changed, 493 insertion

[PATCH v5 5/7] eventdev: use new API to get event crypto metadata

2022-05-12 Thread Akhil Goyal
For getting event crypto metadata from crypto_op, the new API rte_cryptodev_get_session_event_mdata is used instead of getting userdata inside PMD. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar Acked-by: Anoob Joseph --- lib/eventdev/rte_event_crypto_adapter.c | 5

[PATCH v5 4/7] test/event: use new API to set event crypto metadata

2022-05-12 Thread Akhil Goyal
Used the new API rte_cryptodev_set_session_event_mdata to set event crypto metadata from the applications (app/test and app/test-eventdev) instead of using session userdata. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar Acked-by: Anoob Joseph --- app/test-eventdev

[PATCH v5 3/7] crypto/octeontx: use new API for event metadata

2022-05-12 Thread Akhil Goyal
For getting event crypto metadata from crypto_op, the new API rte_cryptodev_get_session_event_mdata can be used directly instead of getting userdata inside PMD. Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar Acked-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cr

[PATCH v5 2/7] crypto/cnxk: add event metadata set operation

2022-05-12 Thread Akhil Goyal
From: Volodymyr Fialko Added cryptodev operation for setting event crypto metadata for all supported sessions - sym/asym/security. Signed-off-by: Volodymyr Fialko Signed-off-by: Akhil Goyal Acked-by: Fan Zhang Acked-by: Abhinandan Gujjar Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k

[PATCH v5 1/7] cryptodev: add APIs to get/set event metadata

2022-05-12 Thread Akhil Goyal
From: Volodymyr Fialko Currently, crypto session userdata is used to set event crypto metadata from the application and the driver is dereferencing it in driver which is not correct. User data is meant to be opaque to the driver. To support this, new API is added to get and set event crypto metad

[PATCH v5 0/7] Add new cryptodev op for event metadata

2022-05-12 Thread Akhil Goyal
For using event crypto metadata, event metadata need to be set in session. For this session user data was used for symmetric crypto sessions and no support was present for asymmetric and security sessions. The use of userdata to store event metadata (which is dereferenced in PMD) is not correct as

Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection

2022-05-12 Thread Jerin Jacob
On Thu, May 12, 2022 at 1:06 PM Andrew Rybchenko wrote: > > Hi Jerin, Hi Andrew, > > On 5/1/22 17:46, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Currently, meter object supports only DSCP based on input color table, > > The patch enhance that to support VLAN based input color table

Re: [PATCH v4 3/8] net/vmxnet3: add Rx queue usage count utility

2022-05-12 Thread Andrew Rybchenko
On 5/6/22 01:00, Pankaj Gupta wrote: Count the number of entries in the Rx queue for debugging. Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2 Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens [snip] diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/dr

Re: [PATCH v4 2/8] net/vmxnet3: implement reta query and reta update

2022-05-12 Thread Andrew Rybchenko
On 5/6/22 01:00, Pankaj Gupta wrote: Add reta query and reta update support for VMXNET3 Please, use RETA in the summary and above line in description. Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens

Re: [PATCH v4 5/8] net/vmxnet3: version 6

2022-05-12 Thread Andrew Rybchenko
On 5/6/22 01:00, Pankaj Gupta wrote: vmxnet3 version 6 supports some new features, including but not limited to: - Increased max MTU up to 9190 - Increased max number of queues, both for Rx and Tx - Removes power-of-two limitations - Extended interrupt structures, required implementation for a

Re: [PATCH v3 02/10] ethdev: optimize xstats-get API's implementation

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 11:02, Chengwen Feng wrote: This patch uses eth_dev_get_xstats_basic_count() to retrieve generic statistics count. Signed-off-by: Chengwen Feng Reviewed-by: Andrew Rybchenko

Re: [PATCH v3 10/10] net/cnxk: fix telemetry possible null pointer access

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 11:02, Chengwen Feng wrote: The return value of rte_tel_data_alloc() may be null pointer, in this patch, the null check function is added. Fixes: 5ea354a1f2cc ("net/cnxk: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Reviewed-by: Andrew Rybchenko

Re: [PATCH v3 09/10] ethdev: fix possible null pointer access

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 11:02, Chengwen Feng wrote: The rte_tel_data_alloc() may return NULL, so the caller should add judgement for it. Fixes: 083b0b310b19 ("ethdev: add common stats for telemetry") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Reviewed-by: Andrew Rybchenko

Re: [PATCH v3 08/10] ethdev: support auto-filled flag when telemetry stats

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 11:02, Chengwen Feng wrote: This patch supports auto-filled queue xstats when telemetry stats. Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 14 +- 1 fi

Re: [PATCH v3 06/10] net/axgbe: adjust retval when xstats is null of get xstats

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 11:02, Chengwen Feng wrote: Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0) to retrieve the required number of elements, but currently axgbe PMD returns zero when xstats is NULL. This patch adjusts that the return value was the required number of elements when s

Re: [PATCH v3 03/10] net/hns3: adjust retval when xstats is null of get xstats

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 11:02, Chengwen Feng wrote: Many user (e.g. telemetry) invokes rte_eth_xstats_get(port_id, NULL, 0) to retrieve the required number of elements, but currently hns3 PMD returns zero when xstats is NULL. This patch adjusts that the return value was the required number of elements when st

Re: [PATCH v2 0/7] bugfix for hns3 PMD

2022-05-12 Thread Ferruh Yigit
On 5/5/2022 1:27 PM, Min Hu (Connor) wrote: This patch set contains 7 bugfix for hns3 PMD. Chengwen Feng (1): net/hns3: fix more mbufs are freed when Tx done cleanup Huisong Li (6): net/hns3: fix order of clearing imissed register in PF net/hns3: fix MAC and queues HW statistics overfl

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-12 Thread Heinrich Schuchardt
On 5/12/22 10:35, Stanisław Kardach wrote: On Thu, May 12, 2022 at 10:04 AM Heinrich Schuchardt wrote: On 5/5/22 19:29, Stanislaw Kardach wrote: This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was t

[PATCH V5] net/mlx5: support ESP SPI match and RSS hash

2022-05-12 Thread Raja Zidane
In packets with ESP header, The Inner IP will be encrypted, and its fields cannot be used for RSS hashing. So, ESP packets can be hashed only by the outer IP layer. So, when using RSS on ESP packets, hashing may not be efficient, because the fields used by the hash functions are only the Outer IPs,

[Bug 1008] Building DPDK with gcc 12.1.1 throws warnings on Fedora 36

2022-05-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1008 Bug ID: 1008 Summary: Building DPDK with gcc 12.1.1 throws warnings on Fedora 36 Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRME

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-12 Thread Stanisław Kardach
On Thu, May 12, 2022 at 10:04 AM Heinrich Schuchardt wrote: > > On 5/5/22 19:29, Stanislaw Kardach wrote: > > This patchset adds support for building and running DPDK on 64bit RISC-V > > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > > was tested on SiFive Unmatched develo

Re: [PATCH] ethdev: fix compilation issue with vtune option

2022-05-12 Thread Andrew Rybchenko
On 5/5/22 16:01, Aman Singh wrote: When VTune profile option is enabled, compilation error is seen. Bugzilla ID: 1004 Fixes: 2c1bbab7f09d ("ethdev: change vtune profiling approach") Cc: ilia.kura...@intel.com Signed-off-by: Aman Singh --- lib/ethdev/ethdev_profile.h | 1 + 1 file changed, 1

Re: [PATCH v2] tap: fix write-after-free and double free of intr_handle

2022-05-12 Thread Andrew Rybchenko
On 5/4/22 14:17, David Marchand wrote: On Tue, May 3, 2022 at 8:23 PM Quentin Armitage wrote: rte_pmd_tun/tap_probe() allocates pmd->intr_handle in eth_dev_tap_create() and it should not be freed until rte_pmd_tap_remove() is called. Inspection of tap_rx_intr_vec_set() shows that the call to

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-12 Thread Heinrich Schuchardt
On 5/5/22 19:29, Stanislaw Kardach wrote: This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with the Freedom U740 SoC running Linux (freedom-u-sdk based ke

[PATCH v5] fix mbuf release function point corrupt in multi-process

2022-05-12 Thread Ke Zhang
In the multiple process environment, the subprocess operates on the shared memory and changes the function pointer of the main process, resulting in the failure to find the address of the function when main process releasing, resulting in crash. Signed-off-by: Ke Zhang --- drivers/net/iavf/iavf_

[PATCH v2] net/ice/base: fix direction match of flow that matches any

2022-05-12 Thread Yuying Zhang
The tx/rx packets were dropped when creating drop any rule since the recipe didn't contain direction flag matching. This patch adds the packet flag which represents the direction of source interface to slove the issue. Fixes: 92317961a731 ("net/ice: support drop any and steer all to queue") Cc: st

Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection

2022-05-12 Thread Andrew Rybchenko
Hi Jerin, On 5/1/22 17:46, jer...@marvell.com wrote: From: Jerin Jacob Currently, meter object supports only DSCP based on input color table, The patch enhance that to support VLAN based input color table, color table based on inner field for the tunnel use case, and support for fallback color

RE: [PATCH v1] net/iavf: fix resource leak issue

2022-05-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, May 12, 2022 3:07 PM > To: Zhang, Qi Z > Cc: Wu, Wenjun1 ; dev@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > 12/05/2022 02:20, Zhang, Qi Z: > > > > > -Original

Re: [PATCH] app/testpmd: remove useless pointer checks

2022-05-12 Thread David Marchand
On Tue, Mar 29, 2022 at 11:26 AM Thomas Monjalon wrote: > > 24/03/2022 17:15, David Marchand: > > Parameters to this static helper can't be NULL. > > str has already been dereferenced in caller. > > dst and size point to variable in stack. > > The same function is copy/pasted in several places. >

Re: [PATCH v1] net/iavf: fix resource leak issue

2022-05-12 Thread Thomas Monjalon
12/05/2022 02:20, Zhang, Qi Z: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, May 12, 2022 5:17 AM > > To: Wu, Wenjun1 ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > > > Subject: Re: [PATCH v1] net/iavf: fix resource leak issue > > > > 11/05

Re: [PATCH] devargs: fix leak on hotplug failure

2022-05-12 Thread David Marchand
On Thu, Apr 14, 2022 at 1:28 PM David Marchand wrote: > > Caught by ASan, if a secondary process tried to attach a device with an > incorrect driver name, devargs was leaked. > > Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand