RE: [PATCH V5] net/mlx5: support ESP SPI match and RSS hash

2022-05-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Raja Zidane > Sent: Thursday, May 12, 2022 12:17 PM > To: dev@dpdk.org > Cc: Matan Azrad > Subject: [PATCH V5] net/mlx5: support ESP SPI match and RSS hash > > In packets with ESP header, The Inner IP will be encrypted, and its fields > cannot be used for

[PATCH v3 0/5] Extend and set event queue attributes at runtime

2022-05-15 Thread Shijith Thotton
This series adds support for setting event queue attributes at runtime and adds two new event queue attributes weight and affinity. Eventdev capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR is added to expose the capability to set attributes at runtime and rte_event_queue_attr_set() API is used to s

[PATCH v3 2/5] eventdev: add weight and affinity to queue attributes

2022-05-15 Thread Shijith Thotton
Extended eventdev queue QoS attributes to support weight and affinity. If queues are of the same priority, events from the queue with highest weight will be scheduled first. Affinity indicates the number of times, the subsequent schedule calls from an event port will use the same event queue. Sched

[PATCH v3 1/5] eventdev: support to set queue attributes at runtime

2022-05-15 Thread Shijith Thotton
Added a new eventdev API rte_event_queue_attr_set(), to set event queue attributes at runtime from the values set during initialization using rte_event_queue_setup(). PMD's supporting this feature should expose the capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR. Signed-off-by: Shijith Thotton Ac

[PATCH v3 3/5] test/event: test cases to test runtime queue attribute

2022-05-15 Thread Shijith Thotton
Added test cases to test changing of queue QoS attributes priority, weight and affinity at runtime. Signed-off-by: Shijith Thotton --- app/test/test_eventdev.c | 201 +++ 1 file changed, 201 insertions(+) diff --git a/app/test/test_eventdev.c b/app/test/test_

[PATCH v3 4/5] common/cnxk: use lock when accessing mbox of SSO

2022-05-15 Thread Shijith Thotton
From: Pavan Nikhilesh Since mbox is now accessed from multiple threads, use lock to synchronize access. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_sso.c | 174 + drivers/common/cnxk/roc_sso_priv.h | 1 + drivers

[PATCH v3 5/5] event/cnxk: support to set runtime queue attributes

2022-05-15 Thread Shijith Thotton
Added API to set queue attributes at runtime and API to get weight and affinity. Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/features/cnxk.ini | 1 + drivers/event/cnxk/cn10k_eventdev.c| 4 ++ drivers/event/cnxk/cn9k_eventdev.c | 4 ++ drivers/event/cnxk/cnxk_eventdev.c

[PATCH v3] doc: announce change in event queue conf structure

2022-05-15 Thread Shijith Thotton
Structure rte_event_queue_conf will be extended to include fields to support weight and affinity attribute. Once it gets added in DPDK 22.11, eventdev internal op, queue_attr_get can be removed. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 in

[PATCH] event/cnxk: flush event queues over multiple pass

2022-05-15 Thread Shijith Thotton
If an event queue flush does not complete after a fixed number of tries, remaining queues are flushed before retrying the one with incomplete flush. Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 10 +- drivers/event/cnxk/cn9k_eventdev.c | 10 +- driver

[PATCH v7] eal: add seqlock

2022-05-15 Thread Mattias Rönnblom
A sequence lock (seqlock) is a synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, suitable for data structures shared across many cores and which are updated relatively infrequently. A seqlock permits multiple parallel readers. A spinlock is used to seri

Re: [PATCH v7] eal: add seqlock

2022-05-15 Thread Mattias Rönnblom
On 2022-05-15 14:24, Mattias Rönnblom wrote: > A sequence lock (seqlock) is a synchronization primitive which allows > for data-race free, low-overhead, high-frequency reads, suitable for > data structures shared across many cores and which are updated > relatively infrequently. > > A seqlock perm

Re: [PATCH v3 1/5] eventdev: support to set queue attributes at runtime

2022-05-15 Thread Mattias Rönnblom
On 2022-05-15 11:53, Shijith Thotton wrote: > Added a new eventdev API rte_event_queue_attr_set(), to set event queue > attributes at runtime from the values set during initialization using > rte_event_queue_setup(). PMD's supporting this feature should expose the > capability RTE_EVENT_DEV_CAP_RUN

RE: [PATCH v7] eal: add seqlock

2022-05-15 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Sunday, 15 May 2022 14.40 > > Two questions remain: > > 1) Should the seqlock and the seqcount reside in different header > files? > 2) Is it it good enough to provided only a spinlock-protected seqlock? > > Question 1 I don

Recall: [PATCH v7] eal: add seqlock

2022-05-15 Thread Morten Brørup
Morten Brørup would like to recall the message, "[PATCH v7] eal: add seqlock".

RE: [PATCH v7] eal: add seqlock

2022-05-15 Thread Morten Brørup
(Resent with Konstantin's new email address.) > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Sunday, 15 May 2022 14.40 > > Two questions remain: > > 1) Should the seqlock and the seqcount reside in different header > files? > 2) Is it it good enough to provided only a sp

[PATCH] net/sfc: improve naming in flow tunnel offload support

2022-05-15 Thread Ivan Malov
Change ambiguous terms "jump rule" and "group rule" to clearer "tunnel rule" and "switch rule". The new terms reflect the purpose of these rules in virtual switches. The module name, "flow tunnel", is replaced by "FT" in function names to avoid the use of word "tunnel" twice. Use term "FT context

Re: [PATCH v7] eal: add seqlock

2022-05-15 Thread Mattias Rönnblom
On 2022-05-15 17:19, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Sunday, 15 May 2022 14.40 Two questions remain: 1) Should the seqlock and the seqcount reside in different header files? 2) Is it it good enough to provided only a spinlock-protected se

[PATCH v2 1/2] acl: fix rules with 8 bytes field size are broken

2022-05-15 Thread Konstantin Ananyev
In theory ACL library allows fields with 8B long. Though in practice they usually not used, not tested, and as was revealed by Ido, this functionality is not working properly. There are few places inside ACL build code-path that need to be addressed. Bugzilla ID: 673 Fixes: dc276b5780c2 ("acl: new

[PATCH v2 2/2] app/acl: support different formats for IPv6 address

2022-05-15 Thread Konstantin Ananyev
Within ACL rule IPv6 address can be represented in different ways: either as 4x4B fields, or as 2x8B fields. Till now, only first format was supported. Extend test-acl to support both formats, mainly for testing and demonstrating purposes. To control desired behavior '--ipv6' command-line option is

[PATCH v2 0/2] ACL fix 8B field

2022-05-15 Thread Konstantin Ananyev
Fix problem with 8B fields and extend test-acl test coverage. v2: - extend app/test-acl/test-acl.sh to support both formats for IPv6 addresses. Konstantin Ananyev (2): acl: fix rules with 8 bytes field size are broken app/acl: support different formats for IPv6 address app/test-acl/main

Re: Does ACL support field size of 8 bytes?

2022-05-15 Thread Konstantin Ananyev
11/05/2022 15:28, Ido Goshen пишет: -Original Message- From: Ananyev, Konstantin Sent: Tuesday, 26 April 2022 20:57 To: Ido Goshen ; us...@dpdk.org; dev@dpdk.org Cc: Konstantin Ananyev Subject: RE: Does ACL support field size of 8 bytes? Hi Ido, I've lots of good experience with

Re: [PATCH v6 1/3] eal: add basic thread ID and current thread identifier API

2022-05-15 Thread Konstantin Ananyev
12/05/2022 14:14, Tyler Retzlaff пишет: Provide a portable type-safe thread identifier. Provide rte_thread_self for obtaining current thread identifier. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff Acked-by: Dmitry Kozlyuk --- lib/eal/include/rte_thread.h | 22 +++

RE: [PATCH v7 12/18] vdpa/ifc: add some log at vDPA launch before qemu connect

2022-05-15 Thread Pei, Andy
Hi Stephen, Thanks for your reply. I will change to DEBUG level log in next version. > -Original Message- > From: Stephen Hemminger > Sent: Friday, May 13, 2022 11:38 PM > To: Pei, Andy > Cc: Xia, Chenbo ; dev@dpdk.org; > maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subje

[PATCH] net/iavf: fix mask not allowed issue

2022-05-15 Thread Qiming Yang
Only zero-mask and full-mask for IPv4/UDP/TCP/SCTP addr/port are supported in current code. Otherwise will return failure when parse pattern. Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/iavf/iavf_fdir.c | 150

[PATCH v7 0/5] vhost: support async dequeue data path

2022-05-15 Thread xuan . ding
From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch set implements vhost async dequeue data path for split ring. The code is based on latest enqueue changes [1]. This p

[PATCH v7 1/5] vhost: prepare sync for descriptor to mbuf refactoring

2022-05-15 Thread xuan . ding
From: Xuan Ding This patch extracts the descriptors to buffers filling from copy_desc_to_mbuf() into a dedicated function. Besides, enqueue and dequeue path are refactored to use the same function sync_fill_seg() for preparing batch elements, which simplifies the code without performance degradat

[PATCH v7 2/5] vhost: prepare async for descriptor to mbuf refactoring

2022-05-15 Thread xuan . ding
From: Xuan Ding This patch refactors vhost async enqueue path and dequeue path to use the same function async_fill_seg() for preparing batch elements, which simplifies the code without performance degradation. Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- l

[PATCH v7 3/5] vhost: merge sync and async descriptor to mbuf filling

2022-05-15 Thread xuan . ding
From: Xuan Ding This patch refactors copy_desc_to_mbuf() used by the sync path to support both sync and async descriptor to mbuf filling. Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c | 48 ++

[PATCH v7 4/5] vhost: support async dequeue for split ring

2022-05-15 Thread xuan . ding
From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, a new API rte_vhost_async_try_dequeue_burst() is introduced. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.r

[PATCH v7 5/5] examples/vhost: support async dequeue data path

2022-05-15 Thread xuan . ding
From: Xuan Ding This patch adds the use case for async dequeue API. Vswitch can leverage DMA device to accelerate vhost async dequeue path. Signed-off-by: Wenwu Ma Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding Tested-by: Yvonne Yang Reviewed-by: Maxime Coquelin --- doc/guides/sample_ap

RE: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct

2022-05-15 Thread Pei, Andy
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:55 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 15/18] vdpa/ifc: add is blk flag to ifcvf HW struct > > > -Original Messag

RE: [PATCH v3 1/5] eventdev: support to set queue attributes at runtime

2022-05-15 Thread Shijith Thotton
>> Added a new eventdev API rte_event_queue_attr_set(), to set event queue >> attributes at runtime from the values set during initialization using >> rte_event_queue_setup(). PMD's supporting this feature should expose the >> capability RTE_EVENT_DEV_CAP_RUNTIME_QUEUE_ATTR. >> >> Signed-off-by: Sh

RE: [PATCH v7 16/18] vdpa/ifc/base: access correct register for blk device

2022-05-15 Thread Pei, Andy
HI Chenbo, Thanks for your reply. I will send out a new version to fix this. > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:58 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 16/18] vdpa/

RE: [PATCH v7 17/18] vdpa/ifc: blk device pause without no inflight IO

2022-05-15 Thread Pei, Andy
Hi Chenbo, Thanks for reply. This will be addressed in next version. > -Original Message- > From: Xia, Chenbo > Sent: Friday, May 13, 2022 10:59 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng > Subject: RE: [PATCH v7 17/18] vdpa/ifc: blk

RE: [PATCH v7 4/5] vhost: support async dequeue for split ring

2022-05-15 Thread Hu, Jiayu
Hi Xuan, > -Original Message- > From: Ding, Xuan > Sent: Monday, May 16, 2022 10:43 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > lian...@liangbit.com; Ding, Xuan ; Wang, YuanX > > Subject: [PATCH v7 4/5] vhost: suppo

RE: [PATCH v7 4/5] vhost: support async dequeue for split ring

2022-05-15 Thread Ding, Xuan
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Monday, May 16, 2022 1:53 PM > To: Ding, Xuan ; maxime.coque...@redhat.com; Xia, > Chenbo > Cc: dev@dpdk.org; Jiang, Cheng1 ; Pai G, Sunil > ; lian...@liangbit.com; Wang, YuanX > > Subject: RE: [PATCH v7 4/5] vhost: support async

Re: [PATCH v6 1/3] eal: add basic thread ID and current thread identifier API

2022-05-15 Thread Tyler Retzlaff
On Sun, May 15, 2022 at 11:02:30PM +0100, Konstantin Ananyev wrote: > 12/05/2022 14:14, Tyler Retzlaff пишет: > >Provide a portable type-safe thread identifier. > >Provide rte_thread_self for obtaining current thread identifier. > > > >Signed-off-by: Narcisa Vasile > >Signed-off-by: Tyler Retzlaff

RE: [PATCH v2 1/2] acl: fix rules with 8 bytes field size are broken

2022-05-15 Thread Ido Goshen
Tested-by: Ido Goshen > -Original Message- > From: Konstantin Ananyev > Sent: Sunday, 15 May 2022 23:03 > To: dev@dpdk.org > Cc: Ido Goshen ; sta...@dpdk.org > Subject: [PATCH v2 1/2] acl: fix rules with 8 bytes field size are broken > > In theory ACL library allows fields with 8B long.

RE: Does ACL support field size of 8 bytes?

2022-05-15 Thread Ido Goshen
> -Original Message- > From: Konstantin Ananyev > Sent: Sunday, 15 May 2022 23:54 > To: Ido Goshen ; Ananyev, Konstantin > ; us...@dpdk.org; dev@dpdk.org > Subject: Re: Does ACL support field size of 8 bytes? > > > My concern was it is sort of awkward in terms of input_field value for ru

[PATCH v3] doc: update matching versions in i40e guide

2022-05-15 Thread Qiming Yang
Add recommended matching list for i40e PMD in DPDK 21.05, 21.08, 21.11 and 22.03. And add a known issue when FW upgrade to a version higher than 8.4. Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- v2: * added known issue in FW 8.4+ v3: * updated x722 FW version --- doc/guides/nics/i40e.rst

[PATCH v6] fix mbuf release function point corrupt in multi-process

2022-05-15 Thread Ke Zhang
In the multiple process environment, the subprocess operates on the shared memory and changes the function pointer of the main process, resulting in the failure to find the address of the function when main process releasing, resulting in crash. Signed-off-by: Ke Zhang --- drivers/net/iavf/iavf_