RE: [PATCH v5] gro: bug fix in identifying fragmented packets

2022-06-28 Thread Hu, Jiayu
Reviewed-by: Jiayu Hu Thanks, Jiayu > -Original Message- > From: Kumara Parameshwaran > Sent: Monday, June 27, 2022 6:31 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kumara Parameshwaran > ; sta...@dpdk.org > Subject: [PATCH v5] gro: bug fix in identifying fragmented packets > > From: Kumar

[PATCH v4] net/i40e: fix error disable double VLAN

2022-06-28 Thread Kevin Liu
Enable double VLAN by default after firmware v8.3 and disable double VLAN is not allowed in subsequent operations. Fixes: 4f13a78f1b8f ("net/i40e: add outer VLAN processing") Signed-off-by: Kevin Liu v4: fix warnig v3: refine commit log v2: update the document --- doc/guides/nics/i40e.rst

[PATCH v3] net/i40e: fix error disable double VLAN

2022-06-28 Thread Kevin Liu
Enable double VLAN by default after firmware v8.3 and disable double VLAN is not allowed in subsequent operations. Fixes: 4f13a78f1b8f ("net/i40e: add outer VLAN processing") Signed-off-by: Kevin Liu v3: refine commit log v2: update the document --- doc/guides/nics/i40e.rst | 5 ++-- dr

Re: Service core statistics MT safety

2022-06-28 Thread Mattias Rönnblom
On 2022-06-28 21:15, Honnappa Nagarahalli wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Monday, 27 June 2022 13.06 Hi. Is it safe to enable stats on MT safe services? https://protect2.fireeye.com/v1/url?k=31323334-501d5122- 313273af - 4 5444731-6096fdb1

Re: [PATCH] doc: notice to deprecate DPAA2 cmdif raw driver

2022-06-28 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 6/29/2022 10:08 AM, Gagandeep Singh wrote: dpaa2_cmdif raw driver is no longer in use, so it will be removed in v22.11 Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_

[PATCH] doc: notice to deprecate DPAA2 cmdif raw driver

2022-06-28 Thread Gagandeep Singh
dpaa2_cmdif raw driver is no longer in use, so it will be removed in v22.11 Signed-off-by: Gagandeep Singh --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 4e5b23c53d

Re: [PATCH] doc: announce support for MACsec in rte_security

2022-06-28 Thread Hemant Agrawal
On 6/29/2022 12:38 AM, Akhil Goyal wrote: MACsec support is planned for DPDK 22.11, which would result in ABI breakage in some of the rte_security structures. This patch is to give deprecation notice for the affected structures. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/deprecatio

[PATCH 2/2] net/ngbe: fix customized devices probe failure

2022-06-28 Thread Jiawen Wu
The devices with OEM subsystem vendor ID failed to be initialized, because flash was read before memory address was set. Fixes: 240422edbf84 ("net/ngbe: support OEM subsystem vendor ID") Signed-off-by: Jiawen Wu --- drivers/net/ngbe/ngbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

[PATCH 1/2] net/txgbe: fix customized devices probe failure

2022-06-28 Thread Jiawen Wu
The devices with OEM subsystem vendor ID failed to be initialized, because flash was read before memory address was set. Fixes: 138d869e41c0 ("net/txgbe: support OEM subsystem vendor ID") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 d

[PATCH v2] net/i40e: fix error disable double VLAN

2022-06-28 Thread Kevin Liu
Sync the kernel driver, enable double VLAN by default after firmware v8.3 and disable double VLAN is not allowed in subsequent operations. Fixes: 4f13a78f1b8f ("net/i40e: add outer VLAN processing") Signed-off-by: Kevin Liu v2: update the document --- doc/guides/nics/i40e.rst | 5 ++-- d

Re: dpdk-devbind.py ./. bonding interfaces

2022-06-28 Thread Stephen Hemminger
On Sat, 25 Jun 2022 01:13:01 +0200 qcqx-obaq.6cba8...@hashmail.org wrote: > To whom it may concern. > > usertools/dpdk-devbind.py currently does not recognize interfaces > that are part of a bond as active. > that can be a nuisance if you are using something like libmoon which > proactively rebi

[PATCH] net/i40e: fix error disable double VLAN

2022-06-28 Thread Kevin Liu
Sync the kernel driver, enable double VLAN by default after firmware v8.3 and disable double VLAN is not allowed in subsequent operations. Fixes: 4f13a78f1b8f ("net/i40e: add outer VLAN processing") Signed-off-by: Kevin Liu --- drivers/net/i40e/i40e_ethdev.c | 45

[PATCH v3] baseband/turbo_sw: remove Flexran SDK meson option

2022-06-28 Thread Nicolas Chautru
The related dependency to build the PMD based on the SDK libraries is now enabled through pkfconfig. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/turbo_sw.rst| 6 -- drivers/baseband/turbo_sw/meson.build | 36 +-- meson_options.txt

[PATCH v3] baseband/turbo_sw: Remove flexran_sdk meson option

2022-06-28 Thread Nicolas Chautru
v3: fix mix of space and tabs in meson files v2: typo in documentation Hi Thomas, This is change you requested earlier this year. This is targeting 22.11. Basically we no longer pass a specific option but rely on pkgconfig. There is small change to generate the .pc files that Intel will make avail

RE: [PATCH v2] baseband/turbo_sw: Remove flexran_sdk meson option

2022-06-28 Thread Chautru, Nicolas
> From: Thomas Monjalon > > 27/06/2022 22:29, Nicolas Chautru: > > Hi Thomas, > > This is change you requested earlier this year. This is targeting 22.11. > > OK thanks. > > > Basically we no longer pass a specific option but rely on pkgconfig. > > There is small change to generate the .pc file

[PATCH v2] examples/distributor: update dynamic configuration

2022-06-28 Thread Abdullah Ömer Yamaç
In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without "-c" parameter, you can run RX and Distributor on the different core. * Syntax error of th

[PATCH v2] examples/distributor: update dynamic configuration

2022-06-28 Thread Abdullah Ömer Yamaç
In this patch, * It is possible to switch the running mode of the distributor using the command line argument. * With "-c" parameter, you can run RX and Distributor on the same core. * Without "-c" parameter, you can run RX and Distributor on the different core. * Syntax error of th

RE: Service core statistics MT safety

2022-06-28 Thread Honnappa Nagarahalli
> > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Monday, 27 June 2022 13.06 > > > > Hi. > > > > Is it safe to enable stats on MT safe services? > > > > https://protect2.fireeye.com/v1/url?k=313233

[PATCH] doc: announce support for MACsec in rte_security

2022-06-28 Thread Akhil Goyal
MACsec support is planned for DPDK 22.11, which would result in ABI breakage in some of the rte_security structures. This patch is to give deprecation notice for the affected structures. Signed-off-by: Akhil Goyal --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+

Re: Service core statistics MT safety

2022-06-28 Thread Mattias Rönnblom
On 2022-06-28 17:24, Honnappa Nagarahalli wrote: > > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 27 June 2022 13.06 > > Hi. > > Is it safe to enable stats on MT safe services? > > https://

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 10:38:27AM -0700, Stephen Hemminger wrote: > On Tue, 28 Jun 2022 10:07:12 -0700 > Tyler Retzlaff wrote: > > > > > to avoid people tripping over mishandling pointers in/out of the api > > > > surface taking the opaque object you could declare opaque handle for the > > > > a

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Stephen Hemminger
On Tue, 28 Jun 2022 10:07:12 -0700 Tyler Retzlaff wrote: > > > to avoid people tripping over mishandling pointers in/out of the api > > > surface taking the opaque object you could declare opaque handle for the > > > api to operate on instead. it would force the use of a cast in the > > > impleme

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 09:29:05AM -0700, Stephen Hemminger wrote: > On Tue, 28 Jun 2022 09:22:13 -0700 > Tyler Retzlaff wrote: > > > On Tue, Jun 28, 2022 at 04:46:43PM +0200, David Marchand wrote: > > > Make rte_bus opaque for non internal users. > > > This will make extending this object possib

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Stephen Hemminger
On Tue, 28 Jun 2022 09:22:13 -0700 Tyler Retzlaff wrote: > On Tue, Jun 28, 2022 at 04:46:43PM +0200, David Marchand wrote: > > Make rte_bus opaque for non internal users. > > This will make extending this object possible without breaking the ABI. > > > > Introduce a new driver header and move rt

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 09:22:13AM -0700, Tyler Retzlaff wrote: > > e.g. make the opaque object an explicit type. > oops missed the typedef there but you probably know what i meant. typedef > struct { > uintptr_t opaque; > } rte_bus_handle_t; >

Re: [RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread Tyler Retzlaff
On Tue, Jun 28, 2022 at 04:46:43PM +0200, David Marchand wrote: > Make rte_bus opaque for non internal users. > This will make extending this object possible without breaking the ABI. > > Introduce a new driver header and move rte_bus definition and helpers. > > Signed-off-by: David Marchand > -

RE: Service core statistics MT safety

2022-06-28 Thread Honnappa Nagarahalli
> >> > >>> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >>> Sent: Monday, 27 June 2022 13.06 > >>> > >>> Hi. > >>> > >>> Is it safe to enable stats on MT safe services? > >>> > >>> https://protect2.fireeye.com/v1/url?k=31323334-501d5122- > 31

[PATCH v3 2/2] net/mlx5: add test for external Rx queue

2022-06-28 Thread Michael Baum
Add mlx5 internal test for map and unmap external RxQs. This patch adds to Testpmd app a runtime function to test the mapping API. For insert mapping use this command: testpmd> mlx5 port (port_id) ext_rxq map (sw_queue_id) (hw_queue_id) For insert mapping use this command: testpmd> mlx5 por

[PATCH v3 1/2] net/mlx5: add test for remote PD and CTX

2022-06-28 Thread Michael Baum
Add mlx5 internal option in testpmd similar to run-time function "port attach" which adds another parameter named "socket" for attaching port and add 2 devargs before. The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and

[PATCH v3 0/2] net/mlx5: external RxQ tests

2022-06-28 Thread Michael Baum
Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in Testpmd application. [1] https://patchwork.dpdk.org/project/dpdk/cover/20220224232511.3238707-1-michae...@nvidia.com/ v1: Initial commit. v2: Fix typos in documentation. Move mlx5 speci

[RFC PATCH 11/11] bus: hide bus object

2022-06-28 Thread David Marchand
Make rte_bus opaque for non internal users. This will make extending this object possible without breaking the ABI. Introduce a new driver header and move rte_bus definition and helpers. Signed-off-by: David Marchand --- app/test/test_devargs.c | 2 +- app/test/test_vdev.c

[RFC PATCH 10/11] bus: introduce accessors

2022-06-28 Thread David Marchand
Prepare for making the bus object opaque by adding one accessor. Update existing users. Signed-off-by: David Marchand --- app/test-pmd/config.c| 6 ++--- app/test-pmd/testpmd.c | 4 +-- app/test-pmd/testpmd.h | 4 +-- app/tes

[RFC PATCH 09/11] drivers/bus: hide specific structures

2022-06-28 Thread David Marchand
Now that there is no bus specific object referenced in the driver objects, we can hide rte_dpaa_bus, rte_fslmc_bus, rte_pci_bus, rte_vmbus_bus specific structures into their bus code. While at it: - move enumerators only used in the bus code itself, - remove unneeded list head structure type, - re

[RFC PATCH 08/11] drivers/bus: remove back reference to bus objects

2022-06-28 Thread David Marchand
There is no need for a back reference to a singleton object in the bus driver objects: each function is contextually aware of which bus object it should manipulate. Signed-off-by: David Marchand --- drivers/bus/auxiliary/auxiliary_common.c | 2 -- drivers/bus/auxiliary/rte_bus_auxiliary.h | 2

[RFC PATCH 07/11] bus: move IOVA definition from header

2022-06-28 Thread David Marchand
iova enum definition does not need to be defined as part of the bus API. Move it to rte_eal.h. With this step, rte_eal.h does not depend on rte_bus.h and rte_dev.h. Fix existing code that was relying on these implicit inclusions. Signed-off-by: David Marchand --- app/test-compress-perf/comp_perf

[RFC PATCH 06/11] bus: remove unneeded inclusion of bus header

2022-06-28 Thread David Marchand
Those files don't need to include rte_bus.h. Signed-off-by: David Marchand --- drivers/bus/auxiliary/linux/auxiliary.c | 1 - drivers/bus/ifpga/ifpga_common.c| 1 - drivers/bus/ifpga/rte_bus_ifpga.h | 1 - drivers/bus/vdev/vdev_params.c | 1 - drivers/bus/vmbus/linux/vmbus

[RFC PATCH 05/11] devargs: remove dependency on bus header

2022-06-28 Thread David Marchand
We don't need to include rte_bus.h. Only a forward declaration of rte_bus and an inclusion of rte_dev.h are needed. Signed-off-by: David Marchand --- app/test/test_vdev.c | 1 + lib/eal/include/rte_devargs.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/app/tes

[RFC PATCH 04/11] dev: move unrelated macros from header

2022-06-28 Thread David Marchand
RTE_FUNC_PTR_OR_* macros have nothing to do with the rte_device object and associated API. Move them to rte_common.h and include it where needed. Signed-off-by: David Marchand --- drivers/common/qat/qat_device.c| 1 + drivers/compress/qat/qat_comp_pmd.c| 1 +

[RFC PATCH 03/11] dev: hide debug messages in device iterator

2022-06-28 Thread David Marchand
For any bus that does not support device iteration, rte_dev_iterator_init both returned an error code and logged an error message. An application (like testpmd) that only wants to list devices, would have no choice but to inspect a bus object to avoid spewing error logs. Make those log messages de

[RFC PATCH 02/11] raw/ifpga: remove PCI bus accessor

2022-06-28 Thread David Marchand
There is no in-tree user for this accessor that returns the PCI bus object. On the other hand, a bus object can be retrieved by name using rte_bus_find_by_name. We can remove driver specific API. Signed-off-by: David Marchand --- drivers/raw/ifpga/ifpga_rawdev.c | 7 +-- drivers/raw/ifpga/

[RFC PATCH 01/11] common/mlx5: rework check on driver registration

2022-06-28 Thread David Marchand
Rely on a local flag rather than dereference a bus object. This will help next commits. Signed-off-by: David Marchand --- drivers/common/mlx5/linux/mlx5_common_auxiliary.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_common_auxilia

[RFC PATCH 00/11] Bus cleanup for 22.11

2022-06-28 Thread David Marchand
This is a PoC for hiding the rte_bus object and mark associated API as internal. A good amount of the patches are preparation work on rte_bus.h, rte_dev.h, rte_devargs.h and rte_eal.h headers, removing dependencies between them. This is something I had in store for some time, maybe I should have d

[PATCH] net/octeontx_ep: support basic stats

2022-06-28 Thread Sathesh Edara
Added functionality to fetch and reset ethdev stats. Signed-off-by: Sathesh Edara --- doc/guides/nics/features/octeontx_ep.ini | 1 + drivers/net/octeontx_ep/otx_ep_ethdev.c | 52 2 files changed, 53 insertions(+) diff --git a/doc/guides/nics/features/octeontx_ep.ini

[PATCH 1/2] doc: announce region based device mapping support

2022-06-28 Thread skori
From: Sunil Kumar Kori Adding region based device mapping support, which enables pci device to map only required memory region instead of mapping full BAR. Signed-off-by: Sunil Kumar Kori --- doc/guides/rel_notes/deprecation.rst | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH 2/2] bus/pci: support region based device mapping

2022-06-28 Thread skori
From: Sunil Kumar Kori This commit allows driver to define a list of sparse memory regions to map for a given device instead mapping the whole BAR. To do that, a driver must register itself with following information: * rte_pci_driver::drv_flags - RTE_PCI_DRV_NEED_REGION_MAPPING must be set.

[PATCH] app/testpmd: fix memory leak for dscp table

2022-06-28 Thread Jasvinder Singh
This patch fixes memory leak reported by coverity. Coverity issue: 379220 Fixes: 9f5488e326d3 ("app/testpmd: support different input color method") Cc: sta...@dpdk.org Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline_mtr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [PATCH V5 0/7] app/testpmd: fix RSS and flow type

2022-06-28 Thread Ferruh Yigit
On 6/25/2022 2:09 AM, lihuisong (C) wrote: 在 2022/6/24 18:44, Ferruh Yigit 写道: On 6/24/2022 10:54 AM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.

Re: [PATCH V5 1/7] app/testpmd: fix supported RSS offload display

2022-06-28 Thread Ferruh Yigit
On 6/25/2022 3:12 AM, lihuisong (C) wrote: 在 2022/6/24 21:01, Ferruh Yigit 写道: On 6/24/2022 8:23 AM, Huisong Li wrote: The rte_eth_dev_info.flow_type_rss_offloads is populated in terms of RTE_ETH_RSS_* bits. If PMD sets RTE_ETH_RSS_L3_SRC_ONLY to dev_info->flow_type_rss_offloads. testpmd will

Re: [PATCH V5 5/7] app/testpmd: compact RSS types output in some commands

2022-06-28 Thread Ferruh Yigit
On 6/25/2022 3:13 AM, lihuisong (C) wrote: 在 2022/6/24 22:04, Ferruh Yigit 写道: On 6/24/2022 8:23 AM, Huisong Li wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.

Re: [PATCH V5 2/7] app/testpmd: unify the name of L2 payload offload

2022-06-28 Thread Ferruh Yigit
On 6/25/2022 3:12 AM, lihuisong (C) wrote: 在 2022/6/24 21:53, Ferruh Yigit 写道: On 6/24/2022 8:23 AM, Huisong Li wrote: Currently, the "port config all rss xx" command uses 'ether' name to match and to set 'RTE_ETH_RSS_L2_PAYLOAD' offload. However, others RSS command, such as, "port config rss

[PATCH v1] examples/fips_validation: add parsing for sha

2022-06-28 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for SHA test. Verified with SHA 1 and 256 vectors. SHA 384 and 512 has some issues with the way jansson objects are created, which could be addressed separately. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 +

[PATCH v2] examples/fips_validation: add parsing for xts

2022-06-28 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES XTS test. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - build failure fixed if no jansson lib available. --- examples/fips_validation/fips_validation.c| 4 +- examples/fips_validation/fips_validation.h| 16 +- .../fips_validation/fips_v

[PATCH v2] example/fips_validation: handle empty payload

2022-06-28 Thread Gowrishankar Muthukrishnan
Allocate at least onebyte to handle empty payload in a test vector when defined. Fixes: 3d0fad56b74 ("examples/fips_validation: add crypto FIPS application") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- v2: - commit message corrections. --- examples/fips_validation/fips_va

RE: [PATCH] doc: announce change in crypto adapter queue add

2022-06-28 Thread Akhil Goyal
> Subject: [PATCH] doc: announce change in crypto adapter queue add > > The function `rte_event_crypto_adapter_queue_pair_add` will accept > `rte_event_crypto_adapter_queue_conf` argument instead of `rte_event`. > > Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Hunt, David
On 28/06/2022 13:06, Omer Yamac wrote: Hi, Here is the final version. If it is ok, I will test the code and publish. if (enable_lcore_rx_distributor){ // rx and distributor combined, 3 fixed function cores (stat, TX, at least 1 worker) min_cores = 4; num_workers = rte_lcore_count() -

RE: [PATCH] crypto/cnxk: predecrement esn value to be used in session

2022-06-28 Thread Akhil Goyal
> ESN provided in the session would be the next sequence number to be > used. Hence predecrement the value, so that in datapath, incremented > value will be as expected. > > Signed-off-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.

[PATCH v2] net/af_xdp: make compatible with libbpf v0.8.0

2022-06-28 Thread Ciara Loftus
libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacement functions bpf_xdp_query_id, bpf_xdp_attach and bpf_xdp_detach which are available to use since libbpf v0.7.0. Signed-off-

RE: [EXT] [PATCH v1] baseband/acc100: remove file prefix for internal file

2022-06-28 Thread Akhil Goyal
> File renamed to avoid the rte_ file prefix since rte_acc100_pmd.h > is actually internal only. > > Signed-off-by: Nicolas Chautru Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH v4] app/test: add additional stream cipher tests

2022-06-28 Thread Akhil Goyal
> > Adding zuc, snow3g and aes-ctr-cmac auth-cipher test vectors with same auth > > and cipher offsets and total digest data encrypted. > > Existing tests have different cipher and auth offsets and partial or no > > digest > > encrypted. > > > > Signed-off-by: Tejasree Kondoj > > --- > Thanks for

[PATCH] doc: announce change in crypto adapter queue add

2022-06-28 Thread Volodymyr Fialko
The function `rte_event_crypto_adapter_queue_pair_add` will accept `rte_event_crypto_adapter_queue_conf` argument instead of `rte_event`. Signed-off-by: Volodymyr Fialko --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprec

RE: [PATCH v4] app/test: add additional stream cipher tests

2022-06-28 Thread Power, Ciara
> -Original Message- > From: Tejasree Kondoj > Sent: Thursday 23 June 2022 19:20 > To: Akhil Goyal ; Power, Ciara ; > Zhang, Roy Fan > Cc: Anoob Joseph ; Ankur Dwivedi > ; dev@dpdk.org > Subject: [PATCH v4] app/test: add additional stream cipher tests > > Adding zuc, snow3g and aes-ct

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Omer Yamac
Hi, Here is the final version. If it is ok, I will test the code and publish. if (enable_lcore_rx_distributor){ // rx and distributor combined, 3 fixed function cores (stat, TX, at least 1 worker) min_cores = 4; num_workers = rte_lcore_count() - 3; } else{ // separate rx and d

Re: [PATCH v1] examples/fips_validation: add parsing for xts

2022-06-28 Thread David Marchand
On Tue, Jun 28, 2022 at 9:59 AM Gowrishankar Muthukrishnan wrote: > > Added function to parse algorithm for AES XTS test. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/fips_validation/fips_validation.c| 4 +- > examples/fips_validation/fips_validation.h| 17 ++- > ...

[PATCH] doc: announce changes to event vector structure

2022-06-28 Thread pbhagavatula
From: Pavan Nikhilesh The structure ``rte_event_vector`` will be modified to include ``elem_offset:12`` bits taken from ``rsvd:15``. The ``elem_offset`` defines the offset into the vector array from which valid elements are present. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/depre

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Hunt, David
On 28/06/2022 12:06, Omer Yamac wrote: Hi David, I have one more question. When I was working on new patch, I just want to make sure what we are doing. On 27.06.2022 18:51, Hunt, David wrote: Hi Ömer, I've a few comments: On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: --clipped-- @@ -3

Re: [PATCH] crypto/qat: fix docsis segmentation fault

2022-06-28 Thread David Marchand
On Tue, Jun 28, 2022 at 12:32 PM Troy, Rebecca wrote: > > > On Mon, Jun 27, 2022 at 6:45 PM Rebecca Troy > > wrote: > > > > > > Currently if AES or DES algorithms fail for Docsis test suite, a > > > segmentation fault occurs when cryptodev_qat_autotest is ran. > > > > > > This is due to a duplica

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Omer Yamac
Hi David, I have one more question. When I was working on new patch, I just want to make sure what we are doing. On 27.06.2022 18:51, Hunt, David wrote: Hi Ömer, I've a few comments: On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: --clipped-- @@ -39,6 +39,7 @@ volatile uint8_t quit_signal_

RE: [PATCH] net/vhost: fix compliant offloading flag

2022-06-28 Thread Ling, WeiX
> -Original Message- > From: Ding, Xuan > Sent: Tuesday, June 28, 2022 6:29 PM > To: Maxime Coquelin ; Xia, Chenbo > > Cc: dev@dpdk.org; Ling, WeiX > Subject: RE: [PATCH] net/vhost: fix compliant offloading flag > > > > > -Original Message- > > From: Maxime Coquelin > > Sent:

Re: [PATCH] crypto/qat: fix docsis segmentation fault

2022-06-28 Thread Troy, Rebecca
> On Mon, Jun 27, 2022 at 6:45 PM Rebecca Troy > wrote: > > > > Currently if AES or DES algorithms fail for Docsis test suite, a > > segmentation fault occurs when cryptodev_qat_autotest is ran. > > > > This is due to a duplicate call of EVP_CIPHER_CTX_free for the session > > context. Ctx is free

RE: [PATCH] net/vhost: fix compliant offloading flag

2022-06-28 Thread Ding, Xuan
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 28, 2022 5:57 PM > To: Ding, Xuan ; Xia, Chenbo > Cc: dev@dpdk.org; Ling, WeiX > Subject: Re: [PATCH] net/vhost: fix compliant offloading flag > > > > On 6/28/22 11:42, xuan.d...@intel.com wrote: > > From: Xuan Ding

RE: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-06-28 Thread Loftus, Ciara
> > On 6/24/22 13:23, Ciara Loftus wrote: > > libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and > >> bpf_set_link_xdp_fd > > functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, > use > > the recommended replacement functions bpf_xdp_query_id, > bpf_

Re: [PATCH v2] baseband/turbo_sw: Remove flexran_sdk meson option

2022-06-28 Thread Thomas Monjalon
27/06/2022 22:29, Nicolas Chautru: > Hi Thomas, > This is change you requested earlier this year. This is targeting 22.11. OK thanks. > Basically we no longer pass a specific option but rely on pkgconfig. > There is small change to generate the .pc files that Intel will make > available by end o

Re: [PATCH] net/vhost: fix compliant offloading flag

2022-06-28 Thread Maxime Coquelin
On 6/28/22 11:42, xuan.d...@intel.com wrote: From: Xuan Ding This patch fixes the check to set compliant offloading flag. Compliant offloading flag should be set when the 'legacy-ol-flags' is true. Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode") Signed-off-by: Xuan Ding

[PATCH] net/vhost: fix compliant offloading flag

2022-06-28 Thread xuan . ding
From: Xuan Ding This patch fixes the check to set compliant offloading flag. Compliant offloading flag should be set when the 'legacy-ol-flags' is true. Fixes: 3a6ee8dafb21("net/vhost: enable compliant offloading mode") Signed-off-by: Xuan Ding --- drivers/net/vhost/rte_eth_vhost.c | 2 +- 1

Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-06-28 Thread Andrew Rybchenko
On 6/27/22 18:24, Loftus, Ciara wrote: On 6/27/22 17:17, Loftus, Ciara wrote: On 6/24/22 13:23, Ciara Loftus wrote: libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacemen

[Bug 1043] [dpdk-22.07]vm2vm_virtio_net_perf_cbdma/vm2vm_split_ring_iperf_with_tso_and_cbdma_enable: iperf test no data between 2 VMs

2022-06-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1043 Bug ID: 1043 Summary: [dpdk-22.07]vm2vm_virtio_net_perf_cbdma/vm2vm_split_ri ng_iperf_with_tso_and_cbdma_enable: iperf test no data between 2 VMs Product: DPDK Version: 2

RE: [EXT] [PATCH 0/2] fix wireless algorithm IVs

2022-06-28 Thread Akhil Goyal
> Some of the ZUC and Snow3G test vectors did not follow > the specification for the cipher and authentication IVs. > > Ciara Power (2): > test/crypto: fix zuc test vector IV format > test/crypto: fix snow3g test vector IV format > > app/test/test_cryptodev_snow3g_test_vectors.h | 142 ++

Re: [PATCH v2] vdpa/sfc: handle sync issue between qemu and vhost-user

2022-06-28 Thread Andrew Rybchenko
On 6/28/22 08:29, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini When DPDK app is running in the VF, it sometimes rings the doorbell before dev_config has had a chance to complete and hence it misses the event. As workaround, ring the doorbell when vDPA reports the notify_area to QEMU.

RE: [PATCH] test/crypto: fix authentication IV for zuc SGL

2022-06-28 Thread Akhil Goyal
> > > > The wireless operation for ZUC SGL tests was being passed NULL instead of a > > pointer to the test data authentication IV, and IV length 0. > > This is now corrected to use the IV from the test data. > > > > Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP") > > C

RE: [EXT] Re: [PATCH v3 1/2] examples/l3fwd: common packet group functionality

2022-06-28 Thread Akhil Goyal
> 23/06/2022 10:38, Rahul Bhansali пишет: > > This will make the packet grouping function common, so > > that other examples can utilize as per need. > > > > For each architecture sse/neon/altivec, port group > > headers will be created under examples/common/. > > > > Signed-off-by: Rahul Bhansali

RE: [PATCH] examples/ipsec-secgw: fix Tx checksum offload flag

2022-06-28 Thread Akhil Goyal
> > For the inline crypto path set the Tx checksum offload flag > > only if the device supports it. > > > > Fixes: d24471e5786b ("examples/ipsec-secgw: disable Tx checksum for inline") > > Cc: ndabilpu...@marvell.com > > > > Signed-off-by: Radu Nicolau > > --- > Acked-by: Fan Zhang Acked-by: Akhi

RE: [PATCH v3] app/test: add event inline security tests

2022-06-28 Thread Akhil Goyal
> Enable ability to run inline security tests using event > API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst). > New test command - event_inline_ipsec_autotest will run same list of > test cases as inline_ipsec_autotest, but packets will go through eventdev. > > Signed-off-by: Volodymy

RE: [dpdk-dev] [PATCH v5] examples/ipsec-secgw: support more flow patterns and actions

2022-06-28 Thread Akhil Goyal
> > From: Satheesh Paul > > > > Added support to create flow rules with count, mark and > > security actions and mark pattern. > > > > Signed-off-by: Satheesh Paul > > --- > Acked-by: Fan Zhang Acked-by: Akhil Goyal Applied to dpdk-next-crypto

Re: [PATCH] examples/distributor: update dynamic configuration

2022-06-28 Thread Hunt, David
Hi Ömer, On 27/06/2022 17:28, Omer Yamac wrote: Hi David, Thank you for your review. I have two questions. The first one is about new release. As I remember new DPDK realize will be published in a short time and my previous fix in that release. Therefore, Should I wait for that release to su

[PATCH v1] examples/fips_validation: add parsing for xts

2022-06-28 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES XTS test. Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 4 +- examples/fips_validation/fips_validation.h| 17 ++- .../fips_validation/fips_validation_xts.c | 126 ++ examples/fips

[PATCH v1] example/fips_validation: handle empty payload

2022-06-28 Thread Gowrishankar Muthukrishnan
Allocate atleast onebyte to handle empty payload in a test vector when defined. Fixes: 3d0fad56b74 ("examples/fips_validation: add crypto FIPS application") Cc: sta...@dpdk.org Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c | 2 +- 1 file changed, 1 ins

RE: [PATCH] common/iavf: replace zero-length arrays with flexible ones

2022-06-28 Thread Zhang, Qi Z
> -Original Message- > From: 835703...@qq.com <835703...@qq.com> > Sent: Thursday, June 16, 2022 1:26 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Shiqi Liu <835703...@qq.com> > Subject: [PATCH] common/iavf: replace zero-length arrays with flexible ones > > From: Shiqi Liu <835703...@qq.c

Re: [PATCH] crypto/qat: fix docsis segmentation fault

2022-06-28 Thread David Marchand
On Mon, Jun 27, 2022 at 6:45 PM Rebecca Troy wrote: > > Currently if AES or DES algorithms fail for Docsis test suite, > a segmentation fault occurs when cryptodev_qat_autotest is ran. > > This is due to a duplicate call of EVP_CIPHER_CTX_free for the > session context. Ctx is freed firstly in the

RE: [PATCH v3] net/igc: move the initialization of data path into dev_init

2022-06-28 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Tuesday, June 28, 2022 2:21 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhang, Qi Z > ; Zeng, ZhichaoX ; > alvinx.zh...@intel.com; Guo, Junfeng ; Su, Simei > ; Ferruh Yigit > Subject: [PATCH v3] net/igc: move the initi