[PATCH v2] net/nfp: store counter reset before zeroing flow query

2022-12-09 Thread Chaoyong He
The reset flag in the query structure are cleared by mistake, cause the flow count never be reset, so the query API will always has count value even the flow has stopped, and this will cause the flow never been aged. Fixes: 30ecce522732 ("net/nfp: support flow API") Cc: sta...@dpdk.org Signed-off

Re: [PATCH 2/2] devtools: configure source repo to use as ABI reference

2022-12-09 Thread David Marchand
On Tue, Dec 6, 2022 at 1:24 PM Ferruh Yigit wrote: > > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting different repository to close fo

Re: [PATCH 2/2] devtools: configure source repo to use as ABI reference

2022-12-09 Thread Ferruh Yigit
On 12/9/2022 8:22 AM, David Marchand wrote: > On Tue, Dec 6, 2022 at 1:24 PM Ferruh Yigit wrote: >> >> By default 'test-meson-builds.sh' script clones the repository which the >> script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') >> as a reference for ABI check. >> >> This patc

[PATCH v2 2/2] devtools: configure source repo to use as ABI reference

2022-12-09 Thread David Marchand
From: Ferruh Yigit By default 'test-meson-builds.sh' script clones the repository which the script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') as a reference for ABI check. This patch enables selecting different repository to clone for reference using 'DPDK_ABI_REF_SRC' envir

[PATCH v2 1/2] devtools: document test meson script config options

2022-12-09 Thread David Marchand
From: Ferruh Yigit Document config options of script that can be provided by 'devel.config' config file. Signed-off-by: Ferruh Yigit --- devtools/test-meson-builds.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh i

Re: 20.11.7 patches review and test

2022-12-09 Thread YangHang Liu
Hi Luca, RedHat QE does not find new issues about the 20.11.7 dpdk during the tests. We tested below 17 scenarios and all got PASS on RHEL8: - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) throughput testing(2M hugepage s

Re: Building DPDK with IOVA_AS_VA

2022-12-09 Thread fengchengwen
The hns3 and idpf both use static_library to build advanced vector (e.g. SVE for hns3 and AVX512 for idpf). The static-library is still compiled even the PMD is not compiled, and this lead to the compile fail problem. Although the following could solve the problem, but is there a better plan

Re: 19.11.14 patches review and test

2022-12-09 Thread YangHang Liu
Hi, Christian RedHat QE does not find new issues about the 19.11.14 dpdk during the tests. We tested below 17 scenarios and all got PASS on RHEL8: - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) throughput testing(2M huge

Re: 20.11.7 patches review and test

2022-12-09 Thread Luca Boccassi
Thank you! The two compilation issues have been fixed. Waiting on a resolution on the other two issues. Should they be considered blockers and delay the release, if a fix is not available by next week? On Wed, 7 Dec 2022 at 10:22, Jiang, YuX wrote: > > Hi All, > Update the test status for Intel

Re: 20.11.7 patches review and test

2022-12-09 Thread Luca Boccassi
Thank you! On Fri, 9 Dec 2022 at 09:25, YangHang Liu wrote: > > Hi Luca, > > RedHat QE does not find new issues about the 20.11.7 dpdk during the tests. > > We tested below 17 scenarios and all got PASS on RHEL8: > > Guest with device assignment(PF) throughput testing(1G hugepage size): PASS > G

RE: [PATCH v6] doc: add PMD known issue

2022-12-09 Thread Ye, MingjinX
Hi All, Could you please review and provide suggestions if any. Thanks, Mingjin > > -Original Message- > > From: Ye, MingjinX > > Sent: 2022年11月21日 10:55 > > To: dev@dpdk.org > > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, > > YidingX ; Ye, MingjinX > > ; Zhang, Qi Z ; Jie Zhou > > ; Meno

Re: [PATCH v2 3/3] test/bbdev: explicit check for allocation failure

2022-12-09 Thread Maxime Coquelin
Hi Nicolas, On 12/7/22 16:33, Chautru, Nicolas wrote: Hi Maxime, I don’t believe this constitutes a fix, just adding more error check to be more comprehensive. Not required for stable branch really. Let me know if you disagree. I think we should backport it since it constitutes a fix. Witho

[PATCH V2 01/11] telemetry: move to header to controllable range

2022-12-09 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is uncontrollable. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/tel

[PATCH V2 00/11] telemetry: add u32 value type and hex integer string API

2022-12-09 Thread Huisong Li
Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. The 'u32' data can not be assigned to signed 32-bit integer. However, assigning to u64 is very wasteful, after all, the buffer capacity of

[PATCH V2 04/11] ethdev: fix possible data truncation and conversion error

2022-12-09 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Hui

[PATCH V2 06/11] cryptodev: fix possible data conversion error

2022-12-09 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/cryptodev/rte_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH V2 03/11] test: add test cases for adding u32 value API

2022-12-09 Thread Huisong Li
Add test cases for adding u32 value API. Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- app/test/test_telemetry_data.c | 85 +- app/test/test_telemetry_json.c | 23 - 2 files changed, 104 insertions(+), 4 deletions(-) diff --git a/app/test/test_teleme

[PATCH V2 08/11] telemetry: refactor mapping betwween value and array type

2022-12-09 Thread Huisong Li
Currently, use rte_tel_value_type as index of array to find the tel_container_types in rte_tel_data_start_array. It's not good for maintenance. Fixes: ed1bfad7d384 ("telemetry: add functions for returning callback data") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/telemetry/telemetry_

[PATCH V2 10/11] test: add test cases for adding hex integer values API

2022-12-09 Thread Huisong Li
Add test cases for adding hexadecimal u32 and u64 values API. Signed-off-by: Huisong Li --- app/test/test_telemetry_data.c | 164 + 1 file changed, 164 insertions(+) diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c index 8ab3441cbe..7c

[PATCH V2 11/11] ethdev: display capability values in hexadecimal format

2022-12-09 Thread Huisong Li
The 'dev_flags', 'rx_offloads', 'tx_offloads' and 'rss_hf' are better displayed in hexadecimal format. Like: -->old display by input /ethdev/info,0 "dev_flags": 3, "rx_offloads": 524288, "tx_offloads": 65536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3",

[PATCH V2 05/11] mempool: fix possible data truncation and conversion error

2022-12-09 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- l

[PATCH V2 02/11] telemetry: add u32 value type

2022-12-09 Thread Huisong Li
Currently, 32-bit integer value only is signed in telemetry. The u32 data can not be assigned to signed 32-bit integer. However, assigning to u64 is very wasteful, after all, the buffer capacity of each transfer is limited. So it is necessary for 'u32' data to add usigned 32-bit integer type and co

[PATCH V2 07/11] mem: possible data truncation and conversion error

2022-12-09 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. The 'u32' data need to use the 'u32' telemetry API to add, and the 'u64' data need to use the 'u64' telemetry API to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/eal/

[PATCH V2 09/11] telemetry: support adding integer value as hexadecimal

2022-12-09 Thread Huisong Li
Sometimes displaying a integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device falg. This patch introduces some APIs to add 'u32' and 'u64' value as hexadecimal encoded string to array or dictionary. Signed-off-by: Huisong Li ---

[PATCH] event/cnxk: wait for CPT fc on wqe path

2022-12-09 Thread Rahul Bhansali
Wait for CPT flow control on WQE path. Signed-off-by: Rahul Bhansali --- drivers/event/cnxk/cn9k_worker.h | 1 + drivers/net/cnxk/cn9k_tx.h | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h index 4c3932da47

[PATCH] net/mlx5: fix assert on getting register of sample flow

2022-12-09 Thread Jiawei Wang
From: Jiawei Wang The sample flow tried to get the reserved metadata register for match implicitly, and if the reserved metadata register was invalid then back to use the application tag. The assertion failure was caused while getting register due to the reserved metadata regC is invalid on CX-5

Re: [PATCH v4 0/2] add a fast path for memif Rx/Tx

2022-12-09 Thread Ferruh Yigit
On 9/22/2022 10:12 AM, Ferruh Yigit wrote: > On 9/15/2022 7:58 AM, Joyce Kong wrote: >> For memif non-zero-copy mode, there is a branch to compare >> the mbuf and memif buffer size during memory copy. Add a >> fast memcpy path by removing this branch with mbuf and memif >> buffer size defined at co

[PATCH v2] net/mlx5: fix assert on getting register of sample flow

2022-12-09 Thread Jiawei Wang
The sample flow tried to get the reserved metadata register for match implicitly, and if the reserved metadata register was invalid then back to use the application tag. The assertion failure was caused while getting register due to the reserved metadata regC is invalid on CX-5 trusted device(VF/S

[PATCH v3] net/mlx5: fix assert on getting register of sample flow

2022-12-09 Thread Jiawei Wang
The sample flow tried to get the reserved metadata register for match implicitly, and if the reserved metadata register was invalid then back to use the application tag. The assertion failure was caused while getting register due to the reserved metadata regC is invalid on CX-5 trusted device(VF/S

Re: [PATCH v2] net/memif: default to physical socket

2022-12-09 Thread Ferruh Yigit
On 12/8/2022 11:24 AM, Nathan Skrzypczak wrote: > Hi Stephen, Hi Ferruh, > > I don't have a strong opinion on usage of regular sockets vs abstract > sockets. My point is that most existing memif implementations > either don't yet properly support abstract sockets or require extra > flags to be pas

Re: [PATCH v2] kni: fix possible alloc_q starvation when mbufs are exhausted

2022-12-09 Thread Ferruh Yigit
On 11/11/2022 9:12 AM, Matt wrote: > > > On Thu, Nov 10, 2022 at 12:39 AM Stephen Hemminger > mailto:step...@networkplumber.org>> wrote: > > On Wed,  9 Nov 2022 14:04:34 +0800 > Yangchao Zhou mailto:zhouya...@gmail.com>> wrote: > > > In some scenarios, mbufs returned by rte_kni_rx_b

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Stephen Hemminger
On Fri, 09 Dec 2022 08:53:57 +0100 Thomas Monjalon wrote: > > > If some execution environment doesn't support thread names, it could > > > return a string that makes it possible for a human to identify the > > > thread, e.g. the tread id. Again, this is assuming that it is only used > > > for

RE: [PATCH V2 00/11] telemetry: add u32 value type and hex integer string API

2022-12-09 Thread Morten Brørup
> From: Huisong Li [mailto:lihuis...@huawei.com] > Sent: Friday, 9 December 2022 12.05 > > Some lib telemetry interfaces add the 'u32' and 'u64' data by the > rte_tel_data_add_dict/array_int API. This may cause data conversion > error or data truncation. > > The 'u32' data can not be assigned to

[Bug 1146] bnx2x: rte_memcpy buffer overflows

2022-12-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1146 Bug ID: 1146 Summary: bnx2x: rte_memcpy buffer overflows Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal P

Re: [PATCH v2 1/3] eal: add rte control thread create API

2022-12-09 Thread Tyler Retzlaff
On Thu, Dec 08, 2022 at 05:09:32PM -0800, Stephen Hemminger wrote: > On Tue, 6 Dec 2022 09:28:24 -0800 > Tyler Retzlaff wrote: > > > + /* Wait for the control thread to initialize successfully */ > > + while ((ctrl_thread_status = > > + __atomic_load_n(¶ms->ctrl_thread_stat

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Tyler Retzlaff
hey, combining the reply to both Thomas and Stephen since i think this series http://mails.dpdk.org/archives/dev/2022-December/257238.html addresses both feedback comments. On Fri, Dec 09, 2022 at 08:48:14AM -0800, Stephen Hemminger wrote: > On Fri, 09 Dec 2022 08:53:57 +0100 > Thomas Monjalon w

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Thomas Monjalon
09/12/2022 21:06, Tyler Retzlaff: > On Fri, Dec 09, 2022 at 08:48:14AM -0800, Stephen Hemminger wrote: > > On Fri, 09 Dec 2022 08:53:57 +0100 > > Thomas Monjalon wrote: > > > > > > > If some execution environment doesn't support thread names, it could > > > > > return a string that makes it poss

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Thomas Monjalon
09/12/2022 17:48, Stephen Hemminger: > On Fri, 09 Dec 2022 08:53:57 +0100 > Thomas Monjalon wrote: > > > > > If some execution environment doesn't support thread names, it could > > > > return a string that makes it possible for a human to identify the > > > > thread, e.g. the tread id. Again,

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Stephen Hemminger
On Fri, 09 Dec 2022 22:14:33 +0100 Thomas Monjalon wrote: > 09/12/2022 17:48, Stephen Hemminger: > > On Fri, 09 Dec 2022 08:53:57 +0100 > > Thomas Monjalon wrote: > > > > > > > If some execution environment doesn't support thread names, it could > > > > > return a string that makes it possib

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Tyler Retzlaff
On Fri, Dec 09, 2022 at 10:13:44PM +0100, Thomas Monjalon wrote: > 09/12/2022 21:06, Tyler Retzlaff: > > On Fri, Dec 09, 2022 at 08:48:14AM -0800, Stephen Hemminger wrote: > > > On Fri, 09 Dec 2022 08:53:57 +0100 > > > Thomas Monjalon wrote: > > > > > > > > > If some execution environment doesn't

Re: help with pthread_t deprecation / api changes

2022-12-09 Thread Tyler Retzlaff
On Fri, Dec 09, 2022 at 02:38:49PM -0800, Stephen Hemminger wrote: > On Fri, 09 Dec 2022 22:14:33 +0100 > Thomas Monjalon wrote: > > > 09/12/2022 17:48, Stephen Hemminger: > > > On Fri, 09 Dec 2022 08:53:57 +0100 > > > Thomas Monjalon wrote: > > > > > > > > > If some execution environment doe