[PATCH v5 0/2] Enable PMD power management on Arm

2022-12-14 Thread Feifei Wang
For Arm aarch, use WFE instructions to enable PMD power management. Test Results: dynamic instructions over 1sec without wfe with wfepercentage ampere-altra6,298,483,712 9,117,624 -99.855% thunderx2 6,990,909,373 3,247,226 -99.

[PATCH v5 1/2] eal: add 8 bits case for wait scheme

2022-12-14 Thread Feifei Wang
For wait scheme generic helper, add 8 bits case. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- lib/eal/arm/include/rte_pause_64.h | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/lib/eal/arm/include/rte_pause_64.h b/lib/eal/arm/include

[PATCH v5 2/2] eal: add power mgmt support on Arm

2022-12-14 Thread Feifei Wang
For Arm aarch, use WFE instruction to enable power monitor API, and use SEV instruction to enable wake up API. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Acked-by: David Hunt --- lib/eal/arm/include/rte_pause_64.h | 5 ++- lib/eal/arm/rte_cpuflags.c | 5 +++ lib/eal/arm/rte

[PATCH] vdpa/ifc: add live migration for block device

2022-12-14 Thread Andy Pei
When we use "sw-live-migration=1" in arguments, we run in SW assisted live migration mode. In SW assisted live migration mode, driver will stop the device and setup a mediated virtio ring to relay the communication between the virtio driver and the VDPA device. For block devices, we have to make

Re: [PATCH] ci: drop Travis configuration

2022-12-14 Thread Ferruh Yigit
On 12/13/2022 3:07 PM, David Marchand wrote: > We stopped using Travis in the main branch and in the public CI in favor > of GHA more than a year ago. > The UNH community lab now covers testing native compilation and unit > tests for ARM platforms. > > We decided to stop maintaining the configurat

Re: [PATCH] cryptodev: add algo enums to string conversion APIs

2022-12-14 Thread Zhang, Fan
On 12/12/2022 3:10 PM, Akhil Goyal wrote: Symmetric/Asymmetric algorithm strings are accessed by application using arrays in cryptodev lib, which hampers new algorithms addition in the array due to ABI breakage. These arrays are now deprecated and will be removed in next ABI break release. New AP

RE: [PATCH v4 1/4] eal: add generic support for reading PMU events

2022-12-14 Thread Tomasz Duszynski
Hello Morten, Thanks for review. Answers inline. [...] > > +/** > > + * @file > > + * > > + * PMU event tracing operations > > + * > > + * This file defines generic API and types necessary to setup PMU and > > + * read selected counters in runtime. > > + */ > > + > > +/** > > + * A structure d

RE: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic

2022-12-14 Thread Naga Harish K, S V
> -Original Message- > From: Jayatheerthan, Jay > Sent: Wednesday, December 14, 2022 1:01 PM > To: Naga Harish K, S V ; jer...@marvell.com; > Carrillo, Erik G ; Gujjar, Abhinandan S > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig > logic >

Re: [PATCH v2 0/3] net/bonding: support device private dump

2022-12-14 Thread humin (Q)
Acked-by:Min Hu (Connor) 在 2022/12/14 14:13, Chengwen Feng 写道: This patchset adds device private dump for bonding PMD, and use rte_eth_dev_priv_dump API to implement testpmd show bonding command. Chengwen Feng (3): net/bonding: support private dump ops net/bonding: support dump LACP info

Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-14 Thread David Marchand
On Mon, Dec 12, 2022 at 7:38 PM Ferruh Yigit wrote: > > On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: > > diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map > > index 3651ceb234..79d0b2ee1f 100644 > > --- a/lib/ethdev/version.map > > +++ b/lib/ethdev/version.map > > @@ -319,4 +319,148 @@ IN

Re: Question about add ethdev loopback set API

2022-12-14 Thread Ferruh Yigit
On 12/14/2022 7:25 AM, fengchengwen wrote: > On 2022/12/13 19:25, Ferruh Yigit wrote: >> On 12/13/2022 10:04 AM, fengchengwen wrote: >>> Hi Ferruh, >>> >>> During the test, we need to delineate where go wrong when encountered >>> e.g. CRC error. In this scenario, loopback is useful. >>> >>>

Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-14 Thread Jerin Jacob
On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote: > > On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: > > Hi Ankur, Jerin, Hi Ferruh, Please find answers to generic trace questions. > > I have some major questions, I can see some already queried by Andrew as > well: > > 1) How flexible are we on ch

RE: [PATCH v4 1/4] eal: add generic support for reading PMU events

2022-12-14 Thread Morten Brørup
+CC: Mattias, see my comment below about per-thread constructor for this > From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Wednesday, 14 December 2022 10.39 > > Hello Morten, > > Thanks for review. Answers inline. > > [...] > > > > +/** > > > + * @file > > > + * > > > + * PMU ev

Re: [PATCH v2] net/nfp: using the correct PCI name to look for the firmware

2022-12-14 Thread Niklas Söderlund
Hi Ferruh, On 2022-12-08 18:06:56 +, Ferruh Yigit wrote: > On 12/8/2022 3:31 AM, Chaoyong He wrote: > > From: Peng Zhang > > > > In the description of nfp document, DPDK PMD supports that the PF > > looks for a firmware file by the PCI name. > > > > After this commit, it will looks for the

[Bug 1148] Performance on AESNI MB PMD does not scale properly with number of threads

2022-12-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1148 Bug ID: 1148 Summary: Performance on AESNI MB PMD does not scale properly with number of threads Product: DPDK Version: 22.11 Hardware: All OS: All Stat

Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-14 Thread Ferruh Yigit
On 12/14/2022 10:34 AM, David Marchand wrote: > On Mon, Dec 12, 2022 at 7:38 PM Ferruh Yigit wrote: >> >> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: >>> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map >>> index 3651ceb234..79d0b2ee1f 100644 >>> --- a/lib/ethdev/version.map >>> +++ b/l

Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-14 Thread Ferruh Yigit
On 12/14/2022 10:40 AM, Jerin Jacob wrote: > On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote: >> >> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: >> >> Hi Ankur, Jerin, > > Hi Ferruh, Please find answers to generic trace questions. > >> >> I have some major questions, I can see some already quer

Re: [PATCH V4 7/9] telemetry: support adding integer value as hexadecimal

2022-12-14 Thread lihuisong (C)
在 2022/12/14 15:28, Morten Brørup 写道: From: lihuisong (C) [mailto:lihuis...@huawei.com] Sent: Wednesday, 14 December 2022 03.44 在 2022/12/14 1:09, Bruce Richardson 写道: On Tue, Dec 13, 2022 at 06:15:10PM +0800, Huisong Li wrote: Sometimes displaying a unsigned integer value as hexadecimal enc

[PATCH V5 4/8] cryptodev: fix possible data conversion error

2022-12-14 Thread Huisong Li
The 'u32' data can not assigned to 'int' type variable. The 'u32' data needs to use the 'u64' APIs to add. Fixes: d3d98f5ce9d0 ("cryptodev: support telemetry") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/cryptodev/rte_cryptodev.c | 2 +

[PATCH V5 3/8] mempool: fix possible data truncation and conversion error

2022-12-14 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 2f5c4025abb3 ("mempool: add telemetry endpoint") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/mempool/rte_mempool.c | 24 ++

[PATCH V5 1/8] telemetry: move to header to controllable range

2022-12-14 Thread Huisong Li
The "stdint.h" header is outside '_RTE_TELEMETRY_H_' macro, which cause this header is unconditional. So this patch moves this header to inside '_RTE_TELEMETRY_H_'. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Mor

[PATCH V5 2/8] ethdev: fix possible data truncation and conversion error

2022-12-14 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/ethdev/rte_eth

[PATCH V5 5/8] mem: possible data truncation and conversion error

2022-12-14 Thread Huisong Li
The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- lib/eal/common/eal_common_memory.c | 10

[PATCH V5 0/8] telemetry: fix data truncation and conversion error and add hex integer API

2022-12-14 Thread Huisong Li
Some lib telemetry interfaces add the 'u32' and 'u64' data by the rte_tel_data_add_dict/array_int API. This may cause data conversion error or data truncation. This patch series uses 'u64' functions to do this. In addition, this patch series introduces two APIs to store unsigned integer values as

[PATCH V5 6/8] telemetry: support adding integer value as hexadecimal

2022-12-14 Thread Huisong Li
Sometimes displaying a unsigned integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces two APIs to add unsigned integer value as hexadecimal encoded string to array or dictionary. And user can choose whet

[PATCH V5 8/8] ethdev: display capability values in hexadecimal format

2022-12-14 Thread Huisong Li
The 'dev_flags', 'rx_offloads', 'tx_offloads' and 'rss_hf' are better displayed in hexadecimal format. Like: -->old display by input /ethdev/info,0 "dev_flags": 3, "rx_offloads": 524288, "tx_offloads": 65536, "ethdev_rss_hf": 9100 --> now display "dev_flags": "0x3",

[PATCH V5 7/8] test: add test cases for adding hex integer value API

2022-12-14 Thread Huisong Li
Add test cases for adding hexadecimal unsigned integer value API. Signed-off-by: Huisong Li Acked-by: Morten Brørup Acked-by: Chengwen Feng --- app/test/test_telemetry_data.c | 150 + 1 file changed, 150 insertions(+) diff --git a/app/test/test_telemetry_data.c

RE: [PATCH V5 5/8] mem: possible data truncation and conversion error

2022-12-14 Thread Morten Brørup
> From: Huisong Li [mailto:lihuis...@huawei.com] > Sent: Wednesday, 14 December 2022 13.33 > > The 'u32' and 'u64' data can not assigned to 'int' type variable. > They need to use the 'u64' APIs to add. > > Fixes: e6732d0d6e26 ("mem: add telemetry infos") > Cc: sta...@dpdk.org > > Signed-off-by:

RE: [EXT] Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-14 Thread Ankur Dwivedi
Hi Ferruh, Thanks a lot for reviewing this patch. The generic questions have been answered by Jerin in earlier email. I have replied inline to the remaining comments. > >There are bunch of small comments inline, some are related to above highlevel >question. >But I stopped after some point, speci

[PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

2022-12-14 Thread Shibin Koikkara Reeny
Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privileges, which prevents the PMD

Re: [PATCH V5 6/8] telemetry: support adding integer value as hexadecimal

2022-12-14 Thread Bruce Richardson
On Wed, Dec 14, 2022 at 08:32:51PM +0800, Huisong Li wrote: > Sometimes displaying a unsigned integer value as hexadecimal encoded style > is more expected for human consumption, such as, offload capability and > device flag. This patch introduces two APIs to add unsigned integer value > as hexadec

[PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

2022-12-14 Thread Shibin Koikkara Reeny
Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privileges, which prevents the PMD

RE: [PATCH] app/test: add SHA3 test cases

2022-12-14 Thread Power, Ciara
> -Original Message- > From: Volodymyr Fialko > Sent: Wednesday 9 November 2022 15:28 > To: dev@dpdk.org; Akhil Goyal ; Fan Zhang > ; Wang, Yipeng1 ; > Gobriel, Sameh ; Richardson, Bruce > ; Medvedkin, Vladimir > > Cc: jer...@marvell.com; ano...@marvell.com; vikas.gu...@broadcom.com; >

Re: [PATCH v3 1/3] test/bbdev: fix build issue with optional build flag

2022-12-14 Thread Maxime Coquelin
Hi Nicolas, On 12/13/22 17:18, Nicolas Chautru wrote: Incorrect bbdev member name used in test code under RTE_BBDEV_OFFLOAD_COST build flag. Fixes: 4f08028c5e24 ("bbdev: expose queue related warning and status") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru Next time, please amend the

Re: [PATCH v3 2/3] test/bbdev: fix build issue with optional build flag

2022-12-14 Thread Maxime Coquelin
On 12/13/22 17:18, Nicolas Chautru wrote: Missing implementation for offload test with FFT. Only build when the optional build flag RTE_BBDEV_OFFLOAD_COST is set. Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-b

Re: [PATCH v3 3/3] test/bbdev: explicit check for allocation failure

2022-12-14 Thread Maxime Coquelin
On 12/13/22 17:18, Nicolas Chautru wrote: Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c |

Re: [PATCH v3 0/3] test/bbdev: fix build issues with optional build flag

2022-12-14 Thread Maxime Coquelin
On 12/13/22 17:18, Nicolas Chautru wrote: v3: add more Fixes tag for missing error check commit v2: add check in offload test function for error during allocation suggested by Maxime. Fixing compilation errors in bbdev-test application on rc4 when the optional flag RTE_BBDEV_OFFLOAD_COST is se

[PATCH] crypto/qat: add SHA3 plain hash support

2022-12-14 Thread Ciara Power
Add support for plain SHA3-224, SHA3-256, SHA3-384, and SHA3-512 hash support in QAT GEN3. Add support for SHA3-256 in GEN2. Signed-off-by: Ciara Power --- Tested using testcases from patch not yet merged. https://patchwork.dpdk.org/project/dpdk/patch/20221109152809.2026484-1-vfia...@marvell.com

[PATCH] crypto/qat: enable asymmetric crypto on gen3 device

2022-12-14 Thread Ciara Power
This commit enables asymmetric crypto in generation three devices. Signed-off-by: Ciara Power --- doc/guides/cryptodevs/qat.rst| 3 ++- doc/guides/rel_notes/release_23_03.rst | 3 +++ drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 12 3 files changed, 13 inse

Intel DPDK v23.03 Roadmap

2022-12-14 Thread Mcnamara, John
# Intel roadmap for DPDK 23.03 ## Networking - pipeline IPsec support for tunnel and transport modes ## Network drivers - enable PTP timesync and Tx timestamp for Intel NIC I225 - add initial Intel Control Path Function Library (CPFL) PMD support for Intel IPU E2100 - additional features for I

[PATCH v1] update Intel roadmap for 23.03

2022-12-14 Thread John McNamara
Was announced in the dpdk-dev mailing list: https://mails.dpdk.org/archives/dev/2022-December/257699.html Signed-off-by: John McNamara --- content/roadmap/_index.md | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/content/roadmap/_index.md b/content/roadmap/_in

[PATCH v1] update Intel roadmap for 23.03

2022-12-14 Thread John McNamara
Was announced in the dpdk-dev mailing list: https://mails.dpdk.org/archives/dev/2022-December/257699.html Signed-off-by: John McNamara --- content/roadmap/_index.md | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/content/roadmap/_index.md b/content/roadmap/_in

[PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t

2022-12-14 Thread Tyler Retzlaff
Replace the rte_thread_setname API which operates on pthread_t with rte_thread_set_name that operates on rte_thread_t. v2: * initial series provided get/set for lcore thread id, those additions have been removed as per discussion. including unit test. * add a single api rte_thread_set_

[PATCH v2 2/4] eal: remove thread getname API

2022-12-14 Thread Tyler Retzlaff
Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Signed-off-by: Tyler Retzlaff --- lib/eal/freebsd/eal_thread.c | 9 - lib/eal/include/rte_lcore.h | 17 - lib/eal/linux/eal_thread.c | 15 --- lib/eal/ver

[PATCH v2 3/4] eal: deprecate rte thread setname API

2022-12-14 Thread Tyler Retzlaff
Notify deprecation of rte_thread_setname API, it is being removed as it exposes platform-specific thread details. The functionality it provided is now implicitly provided via the rte_lcore_set_name API if the underlying platform supports it. Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes

[PATCH v2 1/4] eal: add thread set name API operating on rte thread

2022-12-14 Thread Tyler Retzlaff
Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_thread.c | 9 +++- lib/eal/common/eal_common_trace.c

[PATCH v2 4/4] drivers: mlx5 use rte thread set name

2022-12-14 Thread Tyler Retzlaff
Use the new internal rte_thread_set_name API instead of the now deprecated rte_thread_setname API. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.c | 4 +++- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/n

RE: [PATCH v2 4/4] drivers: mlx5 use rte thread set name

2022-12-14 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 14 December 2022 17.47 > > Use the new internal rte_thread_set_name API instead of the now > deprecated rte_thread_setname API. > > Signed-off-by: Tyler Retzlaff > --- Series-acked-by: Morten Brørup

Re: [PATCH 1/2] eal: add missing call marking memory config complete

2022-12-14 Thread Stephen Hemminger
On Mon, 5 Dec 2022 16:39:28 -0800 Tyler Retzlaff wrote: > Memory configuration was not being marked as completed add the missing > call to rte_eal_init() for Windows. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/windows/eal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/l

Re: [PATCH 2/2] test: enable lcores test on Windows

2022-12-14 Thread Stephen Hemminger
On Mon, 5 Dec 2022 16:39:29 -0800 Tyler Retzlaff wrote: > Stop using pthread and convert the test to use EAL thread APIs. Because > the EAL thread APIs provide more than just a stub for thread join on > Windows the tests now pass and need not be skipped. > > Signed-off-by: Tyler Retzlaff This

Re: [RFC PATCH 1/7] telemetry: rename unsigned 64-bit enum value to uint

2022-12-14 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 06:27:24PM +, Bruce Richardson wrote: > For telemetry data, rather than having unsigned 64-bit values and signed > 32-bit values, we want to just have unsigned and signed values, each > stored with the max bit-width i.e. 64-bits. To that end, we rename the > U64 enum ent

Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64

2022-12-14 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 06:27:25PM +, Bruce Richardson wrote: > For future standardization on the "uint" name for unsigned values rather > than the existing "u64" one, we can for now: > * rename all internal values to use uint rather than u64 > * add new function names to alias the existing u64

Re: [RFC PATCH 4/7] telemetry: make array initialization more robust

2022-12-14 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 06:27:27PM +, Bruce Richardson wrote: > Rather than relying on a specific ordering of elements in the array > matching that of elements in the enum definition, we can explicitly mark > each array entry using the equivalent enum value as an index. > > Signed-off-by: Bruc

Re: [RFC PATCH 7/7] telemetry: change public API to use 64-bit signed values

2022-12-14 Thread Tyler Retzlaff
On Tue, Dec 13, 2022 at 09:19:45PM +0100, Morten Brørup wrote: > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, 13 December 2022 19.28 > > > > While the unsigned values added to telemetry dicts/arrays were up to > > 64-bits in size, the sized values were only up to

Re: [PATCH] ci: drop Travis configuration

2022-12-14 Thread Aaron Conole
David Marchand writes: > We stopped using Travis in the main branch and in the public CI in favor > of GHA more than a year ago. > The UNH community lab now covers testing native compilation and unit > tests for ARM platforms. > > We decided to stop maintaining the configuration in our repository

Re: [PATCH 2/8] net/ring: build on Windows

2022-12-14 Thread Kadam, Pallavi
Hi Stephen, Thanks for enabling this support. On 11/30/2022 5:44 PM, Stephen Hemminger wrote: This driver builds ok on windows, but need to modify the test meson build to skip the eventdev test on Windows. Signed-off-by: Stephen Hemminger --- There is still a build error with clang compiler

[PATCH v1 0/3] bbdev: remove offload cost

2022-12-14 Thread Nicolas Chautru
Removing the optional build flag RTE_BBDEV_OFFLOAD_COST from Intel baseband PMDs and bbdev-test application. This helps to simplify build variants complexity causing compilation issues to be missed. Maxime, the first commit is actually a miss related to last commit on top of tree, you may want to

[PATCH v1 1/3] test/bbdev: explicit check for allocation failure

2022-12-14 Thread Nicolas Chautru
Adding check for error on return of the rte_bbdev_*_op_alloc_bulk calls in bbdev-test. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH v1 2/3] drivers/baseband: remove offload cost optional build flag

2022-12-14 Thread Nicolas Chautru
Remove the optional build flag for intel PMDs so that it is enabled by default and having to maintain single build variant. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 12 +--- drivers/baseband/acc/rte_acc100_pmd.c | 2 - drivers/baseband/acc/rte_a

[PATCH v1 3/3] app/bbdev-test: remove offload cost optional build flag

2022-12-14 Thread Nicolas Chautru
Remove the optional build flag for bbdev-test application so that it is enabled by default and having to maintain single build variant. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/app/test-bbdev/t

Re: [PATCH V5 5/8] mem: possible data truncation and conversion error

2022-12-14 Thread lihuisong (C)
在 2022/12/14 21:00, Morten Brørup 写道: From: Huisong Li [mailto:lihuis...@huawei.com] Sent: Wednesday, 14 December 2022 13.33 The 'u32' and 'u64' data can not assigned to 'int' type variable. They need to use the 'u64' APIs to add. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dp

Re: [PATCH V5 6/8] telemetry: support adding integer value as hexadecimal

2022-12-14 Thread lihuisong (C)
在 2022/12/14 23:38, Bruce Richardson 写道: On Wed, Dec 14, 2022 at 08:32:51PM +0800, Huisong Li wrote: Sometimes displaying a unsigned integer value as hexadecimal encoded style is more expected for human consumption, such as, offload capability and device flag. This patch introduces two APIs to

[PATCH 0/2] net/hns3: support rule keep capability

2022-12-14 Thread Chengwen Feng
This patch declare the hns3 PMD supports rule keep capability, and also add "--disable-flow-flush" parameter to test for such capability. Chengwen Feng (2): net/hns3: declare support rule keep capability app/testpmd: add disable-flow-flush parameter app/test-pmd/parameters.c | 4

[PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2022-12-14 Thread Chengwen Feng
This patch adds "--disable-flow-flush" parameter, which could used to disable port flow flush when stop port. It allows testing keep flow rules or shared flow objects across restart. Signed-off-by: Chengwen Feng --- app/test-pmd/parameters.c | 4 app/test-pmd/testpmd.c

[PATCH 1/2] net/hns3: declare support rule keep capability

2022-12-14 Thread Chengwen Feng
The driver supports create flow rules when device is stopped, and re-setup flow rules when restarting, so declare support RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP. The driver also supports to create indirect actions when device is stopped, and keeps the indirect actions when restarting, so declare support

Re: [RFC PATCH 2/7] telemetry: add uint type as alias for u64

2022-12-14 Thread lihuisong (C)
在 2022/12/14 2:27, Bruce Richardson 写道: For future standardization on the "uint" name for unsigned values rather than the existing "u64" one, we can for now: * rename all internal values to use uint rather than u64 * add new function names to alias the existing u64 ones Suggested-by: Morten Br

Re: [PATCH 1/2] net/hns3: declare support rule keep capability

2022-12-14 Thread Dongdong Liu
Acked-by: Dongdong Liu Thanks, Dongdong On 2022/12/15 9:41, Chengwen Feng wrote: The driver supports create flow rules when device is stopped, and re-setup flow rules when restarting, so declare support RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP. The driver also supports to create indirect actions when

Re: [RFC PATCH 7/7] telemetry: change public API to use 64-bit signed values

2022-12-14 Thread lihuisong (C)
在 2022/12/15 1:53, Tyler Retzlaff 写道: On Tue, Dec 13, 2022 at 09:19:45PM +0100, Morten Brørup wrote: From: Bruce Richardson [mailto:bruce.richard...@intel.com] Sent: Tuesday, 13 December 2022 19.28 While the unsigned values added to telemetry dicts/arrays were up to 64-bits in size, the sized

Re: [PATCH 2/8] net/ring: build on Windows

2022-12-14 Thread Stephen Hemminger
On Wed, 14 Dec 2022 15:18:08 -0800 "Kadam, Pallavi" wrote: > Hi Stephen, > > Thanks for enabling this support. > > On 11/30/2022 5:44 PM, Stephen Hemminger wrote: > > This driver builds ok on windows, but need to modify the > > test meson build to skip the eventdev test on Windows. > > > > Sign

RE: 21.11.3 patches review and test

2022-12-14 Thread Jiang, YuX
Hi All, Update the test status for Intel part. dpdk21.11.3-rc1 validation test is almost finished, no critical issue is found. Total find 3 bugs, 2 bugs are fixed on latest stable 21.11. BUG1: vf_interrupt_pmd/nic_interrupt_VF_vfio_pci: l3fwd-power Wake up failed on X722 37d0 - Find on D

[PATCH] examples/ipsec-secgw: set AES-CTR IV length to 16

2022-12-14 Thread Tejasree Kondoj
Set AES-CTR IV length as 16 instead of taking from SA config option since the application populates 16B IV in the datapath. AES-CTR requires 16B IV constructed from nonce and counter. Signed-off-by: Tejasree Kondoj --- examples/ipsec-secgw/sa.c | 7 ++- 1 file changed, 6 insertions(+), 1 del

[PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices

2022-12-14 Thread Abhishek Maheshwari
Ammending the match table for vdpa/ifcvf driver to work with virtio-blk devices that have default subsystem IDs. Cc: sta...@dpdk.org Signed-off-by: Abhishek Maheshwari --- v3: * Removing match with ANY_IDs * Adding support for only default subsystem IDs v2: * commit message update --- drivers

[PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices

2022-12-14 Thread Abhishek Maheshwari
Amending the match table for vdpa/ifcvf driver to work with virtio-blk devices that have default subsystem IDs. Cc: sta...@dpdk.org Signed-off-by: Abhishek Maheshwari --- v3: * Removing match with ANY_IDs * Adding support for only default subsystem IDs v2: * commit message update --- drivers/

[PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

2022-12-14 Thread Tejasree Kondoj
Set AES-CTR IV length as 16 instead of taking from SA config option since the application populates 16B IV in the datapath. AES-CTR requires 16B IV constructed from nonce and counter. Signed-off-by: Tejasree Kondoj --- v2: * Rebased v1 examples/ipsec-secgw/sa.c | 7 ++- 1 file changed, 6 i

Re: [PATCH v3 1/4] ethdev: add trace points

2022-12-14 Thread Jerin Jacob
On Wed, Dec 14, 2022 at 5:40 PM Ferruh Yigit wrote: > > On 12/14/2022 10:40 AM, Jerin Jacob wrote: > > On Wed, Dec 14, 2022 at 1:37 AM Ferruh Yigit wrote: > >> > >> On 10/6/2022 4:18 PM, Ankur Dwivedi wrote: > >> > >> Hi Ankur, Jerin, > > > > Hi Ferruh, Please find answers to generic trace questi

RE: [PATCH V5 5/8] mem: possible data truncation and conversion error

2022-12-14 Thread Morten Brørup
> From: lihuisong (C) [mailto:lihuis...@huawei.com] > Sent: Thursday, 15 December 2022 02.12 > > 在 2022/12/14 21:00, Morten Brørup 写道: > >> From: Huisong Li [mailto:lihuis...@huawei.com] > >> Sent: Wednesday, 14 December 2022 13.33 > >> > >> --- a/lib/eal/common/eal_common_memory.c > >> +++ b/lib/

Re: [PATCH V5 5/8] mem: possible data truncation and conversion error

2022-12-14 Thread lihuisong (C)
在 2022/12/15 15:04, Morten Brørup 写道: From: lihuisong (C) [mailto:lihuis...@huawei.com] Sent: Thursday, 15 December 2022 02.12 在 2022/12/14 21:00, Morten Brørup 写道: From: Huisong Li [mailto:lihuis...@huawei.com] Sent: Wednesday, 14 December 2022 13.33 --- a/lib/eal/common/eal_common_memory.c