After the memzone is freed, it is not removed from the 'rte_ring_tailq'.
If rte_ring_lookup is called at this time, it will cause a use-after-free
problem. This change prevents that from happening.
Fixes: 4e32101f9b01 ("ring: support freeing")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
Acke
> -Original Message-
> From: Xu, HailinX
> Sent: Thursday, April 27, 2023 4:10 PM
> To: Xueming Li ; sta...@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe ;
> Ali Alnubani ; Walker, Benjamin
> ; David Christensen ;
> Hemant Agrawal ; Stokes, Ian
> ; Jerin Jacob ; Mcnamara, John
> ; Ju-Hyoun
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com;
> amore...
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com;
> amore...
> -Original Message-
> From: Maxime Coquelin
> Sent: Friday, March 31, 2023 11:43 PM
> To: dev@dpdk.org; david.march...@redhat.com; Xia, Chenbo
> ; m...@redhat.com; f...@redhat.com;
> jasow...@redhat.com; Liang, Cunming ; Xie, Yongji
> ; echau...@redhat.com; epere...@redhat.com;
> amore...
On Thu, Apr 20, 2023 at 10:59 AM wrote:
>
> From: Kiran Kumar K
>
> Adding support for send queue flow matching item.
To be consistent, use Tx queue every where.(git commit subject too)
> This item is valid only for egress rules.
> An example use case would be that application can
> set differe
Hi Qi,
On Thur, May 4, 2023 at 9:33PM, Zhang, Qi Z wrote:
-Original Message-
From: Morten Brørup
Sent: Thursday, May 4, 2023 9:22 PM
To: zhoumin ; Konstantin Ananyev
Cc: dev@dpdk.org; maob...@loongson.cn; Yang, Qiming
; Wu, Wenjun1 ;
ruifeng.w...@arm.com; d...@linux.vnet.ibm.com; Tyl
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, March 27, 2023 8:38 PM
> To: Deng, KaiwenX ; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX
> ; Chas Williams ; Min Hu (Connor)
> ; Wu, Jingjing ; Xing, Beilei
> ; Mike Pattrick ; Zhang, Qi Z
> ; Doherty, Declan
This patch enables the watchdog to detect VF FLR when the link state
changes to down, and the default period is 2000us as defined by
IAVF_DEV_WATCHDOG_PERIOD.
In addition, the 'watchdog_period' devargs was added to adjust the watchdog
period(microseconds), or set to 0 to disable the watchdog.
Sig
Add maintainers from Google for GVE.
Signed-off-by: Junfeng Guo
Signed-off-by: Jeroen de Borst
Signed-off-by: Rushil Gupta
Signed-off-by: Joshua Washington
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8df23e5099..08001751b0 100644
---
> -Original Message-
> From: Ferruh Yigit
> Sent: Thursday, May 4, 2023 19:01
> To: Guo, Junfeng ; Zhang, Qi Z
> ; Wu, Jingjing ; Xing,
> Beilei
> Cc: dev@dpdk.org; Rushil Gupta ; Jeroen de Borst
> ; Joshua Washington
> Subject: Re: [PATCH 09/10] net/gve: add maintainers for GVE
>
> O
> -Original Message-
> From: Pavan Nikhilesh Bhagavatula
> Sent: Thursday, April 27, 2023 11:03 PM
> To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob
> Kollanukkaran ; Kiran Kumar Kokkilagadda
> ; Nithin Kumar Dabilpuram
> ; step...@networkplumber.org
> Cc: Liang, Cunming ; Wang, Haiyue
>
>
> -Original Message-
> From: Pavan Nikhilesh Bhagavatula
> Sent: Thursday, April 27, 2023 10:53 PM
> To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob
> Kollanukkaran ; Kiran Kumar Kokkilagadda
> ; Nithin Kumar Dabilpuram
> ; step...@networkplumber.org
> Cc: Liang, Cunming ; Wang, Haiyue
>
>
> -Original Message-
> From: Pavan Nikhilesh Bhagavatula
> Sent: Thursday, April 27, 2023 10:59 PM
> To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob
> Kollanukkaran ; Kiran Kumar Kokkilagadda
> ; Nithin Kumar Dabilpuram
> ; step...@networkplumber.org
> Cc: Liang, Cunming ; Wang, Haiyue
>
>
> -Original Message-
> From: Pavan Nikhilesh Bhagavatula
> Sent: Thursday, April 27, 2023 10:11 PM
> To: Yan, Zhirun ; dev@dpdk.org; Jerin Jacob
> Kollanukkaran ; Kiran Kumar Kokkilagadda
> ; Nithin Kumar Dabilpuram
> ; step...@networkplumber.org
> Cc: Liang, Cunming ; Wang, Haiyue
>
>
Hi Morten,
On Thur, May 4, 2023 at 9:21PM, Morten Brørup wrote:
From: zhoumin [mailto:zhou...@loongson.cn]
Sent: Thursday, 4 May 2023 15.17
Hi Konstantin,
Thanks for your comments.
On 2023/5/1 下午9:29, Konstantin Ananyev wrote:
Segmentation fault has been observed while running the
ixgbe_rec
Hi Ruifeng,
Thanks for your review.
On Thur, May 4, 2023 at 2:13PM, Ruifeng Wang wrote:
-Original Message-
From: Konstantin Ananyev
Sent: Monday, May 1, 2023 9:29 PM
To: zhou...@loongson.cn
Cc: dev@dpdk.org; maob...@loongson.cn; qiming.y...@intel.com;
wenjun1...@intel.com;
Ruifeng Wan
> -Original Message-
> From: Kevin Traynor
> Sent: Thursday, May 4, 2023 6:11 PM
> To: Xu, HailinX ; sta...@dpdk.org
> Cc: Stokes, Ian ; Mcnamara, John
> ; Luca Boccassi ; Xu, Qian Q
> ; Thomas Monjalon ; Peng,
> Yuan ; Chen, Zhaoyan ;
> dev@dpdk.org
> Subject: Re: 21.11.4 patches review a
> -Original Message-
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com]
> Sent: Thursday, May 4, 2023 7:46 AM
> To: Konstantin Ananyev ; wangyunjian
>
> Cc: dev@dpdk.org; luyicai ; sta...@dpdk.org; nd
> ; nd
> Subject: RE: [dpdk-dev] [PATCH v2] ring: fix use after free i
From: Shuanglin Wang
Avoid submitting hwrm RSS request when rss mode disabled.
On WH+, if rss mode isn't enabled, then there is no rss context.
Submitting HWRM_VNIC_RSS_CFG request to firmware would hit a failure.
The fix is to check the rss context. If no rss context, then don't
submit the hwrm
From: Randy Schacher
Add eCPRI parsing and offload support in the TruFlow ULP layer.
Signed-off-by: Randy Schacher
Signed-off-by: Shahaji Bhosle
Reviewed-by: Manish Kurup
Reviewed-by: Ajit Khaparde
---
.mailmap | 1 +
doc/guides/nics/features/bnxt.ini
From: Kishore Padmanabha
Changed the logic to use device serial number to identify that
different ports belong to same physical card instead of the PCI
domain address.
Fixes: 34a7ff5a920e ("net/bnxt: support multi root capability")
Cc: sta...@dpdk.org
Signed-off-by: Kishore Padmanabha
Reviewed
From: Somnath Kotur
add locking and time stamp checks to ptp feature
Signed-off-by: Somnath Kotur
Signed-off-by: Randy Schacher
Reviewed-by: Kalesh AP
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h| 5
drivers/net/bnxt/bnxt_ethdev.c | 11 +
drivers/net/bnxt/bnx
From: Randy Schacher
Add RTE meter support into the ULP layer.
Currently:
- Chaining of meters is not supported
- Meter can be shared by multiple flows
- srtcm_rfc2697 type is supported
- Stats are not supported in the implementation yet
Signed-off-by: Randy Schacher
Signed-off-by: Jay Ding
Ac
From: Randy Schacher
Update the Copyright to 2023
Clean up extra blank lines
Clean up other whitespace issues
Signed-off-by: Randy Schacher
Reviewed-by: Kishore Padmanabha
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_cpr.c| 2 +-
drivers/net/bnxt/bnxt_cpr.h
From: Randy Schacher
- Deprecate shadow identifier
- Deprecate shadow TCAM
- Remove files which are not needed anymore.
Signed-off-by: Randy Schacher
Signed-off-by: Kishore Padmanabha
Reviewed-by: Peter Spreadborough
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c
Update Truflow support to latest release, deprecating code, updating
the copyright date and hsi structure, syncing the truflow core,
adding ULP shared session support, RSS action support, Queue
action support, rte meter support, and more.
Please apply.
v2->v3:
- update some commit messages
- remo
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
>
> On Thu, 4 May 2023 16:11:31 +
> "Coyle, David" wrote:
>
> > Hi Morten
> >
> > > -Original Message-
> > > From: Morten Brørup
> > >
> >
> >
> >
> > > Power saving is important for the envi
On Thu, 4 May 2023 10:24:45 +
"Mcnamara, John" wrote:
> Release status meeting minutes 2023-05-04
> =
>
> Agenda:
> * Release Dates
> * Subtrees
> * Roadmaps
> * LTS
> * Defects
> * Opens
>
> Participants:
> * AMD
> * ARM
> * Intel
> * Marvell
> * Nvi
https://bugs.dpdk.org/show_bug.cgi?id=1225
Stephen Hemminger (step...@networkplumber.org) changed:
What|Removed |Added
CC||step...@networkpl
On Thu, 4 May 2023 16:11:31 +
"Coyle, David" wrote:
> Hi Morten
>
> > -Original Message-
> > From: Morten Brørup
> >
>
>
>
> > Power saving is important for the environment (to save the planet and all
> > that), so everyone should contribute, if they have a good solution. So e
Hi Morten
> -Original Message-
> From: Morten Brørup
>
> Power saving is important for the environment (to save the planet and all
> that), so everyone should contribute, if they have a good solution. So even if
> our algorithm had a significant degree of innovation, we would probably
On 4/21/2023 3:54 PM, Nipun Gupta wrote:
> Adding support for AMD CDX devices
>
> Signed-off-by: Nipun Gupta
> ---
> config/arm/arm64_cdx_linux_gcc | 17 +
> config/arm/meson.build | 14 ++
> 2 files changed, 31 insertions(+)
> create mode 100644 config/arm/a
On Thu, May 04, 2023 at 09:48:59AM +0100, Bruce Richardson wrote:
> On Thu, May 04, 2023 at 09:50:09AM +0200, Mattias Rönnblom wrote:
> > On 2023-05-03 19:30, Bruce Richardson wrote:
> > > Add a deprecation notice informing users that we will require a C11
> > > compiler from 23.11 release onwards.
On 2023/05/04 18:43, Ruifeng Wang wrote:
-Original Message-
From: Akihiko Odaki
Sent: Thursday, May 4, 2023 3:47 PM
To: Ruifeng Wang ; Bruce Richardson
;
Juraj Linkeš
Cc: dev@dpdk.org; nd
Subject: Re: [PATCH 1/2] config/arm: Do not require processor information
On 2023/04/20 16:12, A
On 4/26/2023 10:37 PM, Rushil Gupta wrote:
> Change gve_driver_info fields to report DPDK as OS type and DPDK RTE
> version as OS version, reserving driver_version fields for GVE driver
> version based on features.
>
'./devtools/check-git-log.sh' is giving some warnings, can you please
check them
> -Original Message-
> From: Morten Brørup
> Sent: Thursday, May 4, 2023 9:22 PM
> To: zhoumin ; Konstantin Ananyev
>
> Cc: dev@dpdk.org; maob...@loongson.cn; Yang, Qiming
> ; Wu, Wenjun1 ;
> ruifeng.w...@arm.com; d...@linux.vnet.ibm.com; Tyler Retzlaff
>
> Subject: RE: [PATCH v2] net/
> -Original Message-
> From: Min Zhou
> Sent: Friday, April 28, 2023 4:43 PM
> To: Zhang, Qi Z ; Yang, Qiming
> ; Wu, Wenjun1 ;
> zhou...@loongson.cn
> Cc: dev@dpdk.org; maob...@loongson.cn
> Subject: [PATCH v2] net/ixgbe: consider DCB/VMDq conf when getting RSS
> conf
>
> The mrqe fie
> From: zhoumin [mailto:zhou...@loongson.cn]
> Sent: Thursday, 4 May 2023 15.17
>
> Hi Konstantin,
>
> Thanks for your comments.
>
> On 2023/5/1 下午9:29, Konstantin Ananyev wrote:
> >> Segmentation fault has been observed while running the
> >> ixgbe_recv_pkts_lro() function to receive packets o
Hi Konstantin,
Thanks for your comments.
On 2023/5/1 下午9:29, Konstantin Ananyev wrote:
Segmentation fault has been observed while running the
ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000
processor which has 64 cores and 4 NUMA nodes.
From the ixgbe_recv_pkts_lro()
Hi Morten,
Thanks for your comments.
On Fri, Apr 28, 2023 at 2:27PM, Morten Brørup wrote:
From: Zhang, Qi Z [mailto:qi.z.zh...@intel.com]
Sent: Friday, 28 April 2023 05.44
From: Min Zhou
Sent: Monday, April 24, 2023 5:06 PM
Segmentation fault has been observed while running the
ixgbe_recv_p
On Thu, May 04, 2023 at 02:37:48PM +0200, Juraj Linkeš wrote:
> The tool used to generate developer docs is sphinx, which is already
> used in DPDK. The configuration is kept the same to preserve the style.
>
> Sphinx generates the documentation from Python docstrings. The docstring
> format most
Hi Qi,
Thanks for your review.
On Fri, Apr 28, 2023 at 11:43AM, Zhang, Qi Z wrote:
-Original Message-
From: Min Zhou
Sent: Monday, April 24, 2023 5:06 PM
To: Yang, Qiming ; Wu, Wenjun1
; zhou...@loongson.cn
Cc: dev@dpdk.org; maob...@loongson.cn
Subject: [PATCH v2] net/ixgbe: add prop
WIP: only one module is reformatted to serve as a demonstration.
The google format is documented here [0].
[0]: https://google.github.io/styleguide/pyguide.html
Signed-off-by: Juraj Linkeš
---
dts/framework/testbed_model/node.py | 152 +++-
1 file changed, 103 insertion
The tool used to generate developer docs is sphinx, which is already
used in DPDK. The configuration is kept the same to preserve the style.
Sphinx generates the documentation from Python docstrings. The docstring
format most suitable for DTS seems to be the Google format [0] which
requires the sp
Sphinx imports every Python module when generating documentation from
docstrings, meaning all dts dependencies, including Python version,
must be satisfied.
By adding Sphinx to dts dependencies we make sure that the proper
Python version and dependencies are used when Sphinx is executed.
Signed-of
sphinx-build only imports the Python modules when building the
documentation; it doesn't run DTS. This requires changes that make the
code importable without running it. This means:
* properly guarding argument parsing in the if __name__ == '__main__'
block.
* the logger used by DTS runner underw
Augment the meson build system with dts api generation. The api docs are
generated from Python docstrings in DTS using Sphinx. The format of
choice is the Google format [0].
The guide html sphinx configuration is used to preserve the same style.
The build requires the same Python version and depe
On 4/13/2023 7:16 AM, Junfeng Guo wrote:
> Add maintainers from Google for GVE.
>
> Signed-off-by: Junfeng Guo
> Signed-off-by: Rushil Gupta
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8df23e5099..08001751b0 100644
> --- a/M
On 4/13/2023 7:16 AM, Junfeng Guo wrote:
> This patch set includs two main enhancements for gve PMD:
> - support basic data path with DQO queue format
> - support jumbo frame with GQI queue format
>
> This patch set is based on this:
> patchwork.dpdk.org/project/dpdk/list/?series=27653&state=*
>
Release status meeting minutes 2023-05-04
=
Agenda:
* Release Dates
* Subtrees
* Roadmaps
* LTS
* Defects
* Opens
Participants:
* AMD
* ARM
* Intel
* Marvell
* Nvidia
* Red Hat
Release Dates
-
The following are the proposed current dates for
On 04/05/2023 03:13, Xu, HailinX wrote:
-Original Message-
From: Kevin Traynor
Sent: Tuesday, May 2, 2023 5:35 PM
To: Xu, HailinX ; sta...@dpdk.org
Cc: Stokes, Ian ; Mcnamara, John
; Luca Boccassi ; Xu, Qian Q
; Thomas Monjalon ; Peng,
Yuan ; Chen, Zhaoyan ;
dev@dpdk.org
Subject: Re: 21.
> -Original Message-
> From: Akihiko Odaki
> Sent: Thursday, May 4, 2023 3:47 PM
> To: Ruifeng Wang ; Bruce Richardson
> ;
> Juraj Linkeš
> Cc: dev@dpdk.org; nd
> Subject: Re: [PATCH 1/2] config/arm: Do not require processor information
>
> On 2023/04/20 16:12, Akihiko Odaki wrote:
> >
> -Original Message-
> From: jer...@marvell.com
> Sent: Thursday, May 4, 2023 16:54
> To: dev@dpdk.org; Wu, Jingjing ; Guo, Junfeng
> ; Li, Xiaoyun
> Cc: tho...@monjalon.net; david.march...@redhat.com;
> ferruh.yi...@amd.com; Jerin Jacob ;
> sta...@dpdk.org; Ali Alnubani
> Subject: [d
From: Jerin Jacob
Fix the following build issue by not allowing nb_ids to be zero.
nb_ids can be zero based on rte_rawdev_xstats_get() API
documentation but it is not valid for the case when second
argument is NULL.
examples/ntb/ntb_fwd.c: In function 'ntb_stats_display':
examples/ntb/ntb_fwd.c:
On Thu, May 04, 2023 at 09:50:09AM +0200, Mattias Rönnblom wrote:
> On 2023-05-03 19:30, Bruce Richardson wrote:
> > Add a deprecation notice informing users that we will require a C11
> > compiler from 23.11 release onwards. This requirement was agreed by
> > technical board to enable use of newer
On Thu, May 4, 2023 at 2:06 PM Guo, Junfeng wrote:
>
>
>
> > -Original Message-
> > From: jer...@marvell.com
> > Sent: Tuesday, May 2, 2023 21:51
> > To: dev@dpdk.org; Wu, Jingjing ; Guo, Junfeng
> > ; Li, Xiaoyun
> > Cc: tho...@monjalon.net; david.march...@redhat.com;
> > ferruh.yi...@x
> -Original Message-
> From: jer...@marvell.com
> Sent: Tuesday, May 2, 2023 21:51
> To: dev@dpdk.org; Wu, Jingjing ; Guo, Junfeng
> ; Li, Xiaoyun
> Cc: tho...@monjalon.net; david.march...@redhat.com;
> ferruh.yi...@xilinx.com; step...@networkplumber.org; Jerin Jacob
> ; sta...@dpdk.or
On 4/11/2023 5:59 AM, Rushil Gupta wrote:
> Update gve base code to support DQO.
>
> This patch is based on this:
> https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
>
> Signed-off-by: Rushil Gupta
> Signed-off-by: Junfeng Guo
Applied to dpdk-next-net/main, thanks.
On 4/10/2023 7:47 AM, Junfeng Guo wrote:
> Add struct members for gve_tx_queue and gve_rx_queue.
> Add typedefs for little endians.
>
> Signed-off-by: Junfeng Guo
> Signed-off-by: Rushil Gupta
> Signed-off-by: Joshua Washington
> Signed-off-by: Jeroen de Borst
Applied to dpdk-next-net/main, t
Hello Tomasz,
On Thu, Feb 16, 2023 at 6:55 PM Tomasz Duszynski wrote:
>
> This series adds self monitoring support i.e allows to configure and
> read performance measurement unit (PMU) counters in runtime without
> using perf utility. This has certain advantages when application runs on
> isolate
-Original Message-
From: Bruce Richardson
Sent: Wednesday, May 3, 2023 11:18 AM
To: Gilbert Carrillo
Cc: dev@dpdk.org
Subject: Re: DPDK 22.11 Troubleshooting
On Wed, May 03, 2023 at 04:53:20PM +, Gilbert Carrillo wrote:
> Make static returns an error (see attached).
>
> v/R,
> G
Make static returns an error (see attached).
v/R,
Gilbert
-Original Message-
From: Bruce Richardson
Sent: Wednesday, May 3, 2023 10:35 AM
To: Gilbert Carrillo
Cc: dev@dpdk.org
Subject: Re: DPDK 22.11 Troubleshooting
On Wed, May 03, 2023 at 04:22:05PM +, Gilbert Carrillo wrote:
> H
Hi Bruce,
Thank you for the response.
There is no errors when I run the makefile, however I do see a difference in
the programs. I don't believe the makefile is linking all the libraries
together as intended.
For example, when I run the ethtool sample program and compile it using meson,
it w
On 2023-05-03 19:30, Bruce Richardson wrote:
Add a deprecation notice informing users that we will require a C11
compiler from 23.11 release onwards. This requirement was agreed by
technical board to enable use of newer C language features, e.g.
standard atomics. [1]
[1]
http://inbox.dpdk.org/d
On 5/4/2023 8:13 AM, Denis Pryazhennikov wrote:
> I think my patch isn't correct.
> I would say that
> - fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()';
> - fec_mode is an element of 'enum rte_eth_fec_mode'.
>
> Based on this definition, replacing 'fec_capa' with 'fec_mode' sho
On 2023/04/20 16:12, Akihiko Odaki wrote:
On 2023/04/20 16:10, Ruifeng Wang wrote:
-Original Message-
From: Akihiko Odaki
Sent: Thursday, April 20, 2023 9:40 AM
To: Ruifeng Wang ; Bruce Richardson
;
Juraj Linkeš
Cc: dev@dpdk.org; nd
Subject: Re: [PATCH 1/2] config/arm: Do not requir
On 2023-05-02 11:54, Sachin Saxena (OSS) wrote:
From: Stephen Hemminger
Using system() is a bad idea in driver code because it introduces
a number of potential security issues. The codeql analysis tool
flags this a potential security issue.
Instead just use normal stdio to do the same
Hello Ophir,
Good thing someone is looking into this.
Thanks.
I have a few comments.
This commitlog is a bit compact.
Separating it with some empty lines would help digest it.
On Wed, May 3, 2023 at 9:27 AM Ophir Munk wrote:
>
> In current DPDK the RTE_MAX_MEMZONE definition is unconditional
I think my patch isn't correct.
I would say that
- fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()';
- fec_mode is an element of 'enum rte_eth_fec_mode'.
Based on this definition, replacing 'fec_capa' with 'fec_mode' should
involve changing the parameter type.
Probably I should
74 matches
Mail list logo
