[PATCH] net/ice: fix timestamp enable error

2023-05-18 Thread Wenjing Qiao
Use the following command: 1. dpdk-testpmd -c 0x3 -n 4 --force-max-simd-bitwidth=64 -- -i --enable-rx-timestamp 2. port stop 0 3. port config 0 rx_offload timestamp off 4. port start 0 Then start it, log will show timestamp info, which should not appear. Because ice_timestamp_dynflag is still mo

[PATCH] doc: announce inclusive naming function name changes

2023-05-18 Thread Chaoyong He
In order to support inclusive naming, some of the functions in DPDK will need to be renamed. Do this through deprecation process now for 23.07. Signed-off-by: Chaoyong He --- doc/guides/rel_notes/deprecation.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/rel_not

RE: [PATCH 06/10] net/cpfl: support hairpin queue configuration

2023-05-18 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Monday, April 24, 2023 5:48 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Wang, Xiao W > Subject: RE: [PATCH 06/10] net/cpfl: support hairpin queue configuration > > > > > -Original Message- > > From: Xing, Beilei

RE: [PATCH 04/10] net/cpfl: add haipin queue group during vpotr init

2023-05-18 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Monday, April 24, 2023 4:55 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH 04/10] net/cpfl: add haipin queue group during vpotr init > > > > > -Original Message- > > From: Xing, Beilei > > Sent

RE: [PATCH 03/10] common/idpf: support queue groups add/delete

2023-05-18 Thread Xing, Beilei
> -Original Message- > From: Liu, Mingxia > Sent: Monday, April 24, 2023 4:50 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH 03/10] common/idpf: support queue groups add/delete > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Frid

[PATCH v2 10/10] net/cpfl: support hairpin bind/unbind

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch supports hairpin_bind/unbind ops. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 137 + drivers/net/cpfl/cpfl_rxtx.c | 28 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 + 3 files changed,

[PATCH v2 09/10] net/cpfl: support peer ports get

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch supports get hairpin peer ports. Signed-off-by: Xiao Wang Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_e

[PATCH v2 08/10] net/cpfl: enable write back based on ITR expire

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch enabls write back based on ITR expire (WR_ON_ITR) for hairpin queue. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 75 drivers/common/idpf/idpf_common_device.h | 4 ++ drivers/common/

[PATCH v2 07/10] net/cpfl: support hairpin queue start/stop

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue start/stop. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 2 +- drivers/common/idpf/idpf_common_virtchnl.h | 3 + drivers/common/idpf/version.map

[PATCH v2 05/10] net/cpfl: support hairpin queue setup and release

2023-05-18 Thread beilei . xing
From: Beilei Xing Support hairpin Rx/Tx queue setup and release. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 6 + drivers/net/cpfl/cpfl_ethdev.h | 12 + drivers/net/cpfl/cpfl_rxtx.c| 373

[PATCH v2 06/10] net/cpfl: support hairpin queue configuration

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch supports Rx/Tx hairpin queue configuration. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 70 +++ drivers/common/idpf/idpf_common_virtchnl.h | 6 + drivers/common/idpf/ve

[PATCH v2 04/10] net/cpfl: add haipin queue group during vpotr init

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vpotr init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 130 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files

[PATCH v2 04/10] net/cpfl: add haipin queue group during vport init

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch adds haipin queue group during vport init. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 130 + drivers/net/cpfl/cpfl_ethdev.h | 18 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files

[PATCH v2 03/10] common/idpf: support queue groups add/delete

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch adds queue group add/delete virtual channel support. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_virtchnl.c | 66 ++ drivers/common/idpf/idpf_common_virtchnl.h | 9 +++ drivers/common/idpf/version.

[PATCH v2 02/10] net/cpfl: support hairpin queue capbility get

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch adds hairpin_cap_get ops support. Signed-off-by: Xiao Wang Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 13 + drivers/net/cpfl/cpfl_rxtx.h | 4 2 files changed, 17 insertions(+) diff --git a/drive

[PATCH v2 01/10] net/cpfl: refine structures

2023-05-18 Thread beilei . xing
From: Beilei Xing This patch refines some structures to support hairpin queue, cpfl_rx_queue/cpfl_tx_queue/cpfl_vport. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/net/cpfl/cpfl_ethdev.c | 85 +++- drivers/net/cpfl/cpfl_ethdev.h | 6 +- driver

[PATCH v2 00/10] add hairpin queue support

2023-05-18 Thread beilei . xing
From: Beilei Xing This patchset adds hairpin queue support. v2 changes: - change hairpin rx queus configuration sequence. - code refine. Beilei Xing (10): net/cpfl: refine structures net/cpfl: support hairpin queue capbility get common/idpf: support queue groups add/delete net/cpfl: a

RE: [EXT] [PATCH] ethdev: fix asynchronous destroy and push tracepoints

2023-05-18 Thread Ankur Dwivedi
>The rte_flow_async_destroy() and rte_flow_push() API is intended to be as >fast as possible and tracepoints for these functions must be marked as fast- >path tracepoints. > >Fixes: 6679cf21d608 ("ethdev: add trace points") > >Signed-off-by: Alexander Kozyrev Acked-by: Ankur Dwivedi >--- > lib/e

[PATCH 4/4] test/malloc: fix case expectation

2023-05-18 Thread Ruifeng Wang
The case expects all stats to be equal. Therefor the conditions in check should be logically or'ed. Fixes: a40a1f8231b4 ("app: various tests update") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- app/test/test_malloc.c | 20 ++-- 1 file changed, 1

[PATCH 3/4] test/malloc: fix missing free

2023-05-18 Thread Ruifeng Wang
Free the allocated buffer before returning. Fixes: a40a1f8231b4 ("app: various tests update") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- app/test/test_malloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c

[PATCH 2/4] eal: simplify check condition

2023-05-18 Thread Ruifeng Wang
The alt_elem is initialized to null. Checking only size hint flag is sufficient to return a proper value. Removed the redundant check. Signed-off-by: Ruifeng Wang Reviewed-by: Feifei Wang --- lib/eal/common/malloc_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ea

[PATCH 1/4] eal: fix list index for 256 byte element

2023-05-18 Thread Ruifeng Wang
Elements with 2^8B size should fall into index 1 of the list. Fixes: f62f4a375ff4 ("malloc: optimize 4K allocations") Cc: changfeng...@bytedance.com Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang --- lib/eal/common/malloc_elem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/4] Heap library and test case changes

2023-05-18 Thread Ruifeng Wang
This series fixed a heap free list management issue which was captured by unit test failure. It also includes fixes of the unit test. Ruifeng Wang (4): eal: fix list index for 256 byte element eal: simplify check condition test/malloc: fix missing free test/malloc: fix case expectation a

[dpdk-dev] [PATCH 2/2] net/cnxk: support Tx queue flow pattern item

2023-05-18 Thread psatheesh
From: Satheesh Paul Added support for Tx queue flow pattern item. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/net/cnxk/cnxk_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cnxk_flow.c b/drivers/net/cnxk/cnxk_flow.c index f

[dpdk-dev] [PATCH 1/2] common/cnxk: support Tx queue flow pattern in ROC API

2023-05-18 Thread psatheesh
From: Satheesh Paul Added ROC API changes to support Tx queue flow pattern item. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- Depends-on: series-28056 ("ethdev: add Tx queue flow matching item") drivers/common/cnxk/roc_npc.c | 16 +--- drivers/common/cnxk/roc_npc.h

[PATCH V9] ethdev: fix one address occupies two entries in MAC addrs

2023-05-18 Thread Huisong Li
The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by .mac_addr_set(). However, if the new default one has been added as a non-default MAC address by .mac_addr_add(), the .mac_addr_set() didn't check this address. As a result, this MAC

[PATCH 8/8] net/nfp: revise the logic of MAC address

2023-05-18 Thread Chaoyong He
Drop the usage of customed macro and function about MAC address, using the macro and function from framework. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- .../net/nfp/flower/nfp_flower_representor.c| 3 +-- drivers/net/nfp/nfp_common.c | 11 --- dr

[PATCH 7/8] net/nfp: revise cast from void pointer

2023-05-18 Thread Chaoyong He
When cast from void pointer to other pointer type, there is not need to use '()' for force cast. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 20 +++ .../net/nfp/flower/nfp_flower_representor.c | 30 +-- drivers/net/n

[PATCH 6/8] net/nfp: remove the unneeded comment

2023-05-18 Thread Chaoyong He
Remove the unneeded comment at the head and tail of some source files. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c | 15 --- drivers/net/nfp/nfp_common.h | 14 -- drivers/net/nfp/nfp_cpp_bridge.c | 14 --

[PATCH 5/8] net/nfp: remove the custom round macro

2023-05-18 Thread Chaoyong He
Remove the custom round macro, use the macro provide by the DPDK. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 9 + drivers/net/nfp/nfpcore/nfp_rtsym.c | 4 ++-- drivers/net/nfp/nfpcore/nfp_rtsym.h | 19 --- 3 files

[PATCH 3/8] net/nfp: modify the Rx descriptor struct

2023-05-18 Thread Chaoyong He
Modify the struct nfp_net_rx_desc, change the type of the fields, make it meet the DPDK coding style. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/nfp/nfp_rxtx

[PATCH 4/8] net/nfp: modify the txq struct

2023-05-18 Thread Chaoyong He
Modify the struct nfp_net_txq, remove the unused fields, change the type of some fields and make the comment message more suitable. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 7 +-- .../net/nfp/flower/nfp_flower_representor.c

[PATCH 2/8] net/nfp: modify the rxq struct

2023-05-18 Thread Chaoyong He
Modify the struct nfp_net_rxq, remove the unused fields, change the type of some fields and make the comment message more suitable. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 13 ++- drivers/net/nfp/flower/nfp_flower_ctrl.c

[PATCH 1/8] net/nfp: reuse the ring buffer struct

2023-05-18 Thread Chaoyong He
Reuse the ring buffer struct, make the code more readable. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 2 +- drivers/net/nfp/flower/nfp_flower_ctrl.c | 2 +- drivers/net/nfp/nfp_rxtx.c | 4 ++-- drivers/net/nfp/nfp_rxt

[PATCH 0/8] make the logic conform the coding style of DPDK

2023-05-18 Thread Chaoyong He
Modify some logic of nfp PMD, to make it conform the coding style of DPDK. Also remove some unnecessary macro and functions which DPDK has already provided. Chaoyong He (8): net/nfp: reuse the ring buffer struct net/nfp: modify the rxq struct net/nfp: modify the Rx descriptor struct net/n

[PATCH] eal: allow both allow and block options coexistence

2023-05-18 Thread Marvin Liu
Since all buses share the same eal allow and block options. There's a need to allow both allow and block options coexist. At the same time, this wouldn't be a problem if both allow and block options were present on the same bus. The scan mode of a bus will be set when met the first type option. eg

RE: [PATCH] maintainers: add maintainers to Nvidia net mlx5

2023-05-18 Thread Suanming Mou
> -Original Message- > From: Matan Azrad > Sent: Wednesday, May 17, 2023 3:43 PM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) > Cc: dev@dpdk.org > Subject: [PATCH] maintainers: add maintainers to Nvidia net mlx5 > > Add Ori Kam and Suanming Mou to the mainterners list of the Nvidia ne

[PATCH v6] app/testpmd: txonly multiflow port change support

2023-05-18 Thread Joshua Washington
Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow mode to modify source ports instead of source IP ad

[PATCH] ethdev: fix asynchronous destroy and push tracepoints

2023-05-18 Thread Alexander Kozyrev
The rte_flow_async_destroy() and rte_flow_push() API is intended to be as fast as possible and tracepoints for these functions must be marked as fast-path tracepoints. Fixes: 6679cf21d608 ("ethdev: add trace points") Signed-off-by: Alexander Kozyrev --- lib/ethdev/ethdev_trace.h | 42 ++

[PATCH v3] ethdev: add flow rule actions update API

2023-05-18 Thread Alexander Kozyrev
Introduce the new rte_flow_update() API allowing users to update the action list in the already existing rule. Flow rules can be updated now without the need to destroy the rule first and create a new one instead. A single API call ensures that no packets are lost by guaranteeing atomicity and flow

RE: [PATCH] ethdev: add flow rule actions update API

2023-05-18 Thread Alexander Kozyrev
> Hi Alexander, > > Please add rte_flow_trace_xxx for all new functions. Added in v2.

[PATCH v2] ethdev: add flow rule actions update API

2023-05-18 Thread Alexander Kozyrev
Introduce the new rte_flow_update() API allowing users to update the action list in the already existing rule. Flow rules can be updated now without the need to destroy the rule first and create a new one instead. A single API call ensures that no packets are lost by guaranteeing atomicity and flow

RE: [RFC PATCH v3] ethdev: add indirect list flow action

2023-05-18 Thread Gregory Etelson
Hello Ori, > First I'm assuming this is just RFC, since there is no code implementation. > I'll add code implementation in v4. > > -Original Message- > > From: Gregory Etelson > > Sent: Sunday, May 7, 2023 12:51 PM > > > > Indirect API creates a shared flow action with unique action ha

Re: [dpdk-dev] [PATCH 1/1] net/txgbe: fix use-after-free on remove

2023-05-18 Thread Ferruh Yigit
On 5/18/2023 8:46 AM, Jiawen Wu wrote: >> When cleaning up NIC's interrupts, it is possible to add some alarms >> at the same time. However, if these alarms are not canceled, it may >> cause use-after-free problems. Therefore, after cleaning up NIC's >> interrupts, these alarms should also be cance

Re: [v2] net/gve: check driver compatibility

2023-05-18 Thread Rushil Gupta
Thanks for reviewing. Here is v3: http://patchwork.dpdk.org/project/dpdk/patch/20230518174005.1377467-1-rush...@google.com/ On Wed, May 17, 2023 at 9:59 AM Ferruh Yigit wrote: > On 5/8/2023 8:15 PM, Rushil Gupta wrote: > > Change gve_driver_info fields to report DPDK as OS type and DPDK RTE > >

[PATCH v2 5/5] ethdev: add MPLS header modification support

2023-05-18 Thread Michael Baum
Add support for MPLS modify header using "RTE_FLOW_FIELD_MPLS" id. Since MPLS heaser might appear more the one time in inner/outer/tunnel, a new field was added to "rte_flow_action_modify_data" structure in addition to "level" field. The "tag_index" field is the index of the header inside encapsul

[PATCH v2 3/5] doc: fix wrong indentation in RSS action description

2023-05-18 Thread Michael Baum
The RSS action description inside "Generic flow API (rte_flow)" documentation, lists the values supported for a encapsulation level field. For "2" value, it uses 3 spaces as an indentation instead of 2 after line breaking, causing the first line to be bold. This patch updates the number of spaces

[PATCH v2 4/5] ethdev: add GENEVE TLV option modification support

2023-05-18 Thread Michael Baum
Add modify field support for GENEVE option fields: - "RTE_FLOW_FIELD_GENEVE_OPT_TYPE" - "RTE_FLOW_FIELD_GENEVE_OPT_CLASS" - "RTE_FLOW_FIELD_GENEVE_OPT_DATA" Each GENEVE TLV option is identified by both its "class" and "type", so 2 new fields were added to "rte_flow_action_modify_data" structure

[PATCH v2 1/5] doc: fix blank lines in modify field action description

2023-05-18 Thread Michael Baum
The modify field action description inside "Generic flow API (rte_flow)" documentation, lists all operations supported for a destination field. In addition, it lists the values supported for a encapsulation level field. Before the lists, in both cases, miss a blank line causing them to look regula

[PATCH v2 2/5] doc: fix blank line in asynchronous operations description

2023-05-18 Thread Michael Baum
The asynchronous operations description inside "Generic flow API (rte_flow)" documentation, adds some bullets to describe asynchronous operations behavior. Before the first bullet, miss a blank line causing it to look a regular text line. This patch adds the blank line. Fixes: 197e820c6685 ("eth

[PATCH v2 0/5] ethdev: modify field API for multiple headers

2023-05-18 Thread Michael Baum
This patch-set extend the modify field action API to support both multiple MPLS and GENEVE option headers. In current API, the header type is provided by rte_flow_field_id enumeration and the encapsulation level (inner/outer/tunnel) is specified by data.level field. However, there is no way to spe

[v3] net/gve: check driver compatibility

2023-05-18 Thread Rushil Gupta
Change gve_driver_info fields to report DPDK as OS type and DPDK RTE version as OS version, reserving driver_version fields for GVE driver version based on features. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- driv

Re: [PATCH net v2] net/vmxnet3: fix drop of empty segments in tx

2023-05-18 Thread Ferruh Yigit
On 5/9/2023 3:21 AM, Ronak Doshi wrote: > When empty segments are dropped, some descriptor variable values are > updated in the segment processing loop before it is exited. This can > lead to a wedged queue where all subsequent packets are dropped for > this queue. > > Also move the check for empt

Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs

2023-05-18 Thread Ivan Malov
Hi Ferruh, Thanks for reviewing this. PSB. On Thu, 18 May 2023, Ferruh Yigit wrote: On 4/24/2023 3:30 PM, Ivan Malov wrote: When the client driver (the DPDK one, for instance) parses user flow actions, it ends up with an action set specification. Next, in case there are any FW resource-backed

Re: [PATCH v2 01/19] mbuf: replace term sanity check

2023-05-18 Thread Stephen Hemminger
On Thu, 18 May 2023 09:45:28 -0700 Stephen Hemminger wrote: > Replace rte_mbuf_sanity_check() with rte_mbuf_verify() > to match the similar macro RTE_VERIFY() in rte_debug.h > > The term sanity check is on the Tier 2 list of words > that should be replaced. > > Signed-off-by: Stephen Hemminger

Re: [PATCH next] net/vmxnet3: add interrupt handling for reset

2023-05-18 Thread Ferruh Yigit
On 5/9/2023 3:15 AM, Ronak Doshi wrote: > vmxnet3 should call the reset callback when a queue is stopped > by the host. This patch also fixes a logging issue. Currently, > status of only first queue is checked and logged. But status > of all queues should be checked. > > Signed-off-by: Ronak Doshi

[PATCH v2 19/19] Remove use of term sanity check

2023-05-18 Thread Stephen Hemminger
Replace non-inclusive language with better comments. Acked-by: Hemant Agrawal Signed-off-by: Stephen Hemminger --- drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +- drivers/common/dpaax/caamflib/desc.h | 2 +- drivers/dma/idxd/idxd_pci.c | 2 +- drivers/net/bonding/rte_eth_bo

[PATCH v2 18/19] crypto/bcmfs: replace term sanity check

2023-05-18 Thread Stephen Hemminger
Do not use non-inclusive naming here. Signed-off-by: Stephen Hemminger --- drivers/crypto/bcmfs/hw/bcmfs4_rm.c | 6 +++--- drivers/crypto/bcmfs/hw/bcmfs5_rm.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c b/drivers/crypto/bcmfs/hw

[PATCH v2 15/19] event/opdl: remove term sanity

2023-05-18 Thread Stephen Hemminger
Don't use non-inclusive term. Signed-off-by: Stephen Hemminger --- drivers/event/opdl/opdl_evdev.c | 2 +- drivers/event/opdl/opdl_evdev_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index 9ce8

[PATCH v2 17/19] net/cxgbe: remove use of term sanity

2023-05-18 Thread Stephen Hemminger
Remove non-inclusive terminolgy. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++ drivers/net/cxgbe/cxgbevf_main.c | 4 ++-- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c

[PATCH v2 16/19] net/txgbe: replace term sanity

2023-05-18 Thread Stephen Hemminger
Don't use term sanity. Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_ipsec.c | 2 +- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c index f9f8108fb894..cadb094

[PATCH v2 14/19] cnxk: replace term sanity

2023-05-18 Thread Stephen Hemminger
Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_

[PATCH v2 13/19] net/bnx2x: remove reference to sanity

2023-05-18 Thread Stephen Hemminger
Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 drivers/net/bnx2x/ecore_sp.c| 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drive

[PATCH v2 11/19] net/ark: replace use of term sanity

2023-05-18 Thread Stephen Hemminger
Do not use non inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/ark/ark_ethdev.c| 8 drivers/net/ark/ark_ethdev_rx.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c index b2995427c8ca

[PATCH v2 12/19] net/bnxt: replace use of term sanity

2023-05-18 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 51e1e2d6b39b..5370293fed8d 100644 --- a/drivers/net/bnxt/bnxt_hw

[PATCH v2 10/19] net/sfc: remove term "sanity check"

2023-05-18 Thread Stephen Hemminger
Remove term sanity check in comment. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_dp_rx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h index 246adbd87cde..c64db488f652 100644 --- a/drivers/net/sfc/sfc_dp

[PATCH v2 05/19] lib: replace use of sanity check in comments and messages

2023-05-18 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Signed-off-by: Stephen Hemminger --- lib/graph/graph.c | 2 +- lib/graph/graph_stats.c | 2 +- lib/graph/node.c| 2 +- lib/jobstats/rte_jobstats.c | 6 +++--- lib/metrics/rte_metrics.c | 2 +- lib

[PATCH v2 09/19] net/mlx[45]: remove word sanity

2023-05-18 Thread Stephen Hemminger
The term "sanity" is on non-inclusive naming list. Remove it from the Nvidia drivers. Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/linux/mlx5_common_os.c | 2 +- drivers/net/mlx4/mlx4.c| 2 +- drivers/net/mlx4/mlx4_flow.c | 6 +++--- drivers/net/mlx5

[PATCH v2 08/19] net/fm10k, net/ixgbe: remove word sanity

2023-05-18 Thread Stephen Hemminger
Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2

[PATCH v2 06/19] doc/eventdev_pipeline: remove sanity

2023-05-18 Thread Stephen Hemminger
The word sanity check is unnecessary here. Signed-off-by: Stephen Hemminger --- doc/guides/gpus/cuda.rst | 2 +- doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +- doc/guides/tools/testbbdev.rst | 8 3 files changed, 6 insertions(+), 6 deletions

[PATCH v2 07/19] net/ring: replace use of sanity

2023-05-18 Thread Stephen Hemminger
Don't use term sanity check Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e8bc9b627102..e36742fda84f 100644 --- a/drivers/net/

[PATCH v2 04/19] examples: remove term sanity

2023-05-18 Thread Stephen Hemminger
Do not use non-inclusive terms. Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/event_helper.c | 2 +- examples/qos_sched/args.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/event_helper.c b/examples/ipsec-secgw/event_helper.c i

[PATCH v2 03/19] test: replace use word sanity

2023-05-18 Thread Stephen Hemminger
The word "sanity" is on the not-allowed inclusive naming list. Replace the unnecessary usage in tests. Signed-off-by: Stephen Hemminger --- app/test/test_bitmap.c | 4 +-- app/test/test_bpf.c| 6 ++-- app/test/test_common.c | 2 +- app/test/test_distrib

[PATCH v2 02/19] eal: replace use of sanity check in comments and messages

2023-05-18 Thread Stephen Hemminger
Sanity check is on the Tier 2 non-inclusive list. Replace or remove it. Acked-by: Anatoly Burakov Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_memory.c | 2 +- lib/eal/common/eal_common_proc.c | 3 ++- lib/eal/common/eal_common_trace.c | 2 +- lib/eal/common/eal_memcfg.h

[PATCH v2 01/19] mbuf: replace term sanity check

2023-05-18 Thread Stephen Hemminger
Replace rte_mbuf_sanity_check() with rte_mbuf_verify() to match the similar macro RTE_VERIFY() in rte_debug.h The term sanity check is on the Tier 2 list of words that should be replaced. Signed-off-by: Stephen Hemminger --- app/test/test_mbuf.c | 30 ++--- doc/guides/prog

[PATCH v2 00/19] Replace use of the term sanity-check

2023-05-18 Thread Stephen Hemminger
This set of patches removes almost all use of the term sanity check in DPDK. Did not address base drivers which come from vendors. It is up to them to fix that. The term sanity-check and related formats are on the Inclusive Naming Tier 2 (Strongly Consider Replacing) word list. https://inclusive

Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs

2023-05-18 Thread Ferruh Yigit
On 4/24/2023 3:30 PM, Ivan Malov wrote: > When the client driver (the DPDK one, for instance) parses user flow > actions, it ends up with an action set specification. Next, in case > there are any FW resource-backed actions, like COUNT or SET_DST_MAC, > the driver allocates these resources and indi

[PATCH v2 3/3] examples/l3fwd-graph: add IPv6 lookup and rewrite support

2023-05-18 Thread Amit Prakash Shukla
From: Sunil Kumar Kori Similar to ipv4, to support IPv6 lookup and rewrite node routes and rewrite data needs to be added. Patch adds routes for ipv6 to validate ip6_lookup node and rewrite data to validate ip6_rewrite node. Signed-off-by: Sunil Kumar Kori Signed-off-by: Amit Prakash Shukla

[PATCH v2 2/3] lib: add IPv6 rewrite node

2023-05-18 Thread Amit Prakash Shukla
Similar to IPv4 rewrite node, patch adds IPv6 rewrite node. Signed-off-by: Amit Prakash Shukla --- v2: - Performance related changes doc/guides/prog_guide/graph_lib.rst | 8 + lib/node/ethdev_ctrl.c | 13 ++ lib/node/ip6_rewrite.c | 331

[PATCH v2 1/3] lib: add IPv6 lookup node

2023-05-18 Thread Amit Prakash Shukla
From: Sunil Kumar Kori Similar to IPv4 lookup node, patch adds IPv6 lookup node. Signed-off-by: Sunil Kumar Kori Signed-off-by: Amit Prakash Shukla --- v2: - Performance related changes doc/guides/prog_guide/graph_lib.rst | 13 + lib/node/ip6_lookup.c | 374 +++

Re: [PATCH V3] lib: set/get max memzone segments

2023-05-18 Thread Burakov, Anatoly
Hi, On 5/3/2023 8:26 AM, Ophir Munk wrote: In current DPDK the RTE_MAX_MEMZONE definition is unconditionally hard coded as 2560. For applications requiring different values of this parameter – it is more convenient to set the max value via an rte API - rather than changing the dpdk source code

[PATCH v2 5/5] net/cnxk: add mempool check for frag attach

2023-05-18 Thread Rahul Bhansali
Add mempool cookies get mark to all frags in case of reassembly failure. Signed-off-by: Rahul Bhansali --- Changes in v2: No change drivers/net/cnxk/cn10k_rx.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h index 9fdb5565e9

[PATCH v2 4/5] event/cnxk: fix mempool cookies check

2023-05-18 Thread Rahul Bhansali
Fix for mempool cookies get mark to be done before meta to mbuf processing. Fixes: 7a709964d9bb ("net/cnxk: use NPA batch burst free for meta buffers") Cc: sta...@dpdk.org Signed-off-by: Rahul Bhansali --- Changes in v2: update in commit message for fixes and cc tag drivers/event/cnxk/cn10k_wo

[PATCH v2 3/5] event/cnxk: fix Tx adapter data pointer

2023-05-18 Thread Rahul Bhansali
Dpdk test application crashes when event inline IPsec test ran for second time onwards. In case of event device cleanup, Tx adapter data pointer is free but not set back to NULL, which causes incomplete initialization on next run. Fixes: 6a24c7c4bcd1 ("event/cnxk: add Tx adapter freeing") Cc: sta.

[PATCH v2 2/5] event/cnxk: set Rx offload flags

2023-05-18 Thread Rahul Bhansali
Configure event dev Rx offload flags with rx adapter start/stop callbacks. Signed-off-by: Rahul Bhansali --- Changes in v2: No change drivers/event/cnxk/cnxk_eventdev_adptr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c

[PATCH v2 1/5] common/cnxk: fix IPsec IPv6 tunnel address byte swap

2023-05-18 Thread Rahul Bhansali
Fix the IPsec IPv6 tunnel address bytes swap during SA configurations in session create/update. Fixes: 78d03027f2cc ("common/cnxk: add IPsec common code") Cc: sta...@dpdk.org Signed-off-by: Rahul Bhansali --- Changes in v2: update in commit message for fixes and cc tag drivers/common/cnxk/cnxk

RE: [EXT] [PATCH v2 3/3] app/eventdev: prevent mempool exhaustion

2023-05-18 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Prevent mempool exhaustion due to elements being stuck in lcore >local caches. > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- > app/test-eventdev/test_perf_common.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/ap

RE: [EXT] [PATCH v2 2/3] app/eventdev: use enqueue new event burst routine

2023-05-18 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Use the `rte_event_enqueue_new_burst` routine to enqueue events >with rte_event::op as RTE_EVENT_OP_NEW. This allows PMDs to use >optimized enqueue routines. > >Signed-off-by: Pavan Nikhilesh [] Acked-by: Shijith Thotton >--- > app/test-eventdev/evt_options.c |

RE: [PATCH v2 1/3] event/cnxk: use LMTST for enqueue new burst

2023-05-18 Thread Shijith Thotton
>From: Pavan Nikhilesh > >Use LMTST when all events in the burst are enqueue with >rte_event:op as RTE_EVENT_OP_NEW i.e. events are enqueued >with the `rte_event_enqueue_new_burst` API. > >Signed-off-by: Pavan Nikhilesh Acked-by: Shijith Thotton >--- >v2 Changes: >- Fix spell check. > > driver

Re: [PATCH] lib/mempool : rte_mempool_avail_count, fixing return bigger than mempool size

2023-05-18 Thread Mattias Rönnblom
On 2023-05-16 18:03, Morten Brørup wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Tuesday, 16 May 2023 17.24 On Tue, 16 May 2023 13:41:46 + Yasin CANER wrote: From: Yasin CANER after a while working rte_mempool_avail_count function returns bigger than mempool s

Re: [PATCH v4] net/bonding: replace master/slave to main/member

2023-05-18 Thread Stephen Hemminger
On Thu, 18 May 2023 16:44:58 +0800 Chaoyong He wrote: > From: Long Wu > > This patch replaces the usage of the word 'master/slave' with more > appropriate word 'main/member' in bonding PMD as well as in its docs > and examples. Also the test app and testpmd were modified to use the > new wordin

RE: [PATCH] ethdev: add flow rule actions update API

2023-05-18 Thread Ori Kam
Hi Alexander, Please add rte_flow_trace_xxx for all new functions. > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, April 18, 2023 10:58 PM > > Introduce the new rte_flow_update() API allowing users > to update the action list in the already existing rule. > Flow rules ca

[PATCH v2 20/20] net/ice/base: add new AQ ro read HW sensors

2023-05-18 Thread Qiming Yang
Adds new helper function to read from HW sensors via a new AQ command "Get Sensor Reading (0x0632)". Currently, this AQ command only supports reading the temperature from E810 devices with a supported firmware, but in the future it could be extended to read other sensors. Signed-off-by: Marcin Do

[PATCH v2 19/20] net/ice/base: offer memory config for schedual node

2023-05-18 Thread Qiming Yang
Add an option to pre-allocate memory for ice_sched_node struct. Add new arguments to ice_sched_add() and ice_sched_add_elems() that allow for pre-allocation of memory for ice_sched_node struct. Signed-off-by: Michal Wilczynski Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c |

[PATCH v2 18/20] net/ice/base: fix static analyzer bug

2023-05-18 Thread Qiming Yang
The default condition in the switch statement in ice_sched_get_psm_clk_freq() is an unreachable code. The variable clk_src is restricted to values 0 to 3 with the bit mask and shift values set. Fixes: 76ac9d771c97 ("net/ice/base: read PSM clock frequency from register") Signed-off-by: Vignesh Srid

[PATCH v2 17/20] net/ice/base: update 3k-sign DDP support for E825C

2023-05-18 Thread Qiming Yang
The original DDP specification has been changed in terms of Signature Type ID definition for E825-C. Signed-off-by: Grzegorz Nitka Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 3 ++- drivers/net/ice/base/ice_ddp.c| 4 drivers/net/ice/base/ice_ddp.h| 1 + 3 fil

[PATCH v2 16/20] net/ice/base: delete get field vector function

2023-05-18 Thread Qiming Yang
Currently ice_get_fv() is only used inside ice_get_sw_fv_list(). Remove ice_get_fv() and call ice_get_sw_fv_list() directly. Signed-off-by: Marcin Szycik Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_ddp.c| 3 +++ drivers/net/ice/base/ice_switch.c | 23 ++- 2

[PATCH v2 14/20] net/ice/base: modify tunnel match mask

2023-05-18 Thread Qiming Yang
Tunneled packets with VLAN inside were not detected by filter. This patch fix it by modifying tunnel flag match mask. As a result both type of packets (tunneled VLAN, tunneled non-VLAN) will be detected by filter. Signed-off-by: Marcin Domagala Signed-off-by: Qiming Yang --- drivers/net/ice/bas

[PATCH v2 15/20] net/ice/base: check VSIG before disassociating VSI

2023-05-18 Thread Qiming Yang
Add checking if the VSIG group exists when iterating through all flow profiles and disassociating them from the VSI. Signed-off-by: Benjamin Mikailenko Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_flow.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v2 13/20] net/ice/base: add function to get rxq context

2023-05-18 Thread Qiming Yang
This patch exports rxq context which is consumed by linux live migration driver to save device state. Signed-off-by: Yahui Cao Signed-off-by: Qiming Yang --- drivers/net/ice/base/ice_common.c | 67 --- drivers/net/ice/base/ice_common.h | 7 +++- 2 files changed, 67

  1   2   >