[PATCH] eal/linux: register mp hotplug callback after memory init

2023-05-30 Thread Zhihong Wang
Secondary would crash if it tries to handle mp requests before memory init, since globals such as eth_dev_shared_data_lock are not accessible to it at this moment. --- lib/eal/linux/eal.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/eal/linux/eal.c b/lib/eal

RE: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one

2023-05-30 Thread Xia, Chenbo
Hi Eelco, > -Original Message- > From: Eelco Chaudron > Sent: Wednesday, May 17, 2023 5:09 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com > Cc: dev@dpdk.org > Subject: [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a > read/write one > > This

RE: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 30, 2023 11:17 PM > To: Thomas Monjalon ; Eelco Chaudron > ; Xia, Chenbo ; > david.march...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt > kick > > > > On 5/30/

RE: [PATCH v3 3/4] vhost: fix invalid call FD handling

2023-05-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 30, 2023 8:54 PM > To: Eelco Chaudron ; Xia, Chenbo > ; david.march...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 3/4] vhost: fix invalid call FD handling > > > > On 5/17/23 11:09, Eelco Chaudron wrote: > > Th

RE: [PATCH v6 1/4] ethdev: add API for mbufs recycle mode

2023-05-30 Thread Feifei Wang
> -Original Message- > From: Morten Brørup > Sent: Thursday, May 25, 2023 11:09 PM > To: Feifei Wang ; tho...@monjalon.net; Ferruh > Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > > Subject: RE: [PATCH v6 1/4] ethdev: add API for mbufs recy

RE: [PATCH] pci: fix comment referencing renamed function

2023-05-30 Thread Xia, Chenbo
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, May 31, 2023 12:02 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Gaetan Rivet ; David Marchand > > Subject: [PATCH] pci: fix comment referencing renamed function > > When renaming functions eal_parse_pci_*, > a referencing co

[PATCH v4 4/4] bus/pci: add VFIO sparse mmap support

2023-05-30 Thread Miao Li
This patch adds sparse mmap support in PCI bus. Sparse mmap is a capability defined in VFIO which allows multiple mmap areas in one VFIO region. In this patch, the sparse mmap regions are mapped to one continuous virtual address region that follows device-specific BAR layout. So, driver can still

[PATCH v4 3/4] bus/pci: introduce helper for MMIO read and write

2023-05-30 Thread Miao Li
From: Chenbo Xia The MMIO regions may not be mmap-able for VFIO-PCI devices. In this case, the driver should explicitly do read and write to access these regions. Signed-off-by: Chenbo Xia Acked-by: Sunil Kumar Kori Acked-by: Yahui Cao --- doc/guides/rel_notes/release_23_07.rst | 5 +++ dri

[PATCH v4 2/4] bus/pci: avoid depending on private value in kernel source

2023-05-30 Thread Miao Li
From: Chenbo Xia The value 40 used in VFIO_GET_REGION_ADDR() is a private value (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It is not part of VFIO API, and we should not depend on it. [1] https://github.com/torvalds/linux/blob/v6.2/include/linux/vfio_pci_core.h Signed-off-by: Ch

[PATCH v4 1/4] bus/pci: introduce an internal representation of PCI device

2023-05-30 Thread Miao Li
From: Chenbo Xia This patch introduces an internal representation of the PCI device which will be used to store the internal information that don't have to be exposed to drivers, e.g., the VFIO region sizes/offsets. In this patch, the internal structure is simply a wrapper of the rte_pci_device

[PATCH v4 0/4] Support VFIO sparse mmap in PCI bus

2023-05-30 Thread Miao Li
This series introduces a VFIO standard capability, called sparse mmap to PCI bus. In linux kernel, it's defined as VFIO_REGION_INFO_CAP_SPARSE_MMAP. Sparse mmap means instead of mmap whole BAR region into DPDK process, only mmap part of the BAR region after getting sparse mmap information from kern

[PATCH v4 1/2] ip_frag: optimize key compare and hash generation

2023-05-30 Thread pbhagavatula
From: Pavan Nikhilesh Use optimized rte_hash_k32_cmp_eq routine for key comparison for x86 and ARM64. Use CRC instructions for hash generation on ARM64. Signed-off-by: Pavan Nikhilesh Reviewed-by: Ruifeng Wang --- On Neoverse-N2, performance improved by 10% when measured with examples/ip_reass

[PATCH v4 2/2] test: add reassembly perf test

2023-05-30 Thread pbhagavatula
From: Pavan Nikhilesh Add reassembly perf autotest for both ipv4 and ipv6 reassembly. Each test is performed with variable number of fragments per flow, either ordered or unordered fragments and interleaved flows. Signed-off-by: Pavan Nikhilesh Reviewed-by: Amit Prakash Shukla Tested-by: Amit

[PATCH v5] ethdev: add flow item for RoCE infiniband BTH

2023-05-30 Thread Dong Zhou
IB(InfiniBand) is one type of networking used in high-performance computing with high throughput and low latency. Like Ethernet, IB defines a layered protocol (Physical, Link, Network, Transport Layers). IB provides native support for RDMA(Remote DMA), an extension of the DMA that allows direct acc

RE: [PATCH v4] ethdev: add flow item for RoCE infiniband BTH

2023-05-30 Thread Dong Zhou
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, May 31, 2023 1:46 AM > To: Dong Zhou ; Ori Kam ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Andrew Rybchenko ; Olivier Matz > > Cc: dev@dpdk.org > Subject: Re: [PATCH v4] ethdev: add flow item fo

Reminder - DPDK Tech Board Meeting - Tomorrow, Wed. 5/31/23 @ 8am Pacific/11am Eastern/1500h UTC

2023-05-30 Thread Nathan Southern
Good evening DPDK Community, Tomorrow, the DPDK Tech board will meet @ 8am Pacific/11am Eastern/1500h UTC. Here is a read-only copy of the agenda: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db And as always, our login: http://jit.si/dpdk See you there. Thanks, Nathan Na

[PATCH v1] common/idpf: fix memory leak on AVX512 TX queue close

2023-05-30 Thread Wenjun Wu
When releasing mbufs for TX queue software ring of AVX512, the mbuf in the range [i, tx_tail] should also be freed. The variable i refers to the index of the last mbuf released in the software ring. Signed-off-by: Wenjun Wu --- drivers/common/idpf/idpf_common_rxtx_avx512.c | 4 1 file chang

Re: [dpdk-dev] [PATCH v1] drivers/cnxk: improve the build time for non arm64 build

2023-05-30 Thread Nithin Kumar Dabilpuram
Acked-by: Nithin Dabilpuram From: jer...@marvell.com Sent: Monday, May 29, 2023 2:53 PM To: dev@dpdk.org ; Pavan Nikhilesh Bhagavatula ; Shijith Thotton ; Nithin Kumar Dabilpuram ; Kiran Kumar Kokkilagadda ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi Cc

ring name length simplification in ipsec_mb_qp_create_processed_ops_ring

2023-05-30 Thread Stephen Hemminger
I was looking at places in DPDK that are using rte_strlcpy which should be using strlcpy directly instead. Looking at this code in ipsec_mb, the use of strlcpy is actually not needed at all. /** Create a ring to place processed operations on */ static struct rte_ring *ipsec_mb_qp_create_process

[RFT] graph: fix pcapng file support

2023-05-30 Thread Stephen Hemminger
The interface to rte_pcapng changed in last release so that the interfaces used need to be added to the pcapng file via the API. If this step is missing the pcapng file will not be valid and can't be read by wireshark etc. I don't have setup to test graph, so needs a validation test. Fixes: d1da6

RE: [EXT] Re: [PATCH v3 1/2] ip_frag: optimize key compare and hash generation

2023-05-30 Thread Pavan Nikhilesh Bhagavatula
> On Mon, 29 May 2023 20:25:01 +0530 > wrote: > > > + return (k1->id_key_len != k2->id_key_len) || > > + (k1->key_len == IPV4_KEYLEN ? k1->src_dst[0] != k2->src_dst[0] : > > +rte_hash_k32_cmp_eq(k1, k2, > 32)); > > If you make another version, o

Re: [PATCH v4] ethdev: add flow item for RoCE infiniband BTH

2023-05-30 Thread Ferruh Yigit
On 5/30/2023 4:06 AM, Dong Zhou wrote: > IB(InfiniBand) is one type of networking used in high-performance > computing with high throughput and low latency. Like Ethernet, > IB defines a layered protocol (Physical, Link, Network, Transport > Layers). IB provides native support for RDMA(Remote DMA),

Re: [PATCH v3] common/cnxk: add new APIs for batch operations

2023-05-30 Thread Jerin Jacob
On Tue, May 30, 2023 at 2:43 PM Ashwin Sekhar T K wrote: > > Add new APIs for counting and extracting allocated objects > from a single cache line in the batch alloc memory. > > Signed-off-by: Ashwin Sekhar T K Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/roc

[PATCH] pci: fix comment referencing renamed function

2023-05-30 Thread Thomas Monjalon
When renaming functions eal_parse_pci_*, a referencing comment was missed in the function rte_pci_device_name(). Fixes: ca52fccbb3b9 ("pci: remove deprecated functions") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- lib/pci/rte_pci.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions

📣 Last Call for Content

2023-05-30 Thread Ben Thomas
Hello everyone *Please email me *btho...@linuxfoundation.org with any content you would like featured in our new monthly newsletter, and shared across DPDK and Linux Foundation social accounts. *Examples of content:* - Send links to tech updates, news events, meetings etc related to DPDK -

[PATCH] drivers: fix vmxnet3 return wrong error code in initializing

2023-05-30 Thread root
From: Kaijun Zeng In vmxnet3_dev_rxtx_init(), a wrong error code may be thrown after it invokes vmxnet3_post_rx_bufs() because it negates the error code before returning it. It causes rte_eth_dev_start() to give a positive number to the invoker, but it should be a negative number, as described in

dpdk: Inquiry about vring cleanup during packets transmission

2023-05-30 Thread wangzengyuan
Hi, I am writing to inquire about the vring cleanup process during packets transmission. In the virtio_xmit_pkts function, there is the following code: nb_used = virtqueue_nused(vq); if (likely(nb_used > vq->vq_nentries - vq->vq_free_thresh)) virtio_x

Re: Hugepage migration

2023-05-30 Thread Stephen Hemminger
On Tue, 30 May 2023 16:53:14 +0300 Baruch Even wrote: > > what kernel driver was being used for the device I/O part? Was it a UIO > > based driver or "vfio-pci"? When using vfio-pci and configuring IOMMU > > mappings, the pages mapped should be pinned by the kernel, I would have > > thought, sinc

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Maxime Coquelin
On 5/30/23 15:16, Thomas Monjalon wrote: 30/05/2023 15:02, Maxime Coquelin: On 5/17/23 11:09, Eelco Chaudron wrote: This patch adds an operation callback which gets called every time the library wants to call eventfd_write(). This eventfd_write() call could result in a system call, which co

[PATCH 1/1] net/mlx5: fix device removal event handling

2023-05-30 Thread Viacheslav Ovsiienko
On the device removal kernel notifies user space application with queueing the IBV_DEVICE_FATAL_EVENT and triggering appropriate file descriptor. Mellanox kernel driver stack emits this event twice from different layers (mlx5 and uverbs). The IB port index is not applicable in the event structure a

RE: [EXT] [PATCH] drivers/net/bnx2x : Offer maintainership for bnx2x

2023-05-30 Thread Alok Prasad
> -Original Message- > From: Akhil Goyal > Sent: 30 May 2023 12:37 > To: julien_d...@jaube.fr; dev@dpdk.org > Cc: Alok Prasad > Subject: RE: [EXT] [PATCH] drivers/net/bnx2x : Offer maintainership for bnx2x > > > From: Julien Aube > > > > Signed-off-by: Julien Aube > > --- > ++ Alok

RE: [PATCH] lib/cryptodev: set minimal output buffer size for RSA op

2023-05-30 Thread Akhil Goyal
> > Subject: [PATCH] lib/cryptodev: set minimal output buffer size for RSA op > > > > Depending on RSA op, the output buffer size could be set > > minimal expected memory, rather than 0 as today. This will allow > > PMD to do any validation on the size, in case an application > > did not create eno

RE: [EXT] [PATCH v5 1/2] cryptodev: support SM3_HMAC,SM4_CFB and SM4_OFB

2023-05-30 Thread Akhil Goyal
> Add SM3_HMAC/SM4_CFB/SM4_OFB support in DPDK. > > Signed-off-by: Sunyang Wu Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto

Minutes of Technical Board Meeting, 2023-05-17

2023-05-30 Thread Thomas Monjalon
Members Attending: 10/10 - Aaron Conole - Bruce Richardson - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Stephen Hemminger - Thomas Monjalon (Chair) NOTE

Re: Hugepage migration

2023-05-30 Thread Baruch Even
On Tue, May 30, 2023 at 11:04 AM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Sun, May 28, 2023 at 11:07:40PM +0300, Baruch Even wrote: > >Hi, > >We found an issue with newer kernels (5.13+) that are found on newer > >OSes (Ubuntu22, Rocky9, Ubuntu20 with kernel 5.15) whe

Re: Hugepage migration

2023-05-30 Thread Baruch Even
I have tested the MAP_LOCKED, it doesn't help in this case. I do intend to report to the kernel but was wondering if others have hit upon this first. On Tue, May 30, 2023 at 4:35 AM Stephen Hemminger < step...@networkplumber.org> wrote: > On Sun, 28 May 2023 23:07:40 +0300 > Baruch Even wrote: >

Re: [PATCH 1/3] security: introduce out of place support for inline ingress

2023-05-30 Thread Thomas Monjalon
30/05/2023 11:23, Jerin Jacob: > > > > > > + */ > > > > > > + uint32_t ingress_oop : 1; > > > > > > + > > > > > > /** Reserved bit fields for future extension > > > > > >* > > > > > >* User should ensure reserved_opts is cleared as it may > > > > > > change in > > >

Re: [PATCH v1] bus/pci: get PCI address from rte_device

2023-05-30 Thread Thomas Monjalon
30/05/2023 13:42, eagost...@nvidia.com: > This patch introduces a get function to retrieve a PCI address > from an rte_device handler. [...] > +const struct rte_pci_addr * > +rte_pci_get_addr(const struct rte_device *dev) > +{ > + const struct rte_pci_device *pci_dev; > + > + if (!dev) { P

Re: [PATCH v4] lib: set/get max memzone segments

2023-05-30 Thread Thomas Monjalon
25/05/2023 00:25, Ophir Munk: > --- a/config/rte_config.h > +++ b/config/rte_config.h > -#define RTE_MAX_MEMZONE 2560 Good to be able to remove this compilation-time configuration. > --- a/lib/eal/common/eal_common_memzone.c > +++ b/lib/eal/common/eal_common_memzone.c > +#define DEFAULT_MAX_MEMZ

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Thomas Monjalon
30/05/2023 15:02, Maxime Coquelin: > > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentially block the PMD th

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Maxime Coquelin
On 5/17/23 11:09, Eelco Chaudron wrote: This patch adds an operation callback which gets called every time the library wants to call eventfd_write(). This eventfd_write() call could result in a system call, which could potentially block the PMD thread. The callback function can decide whether

Re: [PATCH v3 3/4] vhost: fix invalid call FD handling

2023-05-30 Thread Maxime Coquelin
On 5/17/23 11:09, Eelco Chaudron wrote: This patch fixes cases where IRQ injection is tried while the call FD is not valid, which should not happen. Fixes: b1cce26af1dc ("vhost: add notification for packed ring") Fixes: e37ff954405a ("vhost: support virtqueue interrupt/notification suppressi

Re: [PATCH v3 2/4] vhost: make the guest_notifications statistic counter atomic

2023-05-30 Thread Maxime Coquelin
On 5/17/23 11:08, Eelco Chaudron wrote: Making the guest_notifications statistic counter atomic, allows it to be safely incremented while holding the read access_lock. Signed-off-by: Eelco Chaudron --- lib/vhost/vhost.c |8 lib/vhost/vhost.h |9 ++--- 2 files changed

[PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Srujana Challa
LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa --- drivers/event/cnxk/cn10k_tx_worker.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletio

[PATCH v1] bus/pci: get PCI address from rte_device

2023-05-30 Thread eagostini
From: Elena Agostini In DPDK 22.11 pci bus related structure have been hidden internally so the application doesn't have a direct access to those info anymore. This patch introduces a get function to retrieve a PCI address from an rte_device handler. Signed-off-by: Elena Agostini --- drivers/

RE: [PATCH v4] lib: set/get max memzone segments

2023-05-30 Thread Ophir Munk
> -Original Message- > Subject: Re: [PATCH v4] lib: set/get max memzone segments > > On 5/24/2023 11:25 PM, Ophir Munk wrote: > > Currently, the max memzones count constat (RTE_MAX_MEMZONE) is used > to > > decide how many memzones a DPDK application can have. This value could > > techni

RE: [EXT] [PATCH v3 2/2] test: add reassembly perf test

2023-05-30 Thread Amit Prakash Shukla
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, May 29, 2023 8:25 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [EXT] [PATCH v3 2/2] test: add reassembly perf test > > External Email > >

RE: [EXT] [PATCH v2 0/4] Replace obsolote test cases.

2023-05-30 Thread Akhil Goyal
> This patchset removes obsolete test cases for RSA, MOD EXP, MOD INV. > Doing that, new way of handling ut_setup and ut_teardown was proposed. > Now both behave like constructor/desctuctor to the unit tests. > It frees particular alghorithm functions from any kind of responsibility to > free > re

RE: [PATCH v1] power: support amd-pstate cpufreq driver

2023-05-30 Thread Tummala, Sivaprasad
[AMD Official Use Only - General] Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, May 25, 2023 12:17 AM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; dev@dpdk.org; Yigit, Ferruh ; > anatoly.bura...@intel.com; Laatz, Kevin > Subject: Re: [PATCH v1] powe

[PATCH] net/e1000: support device I219

2023-05-30 Thread Qiming Yang
support device I219 LM22, V22, LM23 and V23. Signed-off-by: Qiming Yang --- drivers/net/e1000/em_ethdev.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 8ee9be12ad..0afedcd00c 100644 --- a/

[PATCH v6 21/21] test/pdcp: add PDCP status report cases

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Test PDCP status report generation. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 312 +++ 1 file changed, 312 insertions(+) diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c index

[PATCH v6 20/21] pdcp: allocate reorder buffer alongside with entity

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Instead of allocating reorder buffer separately on heap, allocate memory for it together with rest of entity, and then only initialize buffer via `rte_reorder_init()`. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 9 +++

[PATCH v6 18/21] test/pdcp: add timer restart case

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Add test to cover the case when t-reordering timer should be restarted on the same packet. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 68 1 file changed, 68 insertions(+) diff --gi

[PATCH v6 19/21] pdcp: add support for status report

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Implement status report generation for PDCP entity. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_cnt.c | 158 --- lib/pdcp/pdcp_cnt.h | 11 ++- lib/pdcp/pdcp_ctrl_pdu.c | 34 - lib/

[PATCH v6 17/21] test/pdcp: add timer expiry cases

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases for handling the expiry with rte_timer and rte_event_timer. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 350 +++ 1 file changed, 350 insertions(+) diff --git a/app/test/te

[PATCH v6 16/21] pdcp: add timer expiry handle

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko The PDCP protocol requires usage of timers to keep track of how long an out-of-order packet should be buffered while waiting for missing packets. Applications can register a desired timer implementation with the PDCP library. Once the timer expires, the application will be

[PATCH v6 14/21] test/pdcp: add in-order delivery cases

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Add test cases to verify behaviour when in-order delivery is enabled and packets arrive in out-of-order. PDCP library is expected to buffer the packets and return packets in-order when the missing packet arrives. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko

[PATCH v6 15/21] pdcp: add timer callback handlers

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko PDCP has a windowing mechanism which allows only packets that fall in a reception window. The pivot point for this window is RX_REORD which happens to be the first missing or next expected packet. If the missing packet is not received after a specified time, then the RX_REO

[PATCH v6 13/21] pdcp: implement t-Reordering and packet buffering

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Add in-order delivery of packets in PDCP. Delivery of packets in-order relies on t-Reordering timer. When 'out-of-order delivery' is disabled, PDCP will buffer all received packets that are out of order. The t-Reordering timer determines the time period these packets would

[PATCH v6 12/21] pdcp: add control PDU handling for status report

2023-05-30 Thread Anoob Joseph
Add control PDU handling and implement status report generation. Status report generation works only when RX_DELIV = RX_NEXT. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- doc/guides/prog_guide/pdcp_lib.rst | 9 ++ lib/pdcp/meson.build | 2 ++ lib/pdcp/pdcp

[PATCH v6 11/21] doc: add PDCP library guide

2023-05-30 Thread Anoob Joseph
Add guide for PDCP library. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + .../img/pdcp_functional_overview.svg | 1 + doc/guides/prog_guide/index.rst | 1 + doc/guid

[PATCH v6 10/21] test/pdcp: pdcp HFN tests in combined mode

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Add tests to verify HFN/SN behaviour. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- app/test/test_pdcp.c | 302 ++- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/app/test/test_pdcp.c b/app/test/

[PATCH v6 09/21] app/test: add lib pdcp tests

2023-05-30 Thread Anoob Joseph
Add tests to verify lib PDCP operations. Tests leverage existing PDCP test vectors. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- MAINTAINERS | 1 + app/test/meson.build | 5 + app/test/test_pdcp.c | 732 +++ 3 files changed

[PATCH v6 08/21] pdcp: add IV generation routines

2023-05-30 Thread Anoob Joseph
For PDCP, IV generated has varying formats depending on the ciphering and authentication algorithm used. Add routines to populate IV accordingly. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 87 lib/pdcp/pdcp_process.c | 284 +++

[PATCH v6 07/21] pdcp: add pre and post process for DL

2023-05-30 Thread Anoob Joseph
Add routines to perform pre & post processing for down link entities. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko --- lib/pdcp/pdcp_entity.h | 2 + lib/pdcp/pdcp_process.c | 384 lib/pdcp/pdcp_process.h |

[PATCH v6 06/21] pdcp: add pre and post process for UL

2023-05-30 Thread Anoob Joseph
Add routines to perform pre & post processing based on the type of entity. To avoid checks in datapath, there are different function pointers registered based on the following, 1. Control plane v/s user plane 2. 12 bit v/s 18 bit SN For control plane only 12 bit SN need to be supported (as per PDC

[PATCH v6 05/21] pdcp: add crypto session create and destroy

2023-05-30 Thread Anoob Joseph
Add routines to create & destroy sessions. PDCP lib would take crypto transforms as input and creates the session on the corresponding device after verifying capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- lib/pdcp/pdcp_crypto.c | 223 +++

[PATCH v6 04/21] pdcp: add packet group

2023-05-30 Thread Anoob Joseph
Crypto processing in PDCP is performed asynchronously by rte_cryptodev_enqueue_burst() and rte_cryptodev_dequeue_burst(). Since cryptodev dequeue can return crypto operations belonging to multiple entities, rte_pdcp_pkt_crypto_group() is added to help grouping crypto operations belonging to same en

[PATCH v6 03/21] pdcp: add pre and post-process

2023-05-30 Thread Anoob Joseph
PDCP process is split into 2 parts. One before crypto processing (rte_pdcp_pkt_pre_process()) and one after crypto processing (rte_pdcp_pkt_post_process()). Functionality of pre-process & post-process varies based on the type of entity. Registration of entity specific function pointer allows skippi

[PATCH v6 02/21] lib: add pdcp protocol

2023-05-30 Thread Anoob Joseph
Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following options, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4. Upl

[PATCH v6 01/21] net: add PDCP header

2023-05-30 Thread Anoob Joseph
From: Volodymyr Fialko Add PDCP protocol header to be used for supporting PDCP protocol processing. Signed-off-by: Anoob Joseph Signed-off-by: Kiran Kumar K Signed-off-by: Volodymyr Fialko Acked-by: Akhil Goyal --- doc/api/doxy-api-index.md | 3 +- lib/net/meson.build | 1 + lib/n

[PATCH v6 00/21] lib: add pdcp protocol

2023-05-30 Thread Anoob Joseph
Add Packet Data Convergence Protocol (PDCP) processing library. The library is similar to lib_ipsec which provides IPsec processing capabilities in DPDK. PDCP would involve roughly the following operations, 1. Transfer of user plane data 2. Transfer of control plane data 3. Header compression 4.

Re: [PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Jerin Jacob
On Tue, May 30, 2023 at 3:12 PM Srujana Challa wrote: > > From: Author Srujana Challa > > LMTST area can be overwritten before read by HW between to consecutive > steorl operations. Hence, add wmb() after steorl op to make sure > the lmtst operation is complete. lmtst -> LMTST Change the subjec

Re: dpdk: Inquiry about vring cleanup during packets transmission

2023-05-30 Thread Maxime Coquelin
Hello, On 5/27/23 09:08, wangzengyuan wrote: Hi, I am writing to inquire about the vring cleanup process during packets transmission. In the virtio_xmit_pkts function, there is the following code: nb_used = virtqueue_nused(vq); if (likely(nb_used > vq->vq_nent

[PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Srujana Challa
From: Author Srujana Challa LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa --- drivers/event/cnxk/cn10k_tx_worker.h | 8 +++- 1 file chang

[PATCH] event/cnxk: add wmb after steorl for event mode

2023-05-30 Thread Srujana Challa
From: Author Srujana Challa LMTST area can be overwritten before read by HW between to consecutive steorl operations. Hence, add wmb() after steorl op to make sure the lmtst operation is complete. Signed-off-by: Srujana Challa Change-Id: Ib16d7cd88cff79e9ca78eff8c47b7ddad2d234dd Reviewed-on: ht

Re: [PATCH v6 0/3] add telemetry cmds for ring

2023-05-30 Thread Jie Hai
Hi, Thomas and all maintainers, Kindly ping for comments, thanks. On 2023/5/9 17:24, Jie Hai wrote: This patch set supports telemetry cmd to list rings and dump information of a ring by its name. v1->v2: 1. Add space after "switch". 2. Fix wrong strlen parameter. v2->v3: 1. Remove prefix "rte_

Re: [PATCH 1/3] security: introduce out of place support for inline ingress

2023-05-30 Thread Jerin Jacob
> > > > > + */ > > > > > + uint32_t ingress_oop : 1; > > > > > + > > > > > /** Reserved bit fields for future extension > > > > >* > > > > >* User should ensure reserved_opts is cleared as it may change > > > > > in > > > > > @@ -282,7 +293,7 @@ struct rte_security_i

[PATCH v3] common/cnxk: add new APIs for batch operations

2023-05-30 Thread Ashwin Sekhar T K
Add new APIs for counting and extracting allocated objects from a single cache line in the batch alloc memory. Signed-off-by: Ashwin Sekhar T K --- drivers/common/cnxk/roc_npa.h | 78 ++- 1 file changed, 67 insertions(+), 11 deletions(-) diff --git a/drivers/comm

[PATCH 10/10] ethdev: support telemetry query VLAN info

2023-05-30 Thread Jie Hai
This patch supports querying VLAN information by telemetry. The command is like: --> /ethdev/vlan,0 { "/ethdev/vlan": { "pvid": 0, "hw_vlan_reject_tagged": 0, "hw_vlan_reject_untagged": 0, "hw_vlan_insert_pvid": 0, "VLAN_STRIP": "off", "VLAN_EXTEND": "off", "QINQ_STRIP

[PATCH 09/10] ethdev: support telemetry query FEC info

2023-05-30 Thread Jie Hai
This patch supports getting FEC information by telemetry. The command is like: --> /ethdev/fec,0 { "/ethdev/fec": { "fec_mode": "off", "fec_capability": { "10_Gbps": "off auto baser" } } } Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.c | 145

[PATCH 08/10] ethdev: support telemetry query RSS info

2023-05-30 Thread Jie Hai
This patch supports querying RSS info by telemetry command. The command is like: --> /ethdev/rss_info,0 { "/ethdev/rss_info": { "rss_hf": "0x238c", "rss_key_len": 40, "rss_key": "6d5a56da255b0ec24167253d43a38fb0d0ca2b\ cbae7b30b477cb2da38030f20c6a42b73bbeac01fa" } }

[PATCH 07/10] ethdev: support telemetry query DCB info

2023-05-30 Thread Jie Hai
This patch supports querying DCB info. The command is like: --> /ethdev/dcb,0 { "/ethdev/dcb": { "tc_num": 1, "tc0": { "priority": 0, "bw_percent": "100%", "rxq_base": 0, "txq_base": 0, "nb_rxq": 4, "nb_txq": 4 } } } Signed-off-by: Jie Hai ---

[PATCH 06/10] ethdev: add firmware version in telemetry info command

2023-05-30 Thread Jie Hai
This patch adds firmware version in telemetry info command. An example is like: --> /ethdev/info,0 { "/ethdev/info": { "name": ":bd:00.0", "fw_version": "1.20.0.17", } } Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 05/10] ethdev: support telemetry query Tx queue info

2023-05-30 Thread Jie Hai
This patch support querying information of Tx queues. The command is like: --> /ethdev/tx_queue,0,0 { "/ethdev/tx_queue": { "host_threshold": 0, "prefetch_threshold": 0, "writeback_threshold": 0, "rs_threshold": 32, "free_threshold": 928, "deferred_start": "off", "offl

[PATCH 03/10] ethdev: support telemetry query flow ctrl info

2023-05-30 Thread Jie Hai
This patch supports telemetry querying flow control info. The command is like: --> /ethdev/flow_ctrl,0 { "/ethdev/flow_ctrl": { "high_waterline": "0x0", "low_waterline": "0x0", "pause_time": "0x", "send_xon": "off", "mac_ctrl_frame_fwd": "off", "rx_pause": "off", "

[PATCH 04/10] ethdev: support telemetry query Rx queue info

2023-05-30 Thread Jie Hai
This patch support querying information of Rx queues. The command is like: --> /ethdev/rx_queue,0,0 { "/ethdev/rx_queue": { "mempool_name": "mb_pool_0", "socket_id": 0, "host_threshold": 0, "prefetch_threshold": 0, "writeback_threshold": 0, "free_threshold": 32, "rx_dr

[PATCH 02/10] ethdev: support RxTx offload display

2023-05-30 Thread Jie Hai
Currently, Rx/Tx offloads are displayed in numeric format, which is not easy to understand. This patch fixes it. Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/lib/ethdev/rte_ethde

[PATCH 01/10] ethdev: support telemetry query MAC addresses

2023-05-30 Thread Jie Hai
From: Dengdui Huang This patch support telemetry query MAC addresses for a specific port. The command is like: --> /ethdev/macs,0 { "/ethdev/macs": [ "00:18:2D:00:00:79", "00:18:2D:00:00:78", "00:18:2D:00:00:77" ] } Signed-off-by: Dengdui Huang --- lib/ethdev/rte_ethdev.c | 44

[PATCH 00/10] support telemetry query ethdev info

2023-05-30 Thread Jie Hai
This patchset supports querying information about ethdev. The information includes MAC addresses, RxTx offload, flow ctrl, Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. Dengdui Huang (1): ethdev: support telemetry query MAC addresses Jie Hai (9): ethdev: support RxTx offload displ

RE: [PATCH] examples/ptpclient: add signal handler for cleanup

2023-05-30 Thread Rahul Bhansali
Hi Kirill, This patch is pending for review from long time. Please do let me know if any comments on this patch, else will request to merge it. Regards, Rahul > -Original Message- > From: Rahul Bhansali > Sent: Monday, May 15, 2023 4:29 PM > To: 'Kirill Rybalchenko' ; Thomas Monjalon >

Re: [PATCH v2 1/3] lib: add IPv6 lookup node

2023-05-30 Thread Nithin Dabilpuram
On Thu, May 18, 2023 at 9:27 PM Amit Prakash Shukla wrote: > > From: Sunil Kumar Kori > > Similar to IPv4 lookup node, patch adds IPv6 lookup > node. > > Signed-off-by: Sunil Kumar Kori > Signed-off-by: Amit Prakash Shukla > --- > v2: > - Performance related changes > > doc/guides/prog_guide/g

RE: [PATCH v5 01/21] net: add PDCP header

2023-05-30 Thread Akhil Goyal
> Subject: [PATCH v5 01/21] net: add PDCP header > > From: Volodymyr Fialko > > Add PDCP protocol header to be used for supporting PDCP protocol > processing. > > Signed-off-by: Anoob Joseph > Signed-off-by: Kiran Kumar K > Signed-off-by: Volodymyr Fialko > Acked-by: Akhil Goyal > --- Olivi

Re: [PATCH v2 1/4] node: add pkt punt to kernel node

2023-05-30 Thread Nithin Dabilpuram
On Tue, Apr 25, 2023 at 6:45 PM Vamsi Attunuru wrote: > > Patch adds a node to punt the packets to kernel over > a raw socket. > > Signed-off-by: Vamsi Attunuru > --- > doc/guides/prog_guide/graph_lib.rst | 10 +++ > lib/node/meson.build| 1 + > lib/node/punt_kernel.c

[PATCH] app/testpmd: fix IPv6 tunnel packet checksum error

2023-05-30 Thread Shiyang He
In checksum forwarding mode, the checksum of tunnel packet calculated incorrectly when outer header is IPv6. This patch fixes the issue by setting L4 checksum flag. Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags") Cc: sta...@dpdk.org Signed-off-by: Shiyang He --- app/test-pmd/csumo

Re: Hugepage migration

2023-05-30 Thread Bruce Richardson
On Sun, May 28, 2023 at 11:07:40PM +0300, Baruch Even wrote: >Hi, >We found an issue with newer kernels (5.13+) that are found on newer >OSes (Ubuntu22, Rocky9, Ubuntu20 with kernel 5.15) where a 2M page that >was allocated for DPDK was migrated (moved into another physical page) >

[PATCH] app/testpmd: fix IPv6 tunnel packet checksum error

2023-05-30 Thread Shiyang He
In checksum forwarding mode, the checksum of tunnel packet calculated incorrectly when outer header is IPv6. This pathch fixes the issue by setting L4 checksum flag. Fixes: daa02b5cddbb ("mbuf: add namespace to offload flags") Cc: sta...@dpdk.org Signed-off-by: Shiyang He --- app/test-pmd/csum

RE: [PATCH v3 1/2] ip_frag: optimize key compare and hash generation

2023-05-30 Thread Ruifeng Wang
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, May 29, 2023 10:55 PM > To: jer...@marvell.com; Ruifeng Wang ; Yipeng Wang > ; Sameh Gobriel ; Bruce > Richardson > ; Vladimir Medvedkin > ; > Konstantin Ananyev > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH

Re: [PATCH v2 4/4] app: add testgraph application

2023-05-30 Thread Jerin Jacob
On Mon, May 22, 2023 at 12:37 PM Vamsi Krishna Attunuru wrote: > > > +static int > > > +link_graph_nodes(uint64_t valid_nodes, uint32_t lcore_id) > > > +{ > > > + int ret = 0; > > > + > > > + num_patterns = 0; > > > + > > > + if (valid_nodes == (TEST_GRAPH_ETHDEV_TX_NODE | I think, if we

RE: [EXT] [PATCH] drivers/net/bnx2x : Offer maintainership for bnx2x

2023-05-30 Thread Akhil Goyal
> From: Julien Aube > > Signed-off-by: Julien Aube > --- ++ Alok

  1   2   >