RE: [EXT] [PATCH v8] app/dma-perf: introduce dma-perf application

2023-06-22 Thread Anoob Joseph
Hi Cheng, Thanks for the new version. Please see inline. Thanks, Anoob > -Original Message- > From: Cheng Jiang > Sent: Tuesday, June 20, 2023 12:24 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > m...@smartsharesystems.com; chenbo@intel.com; Amit Prakash Shukla > ; Anoo

[PATCH v8 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Artemii Morozov
Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchen

[PATCH v8 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Artemii Morozov
To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate Rx prefix should be requested. VLAN stripping is supported on EF100. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- dri

[PATCH v8 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Artemii Morozov
This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_filter.c | 20 ++ drivers/common/sfc_efx/base/ef10_impl.h | 6 + drivers/common/sfc_efx/

[PATCH v8 1/4] common/sfc_efx/base: report VLAN stripping capability

2023-06-22 Thread Artemii Morozov
These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++ drivers/common/sfc_efx/base/efx.h

[PATCH v8 0/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Artemii Morozov
This patch series adds VLAN stripping offload. Note that this offload are device level offload. v8: * fix minor issues * update the release notes v7: * raise an error if there is no callback for efo_get_count * fix alignment * remove the extra check v6: * highlight that efx_port_vlan

Re: [PATCH] net/octeon_ep: support backward compatibility

2023-06-22 Thread Jerin Jacob
On Thu, Jun 22, 2023 at 4:48 PM Vamsi Attunuru wrote: > > From: Sathesh Edara > > Add backward compatibility support between VF > and PF mailbox messages. > > Signed-off-by: Sathesh Edara > Signed-off-by: Vamsi Attunuru Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/

Re: [PATCH v5 0/6] replace rte atomics with GCC builtin atomics

2023-06-22 Thread Patrick Robb
I want to report a possible regression from this patch series seen from CI testing on our Intel 82599ES 10G NIC, which we failed to report to patchwork when this initially went under CI due to a bug in our Jenkins reporting scripts. Use of the ixgbe driver appears to be affected. Tyler I apologize

Re: [PATCH v5] lib/net: add MPLS insert and strip functionality

2023-06-22 Thread Tanzeel Ahmed
Hi, @olivier.m...@6wind.com On Sun, 11 Jun 2023, 1:17 am Tanzeel-inline, wrote: > None of the foundational NICs currently supports MPLS insertion and > stripping, this functionality can help users who rely on MPLS in their > network application. > > Signed-off-by: Tanzeel Ahmed > > --- > > Thi

Re: [PATCH v3] doc: prefer installing using meson rather than ninja

2023-06-22 Thread Thomas Monjalon
09/06/2023 16:51, Bruce Richardson: > After doing a build, to install DPDK system-wide our documentation > recommended using the "ninja install" command. However, for anyone > building as a non-root user and only installing as root, the "meson > install" command is a better alternative, as it provi

Re: [PATCH] eal: add notes to SMP memory barrier APIs

2023-06-22 Thread Mattias Rönnblom
On 2023-06-21 08:44, Ruifeng Wang wrote: The rte_smp_xx() APIs are deprecated. But it is not mentioned in the function header. Added notes in function header for clarification. Signed-off-by: Ruifeng Wang --- lib/eal/include/generic/rte_atomic.h | 15 +++ 1 file changed, 15 inser

Re: [PATCH v3] bitmap: add scan from offset function

2023-06-22 Thread Thomas Monjalon
21/06/2023 12:01, Volodymyr Fialko: > Currently, in the case when we search for a bit set after a particular > value, the bitmap has to be scanned from the beginning and > rte_bitmap_scan() has to be called multiple times until we hit the value. > > Add a new rte_bitmap_scan_from_offset() function

Re: [PATCH] ci: fix libabigail cache in GHA

2023-06-22 Thread Thomas Monjalon
20/06/2023 16:21, Aaron Conole: > David Marchand writes: > > > In repositories where multiple branches run the ABI checks using > > different versions of libabigail (for example, a 22.11 branch using > > libabigail-1.8 and a main branch using libabigail-2.1), a collision > > happens on the libabi

Re: [PATCH] mbuf: fix doxygen for distributor metadata

2023-06-22 Thread Thomas Monjalon
19/06/2023 16:19, Bruce Richardson: > On Mon, Jun 19, 2023 at 09:37:09AM +0200, David Marchand wrote: > > On Thu, Jun 15, 2023 at 5:15 PM Bruce Richardson > > wrote: > > > > > > On Thu, Jun 15, 2023 at 03:49:42PM +0200, David Marchand wrote: > > > > /**< is for post annotations. > > > > > > > > Fi

Re: [PATCH 2/2] lib: make graph optional

2023-06-22 Thread Thomas Monjalon
20/06/2023 10:20, Jerin Jacob: > On Tue, Jun 20, 2023 at 1:40 PM Bruce Richardson > wrote: > > > > On Mon, Jun 19, 2023 at 10:46:50PM +0200, David Marchand wrote: > > > Allow disabling of the graph library in builds. > > > > > > Signed-off-by: David Marchand > > > --- > > > app/test/meson.build

Re: [PATCH v4 0/4] Select optional libraries

2023-06-22 Thread Thomas Monjalon
22/06/2023 11:09, Bruce Richardson: > On Wed, Jun 21, 2023 at 07:00:54PM +0200, David Marchand wrote: > > This series is one implementation to try and please users who want to > > select more easily which parts of DPDK are built. > > > > It introduces a change in behavior for enabling deprecated l

RE: [PATCH v4] app/testpmd: fix primary process not polling all queues

2023-06-22 Thread Ali Alnubani
> -Original Message- > From: Jie Hai > Sent: Friday, June 9, 2023 12:04 PM > To: Aman Singh ; Yuying Zhang > ; Anatoly Burakov ; > Matan Azrad ; Dmitry Kozlyuk > > Cc: dev@dpdk.org; liudongdo...@huawei.com; shiyangx...@intel.com; > ferruh.yi...@amd.com > Subject: [PATCH v4] app/testpmd: f

DPDK22 issue: Unable to set more than 4 queues in Azure

2023-06-22 Thread Nageswara Rao
Hi All, We are observing the following issue with DPDK22.11. We didn’t find any upstream patches for this issue on the DPDK github. Is there any known issue, please let us know. *Issue:* On Azure platform, we are unable to configure more than 4 queues. When we try to configure more than 4 queu

Re: [PATCH v7 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Ferruh Yigit
On 6/22/2023 4:11 PM, Artemii Morozov wrote: > Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. > VLAN stripping is supported for ef100 datapath only. This is device > level offload. > > Signed-off-by: Artemii Morozov > Reviewed-by: Viacheslav Galaktionov > Reviewed-by: Ivan

Re: [PATCH v14 5/6] memarea: support dump API

2023-06-22 Thread Burakov, Anatoly
On 2/9/2023 6:36 AM, Chengwen Feng wrote: This patch supports rte_memarea_dump() API which could be used for debug. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- Provisionally, Acked-by: Anatoly Burakov As long as below is addressed. +static void +m

Re: [PATCH v7 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 18:11, Artemii Morozov wrote: This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov Acked-by: Andrew Rybchenko However, it would be good if it is reviewed as well by Andy and Ivan.

Re: [PATCH v7 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 18:11, Artemii Morozov wrote: Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed

Re: [PATCH v7 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 18:11, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate Rx prefix should be requested. VLAN stripping is supported on EF100. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Mo

Re: [PATCH v14 3/6] memarea: support alloc and free API

2023-06-22 Thread Burakov, Anatoly
On 2/9/2023 6:36 AM, Chengwen Feng wrote: This patch supports rte_memarea_alloc() and rte_memarea_free() API. Signed-off-by: Chengwen Feng Reviewed-by: Dongdong Liu Acked-by: Morten Brørup --- General note: this patchset could benefit from a bit more comments. I don't suggest commenting ev

[PATCH v7 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Artemii Morozov
Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/nics/sfc

[PATCH v7 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Artemii Morozov
To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate Rx prefix should be requested. VLAN stripping is supported on EF100. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef1

[PATCH v7 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Artemii Morozov
This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov --- drivers/common/sfc_efx/base/ef10_filter.c | 20 ++ drivers/common/sfc_efx/base/ef10_impl.h | 6 + drivers/common/sfc_efx/base/efx_filter.c | 32

[PATCH v7 1/4] common/sfc_efx/base: report VLAN stripping capability

2023-06-22 Thread Artemii Morozov
These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++ drivers/common/sfc_efx/base/efx.h

[PATCH v7 0/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Artemii Morozov
This patch series adds VLAN stripping offload. Note that this offload are device level offload. v7: * raise an error if there is no callback for efo_get_count * fix alignment * remove the extra check v6: * highlight that efx_port_vlan_strip_set() must be called before any filter insertio

Re: [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix

2023-06-22 Thread Ferruh Yigit
On 6/22/2023 1:31 PM, Artemii Morozov wrote: > If the prefix for the RSS hash was not chosen the ENOTSUP error should > be returned. > > Before this patch success was returned for this case causing Rx queue > creation to fail. > > Fixing return value to indicate failure. > > Fixes: f784cdc5cbb1

[PATCH v2 7/7] build: make reorder library optional

2023-06-22 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.bu

[PATCH v2 6/7] build: make fragmentation library optional

2023-06-22 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.bu

[PATCH v2 5/7] build: make distributor library optional

2023-06-22 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson

[PATCH v2 4/7] build: make efd library optional

2023-06-22 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 8 lib/meson.build | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test/meson.

[PATCH v2 3/7] build: make bpf library optional

2023-06-22 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 10 +++--- lib/meson.build | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/me

[PATCH v2 2/7] build: make membership library optional

2023-06-22 Thread Bruce Richardson
This library is not essential for most DPDK uses, so mark it as optional in the build config. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson

[PATCH v2 1/7] build: make most device classes optional

2023-06-22 Thread Bruce Richardson
Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH v2 0/7] expand list of optional libraries

2023-06-22 Thread Bruce Richardson
DPDK still has many libraries which cannot be disabled as part of a build. With the ongoing work to make it easier to only build a subset of the libraries in DPDK, we can also work to expand the list of libraries which can be enabled/disabled as desired. This patch addresses a number of the "low-h

RE: [PATCH 0/7] expand list of optional libraries

2023-06-22 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 22 June 2023 15.49 > > DPDK still has many libraries which cannot be disabled as part of a > build. With the ongoing work to make it easier to only build a subset > of the libraries in DPDK, we can also work to expand t

[PATCH 7/7] build: make reorder library optional

2023-06-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index e8dbbadd5e..13bd752002 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@

[PATCH 6/7] build: make fragmentation libary optional

2023-06-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/test/meson.build | 6 -- lib/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 749e929945..e8dbbadd5e 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@

[PATCH 5/7] build: make distributor library optional

2023-06-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index ab5bd370bf..749e929945 100644 --- a/app/test/meson.build +++ b/app/test/meson.build

[PATCH 4/7] build: make efd library optional

2023-06-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/test/meson.build | 8 lib/meson.build | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index d8ad8b1d97..ab5bd370bf 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @

[PATCH 3/7] build: make bpf library optional

2023-06-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/test/meson.build | 10 +++--- lib/meson.build | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index bed6acfdaf..d8ad8b1d97 100644 --- a/app/test/meson.build +++ b/app/test/meson.bui

[PATCH 2/7] build: make membership library optional

2023-06-22 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- app/test/meson.build | 9 + lib/meson.build | 1 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 780005f320..bed6acfdaf 100644 --- a/app/test/meson.build +++ b/app/test/meson.build

[PATCH 1/7] build: make most device classes optional

2023-06-22 Thread Bruce Richardson
Apart from ethdev and cryptodev, which have lots of components and tests which depend on them, we can make the device class libraries optional without too much work. This patch marks: * bbdev, * compressdev, * dmadev, * eventdev, * mldev, * rawdev, * regexdev optional, and ensures that DPDK - incl

[PATCH 0/7] expand list of optional libraries

2023-06-22 Thread Bruce Richardson
DPDK still has many libraries which cannot be disabled as part of a build. With the ongoing work to make it easier to only build a subset of the libraries in DPDK, we can also work to expand the list of libraries which can be enabled/disabled as desired. This patch addresses a number of the "low-h

Re: [PATCH] examples/l2fwd-cat: fix external build

2023-06-22 Thread Thomas Monjalon
22/06/2023 15:48, Thomas Monjalon: > From: David Marchand > > cpu_set_t definition requires _GNU_SOURCE. > > Fixes: e0473c6d5b18 ("eal: fix build with musl") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > This patch was missing in the patchset to make all examples compile. > I

Re: [PATCH v3 0/4] Test examples compilation externally

2023-06-22 Thread Thomas Monjalon
20/06/2023 16:07, David Marchand: > As DPDK provides examples compiled with makefiles, we need some tests in > the CI. So far, a few maintainers have been testing them but a simple > issue has been missed for some time and there was no way to try to build > all examples that were built with meson.

Re: [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix

2023-06-22 Thread Artemii Morozov
On 6/22/23 17:13, Ferruh Yigit wrote: On 6/22/2023 1:31 PM, Artemii Morozov wrote: If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch success was returned for this case causing Rx queue creation to fail. Fixing return value to indicate failu

[PATCH] examples/l2fwd-cat: fix external build

2023-06-22 Thread Thomas Monjalon
From: David Marchand cpu_set_t definition requires _GNU_SOURCE. Fixes: e0473c6d5b18 ("eal: fix build with musl") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- This patch was missing in the patchset to make all examples compile. It will be merged with others from: "Test examples

Re: [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix

2023-06-22 Thread Ferruh Yigit
On 6/22/2023 1:31 PM, Artemii Morozov wrote: > If the prefix for the RSS hash was not chosen the ENOTSUP error should > be returned. > > Before this patch success was returned for this case causing Rx queue > creation to fail. > > Fixing return value to indicate failure. > It looks like you use

Re: [PATCH v4 0/4] net/sfc: support KEEP_CRC offload

2023-06-22 Thread Ferruh Yigit
On 6/22/2023 12:47 PM, Denis Pryazhennikov wrote: > This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC > offload in the SFC driver. > > Changes in v2: > * Applied review notes; > * Fixed stats handling; > * Added missing release notes to [4/4]. > > Changes in v3: > * Fixed wrong inden

[PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix

2023-06-22 Thread Artemii Morozov
If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch success was returned for this case causing Rx queue creation to fail. Fixing return value to indicate failure. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") Cc

RE: [PATCH] common/mlx5: adjust fork call with the new kernel API

2023-06-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Erez Ferber > Sent: Wednesday, May 24, 2023 3:02 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh ; Erez Ferber > ; sta...@dpdk.org > Subject: [PATCH] common/mlx5: adjust fork call with the new kernel API > > From: Erez Ferbe

Re: [PATCH v6 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed

Re: [PATCH v6 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate Rx prefix should be requested. VLAN stripping is supported on EF100. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Mo

Re: [PATCH v6 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov --- drivers/common/sfc_efx/base/ef10_filter.c | 20 + drivers/common/sfc_efx/base/ef10_impl.h | 6 + dr

[PATCH v4 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-22 Thread Denis Pryazhennikov
Configurable Rx CRC stripping is allowed only if running firmware variant supports it and if NIC is configured with single PF per port and without VFs. When KEEP_CRC is supported, CRC will be part of the packet payload. The packet length will also contain CRC length. At the same time, CRC length sh

[PATCH v4 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov Drivers cannot determine if received packet includes the FCS or not. Only packets with an external port have the FCS included and functions without link control privilege cannot determine the MAC configuration. This patch is trying to make assumptions that: if PF is the only fu

[PATCH v4 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++

[PATCH v4 0/4] net/sfc: support KEEP_CRC offload

2023-06-22 Thread Denis Pryazhennikov
This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC offload in the SFC driver. Changes in v2: * Applied review notes; * Fixed stats handling; * Added missing release notes to [4/4]. Changes in v3: * Fixed wrong indents in [1/4]. Changes in v4: * Fixed "From" section in [3/4]. Denis P

[PATCH v4 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-22 Thread Denis Pryazhennikov
From: Sandilya Bhagi NIC Partitioning mode in SFC devices means multiple PFs per network port. When NIC Partitioning is configured, apart from the privileged adapter(s) the other unprivileged adapter(s) will share the same physical port. Determining NIC Partitioning mode is required to take neces

Re: [PATCH v6 1/4] common/sfc_efx/base: report VLAN stripping capability

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 14:31, Artemii Morozov wrote: These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

[PATCH v3 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-22 Thread Denis Pryazhennikov
Configurable Rx CRC stripping is allowed only if running firmware variant supports it and if NIC is configured with single PF per port and without VFs. When KEEP_CRC is supported, CRC will be part of the packet payload. The packet length will also contain CRC length. At the same time, CRC length sh

[PATCH v3 3/4] common/sfc_efx/base: add support for configure MAC to keep FCS

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_mac.c | 5 +-- drivers/common/sfc_efx/base/efx.h | 5 +++ drivers/common/sfc_efx/base/efx_impl.h | 1 + drivers/common/sfc_efx/base/efx_mac.c

[PATCH v3 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-22 Thread Denis Pryazhennikov
From: Sandilya Bhagi NIC Partitioning mode in SFC devices means multiple PFs per network port. When NIC Partitioning is configured, apart from the privileged adapter(s) the other unprivileged adapter(s) will share the same physical port. Determining NIC Partitioning mode is required to take neces

[PATCH v3 2/4] common/sfc_efx/base: detect and report FCS include support

2023-06-22 Thread Denis Pryazhennikov
From: Roman Zhukov A new variable was added to efx_nic_cfg_s to detect and report if FCS is supported by FW. Signed-off-by: Roman Zhukov Signed-off-by: Denis Pryazhennikov Reviewed-by: Viacheslav Galaktionov Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++

[PATCH v3 0/4] net/sfc: support KEEP_CRC offload

2023-06-22 Thread Denis Pryazhennikov
This patch series adds support for RTE_ETH_RX_OFFLOAD_KEEP_CRC offload in the SFC driver. Changes in v2: * Applied review notes; * Fixed stats handling; * Added missing release notes to [4/4]. Changes in v3: * Fixed wrong indents in [1/4]. Denis Pryazhennikov (3): common/sfc_efx/base: detect a

[PATCH v6 4/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Artemii Morozov
Extract VLAN TCI provided by the HW in the prefix and put it to mbuf. VLAN stripping is supported for ef100 datapath only. This is device level offload. Signed-off-by: Artemii Morozov Reviewed-by: Viacheslav Galaktionov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- doc/guides/nics/sfc

[PATCH v6 3/4] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-22 Thread Artemii Morozov
To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate Rx prefix should be requested. VLAN stripping is supported on EF100. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef1

[PATCH v6 2/4] common/sfc_efx/base: add API to get installed filters count

2023-06-22 Thread Artemii Morozov
This API allows to get number of installed filters. This will be used in the future patches. Signed-off-by: Artemii Morozov --- drivers/common/sfc_efx/base/ef10_filter.c | 20 + drivers/common/sfc_efx/base/ef10_impl.h | 6 + drivers/common/sfc_efx/base/efx_filter.c | 27 +

[PATCH v6 1/4] common/sfc_efx/base: report VLAN stripping capability

2023-06-22 Thread Artemii Morozov
These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++ drivers/common/sfc_efx/base/efx.h | 1 + drivers/common/sfc_

[PATCH v6 0/4] net/sfc: support VLAN stripping offload

2023-06-22 Thread Artemii Morozov
This patch series adds VLAN stripping offload. Note that this offload are device level offload. v6: * highlight that efx_port_vlan_strip_set() must be called before any filter insertion * avoid an extra check if offload is not requested v5: * fixed problems with naming * fixed problems

Re: [PATCH v4] common/sfc_efx/base: set return code in case of the error

2023-06-22 Thread Ferruh Yigit
On 6/22/2023 10:31 AM, Artemii Morozov wrote: > If the prefix for the RSS hash was not chosen the > ENOTSUP error should be returned. Before this patch > the zero code was returned in case of an error. > What is the impact of the problem to user? Previously 'efx_rx_qcreate_internal()' was return

[PATCH] net/octeon_ep: support backward compatibility

2023-06-22 Thread Vamsi Attunuru
From: Sathesh Edara Add backward compatibility support between VF and PF mailbox messages. Signed-off-by: Sathesh Edara Signed-off-by: Vamsi Attunuru --- drivers/net/octeon_ep/otx_ep_common.h | 3 +++ drivers/net/octeon_ep/otx_ep_ethdev.c | 6 + drivers/net/octeon_ep/otx_ep_mbox.c | 3

Re: [PATCH v2 4/4] net/sfc: add configurable Rx CRC stripping

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 06:47, Denis Pryazhennikov wrote: Configurable Rx CRC stripping is allowed only if running firmware variant supports it and if NIC is configured with single PF per port and without VFs. When KEEP_CRC is supported, CRC will be part of the packet payload. The packet length will also cont

Re: [PATCH v2 1/4] common/sfc_efx/base: discover NIC partitioning mode

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 06:47, Denis Pryazhennikov wrote: From: Sandilya Bhagi NIC Partitioning mode in SFC devices means multiple PFs per network port. When NIC Partitioning is configured, apart from the privileged adapter(s) the other unprivileged adapter(s) will share the same physical port. Determining

[PATCH v4] common/sfc_efx/base: set return code in case of the error

2023-06-22 Thread Artemii Morozov
If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch the zero code was returned in case of an error. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") Cc: sta...@dpdk.org Signed-off-by: Artemii Morozov Reviewed-by: A

Re: [PATCH v3] build: select optional libraries

2023-06-22 Thread Juraj Linkeš
On Wed, Jun 21, 2023 at 11:54 AM David Marchand wrote: > On Tue, Jun 20, 2023 at 5:05 PM Bruce Richardson > wrote: > > > > On Tue, Jun 20, 2023 at 04:33:15PM +0200, Thomas Monjalon wrote: > > > 20/06/2023 11:03, Bruce Richardson: > > > > On Tue, Jun 20, 2023 at 10:48:50AM +0200, David Marchand w

Re: [PATCH v3] common/sfc_efx/base: set return code in case of the error

2023-06-22 Thread Andrew Rybchenko
On 6/22/23 12:13, Artemii Morozov wrote: If the prefix for the rss hash was not chosen the rss -> RSS ENOTSUP error should be returned. Before this patch the zero code was returned in case of an error. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") I guess

[PATCH v3] common/sfc_efx/base: set return code in case of the error

2023-06-22 Thread Artemii Morozov
If the prefix for the rss hash was not chosen the ENOTSUP error should be returned. Before this patch the zero code was returned in case of an error. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") Signed-off-by: Artemii Morozov Reviewed-by: Andy Moreton --- v3:

Re: [PATCH v4 0/4] Select optional libraries

2023-06-22 Thread Bruce Richardson
On Wed, Jun 21, 2023 at 07:00:54PM +0200, David Marchand wrote: > This series is one implementation to try and please users who want to > select more easily which parts of DPDK are built. > > It introduces a change in behavior for enabling deprecated libraries: > this series is aimed at the next r

Re: [PATCH] maintainers: update for PCI bus driver

2023-06-22 Thread Ferruh Yigit
On 6/15/2023 5:14 PM, Nipun Gupta wrote: > Add myself as co-maintainer of PCI bus driver > > Signed-off-by: Nipun Gupta > --- > This patch is based on top of: > http://patches.dpdk.org/project/dpdk/patch/20230613065738.42370-1-chenbo@intel.com/ > > MAINTAINERS | 1 + > 1 file changed, 1 ins

Re: [PATCH v4 3/4] build: select deprecated libraries

2023-06-22 Thread Bruce Richardson
On Thu, Jun 22, 2023 at 09:43:18AM +0100, Bruce Richardson wrote: > On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > > Rework deprecated libraries selection by introducing a new configuration > > option. > > > > This breaks existing configurations that were relying on disable_libs

Re: [PATCH v4 4/4] build: select optional libraries

2023-06-22 Thread Bruce Richardson
On Wed, Jun 21, 2023 at 07:00:58PM +0200, David Marchand wrote: > There is currently no way to know which libraries are optional. > Introduce a enable_libs option (close to what we have for drivers) so > that packagers or projects consuming DPDK can more easily select the > optional libraries that

Re: [PATCH v4 3/4] build: select deprecated libraries

2023-06-22 Thread Bruce Richardson
On Wed, Jun 21, 2023 at 07:00:57PM +0200, David Marchand wrote: > Rework deprecated libraries selection by introducing a new configuration > option. > > This breaks existing configurations that were relying on disable_libs='' > for enabling deprecated libraries. > On the other hand, it will make e

Re: [PATCH v4 2/4] build: rename enabled libraries list

2023-06-22 Thread Bruce Richardson
On Wed, Jun 21, 2023 at 07:00:56PM +0200, David Marchand wrote: > The enabled_libs variable is renamed and moved to the top level > meson.build file, for sake of consistency wrt to drivers and > applications similar variables. > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson A

Re: [PATCH v4 1/4] kni: move IOVA build check

2023-06-22 Thread Bruce Richardson
On Wed, Jun 21, 2023 at 07:00:55PM +0200, David Marchand wrote: > kni dependency to IOVA configuration does not need to be expressed in > the top level lib/meson.build file. > > Signed-off-by: David Marchand > --- > lib/kni/meson.build | 5 + > lib/meson.build | 3 --- > 2 files changed,

RE: [PATCH 0/2] net/mlx5: add modify MPLS support

2023-06-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Wednesday, June 14, 2023 8:53 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 0/2] net/mlx5: add modify MPLS support > > Add support for MPLS header modification. > > RFC: > https://p