DPDK KNI problem

Hello DPDK mentors, We are facing an issue, KNI core stuck after 4-5 days of traffic. Can anybody guide us on this? We have set isolcpu, rcu_nocbs in grub for given cores. Aug 22 01:38:29 kernel: INFO: rcu_sched self-detected stall on CPU { 2} (t=60001 jiffies g=426362199 c=426362198 q=150932)

[Bug 1276] platform bus use after free

https://bugs.dpdk.org/show_bug.cgi?id=1276 Bug ID: 1276 Summary: platform bus use after free Product: DPDK Version: 23.07 Hardware: ARM OS: Linux Status: UNCONFIRMED Severity: critical Priority:

Re: [PATCH] net/iavf: fix checksum offloading

On Tue, Aug 22, 2023 at 3:52 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, August 22, 2023 1:29 AM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; echau...@redhat.com; m...@redhat.com; > > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > > ; Doher

RE: [RFC] lib/st_ring: add single thread ring

> -Original Message- > From: Morten Brørup > Sent: Monday, August 21, 2023 2:37 AM > To: Honnappa Nagarahalli ; > jack...@nvidia.com; konstantin.v.anan...@yandex.ru > Cc: dev@dpdk.org; Ruifeng Wang ; Aditya > Ambadipudi ; Wathsala Wathawana Vithanage > ; nd > Subject: RE: [RFC] lib/st_

RE: [RFC] lib/st_ring: add single thread ring

> -Original Message- > From: Mattias Rönnblom > Sent: Monday, August 21, 2023 4:14 PM > To: Honnappa Nagarahalli ; > jack...@nvidia.com; konstantin.v.anan...@yandex.ru > Cc: dev@dpdk.org; Ruifeng Wang ; Aditya > Ambadipudi ; Wathsala Wathawana > Vithanage ; nd > Subject: Re: [RFC] lib/s

Re: [PATCH v7] eventdev/eth_rx: add new adapter create API

On Mon, Aug 21, 2023 at 9:14 PM Naga Harish K S V wrote: > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > creating Rx adapter instance. This API is similar to > rte_event_eth_rx_adapter_create_ext() with an additional input > argument for adapter configuration parameters o

RE: MLX5 PMD access ring library private data

> > > > On 2023/8/18 12:30, Honnappa Nagarahalli wrote: > > > > > > > > > > > > -Original Message- > > > > From: Jack Min > > > > > > Sent: Thursday, August 17, 2023 9:32 PM > > > > To: Stephen Hemminger > > <

[PATCH] doc: update for Intel IPU

From: Beilei Xing Remove *EXPERIMENTAL* for idpf and cpfl PMD. Signed-off-by: Beilei Xing --- doc/guides/nics/cpfl.rst | 4 ++-- doc/guides/nics/idpf.rst | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/cpfl.rst b/doc/guides/nics/cpfl.rst index 39a2b603f

[PATCH v3] bus/pci: fix legacy device IO port map in secondary process

When doing IO port mapping for legacy device in secondary process, the region information is missing, so, we need to refill it. Fixes: 4b741542ecde ("bus/pci: avoid depending on private kernel value") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v3: - adjusting variable settings v2: - add r

RE: [PATCH v2] bus/pci: fix legacy device IO port map in secondary process

Hi, > -Original Message- > From: Stephen Hemminger > Sent: 2023年8月21日 10:53 > To: Ma, WenwuX > Cc: nipun.gu...@amd.com; dev@dpdk.org; david.march...@redhat.com; > maxime.coque...@redhat.com; Xia, Chenbo ; Li, > Miao ; Ling, WeiX ; > sta...@dpdk.org > Subject: Re: [PATCH v2] bus/pci: fix

RE: [PATCH] net/iavf: fix checksum offloading

> -Original Message- > From: David Marchand > Sent: Tuesday, August 22, 2023 1:29 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; echau...@redhat.com; m...@redhat.com; > sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Doherty, Declan ; Sinha, > Abhijit ; Nicolau, Radu > Subject: Re: [PATCH]

RE: [PATCH v6] eventdev/eth_rx: add new adapter create API

> -Original Message- > From: Jerin Jacob > Sent: Monday, August 21, 2023 9:07 PM > To: Naga Harish K, S V > Cc: dev@dpdk.org; Carrillo, Erik G ; Gujjar, > Abhinandan S ; McDaniel, Timothy > ; pbhagavat...@marvell.com; > sthot...@marvell.com; hemant.agra...@nxp.com; > sachin.sax...@oss.n

Re: [PATCH v5 0/6] optional rte optional stdatomics API

This series introduces API additions prefixed in the rte namespace that allow the optional use of stdatomics.h from C11 using enable_stdatomics=true for targets where enable_stdatomics=false no functional change is intended. Be aware this does not contain all changes to use stdatomics across t

Re: [RFC] lib/st_ring: add single thread ring

On 2023-08-21 08:04, Honnappa Nagarahalli wrote: Add a single thread safe and multi-thread unsafe ring data structure. One must have set the bar very low, if one needs to specify that an API is single-thread safe. This library provides an simple and efficient alternative to multi-thread saf

Reminder to Register for the DPDK Dublin Summit - Sep. 12-13, 2023

Dear DPDK Community, September 12-13, 2023 we will have the DPDK Summit at the Gibson Hotel in Point Square in Dublin. Once again, registration and attendance for this event are *free! *Virtual and on-site attendance options will be available. The schedule is posted here, and we have an outstandi

[PATCH v4 8/8] dma/cnxk: track last index return value

From: Vamsi Attunuru last index value might lost the order when dma stats are reset in between copy operations. Patch adds a variable to track the completed count, that can be used to compute the last index, also patch adds misc other changes. Signed-off-by: Vamsi Attunuru --- v2: - Fix for bug

[PATCH v4 7/8] dma/cnxk: add completion ring tail wrap check

From: Vamsi Attunuru Adds a check to avoid tail wrap when completion desc ring is full. Also patch increase max desc size to 2048. Signed-off-by: Vamsi Attunuru --- v2: - Fix for bugs observed in v1. - Squashed few commits. v3: - Resolved review suggestions. - Code improvement. v4: - Resolved

[PATCH v4 6/8] dma/cnxk: vchan support enhancement

Code changes to realign dpi private structure based on vchan. Changeset also resets DMA dev stats while starting dma device. Signed-off-by: Amit Prakash Shukla --- v2: - Fix for bugs observed in v1. - Squashed few commits. v3: - Resolved review suggestions. - Code improvement. v4: - Resolved ch

[PATCH v4 5/8] dma/cnxk: increase vchan per queue to max 4

To support multiple directions in same queue make use of multiple vchan per queue. Each vchan can be configured in some direction and used. Signed-off-by: Amit Prakash Shukla Signed-off-by: Radha Mohan Chintakuntla --- v2: - Fix for bugs observed in v1. - Squashed few commits. v3: - Resolved re

[PATCH v4 4/8] dma/cnxk: update func field based on transfer type

Use pfid and vfid of src_port for incoming DMA transfers and dst_port for outgoing DMA transfers. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Amit Prakash Shukla --- v2: - Fix for bugs observed in v1. - Squashed few commits. v3: - Resolved review suggestions. - Code improvement. v4:

[PATCH v4 3/8] dma/cnxk: add DMA devops for all models of cn10xxx

Valid function pointers are set for DMA device operations i.e. cn10k_dmadev_ops are used for all cn10k devices. Signed-off-by: Radha Mohan Chintakuntla Signed-off-by: Amit Prakash Shukla --- v2: - Fix for bugs observed in v1. - Squashed few commits. v3: - Resolved review suggestions. - Code imp

[PATCH v4 2/8] dma/cnxk: changes for dmadev driver

Dmadev driver changes to align with dpdk spec. Fixes: 681851b347ad ("dma/cnxk: support CN10K DMA engine") Cc: sta...@dpdk.org Signed-off-by: Amit Prakash Shukla --- v2: - Fix for bugs observed in v1. - Squashed few commits. v3: - Resolved review suggestions. - Code improvement. v4: - Resolved

[PATCH v4 1/8] common/cnxk: use unique name for DPI memzone

roc_dpi was using vfid as part of name for memzone allocation. This led to memzone allocation failure in case of multiple physical functions. vfid is not unique by itself since multiple physical functions can have the same virtual function indices. So use complete DBDF as part of memzone name to ma

Re: [PATCH] net/iavf: fix checksum offloading

On Mon, Aug 21, 2023 at 1:54 PM Zhang, Qi Z wrote: > > Subject: [PATCH] net/iavf: fix checksum offloading > > > > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator that > > a checksum offload has been requested by an application. > > According to current implementation, actuall

Re: [PATCH v3] common/mlx5: replace use of PMD logtype

On Mon, Aug 21, 2023 at 09:16:25AM -0700, Stephen Hemminger wrote: > The goal to eliminate the generic PMD logtype. > One place it is used unnecessarily is in the mlx5 common code. > Change the one RTE_LOG() call here to use the same macro > as other log messages in same file. > > Fixes: 9c410b28b

Re: [PATCH v2 15/15] devtools: forbid inclusion of Linux header for PCI

On Mon, Aug 21, 2023 at 01:35:48PM +0200, David Marchand wrote: > Refrain from including Linux-only pci_regs.h header. > Instead, prefer our own definitions from the pci library. > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson > --- Acked-by: Tyler Retzlaff

[PATCH v3] common/mlx5: replace use of PMD logtype

The goal to eliminate the generic PMD logtype. One place it is used unnecessarily is in the mlx5 common code. Change the one RTE_LOG() call here to use the same macro as other log messages in same file. Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query") Cc: viachesl...@nvidia.com S

Re: [PATCH v2 02/15] bus/pci: add const to some experimental API

On Mon, Aug 21, 2023 at 01:35:35PM +0200, David Marchand wrote: > Those functions are fine with a const on the device pointer. > > Signed-off-by: David Marchand > Acked-by: Bruce Richardson > --- Acked-by: Tyler Retzlaff

[PATCH v13 21/21] pipeline: convert RTE_LOGTYPE_PIPELINE to dynamic type

Convert RTE_LOGTYPE_PIPELINE to a dynamic value. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 2 ++ lib/pipeline/rte_pipeline.h | 5 + 4 files changed, 8 insertions(+), 2 deletions(-) diff --git a/l

[PATCH v13 20/21] app/test: remove use of RTE_LOGTYPE_PIPELINE

Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v13 19/21] table: convert RTE_LOGTYPE_TABLE to dynamic type

Make an alias for RTE_LOGTYPE_TABLE in rte_table.h and use it. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/table/meson.build | 1 + lib/table/rte_table.c | 8 lib/table/rte_table.h | 4 5 files changed, 14 insertions(+), 2 del

[PATCH v13 18/21] hash: convert RTE_LOGTYPE_HASH to dynamic type

Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c| 5 + lib/hash/rte_thash.c | 3 +++ lib/hash/rte_thash_gfni.c | 3 +++ lib/log/log.c | 1 - lib/log/rte_log.

[PATCH v13 17/21] hash: move rte_hash_set_alg out header

The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v13 16/21] hash: move rte_thash_gfni stubs out of header file

Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 ++- lib/hash/rte_thash_gfni.c | 47 +++ lib/hash/rte_thash_gfni.h | 30 ---

[PATCH v13 15/21] port: convert RTE_LOGTYPE_PORT to dynamic type

Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v13 14/21] examples/ipsec-secgw: replace RTE_LOGTYPE_PORT

Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Acked-by: Akhil Goyal Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++--

[PATCH v13 13/21] sched: convert RTE_LOGTYPE_SCHED to dynamic type

Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/log/log.c | 2 -- lib/log/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files changed, 12 insertions(+), 4 delet

[PATCH v13 12/21] lpm: convert RTE_LOGTYPE_LPM to dynamic types

Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/fib/fib_log.h | 4 lib/fib/rte_fib.c | 3 +++ lib/fib/rte_

[PATCH v13 11/21] mempool: convert RTE_LOGTYPE_MEMPOOL to dynamic type

Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 2 ++ lib/mempool/rte_mempool.h | 8 lib/mempool/version.map | 3 +++ 5 files changed, 14 insertions

[PATCH v13 10/21] ring: convert RTE_LOGTYPE_RING to dynamic type

The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 5ec3c16250f5..212c5d7b8669 100644

[PATCH v13 09/21] power: convert RTE_LOGTYPE_POWER to dynamic type

Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- lib/power/guest_channel.c | 3 ++- lib/power/power_common.c | 2 ++ l

[PATCH v13 08/21] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- examples/l3fwd-power/main.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 3f0

[PATCH v13 07/21] examples/power: replace use of RTE_LOGTYPE_POWER

Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 10

[PATCH v13 06/21] acl: convert RTE_LOGTYPE_ACL to dynamic type

Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v13 05/21] mbuf: convert RTE_LOGTYPE_MBUF to dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/log/log.c| 1 - lib/log/rte_log.h| 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_mbuf.c

[PATCH v13 04/21] efd: convert RTE_LOGTYPE_EFD to dynamic type

Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/efd/rte_efd.c | 4 lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index dad962ce2

[PATCH v13 03/21] log: drop unused RTE_LOGTYPE_TIMER

The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index b51beb1a7604..4a7ff738750b 100644 --- a/lib/log/log.c +++ b/lib/log/log.c

[PATCH v13 02/21] eal: drop no longer used GSO logtype

The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/log/log.c | 1 - lib/log/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/log/log.c b/lib/log/log.c index 52c771fb6b84..b51beb1a7604 100644 --- a/lib/log/log

[PATCH v13 01/21] gso: don't log message on non TCP/UDP

If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Reviewed-by: Jiayu Hu Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 4 +--- lib/gso

[PATCH v13 00/21] Convert static log types in libraries to dynamic types

This patchset removes most of the uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since ther

Re: [PATCH] app/test: fix reference to master in bonding test

On Thu, Aug 17, 2023 at 07:44:48PM -0700, Stephen Hemminger wrote: > Missed in previous patch > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

Re: [PATCH] test: remove use of word master in test_red

On Thu, Aug 17, 2023 at 07:33:14PM -0700, Stephen Hemminger wrote: > No need to use term master here. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Tyler Retzlaff

Re: [PATCH v4 15/19] event/opdl: remove term sanity

On Wed, Aug 02, 2023 at 04:25:46PM -0700, Stephen Hemminger wrote: > Don't use non-inclusive term. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Liang Ma > drivers/event/opdl/opdl_evdev.c | 2 +- > drivers/event/opdl/opdl_evdev_init.c | 2 +- > 2 files changed, 2 insertions(+), 2

Re: [PATCH v6 04/11] app/test: make telemetry data test buildable on windows

On Wed, Aug 16, 2023 at 04:34:32PM +0100, Bruce Richardson wrote: > To enable the building of the telemetry data tests file when building on > windows, we need to provide a stub implementation. That way, the test > file is buildable any time the library itself is built. > > Signed-off-by: Bruce Ri

Re: [PATCH v5 03/10] app/test: make telemetry data test buildable on windows

On Tue, Aug 15, 2023 at 04:10:47PM +0100, Bruce Richardson wrote: > To enable the building of the telemetry data tests file when building on > windows, we need to provide a stub implementation. That way, the test > file is buildable any time the library itself is built. > > Signed-off-by: Bruce Ri

[PATCH v7] eventdev/eth_rx: add new adapter create API

Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for creating Rx adapter instance. This API is similar to rte_event_eth_rx_adapter_create_ext() with an additional input argument for adapter configuration parameters of type "struct rte_event_eth_rx_adapter_params". Signed-off-by: Nag

Re: [PATCH v5 3/3] power: amd power monitor support

On Fri, Aug 18, 2023 at 02:48:42PM +0100, Bruce Richardson wrote: > On Fri, Aug 18, 2023 at 02:25:14PM +0100, Ferruh Yigit wrote: > > On 8/17/2023 3:18 PM, Konstantin Ananyev wrote: > > > > > >>> Caution: This message originated from an External Source. Use proper > > >>> caution > > >>> when ope

Re: [PATCH v6] eventdev/eth_rx: add new adapter create API

On Mon, Aug 21, 2023 at 8:59 PM Naga Harish K S V wrote: > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > creating Rx adapter instance. This API is similar to > rte_event_eth_rx_adapter_create_ext() with an additional input > argument for adapter configuration parameters o

Re: [dpdk-dev] [PATCH ] common/cnxk: fix ROC naming convention

On Fri, Aug 18, 2023 at 9:31 AM wrote: > > From: Satheesh Paul > > Fix ROC code naming convention. > > Fixes: d110c44d29e7 ("common/cnxk: support flow aging") > > Signed-off-by: Satheesh Paul > Reviewed-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/commo

[PATCH v6] eventdev/eth_rx: add new adapter create API

Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for creating Rx adapter instance. This API is similar to rte_event_eth_rx_adapter_create_ext() with an additional input argument for adapter configuration parameters of type "struct rte_event_eth_rx_adapter_params". Signed-off-by: Nag

RE: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > Sent: Monday, 21 August 2023 15.54 > > >From: Stephen Hemminger > >Sent: Thursday, May 18, 2023 9:04 PM > > > >-- > >On Thu, 18 May 2023 13:45:29 + > >Ankur Dwivedi wrote

[PATCH v2] crypto/ipsec_mb: add digest encrypted feature

AESNI_MB PMD does not support Digest Encrypted. This patch adds a check and support for this feature. Signed-off-by: Brian Dooley --- v2: Fixed CHECKPATCH warning --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 107 +++-- 1 file changed, 102 insertions(+), 5 deletions(-) diff -

Re: [PATCH v5 04/10] app/test: build using per-file dependency matrix

Hi David, Responding to your Slack request about merging Bruce's patch ahead of yours here so there is more visibility. That is fine, but as you point out it will mean a temporary loss of test coverage, as it will disable arm unit testing until either 1. your patch fixing the flags test hits main

[PATCH v2] common/mlx5: replace use of PMD logtype

The goal to eliminate the generic PMD logtype. One place it is used unnecessarily is in the mlx5 common code. Change the one RTE_LOG() call here to use the same macro as other log messages in same file. Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query") Cc: viachesl...@nvidia.com S

RE: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

>-Original Message- >From: Stephen Hemminger >Sent: Thursday, May 18, 2023 9:04 PM >To: Ankur Dwivedi >Cc: Thomas Monjalon ; Jerin Jacob Kollanukkaran >; dev@dpdk.org >Subject: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch > >External Email > >-

Re: [PATCH v3 1/8] common/cnxk: use unique name for DPI memzone

On Fri, Aug 18, 2023 at 2:32 PM Amit Prakash Shukla wrote: > > roc_dpi was using vfid as part of name for memzone allocation. > This led to memzone allocation failure in case of multiple > physical functions. vfid is not unique by itself since multiple > physical functions can have the same virtua

RE: [RFC] ring: further performance improvements with C11

> > > > > For improved performance over the current C11 based ring > > > > > implementation following changes were made. > > > > > (1) Replace tail store with RELEASE semantics in > > > > > __rte_ring_update_tail with a RELEASE fence. Replace load of the > > > > > tail with ACQUIRE semantics in _

Re: 21.11.5 patches review and test

On 21/08/2023 11:50, Mcnamara, John wrote: -Original Message- From: Kevin Traynor Any updates from Intel validation team ? The release is due tomorrow (22nd) but I can postpone it if you need a few more days to complete testing. Hi, We have had some attritions on the Intel validat

RE: [PATCH] net/iavf: fix checksum offloading

> -Original Message- > From: David Marchand > Sent: Friday, August 18, 2023 5:04 PM > To: dev@dpdk.org > Cc: echau...@redhat.com; m...@redhat.com; sta...@dpdk.org; Wu, Jingjing > ; Xing, Beilei ; Doherty, Declan > ; Sinha, Abhijit ; Nicolau, > Radu > Subject: [PATCH] net/iavf: fix chec

[PATCH v2 15/15] devtools: forbid inclusion of Linux header for PCI

Refrain from including Linux-only pci_regs.h header. Instead, prefer our own definitions from the pci library. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/ch

[PATCH v2 14/15] pci: define some AER constants

Define some Advanced Error Reporting constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/event/dlb2/pf/dlb2_main.c | 10 +++--- lib/pci/rte_pci.h | 5 + 2 files changed, 8 insertions(+), 7 deletions(-) diff -

[PATCH v2 13/15] pci: define some PRI constants

Define some PCI PRI extended feature constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/event/dlb2/pf/dlb2_main.c | 11 --- lib/pci/rte_pci.h | 5 + 2 files changed, 9 insertions(+), 7 deletions(-) diff

[PATCH v2 12/15] pci: define some ACS constants

Define some PCI ACS extended feature constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/event/dlb2/pf/dlb2_main.c | 23 --- lib/pci/rte_pci.h | 9 + 2 files changed, 17 insertions(+), 15 d

[PATCH v2 11/15] pci: define some extended capability constants

Define some PCI extended capability constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/event/dlb2/pf/dlb2_main.c | 7 ++- lib/pci/rte_pci.h | 4 +++- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/

[PATCH v2 10/15] pci: define some PCIe constants

Define some PCI Express constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/event/dlb2/pf/dlb2_main.c | 40 --- drivers/net/bnx2x/bnx2x.c | 16 ++--- drivers/net/bnx2x/bnx2x.h | 35 -

[PATCH v2 09/15] pci: define some PM constants

Define some PCI Power Management constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/net/bnx2x/bnx2x.c | 17 + drivers/net/bnx2x/bnx2x.h | 5 - lib/pci/rte_pci.h | 6 ++ 3 files changed, 15 insertions

[PATCH v2 08/15] pci: define some BAR constants

Define some PCI BAR constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_vfio.c | 7 +++ lib/pci/rte_pci.h| 4 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/li

[PATCH v2 07/15] pci: define some command constants

Define some PCI command constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_vfio.c | 8 drivers/event/dlb2/pf/dlb2_main.c | 8 +++- lib/pci/rte_pci.h | 6 -- 3 files changed, 11 inse

[PATCH v2 06/15] pci: define some MSIX constants

Define some PCI MSIX constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_init.h | 18 -- drivers/bus/pci/linux/pci_vfio.c | 7 --- drivers/crypto/virtio/virtio_pci.c | 6 ++ drivers/even

[PATCH v2 05/15] pci: define some capability constants

Define some PCI capability constants and use them in existing drivers. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_vfio.c| 2 +- drivers/crypto/virtio/virtio_pci.c | 12 ++-- drivers/event/dlb2/pf/dlb2_main.c | 6 ++ drivers/net/bn

[PATCH v2 04/15] bus/pci: find PCI capability

Introduce two helpers so that drivers stop reinventing the wheel when it comes to finding capabilities in a device PCI configuration space. Use it in existing drivers. Note: - base/ drivers code is left untouched, only some wrappers in cxgbe are touched, - bnx2x maintained a per device cache of

[PATCH v2 03/15] bus/pci: rework MSIX discovery with VFIO

This is a preparatory step before using new helpers for finding PCI capabilities. In the code querying PCI capabilities for checking MSIX availability, replace direct calls to VFIO fd with the existing helpers for reading PCI configuration space: this requires setting VFIO fd in the PCI device obje

[PATCH v2 02/15] bus/pci: add const to some experimental API

Those functions are fine with a const on the device pointer. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/bus/pci/pci_common.c | 4 ++-- drivers/bus/pci/rte_bus_pci.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b

[PATCH v2 01/15] drivers: remove duplicated PCI master control

Use existing API to cleanup duplicated code. Signed-off-by: David Marchand Acked-by: Bruce Richardson --- drivers/bus/pci/linux/pci_uio.c| 32 +-- drivers/bus/pci/linux/pci_vfio.c | 41 ++ drivers/net/hns3/hns3_ethdev_vf.c | 25 +---

[PATCH v2 00/15] Cleanup PCI(e) drivers

Rather than rely on Linux headers to find some PCI(e) standard constants or reinvent the same PCI capability helper, this series complements the pci library and the pci bus driver. PCI drivers can then use OS agnostic macros and helpers. -- David Marchand Changes since v1: - fix VFIO-backed dri

RE: 21.11.5 patches review and test

> -Original Message- > From: Kevin Traynor > > Any updates from Intel validation team ? The release is due tomorrow > (22nd) but I can postpone it if you need a few more days to complete > testing. Hi, We have had some attritions on the Intel validation team so some of the co-ordinat

RE: Ring library optimization idea

Hi Morten, > > Most of the fast path ring library functions access the two cache lines > > containing > > respectively the r->prod and r->cons structures. > > > > Some of the fast path functions also have to fetch r->capacity and r->mask, > > which reside in another cache line. > > > > What do

Re: [PATCH v5] eventdev/eth_rx: add new adapter create API

On Fri, Aug 18, 2023 at 3:07 PM Naga Harish K S V wrote: > > Add new API "rte_event_eth_rx_adapter_create_ext_with_params()" for > creating Rx adapter instance. This API is similar to > rte_event_eth_rx_adapter_create_ext() with an additional input > argument for adapter configuration parameters o

[PATCH v4] net/iavf: fix VLAN offload strip flag inconsistency

For i40e kernel driver which only supports vlan(v1) VIRTCHNL OP, it will set strip on when setting filter on but dpdk side will not change strip flag. To be consistent with dpdk side, disable strip again. Fixes: cb25d4323fbf ("net/avf: enable MAC VLAN and promisc ops") Cc: sta...@dpdk.org Signed-

RE: [PATCH] common/qat: enable gen4 c devices

Hi David, > > > > +-+-+-+-+--+---+---++--- > -+--+++ > > | Yes | No | No | 4 | 401xxx | IDZ/ N/A | qat_401xxx| > > 4xxx | > 4942 | 2| 4943 | 16 | > > > > +-+-+

RE: Bug in non-power-of-2 rings?

+CC Olivier, referring to your review of the original patch. > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Monday, 21 August 2023 11.29 > > Hi everyone, > > > On Sun, Aug 20, 2023 at 11:07:33AM +0200, Morten Brørup wrote: > > > Bruce, Honnappa, Konstantin, > > > > > >

[PATCH v2] common/qat: enable QAT 2.0c devices

This commit enables QAT 2.0c devices in the Intel QuickAssist Technology PMD. These are 4th Generation QAT, 402xx devices. Signed-off-by: Ciara Power --- v2: - Fixed kernel module. - Modified commit to align naming of new QAT device. --- doc/guides/cryptodevs/qat.rst | 4 doc/

RE: [PATCH v5 1/8] net/rnp: add skeleton

Hi Thomas, Thanks for your useful advice, previously only focused on code format and Ignored document format. Regards Wenbo > -Original Message- > From: Thomas Monjalon > Sent: 2023年8月15日 19:11 > To: Wenbo Cao > Cc: dev@dpdk.org; ferruh.yi...@amd.com; andrew.rybche...@oktetlabs.ru;

RE: Bug in non-power-of-2 rings?

Hi everyone, > On Sun, Aug 20, 2023 at 11:07:33AM +0200, Morten Brørup wrote: > > Bruce, Honnappa, Konstantin, > > > > Back in 2017, Bruce added support for non-power-of-2 rings with this patch > > [1]. > > > > [1]: > > https://git.dpdk.org/dpdk/commit/lib/librte_ring/rte_ring.h?id=b7446115554

Re: 21.11.5 patches review and test

On 02/08/2023 17:31, Kevin Traynor wrote: Hi all, Here is a list of patches targeted for stable release 21.11.5. The planned date for the final release is 22nd August. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the f

[PATCH v3 3/3] ethdev: cleanup shared data with the last port

If no port is allocated and no port owner is still registered, ethdev from a primary process may release the memzone used to store port data. This makes it possible for the DPDK memory allocator to release associated resources back to the OS. Signed-off-by: David Marchand Acked-by: Morten Brørup

[PATCH v3 1/3] ethdev: protect shared memory accesses under one lock

ethdev currently uses two locks to protect access around eth_dev_shared_data: - one (process local) for avoiding multiple threads to reserve/lookup the eth_dev_shared_data memzone, - one (shared with other processes) for protecting port allocation/destruction, Simplify the logic and put everyt

[PATCH v3 2/3] ethdev: avoid panicking in absence of ethdev shared data

This is a preparation step before freeing the ethdev shared data memzone. Previously, because the primary process never freed the memzone, a secondary process could assume this memzone was present. But in the next commit, this will change. Make eth_dev_shared_data_prepare() report whether the memz

Re: 21.11.5 patches review and test

On 17/08/2023 10:45, Ali Alnubani wrote: -Original Message- From: Kevin Traynor Sent: Wednesday, August 2, 2023 7:31 PM To: sta...@dpdk.org Cc: dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; benjamin.wal...@intel.com; David Christensen ; Hemant Agrawal ; Ian Stokes ; Jerin Jacob ; John

[PATCH v3 0/3] Release ethdev shared memory on port cleanup

This series was triggered after investigating why the eal_flags_file_prefix_autotest unit test was failing in the case of statically built binaries [1]). For now, I went with a simple (naive) approach and put all accesses to the shared data under a single lock: ethdev maintainers, it is your turn

  1   2   >