[PATCH] common/idpf: fix Tx checksum offload

2023-09-22 Thread beilei . xing
From: Beilei Xing For multi-segment packets, the Tx checksum offload doesn't work except the last segment, because other segments don't enable HW checksum offload successfully. Fixes: ef47d95e9031 ("net/idpf: fix TSO") Fixes: 8c6098afa075 ("common/idpf: add Rx/Tx data path") Cc: sta...@dpdk.org

[PATCH v4 0/3] Add dispatcher library

2023-09-22 Thread Mattias Rönnblom
The purpose of the dispatcher library is to decouple different parts of an eventdev-based application (e.g., processing pipeline stages), sharing the same underlying event device. The dispatcher replaces the conditional logic (often, a switch statement) that typically follows an event device deque

[PATCH v4 1/3] lib: introduce dispatcher library

2023-09-22 Thread Mattias Rönnblom
The purpose of the dispatcher library is to help reduce coupling in an Eventdev-based DPDK application. In addition, the dispatcher also provides a convenient and flexible way for the application to use service cores for application-level processing. Signed-off-by: Mattias Rönnblom Tested-by: Pe

[PATCH v4 3/3] doc: add dispatcher programming guide

2023-09-22 Thread Mattias Rönnblom
Provide programming guide for the dispatcher library. Signed-off-by: Mattias Rönnblom -- PATCH v3: o Adapt guide to the dispatcher API name changes. PATCH: o Improve grammar and spelling. RFC v4: o Extend event matching section of the programming guide. o Improve grammar and spelling. ---

[PATCH v4 2/3] test: add dispatcher test suite

2023-09-22 Thread Mattias Rönnblom
Add unit tests for the dispatcher. -- PATCH v3: o Adapt the test suite to dispatcher API name changes. PATCH v2: o Test finalize callback functionality. o Test handler and finalizer count upper limits. o Add statistics reset test. o Make sure dispatcher supply the proper event dev id and por

[PATCH] eal/unix: enhance error reporting for firmware

2023-09-22 Thread David Marchand
Put more details if a libarchive context initialisation fails. Signed-off-by: David Marchand --- lib/eal/unix/eal_firmware.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c index

Re: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read

2023-09-22 Thread David Marchand
Hello, On Fri, Sep 22, 2023 at 5:59 AM Srikanth Yalavarthi wrote: > > From: David Marchand > > On Thu, Sep 21, 2023 at 3:06 PM Srikanth Yalavarthi > > wrote: > > > > > > archive. This causes the ML firmware binary to be parsed > > > > > > incorrectly. > > > > > > > > > > + @David Marchand rte_

Re: [PATCH] eal: fix modify data area after memset

2023-09-22 Thread Fengnan Chang
ping Fengnan Chang 于2023年9月12日周二 17:05写道: > > Let's look at this path: > malloc_elem_free >->malloc_elem_join_adjacent_free > ->join_elem(elem, elem->next) > > 0. cur elem's pad > 0 > 1. data area memset in malloc_elem_free first. > 2. next elem is free, try to join cur elem and next. >

Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info

2023-09-22 Thread Maxime Coquelin
Hi Nicolas, On 9/19/23 22:51, Chautru, Nicolas wrote: Hi Maxime, This is neither part of 3GPP per se, nor specific to VRB device. Let me provide more context. The SRS processing chain (https://doc.dpdk.org/guides/prog_guide/bbdev.html#bbdev-fft-operation) includes a pointwise multiplication

[RFC PATCH 0/5] Using shared mempools for zero-copy IO proxying

2023-09-22 Thread Bruce Richardson
Following my talk at the recent DPDK Summit [1], here is an RFC patchset containing the prototypes I created which led to the talk. This patchset is simply to demonstrate: * what is currently possible with DPDK in terms of zero-copy IPC * where the big gaps, and general problem areas are * what t

[RFC PATCH 1/5] bus: new driver to accept shared memory over unix socket

2023-09-22 Thread Bruce Richardson
Add a new driver to DPDK which supports taking in memory e.g. hugepage memory via a unix socket connection and maps it into the DPDK process replacing the current socket memory as the default memory for use by future requests. Signed-off-by: Bruce Richardson --- drivers/bus/meson.build

[RFC PATCH 2/5] mempool: driver for mempools of mbufs on shared memory

2023-09-22 Thread Bruce Richardson
This mempool driver can be used with the shared_mem bus driver to create a pool of shared mbufs on a shared memory segment. Signed-off-by: Bruce Richardson --- drivers/mempool/meson.build| 1 + drivers/mempool/shared_mem/meson.build | 10 +++ drivers/mempool/shared_mem/share

[RFC PATCH 3/5] net: new ethdev driver to communicate using shared mem

2023-09-22 Thread Bruce Richardson
This ethdev builds on the previous shared_mem bus driver and shared_mem mempool driver to provide an ethdev interface which can allow zero-copy I/O from one process to another. Signed-off-by: Bruce Richardson --- drivers/net/meson.build | 1 + drivers/net/shared_mem/meson.build

[RFC PATCH 4/5] app: add IO proxy app using shared memory interfaces

2023-09-22 Thread Bruce Richardson
This app uses the shared memory poll, and shared ethdev infrastructure to act as a zero-copy IO proxy to other applications. It has been tested and verified to work successfully proxying data to testpmd instances on the system, with those testpmd instances each being passed a unix socket to work wi

[RFC PATCH 5/5] app/io-proxy: add startup commands

2023-09-22 Thread Bruce Richardson
To make it easier to run the io-proxy, add a startup command line example to configure by default 4 sockets on two ports. Signed-off-by: Bruce Richardson --- app/io-proxy/dpdk-io-proxy.cmds | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 app/io-proxy/dpdk-io-proxy.cmds diff --gi

RE: [PATCH] common/idpf: fix Tx checksum offload

2023-09-22 Thread Huang, ZhiminX
> -Original Message- > From: beilei.x...@intel.com > Sent: Friday, September 22, 2023 11:30 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org > Subject: [PATCH] common/idpf: fix Tx checksum offload > > From: Beilei Xing > > For multi-segment packets, the Tx check

[PATCH v2] net/af_xdp: fix cflags to appropriate UMEM feature

2023-09-22 Thread Shibin Koikkara Reeny
Fix missing RTE_NET_AF_XDP_SHARED_UMEM flag in xsk_socket__create_shared(). rte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0 init_internals(): Shared UMEM feature not available. Check kernel and libbpf version rte_pmd_af_xdp_probe(): Failed to init internals vdev_probe(): failed to

Re: [PATCH 1/2] net/sfc: offer indirect VXLAN encap action in transfer flows

2023-09-22 Thread Ferruh Yigit
On 9/22/2023 7:32 AM, Andrew Rybchenko wrote: > On 8/10/23 21:06, Ivan Malov wrote: >> Parsing inline action VXLAN_ENCAP repeating in many flows is >> expensive, so offer support for its indirect version. Query >> operation is not supported for this action. The next patch >> will add a means to upd

Re: [PATCH 1/2] net/mana: enable 32 bit build for mana driver

2023-09-22 Thread Ferruh Yigit
On 9/21/2023 9:53 PM, Long Li wrote: >> Subject: [PATCH 1/2] net/mana: enable 32 bit build for mana driver >> >> Enable 32 bit build on x86 Linux. Fixed build warnings and errors when >> building in >> 32 bit. >> >> With this patch, mana will be able to build into 32 bit. However, another >> patc

[PATCH 1/2] eal: introduce x86 processor identification

2023-09-22 Thread David Marchand
In some really specific cases, it may be needed to get a detailed information on the processor running a DPDK application for drivers to achieve better performance, or for matters that concern only them. Those information are highly arch-specific and require a specific API. Introduce a set of fun

[PATCH 0/2] Introduce x86 specific identification API

2023-09-22 Thread David Marchand
Rather than have every driver implement their own set of cpuid() ugly stuff, provide an abstracted (gcc/clang vs MSVC) API for querying about x86 processor details. Note: - coming up with a cross arch API seems a difficult task, hence a arch specific API has been preferred. If other arches have

[PATCH 2/2] common/mlx5: use EAL x86 processor identification

2023-09-22 Thread David Marchand
Rather than use an ugly asm thing, use newly introduced EAL x86 API. Signed-off-by: David Marchand --- drivers/common/mlx5/mlx5_common.c | 81 --- 1 file changed, 21 insertions(+), 60 deletions(-) diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/

Re: [PATCH v1] net/axgbe: use CPUID to identify cpu

2023-09-22 Thread David Marchand
On Fri, Sep 15, 2023 at 4:35 PM Ferruh Yigit wrote: > > On 9/15/2023 2:02 PM, David Marchand wrote: > > On Fri, Sep 15, 2023 at 12:54 PM Ferruh Yigit wrote: > >> > >> On 8/31/2023 1:31 PM, Selwin Sebastian wrote: > >>> Using root complex to identify cpu will not work for vm passthrough. > >>> CPU

Re: [PATCH 1/2] eal: introduce x86 processor identification

2023-09-22 Thread Bruce Richardson
On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote: > In some really specific cases, it may be needed to get a detailed > information on the processor running a DPDK application for drivers to > achieve better performance, or for matters that concern only them. > > Those information ar

Re: [PATCH 1/2] eal: introduce x86 processor identification

2023-09-22 Thread Bruce Richardson
On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote: > In some really specific cases, it may be needed to get a detailed > information on the processor running a DPDK application for drivers to > achieve better performance, or for matters that concern only them. > > Those information ar

Re: [PATCH 1/2] eal: introduce x86 processor identification

2023-09-22 Thread Bruce Richardson
On Fri, Sep 22, 2023 at 11:38:38AM +0100, Bruce Richardson wrote: > On Fri, Sep 22, 2023 at 11:37:20AM +0200, David Marchand wrote: > > In some really specific cases, it may be needed to get a detailed > > information on the processor running a DPDK application for drivers to > > achieve better per

Re: [PATCH 00/13] improve the modularization of NFP PMD

2023-09-22 Thread Ferruh Yigit
On 9/20/2023 12:34 PM, Chaoyong He wrote: > This patch series aims to improve the modularization of NFP PMD through: > * Make the header files self-containing by adding the correct include > statement. > * Try to keep the interface of modules as small as possible. > * Remove the unneeded include

Re: [PATCH 0/1] make file prefix unit test more resilient

2023-09-22 Thread Thomas Monjalon
20/09/2023 12:09, Bruce Richardson: > On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote: > > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson > > wrote: > > > > > > When examining the IOL testing failures for patch series [1], I observed > > > that the failures reported were in the e

Re: [PATCH 0/1] make file prefix unit test more resilient

2023-09-22 Thread Bruce Richardson
On Fri, Sep 22, 2023 at 02:57:32PM +0200, Thomas Monjalon wrote: > 20/09/2023 12:09, Bruce Richardson: > > On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote: > > > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson > > > wrote: > > > > > > > > When examining the IOL testing failures fo

Re: [PATCH v3 00/11] rework thread management

2023-09-22 Thread David Marchand
On Wed, Sep 13, 2023 at 1:45 PM Thomas Monjalon wrote: > > The main effect of this patch series is to > remove calls to pthread functions except for pthread_cancel and locks. > > The function rte_thread_create_control() does not take thread attributes > settings anymore as it looks a useless compl

Re: [PATCH] eal: fix location of per lcore macro documentation

2023-09-22 Thread David Marchand
On Thu, Sep 21, 2023 at 8:14 PM Tyler Retzlaff wrote: > > doxygen document generation does traverse RTE_TOOLCHAIN_MSVC conditional > compilation paths so move the documentation for per lcore macros out of > the RTE_TOOLCHAIN_MSVC block. > > Fixes: b2f967dcae69 ("eal: implement per lcore variables

Re: [PATCH 0/6] docs: Unify Getting Started Guides

2023-09-22 Thread David Marchand
Hello David, On Wed, Sep 20, 2023 at 5:49 PM David Young wrote: > > The separate Getting Started Guides for Linux, FreeBSD, and Windows have been > consolidated into a single, streamlined guide to simplify the user experience > and facilitate easier maintenance. > > David Young (6): > Section 1

RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode

2023-09-22 Thread Feifei Wang
Hi, Konstantin > -Original Message- > From: Feifei Wang > Sent: Tuesday, September 5, 2023 11:11 AM > To: Konstantin Ananyev ; Konstantin > Ananyev > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; Yuying Zhang ; Beilei > Xing ; nd ; nd ; nd > ; nd ; nd > Subject: RE:

Re: [PATCH] ethdev: validate reserved fields

2023-09-22 Thread Ferruh Yigit
On 9/21/2023 5:33 PM, Ferruh Yigit wrote: > On 9/21/2023 4:12 PM, Ferruh Yigit wrote: >> On 5/26/2023 9:15 AM, Bruce Richardson wrote: >>> On Thu, May 25, 2023 at 01:39:42PM -0700, Stephen Hemminger wrote: The various reserved fields added to ethdev could not be safely used for future ext

Re: [PATCH v12 0/4] Recycle mbufs from Tx queue into Rx queue

2023-09-22 Thread Ferruh Yigit
On 9/20/2023 2:12 PM, Ferruh Yigit wrote: > On 8/24/2023 8:36 AM, Feifei Wang wrote: >> Currently, the transmit side frees the buffers into the lcore cache and >> the receive side allocates buffers from the lcore cache. The transmit >> side typically frees 32 buffers resulting in 32*8=256B of store

RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode

2023-09-22 Thread Feifei Wang
> -Original Message- > From: Feifei Wang > Sent: Friday, September 22, 2023 10:59 PM > To: Konstantin Ananyev ; Konstantin > Ananyev > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; Yuying Zhang ; Beilei > Xing ; nd ; nd ; nd > ; nd ; nd ; nd > Subject: RE: [PATCH v11

Re: [PATCH 0/6] docs: Unify Getting Started Guides

2023-09-22 Thread Bruce Richardson
On Fri, Sep 22, 2023 at 04:47:55PM +0200, David Marchand wrote: > Hello David, > > On Wed, Sep 20, 2023 at 5:49 PM David Young wrote: > > > > The separate Getting Started Guides for Linux, FreeBSD, and Windows have > > been > > consolidated into a single, streamlined guide to simplify the user

RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode

2023-09-22 Thread Konstantin Ananyev
Hi Feifei, > > > -Original Message- > > > From: Feifei Wang > > > Sent: Tuesday, September 5, 2023 11:11 AM > > > To: Konstantin Ananyev ; Konstantin > > > Ananyev > > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > > ; Ruifeng Wang > > ; > > > Yuying Zhang ; Beilei Xing > > > ; nd ;

RE: [PATCH v1 1/7] bbdev: add FFT version member in driver info

2023-09-22 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, September 22, 2023 1:15 AM > To: Chautru, Nicolas ; > hemant.agra...@nxp.com; dev@dpdk.org > Cc: david.march...@redhat.com; Vargas, Hernan > > Subject: Re: [PATCH v1 1/7] bbdev: add FFT version member in driver info

[PATCH 1/1] eal: enable xz read support and ignore warning

2023-09-22 Thread Srikanth Yalavarthi
archive_read_support_filter_xz returns a warning when compression is not fully supported and is supported through external program. This warning can be ignored when reading the files through firmware open as only decompression is required. Fixes: 40edb9c0d36b ("eal: handle compressed firmware") Cc

RE: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for firmware read

2023-09-22 Thread Srikanth Yalavarthi
> -Original Message- > From: David Marchand > Sent: 22 September 2023 13:38 > To: Srikanth Yalavarthi > Cc: Jerin Jacob ; Prince Takkar > ; dev@dpdk.org; Shivah Shankar Shankar Narayan > Rao ; Anup Prabhu > Subject: Re: [EXT] Re: [PATCH v1 02/34] ml/cnxk: drop use of RTE API for > firmwa

SIGILL in rte_cpu_get_flag_enabled / RTE_CPUFLAG_RTM

2023-09-22 Thread Bernd Schubert
Hello, I'm trying to compile our tools on an older lab system and get Program received signal SIGILL, Illegal instruction. 0x7434c766 in rte_cpu_get_flag_enabled (feature=feature@entry=RTE_CPUFLAG_RTM) at ../lib/eal/x86/rte_cpuflags.c:173 173 return (regs[feat->reg] >> feat-

Re: SIGILL in rte_cpu_get_flag_enabled / RTE_CPUFLAG_RTM

2023-09-22 Thread Bernd Schubert
This already has been reported here https://inbox.dpdk.org/users/c7ff2508-d633-404e-95af-5f604d8e8...@intel.com/t/ but I don't see a solution there. It just ends up asking for the line numbers. Well, the line is __cpuid_count(feat->leaf, feat->subleaf, regs[RTE_REG_EAX], r

[PATCH v2 00/12] event DMA adapter library support

2023-09-22 Thread Amit Prakash Shukla
This series adds support for event DMA adapter library. API's defined as part of this library can be used by the application for DMA transfer of data using event based mechanism. v2: - Resolved review comments. - Patch split into multiple patches. Amit Prakash Shukla (12): eventdev: introduce e

[PATCH v2 01/12] eventdev: introduce event DMA adapter library

2023-09-22 Thread Amit Prakash Shukla
Introduce event DMA adapter APIs. The change provides information on adapter modes and usage. Application can use this event adapter interface to transfer packets between DMA device and event device. Signed-off-by: Amit Prakash Shukla --- MAINTAINERS |5 + d

[PATCH v2 02/12] eventdev: api to get DMA adapter capabilities

2023-09-22 Thread Amit Prakash Shukla
Added a new eventdev API rte_event_dma_adapter_caps_get(), to get DMA adapter capabilities supported by the driver. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/meson.build| 2 +- lib/eventdev/rte_eventdev.c | 23 +++ lib/eventdev/rte_eventdev.h | 2 +- lib/meson

[PATCH v2 03/12] eventdev: add DMA adapter API to create and free

2023-09-22 Thread Amit Prakash Shukla
This patch adds API support to create and free DMA adapter. Signed-off-by: Amit Prakash Shukla --- config/rte_config.h | 1 + lib/eventdev/meson.build | 1 + lib/eventdev/rte_event_dma_adapter.c | 335 +++ 3 files changed, 337 insertions(+

[PATCH v2 04/12] eventdev: api support for vchan add and delete

2023-09-22 Thread Amit Prakash Shukla
Added API support to add and delete vchan's for a DMA device. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 204 +++ 1 file changed, 204 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.

[PATCH v2 05/12] eventdev: add support for service function

2023-09-22 Thread Amit Prakash Shukla
Added support for DMA adapter service function for event devices. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 589 +++ 1 file changed, 589 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adap

[PATCH v2 06/12] eventdev: api support for DMA adapter start stop

2023-09-22 Thread Amit Prakash Shukla
Added API support to start and stop DMA adapter. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 69 1 file changed, 69 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index a9b945

[PATCH v2 08/12] eventdev: add DMA adapter support for runtime params

2023-09-22 Thread Amit Prakash Shukla
Added support to set and get runtime params for DMA adapter. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 93 1 file changed, 93 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c

[PATCH v2 07/12] eventdev: api support to get DMA adapter service ID

2023-09-22 Thread Amit Prakash Shukla
Added API support to get DMA adapter service ID. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index 2f574cb7ea..e66e0

[PATCH v2 09/12] eventdev: add support for DMA adapter stats

2023-09-22 Thread Amit Prakash Shukla
Added DMA adapter stats support for get and reset functions. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 95 1 file changed, 95 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c

[PATCH v2 10/12] eventdev: add support for DMA adapter enqueue

2023-09-22 Thread Amit Prakash Shukla
Added support for DMA adapter enqueue. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index 06a09371d2..b55b40cd46 100644 -

[PATCH v2 11/12] eventdev: add DMA adapter port get

2023-09-22 Thread Amit Prakash Shukla
Added support for DMA adapter port get. Signed-off-by: Amit Prakash Shukla --- lib/eventdev/rte_event_dma_adapter.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index b55b40cd46..5f52977543 1006

[PATCH v2 12/12] app/test: add event DMA adapter auto-test

2023-09-22 Thread Amit Prakash Shukla
Added testsuite to test the dma adapter functionality. The testsuite detects event and DMA device capability and accordingly dma adapter is configured and modes are tested. Signed-off-by: Amit Prakash Shukla --- app/test/meson.build | 1 + app/test/test_event_dma_adapter.c | 808 +

RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode

2023-09-22 Thread Feifei Wang
> -Original Message- > From: Konstantin Ananyev > Sent: Saturday, September 23, 2023 12:41 AM > To: Feifei Wang ; Konstantin Ananyev > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; Yuying Zhang ; Beilei > Xing ; nd ; nd ; nd > ; nd ; nd ; nd ; > nd > Subject: RE: