> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 12 February 2024 23.57
>
> On Mon, 12 Feb 2024 14:36:02 -0800
> Tyler Retzlaff wrote:
>
> > Replace some missed zero length arrays not captured in the
> > original series.
> > https://patchwork.dpdk.org/project/dpdk/li
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Monday, 12 February 2024 21.52
>
> Provide __rte_section(name) macro that allocates and names a section
> or segment that works with both MSVC and GCC.
>
> Update RTE_TRACE_POINT_REGISTER with __rte_section("__rte_trace_point")
On Mon, Feb 12, 2024 at 10:45:40PM -0800, Tyler Retzlaff wrote:
> The zero sized RTE_MARKER typedefs are a GCC extension unsupported by
> MSVC. Replace the use of the RTE_MARKER typedefs with anonymous unions.
>
> Note:
>
> v1 of the series tried to maintain the API after some study it has been
On Mon, Feb 12, 2024 at 01:49:02PM -0800, Tyler Retzlaff wrote:
> MSVC does not support GCC args... forwarding of args replace
> with ... and __VA_ARGS__ when forwarding. Both forms of
> forwarding are a compiler extension but the latter is supported
> by both MSVC and GCC.
>
> I have not been ab
On Mon, Feb 12, 2024 at 01:49:05PM -0800, Tyler Retzlaff wrote:
> Use ... and forward with __VA_ARGS__ instead of args... and args.
> Neither mechanism is conformant with the standard but the former works
> with both GCC and MSVC.
>
> Signed-off-by: Tyler Retzlaff
> ---
> lib/cfgfile/rte_cfgfile
On Mon, Feb 12, 2024 at 01:49:06PM -0800, Tyler Retzlaff wrote:
> Use ... and forward with __VA_ARGS__ instead of args... and args.
> Neither mechanism is conformant with the standard but the former works
> with both GCC and MSVC.
>
> Fix checkpatches warning about style while(0) -> while (0)
>
>
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Monday, 12 February 2024 22.49
>
> MSVC does not support GCC args... forwarding of args replace
> with ... and __VA_ARGS__ when forwarding. Both forms of
> forwarding are a compiler extension but the latter is supported
> by bot
On Thu, Feb 8, 2024 at 3:32 PM Aaron Conole wrote:
> > Fedora 37 has reached end of life in December 2023.
> > Ubuntu 20.04 is getting quite old.
> >
> > Switch to more recent versions.
> >
> > With this move, some packages provided by those distributions are now
> > recent enough to extend our bu
On 2/12/2024 5:48 AM, Stephen Hemminger wrote:
> The sfc base code had its own definition of static assertions
> using the out of bound array access hack. Replace it with a
> static_assert like rte_common.h.
>
> The use of null pointer to compute offset is not always a constant
> in older versions
The location of indexed rules is determined by the index, not the item
hash. A matcher test is added to prevent access to non-existent items.
This avoids unnecessary processing and potential segmentation faults.
Fixes: 405242c ("net/mlx5/hws: add rule object")
Signed-off-by: Itamar Gozlan
Acked-b
Don't allow the user to mask over rsvd1 / rsvd2 fields which are not
supported.
Fixes: dbff89ef806f ("net/mlx5/hws: fix tunnel protocol checks")
Signed-off-by: Erez Shitrit
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a
From: Yevgeny Kliteynik
Add support for matcher resize with the following new API calls:
- mlx5dr_matcher_resize_set_target
- mlx5dr_matcher_resize_rule_move
The first function links two matchers and allows moving rules from src
matcher to dst matcher. Both matchers should have the same charac
Inserting two rules with the same hash calculation result into the same
matcher will cause collisions, which can cause degradation in PPS.
Changing the order of some fields in the STE can change the hash result,
and doing this for every value would give us a different hash distribution
for the inpu
From: Hamdan Igbaria
Only allow rule updates for rules with their status value equal to
MLX5DR_RULE_STATUS_CREATED.
Otherwise, the rule may be in an unstable stage like deleting and
this will result in a faulty unexpected scenario.
Signed-off-by: Hamdan Igbaria
Acked-by: Matan Azrad
---
drive
From: Hamdan Igbaria
If a VLAN item was passed with null mask, the item handler would
return immediately and thus won't set default values for non relax
mode.
Also change the non relax default set to single-tagged (CVLAN).
Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer")
Signed-off-by: Ha
From: Hamdan Igbaria
Extend mlx5dr_action_template_create function params
to include flags parameter.
Signed-off-by: Hamdan Igbaria
Acked-by: Matan Azrad
---
drivers/net/mlx5/hws/mlx5dr.h | 10 +-
drivers/net/mlx5/hws/mlx5dr_action.c | 11 ++-
drivers/net/mlx5/hws/mlx
From: Hamdan Igbaria
Today if we pass a remove header action and after it an insert header
action then our action template builder will set two different
STE setters, because it won't allow insert header in same STE as
remove header.
But if we have the opposite order of insert header and then rem
From: Hamdan Igbaria
support push_esp flag for insert header action, it must be set when
inserting an ESP header, it's also sets the next_protocol field in
the IPsec trailer.
Signed-off-by: Hamdan Igbaria
Acked-by: Matan Azrad
---
drivers/common/mlx5/mlx5_prm.h | 3 ++-
drivers/net/mlx5
in the past months, I saw that the usertools scripts didn't receive much
reviews. Unless somebody is against it, I'd like to become maintainer
for the usertools folder.
Signed-off-by: Robin Jarry
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
ind
On Tue, Feb 13, 2024 at 10:58:46AM +0100, Robin Jarry wrote:
> in the past months, I saw that the usertools scripts didn't receive much
> reviews. Unless somebody is against it, I'd like to become maintainer
> for the usertools folder.
>
> Signed-off-by: Robin Jarry
> ---
Thank you for stepping u
13/02/2024 10:58, Robin Jarry:
> in the past months, I saw that the usertools scripts didn't receive much
> reviews. Unless somebody is against it, I'd like to become maintainer
> for the usertools folder.
>
> Signed-off-by: Robin Jarry
Thank you for proposing.
You already did some valuable revi
+CC: Ethernet API maintainers
+CC: Jerin (commented on another branch of this thread)
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com]
> Sent: Sunday, 11 February 2024 16.04
>
> > > > > TSO breaks when MSS spans more than 8 data fragments. Those
> > > > > packets will be dropped
> -Original Message-
> From: Robin Jarry
> Sent: Tuesday, February 13, 2024 9:59 AM
> To: dev@dpdk.org
> Cc: Power, Ciara ; Dmitry Kozlyuk
> ; Thomas Monjalon
> Subject: [PATCH] maintainers: add myself to usertools
>
> in the past months, I saw that the usertools scripts didn't receive
On Mon, Feb 12, 2024 at 6:56 PM Tyler Retzlaff
wrote:
>
> ping
>
> could relevant maintainers take a look?
This change comes from the old commit 5f2c68a710e1 ("lib: work around
braced-groups within expressions").
I suspect this change breaks application compiling with pedantic,
without setting a
On Thu, Jan 25, 2024 at 12:18 AM Tyler Retzlaff
wrote:
>
> Replace use of __alignof__(T) and __alignof__(e) with C11 alignof(T)
> and alignof(typeof(e)) respectively to improve portability of the code
> between toolchains.
>
> Tyler Retzlaff (9):
> ring: use C11 alignof
> mbuf: use C11 alignof
On Mon, Feb 12, 2024 at 5:49 PM Jeremy Spewock wrote:
>
> On Wed, Feb 7, 2024 at 7:16 AM Juraj Linkeš
> wrote:
> >
> > There could be a newline at the end of stdout or stderr of a remotely
> > executed command. These cause issues when used later, such as when
> > joining paths from such commands
On Tue, Feb 13, 2024 at 11:41 AM David Marchand
wrote:
>
> On Mon, Feb 12, 2024 at 6:56 PM Tyler Retzlaff
> wrote:
> >
> > ping
> >
> > could relevant maintainers take a look?
>
> This change comes from the old commit 5f2c68a710e1 ("lib: work around
> braced-groups within expressions").
> I suspe
On Tue, Dec 19, 2023 at 6:28 PM Tyler Retzlaff
wrote:
>
> The design of the macros requires a type to be provided to the macro.
>
> By expanding the type parameter inside of typeof it also inadvertently
> allows an expression to be used which appears not to have been intended
> after evaluating th
There could be a newline at the end of stdout or stderr of a remotely
executed command. These cause issues when used later, such as when
joining paths from such commands - a newline in the middle of a path is
not valid.
Fixes: ad80f550dbc5 ("dts: add SSH command verification")
Signed-off-by: Juraj
13/02/2024 09:51, Morten Brørup:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Monday, 12 February 2024 21.52
> >
> > Provide __rte_section(name) macro that allocates and names a section
> > or segment that works with both MSVC and GCC.
> >
> > Update RTE_TRACE_POINT_RE
On 2/13/2024 9:58 AM, Robin Jarry wrote:
> in the past months, I saw that the usertools scripts didn't receive much
> reviews. Unless somebody is against it, I'd like to become maintainer
> for the usertools folder.
>
> Signed-off-by: Robin Jarry
>
Acked-by: Ferruh Yigit
From: Vignesh PS
Add support to ip_frag library to perform IPv6 reassembly
when extension headers are present before the fragment
extension in the packet.
Signed-off-by: Vignesh PS
---
.mailmap | 1 +
lib/ip_frag/ip_frag_common.h | 2 +
lib/ip_frag/ip_reassembly
12/02/2024 19:12, Gregory Etelson:
> --- a/doc/guides/howto/rte_flow.rst
> +++ b/doc/guides/howto/rte_flow.rst
> +Template API resizable table
> +
> +
> +Description
> +~~~
> +
> +The resizable template table API enables applications to dynamically adjust
> +capa
Hi,
Sorry for the delay - we considered the opportunity to get rid of the pointer
to array at all.
Not this time. So:
Acked-by: Viacheslav Ovsiienko
With best regards,
Slava
> -Original Message-
> From: Tyler Retzlaff
> Sent: Monday, February 12, 2024 8:03 PM
> To: dev@dpdk.org
> Cc:
Simplified the L2 forwarding examples by removing all tables and
actions, as they are not really needed for this simplest use-case.
---
examples/pipeline/examples/l2fwd.spec | 34 +++
1 file changed, 8 insertions(+), 26 deletions(-)
diff --git a/examples/pipeline/examples/
Simplified the L2 forwarding examples by removing all tables and
actions, as they are not really needed for this simplest use-case.
Signed-off-by: Cristian Dumitrescu
---
examples/pipeline/examples/l2fwd.spec | 34 +++
1 file changed, 8 insertions(+), 26 deletions(-)
dif
Acked-by: Hemant Agrawal
smime.p7s
Description: S/MIME cryptographic signature
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, February 9, 2024 7:21 PM
> To: Rahul Bhansali ; dev@dpdk.org; Radu Nicolau
> ; Akhil Goyal ; Konstantin
> Ananyev ; Anoob Joseph
>
> Subject: Re: [EXT] Re: [PATCH] examples/ipsec-secgw: fix IPsec performance
> drop
>
> On 2/9/2
Hi,
Regarding "dev_out_of_buffer" - it is global counter, relates to the whole
device port,
Including queues not managed by DPDK application - Mellanox/Nvidia NICs operate
In "bifurcated mode" - there might be queues managed by kernel or another DPDK
application. Not sure it makes a lot of sense,
On Mon, Feb 12, 2024 at 11:36 PM Tyler Retzlaff
wrote:
>
> Replace some missed zero length arrays not captured in the
> original series.
> https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=*
>
> Zero length arrays are a GNU extension that has been
> superseded by flex arrays.
>
> ht
During encapsulation of a packet, it is possible to change some
outer headers to improve flow destribution.
For example, from VXLAN RFC:
"It is recommended that the UDP source port number
be calculated using a hash of fields from the inner packet --
one example being a hash of the inner Ethernet fr
This commit adds support for encap hash calculation.
Signed-off-by: Ori Kam
Acked-by: Dariusz Sosnowski
---
drivers/net/mlx5/mlx5_flow.c| 29 +++
drivers/net/mlx5/mlx5_flow.h| 8
drivers/net/mlx5/mlx5_flow_hw.c | 66 +
3 files changed, 1
From: Hamdan Igbaria
Add new function for encap entropy hash calculation, the function
will check the device capability for the entropy hash type used
by the device, and will calculate the entropy hash value of the
user passed fields according this type.
Signed-off-by: Hamdan Igbaria
Acked-by:
This commits add support for calculating the encap hash.
Command structure:
flow hash {port} encap {target field} pattern {item} [/ {item} [...] ] / end
Example:
calculate hash to be used by VXLAN encapsulation.
flow hash 0 encap hash_field_sport pattern ipv4 dst is 7.7.7.7 src is 8.8.8.8
/ ud
During encapsulation of a packet, it is possible to change some
outer headers to improve flow destribution.
For example, from VXLAN RFC:
"It is recommended that the UDP source port number
be calculated using a hash of fields from the inner packet --
one example being a hash of the inner Ethernet fr
From: Hamdan Igbaria
Add new function for encap entropy hash calculation, the function
will check the device capability for the entropy hash type used
by the device, and will calculate the entropy hash value of the
user passed fields according this type.
Signed-off-by: Hamdan Igbaria
Acked-by:
This commit adds support for encap hash calculation.
Signed-off-by: Ori Kam
Acked-by: Dariusz Sosnowski
---
drivers/net/mlx5/mlx5_flow.c| 29 +++
drivers/net/mlx5/mlx5_flow.h| 8
drivers/net/mlx5/mlx5_flow_hw.c | 66 +
3 files changed,
This commits add support for calculating the encap hash.
Command structure:
flow hash {port} encap {target field} pattern {item} [/ {item} [...] ] / end
Example:
calculate hash to be used by VXLAN encapsulation.
flow hash 0 encap hash_field_sport pattern ipv4 dst is 7.7.7.7 src is 8.8.8.8
/ ud
02/01/2024 19:18, Konstantin Ananyev:
>
> > On x86 platforms, max lcores are limited to 128 by default.
> >
> > On AMD EPYC processors, this limit was adjusted for native
> > builds in the previous patch.
> > https://patches.dpdk.org/project/dpdk/patch/
> > 20230925151027.558546-1-sivaprasad.tumm
When rte_log.h was moved to a new directory, the include path was not
updated for the generated C code produced by the pipeline library,
which results in build failure for this code.
Fixes: 09ce41310930 ("log: separate logging functions out of EAL")
Cc: sta...@dpdk.org
Signed-off-by: Cristian Dum
23/11/2023 11:29, Ferruh Yigit:
> On 11/23/2023 7:27 AM, Sivaprasad Tummala wrote:
> > AMD Epyc processors doesn't support get_tsc_freq_arch().
> > The patch allows graceful return to allow fallback to
> > alternate TSC calibration.
> >
> > Fixes: 3dbc565e81a0 ("timer: honor arch-specific TSC freq
rte_common.h provides container_of if none is defined.
The drivers headers touched by this commit either already include
rte_common.h or use some other common macro defined in rte_common.h.
As a consequence, it seems safe to assume that container_of is always
available for includers of those heade
On 2/13/2024 2:16 PM, Ori Kam wrote:
> During encapsulation of a packet, it is possible to change some
> outer headers to improve flow destribution.
> For example, from VXLAN RFC:
> "It is recommended that the UDP source port number
> be calculated using a hash of fields from the inner packet --
>
On 2/13/2024 2:16 PM, Ori Kam wrote:
> This commits add support for calculating the encap hash.
>
> Command structure:
> flow hash {port} encap {target field} pattern {item} [/ {item} [...] ] / end
>
> Example:
> calculate hash to be used by VXLAN encapsulation.
> flow hash 0 encap hash_field_spo
On 2/13/2024 3:45 PM, Ferruh Yigit wrote:
> On 2/13/2024 2:16 PM, Ori Kam wrote:
>> During encapsulation of a packet, it is possible to change some
>> outer headers to improve flow destribution.
>> For example, from VXLAN RFC:
>> "It is recommended that the UDP source port number
>> be calculated u
On Mon, Dec 11, 2023 at 5:53 PM Stephen Hemminger
wrote:
>
> cmdline_poll has been removed by:
> commit f44f2edd198a ("cmdline: remove poll function")
> but deprecation notice was left behind.
>
Fixes: f44f2edd198a ("cmdline: remove poll function")
Cc: sta...@dpdk.org
> Signed-off-by: Stephen He
> -Original Message-
> From: Stephen Hemminger
> Sent: Saturday, February 10, 2024 02:33
> To: Wathsala Vithanage
> Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> Dariusz Sosnowski ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
> ; Matan Azrad ;
> dev@dpdk.org; n...@arm.com; Honnappa Nagara
Reviewed-by: Jeremy Spewock
> -Original Message-
> From: Wathsala Vithanage
> Sent: Friday, February 9, 2024 21:42
> To: NBU-Contact-Thomas Monjalon (EXTERNAL) ;
> Dariusz Sosnowski ; Slava Ovsiienko
> ; Ori Kam ; Suanming Mou
> ; Matan Azrad
> Cc: dev@dpdk.org; n...@arm.com; Wathsala Vithanage
> ; Honnappa Nagaraha
On Tue, Feb 13, 2024 at 3:52 PM Cristian Dumitrescu
wrote:
>
> When rte_log.h was moved to a new directory, the include path was not
> updated for the generated C code produced by the pipeline library,
> which results in build failure for this code.
>
> Fixes: 09ce41310930 ("log: separate logging
On Tue, Feb 13, 2024 at 04:37:41PM +0100, David Marchand wrote:
> rte_common.h provides container_of if none is defined.
>
> The drivers headers touched by this commit either already include
> rte_common.h or use some other common macro defined in rte_common.h.
> As a consequence, it seems safe to
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Tuesday, 13 February 2024 07.46
>
> Replace the use of RTE_MARKER with C11 anonymous unions to improve
> code portability between toolchains.
How about combining the cacheline 0 marker and padding, like this:
struct rte_mbuf {
Enhanced the move instruction to detect and optimize the conversion
between 128-bit numbers (IPv6 addresses) and 64-bit (upper or lower
part of IPv6 addresses) or 32-bit numbers (IPv4 addresses).
Signed-off-by: Cristian Dumitrescu
---
lib/pipeline/rte_swx_pipeline.c | 56 +++
Add example for swapping the two halves of the IPv6 source address.
Signed-off-by: Cristian Dumitrescu
---
examples/pipeline/examples/ipv6_addr_swap.cli | 35
.../pipeline/examples/ipv6_addr_swap.spec | 83 +++
2 files changed, 118 insertions(+)
create mode 100644 e
Added new instruction called "movh" to read/write the upper half of an
IPv6 address, i.e. bits 127-64 of a 128-bit field.
Signed-off-by: Cristian Dumitrescu
---
lib/pipeline/rte_swx_pipeline.c | 99
lib/pipeline/rte_swx_pipeline_internal.h | 52 -
2
So far, the pipeline supports the following operations on IPv6 addresses:
-using an IPv6 address as a table match field of exact/ternary/LPM match type
-assignment of IPv6 address to another IPv6 address
-conversion between an IPv4 address and an IPv6 address
The reason for this limited support is
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> Sent: Tuesday, 13 February 2024 07.46
>
> The zero sized RTE_MARKER typedefs are a GCC extension unsupported
> by
> MSVC. Replace the use of the RTE_MARKER typedefs with anonymous
> unions.
>
> Note:
>
> v1 of the series tried to ma
Hi David,
> -Original Message-
> From: David Marchand
> Sent: Tuesday, February 13, 2024 4:19 PM
> To: Dumitrescu, Cristian
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH] examples/pipeline: fix include path for rte_log.h
>
>
> Wrt $Subject, copy/paste code in drivers/net/so
From: Vignesh PS
Add support to bonding PMD to allow user callback
function registration for TX transmit policy.
Signed-off-by: Vignesh PS
---
.mailmap| 1 +
drivers/net/bonding/eth_bond_private.h | 6 ++
drivers/net/bonding/rte_eth_bond.h | 17 +
When rte_log.h was moved to a new directory, the include path was not
updated for the generated C code produced by the pipeline library,
which results in build failure for this code.
Fixes: 09ce41310930 ("log: separate logging functions out of EAL")
Cc: sta...@dpdk.org
Signed-off-by: Cristian Dum
Change my email to a personal one.
Signed-off-by: Stanislaw Kardach
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b9d258e627..e61c57b1be 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -310,7 +310,7 @@ F: examples/*/*_altivec.*
Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve
portability between toolchains
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/ring/rte_ring.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/ring/rte_ring.c b/
Replace use of __alignof__(T) and __alignof__(e) with C11 alignof(T)
and alignof(typeof(e)) respectively to improve portability of the code
between toolchains.
v2:
* expand series to replace use in entire source tree, now
includes app, drivers, examples in addition to lib.
Tyler Retzlaf
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/mbuf/rte_mbuf_dyn.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/mbuf/rte_mbuf_dyn.c b
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/eventdev/rte_eventdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/eventdev/rte_even
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/ethdev/ethdev_driver.c | 3 ++-
lib/ethdev/rte_flow.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Anoob Joseph
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/pdcp/rte_pdcp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/
Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve
portability between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/stack/rte_stack.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/stack/rte_stack
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/node/node_private.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/node/node_private.h
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Volodymyr Fialko
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/reorder/rte_reorder.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
Acked-by: Akhil Goyal
Acked-by: Morten Brørup
Acked-by: Chengwen Feng
---
lib/security/rte_security.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --g
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
examples/bbdev_app/main.c | 3 ++-
examples/rxtx_callbacks/main.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/examples/bbdev_app/main.c
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Replace use of __alignof__(e) with C11 alignof(typeof(e)) to improve
portability between toolchains
Signed-off-by: Tyler Retzlaff
---
app/test/test_distributor.c | 3 ++-
app/test/test_graph.c
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/event/sw/sw_evdev_selftest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/event/sw/sw_evdev_selftest.c
b/drivers/event/sw/sw_ev
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/bus/dpaa/dpaa_bus.c | 3 ++-
drivers/bus/fslmc/fslmc_bus.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/dpaa/dpaa_bus.c
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
app/test-eventdev/test_order_common.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/test-eventdev/test_order_common.c
b/app/test-eventde
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
inde
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/net/nfp/nfp_ipsec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c
index 452947
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/net/iavf/iavf_ethdev.c | 3 ++-
drivers/net/iavf/iavf_ipsec_crypto.c | 4 +++-
drivers/net/iavf/iavf_testpmd.c | 3 ++-
3 files changed, 7 insertions(
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/net/sfc/sfc_dp.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/sfc_dp.c b/drivers/net/sfc/sfc_dp.c
index 2b0a1d7..7e2a
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/net/virtio/virtio_rxtx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_
Replace use of __alignof__(T) with C11 alignof(T) to improve portability
between toolchains.
Signed-off-by: Tyler Retzlaff
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vm
Add 2 checks forbidding direct use of __alignof__ and __typeof__ instead
C11 alignof and rte_common.h typeof macros should be used.
Signed-off-by: Tyler Retzlaff
---
devtools/checkpatches.sh | 16
1 file changed, 16 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools
On Tue, Feb 13, 2024 at 05:58:21PM +0100, Morten Brørup wrote:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Tuesday, 13 February 2024 07.46
> >
> > Replace the use of RTE_MARKER with C11 anonymous unions to improve
> > code portability between toolchains.
>
> How about
Adjust the use of per lcore macro to provide type as the first
argument as to not require __typeof__ during expansion.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/crypto/ipsec_mb/pmd_aesni_gcm_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
The design of the macros requires a type to be provided to the macro.
By expanding the type parameter inside of typeof it also inadvertently
allows an expression to be used which appears not to have been intended
after evaluating the parameter name and existing macro use.
Technically this is an A
Adjust the use of per lcore macro to provide type as the first argument
as to not require __typeof__ during expansion.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
lib/eal/common/eal_common_errno.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eal/commo
The design of the macros requires a type to be provided to the macro.
By expanding the type parameter inside of typeof it also inadvertently
allows an expression to be used which appears not to have been intended
after evaluating the parameter name and existing macro use.
Technically this is an A
On Tue, Feb 13, 2024 at 10:34 AM Tyler Retzlaff
wrote:
>
> Replace use of __alignof__(T) with C11 alignof(T) to improve portability
> between toolchains.
>
> Signed-off-by: Tyler Retzlaff
Acked-by: Ajit Khaparde
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+),
On Tue, Feb 13, 2024 at 02:14:28PM +0100, David Marchand wrote:
> On Mon, Feb 12, 2024 at 11:36 PM Tyler Retzlaff
> wrote:
> >
> > Replace some missed zero length arrays not captured in the
> > original series.
> > https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=*
> >
> > Zero len
1 - 100 of 188 matches
Mail list logo
