Re: [PATCH v2] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Stephen Hemminger
On Fri, 26 Apr 2024 08:47:37 -0700 Tyler Retzlaff wrote: > > int > > -- > > i do not think introducing os specific behavior/logging to the EAL > is a good idea. logging although not formally part of the api surface > should present the same experience for all platforms. the EAL should > have

Re: [RFC 4/4] eal/malloc: remove type argument from internal malloc routines

2024-04-26 Thread Tyler Retzlaff
On Fri, Apr 26, 2024 at 03:52:29PM -0700, Stephen Hemminger wrote: > On Fri, 26 Apr 2024 09:16:27 -0700 > Tyler Retzlaff wrote: > > > > > > > diff --git a/lib/eal/common/eal_common_memzone.c > > > b/lib/eal/common/eal_common_memzone.c > > > index 32e6b78f87..2d9b6aa3e3 100644 > > > --- a/lib/ea

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Stephen Hemminger
On Fri, 26 Apr 2024 17:17:25 +0200 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, 26 April 2024 17.14 > > > > On Fri, 26 Apr 2024 14:20:01 +0200 > > Morten Brørup wrote: > > > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > >

Re: [RFC 4/4] eal/malloc: remove type argument from internal malloc routines

2024-04-26 Thread Stephen Hemminger
On Fri, 26 Apr 2024 09:16:27 -0700 Tyler Retzlaff wrote: > > > > diff --git a/lib/eal/common/eal_common_memzone.c > > b/lib/eal/common/eal_common_memzone.c > > index 32e6b78f87..2d9b6aa3e3 100644 > > --- a/lib/eal/common/eal_common_memzone.c > > +++ b/lib/eal/common/eal_common_memzone.c > > @@

Re: [RFC v2 0/6] Improve EAL bit operations API

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [v1 1/1] MAINTAINERS: add another AF_XDP maintainer

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH] bpf/xdp: disable on 32bit x86

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [RFC 0/4] malloc type argument cleanup (part 1)

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [v1 1/1] docs: af_xdp device plugin repo update

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH 10/10] doc: update nfp document

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH] lib/vhost: add flag for async connection in client mode

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [RFC] net/af_packet: make stats reset reliable

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH v2] vhost: cleanup resubmit info before inflight setup

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

Re: [PATCH] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Patrick Robb
Recheck-request: iol-compile-amd64-testing The DPDK Community Lab updated to the latest Alpine image yesterday, which resulted in all Alpine builds failing. The failure is unrelated to your patch, and this recheck should remove the fail on Patchwork, as we have disabled Alpine testing for now.

[DPDK/core Bug 1422] vfio-pci driver fails to compile on Alpine Linux

2024-04-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1422 Bug ID: 1422 Summary: vfio-pci driver fails to compile on Alpine Linux Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: norm

Re: [PATCH 6/6] dts: add statefulness to TestPmdShell

2024-04-26 Thread Jeremy Spewock
Apologies for being so late on the discussion, but just a few of my thoughts: * I think using something like overloading even though it is new to python is completely fine because this new python version is a dependency of the DTS runner. The DTS runner can have bleeding-edge requirements because

Re: [PATCH 4/6] dts: use testpmd params for scatter test suite

2024-04-26 Thread Jeremy Spewock
On Wed, Apr 10, 2024 at 9:19 AM Juraj Linkeš wrote: > > On Wed, Apr 10, 2024 at 12:53 PM Luca Vizzarro wrote: > > > > On 09/04/2024 20:12, Juraj Linkeš wrote: > > >> @@ -104,16 +108,15 @@ def pmd_scatter(self, mbsize: int) -> None: > > >> """ > > >> testpmd = self.sut_node.cre

Re: [RFC 4/4] eal/malloc: remove type argument from internal malloc routines

2024-04-26 Thread Tyler Retzlaff
On Thu, Apr 25, 2024 at 11:24:01AM -0700, Stephen Hemminger wrote: > The type argument is carried through malloc heap routines but > never used. > > Signed-off-by: Stephen Hemminger > --- > lib/eal/common/eal_common_memzone.c | 6 ++--- > lib/eal/common/malloc_heap.c | 39 -

[PATCH v9 9/9] net/tap: simplify the internal structure

2024-04-26 Thread Stephen Hemminger
The names of Linux network devices are IFNAMSIZ(16) not the same as DPDK which has up to 64 characters. Don't need to hold onto the whole ifreq to save the remote interface flags. Rearrange internal structure for locality. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 42

[PATCH v9 8/9] doc: update documentation of TAP PMD

2024-04-26 Thread Stephen Hemminger
The driver support of flows has changed and the wording in the guide was awkward. Drop references to DPDK pktgen in this documentation since it is not required and confusing. Signed-off-by: Stephen Hemminger --- doc/guides/linux_gsg/sys_reqs.rst | 3 + doc/guides/nics/tap.rst | 274

[PATCH v9 7/9] net/tap: remove no longer used files

2024-04-26 Thread Stephen Hemminger
The BPF api was replaced by use of libbpf. And the BPF instruction header was replaced by the skeleton. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_api.c | 196 drivers/net/tap/tap_bpf_insns.h | 1741 --- 2 files changed, 1937 deletions(-) de

[PATCH v9 6/9] net/tap: use libbpf to load new BPF program

2024-04-26 Thread Stephen Hemminger
There were multiple issues in the RSS queue support in the TAP driver. This required extensive rework of the BPF support. Change the BPF loading to use bpftool to create a skeleton header file, and load with libbpf. The BPF is always compiled from source so less chance that source and instructions

[PATCH v9 5/9] net/tap: rewrite the RSS BPF program

2024-04-26 Thread Stephen Hemminger
Rewrite the BPF program used to do queue based RSS. Important changes: - uses newer BPF map format BTF - accepts key as parameter rather than constant default - can do L3 or L4 hashing - supports IPv4 options - supports IPv6 extension headers - restru

[PATCH v9 4/9] net/tap: do not build flow support if header is out of date

2024-04-26 Thread Stephen Hemminger
The proper place for finding bpf structures and functions is in linux/bpf.h. The original version was trying to workaround the case where the build environment was running on old pre BPF version of Glibc, but the target environment had BPF. Having own private (and divergent) version headers leads

[PATCH v9 3/9] net/tap: validate and setup parameters for BPF RSS

2024-04-26 Thread Stephen Hemminger
The flow RSS support via BPF was not using the key, or hash type parameters. Which is good because they were never properly setup. Fix the setup and validate the flow parameters, the BPF side gets fixed later. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c | 65

[PATCH v9 2/9] net/tap: remove unused fields

2024-04-26 Thread Stephen Hemminger
The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c| 1 - drivers/net/tap/tap_rss.h | 6 -

[PATCH v9 1/9] net/tap: do not duplicate fd's

2024-04-26 Thread Stephen Hemminger
The TAP device can use same file descriptopr for both rx and tx queues. This allows up to 8 queues (versus 4) to be used with secondary process. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 197 +++--- drivers/net/tap/rte_eth_tap.h | 3 +- dr

[PATCH v9 0/9] net/tap: fix RSS (BPF) support

2024-04-26 Thread Stephen Hemminger
The support of doing RSS for rte_flow_action was a cool idea but it has been broken for several releases of DPDK as the kernel and BPF infrastructure changed. This series cleans up the BPF program, implements several features that were never completed in the original code and changes to use the cu

Re: [PATCH v2] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Tyler Retzlaff
On Thu, Apr 25, 2024 at 07:11:30PM +0800, Jianyue Wu wrote: > From: Jianyue Wu > > Improve the robustness of setting thread affinity in DPDK > by adding detailed error logging. > > Changes: > 1. Check the return value of pthread_setaffinity_np() and log an error > if the call fails. > 2. Include

Re: [PATCH v3] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Tyler Retzlaff
On Fri, Apr 26, 2024 at 11:05:02AM +0200, Mattias Rönnblom wrote: > Cache align Rx and Tx queue struct to avoid false sharing. > > The RX struct happens to be 64 bytes on x86_64 already, so cache > alignment has no effect there, but it does on 32-bit ISAs. > > The TX struct is 56 bytes on x86_64.

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 26 April 2024 17.14 > > On Fri, 26 Apr 2024 14:20:01 +0200 > Morten Brørup wrote: > > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > Sent: Thursday, 25 April 2024 18.53 > > > > > > Making 'rte_eth_stats_res

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Stephen Hemminger
On Fri, 26 Apr 2024 14:20:01 +0200 Morten Brørup wrote: > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > Sent: Thursday, 25 April 2024 18.53 > > > > Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread > > safe has performance impact on datapath. > > > > Instead docum

RE: [RFC] net/af_packet: make stats reset reliable

2024-04-26 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Friday, 26 April 2024 15.38 > > On 4/26/2024 12:33 PM, Morten Brørup wrote: [...] > > While reviewing, I came across the rx_mbuf_alloc_failed counter in the > rte_eth_dev_data structure: > > https://elixir.bootlin.com/dpdk/v24.03/source/

Re: [v1 1/1] docs: af_xdp device plugin repo update

2024-04-26 Thread Ferruh Yigit
On 4/25/2024 4:08 PM, Maryam Tahhan wrote: > Fixup the references to the AF_XDP Device Plugin repo. > > Fixes: 66a2aca4f512 ("docs: fix AF_XDP device plugin howto") > Cc: sta...@dpdk.org > > Signed-off-by: Maryam Tahhan > --- > doc/guides/howto/af_xdp_cni.rst | 12 ++-- > doc/guides/nic

RE: [RFC v2] net/af_packet: make stats reset reliable

2024-04-26 Thread Morten Brørup
> +static uint64_t > +stats_get_diff(uint64_t stats, uint64_t offset) > +{ > + return stats - offset; > +} No need for this function; just subtract inline instead. With the suggested change, Reviewed-by: Morten Brørup

[RFC v2] net/af_packet: make stats reset reliable

2024-04-26 Thread Ferruh Yigit
For stats reset, use an offset instead of zeroing out actual stats values, get_stats() displays diff between stats and offset. This way stats only updated in datapath and offset only updated in stats reset function. This makes stats reset function more reliable. As stats only written by single thr

Re: [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command

2024-04-26 Thread Ferruh Yigit
On 4/26/2024 2:51 PM, Ferruh Yigit wrote: > On 4/22/2024 7:10 PM, Ronak Doshi wrote: >> Vmxnet3 uses capability registers to advertise the supported >> capabilities of UPT device. It uses DCR0_REG command register >> for this purpose. However, the register command enum misses >> one command which t

Re: [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command

2024-04-26 Thread Ferruh Yigit
On 4/22/2024 7:10 PM, Ronak Doshi wrote: > Vmxnet3 uses capability registers to advertise the supported > capabilities of UPT device. It uses DCR0_REG command register > for this purpose. However, the register command enum misses > one command which technically is not used by dpdk vmxnet3 > driver

Re: [RFC] net/af_packet: make stats reset reliable

2024-04-26 Thread Ferruh Yigit
On 4/26/2024 12:33 PM, Morten Brørup wrote: >> +static uint64_t >> +stats_get_diff(uint64_t stats, uint64_t offset) >> +{ >> +if (stats >= offset) >> +return stats - offset; >> +/* unlikely wraparound case */ >> +return UINT64_MAX + stats - offset; > > The numbers are unsig

[RFC PATCH 0/2] add feature arc in rte_graph

2024-04-26 Thread Nitin Saxena
Feature arc represents an ordered list of features/protocols at a given networking layer. It is a high level abstraction to connect various rte_graph nodes, as feature nodes, and allow packets steering across these nodes in a generic manner. Features (or feature nodes) are nodes which handles part

[RFC PATCH 1/2] graph: add feature arc support

2024-04-26 Thread Nitin Saxena
Signed-off-by: Nitin Saxena Change-Id: I8ca9d6285aaeedabc75131af8d28f8b2f63f614b --- lib/graph/graph_feature_arc.c| 834 +++ lib/graph/meson.build| 2 + lib/graph/rte_graph_feature_arc.h| 310 + lib/graph/rte_graph_feature_arc_

[RFC PATCH 2/2] graph: add ip4 output feature arc

2024-04-26 Thread Nitin Saxena
Signed-off-by: Nitin Saxena Change-Id: I80021403c343354c7e494c6bc79b83b0d0fe6b7c --- lib/node/ip4_rewrite.c | 278 lib/node/ip4_rewrite_priv.h | 10 +- lib/node/node_private.h | 10 +- lib/node/rte_node_ip4_api.h | 3 + 4 files changed, 233 insert

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-26 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Thursday, 25 April 2024 18.53 > > Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_reset()' APIs thread > safe has performance impact on datapath. > > Instead document APIs as not thread safe and add condition for reliable > stats reset

RE: [RFC v2 5/6] eal: add atomic bit operations

2024-04-26 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Friday, 26 April 2024 11.39 > > On 2024-04-25 18:18, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Thursday, 25 April 2024 16.36 > >> > >> On 2024-04-25 12:25, Morten Brørup wrote: > +

RE: [RFC] net/af_packet: make stats reset reliable

2024-04-26 Thread Morten Brørup
> +static uint64_t > +stats_get_diff(uint64_t stats, uint64_t offset) > +{ > + if (stats >= offset) > + return stats - offset; > + /* unlikely wraparound case */ > + return UINT64_MAX + stats - offset; The numbers are unsigned, so wrapping comes for free. Remove the compar

Re: [RFC v2 0/6] Improve EAL bit operations API

2024-04-26 Thread Mattias Rönnblom
On 2024-04-25 20:05, Tyler Retzlaff wrote: On Thu, Apr 25, 2024 at 10:58:47AM +0200, Mattias Rönnblom wrote: This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as

[PATCH v2] vhost: cleanup resubmit info before inflight setup

2024-04-26 Thread Haoqian He
This patch fixes a potential VM hang bug when the VM reboots after vhost live recovery due to missing cleanup virtqueue resubmit info. Specifically, if inflight IO that should be resubmitted during the latest vhost reconnection has not been submitted yet while VM rebooting, so GET_VRING_BASE would

Re: [PATCH v1] dts: remove the OS UDP test suite

2024-04-26 Thread Luca Vizzarro
On 26/04/2024 09:55, Juraj Linkeš wrote: From what I can tell, we don't need any of these for Scapy, but we should test this in other environments as well (my virtual environment doesn't play nice with port rebinding and running testpmd - I have to start Scapy after starting testpmd to get it to

RE: [PATCH] net/af_xdp: fix umem map size for zero copy

2024-04-26 Thread Loftus, Ciara
> Subject: [PATCH] net/af_xdp: fix umem map size for zero copy > > The current calculation assumes that the mbufs are contiguous. However, > this assumption is incorrect when the memory spans across a huge page. > Correct to directly read the size from the mempool memory chunks. > > Signed-off-by

Re: [PATCH] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Mattias Rönnblom
On 2024-04-26 10:27, Ferruh Yigit wrote: On 4/26/2024 8:38 AM, Mattias Rönnblom wrote: Cache align Rx and Tx queue struct to avoid false sharing. RX struct happens to be 64 bytes on x86_64 already, so cache alignment has no effect there, but it does on 32-bit ISAs. TX struct is 56 bytes on x86

Re: [PATCH] net/ionic: clean up logging issues

2024-04-26 Thread Ferruh Yigit
On 4/19/2024 11:39 PM, Stephen Hemminger wrote: > On Fri, 19 Apr 2024 13:25:56 -0700 > Andrew Boyer wrote: > >> Switch to the new RTE_LOG_LINE_PREFIX logging macro. While here, fix up >> some trailing-newline issues reported by the new macro. >> >> Signed-off-by: Andrew Boyer > > Acked-by: Step

Re: [RFC v2 5/6] eal: add atomic bit operations

2024-04-26 Thread Mattias Rönnblom
On 2024-04-25 18:18, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Thursday, 25 April 2024 16.36 On 2024-04-25 12:25, Morten Brørup wrote: +#define rte_bit_atomic_test(addr, nr, memory_order) \ + _Generic((addr),

RE: [PATCH v3] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Friday, 26 April 2024 11.05 > > Cache align Rx and Tx queue struct to avoid false sharing. Should an RTE_CACHE_GUARD be added at the end of these two structs? If not, Reviewed-by: Morten Brørup

RE: [v1 1/1] docs: af_xdp device plugin repo update

2024-04-26 Thread Loftus, Ciara
> Subject: [v1 1/1] docs: af_xdp device plugin repo update > > Fixup the references to the AF_XDP Device Plugin repo. > > Fixes: 66a2aca4f512 ("docs: fix AF_XDP device plugin howto") > Cc: sta...@dpdk.org > > Signed-off-by: Maryam Tahhan Acked-by: Ciara Loftus > --- > doc/guides/howto/af_xd

[PATCH v3] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Mattias Rönnblom
Cache align Rx and Tx queue struct to avoid false sharing. The RX struct happens to be 64 bytes on x86_64 already, so cache alignment has no effect there, but it does on 32-bit ISAs. The TX struct is 56 bytes on x86_64. Both structs keep counters, and in the RX case they are updated even for emp

Re: 21.11.7 patches review and test

2024-04-26 Thread Kevin Traynor
On 22/04/2024 09:38, YangHang Liu wrote: > RedHat QE tested below 18 scenarios on RHEL 9.4 and didn't find any new > dpdk issues. > >- >- VM with device assignment(PF) throughput testing(1G hugepage size): >PASS >- VM with device assignment(PF) throughput testing(2M hugepage size)

Re: 21.11.7 patches review and test

2024-04-26 Thread Kevin Traynor
On 26/04/2024 10:04, Xu, HailinX wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Thursday, April 18, 2024 8:34 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Ali Alnubani ; David Christensen >> ; Hemant Agrawal ; >> Stokes, Ian ; Jerin Jacob ; >> Mcnamara

RE: 21.11.7 patches review and test

2024-04-26 Thread Xu, HailinX
> -Original Message- > From: Kevin Traynor > Sent: Thursday, April 18, 2024 8:34 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Stokes, Ian ; Jerin Jacob ; > Mcnamara, John ; Ju-Hyoung Lee > ; Kevin Traynor ; Luca >

Re: [PATCH v1] dts: remove the OS UDP test suite

2024-04-26 Thread Juraj Linkeš
On Tue, Apr 23, 2024 at 2:00 PM Juraj Linkeš wrote: > > On Tue, Apr 23, 2024 at 12:39 PM Luca Vizzarro wrote: > > > > On 19/04/2024 14:52, Juraj Linkeš wrote: > > > diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py > > > > > > -def configure_testbed_ipv4(self, restore: b

[PATCH v4] lib/vhost: add flag for async connection in client mode

2024-04-26 Thread Daniil Ushkov
This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT, which in combination with the flag RTE_VHOST_USER_CLIENT makes rte_vhost_driver_start connect asynchronously to the vhost server. Signed-off-by: Daniil Ushkov --- Fixes: * Cyrillic name in Signed-off-by. Let it be another email addre

Re: [PATCH] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Ferruh Yigit
On 4/26/2024 8:38 AM, Mattias Rönnblom wrote: > Cache align Rx and Tx queue struct to avoid false sharing. > > RX struct happens to be 64 bytes on x86_64 already, so cache alignment > has no effect there, but it does on 32-bit ISAs. > > TX struct is 56 bytes on x86_64. > > Both structs keep coun

Re:Re: [PATCH] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Jianyue Wu
Hello, Stephen, Understand, yesterday I had added new changes to the patch, how to recall that patch? Thank you~ At 2024-04-25 23:04:46, "Stephen Hemminger" wrote: >On Thu, 25 Apr 2024 13:40:21 +0800 (CST) >吴剑跃 wrote: > >> After reviewing the code, I believe that the combinati

[PATCH v2] eal/linux: enhanced error handling for affinity

2024-04-26 Thread Jianyue Wu
From: Jianyue Wu Improve the robustness of setting thread affinity in DPDK by adding detailed error logging. Changes: 1. Check the return value of pthread_setaffinity_np() and log an error if the call fails. 2. Include the current thread name, the intended CPU set, and a detailed error message i

DPDK hugepage issue in docker containter

2024-04-26 Thread Nirmal Sarkar
I am running DPDK application inside docker container bound to a Numa Node. The command to bring up the docker container, I am using the command below: docker run -itd \ --privileged \ --name ${DOCKER_NAME} \ --rm \ --network=${DOCKER_NETWORK} \ --cpuset-cpus="${CPU_SET}" \

[PATCH 09/10] vdpa/nfp: setup vring relay thread

2024-04-26 Thread Chaoyong He
From: Xinying Yu Setup the vring relay thread to monitor the interruption from device. And do the dirty page logging or notify device according to event data. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c

[PATCH 10/10] doc: update nfp document

2024-04-26 Thread Chaoyong He
From: Xinying Yu Add the software assisted vDPA live migration feature into NFP document. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- doc/guides/vdpadevs/nfp.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/v

[PATCH 08/10] vdpa/nfp: recover the ring index on new host

2024-04-26 Thread Chaoyong He
From: Xinying Yu After migrate to new host, the vring information was recovered by the value in offset 'NFP_NET_CFG_TX_USED_INDEX' and 'NFP_NET_CFG_RX_USED_INDEX'. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_comm

[PATCH 07/10] vdpa/nfp: setup the VF configure

2024-04-26 Thread Chaoyong He
From: Xinying Yu Create the relay vring on host and then set the address of Rx used ring to the VF config bar. So the device can DMA the used ring information to host rather than directly to VM. Use 'NFP_NET_CFG_CTRL_LM_RELAY' notify the device side. And enable the MSIX interrupt on device. Tx

[PATCH 06/10] vdpa/nfp: add the interrupt logic of vring relay

2024-04-26 Thread Chaoyong He
From: Xinying Yu Add the interrupt setup logic of vring relay. The epoll fd is provided here so host can get the interrupt from device on Rx direction, all other operations on vring relay are based on this. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH 05/10] vdpa/nfp: add the live migration logic

2024-04-26 Thread Chaoyong He
From: Xinying Yu Add the basic logic of software live migration. Unset the ring notify area to stop the direct IO datapath if the device support, then we can setup the vring relay to help the live migration. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by:

[PATCH 04/10] vdpa/nfp: refactor the logic of datapath update

2024-04-26 Thread Chaoyong He
From: Xinying Yu In order to add the new configuration logic of software live migration, split the datapath update logic into two parts, queue configuration and VF configuration. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa

[PATCH 03/10] vdpa/nfp: fix the logic of reconfiguration

2024-04-26 Thread Chaoyong He
From: Xinying Yu The ctrl words of vDPA is locate on the extend word, so should use the 'nfp_ext_reconfig()' rather than 'nfp_reconfig()'. Also replace the misuse of 'NFP_NET_CFG_CTRL_SCATTER' macro with 'NFP_NET_CFG_CTRL_VIRTIO'. Fixes: b47a0373903f ("vdpa/nfp: add datapath update") Cc: chaoyo

[PATCH 02/10] vdpa/nfp: fix logic in hardware init

2024-04-26 Thread Chaoyong He
From: Xinying Yu Reconfigure the NIC will fail because lack of the initialization logic of queue configuration pointer. Fix this by adding the correct initialization logic. Fixes: d89f4990c14e ("vdpa/nfp: add hardware init") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Xinyin

[PATCH 01/10] mailmap: add new contributor

2024-04-26 Thread Chaoyong He
From: Xinying Yu Add new contributor. Signed-off-by: Xinying Yu Reviewed-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 848603bfc5..84a6ff84f9 100644 --- a/.mailmap +++ b/.mailmap @@ -15

[PATCH] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Mattias Rönnblom
Cache align Rx and Tx queue struct to avoid false sharing. RX struct happens to be 64 bytes on x86_64 already, so cache alignment has no effect there, but it does on 32-bit ISAs. TX struct is 56 bytes on x86_64. Both structs keep counters, and in the RX case they are updated even for empty polls

[PATCH 00/10] support software live migration

2024-04-26 Thread Chaoyong He
This patch series aims to add the support of software live migration feature for NFP vDPA device. Xinying Yu (10): mailmap: add new contributor vdpa/nfp: fix logic in hardware init vdpa/nfp: fix the logic of reconfiguration vdpa/nfp: refactor the logic of datapath update vdpa/nfp: add th

Re: [PATCH v3 4/5] vhost: improve fdset initialization

2024-04-26 Thread Maxime Coquelin
Hi Chenbo, On 4/26/24 09:40, Chenbo Xia wrote: Hi Maxime, On Apr 9, 2024, at 19:48, Maxime Coquelin wrote: External email: Use caution opening links or attachments This patch heavily reworks fdset initialization: - fdsets are now dynamically allocated by the FD manager - the event dispatch

Re: [PATCH v3 4/5] vhost: improve fdset initialization

2024-04-26 Thread Chenbo Xia
Hi Maxime, > On Apr 9, 2024, at 19:48, Maxime Coquelin wrote: > > External email: Use caution opening links or attachments > > > This patch heavily reworks fdset initialization: > - fdsets are now dynamically allocated by the FD manager > - the event dispatcher is now created by the FD manager

Re: [PATCH] net/af_packet: cache align Rx/Tx structs

2024-04-26 Thread Mattias Rönnblom
On 2024-04-25 17:35, Ferruh Yigit wrote: On 4/25/2024 4:08 PM, Mattias Rönnblom wrote: On 2024-04-25 16:08, Ferruh Yigit wrote: On 4/23/2024 12:15 PM, Ferruh Yigit wrote: Signed-off-by: Mattias Rönnblom ---   drivers/net/af_packet/rte_eth_af_packet.c | 5 +++--   1 file changed, 3 insertions