RE: [EXTERNAL] [PATCH v3 0/2] crypto/mlx5: optimize AES-GCM IPsec operation

2024-06-25 Thread Akhil Goyal
> To optimize AES-GCM IPsec operation within crypto/mlx5, > the DPDK API typically supplies AES_GCM AAD/Payload/Digest > in separate locations, potentially disrupting their > contiguous layout. In cases where the memory layout fails > to meet hardware (HW) requirements, an UMR WQE is initiated > ah

RE: [PATCH v2 08/12] crypto/cnxk: add dual submission in Rx inject

2024-06-25 Thread Akhil Goyal
> Subject: [PATCH v2 08/12] crypto/cnxk: add dual submission in Rx inject > > From: Anoob Joseph > > Add dual submission to CPT in Rx inject path. > > Signed-off-by: Anoob Joseph > Signed-off-by: Vidya Sagar Velumuri Please fix [146/241] Compiling C object 'drivers/a715181@@tmp_rte_crypto_

[PATCH] dma/idxd: set defaults for GRPCFG traffic class

2024-06-25 Thread Shaiq Wani
Set GRPCFG traffic class to value of 1 for best performance on current generation of accelerators. Applicable to gen1 and gen2 devices. Signed-off-by: Shaiq Wani --- drivers/dma/idxd/idxd_pci.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/dma/idxd/idxd_pci.c b/drive

RE: [EXTERNAL] [PATCH v2 1/2] crypto: fix build issues on unsetting crypto callbacks macro

2024-06-25 Thread Akhil Goyal
> > > Hi Ganapati, > > > Can you send a new version incorporating above comments and work on > > > similar lines as ethdev is currently doing. > > > > > > I believe as Morten pointed out, use of ifdef is as per DPDK > > > convention, So better move it that way. > > > We can discuss later if we can

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-25 Thread huangdengdui
On 2024/6/26 5:07, Damodharam Ammepalli wrote: > On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: >> >> Hi Damodharam >> Here are some suggestions. See below. >> > Thank you for the review. > >> On 2024/6/18 4:34, Damodharam Ammepalli wrote: >>> Update the eth_dev_ops structure with new func

RE: [PATCH] eventdev/dma: fix missing response info in forward mode

2024-06-25 Thread Jiale, SongX
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, June 24, 2024 5:23 PM > To: jer...@marvell.com; Amit Prakash Shukla > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] eventdev/dma: fix missing response info in forward mode > > From: Pavan Nikhilesh > > When i

RE: [PATCH] telemetry: fix potential connection issue

2024-06-25 Thread Jiale, SongX
> -Original Message- > From: Zhichao Zeng > Sent: Friday, June 21, 2024 10:41 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zeng, ZhichaoX ; > Richardson, Bruce ; Wiles, Keith > ; Ciara Power > Subject: [PATCH] telemetry: fix potential connection issue > > For calling memcpy when the sour

Re: [PATCH 5/6] bus/pci: use a dynamic logtype

2024-06-25 Thread Chenbo Xia
On Jun 25, 2024, at 20:24, David Marchand wrote: > > External email: Use caution opening links or attachments > > > Register a logtype for this bus driver and stop logging as EAL. > > Signed-off-by: David Marchand > --- > drivers/bus/pci/bsd/pci.c| 44 +++ > drivers/bus/pci/li

RE: [PATCH v5 3/5] event/dlb2: enhance DLB credit handling

2024-06-25 Thread Sevincer, Abdullah
>++ @Richardson, Bruce @Thomas Monjalon @David Marchand @Ferruh Yigit >+It is not allowed to add PMD specific build options in generic DPDK build >options. Please check with Bruce. >+You may use scheme like >+>+https://patches.dpdk.org/project/dpdk/patch/20240522192139.3016-1-pbhagavat...@ma

[PATCH v1 1/1] bbdev: add missing symbols in version map

2024-06-25 Thread Nicolas Chautru
A few functions were somehow missing for the last few years in the version map file. Signed-off-by: Nicolas Chautru --- lib/bbdev/version.map | 4 1 file changed, 4 insertions(+) diff --git a/lib/bbdev/version.map b/lib/bbdev/version.map index 1840d2b2a4..9d6dac3cca 100644 --- a/lib/bbdev/

[PATCH v1 0/1] bbdev: adding missing symbols in version map

2024-06-25 Thread Nicolas Chautru
Hi Maxime, David, Thomas, I just realized that some symbols have been missing for a long while in the bbdev version map! Basically the 4 functions for ldpc enc/dec. I have put them directly in the DPDK_24 section since these are really not considered experimental for many releases now arguably. Le

Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2024 15:57:02 -0400 Nicholas Pratte wrote: > The previous comments led me to go on an investigation about how MTUs > are allocated in testpmd. --max-pkt-len, which the documentation > states is defaulted to 1518, will shave off 18 bytes to account for > the 14 byte Ethernet frame a

Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-25 Thread Thomas Monjalon
Nicholas, you are writing a test for the API. You should not adapt to the driver behaviour. If the driver does not report what we can expect from the API definition, it is a bug. Ferruh, please can you explain what is the problem with MTU sizes? 25/06/2024 21:57, Nicholas Pratte: > The previous

[PATCH v2 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-06-25 Thread jspewock
From: Jeremy Spewock Previously all scapy commands were handled using an XML-RPC server that ran on the TGNode. This unnecessarily enforces a minimum Python version of 3.10 on the server that is being used as a traffic generator and complicates the implementation of scapy methods. This patch remo

[PATCH v2 0/1] dts: replace XML-RPC server

2024-06-25 Thread jspewock
From: Jeremy Spewock v2: * Address comments left on the previous version about naming and documentation * Change the multiple-inheritance in the scapy traffic generator to use super instead of calling the init methods of the classes directly. Jeremy Spewock (1): dts: Remove XML-RPC ser

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-25 Thread Damodharam Ammepalli
On Wed, Jun 19, 2024 at 8:23 PM huangdengdui wrote: > > Hi Damodharam > Here are some suggestions. See below. > Thank you for the review. > On 2024/6/18 4:34, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet l

Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-25 Thread Nicholas Pratte
The previous comments led me to go on an investigation about how MTUs are allocated in testpmd. --max-pkt-len, which the documentation states is defaulted to 1518, will shave off 18 bytes to account for the 14 byte Ethernet frame and the Dot1Q headers. This is the case when using Mellanox, but for

Re: DTS WG Meeting Minutes - June 20, 2024

2024-06-25 Thread Patrick Robb
On Fri, Jun 21, 2024 at 3:00 AM David Marchand wrote: > > Hello guys, > > On Thu, Jun 20, 2024 at 6:32 PM Patrick Robb wrote: > > * DPDK Summit Montreal > >* Possible CFP topics for DTS: > > * How to write a testsuite. This could be a simple lightning > > talk which shows how we wrote o

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-25 Thread Mattias Rönnblom
On Tue, Jun 25, 2024 at 05:29:35PM +0200, Maxime Coquelin wrote: > Hi Mattias, > > On 6/20/24 19:57, Mattias Rönnblom wrote: > > This patch set make DPDK library, driver, and application code use the > > compiler/libc memcpy() by default when functions in are > > invoked. > > > > The various cus

Re: [PATCH v3 000/129] Update net/ice base driver to latest upstream snapshot

2024-06-25 Thread Bruce Richardson
On Tue, Jun 25, 2024 at 12:12:05PM +0100, Anatoly Burakov wrote: > This is a patchset loosely based on internal development tree which > tracked ICE driver development over a period of time since last snapshot > update. > > v2-> v3: - Fixed commit authorship for commits where it was feasible to >

Re: [PATCH] net/tap/bpf: fix meson warning

2024-06-25 Thread Bruce Richardson
On Tue, Jun 25, 2024 at 10:06:52AM -0700, Stephen Hemminger wrote: > Meson was warning that run_command was used without check and > the result of that will change in future version. > > In this case, the command (uname -m) should be checked. > > Signed-off-by: Stephen Hemminger > --- Acked-by:

[PATCH] net/tap/bpf: fix meson warning

2024-06-25 Thread Stephen Hemminger
Meson was warning that run_command was used without check and the result of that will change in future version. In this case, the command (uname -m) should be checked. Signed-off-by: Stephen Hemminger --- drivers/net/tap/bpf/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v5 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-06-25 Thread jspewock
From: Jeremy Spewock Some NICs tested in DPDK allow for the scattering of packets without an offload and others enforce that you enable the scattered_rx offload in testpmd. The current version of the suite for testing support of scattering packets only tests the case where the NIC supports testin

[PATCH v5 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-25 Thread jspewock
From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there

[PATCH v5 1/4] dts: add context manager for interactive shells

2024-06-25 Thread jspewock
From: Jeremy Spewock Interactive shells are managed in a way currently where they are closed and cleaned up at the time of garbage collection. Due to there being no guarantee of when this garbage collection happens in Python, there is no way to consistently know when an application will be closed

[PATCH v5 2/4] dts: improve starting and stopping interactive shells

2024-06-25 Thread jspewock
From: Jeremy Spewock The InteractiveShell class currently relies on being cleaned up and shutdown at the time of garbage collection, but this cleanup of the class does no verification that the session is still running prior to cleanup. So, if a user were to call this method themselves prior to ga

[PATCH v5 0/4] Add second scatter test case

2024-06-25 Thread jspewock
From: Jeremy Spewock v5: * Spelling corrections based on comments on previous version * Slight reformatting of interactive shells start_application * More documenttion about reasoning behind some requirements in testpmd shell and pmd_buffer_scatter * Allow for hard-coded verification with

[PATCH v1 4/4] dts: add dynamic queue conf to the yaml schema

2024-06-25 Thread jspewock
From: Jeremy Spewock Adds the ability to run the test suite using the yaml configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/fr

[PATCH v1 3/4] dts: add dynamic queue test suite

2024-06-25 Thread jspewock
From: Jeremy Spewock This patch adds a new test suite that is designed to test the stopping and modification of port queues at runtime. Specifically, there are test cases that display the ports ability to stop some queues but still send and receive traffic on others, as well as the ability to con

[PATCH v1 2/4] dts: add port queue modification and forwarding stats to testpmd

2024-06-25 Thread jspewock
From: Jeremy Spewock This patch adds methods for querying and modifying port queue state and configuration. In addition to this, it also adds the ability to capture the forwarding statistics that get outputted when you send the "stop" command in testpmd. Querying of port queue information is hand

[PATCH v1 1/4] dts: add send_packets to test suites and rework packet addressing

2024-06-25 Thread jspewock
From: Jeremy Spewock Currently the only method provided in the test suite class for sending packets sends a single packet and then captures the results. There is, in some cases, a need to send multiple packets at once while not really needing to capture any traffic received back. The method to do

[PATCH v1 0/4] dts: add dynamic queue configuration test suite

2024-06-25 Thread jspewock
From: Jeremy Spewock This patch ports over a test suite from old DTS that tests the implementation of runtime port queue configuration of PMDs. It also includes necessary framework changes to allow this to happen such as: * Sending multiple packets and not capturing the result * Only adjusting a

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-25 Thread Stephen Hemminger
On Tue, 25 Jun 2024 17:29:35 +0200 Maxime Coquelin wrote: > Hi Mattias, > > On 6/20/24 19:57, Mattias Rönnblom wrote: > > This patch set make DPDK library, driver, and application code use the > > compiler/libc memcpy() by default when functions in are > > invoked. > > > > The various custom D

RE: [PATCH v1 0/6] app/crypto-perf: add asymmetric crypto tests

2024-06-25 Thread Dooley, Brian
Hi Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Saturday, June 15, 2024 12:53 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Akhil Goyal > ; Gowrishankar Muthukrishnan > > Subject: [PATCH v1 0/6] app/crypto-perf: add asymmetric crypto tests > > This patch se

[PATCH v7 3/3] dts: config schema

2024-06-25 Thread Dean Marx
Configuration to run vlan test suite Signed-off-by: Dean Marx --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json index f02a310bb5..cd45902cc4

[PATCH v7 2/3] dts: add VLAN methods to testpmd shell

2024-06-25 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 278 ++ 1 file changed,

[PATCH v7 1/3] dts: VLAN test suite implementation

2024-06-25 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 172 1 file changed, 172 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-25 Thread Maxime Coquelin
Hi Mattias, On 6/20/24 19:57, Mattias Rönnblom wrote: This patch set make DPDK library, driver, and application code use the compiler/libc memcpy() by default when functions in are invoked. The various custom DPDK rte_memcpy() implementations may be retained by means of a build-time option. T

Re: [PATCH v5] graph: expose node context as pointers

2024-06-25 Thread Robin Jarry
Sad :( The introduced anonymous structure gets aligned on the minimum cache line size (64 bytes): with this change, ctx[] move from offset 256, to offset 192. Similarly, nodes[] moves from offset 320 to offset 256. As we discussed offlist, there are a few options to workaround this issue (like

RedHat QE's test result against DPDK release candidate 24.07-rc1

2024-06-25 Thread YangHang Liu
I tested below 18 scenarios on the RHEL 9 host and didn't find any new dpdk issues. - VM with device assignment(PF) throughput testing(1G hugepage size): PASS - VM with device assignment(PF) throughput testing(2M hugepage size) : PASS - VM with device assignment(VF) throughput testi

Re: [PATCH v8 2/3] ethdev: add VXLAN last reserved field

2024-06-25 Thread Thomas Monjalon
12/06/2024 03:25, rongwei liu: > From: Ferruh Yigit > > On 6/7/2024 3:02 PM, Rongwei Liu wrote: > > > @@ -41,7 +41,10 @@ struct rte_vxlan_hdr { > > > uint8_tflags;/**< Should be 8 (I flag). */ > > > uint8_trsvd0[3]; /**< Reserved. */ > > >

Re: [PATCH 3/6] net/sfc: remove use of EAL logtype

2024-06-25 Thread Andrew Rybchenko
On 6/25/24 15:24, David Marchand wrote: When registering a common logtype for this driver, instead of explicitly fall back to EAL, rely on the log registration macro to achieve the same. Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko Thanks

Re: [PATCH 1/6] vdpa/sfc: remove dead code

2024-06-25 Thread Andrew Rybchenko
On 6/25/24 15:24, David Marchand wrote: This is probably a copy/paste from the net/sfc driver. sfc_logtype_driver is not a logtype variable from the sfc vDPA driver. Remove it. Fixes: 6dad9a7353d4 ("vdpa/sfc: support device initialization") Cc: sta...@dpdk.org Signed-off-by: David Marchand R

Re: [PATCH] vhost: Fix the crash caused by accessing the released memory

2024-06-25 Thread Patrick Robb
rerunning the failing performance test in CI testing as it was a false failure. On Tue, Jun 25, 2024 at 2:39 AM zhaoxinxin <15957197...@163.com> wrote: > > The rte_vhost_driver_unregister() vhost_user_read_cb() > vhost_user_client_reconnect() can be called at the same time by 3 threads. > when mem

Re: [PATCH v4 13/13] eal: provide option to use compiler memcpy instead of RTE

2024-06-25 Thread Thomas Monjalon
25/06/2024 15:06, Mattias Rönnblom: > On Mon, Jun 24, 2024 at 12:05:53PM +0200, Thomas Monjalon wrote: > > > > > Please could you enable the option in our compilation scripts? > > > > "Compilation scripts" is test-meson-builds.sh? > Should it be done in the same as is being done for stdatomic?

Re: [PATCH v4 13/13] eal: provide option to use compiler memcpy instead of RTE

2024-06-25 Thread Mattias Rönnblom
On Mon, Jun 24, 2024 at 12:05:53PM +0200, Thomas Monjalon wrote: > Please could you enable the option in our compilation scripts? > "Compilation scripts" is test-meson-builds.sh? Should it be done in the same as is being done for stdatomic? Wouldn't it be enough if this is done in CI only?

Re: [PATCH] config: fix warning for cross build with meson >= 1.3.0

2024-06-25 Thread David Marchand
On Mon, Jun 17, 2024 at 5:21 PM Bruce Richardson wrote: > > Starting meson 1.3.0, the pkgconfig variable is deprecated in favor of > > pkg-config. Keep both variables as suggested in meson RN. > > > > Link: > > https://mesonbuild.com/Release-notes-for-1-3-0.html#machine-files-pkgconfig-field-depr

[PATCH 2/2] dts: add blocklist test suite

2024-06-25 Thread Luca Vizzarro
This test suite tests the port blocklisting functionality built in testpmd. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestSuite_blocklist.py | 68 ++ 2 files changed, 70 insertions(+)

[PATCH 1/2] dts: add blocked ports to EalParams

2024-06-25 Thread Luca Vizzarro
Make the "ports" attribute of EalParams as it actually is to "allowed_ports", and add "blocked_ports". Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/eal.py | 6 +- dts/framework/params/types.py | 3 ++- dts/framework/rem

[PATCH 0/2] dts: add blocklist test suite

2024-06-25 Thread Luca Vizzarro
Hello, sending in an re-implementation of the blocklist test suite. This new version slightly differs in the way it verifies if a NIC was blocked or not, but should be equivalent to the original from old DTS. Best, Luca Luca Vizzarro (2): dts: add blocked ports to EalParams dts: add blockli

Re: [PATCH] build: raise error if requested application is unbuildable

2024-06-25 Thread David Marchand
On Tue, Jun 18, 2024 at 2:57 PM Bruce Richardson wrote: > On Tue, Jun 18, 2024 at 02:51:12PM +0200, David Marchand wrote: > > Similarly to libraries, when setting a list of desired applications, > > report if some application cannot be built because of a missing > > dependency. > > > > Signed-off-

Re: [PATCH] meson: use built-in 'modules' helper for python dependencies

2024-06-25 Thread David Marchand
On Mon, Jun 24, 2024 at 10:15 AM Bruce Richardson wrote: > On Sun, Jun 23, 2024 at 01:30:23PM +0100, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > We now require Meson 0.53 or later, so we can use this feature introduced > > in 0.51. This also fixes a build failure on SUSE Leap 1

[PATCH 6/6] crypto/ccp: use a dynamic logtype

2024-06-25 Thread David Marchand
Register a logtype for this bus driver and stop logging as CRYPTODEV. Signed-off-by: David Marchand --- drivers/crypto/ccp/ccp_crypto.c | 4 ++-- drivers/crypto/ccp/ccp_pmd_private.h | 15 +-- drivers/crypto/ccp/rte_ccp_pmd.c | 2 ++ 3 files changed, 9 insertions(+), 12 de

[PATCH 5/6] bus/pci: use a dynamic logtype

2024-06-25 Thread David Marchand
Register a logtype for this bus driver and stop logging as EAL. Signed-off-by: David Marchand --- drivers/bus/pci/bsd/pci.c| 44 +++ drivers/bus/pci/linux/pci.c | 52 drivers/bus/pci/linux/pci_uio.c | 75 +--- drivers/bus/pci/linux/pci_vfio.c

[PATCH 4/6] vdpa/sfc: remove use of EAL logtype

2024-06-25 Thread David Marchand
If registering a dynamic logtype fails at runtime, fall back to a common logtype. Signed-off-by: David Marchand --- drivers/vdpa/sfc/sfc_vdpa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c index 9db87fcb7d..ed

[PATCH 3/6] net/sfc: remove use of EAL logtype

2024-06-25 Thread David Marchand
When registering a common logtype for this driver, instead of explicitly fall back to EAL, rely on the log registration macro to achieve the same. Signed-off-by: David Marchand --- drivers/net/sfc/sfc_ethdev.c | 12 +--- drivers/net/sfc/sfc_log.h| 2 +- 2 files changed, 2 insertions

[PATCH 2/6] drivers: use dedicated log macros instead of EAL logtype

2024-06-25 Thread David Marchand
Those drivers already have their own logtype and set of logging macros. Use them instead of logging as EAL. Signed-off-by: David Marchand --- drivers/bus/auxiliary/auxiliary_common.c | 4 ++-- drivers/bus/dpaa/dpaa_bus.c | 4 ++-- drivers/bus/fslmc/fslmc_vfio.c | 2 +- dri

[PATCH 1/6] vdpa/sfc: remove dead code

2024-06-25 Thread David Marchand
This is probably a copy/paste from the net/sfc driver. sfc_logtype_driver is not a logtype variable from the sfc vDPA driver. Remove it. Fixes: 6dad9a7353d4 ("vdpa/sfc: support device initialization") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/vdpa/sfc/sfc_vdpa_hw.c | 2 -- 1

[PATCH 0/6] Some drivers logging cleanups

2024-06-25 Thread David Marchand
This series removes the last direct calls to some RTE_LOGTYPE_ coming from libraries (EAL and CRYPTODEV) and replaces them with dedicated macros coming from the drivers. -- David Marchand David Marchand (6): vdpa/sfc: remove dead code drivers: use dedicated log macros instead of EAL logtype

[PATCH] net/vmxnet3: fix init logs

2024-06-25 Thread David Marchand
All logs for this driver are emitted under pmd.net.vmxnet3.driver while two logtypes exist. This issue comes from the conversion to dynamic logtypes change. Redirect PMD_INIT_LOG to pmd.net.vmxnet3.init. Fixes: 79daffdcb6ac ("net/vmxnet3: implement dynamic logging") Cc: sta...@dpdk.org Signed-off

Re: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev

2024-06-25 Thread David Marchand
On Mon, Jun 24, 2024 at 5:14 PM Stephen Hemminger wrote: > > On Mon, 24 Jun 2024 11:04:15 + > Vladimir Ratnikov wrote: > > > diff --git a/drivers/bus/vmbus/bus_vmbus_driver.h > > b/drivers/bus/vmbus/bus_vmbus_driver.h > > index e2475a642d..6b010cbe41 100644 > > --- a/drivers/bus/vmbus/bus_vm

Re: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev

2024-06-25 Thread Vladimir Ratnikov
Thanks for review! Regarding to > The patch only has the device_order field, but it is set but not used > anywhere in the DPDK. Unfortunately, It's not for DPDK usage, it's for DPDK based applications. After some time of testing, if nothing's changed in the host OS(no new devices, no removed dev

Re: [PATCH] vhost: only emit debug log with invalid FD

2024-06-25 Thread Maxime Coquelin
On 6/25/24 09:35, David Marchand wrote: On Mon, Jun 24, 2024 at 4:46 PM Maxime Coquelin wrote: This patch improves the FD manager logging in case of FD removal from the epoll FD set failure. When the FD is not more valid, like for example if it is not valid anymore* has already been cl

Re: [PATCH v2 0/9] test-bbdev fixes and improvements for 24.07

2024-06-25 Thread Maxime Coquelin
On 6/24/24 17:02, Hernan Vargas wrote: v2: Added defines for MLD calculation constants. v1:This series targets test-bbdev changes for 24.07. It includes test fixes, iter-max argument change (after deprecation notice in previous releases) and general test improvements. Hernan Vargas (9): t

[PATCH v3 129/129] net/ice: add new device ids

2024-06-25 Thread Anatoly Burakov
From: Bruce Richardson Add new device ids for latest gen NICs. Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_ethdev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index dbdcacf019..f7189b2dfe 100644 --- a/dri

[PATCH v3 128/129] net/ice/base: misc header file clean up

2024-06-25 Thread Anatoly Burakov
From: Jesse Brandeburg Add last remaining changes that include defines, structs etc to allign with shared code snapshot. Add a new function called ice_fls() to the shared code. The unsigned int ice_fls(u64 n) function finds the Most Significant Bit (MSB) and returns the 1-based index of the bit

[PATCH v3 127/129] net/ice/base: introduce new functions in ice_sched_node

2024-06-25 Thread Anatoly Burakov
From: Michal Wilczynski Add new functions to configure the hardware with new parameters. Signed-off-by: Michal Wilczynski Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_sched.c | 52 drivers/net/ice/base/ice_sched.h | 9 ++ 2 files changed, 61 ins

[PATCH v3 126/129] net/ice/base: rename SMA register macros to match Linux upstream

2024-06-25 Thread Anatoly Burakov
From: Jacob Keller The macros used to define the bits for controlling the SMA are different to what we published upstream. We don't have a strong justification to change the upstream names, so fix the out-of-tree shared code to use the names as published upstream. Signed-off-by: Jacob Keller Si

[PATCH v3 125/129] net/ice/base: change a method to get pca9575 handle

2024-06-25 Thread Anatoly Burakov
From: Milena Olech More universal method for getting pca9575 handle is introduced. The first step is to look for CLK_MUX handle. Having that it is possible to find CLK_MUX GPIO pin. Provided data let check what is driving the pin - the expectation is that pca9575 node part number is returned. Si

[PATCH v3 124/129] net/ice/base: make Tx and Rx vernier offset calibration independent

2024-06-25 Thread Anatoly Burakov
The Tx and Rx calibration and timestamp generation blocks are independent. It is not required to wait for both to complete before programming the offsets. Instead, we can program the offset for each independently as soon as they are ready. Modify the ice_phy_cfg_tx_offset_e822 and ice_phy_cfg_rx_o

[PATCH v3 122/129] net/ice/base: remove PHY port timer bypass mode

2024-06-25 Thread Anatoly Burakov
From: Milena Olech Previous implementation switches between bypass and Vernier mode dynamically. However bypass mode should be removed due to low precision. Signed-off-by: Milena Olech Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 195 +- d

[PATCH v3 123/129] net/ice/base: implement TX interrupt enablement functions

2024-06-25 Thread Anatoly Burakov
From: Sergey Temerkhanov Introduce functions enabling/disabling TX TS interrupts for the E822 and ETH56G PHYs Signed-off-by: Sergey Temerkhanov Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 73 +++ drivers/net/ice/base/ice_ptp_hw.h | 4 ++

[PATCH v3 121/129] net/ice/base: cleanup timestamp registers correctly

2024-06-25 Thread Anatoly Burakov
From: Karol Kolacinski E822 PHY TS registers should not be written and the only way to cleanup them is to reset QUAD memory. To ensure that the status bit for the timestamp index is cleared, ensure that ice_clear_phy_tstamp implementations first read the timestamp out. Implementations which can

[PATCH v3 120/129] net/ice/base: enable CGU error reporting

2024-06-25 Thread Anatoly Burakov
From: Karol Kolacinski Enable CGU error reporting for SyncE and TimeSync issues. Process TimeSync loss of lock event by trying to acquire lock with the default config. Signed-off-by: Karol Kolacinski Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ptp_hw.c | 49

[PATCH v3 119/129] net/ice/base: clean up ice_lan_tx_rx

2024-06-25 Thread Anatoly Burakov
From: Ben Shelton ice_lan_tx_rx currently is missing various defines and structs. These must be in place to match sharedcode for ice devices. Add these defines which include - TIMESYNC defines - Doorbell CTX defines and struct Signed-off-by: Ben Shelton --- drivers/net/ice/base/ice_lan_tx_rx.

[PATCH v3 118/129] net/ice/base: update boost struct for traffic types

2024-06-25 Thread Anatoly Burakov
From: Przemek Kitszel Update boost struc to support both udp and vlan based on union. Signed-off-by: Przemek Kitszel Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_flex_type.h | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_fl

[PATCH v3 117/129] net/ice/base: support DCF query port ETS adminq

2024-06-25 Thread Anatoly Burakov
From: Ting Xu In the adminq command query port ETS function, the root node teid is needed. However, for DCF, the root node is not initialized at parent HW init stage, which will cause error when we refer to the variable. In this patch, we will check whether the root node is available or not first

[PATCH v3 116/129] net/ice/base: add AQ function to configure SyncE error reporting

2024-06-25 Thread Anatoly Burakov
From: Ben Shelton The AE driver will call this function to enable the SyncE error reporting mechanism and enable event reporting when errors occur. Signed-off-by: Ben Shelton Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_common.c | 29 + drivers/net/ice/ba

[PATCH v3 115/129] net/ice/base: fix ice_get_ctx() issue

2024-06-25 Thread Anatoly Burakov
From: Yahui Cao No need to invert mask since we only reserve the masked bits instead of clear them. Fixes: a03c714bfe0b ("net/ice/base: add two helper functions") Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Yahui Cao Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_comm

[PATCH v3 114/129] net/ice/base: use a variable to store reset count

2024-06-25 Thread Anatoly Burakov
From: Fabio Pricoco Depending on platform and whether silicon validation tools are used, the timeout value may be set to a different value. This patch uses a variable to store the reset count value as opposed to using the macro directly. Signed-off-by: Fabio Pricoco Signed-off-by: Ian Stokes -

[PATCH v3 113/129] net/ice/base: adjust memcpy type

2024-06-25 Thread Anatoly Burakov
From: Stefan Wegrzyn Modified function ice_aq_manage_mac_read so that ICE_NONDMA_TO_NONDMA memcpy type is used when copying MAC address value from AQC buffer to hardware descriptor. Since (in case of tools) both locations are in user space there is no need to use ICE_DMA_TO_NONDMA memcpy type tha

[PATCH v3 112/129] net/ice/base: increase PF reset wait timeout to 500 milliseconds

2024-06-25 Thread Anatoly Burakov
From: Benjamin Mikailenko In the CORE ICE driver enabled devlink to issue EMPR resets during NVM update. As a result, resets took a matter of around 25ms longer than driver wait time to finish. Fix this by increasing driver wait time from 300ms to 500ms. Signed-off-by: Benjamin Mikailenko Sign

[PATCH v3 111/129] net/ice/base: add missing defines and misc cleanup

2024-06-25 Thread Anatoly Burakov
From: Ian Stokes Add various missing defines and definitions that are currently not present in DPDK but are present in upstream code. Signed-off-by: Ian Stokes Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_adminq_cmd.h | 88 +-- 1 file changed, 84 inserti

[PATCH v3 110/129] net/ice/base: detect and store device sensor reading capability

2024-06-25 Thread Anatoly Burakov
From: Eric Joyner The driver can use this capability to see if temperature sensor reading or other HW sensor reading capabilities are supported before reading them using the Get Sensor Reading AQ command. Signed-off-by: Eric Joyner Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_adminq

[PATCH v3 109/129] net/ice/base: add L2TPv3 support for adv rules

2024-06-25 Thread Anatoly Burakov
From: Wojciech Drewek This patch adds L2TPv3 dummy packets, data structures and defines. Signed-off-by: Wojciech Drewek Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_switch.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ice_swi

[PATCH v3 108/129] net/ice/base: make some switch-related functions static

2024-06-25 Thread Anatoly Burakov
To better align with upstream release, remove some functions from switch header and make them static instead. Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 14 +++--- drivers/net/ice/base/ice_ptp_hw.h | 16 2 files changed, 7 insertions(+), 23 de

[PATCH v3 107/129] net/ice/base: move code to common headers

2024-06-25 Thread Anatoly Burakov
To align with upstream release, move some code to common headers. Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 4 ++-- drivers/net/ice/base/ice_ptp_hw.h | 2 ++ drivers/net/ice/base/ice_sched.c | 8 +++ drivers/net/ice/base/ice_sched.h | 18 dr

[PATCH v3 106/129] net/ice/base: fix compile issues on some targets

2024-06-25 Thread Anatoly Burakov
To avoid triggering compile errors reported on some targets, use explicit type casts to specify type conversion. Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_flow.h | 2 +- drivers/net/ice/base/ice_parser.c | 3 ++- drivers/net/ice/base/ice_ptp_hw.c | 9 + drivers/net/ic

[PATCH v3 105/129] net/ice/base: use const char* array for storing link modes

2024-06-25 Thread Anatoly Burakov
From: Lukasz Plachno This shortens the amount of code needed to do the same thing. Signed-off-by: Lukasz Plachno Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_common.c | 133 +++--- 1 file changed, 28 insertions(+), 105 deletions(-) diff --git a/drivers/

[PATCH v3 104/129] net/ice/base: align code to base driver

2024-06-25 Thread Anatoly Burakov
Currently, there are some miscellaneous changes that are missing from DPDK that are present in base driver code. This patch aligns our code to that of base driver, with following changes happening: - Comment fixes - Whitespace/line break alignment - Moving function definitions within headers - Mov

[PATCH v3 103/129] net/ice/base: rename netlist check functions to match upstream

2024-06-25 Thread Anatoly Burakov
From: Jacob Keller The driver checks the netlist for nodes indicating hardware support using functions named "ice_is__present" sometimes with an additional _e810t postfix. These functions check the contents of the netlist, and don't make any direct device ID check. When upstreaming the functions

[PATCH v3 102/129] net/ice/base: add missing files for shared code update

2024-06-25 Thread Anatoly Burakov
From: Ian Stokes Add missing files that are present in shared code update. Although these do not contain code add them so that shared code update matches like for like. Signed-off-by: Ian Stokes --- drivers/net/ice/base/{ice_fwlog.h => ice_vf_mbx.c} | 0 drivers/net/ice/base/{ice_fwlog.h => ic

[PATCH v3 101/129] net/ice/base: allow skipping main timer programming

2024-06-25 Thread Anatoly Burakov
From: Sergey Temerkhanov Allow initialization functions to skip main timer programming. Signed-off-by: Sergey Temerkhanov Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ptp_hw.c | 31 --- drivers/net/ice/base/ice_ptp_hw.h | 9 ++--- drivers/net/ic

[PATCH v3 100/129] net/ice/base: add E830 PTP init

2024-06-25 Thread Anatoly Burakov
From: Paul Greenwalt Add E830 PTP initialization flow. TXPP requires SW and HW timer clock synchronization which is done during the PTP initialization flow. The E810 and E830 PTP initialization flows are similar. The primary difference that E810 initializes the PHY via AQCs, and E830 does not i

[PATCH v3 099/129] net/ice/base: support E830 in Topology AQ command

2024-06-25 Thread Anatoly Burakov
From: Dan Nowlin In E830, regarding the Get Tx Topology AQ command, there is a change in the way that the RD bit must be set. For E830, the RD bit must be cleared. Setting the RD bit for the E830 device was causing the Get Tx Topology command to fail. Fix it to clear RD bit for E830 device. Sig

[PATCH v3 098/129] net/ice/base: support E830 in DDP pkg handling

2024-06-25 Thread Anatoly Burakov
From: Sergey Temerkhanov Add support for E830 DDP packages in the DDP package handling code. Signed-off-by: Sergey Temerkhanov Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_ddp.c | 6 ++ drivers/net/ice/base/ice_ddp.h | 1 + 2 files changed, 7 insertions(+) diff --git a/dri

[PATCH v3 097/129] net/ice/base: switch speed conversions to static lookups

2024-06-25 Thread Anatoly Burakov
From: Jesse Brandeburg Refactor to use a constant time lookup in a table for speed conversions from ICE_AQ_LINK_SPEED values to speeds defined in firmware. Also, make sure 20MBPS is defined when needed. Signed-off-by: Jesse Brandeburg Signed-off-by: Anatoly Burakov --- drivers/net/ice/ba

[PATCH v3 096/129] net/ice/base: replace array initialization with macros

2024-06-25 Thread Anatoly Burakov
From: Lukasz Plachno Certain compilers do not allow array initialization with indexes, so the best way to avoid the issue when compiling for these platforms is to use a macro. Signed-off-by: Lukasz Plachno Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_common.c | 86 +

[PATCH v3 094/129] net/ice/base: add port option commands

2024-06-25 Thread Anatoly Burakov
Adds the Set/Get Port Options commands (0x06EA/0x06EB), also include additional status and ID bits to improve the Link topology configuration as well as ability to change port option from pre-boot environment via the UEFI driver. Signed-off-by: Anatoly Burakov --- drivers/net/ice/base/ice_adminq

[PATCH v3 093/129] net/ice/base: add Get Link Status Data version 2

2024-06-25 Thread Anatoly Burakov
From: Paul Greenwalt E830 introduces a new version of Get Link Status Data which increases the size of struct ice_aqc_get_link_status_data from 32 bytes to 51 bytes. Add new link partner fields to ice_aqc_get_link_status_data; PHY type, FEC, and flow control. Add new ICE_GET_LINK_STATUS_DATA_V2

  1   2   >