Re: [PATCH v14 1/3] eventdev: add support for independent enqueue

2024-10-04 Thread Jerin Jacob
On Fri, Oct 4, 2024 at 2:20 AM Abdullah Sevincer wrote: > > This commit adds support for independent enqueue feature Remove "This commit adds" > and updates Event Device and PMD feature list. > > A new capability RTE_EVENT_DEV_CAP_INDEPENDENT_ENQ is introduced. It > allows out-of-order enqueuing

Re: [PATCH 2/2] eal/riscv: add support for zicbop extension

2024-10-04 Thread Stephen Hemminger
On Thu, 30 May 2024 18:19:48 +0100 Daniel Gregory wrote: > This new functionality is controlled by a Meson flag that is disabled by > default. Whilst it's a hint, like rte_pause(), and so has no effect if > the target doesn't support the extension, it requires the address > prefetched to be loade

Re: [PATCH v5 0/5] fix segment fault when parse args

2024-10-04 Thread Stephen Hemminger
On Mon, 6 Nov 2023 07:31:19 + Chengwen Feng wrote: > The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), > it also supports to parse only-key (e.g. socket_id). But many drivers's > callback can only handle key-value, it will segment fault if handles > only-key. so the pat

Re: [PATCH 1/2] pcapng: fix handling of chained mbufs

2024-10-04 Thread Stephen Hemminger
On Fri, 13 Sep 2024 15:19:18 +0300 Oleksandr Nahnybida wrote: > The pcapng generates corrupted files when dealing with chained mbufs. > This issue arises because in rte_pcapng_copy the length of the EPB block > is incorrectly calculated using the data_len of the first mbuf instead > of the pkt_le

[PATCH] replace use of word segregate in comments

2024-10-04 Thread Stephen Hemminger
The use of the word segregate should be avoided. Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/ The word segregation carries strong context in regard to civil rights movements in the US and South Africa, segregation in the US South, and racist history. Signed-off-by

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-10-04 Thread Stephen Hemminger
On Thu, 25 Apr 2024 17:53:08 +0100 Ferruh Yigit wrote: > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 548fada1c7ad..40f04c0e191b 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3136,6 +3136,9 @@ int rte_eth_stats_get(uint16_t port_id, struct

Re: [PATCH] eal/common: fix inconsistent representation of PCI numbers

2024-10-04 Thread Stephen Hemminger
On Mon, 1 Jul 2024 23:01:17 +0300 Shani Peretz wrote: > +/** > + * General device name comparison. Will compare by using the specific bus > + * compare function or by comparing the names directly. > + * > + * @param dev > + * Device handle. > + * @param name > + * Name to compare against. > +

[PATCH v2] doc/multi-process: fix grammar and phrasing

2024-10-04 Thread Stephen Hemminger
Simplify awkward wording in description of the multi process application. Signed-off-by: Stephen Hemminger --- doc/guides/sample_app_ug/multi_process.rst | 168 - 1 file changed, 61 insertions(+), 107 deletions(-) diff --git a/doc/guides/sample_app_ug/multi_process.rst b/do

Re: [PATCH] app: enhance error check if enqueue fail in test_mbuf test_refcnt_iter

2024-10-04 Thread Stephen Hemminger
On Thu, 24 Aug 2023 09:37:18 +0200 jhascoet wrote: > From: Julien Hascoet > > As the ring is big enough by construction, the ring > enqueue ops cannot fail; therefore, we check and panic > on it as soon as it is detected. > > Signed-off-by: Julien Hascoet > --- As per earlier patch in the em

Re: [PATCH 2/4] mempool: clarify comments for mempool cache implementation

2024-10-04 Thread Stephen Hemminger
On Wed, 7 Jun 2023 12:10:01 +0200 Morten Brørup wrote: > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Thursday, 9 March 2023 05.58 > > > > Clarify that the mempool cache create and free API implementations > > work on user owned mempool caches. > > > > Signed-off

Re: [PATCH v3 3/3] build: RFC - add support for optional dependencies

2024-10-04 Thread Stephen Hemminger
On Wed, 20 Dec 2023 15:43:36 + Bruce Richardson wrote: > On Wed, Dec 20, 2023 at 04:08:08PM +0100, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Wednesday, 20 December 2023 15.22 > > > > > > In order to remove more libraries from the mandat

Re: [PATCH] net/bnxt: fix newline character in speed display

2024-10-04 Thread Ajit Khaparde
On Fri, Oct 4, 2024 at 1:53 PM Damodharam Ammepalli wrote: > > Mistakenly "\n" sneaked into bnxt_print_link_info which > prints the speed and lanes information of Broadcom Thor2 NIC. > This patch removes this newline character. > > Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")

[PATCH] net/bnxt: fix newline character in speed display

2024-10-04 Thread Damodharam Ammepalli
Mistakenly "\n" sneaked into bnxt_print_link_info which prints the speed and lanes information of Broadcom Thor2 NIC. This patch removes this newline character. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Cc: sta...@dpdk.org Signed-off-by: Damodharam Ammepalli --- drivers/n

Re: [PATCH] doc: update TAP device features

2024-10-04 Thread Stephen Hemminger
On Fri, 4 Oct 2024 02:48:21 +0100 Ferruh Yigit wrote: > > +Stats per queue = Y > > > > This feature name is misleading, > it is for 'rte_eth_dev_set_[rt]x_queue_stats_mapping()' API, which is > indeed for covering limitation for some drivers. > Tap does support getting stats per queue, bu

Per queue stats

2024-10-04 Thread Stephen Hemminger
... > >>> The stats queue mapping was a feature that was hinted at being removed. > >>> It only exists because of HW limitations on Intel ixgbe NIC and SW > >>> limitations from RTE_ETHDEV_QUEUE_STAT_CNTRS. > >>> > >> > >> > >> We have a plan to remove 'RTE_ETHDEV_QUEUE_STAT_CNTRS', by moving que

Re: [PATCH dpdk v2 04/16] net: use ipv6 structure for header addresses

2024-10-04 Thread Robin Jarry
Ferruh Yigit, Oct 04, 2024 at 20:01: On 10/1/2024 9:17 AM, Robin Jarry wrote: @@ -918,12 +918,14 @@ static struct chrte_fparse parseitem[] = { .fptr = ch_rte_parsetype_ipv6, .dmask = &(const struct rte_flow_item_ipv6) { .hdr = { -

[PATCH] maintainers: update for dts

2024-10-04 Thread Patrick Robb
Paul and Patrick have been appointed as the new dts maintainers. Updating the MAINTAINERS file to reflect this. Signed-off-by: Patrick Robb --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 812463fe9f..5c8402707a 100644 --- a/MA

RE: [PATCH] ethdev: convert string initialization

2024-10-04 Thread Dariusz Sosnowski
> -Original Message- > From: Andrew Rybchenko > Sent: Friday, October 4, 2024 09:27 > To: Ferruh Yigit ; NBU-Contact-Thomas Monjalon > (EXTERNAL) ; Ori Kam ; Aman Singh > ; Konstantin Ananyev > ; Reshma Pattan ; > Stephen Hemminger ; Akhil Goyal > ; Anoob Joseph ; Potnuri Bharat > Teja ; H

RE: [RFC 0/4] ethdev: rework config restore

2024-10-04 Thread Dariusz Sosnowski
> -Original Message- > From: Ferruh Yigit > Sent: Monday, September 30, 2024 01:31 > To: Dariusz Sosnowski ; NBU-Contact-Thomas > Monjalon (EXTERNAL) ; Andrew Rybchenko > > Cc: dev@dpdk.org; Bruce Richardson ; Konstantin > Ananyev > Subject: Re: [RFC 0/4] ethdev: rework config restore >

RE: [RFC v2] ethdev: an API for cache stashing hints

2024-10-04 Thread Wathsala Wathawana Vithanage
> > >> > > >> And I can see set() has two different APIs, > > >> 'rte_eth_dev_stashing_hints_rx' & 'rte_eth_dev_stashing_hints_tx', > > >> is there a reason to have two separate APIs instead of having one > > >> which gets RX & TX as argument, as done in internal device ops? > > > > > > Some types/

Re: [PATCH v5] doc: add new driver guidelines

2024-10-04 Thread Ferruh Yigit
On 10/4/2024 5:39 PM, Nandini Persad wrote: > +* Each patch should be organized logically as a new feature. > +* Run test tools per patch (See :ref:`tool_list`:). > ':' after `tool_list` is extra and can be dropped. Rest looks good to me, thanks.

RE: [PATCH v2 02/10] baseband/acc: queue allocation refactor

2024-10-04 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 4, 2024 5:08 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v2 02/10] baseband/acc: queue allocation refactor > >

Re: [PATCH 0/8] fix the representor port link status and speed

2024-10-04 Thread Ferruh Yigit
On 9/5/2024 7:25 AM, Chaoyong He wrote: > This patch series aims to fix some problems in the representor port link > status and speed update logic, also do some refactors to the related > logics. > > Qin Ke (8): > net/nfp: fix incorrect type declaration of some variables > net/nfp: add help fu

[PATCH v2] cryptodev: add asymmetric operational capability

2024-10-04 Thread Gowrishankar Muthukrishnan
Asymmetric crypto algorithms such as SM2, EdDSA would need per op capability and based on it, the input param to a crypto operation is chosen wisely. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - op_capa is array of int instead of structure. - compilation issues addressed. --- app/test/t

Re: [PATCH dpdk v2 04/16] net: use ipv6 structure for header addresses

2024-10-04 Thread Ferruh Yigit
On 10/1/2024 9:17 AM, Robin Jarry wrote: > @@ -918,12 +918,14 @@ static struct chrte_fparse parseitem[] = { > .fptr = ch_rte_parsetype_ipv6, > .dmask = &(const struct rte_flow_item_ipv6) { > .hdr = { > - .src_addr = > +

Re: [RFC] ethdev: convert string initialization

2024-10-04 Thread Ferruh Yigit
On 10/4/2024 4:17 PM, Stephen Hemminger wrote: > On Thu, 1 Aug 2024 02:27:22 -0700 > Ferruh Yigit wrote: > >> gcc 15 experimental [1], with -Wextra flag, gives warning in variable >> initialization as string [2]. >> >> The warning has a point when initialized variable is intended to use as >> str

Re: [RFC v2] ethdev: an API for cache stashing hints

2024-10-04 Thread Stephen Hemminger
On Sun, 22 Sep 2024 22:43:55 +0100 Ferruh Yigit wrote: > >> > >> And I can see set() has two different APIs, > >> 'rte_eth_dev_stashing_hints_rx' & > >> 'rte_eth_dev_stashing_hints_tx', is there a reason to have two separate > >> APIs > >> instead of having one which gets RX & TX as argument, a

[PATCH v4 47/47] net/bnxt: tf_ulp: add stats cache for thor2

2024-10-04 Thread Sriharsha Basavapatna
From: Peter Spreadborough This change adds a stats cache for Thor2 flows using counters. Flow stats will be harvested periodically in the background and stats reads by the application will be returned stats from the cache and not by initiating a read from HW. This change also adds read-clear fun

[PATCH v4 45/47] net/bnxt: tf_ulp: support a few feature extensions

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch supports the following features. add support for port table write operation Added support for port table write operation from the template so that template can write mirror id details into the port database. support generic template fo

[PATCH v4 44/47] net/bnxt: tf_ulp: enable support for truflow feature configuration

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added truflow feature bit meson configuration parameter to enable optional capability features of the appplication. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_

[PATCH v4 42/47] net/bnxt: tf_ulp: TFC support flow scale query for Thor2

2024-10-04 Thread Sriharsha Basavapatna
From: Shuanglin Wang TFC supports the flow scale query feature for OVS application. The resource usage(WC-TCAM) is tracked inside Thor2 firmware. This patch is to query the wc-tcam usage info when adding/ deleting a flow. It is just for debugging purpose and disabled by default. Using the build

[PATCH v4 41/47] net/bnxt: tf_ulp: support a few generic template items

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch provides the following changes. support generic template items Add support for jump action, dynamic tunnels and flow priority to thor2 platform. fix generic application template The queue action is enabled for Thor2 platform. E

[PATCH v4 39/47] net/bnxt: tf_ulp: switch ulp to use rte crc32 hash

2024-10-04 Thread Sriharsha Basavapatna
From: Peter Spreadborough The RTE hash is highly optimized and will use HW acceleration when available. Signed-off-by: Peter Spreadborough Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 4 dr

[PATCH v4 36/47] net/bnxt: tf_ulp: add support for rss flow query to ULP

2024-10-04 Thread Sriharsha Basavapatna
From: Randy Schacher Support flow query rss command for truflow in ULP layer. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c| 39 +- drivers/net/bnxt/bnxt_

[PATCH v4 35/47] net/bnxt: tf_ulp: TF support flow scale query

2024-10-04 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH v4 34/47] net/bnxt: tf_ulp: add rte_mtr support for Thor2

2024-10-04 Thread Sriharsha Basavapatna
From: Jay Ding 1. Implement Thor2 meter template tables 2. Add Thor2 meter support in ULP 3. Make rte_mtr API implementation device independent to adapt Thor2 meter hw change 4. Fix the round issue in xir calculation Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v4 30/47] net/bnxt: tf_ulp: add mask defaults when mask is not specified

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha If application does not specify mask in a field description then use the default mask values from dpdk header files. This patch also includes the following related changes. fix stats collection for shared session The stats accumulation was being performed on def

[PATCH v4 29/47] net/bnxt: tf_ulp: update template files

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. dynamic support for VF representor mode (template files only) The configurable VF representor mode is removed and it is dynamic. The action record

[PATCH v4 28/47] net/bnxt: tf_ulp: modify return values to adhere to C coding standard

2024-10-04 Thread Sriharsha Basavapatna
From: Shuanglin Wang Modified return values of the several ULP utilities to comply C coding standard. Like using macros EXIT_SUCCESS(0) and EXIT_FAILURE(1) for the conventional status value for success and failure, respectively. They are declared in the file stdlib.h. Signed-off-by: Shuanglin W

[PATCH v4 27/47] net/bnxt: tf_ulp: fixed parent child db counters

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha The locking for the parent child counters need to be done till the stats are retrieved. Also the OVS is creating multiple F1 flows for same tunnel hence reference count needs to be maintined for the F1 flows. Fix name conflicts for class and action tables. Matcher alloca

[PATCH v4 26/47] net/bnxt: tf_ulp: enable recipe id generation

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added support to generate recipe id generation. This patch includes a few related changes: fix segfault in the wildcard recipe process The recipe id is being passed as 8 bit instead of 64bit causing the crash. Ported code using default_non_ha resource

[PATCH v4 25/47] net/bnxt: tf_ulp: update template files

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha This patch updates template files for the following list of changes, that are being added in the next patch. - enable recipe id generation - fix segfault in the wildcard recipe process Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by:

[PATCH v4 23/47] net/bnxt: tf_ulp: VFR updates for Thor 2

2024-10-04 Thread Sriharsha Basavapatna
From: Mike Baucom Update to VFR code to: - add the endpoint (efid) to the session - modify the generic tables to write the l2 context id - tfc session code changes to allow the efid to be added to the sid - release both rfid and efid from afm This patch includes a few related changes: Thor2 cha

[PATCH v4 21/47] net/bnxt: tf_ulp: add action read and clear support

2024-10-04 Thread Sriharsha Basavapatna
From: Jay Ding Implement action read and clear support. Change flow query count to reset the count after read in ULP. Update cli cmds accordingly. Fixed bnxt_mpc_xmit() to pad the mpc message to be multiple of 16 bytes. Signed-off-by: Jay Ding Signed-off-by: Sriharsha Basavapatna Reviewed-by:

Re: [PATCH v2] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-10-04 Thread Stephen Hemminger
On Fri, 3 May 2024 19:27:30 +0100 Daniel Gregory wrote: > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check > memorder, which is not constant. This causes compile errors when it is > enabled with RTE_ARM_USE_WFE. eg. > > ../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_w

[PATCH v4 19/47] net/bnxt: tf_ulp: convert recipe table to dynamic memory

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Converted the recipe table allocation from static model to dynamic memory allocation model. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 175 +

[PATCH v4 16/47] net/bnxt: tf_ulp: miscellaneous fixes

2024-10-04 Thread Sriharsha Basavapatna
From: Mike Baucom Template compiler modifications for v3 api: Compile named/unnamed shared app resources for the applications that are capable. Change app id signature with base zero offset: The app id is used in the calculation of the matching signatures and as app id value incr

[PATCH v4 15/47] net/bnxt: tf_ulp: Wh+ mirroring support

2024-10-04 Thread Sriharsha Basavapatna
From: Manish Kurup 1. ULP fixes to enable primitives to support mirroring 2. RTE parser changes to support and use multiple ports in RTE input msgs 3. Template changes required to support ingress mirroring 4. Template changes required to support egress mirroring (using VFR pipeline) Signed

[PATCH v4 14/47] net/bnxt: tf_ulp: add support for vf to vf flow offload

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added support for the vf to vf flow offload for the whitney platform. It includes the change of the pipeline from using vlan tags to using custom L2 encap and decap of the packets. Signed-off-by: Kishore Padmanabha Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shah

[PATCH v4 13/47] net/bnxt: tf_ulp: add custom l2 etype tunnel support

2024-10-04 Thread Sriharsha Basavapatna
From: Shahaji Bhosle Add hooks in the hwrm and ulp layer to enable, custom tunnel header support on wh+ generic app(ovs). Signed-off-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapatna Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 4

RE: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-04 Thread Akhil Goyal
> Hello, > > Ferruh Yigit writes: > > > On 9/5/2024 11:14 AM, Akhil Goyal wrote: > >> Replace *_LIST_END enumerators from asymmetric crypto > >> lib to avoid ABI breakage for every new addition in > >> enums with inline APIs. > >> > >> Signed-off-by: Akhil Goyal > >> --- > >> This patch was dis

[PATCH v4 10/47] net/bnxt: tf_core: remove dead code from session-based priority TCAM mgr

2024-10-04 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to tx_tcam_supported and rx_tcam_supported logic which chooses between FW-based tcam resource allocation and driver-based tcam manager. Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Peter Spreadborough Reviewed-by: Manis

[PATCH v4 09/47] net/bnxt: tf_core: remove dead AFM code from session-based priority TCAM mgr

2024-10-04 Thread Sriharsha Basavapatna
From: Randy Schacher Remove references to AFM allocated memory which is no longer supported with TCAM mgr and truflow Signed-off-by: Randy Schacher Signed-off-by: Sriharsha Basavapatna Reviewed-by: Farah Smith Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[PATCH v4 07/47] net/bnxt: tf_core: fix slice count in case of HA entry move

2024-10-04 Thread Sriharsha Basavapatna
From: Sangtani Parag Satishbhai When entries are moved during HA, a shared move function transfers TCAM entries by using get/set message APIs, and the slice number of the entry is required to accomplish the movement. The slice number is calculated as the product of row_slice and entry size. Befor

[PATCH v4 06/47] net/bnxt: tf_core: TF support flow scale query

2024-10-04 Thread Sriharsha Basavapatna
From: Shuanglin Wang TF supports the flow scale query feature for OVS application. The resource usage is tracked when opening a TF session or adding/deleting a flow. The resources includes WC TCAM, EM, Action, Counter, Meter, ACT_ENCAP, ACT_ENCAP, and SP_SMAC. User can query the resource usage us

[PATCH v4 05/47] net/bnxt: tf_core: flow scale improvement

2024-10-04 Thread Sriharsha Basavapatna
From: Kishore Padmanabha Added logic to add flows to wildcard tcam if flows fail to be added to exact match table. Signed-off-by: Kishore Padmanabha Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde Reviewed-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapatna --- drivers/net/bnxt/

[PATCH v4 04/47] net/bnxt: tf_core: Thor TF EM key size check

2024-10-04 Thread Sriharsha Basavapatna
From: Farah Smith The maximum EM key size is 640 bits for Thor. But the lookup record + the key size is 679 bits. This value must be rounded up to a 128 bit aligned number. So the size check should be 96 bytes rather than 80. This fix allows keys > 601 bits to be successfully inserted. Fixes:

[PATCH v4 03/47] net/bnxt: tf_core: External EM support cleanup

2024-10-04 Thread Sriharsha Basavapatna
From: Shuanglin Wang Isolate external EM support as it is now defunct on Wh+. Signed-off-by: Shuanglin Wang Signed-off-by: Sriharsha Basavapatna Reviewed-by: Shahaji Bhosle Reviewed-by: Farah Smith Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/meson.build |2 - drivers/ne

[PATCH v4 02/47] net/bnxt: tf_core: tcam manager data corruption

2024-10-04 Thread Sriharsha Basavapatna
From: Shahaji Bhosle Max entries per session were not getting initialized to 0, when the sessions were closed. Reset max entries counter session when the session is initialized Fixes: 97435d7906d7 ("net/bnxt: update Truflow core") Signed-off-by: Shahaji Bhosle Signed-off-by: Sriharsha Basavapat

[PATCH v4 01/47] net/bnxt: tf_core: fix wc tcam multi slice delete issue

2024-10-04 Thread Sriharsha Basavapatna
From: Shahaji Bhosle FW tries to update the HWRM request data in the delete case to update the mode bit and also update invalid profile id. This update only happens when the data is send over DMA. HWRM requests are read only buffers and cannot be updated. So driver now will always send WC tcam se

[PATCH v4 00/47] TruFlow update for Thor2

2024-10-04 Thread Sriharsha Basavapatna
This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. TruFlow(TF) is the software library that exposes CFA HW resources to upper layer protocols or applications. This patch series implements the tfc (tf_core) and the tf_ulp libraries as a part of the bnxt PMD, so that upper la

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-10-04 Thread Stephen Hemminger
On Sun, 26 May 2024 09:21:55 +0200 Mattias Rönnblom wrote: > On 2024-05-08 17:23, Stephen Hemminger wrote: > > On Wed, 8 May 2024 09:19:02 +0200 > > Mattias Rönnblom wrote: > > > >> On 2024-05-04 00:00, Stephen Hemminger wrote: > >>> On Fri, 3 May 2024 16:45:47 +0100 > >>> Ferruh Yigit wro

Re: [PATCH v2] eal/linux: enhanced error handling for affinity

2024-10-04 Thread Stephen Hemminger
On Sun, 28 Apr 2024 20:26:18 +0800 (CST) "Jianyue Wu" wrote: > Yes, agree with that, there is also trace from kernel can see that. I'll > ignore this patch. > > > At 2024-04-27 08:18:53, "Stephen Hemminger" > wrote: > >On Fri, 26 Apr 2024 08:47:37 -0700 > >Tyler Retzlaff wrote: > > > >> >

RE: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-04 Thread Akhil Goyal
> On Fri, Oct 4, 2024 at 5:55 AM Ferruh Yigit wrote: > > > > On 9/5/2024 11:14 AM, Akhil Goyal wrote: > > > Replace *_LIST_END enumerators from asymmetric crypto > > > lib to avoid ABI breakage for every new addition in > > > enums with inline APIs. > > > > > > Signed-off-by: Akhil Goyal > > > --

RE: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

2024-10-04 Thread Akhil Goyal
> > If we want to make it a generic thing in rte_common.h > > Will the below change be ok? > > -- > > Common header file (rte_common.h): > > -- > > #define rte_define_enum_list_end(name, last_value) \ > > static inline int name ## _enu

Re: [PATCH] doc: update TAP device features

2024-10-04 Thread Ferruh Yigit
On 10/4/2024 8:54 AM, Bruce Richardson wrote: > On Fri, Oct 04, 2024 at 05:09:21AM +0100, Ferruh Yigit wrote: >> On 10/4/2024 3:26 AM, Stephen Hemminger wrote: >>> On Fri, 4 Oct 2024 02:48:21 +0100 >>> Ferruh Yigit wrote: >>> On 9/4/2024 4:42 PM, Stephen Hemminger wrote: > The TAP device

Re: [PATCH v6 2/2] net/bnxt: code refactor for supporting speed lanes

2024-10-04 Thread Damodharam Ammepalli
On Fri, Oct 4, 2024 at 6:56 AM David Marchand wrote: > > Hello, > > On Thu, Sep 26, 2024 at 11:56 PM Damodharam Ammepalli > wrote: > > @@ -1331,16 +1376,17 @@ static int bnxt_dev_configure_op(struct rte_eth_dev > > *eth_dev) > > void bnxt_print_link_info(struct rte_eth_dev *eth_dev) > > { > >

Re: [PATCH] app/dma-perf: documentation update of DMA perf for idxd

2024-10-04 Thread Bruce Richardson
On Thu, Jun 27, 2024 at 05:34:04AM +, Shaiq Wani wrote: > Added a note to avoid usage errors by end user. > > Signed-off-by: Shaiq Wani > --- > app/test-dma-perf/config.ini | 3 +++ > doc/guides/tools/dmaperf.rst | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/app/test-dma-perf/c

[PATCH v1 30/31] net/ntnic: add Tx Packet Editor (TPE) FPGA module

2024-10-04 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 80 + drivers/net/ntn

RE: [EXTERNAL] Re: [PATCH v5 0/6] Introduce event pre-scheduling

2024-10-04 Thread Pavan Nikhilesh Bhagavatula
> > From: Pavan Nikhilesh > > > > Event pre-scheduling improves scheduling performance by assigning events > > to event ports in advance when dequeues are issued. > > This series introduces various types and levels of pre-scheduling to the > > eventdev library. > > > > pre-scheduling Types: > > *

Re: [PATCH] dma/idxd: set defaults for GRPCFG traffic class

2024-10-04 Thread Bruce Richardson
On Wed, Jun 26, 2024 at 05:45:23AM +, Shaiq Wani wrote: > Set GRPCFG traffic class to value of 1 for best performance on current > generation of accelerators. Applicable to gen1 and gen2 devices. > > Signed-off-by: Shaiq Wani > --- > drivers/dma/idxd/idxd_pci.c | 13 + > 1 file c

[PATCH v5] doc: add new driver guidelines

2024-10-04 Thread Nandini Persad
This document was created to assist contributors in creating DPDK drivers and provides suggestions and guidelines on how to upstream effectively. Signed-off-by: Ferruh Yigit Signed-off-by: Nandini Persad Reviewed-by: Stephen Hemminger Acked-by: Chengwen Feng --- doc/guides/contributing/index.

Re: [PATCH v5 0/6] Introduce event pre-scheduling

2024-10-04 Thread Stephen Hemminger
On Fri, 4 Oct 2024 21:54:45 +0530 wrote: > From: Pavan Nikhilesh > > Event pre-scheduling improves scheduling performance by assigning events > to event ports in advance when dequeues are issued. > This series introduces various types and levels of pre-scheduling to the > eventdev library. > >

Re: [PATCH] devtools: download scripts from linux if not found

2024-10-04 Thread Stephen Hemminger
On Fri, 15 Mar 2024 15:14:42 +0100 Robin Jarry wrote: > Both checkpatches.sh and get-maintainer.sh require scripts that come > from the linux sources. And they require DPDK_*_PATH variables to be set > to point at these scripts locally. For new contributors this can be > tedious since they will h

Re: [PATCH v4 0/6] docs: getting started guide consolidation

2024-10-04 Thread Stephen Hemminger
On Wed, 22 Nov 2023 20:26:21 -0500 David Young wrote: > This patch series introduces significant updates to the DPDK Getting Started > Guide, enhancing user accessibility and content clarity: > > 1-Structural Improvements: > Integrated links to the Getting Started Guide in the main index. > Relo

[PATCH v5 5/6] app/test-eventdev: add pre-scheduling support

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Add support to configure pre-scheduling for eventdev test application. Option `--preschedule` 0 - Disable pre-scheduling. 1 - Enable pre-scheduling. 2 - Enable pre-schedule with adaptive mode (Default). Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common

[PATCH v5 4/6] event/cnkx: add pre-schedule support

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Add device level and port level pre-schedule support for cnxk eventdev. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 10 -- doc/guides/eventdevs/features/cnxk.ini | 1 + drivers/event/cnxk/cn10k_eventdev.c| 19 +-

[PATCH v5 6/6] examples: use eventdev pre-scheduling

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Enable event pre-scheduling if supported by the event device. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/pipeline_worker_generic.c | 6 ++ examples/eventdev_pipeline/pipeline_worker_tx.c | 6 ++ examples/ipsec-secgw/event_helper.c

[PATCH v5 3/6] eventdev: add event preschedule hint

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Add a new eventdev API to provide a hint to the eventdev PMD to pre-schedule the next event into the event port, without releasing the current flow context. Event device that support this feature advertises the capability using the RTE_EVENT_DEV_CAP_PRESCHEDULE_EXPLICIT capa

[PATCH v5 1/6] eventdev: introduce event pre-scheduling

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. The dequeue operation initiates the pre-schedule operation, which completes in parallel without affecting the dequeued event flow contexts and dequeue

[PATCH v5 2/6] eventdev: add event port pre-schedule modify

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Some event devices allow pre-schedule types to be modified at runtime on an event port. Add `RTE_EVENT_DEV_CAP_PER_PORT_PRESCHEDULE` capability to indicate that the event device supports this feature. Add `rte_event_port_preschedule_modify()` API to modify the pre-schedule

[PATCH v5 0/6] Introduce event pre-scheduling

2024-10-04 Thread pbhagavatula
From: Pavan Nikhilesh Event pre-scheduling improves scheduling performance by assigning events to event ports in advance when dequeues are issued. This series introduces various types and levels of pre-scheduling to the eventdev library. pre-scheduling Types: * RTE_EVENT_PRESCHEDULE_NONE: No pr

[PATCH 10/10] ethdev: require checking results of info_get functions

2024-10-04 Thread Stephen Hemminger
With functions that return a data structure, the application must check the return value since the data structure contents will be undefined in case of error. Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.h | 34 +- 1 file changed, 21 insertions(+), 1

[PATCH 09/10] ethdev: check return value from rte_eth_dev_info_get

2024-10-04 Thread Stephen Hemminger
The mac compare must check return value from rte_eth_dev_info_get before using the dev_info information. Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_class_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c

[PATCH 08/10] examples/qos_sched: check return value from rte_eth_link_get

2024-10-04 Thread Stephen Hemminger
The return status of link is undefined if call to rte_eth_link_get returns an error. Signed-off-by: Stephen Hemminger --- examples/qos_sched/init.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 32964

[PATCH 07/10] examples/pipeline: check return value of ethdev functions

2024-10-04 Thread Stephen Hemminger
The rte_eth_dev_info_get and rte_eth_link_get functions may return an error, and in that case the information structure is undefined. The port is valid check is not needed, that can be handled by rte_eth_dev_info_get checks. Signed-off-by: Stephen Hemminger --- examples/pipeline/cli.c | 7 --

[PATCH 06/10] examples/ntb: always check return value

2024-10-04 Thread Stephen Hemminger
The ethdev_info is only valid if rte_eth_dev_info_get returns success. Fixes: 5194299d6ef5 ("examples/ntb: support more functions") Cc: xiaoyun...@intel.com Signed-off-by: Stephen Hemminger --- examples/ntb/ntb_fwd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/example

[PATCH 05/10] examples/l3fwd: check return value from ethdev info

2024-10-04 Thread Stephen Hemminger
Need to check return value from rte_eth_dev_info_get. Signed-off-by: Stephen Hemminger --- examples/l3fwd-graph/main.c | 12 ++-- examples/l3fwd/l3fwd_fib.c | 16 examples/l3fwd/l3fwd_lpm.c | 14 ++ 3 files changed, 32 insertions(+), 10 deletions(-) diff -

[PATCH 04/10] examples/ethtool: handle devices without registers

2024-10-04 Thread Stephen Hemminger
If device does not support reading registers then call to rte_eth_dev_get_reg_info will return an error. This fixes compiler warning when warn unused result is set. Signed-off-by: Stephen Hemminger --- examples/ethtool/lib/rte_ethtool.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH 03/10] graph: check return value from rte_eth_dev_info_get

2024-10-04 Thread Stephen Hemminger
The data in rte_eth_dev_info is undefined if rte_eth_dev_info_get returns an error. Handle the errors the same as previous error. Signed-off-by: Stephen Hemminger --- app/graph/ethdev.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/app/graph/ethdev.c b

[PATCH 02/10] net/memif: check return value from rte_eth_dev_info_get

2024-10-04 Thread Stephen Hemminger
Handle errors from rte_eth_dev_info_get in the same manner as other places in this file. Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif

[PATCH 01/10] app/test: remove redundant call

2024-10-04 Thread Stephen Hemminger
The patch to check return value of rte_eth_dev_info_get added a duplicate call in one spot. Fixes: 773392553bed ("app: check status of getting ethdev info") Signed-off-by: Stephen Hemminger --- app/test/test_link_bonding_rssconf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test/test_

[PATCH 00/10] require checking ethdev get return value

2024-10-04 Thread Stephen Hemminger
Several places flagged by Coverity and Codeql are from code that calls rte_eth_dev_info_get() but does not check the return value. If rte_eth_dev_info_get() returns an error, the device info is garbage. This patch series uses the function attribute to force code to check the result or there will b

RE: [PATCH v6 6/6] app/crypto-perf: support EDDSA

2024-10-04 Thread Dooley, Brian
Hi Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 9:26 AM > To: dev@dpdk.org; Dooley, Brian > Cc: Anoob Joseph ; Richardson, Bruce > ; jer...@marvell.com; > fanzhang@gmail.com; Kusztal, ArkadiuszX > ; Ji, Kai ; jack.bond- > pres.

RE: [PATCH v6 5/6] examples/fips_validation: support EDDSA

2024-10-04 Thread Dooley, Brian
Hi Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 9:26 AM > To: dev@dpdk.org; Dooley, Brian ; Gowrishankar > Muthukrishnan > Cc: Anoob Joseph ; Richardson, Bruce > ; jer...@marvell.com; > fanzhang@gmail.com; Kusztal, ArkadiuszX >

Re: [PATCH dpdk v2 14/16] rib6,fib6,lpm6: remove duplicate constants

2024-10-04 Thread Stephen Hemminger
On Fri, 04 Oct 2024 13:54:42 +0200 "Robin Jarry" wrote: > Stephen Hemminger, Oct 04, 2024 at 01:12: > > On Tue, 1 Oct 2024 10:17:26 +0200 > > Robin Jarry wrote: > > > >> Replace all address size and max depth macros with common ones from > >> rte_ip6.h. > >> > >> Signed-off-by: Robin Jarry

Re: [PATCH v4 8/8] examples/l3fwd-power: update to call arg parser API

2024-10-04 Thread Stephen Hemminger
On Fri, 15 Dec 2023 17:26:32 + Euan Bourke wrote: > Update to the l3fwd-power example application to call the arg parser > library for its 'combined core string parser' instead of implementing its > own corelist parser. The default_type passed into the function call is > a corelist. > > Sign

Re: [PATCH v2] vhost: fix crash on vhost-user client port deletion

2024-10-04 Thread Stephen Hemminger
On Thu, 11 May 2023 22:59:57 +0800 suntianyuan wrote: > The rte_vhost_driver_unregister() and vhost_user_read_cb() can be > called at the same time by 2 threads. reconn may be added back to > reconn_list by vhost_user_read_cb() after rte_vhost_driver_unregister() > removed from reconn_list. Then

Re: [PATCH v3] docs: freebsd: Update to 20.11

2024-10-04 Thread Stephen Hemminger
On Thu, 6 Jul 2023 16:36:05 -0400 David Young wrote: > This patch updates the FreeBSD DPDK installation guide to detail > how users can find and install specific versions of DPDK using the > pkg package manager. The prior instructions did not highlight > 'dpdk' is an alias and may not always po

RE: [EXTERNAL] Re: [v2 7/7] crypto/dpaa2_sec: rework debug code

2024-10-04 Thread Akhil Goyal
> Hello guys, > > On Tue, Aug 6, 2024 at 12:28 PM Gagandeep Singh wrote: > > > > From: Jun Yang > > > > Output debug information according to various modes. > > > > Signed-off-by: Jun Yang > > --- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 87 +++-- > > 1 file changed, 6

  1   2   3   >