Re: [PATCH v3 5/5] net/cxgbe: use rte macro instead of GCC attribute

2024-10-08 Thread Potnuri Bharat Teja
On Monday, October 10/07/24, 2024 at 13:18:30 -0700, Stephen Hemminger wrote: > On Thu, 13 Jun 2024 16:05:10 +0200 > David Marchand wrote: > > > On Thu, Jun 13, 2024 at 3:44 PM David Marchand > > wrote: > > > > > > On Wed, Jun 12, 2024 at 10:16 AM David Marchand > > > wrote: > > > > > > > > O

Re: [PATCH v9 05/17] examples/vhost: fix free function mismatch

2024-10-08 Thread Chenbo Xia
> On Oct 9, 2024, at 00:47, Stephen Hemminger > wrote: > > External email: Use caution opening links or attachments > > > The pointer bdev is allocated with rte_zmalloc() and then > incorrectly freed with free() which will lead pool corruption. > > Bugzilla ID: 1553 > Fixes: c19beb3f38cd ("

Re: [PATCH v2] rawdev: add API to get device from index

2024-10-08 Thread Hemant Agrawal
Reviewed-by:  Hemant Agrawal On 08-10-2024 13:10, Akhil Goyal wrote: Added an internal API for PMDs to get raw device pointer from a device id. Signed-off-by: Akhil Goyal --- - resend patch for main branch separated from rvu_lf raw driver https://patches.dpdk.org/project/dpdk/list/?series=329

[PATCH v2] net/mvneta: fix possible out-of-bounds write

2024-10-08 Thread Chengwen Feng
The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit --- v2: ad

RE: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

2024-10-08 Thread Ankur Dwivedi
>-Original Message- >From: Stephen Hemminger >Sent: Tuesday, October 8, 2024 6:11 AM >To: Ankur Dwivedi >Cc: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob >Subject: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in >checkpatch > >On Wed, 17 Jul 2024 12: 09: 53 + Ank

[v2] crypto/dpaa2_sec: rework debug code

2024-10-08 Thread Gagandeep Singh
Output debug information according to various modes. Signed-off-by: Jun Yang Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 72 + 1 file changed, 46 insertions(+), 26 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/

Re: [PATCH v5 0/5] fix segment fault when parse args

2024-10-08 Thread fengchengwen
Hi Stephen, On 2024/10/5 9:19, Stephen Hemminger wrote: > On Mon, 6 Nov 2023 07:31:19 + > Chengwen Feng wrote: > >> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), >> it also supports to parse only-key (e.g. socket_id). But many drivers's >> callback can only handle

[PATCH v6 1/4] kvargs: add one new process API

2024-10-08 Thread Chengwen Feng
The rte_kvargs_process() was used to handle key=value (e.g. socket_id=0), it also supports to handle only-key (e.g. socket_id). But many drivers's callback can only handle key=value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified to

[PATCH v6 0/4] fix segment fault when parse args

2024-10-08 Thread Chengwen Feng
The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), it also supports to parse only-key (e.g. socket_id). But many drivers's callback can only handle key-value, it will segment fault if handles only-key. so the patchset [1] was introduced. Because the patchset [1] modified too

[PATCH v6 2/4] net/sfc: use new API to parse kvargs

2024-10-08 Thread Chengwen Feng
Add sfc_kvargs_process_opt() function to handle only-key case, and remove redundancy NULL judgement of value because the rte_kvargs_process (which invoked in sfc_kvargs_process()) will handle it. Signed-off-by: Chengwen Feng --- drivers/common/sfc_efx/sfc_efx.c | 3 --- drivers/net/sfc/sfc_ethd

[PATCH v6 4/4] common/nfp: use new API to parse kvargs

2024-10-08 Thread Chengwen Feng
The nfp_parse_class_options() function could handle both key=value and only-key, so it should use rte_kvargs_process_opt() instead of rte_kvargs_process() to parse. Signed-off-by: Chengwen Feng --- drivers/common/nfp/nfp_common_pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) d

[PATCH v6 3/4] net/tap: use new API to parse kvargs

2024-10-08 Thread Chengwen Feng
Some kvargs could be key=value or only-key, it should use rte_kvargs_process_opt() instead of rte_kvargs_process() to handle these kvargs. Signed-off-by: Chengwen Feng --- drivers/net/tap/rte_eth_tap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/tap

Re: [PATCH] net/mvneta: fix possible out-of-bounds write

2024-10-08 Thread zhoumin
Recheck-request: loongarch-compilation -- Just for a test, please ignore.

Re: [PATCH] net/mvneta: fix possible out-of-bounds write

2024-10-08 Thread Stephen Hemminger
On Wed, 9 Oct 2024 02:23:42 + Chengwen Feng wrote: > The mvneta_ifnames_get() function will save 'iface' value to ifnames, > it will out-of-bounds write if passed many iface pairs (e.g. > 'iface=xxx,iface=xxx,...'). > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") > Cc: sta...@dpdk.o

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-08 Thread Gowrishankar Muthukrishnan
> > > > > +/** > > > > > + * EdDSA operation params > > > > > + */ > > > > > +struct rte_crypto_eddsa_op_param { > > > > > + enum rte_crypto_asym_op_type op_type; > > > > > + /**< Signature generation or verification */ > > > > > + > > > > > + rte_crypto_param message; > > > > > + /

Re: [PATCH] Increasing ci meson version to .57

2024-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2024 15:25:43 -0400 Patrick Robb wrote: > There is a proposed increase in the minimum meson version to .57 > This patch aligns the linux setup ci script with this change. > > Signed-off-by: Patrick Robb I wonder if we shouldn't push it to something later. Debian stable is using

RE: [PATCH v2] cryptodev: add asymmetric operational capability

2024-10-08 Thread Gowrishankar Muthukrishnan
> Acked-by: Arkadiusz Kusztal Thanks. > With some comments. > > > diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > b/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > index b7b612fc57..6f81bcb110 100644 > > --- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c > > +++ b/drivers/crypt

Re: [PATCH v2 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-08 Thread Ferruh Yigit
On 10/7/2024 8:33 PM, Serhii Iliushyk wrote: > The list of updates provided by the patchset: > * Update the supported version of the FPGA to 9563.55.49 > * Fix Coverity issues > * Fix issues related to release 24.07 > * Extended and fixed the implementation of the logging > * Added NT flo

Just for a test, please ignore

2024-10-08 Thread zhoumin
Recheck-request: loongarch-compilation -- Just for a test, please ignore.

Re: [PATCH v2 05/50] net/ntnic: extend and fix logging implementation

2024-10-08 Thread Ferruh Yigit
On 10/7/2024 8:33 PM, Serhii Iliushyk wrote: > @@ -682,7 +682,7 @@ static void > qsfp28_wait_for_ready_after_reset(nim_i2c_ctx_p ctx) > init_complete_flag_present = (data & (1 << 4)) != 0; > } > > - NT_LOG(DBG, NTHW, "NIM InitCompleteFlagPresent = %d", > init_complete_fl

Re: [PATCH] Increasing ci meson version to .57

2024-10-08 Thread Aaron Conole
Patrick Robb writes: > Haha... I guess that serves as a lesson. > > Thanks Bruce. Probably worth it to try that patch out and add your tested-by tag :)

[PATCH] net/mvneta: fix possible out-of-bounds write

2024-10-08 Thread Chengwen Feng
The mvneta_ifnames_get() function will save 'iface' value to ifnames, it will out-of-bounds write if passed many iface pairs (e.g. 'iface=xxx,iface=xxx,...'). Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Ferruh Yigit --- driver

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-08 Thread Wathsala Wathawana Vithanage
> > > 1. rte_ring_generic_pvt.h: > > > = > > > > > > pseudo-c-code //related > > > armv8 instructions > > > > > > -- > > > hea

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-08 Thread Wathsala Wathawana Vithanage
> > > > 1. rte_ring_generic_pvt.h: > > > = > > > > > > pseudo-c-code //related > > > armv8 instructions > > > > > > -- > > >

Re: [PATCH v3] app/proc-info: add rte_eal_cleanup() to avoid memory leak

2024-10-08 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/10/4 10:48, Stephen Hemminger wrote: > From: Fidaullah Noonari > > when app is launched with -m proc-info exit without > rte_eal_cleanup() causing memory leakage. This commit resolves the > memory leakage issue and closes app properly. > > Bugzilla id: 898 > Sig

Re: [PATCH] net/gve: add IO memory barriers before reading descriptors

2024-10-08 Thread Ferruh Yigit
On 10/4/2024 2:05 AM, Joshua Washington wrote: > Without memory barriers, there is no guarantee that the CPU will > actually wait until after the descriptor has been fully written before > loading descriptor data. In this case, it is possible that stale data is > read and acted on by the driver whe

Re: [RFC 0/4] ethdev: rework config restore

2024-10-08 Thread Ferruh Yigit
On 10/8/2024 6:21 PM, Konstantin Ananyev wrote: > > >> We have been working on optimizing the latency of calls to >> rte_eth_dev_start(), on ports spawned by mlx5 PMD. Most of the work >> requires changes in the implementation of >> .dev_start() PMD callback, but I also wanted to

Re: [PATCH 0/5] Increase minimum meson version

2024-10-08 Thread zhoumin
Hi David, On Tues, Oct 8, 2024 at 8:28AM, David Marchand wrote: Hello CI guys, On Fri, Sep 20, 2024 at 2:57 PM Bruce Richardson wrote: This patchset proposed increasing the minimum meson version to 0.57 and makes changes to update our build files appropriately for that change: replacing depre

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-08 Thread Ferruh Yigit
On 10/8/2024 9:51 PM, Kusztal, ArkadiuszX wrote: > Hi Ferruh, > Thanks for the review, comments inline, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, October 8, 2024 5:43 AM >> To: Kusztal, ArkadiuszX ; Marchand, David >> >> Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian >>

Re: [PATCH v2 3/3] app/testpmd: add support for querying TM nodes

2024-10-08 Thread fengchengwen
Please update the testpmd doc, with that added, Acked-by: Chengwen Feng On 2024/10/8 22:43, Bruce Richardson wrote: > Support use of the rte_tm_node_query API to print out details about > previously added TM nodes in testpmd. > > Example output, configuring three nodes, and then printing the det

Re: [PATCH v2 1/3] ethdev: add traffic manager query function

2024-10-08 Thread fengchengwen
On 2024/10/8 22:43, Bruce Richardson wrote: > Add function to allow querying a node in the scheduler tree. Returns > the parameters as were given to the add function. Adding this function > allows apps to just query the hierarchy rather than having to maintain > their own copies of it internally.

Re: [PATCH v2] replace use of word segregate in comments

2024-10-08 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/10/8 23:49, Stephen Hemminger wrote: > The use of the word segregate should be avoided. > Rationale from https://inclusivenaming.org/word-lists/tier-3/segregate/ > > The word segregation carries strong context in regard to civil rights > movements in the US an

[PATCH v10] dts: port over queue start/stop suite

2024-10-08 Thread Dean Marx
This suite tests the ability of the Poll Mode Driver to enable and disable Rx/Tx queues on a port. Depends-on: patch-12 ("dts: add port queue modification and forwarding stats to testpmd") Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json |

[PATCH v10 0/1] dts: port over queue start/stop suite

2024-10-08 Thread Dean Marx
Queue start/stop suite ensures the Poll Mode Driver can functionally enable and disable Rx/Tx queues on ports. The suite contains two test cases: 1. All queues enabled - verifies that packets are received when all queues on all ports are enabled. 2. Queue start/stop - verifies that packets are not

RE: [PATCH v4 2/4] cryptodev: add ec points to sm2 op

2024-10-08 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 8, 2024 11:09 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op > > On Tue, 8 Oct 2024 21:00:50 + > "Kusztal

Re: [PATCH v2] fib: network byte order IPv4 lookup

2024-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2024 17:16:05 + Vladimir Medvedkin wrote: > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order

Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op

2024-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2024 21:00:50 + "Kusztal, ArkadiuszX" wrote: > Hi Stephen, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, October 8, 2024 10:46 PM > > To: Kusztal, ArkadiuszX > > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > > > Subject: Re: [PATCH

RE: [PATCH v4 2/4] cryptodev: add ec points to sm2 op

2024-10-08 Thread Kusztal, ArkadiuszX
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 8, 2024 10:46 PM > To: Kusztal, ArkadiuszX > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op > > On Tue, 8 Oct 2024 19:14:31 +0100

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-08 Thread Kusztal, ArkadiuszX
Hi Ferruh, Thanks for the review, comments inline, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 8, 2024 5:43 AM > To: Kusztal, ArkadiuszX ; Marchand, David > > Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian > > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api >

Re: [PATCH v4 2/4] cryptodev: add ec points to sm2 op

2024-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2024 19:14:31 +0100 Arkadiusz Kusztal wrote: > + RTE_CRYPTO_SM2_PARTIAL, > + /**< > + * PMD does not support the full process of the > + * SM2 encryption/decryption, but the elliptic > + * curve part only Couldn't this just be: /**< PMD only supports

[PATCH v6 2/2] dts: mac filter test suite refactored for new dts

2024-10-08 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. In porting over this test suite into the new framework, some adjustments were made, namely in the EAL and TestPMD parameter provided before executing

[PATCH v6 1/2] dts: add methods for setting mac and multicast addresses

2024-10-08 Thread Nicholas Pratte
New methods have been added to TestPMDShell in order to produce the mac filter's individual test cases: - set_mac_addr - set_multicast_mac_addr set_mac_addr and set_multicast_addr were created for the mac filter test suite, enabling users to both add or remove mac and multicast addresses based o

[PATCH v6 0/2] Mac Filter Port to New DTS

2024-10-08 Thread Nicholas Pratte
v6: * Added a subtle change to the invalid address test to avoid failures. This component should be discussed and eventually fixed as this is a temporary fix for a discovered issue. * Added decorators to sync with the capabilities patch. Nicholas Pratte (2): dts: add methods for sett

RE: [PATCH v2 05/10] baseband/acc: enhance SW ring alignment

2024-10-08 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 8, 2024 12:52 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v2 05/10] baseband/acc: enhance SW ring alignment >

Re: [PATCH] Increasing ci meson version to .57

2024-10-08 Thread Patrick Robb
Haha... I guess that serves as a lesson. Thanks Bruce.

Re: [PATCH] Increasing ci meson version to .57

2024-10-08 Thread Bruce Richardson
On Tue, Oct 08, 2024 at 03:25:43PM -0400, Patrick Robb wrote: > There is a proposed increase in the minimum meson version to .57 > This patch aligns the linux setup ci script with this change. > > Signed-off-by: Patrick Robb > --- > .ci/linux-setup.sh | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [OS-Team] [dpdklab] Re: [PATCH 0/5] Increase minimum meson version

2024-10-08 Thread Bruce Richardson
On Tue, Oct 08, 2024 at 03:49:12PM -0400, Patrick Robb wrote: >On Tue, Oct 8, 2024 at 4:28 AM David Marchand ><[1]david.march...@redhat.com> wrote: > > This series can't be merged until the (UNH and LoongArch) CI are > ready > for such a change. > TL;DR: the meson minim

Re: [OS-Team] [dpdklab] Re: [PATCH 0/5] Increase minimum meson version

2024-10-08 Thread Patrick Robb
On Tue, Oct 8, 2024 at 4:28 AM David Marchand wrote: > > This series can't be merged until the (UNH and LoongArch) CI are ready > for such a change. > > TL;DR: the meson minimum version is being changed from 0.53.2 to 0.57 > in the current release. > > @UNH @Min Zhou > How long would it take for

Re: [PATCH] Increasing ci meson version to .57

2024-10-08 Thread Patrick Robb
Oh, I guess I should have mentioned that I did "test" this for good measure, by spinning up a base ubuntu 20.04 container, running the linux-setup.sh with this change, and did a dpdk build. Tested-by: Patrick Robb On Tue, Oct 8, 2024 at 3:27 PM Patrick Robb wrote: > There is a proposed increas

[PATCH v4 4/4] app/test: add test sm2 C1/Kp test cases

2024-10-08 Thread Arkadiusz Kusztal
This commit adds tests cases to be used when C1 or kP elliptic curve points need to be computed. Signed-off-by: Arkadiusz Kusztal --- app/test/test_cryptodev_asym.c | 138 - app/test/test_cryptodev_sm2_test_vectors.h | 112 ++- 2 files

[PATCH v4 3/4] crypto/qat: add sm2 encryption/decryption function

2024-10-08 Thread Arkadiusz Kusztal
This commit adds SM2 elliptic curve based asymmetric encryption and decryption to the Intel QuickAssist Technology PMD. Signed-off-by: Arkadiusz Kusztal --- doc/guides/cryptodevs/features/qat.ini | 1 + doc/guides/rel_notes/release_24_11.rst | 4 + drivers/common/qat/qat_ad

[PATCH v4 2/4] cryptodev: add ec points to sm2 op

2024-10-08 Thread Arkadiusz Kusztal
In the case when PMD cannot support the full process of the SM2, but elliptic curve computation only, additional fields are needed to handle such a case. Points C1, kP therefore were added to the SM2 crypto operation struct. Signed-off-by: Arkadiusz Kusztal --- lib/cryptodev/rte_crypto_asym.h |

[PATCH v4 1/4] cryptodev: reorder structures in asym crypto header

2024-10-08 Thread Arkadiusz Kusztal
Asymmetric-crypto header has a simple structure that allows to keep logically separate blocks together. Therefore, xforms, ops, and generic structs may be appropriately ordered. This patch moves sm2-op structs to be placed along other algorithms-op structs. Signed-off-by: Arkadiusz Kusztal --- l

[PATCH v4 0/4] add ec points to sm2 op

2024-10-08 Thread Arkadiusz Kusztal
In the case when PMD cannot support the full process of the SM2, but elliptic curve computation only, additional fields are needed to handle such a case. Depends-on: patch-145188 ("[v2] cryptodev: add asymmetric operational capability") v2: - rebased against the 24.11 code v3: - added feature fl

[PATCH] Increasing ci meson version to .57

2024-10-08 Thread Patrick Robb
There is a proposed increase in the minimum meson version to .57 This patch aligns the linux setup ci script with this change. Signed-off-by: Patrick Robb --- .ci/linux-setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/linux-setup.sh b/.ci/linux-setup.sh index 975b

[PATCH v17 1/1] dts: VLAN test suite implementation

2024-10-08 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Depends-on: Patch-145500 ("dts: add VLAN methods to testpmd shell") Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestS

[PATCH v17 0/1] port over VLAN test suite

2024-10-08 Thread Dean Marx
Port over VLAN capabilities test suite from old DTS. This test suite verifies that VLAN filtering, stripping, and header insertion all function as expected. When a VLAN ID is in the filter list, all packets with that ID should be forwarded and all others should be dropped. While stripping is enable

[PATCH v3] dts: add VLAN methods to testpmd shell

2024-10-08 Thread Dean Marx
Added the following methods to testpmd shell class: set vlan filter on/off, rx vlan add/rm, set vlan strip on/off, tx vlan set/reset, set promisc/verbose. Fixed a bug in the VLAN regex used in testpmd shell flags. Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by:

[DPDK/ethdev Bug 1561] BNX2X: Jumbo frames not working on NetXtreme II BCM57810

2024-10-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1561 Bug ID: 1561 Summary: BNX2X: Jumbo frames not working on NetXtreme II BCM57810 Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED

[PATCH v3] dts: add VLAN methods to testpmd shell

2024-10-08 Thread Dean Marx
Added the following methods to testpmd shell class: set vlan filter on/off, rx vlan add/rm, set vlan strip on/off, tx vlan set/reset, set promisc/verbose. Fixed a bug in the VLAN regex used in testpmd shell flags. Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by:

[PATCH v3 9/9] raw/cnxk_rvu_lf: add PMD API to get device pffunc

2024-10-08 Thread Akhil Goyal
Added ``rte_pmd_rvu_lf_pf_func_get`` API to get RVU LF device pffunc for the application use. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/roc_rvu_lf.c | 2 +- drivers/common/cnxk/roc_rvu_lf.h | 2 ++ drivers/common/cnxk/version.map | 1 + driver

[PATCH v3 8/9] raw/cnxk_rvu_lf: add selftest

2024-10-08 Thread Akhil Goyal
Added raw device selftest for cnxk_rvu_lf to verify various PMD APIs. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 18 drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 137 +- 2 files changed, 154 insertions(+), 1 deletion(-) diff --git a/doc/guide

[PATCH v3 7/9] raw/cnxk_rvu_lf: process mailbox message

2024-10-08 Thread Akhil Goyal
Added PMD API rte_pmd_rvu_lf_msg_process() to process mailbox messages between rvu_lf devices. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 8 ++ doc/guides/rel_notes/release_24_11.rst| 5 + drivers/common/cnxk/roc_dev.c | 118 +++

[PATCH v3 6/9] raw/cnxk_rvu_lf: set message ID range

2024-10-08 Thread Akhil Goyal
Added PMD API rte_pmd_rvu_lf_msg_id_range_set() to set RVU mailbox message id range. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 12 drivers/common/cnxk/roc_mbox.h| 1 + drivers/common/cnxk/roc_rvu_lf.c | 30 ++

[PATCH v3 5/9] raw/cnxk_rvu_lf: register/unregister msg handler

2024-10-08 Thread Akhil Goyal
Added PMD APIs rte_pmd_rvu_lf_msg_handler_register() and rte_pmd_rvu_lf_msg_handler_unregister() to register/unregister mailbox message handlers. These handlers are needed to fill response at the other side for the request sent from one side. Signed-off-by: Akhil Goyal --- drivers/common/cnxk/ro

[PATCH v3 4/9] raw/cnxk_rvu_lf: register/unregister interrupt handler

2024-10-08 Thread Akhil Goyal
Added PMD API rte_pmd_rvu_lf_irq_register() and rte_pmd_rvu_lf_irq_unregister() to register/unregister interrupt handlers for rvu lf raw device. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 8 drivers/common/cnxk/roc_rvu_lf.c | 26 +++

[PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses

2024-10-08 Thread Akhil Goyal
Added rte_pmd_rvu_lf_bar_get() API to get BAR address for application to configure hardware. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst| 7 ++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 23 +++ drivers/raw/cnxk_rvu_lf/rte_pmd_cnxk_rvu_

[PATCH v3 2/9] raw/cnxk_rvu_lf: add PMD API to get npa/sso pffunc

2024-10-08 Thread Akhil Goyal
Added rte_pmd_rvu_lf_npa_pf_func_get and rte_pmd_rvu_lf_sso_pf_func_get APIs to get NPA and SSO pffunc for the application use. Signed-off-by: Akhil Goyal --- doc/api/doxy-api-index.md | 1 + doc/guides/rawdevs/cnxk_rvu_lf.rst| 7 +++ drivers/common/cnxk/roc_npa

[PATCH v3 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-08 Thread Akhil Goyal
CNXK product families can have a use case to allow PF and VF applications to communicate using mailboxes and also get notified of any interrupt that may occur on the device. Hence, a new raw device driver is added for such RVU LF devices. These devices can map to a PF or a VF which can send mailbox

[PATCH v3 0/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-08 Thread Akhil Goyal
CNXK product families can have a use case to allow PF and VF applications to communicate using mailboxes and also get notified of any interrupt that may occur on the device. Hence, a new raw device driver is added for such RVU LF devices. These devices can map to a PF or a VF which can send mailbox

Re: [PATCH v2 1/2] fib: implement RCU rule reclamation

2024-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2024 17:55:23 + Vladimir Medvedkin wrote: > + if ((tbl8_idx == -ENOSPC) && dp->dq != NULL) { Better to either drop the parenthesis here, or put it on both conditions. > + /* If there are no tbl8 groups try to reclaim one. */ > + if (rte_rcu_qsbr_dq_

Re: [PATCH v2 1/2] fib: implement RCU rule reclamation

2024-10-08 Thread Stephen Hemminger
On Tue, 8 Oct 2024 17:55:23 + Vladimir Medvedkin wrote: > @@ -569,7 +600,60 @@ dir24_8_free(void *p) > { > struct dir24_8_tbl *dp = (struct dir24_8_tbl *)p; > > + if (dp->dq != NULL) > + rte_rcu_qsbr_dq_delete(dp->dq); > + Side note: rte_rcu_qsbr_dq_delete should be

[PATCH v2 2/2] test/fib: add RCU functional tests

2024-10-08 Thread Vladimir Medvedkin
Add positive and negative tests for API rte_fib_rcu_qsbr_add. Also test FIB library behavior when RCU QSBR is enabled. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c | 209 1 file changed, 209 insertions(+) diff --git a/app/test/test_fib.c

[PATCH v2 1/2] fib: implement RCU rule reclamation

2024-10-08 Thread Vladimir Medvedkin
Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. As a result, lookup may be performed incorrectly. To address that, RCU QSBR is integrated for safe tbl8 group reclamation. Sign

[PATCH v3 0/5] power: refactor power management library

2024-10-08 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organizati

[PATCH v3 5/5] maintainers: update for drivers/power

2024-10-08 Thread Sivaprasad Tummala
Update maintainers for drivers/power/*. Signed-off-by: Sivaprasad Tummala --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 812463fe9f..7d2868fe30 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1737,6 +1737,7 @@ M: Anatoly Burakov M: David Hunt

[PATCH v3 4/5] power/amd_uncore: uncore support for AMD EPYC processors

2024-10-08 Thread Sivaprasad Tummala
This patch introduces driver support for power management of uncore components in AMD EPYC processors. v2: - fixed typo in comments section. - added fabric frequency get support for legacy platforms. Signed-off-by: Sivaprasad Tummala --- drivers/power/amd_uncore/amd_uncore.c | 329 +++

[PATCH v3 2/5] power: refactor uncore power management library

2024-10-08 Thread Sivaprasad Tummala
This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. This

[PATCH v3 3/5] test/power: removed function pointer validations

2024-10-08 Thread Sivaprasad Tummala
After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Siv

[PATCH v3 1/5] power: refactor core power management library

2024-10-08 Thread Sivaprasad Tummala
This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories within 'drivers/power/core/*'. The adjustment of m

[PATCH v3 0/5] power: refactor power management library

2024-10-08 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organizati

[PATCH v2] fib: network byte order IPv4 lookup

2024-10-08 Thread Vladimir Medvedkin
Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH] fib6: add runtime checks for vector lookup

2024-10-08 Thread Vladimir Medvedkin
AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding if vector function can be used. Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --

[PATCH v3 5/5] maintainers: update for drivers/power

2024-10-08 Thread Sivaprasad Tummala
Update maintainers for drivers/power/*. Signed-off-by: Sivaprasad Tummala --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 812463fe9f..7d2868fe30 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1737,6 +1737,7 @@ M: Anatoly Burakov M: David Hunt

[PATCH v3 0/5] power: refactor power management library

2024-10-08 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organizati

[PATCH v3 3/5] test/power: removed function pointer validations

2024-10-08 Thread Sivaprasad Tummala
After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Siv

[PATCH v3 4/5] power/amd_uncore: uncore support for AMD EPYC processors

2024-10-08 Thread Sivaprasad Tummala
This patch introduces driver support for power management of uncore components in AMD EPYC processors. v2: - fixed typo in comments section. - added fabric frequency get support for legacy platforms. Signed-off-by: Sivaprasad Tummala --- drivers/power/amd_uncore/amd_uncore.c | 328 +++

[PATCH v3 2/5] power: refactor uncore power management library

2024-10-08 Thread Sivaprasad Tummala
This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. This

[PATCH v3 1/5] power: refactor core power management library

2024-10-08 Thread Sivaprasad Tummala
This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories within 'drivers/power/core/*'. The adjustment of m

[PATCH v3 0/5] power: refactor power management library

2024-10-08 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organizati

RE: [RFC 0/4] ethdev: rework config restore

2024-10-08 Thread Konstantin Ananyev
> We have been working on optimizing the latency of calls to > rte_eth_dev_start(), on ports spawned by mlx5 PMD. Most of the work > requires changes in the implementation of > .dev_start() PMD callback, but I also wanted to start a discussion > regarding configuration re

[PATCH v16] dts: VLAN test suite implementation

2024-10-08 Thread Dean Marx
Test suite for verifying VLAN filtering, stripping, and insertion functionality on Poll Mode Driver. Depends-on: Patch-145473 ("dts: add VLAN methods to testpmd shell") Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 +- dts/tests/TestS

[PATCH v16 0/1] dts: port over VLAN test suite

2024-10-08 Thread Dean Marx
Port over VLAN capabilities test suite from old DTS. This test suite verifies that VLAN filtering, stripping, and header insertion all function as expected. When a VLAN ID is in the filter list, all packets with that ID should be forwarded and all others should be dropped. While stripping is enable

[PATCH v2] fib: network byte order IPv4 lookup

2024-10-08 Thread Vladimir Medvedkin
Previously when running rte_fib_lookup IPv4 addresses must have been in host byte order. This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on fib create, which will allow to have IPv4 in network byte order on lookup. Signed-off-by: Vladimir Medvedkin --- app/test/test_fib.c

[PATCH v2] dts: add VLAN methods to testpmd shell

2024-10-08 Thread Dean Marx
Added the following methods to testpmd shell class: set vlan filter on/off, rx vlan add/rm, set vlan strip on/off, tx vlan set/reset, set promisc/verbose. Fixed a bug in the VLAN regex used in testpmd shell flags. Fixes: 61d5bc9bf974 ("dts: add port info command to testpmd shell") Signed-off-by:

RE: [PATCH v2] cryptodev: add asymmetric operational capability

2024-10-08 Thread Kusztal, ArkadiuszX
Acked-by: Arkadiusz Kusztal With some comments. > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Friday, October 4, 2024 8:13 PM > To: dev@dpdk.org; Kusztal, ArkadiuszX ; Akhil > Goyal ; Fan Zhang ; Ankur > Dwivedi ; Anoob Joseph ; > Tejasree Kondoj ; Ji, Kai > Cc: fanzh

Re: [RFC v3 1/3] uapi: introduce kernel uAPI headers import

2024-10-08 Thread Maxime Coquelin
On 9/19/24 10:39, Thomas Monjalon wrote: 11/09/2024 21:32, Maxime Coquelin: This patch introduces uAPI headers import into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr

Re: [RFC v3 1/3] uapi: introduce kernel uAPI headers import

2024-10-08 Thread Maxime Coquelin
On 9/17/24 13:36, David Marchand wrote: On Wed, Sep 11, 2024 at 9:32 PM Maxime Coquelin wrote: This patch introduces uAPI headers import into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https://git.kernel.org/pub/scm/linux/kernel/git/

RE: [EXTERNAL] [PATCH v9 04/17] event/cnxk: fix free of non-heap in cleanup code

2024-10-08 Thread Pavan Nikhilesh Bhagavatula
> The code to cleanup in case of error would derefence null pointer > then pass that result to rte_free. > > Fixes: 97a05c1fe634 ("event/cnxk: add port config") > Cc: sthot...@marvell.com > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger Thanks Stephen, Acked-by: Pavan Nikhilesh

[PATCH v3 10/10] net: use global AVX-512 variables

2024-10-08 Thread Bruce Richardson
Replace some library-specific checks for AVX-512 with the standard variables from config/x86. Signed-off-by: Bruce Richardson --- lib/net/meson.build | 40 1 file changed, 4 insertions(+), 36 deletions(-) diff --git a/lib/net/meson.build b/lib/net/meson.

  1   2   3   >