dumpcap, interfaces, and promiscuous mode

2022-12-27 Thread Ben Magistro
ybe adding an option to inherit the main process's promiscuous state(s) when starting. Happy to try and work on some of these changes but want to talk through the issues first so we can try to address all of them. Cheers, Ben Magistro

Re: dumpcap, interfaces, and promiscuous mode

2022-12-28 Thread Ben Magistro
entioned before I am happy to try and work on some of these changes, but would like to have something of a plan before starting that work. Cheers, Ben Magistro [1] https://www.wireshark.org/docs/man-pages/dumpcap.html On Tue, Dec 27, 2022 at 11:43 AM Stephen Hemminger < step...@networkplumber.o

[PATCH 1/6] app/dumpcap: add additional dump info

2023-01-02 Thread Ben Magistro
address the issues identified on the mailing list [1]. [1] http://mails.dpdk.org/archives/dev/2022-December/258317.html Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 27 ++- doc/guides/tools/dumpcap.rst | 9 ++--- 2 files changed, 32 insertions(+), 4

[PATCH 2/6] app/dumpcap: fix storing port identifier

2023-01-02 Thread Ben Magistro
occurring on the wrong interface. Fixes: d59fb4d ("app/dumpcap: add new packet capture application") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/dumpcap/main.c b/app/dump

[PATCH 3/6] app/dumpcap: fix preserving promiscuous mode

2023-01-02 Thread Ben Magistro
cleaning up allowing that to be preserved. Fixes: d59fb4d ("app/dumpcap: add new packet capture application") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/a

[PATCH 4/6] app/dumpcap: fix capturing on multiple interfaces

2023-01-02 Thread Ben Magistro
selected, the interface information is included in the capture file. Fixes: 7f3623a ("app/dumpcap: fix select interface") Cc: arshdeep.k...@intel.com Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by: Ben Magistro --- app/dumpcap/m

[PATCH 5/6] app/dumpcap: improve per interface arg parsing

2023-01-02 Thread Ben Magistro
This change improves the argument parsing to align closer to that of Wireshark dumpcap allowing for per interface settings on promiscuous mode and the filter string. Cc: step...@networkplumber.org Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 149

[PATCH 6/6] app/dumpcap: refactor add all and default

2023-01-02 Thread Ben Magistro
This refactors the add all and default interface functions to reduce code duplication. Cc: step...@networkplumber.org Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/app/dumpcap/main.c b/app

Re: RFC abstracting atomics

2023-01-13 Thread Ben Magistro
As a user/developer I'll put a vote on Morten's side here. There are other libraries we utilize that have stated x.y.z is the last version that will support w, beginning on version l.m.n it will be standard o. I personally don't think a project asking for C11 support at a minimum would be unreaso

ICE DDP Load assistance

2023-01-19 Thread Ben Magistro
Hello, We are still trying to track this down but want to reach out to the community and see if there is something obvious we are missing. This happens to be a CentOS 7 based host with DPDK 22.11.1 in use. We have obtained the latest compatible Intel drivers and DDP from https://sourceforge.net/

Re: ICE DDP Load assistance

2023-01-20 Thread Ben Magistro
ode) On Thu, Jan 19, 2023 at 9:14 AM Ben Magistro wrote: > Hello, > > We are still trying to track this down but want to reach out to the > community and see if there is something obvious we are missing. This > happens to be a CentOS 7 based host with DPDK 22.11.1 in use. We h

Sign changes through function signatures

2023-02-02 Thread Ben Magistro
Hello, While making some updates to our code base for 22.11.1 that were missed in our first pass through, we hit the numa node change[1]. In the process of updating our code, we noticed that a couple functions (rx/tx_queue_setup, maybe more that we aren't using) state they accept `SOCKET_ID_ANY`

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-03 Thread Ben Magistro
Since this topic keeps coming up in other threads I'll chime in with my $0.01 here. We've been using CentOS 7 for awhile (and working on migrating off) but have had to leverage devtoolset/llvmtoolset for various reasons. I remember a discussion of installing a different compiler coming up but don'

Re: ICE DDP Load assistance

2023-02-03 Thread Ben Magistro
gt; > So to upgrade DDP package, we need to make sure no active driver is > stilling using the old package, so we may need “rmmod ice” first > > > > Regard > > Qi > > > > *From:* Ben Magistro > *Sent:* Friday, January 20, 2023 11:48 PM > *To:* dev@dpdk.org >

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-03 Thread Ben Magistro
es Cheers On Fri, Feb 3, 2023 at 10:09 AM Bruce Richardson wrote: > On Fri, Feb 03, 2023 at 09:09:14AM -0500, Ben Magistro wrote: > >Since this topic keeps coming up in other threads I'll chime in with > my > >$0.01 here. We've been using CentOS 7 for awhile

Re: [PATCH v3] build: add definitions for use as meson subproject

2022-05-20 Thread Ben Magistro
Currently utilizing this in an upcoming set of changes for TLDK and all seems to be working for fallback dependency support under both shared and static linkage. Reviewed-by: Ben Magistro Tested-by: Ben Magistro On Fri, May 6, 2022 at 10:43 AM Bruce Richardson wrote: > To allow ot

static link + pkg-config assistance

2022-05-20 Thread Ben Magistro
I've been working through some updates to the build system for TLDK and have been working through the different variants (system vs fallback + shared vs static). I've been able to successfully build and run the unit test app for most of these combinations however, I haven't been able to get the sy

Re: static link + pkg-config assistance

2022-05-23 Thread Ben Magistro
3 via pkgconf) gcc: 11.2.0 On Mon, May 23, 2022 at 4:20 AM Bruce Richardson wrote: > On Fri, May 20, 2022 at 10:35:07PM -0400, Ben Magistro wrote: > >I've been working through some updates to the build system for TLDK > and > >have been working through the different

Additional reviewers

2022-05-25 Thread Ben Magistro
Hello, I recently wrapped up the conversion from makefiles to meson on another project and while everything seems functional, if there is anyone that has experience with meson/time/interest, I would appreciate some more eyes on this change. For the change, most things were modeled off of how DPDK

Confirm if rte_ipv4_udptcp_cksum_verify should be experimental

2022-05-26 Thread Ben Magistro
considered experimental and the docs section updated or is this considered a stable function and the signature should updated? Introduced in https://patches.dpdk.org/project/dpdk/patch/20210630135158.8108-4-olivier.m...@6wind.com/ Thanks, Ben Magistro

Re: dumpcap w/ pcapng produces out of order/negative times

2022-06-02 Thread Ben Magistro
AM Stephen Hemminger < step...@networkplumber.org> wrote: > On Thu, 13 Jan 2022 21:38:06 -0500 > Ben Magistro wrote: > > > While utilizing dumpcap with our app, we have observed the captured file > > producing out of order timestamps to include negative times. We are > st

Re: [PATCH v7] net/i40e: add outer VLAN processing

2022-06-10 Thread Ben Magistro
I'm trying to understand if this change is at all related to an issue we are experiencing with newer firmwares ( https://mails.dpdk.org/archives/dev/2022-April/238621.html) that happened to start with 8.4 and affected qinq offload processing. I can say loading this patch and running testpmd does n

Re: [PATCH v7] net/i40e: add outer VLAN processing

2022-06-13 Thread Ben Magistro
the firmware team gave a clear > reply that there are many related bugs in firmware v8.4 and v8.5, and they > were fixed in firmware v8.6. The firmware team recommends using v8.6. > > > > Regards > > Kevin > > > > *From:* Ben Magistro > *Sent:* 2022年6月10日 22:

Re: [RFC] pcapng: record received RSS hash in pcap file

2022-10-25 Thread Ben Magistro
Tested with Wireshark 4.1.0rc0-599-g708da4852678 (and older version to confirm no issues) Tested-by: Ben Magistro On Fri, Oct 21, 2022 at 4:05 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 26 Jul 2022 14:36:19 -0700 > Stephen Hemminger wrote: > > > T

[PATCH] apps/dumpcap: fix interface parameter option

2022-08-21 Thread Ben Magistro
rg Signed-off-by: Ben Magistro --- doc/guides/tools/dumpcap.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/tools/dumpcap.rst b/doc/guides/tools/dumpcap.rst index 6fa284380c..d8a137b1cd 100644 --- a/doc/guides/tools/dumpcap.rst +++ b/doc/guides/tools/d

Re: TCP/IP stack recommendations

2022-09-03 Thread Ben Magistro
I wasn't aware of VPP having a host stack so would certainly be interested to hear more on it. We are doing some work with TLDK (https://wiki.fd.io/view/TLDK) as a userspace stack. The other stacks I am aware (existence only, haven't explored/evaluated) of are ANS (https://github.com/ansyun/dpdk-

Re: [RFT] dumpcap: add file-prefix option

2022-09-16 Thread Ben Magistro
Kaur, I believe parse_opts() should be called before dpdk_init() now see https://patches.dpdk.org/project/dpdk/patch/20220125032545.7704-1-konce...@gmail.com/ On Fri, Sep 16, 2022 at 4:19 AM Kaur, Arshdeep wrote: > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday,

Re: i40e QinQ Offload w/ NVM 8.40 not working

2022-04-07 Thread Ben Magistro
appreciated. Cheers, Ben On Mon, Apr 4, 2022 at 11:36 AM Ben Magistro wrote: > Hello, > > Wanted to follow up with some additional testing results. I believe this > is a bug at the NVM firmware level but still want someone else to confirm. > We can easily retest or change parameter

Re: [PATCH] mbuf: expose outer vlan in mbuf dump

2022-04-12 Thread Ben Magistro
e, Apr 05, 2022 at 05:51:05PM +0200, Thomas Monjalon wrote: > > 04/04/2022 12:33, Kevin Traynor: > > > On 04/04/2022 07:15, Morten Brørup wrote: > > > >> From: Ben Magistro [mailto:konce...@gmail.com] > > > >> Sent: Monday, 4 April 2022 02.57 > &

[dpdk-dev] [PATCH v2] build: add definitions for use as meson subproject

2022-04-18 Thread Ben Magistro
I am currently in the process of trying to embed DPDK into a project utilizing meson's subproject so have some interest in this patch now. To Bruce's question, I believe default_library parameter that would be passed when including the subproject would correctly handle flipping between static and

Re: Sign changes through function signatures

2023-02-06 Thread Ben Magistro
13 > > > > On Fri, Feb 03, 2023 at 12:05:04PM +, Bruce Richardson wrote: > > > On Thu, Feb 02, 2023 at 10:26:48PM +0100, Morten Brørup wrote: > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > Sent: Thursday, 2 February 2

Re: [RFC PATCH 0/1] Specify C-standard requirement for DPDK builds

2023-02-10 Thread Ben Magistro
wrote: > On Fri, Feb 03, 2023 at 11:45:04AM -0500, Ben Magistro wrote: > >In our case we have other libraries that we are using that have > >required us to specify a minimum c++ version (14/17 most recently for > >one) so it doesn't feel like a big ask/is

Re: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Ben Magistro
There is a thread discussing a change to the standard [1] but I have not seen anything explicit yet about moving to C11. I am personally in favor of making the jump to C11 now as part of the 23.x branch and provided my thoughts in the linked thread (what other projects using DPDK have as minimum c

Re: [PATCH] eal: introduce atomics abstraction

2023-02-13 Thread Ben Magistro
On Mon, Feb 13, 2023 at 10:55 AM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Mon, Feb 13, 2023 at 10:28:40AM -0500, Ben Magistro wrote: > >There is a thread discussing a change to the standard [1] but I have > >not seen anything explicit yet about

i40e QinQ Offload w/ NVM 8.40 not working

2022-04-01 Thread Ben Magistro
Hello, We recently needed to apply a firmware upgrade for some XXV710s to resolve a FEC issue (I'd have to find the details in email) but applied this same firmware to other nics (XL710s) to maintain a consistent baseline. In testing we have seen the NVM 8.40 resolve the FEC issue but it introduc

[PATCH] mbuf: expose outer vlan in mbuf dump

2022-04-03 Thread Ben Magistro
Enable printing of the outer vlan if flags indicate it is present. Signed-off-by: Ben Magistro --- While troubleshooting some QinQ offloads with various Intel i40e firmware[1], it was helpful to expose the outer vlan in the dump mbuf calls. This should be straightforward to backport and

Re: i40e QinQ Offload w/ NVM 8.40 not working

2022-04-04 Thread Ben Magistro
4_len=40 - Receive queue=0x0 ol_flags: RTE_MBUF_F_RX_VLAN RTE_MBUF_F_RX_L4_CKSUM_GOOD RTE_MBUF_F_RX_IP_CKSUM_GOOD RTE_MBUF_F_RX_VLAN_STRIPPED RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN Thanks, Ben On Fri, Apr 1, 2022 at 11:13 AM Ben Magistro wrote: > Hello, > > We recently needed

dumpcap w/ pcapng produces out of order/negative times

2022-01-13 Thread Ben Magistro
While utilizing dumpcap with our app, we have observed the captured file producing out of order timestamps to include negative times. We are still investigating the root cause but believe it is in lib/pcapng. While doing some testing of this issue, this behavior was not observed with pcap. In th

[PATCH] app/dumpcap: allow help/version without primary process

2022-01-24 Thread Ben Magistro
Currently dumpcap tries to initialize dpdk before parsing command line arguments, this makes it impossible to check version or help without having the primary process running already. Signed-off-by: Ben Magistro --- app/dumpcap/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v3] net/i40e: fix i40evf device initialization

2021-10-12 Thread Ben Magistro
mode driver") Cc: sta...@dpdk.org Signed-off-by: Ben Magistro --- drivers/net/i40e/i40e_ethdev_vf.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 0cfe13b7b2..ccdce9a16a 100644 --- a/d

Re: [dpdk-dev] [PATCH] driver: i40evf device initialization

2021-10-13 Thread Ben Magistro
the "not applicable" pile still? Thanks and appreciate the advice, Ben Magistro On Mon, Sep 13, 2021 at 10:52 PM Ben Magistro wrote: > +cc: sta...@dpdk.org > > Per discussions here, cc'ing stable for fix to be applied to LTS as > i40evf is being removed from next. > &

[dpdk-dev] Overriding rte_config.h

2021-10-29 Thread Ben Magistro
maintained patch so that we can track custom values easier to the rte_config.h file unless there is another way to pass in an overridden value. As an example, one of the values we are customizing is IP_FRAG_MAX_FRAG. Cheers, Ben Magistro

Re: [dpdk-dev] Overriding rte_config.h

2021-11-03 Thread Ben Magistro
of 1200 (VPN/tunneling). I am not sure this is a value that makes sense for the majority of use cases. On Tue, Nov 2, 2021 at 11:09 AM Ananyev, Konstantin < konstantin.anan...@intel.com> wrote: > > > > > > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wr

[dpdk-dev] [PATCH v4] net/i40e: fix i40evf device initialization

2021-11-08 Thread Ben Magistro
. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Ben Magistro --- drivers/net/i40e/i40e_ethdev_vf.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 625981048a..

Re: [dpdk-dev] [PATCH] driver: i40evf device initialization

2021-09-13 Thread Ben Magistro
, August 30, 2021 5:43 PM > > To: Xueming(Steven) Li ; Kevin Traynor > > ; Ben Magistro ; > > dev@dpdk.org; Beilei Xing ; Luca Boccassi > > ; Christian Ehrhardt > > > > Cc: ben.magis...@trinitycyber.com; stefan.baran...@trinitycyber.com; Qi > > Zhang

[dpdk-dev] [PATCH v2, 20.11] net/i40e: fix i40evf device initialization

2021-09-28 Thread Ben Magistro
The i40evf driver is not initializing the eth_dev attribute which can result in a nullptr dereference. Changes were modeled after the iavf_dev_init() per suggestion from the mailing list[1]. [1] https://mails.dpdk.org/archives/dev/2021-August/217251.html Cc: sta...@dpdk.org Signed-off-by: Ben

[dpdk-dev] [PATCH] driver: i40evf device initialization

2021-08-25 Thread Ben Magistro
The i40evf driver is not initializing the eth_dev attribute which can result in a nullptr dereference. Changes were modeled after the iavf_dev_init() per suggestion from the mailing list[1]. [1] https://mails.dpdk.org/archives/dev/2021-August/217251.html Signed-off-by: Ben Magistro --- drivers

[dpdk-dev] [PATCH] docs: fix bond driver name

2021-08-26 Thread Ben Magistro
The documentation for the bond driver lists the name as `net/bond` however the driver should be `net/bonding`. Signed-off-by: Ben Magistro --- doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide