Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler crypto pmd

2016-12-02 Thread Bruce Richardson
On Fri, Dec 02, 2016 at 03:31:24PM +0100, Thomas Monjalon wrote: > 2016-12-02 14:15, Fan Zhang: > > This patch provides the initial implementation of the scheduler poll mode > > driver using DPDK cryptodev framework. > > > > Scheduler PMD is used to schedule and enqueue the crypto ops to the > >

[dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit

2016-11-30 Thread Bruce Richardson
On Wed, Nov 30, 2016 at 04:31:46PM +0100, Thomas Monjalon wrote: > 2016-11-30 15:26, Bruce Richardson: > > On Wed, Nov 30, 2016 at 04:09:47PM +0100, Thomas Monjalon wrote: > > > 2016-11-30 14:54, Ferruh Yigit: > > > > On 11/21/2016 10:43 PM, Thomas Monjalon wrote: >

[dpdk-dev] [PATCH] scripts: check cc stable mailing list in commit

2016-11-30 Thread Bruce Richardson
On Wed, Nov 30, 2016 at 04:09:47PM +0100, Thomas Monjalon wrote: > 2016-11-30 14:54, Ferruh Yigit: > > On 11/21/2016 10:43 PM, Thomas Monjalon wrote: > > > +stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d' | cut > > > -d' ' -f2) > > > > This breaks the "check-git-log.sh -N"

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-29 Thread Bruce Richardson
On Tue, Nov 29, 2016 at 09:31:42AM +0530, Jerin Jacob wrote: > On Mon, Nov 28, 2016 at 09:16:10AM +0000, Bruce Richardson wrote: > > On Sat, Nov 26, 2016 at 08:24:55AM +0530, Jerin Jacob wrote: > > > On Fri, Nov 25, 2016 at 11:00:53AM +, Bruce Richardson wrote: > >

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-28 Thread Bruce Richardson
On Sat, Nov 26, 2016 at 08:24:55AM +0530, Jerin Jacob wrote: > On Fri, Nov 25, 2016 at 11:00:53AM +0000, Bruce Richardson wrote: > > On Fri, Nov 25, 2016 at 05:53:34AM +0530, Jerin Jacob wrote: > > > On Thu, Nov 24, 2016 at 04:35:56PM +0100, Thomas Monjalon wrote: > > >

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-28 Thread Bruce Richardson
On Sat, Nov 26, 2016 at 06:27:57AM +0530, Jerin Jacob wrote: > On Fri, Nov 25, 2016 at 02:09:22PM +0100, Thomas Monjalon wrote: > > 2016-11-25 11:00, Bruce Richardson: > > > On Fri, Nov 25, 2016 at 05:53:34AM +0530, Jerin Jacob wrote: > > > > On Thu, Nov 24, 20

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-25 Thread Bruce Richardson
On Fri, Nov 25, 2016 at 05:53:34AM +0530, Jerin Jacob wrote: > On Thu, Nov 24, 2016 at 04:35:56PM +0100, Thomas Monjalon wrote: > > 2016-11-24 07:29, Jerin Jacob: > > > On Wed, Nov 23, 2016 at 07:39:09PM +0100, Thomas Monjalon wrote: > > > > 2016-11-18 11:14, Jerin Jacob: > > > > > +Eventdev API -

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-24 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 11:14:59AM +0530, Jerin Jacob wrote: > In a polling model, lcores poll ethdev ports and associated > rx queues directly to look for packet. In an event driven model, > by contrast, lcores call the scheduler that selects packets for > them based on programmer-specified

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-24 Thread Bruce Richardson
On Thu, Nov 24, 2016 at 07:29:13AM +0530, Jerin Jacob wrote: > On Wed, Nov 23, 2016 at 07:39:09PM +0100, Thomas Monjalon wrote: Just some comments on mine triggered by Thomas comments? > > + */ > > > +static inline int > > > +rte_event_enqueue(uint8_t dev_id, uint8_t port_id, struct rte_event

[dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs

2016-11-23 Thread Bruce Richardson
Hi Gage, just FYI, you can make it easier on your readers if you cut off the end of the original email that you are not replying to. It saves us having to scroll down to check for more comments. :-) /Bruce On Tue, Nov 22, 2016 at 03:15:52PM +, Eads, Gage wrote: > > > > -Original

[dpdk-dev] [PATCH v2] i40e: Fix eth_i40e_dev_init sequence on ThunderX

2016-11-22 Thread Bruce Richardson
On Tue, Nov 22, 2016 at 03:46:38AM +0530, Jerin Jacob wrote: > On Sun, Nov 20, 2016 at 11:21:43PM +, Ananyev, Konstantin wrote: > > Hi > > > > > > i40e_asq_send_command: rd32 & wr32 under ThunderX gives unpredictable > > >results. To solve this include rte memory

[dpdk-dev] [PATCH] pmdinfogen: Fix pmdinfogen to select proper endianess on cross-compile

2016-11-21 Thread Bruce Richardson
dian.h), but BSD and Linux put that > header > in different locations so some ifdeffery is required. > > Tested successfully by myself on Linux and BSD systems. > > Signed-off-by: Neil Horman > CC: Hemant Agrawal > CC: Jerin Jacob > CC: Bruce Richardson > CC: Thomas Monj

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-21 Thread Bruce Richardson
On Mon, Nov 21, 2016 at 10:40:50AM +0100, Thomas Monjalon wrote: > 2016-11-19 00:57, Jerin Jacob: > > On Fri, Nov 18, 2016 at 04:04:29PM +0000, Bruce Richardson wrote: > > > On Fri, Nov 18, 2016 at 03:25:18PM +, Bruce Richardson wrote: > > > > On Fri, Nov 18, 2

[dpdk-dev] [RFC PATCH 0/7] RFC: EventDev Software PMD

2016-11-21 Thread Bruce Richardson
On Sat, Nov 19, 2016 at 03:53:25AM +0530, Jerin Jacob wrote: > On Thu, Nov 17, 2016 at 10:05:07AM +0000, Bruce Richardson wrote: > > > 2) device stats API can be based on capability, HW implementations may not > > > support all the stats > > > > Yes, this is

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-18 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 08:50:52AM -0500, Neil Horman wrote: > On Fri, Nov 18, 2016 at 12:03:19PM +, Hemant Agrawal wrote: > > > -Original Message- > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > On Tue, Nov 15, 2016 at 09:34:16AM +, Hemant Agrawal wrote: > > > > >

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-18 Thread Bruce Richardson
+Thomas On Fri, Nov 18, 2016 at 03:25:18PM +, Bruce Richardson wrote: > On Fri, Nov 18, 2016 at 11:14:58AM +0530, Jerin Jacob wrote: > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > > described in [3] (also pasted below), here is the first n

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-18 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 11:14:58AM +0530, Jerin Jacob wrote: > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > described in [3] (also pasted below), here is the first non-draft series > for this new API. > > [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html > [2]

[dpdk-dev] [PATCH v2] i40e: Fix eth_i40e_dev_init sequence on ThunderX

2016-11-18 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 04:52:13AM -0800, Satha Rao wrote: > i40e_asq_send_command: rd32 & wr32 under ThunderX gives unpredictable >results. To solve this include rte memory barriers > > Signed-off-by: Satha Rao > --- > drivers/net/i40e/base/i40e_osdep.h | 14

[dpdk-dev] [RFC PATCH 0/7] RFC: EventDev Software PMD

2016-11-17 Thread Bruce Richardson
On Thu, Nov 17, 2016 at 01:49:25AM +0530, Jerin Jacob wrote: > On Wed, Nov 16, 2016 at 06:00:00PM +, Harry van Haaren wrote: > > This series of RFC patches implements the libeventdev API and a software > > eventdev PMD. > > > > The implementation here is intended to enable the community to

[dpdk-dev] Running 2 process on the same machine

2016-11-14 Thread Bruce Richardson
On Tue, Nov 08, 2016 at 02:02:32PM +0200, Keren Hochman wrote: > Also, I can't understand how to define socket-mem. I did not see anything > related to hugepages in /etc/sysctl.conf. Can i mount hugepages to 2 > different dirs instead and use --huge-dir ? > Thank you. > Doing so would be a

[dpdk-dev] PCAP memory leak in freeing jumbo frames

2016-11-03 Thread Bruce Richardson
On Thu, Nov 03, 2016 at 11:35:14AM +0200, Dror Birkman wrote: > Hi, > > I have a huge memory leak when I release mbufs allocated > by eth_pcap_rx_jumbo(). > > I use rte_mempool_put_bulk() to release the mbufs. > To my horror I found out it puts back to the mempool only the head mbuf and > not

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-11-02 Thread Bruce Richardson
On Wed, Nov 02, 2016 at 06:39:27PM +0530, Jerin Jacob wrote: > On Wed, Nov 02, 2016 at 11:35:51AM +0000, Bruce Richardson wrote: > > On Wed, Nov 02, 2016 at 04:55:22PM +0530, Jerin Jacob wrote: > > > On Fri, Oct 28, 2016 at 02:36:48PM +0530, Jerin Jacob wrote: > > > >

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-11-02 Thread Bruce Richardson
On Wed, Nov 02, 2016 at 01:36:34PM +0530, Jerin Jacob wrote: > On Fri, Oct 28, 2016 at 01:48:57PM +, Van Haaren, Harry wrote: > > > -Original Message- > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > > Sent: Tuesday, October 25, 2016 6:49 PM > > > > > > >

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-11-02 Thread Bruce Richardson
On Wed, Nov 02, 2016 at 04:17:04PM +0530, Jerin Jacob wrote: > On Wed, Oct 26, 2016 at 12:11:03PM +, Van Haaren, Harry wrote: > > > -Original Message- > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > > > > > So far, I have received constructive feedback

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-11-02 Thread Bruce Richardson
On Wed, Nov 02, 2016 at 04:55:22PM +0530, Jerin Jacob wrote: > On Fri, Oct 28, 2016 at 02:36:48PM +0530, Jerin Jacob wrote: > > On Fri, Oct 28, 2016 at 09:36:46AM +0100, Bruce Richardson wrote: > > > On Fri, Oct 28, 2016 at 08:31:41AM +0530, Jerin Jacob wrote: > > > >

[dpdk-dev] [PATCH] app/test: fix a segfault when lpm_perf_autotest is run more than 1 time

2016-11-01 Thread Bruce Richardson
line is needed to identify the commit that introduced the bug. Tested-by: Bruce Richardson

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-28 Thread Bruce Richardson
On Fri, Oct 28, 2016 at 02:48:57PM +0100, Van Haaren, Harry wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > Sent: Tuesday, October 25, 2016 6:49 PM > > > > > Hi Community, > > > > So far, I have received constructive feedback

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-28 Thread Bruce Richardson
On Fri, Oct 28, 2016 at 08:31:41AM +0530, Jerin Jacob wrote: > On Wed, Oct 26, 2016 at 01:54:14PM +0100, Bruce Richardson wrote: > > On Wed, Oct 26, 2016 at 05:54:17PM +0530, Jerin Jacob wrote: > > > On Wed, Oct 26, 2016 at 12:11:03PM +, Van Haaren, Harry wrote: > > >

[dpdk-dev] [PATCH v4 18/32] net/qede: add missing 100G link speed capability

2016-10-26 Thread Bruce Richardson
On Wed, Oct 26, 2016 at 05:41:58PM +0200, Thomas Monjalon wrote: > 2016-10-18 21:11, Rasesh Mody: > > From: Harish Patil > > > > This patch fixes the missing 100G link speed advertisement > > when the 100G support was initially added. > > > > Fixes: 2af14ca79c0a ("net/qede: support 100G") > >

[dpdk-dev] [PATCH v2] net/i40e: fix Rx hang when disable LLDP

2016-10-26 Thread Bruce Richardson
On Wed, Oct 26, 2016 at 04:47:31PM +0100, Wu, Jingjing wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Wednesday, October 26, 2016 11:44 PM > > To: Wu, Jingjing > > Cc: Zhang, Qi Z ; Zhang, Helin > intel.com>; > > dev at dpdk.org > > Subject: Re: [dpdk-dev]

[dpdk-dev] [PATCH v2] net/i40e: fix Rx hang when disable LLDP

2016-10-26 Thread Bruce Richardson
On Wed, Oct 26, 2016 at 03:12:41PM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Thursday, October 20, 2016 4:40 AM > > To: Wu, Jingjing ; Zhang, Helin > > > > Cc: dev at dpdk.org; Zhang, Qi Z > > Subject: [PATCH v2] net/i40e: fix Rx hang when

[dpdk-dev] [PATCH v7] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV

2016-10-26 Thread Bruce Richardson
On Wed, Oct 26, 2016 at 04:28:40PM +0100, Bernard Iremonger wrote: > The folowing changes have been made to allow Data Centre Bridge > (DCB) configuration when SRIOV is enabled. > > Modify ixgbe_check_mq_mode function, > when SRIOV is enabled, enable mq_mode > ETH_MQ_RX_VMDQ_DCB and

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-26 Thread Bruce Richardson
On Wed, Oct 26, 2016 at 05:54:17PM +0530, Jerin Jacob wrote: > On Wed, Oct 26, 2016 at 12:11:03PM +, Van Haaren, Harry wrote: > > > -Original Message- > > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > > > > > So far, I have received constructive feedback

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-26 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 11:19:05PM +0530, Jerin Jacob wrote: > On Wed, Oct 12, 2016 at 01:00:16AM +0530, Jerin Jacob wrote: > > Thanks to Intel and NXP folks for the positive and constructive feedback > > I've received so far. Here is the updated RFC(v2). > > > > I've attempted to address as many

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 02:48:04PM +0100, Declan Doherty wrote: > On 25/10/16 13:57, Bruce Richardson wrote: > > On Mon, Oct 24, 2016 at 04:07:17PM +0100, Declan Doherty wrote: > > > On 24/10/16 15:51, Jan Blunck wrote: > > > > On Mon, Oct 24, 2016 at 7:02 AM,

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-25 Thread Bruce Richardson
On Wed, Oct 19, 2016 at 10:55:25AM +0100, Bruce Richardson wrote: > On Thu, Oct 06, 2016 at 03:32:36PM +0100, Declan Doherty wrote: > > On 07/09/16 13:28, Ilya Maximets wrote: > > > This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. > > > > > > It is

[dpdk-dev] mbuf changes

2016-10-25 Thread Bruce Richardson
yev, > >> Konstantin > >> Sent: Tuesday, October 25, 2016 12:03 PM > >> To: Richardson, Bruce; Morten Br?rup > >> Cc: Wiles, Keith; dev at dpdk.org; Olivier Matz > >> Subject: Re: [dpdk-dev] mbuf changes > >> > >> Hi everyone, > >>

[dpdk-dev] [PATCH v2 1/2] net/i40e: fix link status change interrupt

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 12:19:05PM +0800, Qiming Yang wrote: > Previously, link status interrupt in i40e is achieved by checking > LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only > for diagnostic use. Instead, drivers need to get the link status > change notification by using

[dpdk-dev] mbuf changes

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 02:33:55PM +0200, Morten Br?rup wrote: > Comments at the end. > > Med venlig hilsen / kind regards > - Morten Br?rup > > > -Original Message- > > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > > Sent:

[dpdk-dev] [PATCH v4] net/i40e: fix hash filter invalid issue in X722

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 10:22:09AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Guo, Jia > > Sent: Tuesday, October 25, 2016 10:43 AM > > To: Zhang, Helin ; Wu, Jingjing > intel.com> > > Cc: dev at dpdk.org; Guo, Jia > > Subject: [PATCH v4] net/i40e: fix hash filter

[dpdk-dev] [PATCH v2] net/i40e: fix fdir configure failed issue in X710

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 10:28:22AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: Guo, Jia > > Sent: Tuesday, October 25, 2016 10:26 AM > > To: Zhang, Helin ; Wu, Jingjing > intel.com> > > Cc: dev at dpdk.org; Guo, Jia > > Subject: [PATCH v2] net/i40e: fix fdir

[dpdk-dev] mbuf changes

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 02:16:29PM +0200, Morten Br?rup wrote: > Comments inline. > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, October 25, 2016 1:14 PM > > To: Adrien Mazarguil >

[dpdk-dev] mbuf changes

2016-10-25 Thread Bruce Richardson
On Tue, Oct 25, 2016 at 05:24:28PM +0530, Shreyansh Jain wrote: > On Monday 24 October 2016 09:55 PM, Bruce Richardson wrote: > > On Mon, Oct 24, 2016 at 04:11:33PM +, Wiles, Keith wrote: > > > > > > > On Oct 24, 2016, at 10:49 AM, Morten Br?rup >

[dpdk-dev] mbuf changes

2016-10-25 Thread Bruce Richardson
iginal Message- > > > From: Adrien Mazarguil [mailto:adrien.mazarguil at 6wind.com] > > > Sent: Tuesday, October 25, 2016 11:39 AM > > > To: Bruce Richardson > > > Cc: Wiles, Keith; Morten Br?rup; dev at dpdk.org; Olivier Matz; Oleg > > > Kuporosov > >

[dpdk-dev] mbuf changes

2016-10-25 Thread Bruce Richardson
On Mon, Oct 24, 2016 at 11:47:16PM +0200, Morten Br?rup wrote: > Comments inline. > > Med venlig hilsen / kind regards > - Morten Br?rup > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent:

[dpdk-dev] mbuf changes

2016-10-24 Thread Bruce Richardson
mbuf: Metadata generated by > > the NIC?s RX handler belongs in the first cache line, and metadata required > > by the NIC?s TX handler belongs in the second cache line. This also means > > that touching the second cache line on ingress should be avoided if > > possibl

[dpdk-dev] [PATCH v2 0/2] net/ixgbe: fix VF VLAN insert

2016-10-24 Thread Bruce Richardson
On Thu, Oct 20, 2016 at 12:54:52AM +, Lu, Wenzhuo wrote: > Hi, > > > -Original Message- > > From: Iremonger, Bernard > > Sent: Wednesday, October 19, 2016 10:48 PM > > To: dev at dpdk.org; daniels at research.att.com; Lu, Wenzhuo; az5157 at > > att.com > > Cc: Iremonger, Bernard > >

[dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default

2016-10-24 Thread Bruce Richardson
On Tue, Oct 18, 2016 at 09:11:14PM -0700, Rasesh Mody wrote: > Hi, > > This patch set includes changes to update the base driver, work with > newer FW 8.10.9.0, adds new features, includes enhancements and code > cleanup, provides bug fixes and updates documentation for the QEDE > poll mode

[dpdk-dev] [PATCH v2] net/mlx5: fix init on secondary process

2016-10-24 Thread Bruce Richardson
On Mon, Oct 17, 2016 at 04:18:59PM +0200, Adrien Mazarguil wrote: > On Mon, Oct 17, 2016 at 02:52:39PM +0100, Ferruh Yigit wrote: > > Hi Adrien, > > > > On 10/17/2016 1:56 PM, Olivier Gournet wrote: > > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > > Fixes: 21c8bb4928c9

[dpdk-dev] [PATCH] drivers: make driver names consistent

2016-10-19 Thread Bruce Richardson
On Tue, Oct 18, 2016 at 05:26:22PM +0200, Jan Blunck wrote: > On Tue, Oct 18, 2016 at 3:42 PM, Thomas Monjalon > wrote: > > 2016-10-18 21:06, Yuanhan Liu: > >> On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > >> > >From my understanding this is a massive API breakage. This forces all

[dpdk-dev] [PATCH] net/fm10k: fix SGLORT of VF Tx queues

2016-10-19 Thread Bruce Richardson
On Wed, Oct 19, 2016 at 09:30:14AM +0800, Xiao Wang wrote: > The SGLORT (Source Global Resource Tag) of the VF queues should be > assigned by PF driver, VF driver should not set these registers. > > Fixes: 3b845bf6bcd9 ("fm10k: fix switch manager high CPU usage") > > Signed-off-by: Xiao Wang >

[dpdk-dev] [PATCH] net/mlx5: fix link status report

2016-10-19 Thread Bruce Richardson
On Mon, Oct 17, 2016 at 01:10:48PM +0200, Nelio Laranjeiro wrote: > From: Olga Shern > > This commit fixes link status report on device start up when > lcs callback is configured. > > Fixes: 62072098b54e ("mlx5: support setting link up or down") > > Signed-off-by: Olga Shern > --- Applied to

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-19 Thread Bruce Richardson
On Thu, Oct 06, 2016 at 03:32:36PM +0100, Declan Doherty wrote: > On 07/09/16 13:28, Ilya Maximets wrote: > > This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. > > > > It is necessary to reconfigure all queues every time because configuration > > can be changed. > > > > Hey Ilya,

[dpdk-dev] [PATCH v2 0/3] net: fix out of order Rx read issue

2016-10-19 Thread Bruce Richardson
On Tue, Oct 18, 2016 at 11:33:43AM +, Ananyev, Konstantin wrote: > > > > > > In vPMD, when load Rx desc with _mm_loadu_si128, > > volatile point will be cast into non-volatile point. > > So GCC is allowed to reorder the load instructions, > > while Rx read's correctness is reply on these

[dpdk-dev] [PATCH 1/2] net/enic: fix error in init of RQ when not using Rx scatter

2016-10-19 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 01:11:28PM -0700, John Daley wrote: > From: Nelson Escobar > > The Rx scatter patch was accidentally setting the index of the > secondary receive queue in the primary receive queue's initialization > when the secondary receive queue wasn't needed and was disabled. This >

[dpdk-dev] [PATCH 1/2] net/enic: fix crash on MTU update or rxq reconfigure

2016-10-19 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 02:12:02PM -0700, John Daley wrote: > The incorrect completion queue corresponding to an RQ would be > freed if multiple Rx queues are in use and the MTU is changed, > or an Rx queue is released. This could lead to a segmentation fault > when the device is disabled or even

[dpdk-dev] [PATCH] net/enic: fix poor multi-queue Rx performance

2016-10-19 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 02:22:29PM -0700, John Daley wrote: > The rx_free_thresh was not being initialized and left at 0 > on 1/2 of the RQs which could lead to poor multi-queue > performanace. > > Fixes: 856d7ba7ed22 ("net/enic: support scattered Rx") > > Signed-off-by: John Daley >

[dpdk-dev] [PATCH] net/enic: fix fdir UDP v4 source port mask

2016-10-19 Thread Bruce Richardson
On Mon, Oct 17, 2016 at 10:17:08PM -0700, John Daley wrote: > This fixes issue found by Coverity where a typo caused the flow director > UDP IPv4 source port mask to be assigned the destination port mask > supplied by the caller. > > Coverity issue: 137860 > > Fixes: dfbd6a9cb504 ("net/enic:

[dpdk-dev] [PATCH v3 0/3] fix flow director mask issues

2016-10-19 Thread Bruce Richardson
On Wed, Oct 19, 2016 at 09:22:57AM +0800, Wenzhuo Lu wrote: > There're 2 issues about flow director mask. > 1, MAC address mask is not supported in mac-vlan mode. > 2, All the parameter are defined as big endian, but >they're not treated approriately. > This patch set is used to fix these 2

[dpdk-dev] [PATCH v2] net/mlx5: fix init on secondary process

2016-10-19 Thread Bruce Richardson
On Mon, Oct 17, 2016 at 04:18:59PM +0200, Adrien Mazarguil wrote: > On Mon, Oct 17, 2016 at 02:52:39PM +0100, Ferruh Yigit wrote: > > Hi Adrien, > > > > On 10/17/2016 1:56 PM, Olivier Gournet wrote: > > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > > Fixes: 21c8bb4928c9

[dpdk-dev] [PATCH] net/mlx5: fix hash key size retrieval

2016-10-19 Thread Bruce Richardson
On Fri, Oct 14, 2016 at 10:20:32AM +0200, Adrien Mazarguil wrote: > On Fri, Oct 14, 2016 at 09:30:14AM +0200, Nelio Laranjeiro wrote: > > Return RSS key size in struct rte_eth_dev_info. > > > > Fixes: 0f6f219e7919 ("app/testpmd: fix RSS hash key size") > > > > Signed-off-by: Nelio Laranjeiro >

[dpdk-dev] [PATCH] net/bnx2x: fix icc build error

2016-10-19 Thread Bruce Richardson
On Mon, Oct 17, 2016 at 06:04:32PM +, Mody, Rasesh wrote: > > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > > Sent: Monday, October 17, 2016 5:12 AM > > > > On 9/30/2016 3:45 PM, Ferruh Yigit wrote: > > > When bnx2x debug config enabled, icc (ICC) 17.0.0 20160721 gives the > > >

[dpdk-dev] [PATCH v2 0/5] i40e: vector poll-mode driver on ARM64

2016-10-19 Thread Bruce Richardson
On Mon, Oct 17, 2016 at 03:44:34PM +0100, Bruce Richardson wrote: > On Fri, Oct 14, 2016 at 09:29:59AM +0530, Jianbo Liu wrote: > > This patch set is to implement i40e vector PMD on ARM64. > > For x86, vPMD is only reorganized, there should be no performance loss. > > >

[dpdk-dev] [PATCH v2 0/5] i40e: vector poll-mode driver on ARM64

2016-10-17 Thread Bruce Richardson
e ARM code, I have run a very quick sanity check on an IA platform and saw no performance regression there. Acked-by: Bruce Richardson

[dpdk-dev] [RFC] [PATCH v2] libeventdev: event driven programming model framework for DPDK

2016-10-14 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 01:00:16AM +0530, Jerin Jacob wrote: > Thanks to Intel and NXP folks for the positive and constructive feedback > I've received so far. Here is the updated RFC(v2). > > I've attempted to address as many comments as possible. > > This series adds rte_eventdev.h to the DPDK

[dpdk-dev] [PATCH v9 0/2] add API's for VF management

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 06:54:10PM +0100, Bernard Iremonger wrote: > This patchset contains new DPDK API's for use > with the Virtual Function Daemon (VFD). > > The need to configure and manage VF's on a NIC has grown to the > point where a DPDK based tool, VFD, has been developed to do this. >

[dpdk-dev] [PATCH] net/ring: fix param string info

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 11:22:25AM +0100, Bruce Richardson wrote: > On Wed, Aug 31, 2016 at 05:53:51PM +0100, Ferruh Yigit wrote: > > Fixes: 65eca099f405 ("drivers: split parameters infos in multiple lines") > > > > Signed-off-by: Ferruh Yigit > > ---

[dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 11:21:57AM +0100, Bruce Richardson wrote: > On Wed, Aug 31, 2016 at 05:51:11PM +0100, Ferruh Yigit wrote: > > Using nodeaction devarg lets creating multiple ring eth devices: > > "eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE" > > &

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-13 Thread Bruce Richardson
On Thu, Oct 13, 2016 at 02:22:16PM +0100, Bruce Richardson wrote: > On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for

[dpdk-dev] [PATCH] net/enic: remove assert which causes compile error

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 11:09:35AM -0700, John Daley wrote: > Remove an RTE_ASSERT which will not compile if enabled and is not needed. > > Fixes: a1f7c7b3b5b2 ("net/enic: extend fdir support for 1300 series adapters") > > Signed-off-by: John Daley > --- > Would have been nice if I caught this

[dpdk-dev] [PATCH] net/ring: fix param string info

2016-10-13 Thread Bruce Richardson
On Wed, Aug 31, 2016 at 05:53:51PM +0100, Ferruh Yigit wrote: > Fixes: 65eca099f405 ("drivers: split parameters infos in multiple lines") > > Signed-off-by: Ferruh Yigit > --- Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs

2016-10-13 Thread Bruce Richardson
nodeaction devarg is name (in above sample R0,R1), this name field > can be used as eth dev name. > > Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix > linking") > > Signed-off-by: Ferruh Yigit > --- Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] net/i40e: add additional prefetch instructions for bulk rx

2016-10-13 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 12:04:39AM +, Ananyev, Konstantin wrote: > Hi Vladislav, > > > > > > > > > > > > > On 7/14/2016 6:27 PM, Vladyslav Buslov wrote: > > > > > > > Added prefetch of first packet payload cacheline in > > > > > > > i40e_rx_scan_hw_ring Added prefetch of second mbuf cacheline

[dpdk-dev] [PATCH 0/4] bnxt patch series

2016-10-13 Thread Bruce Richardson
On Thu, Sep 29, 2016 at 06:32:59PM +0100, Ferruh Yigit wrote: > On 9/29/2016 6:03 PM, Ajit Khaparde wrote: > > Please consider applying this patch series. > > This series is expected to be applied over the previous patchset > > once it is accepted. > > Depends on: [v2,15/15] bnxt: Update struct

[dpdk-dev] [PATCH v3 01/10] net/bnx2x: set cache line based on build configuration

2016-10-13 Thread Bruce Richardson
On Tue, Oct 11, 2016 at 07:04:52PM -0400, Chas Williams wrote: > Correctly hint the cache line size. Remove unused macros associated > with the cache line size. > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Chas Williams <3chas3 at gmail.com> > Acked-by: Harish Patil

[dpdk-dev] [PATCH] net/mlx5: fix Rx function selection

2016-10-13 Thread Bruce Richardson
On Tue, Oct 11, 2016 at 05:01:36PM +0200, Adrien Mazarguil wrote: > On Tue, Oct 11, 2016 at 04:44:50PM +0200, Nelio Laranjeiro wrote: > > mlx5_rx_queue_setup() was setting the Rx function by itself instead of > > using priv_select_rx_function() written for that purpose. > > > > Fixes:

[dpdk-dev] [PATCH] net/enic: add Ethernet VLAN ptype

2016-10-13 Thread Bruce Richardson
On Wed, Aug 24, 2016 at 12:07:02PM -0700, John Daley wrote: > Enic is capable of recognizing packets to be delivered to the > app with single VLAN tags. Advertise this with the ptype > RTE_PTYPE_L2_ETHER_VLAN and set the ptype for VLAN packets. > > Signed-off-by: John Daley > --- Applied to

[dpdk-dev] [PATCH] doc: add ixgbe supported chipsets and NICs

2016-10-13 Thread Bruce Richardson
On Mon, Sep 26, 2016 at 10:11:39AM +, Mcnamara, John wrote: > > -Original Message- > > From: Dai, Wei > > Sent: Monday, September 26, 2016 2:24 AM > > To: dev at dpdk.org; thomas.monjalon at 6wind.com; Butler, Siobhan A > > ; Mcnamara, John > intel.com>; > > Zhang, Helin ; Ananyev,

[dpdk-dev] [PATCH v2 0/4] random fixes for bugs identified by Coverity

2016-10-13 Thread Bruce Richardson
On Thu, Sep 29, 2016 at 01:39:32PM -0400, John W. Linville wrote: > Today I attempted to exercise my brain between meetings by handling > a few bugs identified by Coverity. > > All of the fixes are simple and (hopefully) obvious. They are > compile-tested only. > > v2: fix-up changelog entries

[dpdk-dev] [PATCH 1/2] bnx2x: fix maximum PF queues

2016-10-12 Thread Bruce Richardson
On Wed, Oct 05, 2016 at 10:36:36PM -0700, Rasesh Mody wrote: > Fix the max number of PF rx/tx queues. Set the value based > on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128. > > Fixes: 540a211 ("bnx2x: driver core") > > Signed-off-by: Rasesh Mody > --- Series applied to

[dpdk-dev] [PATCH 4/4] net/enic: extend fdir support for 1300 series adapters

2016-10-12 Thread Bruce Richardson
On Tue, Oct 11, 2016 at 09:25:45AM +, John Daley (johndale) wrote: > > > > -Original Message- > > From: Ferruh Yigit [mailto:ferruh.yigit at intel.com] > > Sent: Tuesday, October 11, 2016 2:22 AM > > To: John Daley (johndale) ; > > bruce.richardson at intel.com > > Cc: dev at

[dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf

2016-10-12 Thread Bruce Richardson
On Mon, Oct 10, 2016 at 03:16:09PM +0100, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley > > Sent: Thursday, September 29, 2016 9:55 PM > > To: Richardson, Bruce > > Cc: dev at dpdk.org; Nelson Escobar > > Subject:

[dpdk-dev] [PATCH] net/mlx: align drivers to latest naming convention

2016-10-12 Thread Bruce Richardson
On Fri, Oct 07, 2016 at 03:24:27PM +0200, Adrien Mazarguil wrote: > On Fri, Oct 07, 2016 at 03:04:13PM +0200, David Marchand wrote: > > Fixes: 2f45703c17ac ("drivers: make driver names consistent") > > > > Signed-off-by: David Marchand > Acked-by: Adrien Mazarguil > Applied to

[dpdk-dev] [PATCH v2 00/15] Add support for secondary queue set in nicvf thunderx driver

2016-10-12 Thread Bruce Richardson
On Fri, Sep 30, 2016 at 02:05:39PM +0200, Kamil Rytarowski wrote: > This series of patches adds support for secondary queue set in nicvf thunderx > driver > > There are two types of VFs: > - Primary VF > - Secondary VF > > Each port consist of a primary VF and n secondary VF(s). Each VF

[dpdk-dev] [PATCH v4 1/2] i40e: Add packet_type metadata in the i40e vPMD

2016-10-12 Thread Bruce Richardson
On Thu, Oct 06, 2016 at 03:28:39PM +, Chen, Jing D wrote: > > > -Original Message- > > From: Shaw, Jeffrey B > > Sent: Wednesday, October 5, 2016 11:38 PM > > To: dev at dpdk.org > > Cc: Zhang, Helin ; Wu, Jingjing > > ; damarion at cisco.com; Zhang, Qi Z > > ; Chen, Jing D > >

[dpdk-dev] [PATCH 1/2] net/bonding: validate speed after link up

2016-10-12 Thread Bruce Richardson
On Wed, Oct 05, 2016 at 12:53:00PM +, Iremonger, Bernard wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eric Kinzie > > Sent: Thursday, August 4, 2016 7:25 PM > > To: dev at dpdk.org > > Cc: Jan Blunck > > Subject: [dpdk-dev] [PATCH 1/2]

[dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues"

2016-10-12 Thread Bruce Richardson
On Wed, Oct 12, 2016 at 04:24:54PM +0300, Ilya Maximets wrote: > On 07.10.2016 05:02, Eric Kinzie wrote: > > On Wed Sep 07 15:28:10 +0300 2016, Ilya Maximets wrote: > >> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. > >> > >> It is necessary to reconfigure all queues every time

[dpdk-dev] [PATCH v3] doc: add limitations for i40e PMD

2016-10-12 Thread Bruce Richardson
On Fri, Sep 30, 2016 at 03:09:53PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: Wu, Jingjing > > Sent: Friday, September 30, 2016 7:46 AM > > To: dev at dpdk.org > > Cc: Wu, Jingjing ; Xing, Beilei > > ; Mcnamara, John > > Subject: [PATCH v3] doc: add limitations

[dpdk-dev] [PATCH v4] net/mlx5: return RSS hash result in mbuf

2016-10-12 Thread Bruce Richardson
On Wed, Sep 28, 2016 at 02:11:18PM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- Applied to dpdk-next-net/rel_16_11 /Bruce

[dpdk-dev] [PATCH v4 0/4] Cuckoo hash enhancements

2016-10-04 Thread Bruce Richardson
> > Firstly, checkpatches is reporting some style errors in these patches. > > > > > > Secondly, when I run the "hash_multiwriter_autotest" I get what I assume > > to > > > be > > > an error after applying this patchset. Before this set is applied, running > > > that test shows the cycles per insert with/without lock elision. Now, > > > though > > > I'm getting an error about a key being dropped or failing to insert in > > > the lock > > > elision case, e.g. > > > > > > Core #2 inserting 1572864: 0 - 1,572,864 > > > key 1497087 is lost > > > 1 key lost > > > > > > I've run the test a number of times, and there is a single key lost each > > > time. > > > Please check on this, is it expected or is it a problem? > > > > I am seeing that error even without the patchset. I am still investigating > > it, > > but using "git bisect" looks like the problem is in commit 5fc74c2e146d > > ("hash: check if slot is empty with key index"). > > I found the problem, and I submitted a patch for it > (http://dpdk.org/dev/patchwork/patch/16361/). > Could you check if it works for you? > That patch looks like a correct bugfix so I've acked it for you. However, I still see the error appearing very occasionally. Since it also appeared before I applied this set, I am ok to accept this set anyway. Please do a new version of the set with checkpatch issues fixed and keep my ack. Series Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] hash: fix incorrect free slot check

2016-10-04 Thread Bruce Richardson
eck if slot is empty with key index") > > Reported-by: Bruce Richardson > Signed-off-by: Pablo de Lara Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v4 0/4] Cuckoo hash enhancements

2016-10-03 Thread Bruce Richardson
On Fri, Sep 30, 2016 at 08:38:52AM +0100, Pablo de Lara wrote: > This patchset improves lookup performance on the current hash library > by changing the existing lookup bulk pipeline, with an improved pipeline, > based on a loop-and-jump model, instead of the current 4-stage 2-entry > pipeline. >

[dpdk-dev] [PATCH] net/kni: add KNI PMD

2016-09-08 Thread Bruce Richardson
On Thu, Sep 08, 2016 at 09:44:55AM +0200, Thomas Monjalon wrote: > 2016-09-06 11:33, Ferruh Yigit: > > Add KNI PMD which wraps librte_kni for ease of use. > > > > KNI PMD can be used as any regular PMD to send / receive packets to the > > Linux networking stack. > > Good move! > Why not

[dpdk-dev] [PATCH v6 1/9] lpm: add altivec intrinsics for dpdk lpm on ppc_64

2016-09-07 Thread Bruce Richardson
64 systems, and patch looks ok to me, so Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v3] eal: restrict cores detection

2016-09-02 Thread Bruce Richardson
On Thu, Sep 01, 2016 at 01:31:47AM +, Jianfeng Tan wrote: > This patch uses pthread_getaffinity_np() to narrow down detected > cores before parsing coremask (-c), corelist (-l), and coremap > (--lcores). > > The purpose of this patch is to leave out these core related options > when DPDK

[dpdk-dev] [RFC] libeventdev: event driven programming model framework for DPDK

2016-08-09 Thread Bruce Richardson
On Tue, Aug 09, 2016 at 06:31:41AM +0530, Jerin Jacob wrote: > Hi All, > > Find below an RFC API specification which attempts to > define the standard application programming interface > for event driven programming in DPDK and to abstract HW based event devices. > > These devices can support

[dpdk-dev] [PATCH] mk:fix second compile error

2016-08-09 Thread Bruce Richardson
On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote: > when compile different targets on a same environment. > The second compile will failed, because test_resource obj file > can't auto clearn by makfile. > > Signed-off-by: xu,huilong > --- > mk/rte.app.mk | 3 ++- > 1 file changed, 2

[dpdk-dev] rte_eth_dev_attach returns 0, although device is not attached

2016-08-05 Thread Bruce Richardson
On Thu, Aug 04, 2016 at 04:47:25PM +0100, Ferruh Yigit wrote: > On 8/4/2016 3:54 PM, Igor Ryzhov wrote: > > > >> 4 ???. 2016 ?., ? 16:21, Ferruh Yigit >> > ???(?): > >> > >> On 8/4/2016 12:51 PM, Igor Ryzhov wrote: > >>> Hello Ferruh, > >>> > 4 ???.

[dpdk-dev] [PATCH v3] doc: autogenerate nic overview table from ini files

2016-08-03 Thread Bruce Richardson
On Mon, Aug 01, 2016 at 11:37:03PM +0200, Thomas Monjalon wrote: > Hi John, > > 2016-07-29 12:59, John McNamara: > > Convert the NIC feature table in the overview doc into a set of ini > > files and add functions into the Sphinx conf.py file to auto-generate > > them back into an RST table. > >

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Bruce Richardson
a tie breaker so I can submit a v2 > without RFC then? > > P.S. I understand there was no objection on changing the file mode - which > might be quite unobvious in the diff? > Definitely no objection on the file mode change. For the dropping of the .sh extension, I don't think it matters much. However, given that .sh files are generally scripts to be executed, I think dropping the extension will reduce confusion. Acked-by: Bruce Richardson

  1   2   3   4   5   6   7   8   9   10   >