[PATCH v2] dma/ioat: remove printf within ioat driver

2023-02-07 Thread Conor Walsh
rte_log should be used instead of printf within the drivers. This patch changes a printf within the ioat dma driver's start function to an rte log. The printfs within ioat's dump function will be retained Signed-off-by: Conor Walsh Acked-by: Bruce Richardson --- v2: fix whites

[PATCH] dma/ioat: remove printf within ioat driver

2023-02-03 Thread Conor Walsh
rte_log should be used instead of printf within the drivers this patch changes a printf within the ioat dma driver's start function to an rte log. The printfs within ioat's dump function will be retained. Signed-off-by: Conor Walsh --- drivers/dma/ioat/ioat_dmadev.c | 6 +++--- 1 fi

[PATCH] fix: rename dpdk-ioat to dpdk-dma in example

2022-10-12 Thread Conor Walsh
When the dpdk-ioat app was renamed to dpdk-dma this example command was missed, this patch corrects that issue. Fixes: bb4141dbe5da ("examples/dma: rename ioat application example") Signed-off-by: Conor Walsh --- doc/guides/sample_app_ug/dma.rst | 2 +- 1 file changed, 1 inser

[PATCH v2 2/2] usertools/telemetry: add new telemetry client

2022-08-31 Thread Conor Walsh
/tui3.png Signed-off-by: Conor Walsh --- v2: - Update rich version to 12.5.1 (latest). - Update plotext version to 5.0.2 (latest). - Call out specific version numbers in error messages to avoid possible future incompatibility. --- usertools/dpdk-telemetry-tui.py

[PATCH v2 1/2] usertools/telemetry: move main to function

2022-08-31 Thread Conor Walsh
uplication. Signed-off-by: Conor Walsh --- usertools/dpdk-telemetry.py | 43 + 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py index a81868a547..2c85fd95b4 100755 --- a/usertools/dpdk-telemetr

[PATCH 2/2] usertools/telemetry: add new telemetry client

2022-08-24 Thread Conor Walsh
/tui2.png Signed-off-by: Conor Walsh --- usertools/dpdk-telemetry-tui.py | 691 1 file changed, 691 insertions(+) create mode 100755 usertools/dpdk-telemetry-tui.py diff --git a/usertools/dpdk-telemetry-tui.py b/usertools/dpdk-telemetry-tui.py new file mode 1

[PATCH 1/2] usertools/telemetry: move main to function

2022-08-24 Thread Conor Walsh
uplication. Signed-off-by: Conor Walsh --- usertools/dpdk-telemetry.py | 43 + 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py index a81868a547..2c85fd95b4 100755 --- a/usertools/dpdk-telemetr

[PATCH 6/6] examples/performance-thread: fix unused but set variables

2021-11-15 Thread Conor Walsh
g Longfeng Signed-off-by: Conor Walsh --- examples/performance-thread/l3fwd-thread/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 3a6a33bda3..8a35040597 100644 --- a/examples/performa

[PATCH 5/6] drivers/net: fix unused but set variables

2021-11-15 Thread Conor Walsh
buffers") Fixes: 86a2265e59d7 ("qede: add SRIOV support") Fixes: b7311360fb67 ("net/txgbe: support VF interrupt") Fixes: c3ecdbb376da ("vmxnet3: support TSO") Cc: sta...@dpdk.org Reported-by: Liang Longfeng Signed-off-by: Conor Walsh --- drivers/net/bnxt/bnxt_r

[PATCH 3/6] drivers/common/qat: fix unused but set variables

2021-11-15 Thread Conor Walsh
Signed-off-by: Conor Walsh --- drivers/common/qat/qat_pf2vf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/common/qat/qat_pf2vf.c b/drivers/common/qat/qat_pf2vf.c index 6327311199..4e9ffc72fc 100644 --- a/drivers/common/qat/qat_pf2vf.c +++ b/drivers/common/qat/qat_pf2vf.c @@ -54

[PATCH 4/6] drivers/event/sw: fix unused but set variables

2021-11-15 Thread Conor Walsh
g Longfeng Signed-off-by: Conor Walsh Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index 070a4802e9..fa72ceb949 100644 --- a/drivers/event/sw/sw_evdev.c +++ b/drivers/event/sw/

[PATCH 2/6] drivers/bus/fslmc: fix unused but set variables

2021-11-15 Thread Conor Walsh
ned-off-by: Conor Walsh --- drivers/bus/fslmc/fslmc_bus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c index ac3cb4aa5a..a0ef24cdc8 100644 --- a/drivers/bus/fslmc/fslmc_bus.c +++ b/drivers/bus/fslmc/fslmc_bus.c @@ -315,7 +315,6 @@

[PATCH 1/6] app/test: fix unused but set variables

2021-11-15 Thread Conor Walsh
Cc: sta...@dpdk.org Reported-by: Liang Longfeng Signed-off-by: Conor Walsh Acked-by: Vladimir Medvedkin --- app/test/test_distributor_perf.c | 3 --- app/test/test_thash_perf.c | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test/test_distribut

[PATCH 0/6] fix unused but set variables

2021-11-15 Thread Conor Walsh
to vmxnet3 to ensure vmxnet_unmap_pkt is run. - Minor changes to commit logs. - Dropped all addresses from CC that bounced back. Conor Walsh (6): app/test: fix unused but set variables drivers/bus/fslmc: fix unused but set variables drivers/common/qat: fix unused but set variables driver

[PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Conor Walsh
to separate file") Fixes: 9eb5cb3b11cc ("net/octeontx: fix access to indirect buffers") Fixes: 86a2265e59d7 ("qede: add SRIOV support") Fixes: b7311360fb67 ("net/txgbe: support VF interrupt") Fixes: c3ecdbb376da ("vmxnet3: support TSO") Signed-off-by: C

[PATCH 7/7] lib/power: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the tot_ppi variable from the update_stats function within empty poll in the power library as it is an unused but set variable. Bugzilla ID: 881 Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Conor Walsh Reported-by: Lian

[PATCH 6/7] examples/performance-thread: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the hits variable from the cpu_load_collector function within the performance thread example app as it is an unused but set variable. Bugzilla ID: 881 Fixes: d48415e1fee3 ("examples/performance-thread: add l3fwd-thread app") Signed-off-by: Conor Walsh Reported

[PATCH 4/7] drivers/event/sw: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the inflights variable from the sw_dump function within the software section of the event driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging") Signed-off-by: Conor Walsh Reported

[PATCH 2/7] drivers/bus/fslmc: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the device_count variable from the rte_fslmc_scan function within the fslmc bus driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") Signed-off-by: Conor Walsh Reported-by: Lian

[PATCH 0/7] fix unused but set variables

2021-11-12 Thread Conor Walsh
split this patchset into 7 patches grouped broadly by subdir, as this set touches code from a lot of different authors I thought it would make it easier to review. Bugzilla ID: 881 Conor Walsh (7): app/test: fix unused but set variables drivers/bus/fslmc: fix unused but set variables drivers

[PATCH 3/7] drivers/common/qat: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch removes the us variable from the qat_pf2vf_exch_msg function within the PF to VF section of the QAT driver as it is an unused but set variable. Bugzilla ID: 881 Fixes: b17d16fb47b4 ("common/qat: add PF to VF communication") Signed-off-by: Conor Walsh Reported-by: Lian

[PATCH 1/7] app/test: fix unused but set variables

2021-11-12 Thread Conor Walsh
This patch fixes unused but set variables within the following test apps: - test distributor perf - test thash perf Bugzilla ID: 881 Fixes: c0de0eb82e40 ("distributor: switch over to new API") Fixes: 239fffe0402e ("test/thash: add performance tests for Toeplitz hash")

[dpdk-dev] [PATCH v8 12/12] raw/ioat: deprecate ioat rawdev driver

2021-10-18 Thread Conor Walsh
Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have moved to dmadev. Signed-off-by: Conor Walsh Acked-by: Kevin Laatz Acked-by: Bruce Richardson Acked-by: Thomas Monjalon --- MAINTAINERS | 2 +- doc/guides/rawdevs/ioat.rst | 4 doc

[dpdk-dev] [PATCH v8 11/12] devbind: move ioat device IDs to dmadev category

2021-10-18 Thread Conor Walsh
Move Intel IOAT devices from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Bruce Richardson --- usertools/dpdk-devbind.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v8 10/12] dma/ioat: add burst capacity function

2021-10-18 Thread Conor Walsh
Adds the ability to find the remaining space in the IOAT ring. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v8 09/12] dma/ioat: add support for vchan status function

2021-10-18 Thread Conor Walsh
Add support for the rte_dmadev_vchan_status API call. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat

[dpdk-dev] [PATCH v8 08/12] dma/ioat: add statistics

2021-10-18 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v8 07/12] dma/ioat: add data path completion functions

2021-10-18 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- doc/guides/dmadevs/ioat.rst| 33 +++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files

[dpdk-dev] [PATCH v8 06/12] dma/ioat: add data path job submission functions

2021-10-18 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- doc/guides/dmadevs/ioat.rst| 9 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed

[dpdk-dev] [PATCH v8 05/12] dma/ioat: add start and stop functions

2021-10-18 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 95 insertions

[dpdk-dev] [PATCH v8 04/12] dma/ioat: add configuration functions

2021-10-18 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc

[dpdk-dev] [PATCH v8 03/12] dma/ioat: add datapath structures

2021-10-18 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 70 ++- drivers/dma/ioat/ioat_hw_defs.h | 215 2 files changed

[dpdk-dev] [PATCH v8 02/12] dma/ioat: create dmadev instances on PCI probe

2021-10-18 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 105

[dpdk-dev] [PATCH v8 01/12] dma/ioat: add device probe and removal functions

2021-10-18 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- MAINTAINERS| 6 +++ doc/guides

[dpdk-dev] [PATCH v8 00/12] dma: add dmadev driver for ioat devices

2021-10-18 Thread Conor Walsh
o update from dmadev v19 to v21. v2: - Rebased on the above patchsets. Conor Walsh (12): dma/ioat: add device probe and removal functions dma/ioat: create dmadev instances on PCI probe dma/ioat: add datapath structures dma/ioat: add configuration functions dma/ioat: add start and stop fu

[dpdk-dev] [PATCH] usertools/telemetry: fix instance help text

2021-10-18 Thread Conor Walsh
The instance option help text was incorrect, this patch corrects it. Fixes: 11435aae2089 ("usertools/telemetry: connect to separate instances") Signed-off-by: Conor Walsh --- usertools/dpdk-telemetry.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/user

[dpdk-dev] [PATCH v3] usertools/telemetry: add list of available file-prefixes

2021-10-18 Thread Conor Walsh
This patch adds the option --list (-l) to dpdk-telemetry.py which will print all of the available dpdk file-prefixes that have telemetry enabled. The prefixes will also be printed if the user passes an incorrect prefix in the --file-prefix (-f) option. Signed-off-by: Conor Walsh Acked-by: Ciara

[dpdk-dev] [PATCH v7 12/12] raw/ioat: deprecate ioat rawdev driver

2021-10-14 Thread Conor Walsh
Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have moved to dmadev. Signed-off-by: Conor Walsh Acked-by: Kevin Laatz Acked-by: Bruce Richardson --- MAINTAINERS | 2 +- doc/guides/rawdevs/ioat.rst | 4 doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH v7 11/12] devbind: move ioat device IDs to dmadev category

2021-10-14 Thread Conor Walsh
Move Intel IOAT devices from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Bruce Richardson --- usertools/dpdk-devbind.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v7 10/12] dma/ioat: add burst capacity function

2021-10-14 Thread Conor Walsh
Adds the ability to find the remaining space in the IOAT ring. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ioat

[dpdk-dev] [PATCH v7 09/12] dma/ioat: add support for vchan status function

2021-10-14 Thread Conor Walsh
Add support for the rte_dmadev_vchan_status API call. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat

[dpdk-dev] [PATCH v7 08/12] dma/ioat: add statistics

2021-10-14 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v7 07/12] dma/ioat: add data path completion functions

2021-10-14 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- doc/guides/dmadevs/ioat.rst| 33 +++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files

[dpdk-dev] [PATCH v7 06/12] dma/ioat: add data path job submission functions

2021-10-14 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- doc/guides/dmadevs/ioat.rst| 9 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed

[dpdk-dev] [PATCH v7 05/12] dma/ioat: add start and stop functions

2021-10-14 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 95 insertions

[dpdk-dev] [PATCH v7 04/12] dma/ioat: add configuration functions

2021-10-14 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc

[dpdk-dev] [PATCH v7 03/12] dma/ioat: add datapath structures

2021-10-14 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 70 ++- drivers/dma/ioat/ioat_hw_defs.h | 215 2 files changed

[dpdk-dev] [PATCH v7 02/12] dma/ioat: create dmadev instances on PCI probe

2021-10-14 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 105

[dpdk-dev] [PATCH v7 01/12] dma/ioat: add device probe and removal functions

2021-10-14 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- MAINTAINERS| 6 +++ doc/guides

[dpdk-dev] [PATCH v7 00/12] dma: add dmadev driver for ioat devices

2021-10-14 Thread Conor Walsh
ity function. - Stop function now waits for suspend rather than just using a sleep. - Changed from vchan idle to vchan status function. - Other minor changes to update from dmadev v19 to v21. v2: - Rebased on the above patchsets. Conor Walsh (12): dma/ioat: add device probe and removal functions

[dpdk-dev] [PATCH v2] usertools/telemetry: add list of available file-prefixes

2021-10-11 Thread Conor Walsh
metry support with in-memory mode") Signed-off-by: Conor Walsh Acked-by: Ciara Power --- usertools/dpdk-telemetry.py | 40 + 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py index

Re: [dpdk-dev] [PATCH v6 4/5] usertools/dpdk-telemetry: connect to in-memory processes

2021-10-05 Thread Conor Walsh
On 05/10/2021 14:59, Bruce Richardson wrote: Allow connecting to an in-memory process via "-p " flag, which can be used to identify the in-memory process to which to connect. Signed-off-by: Bruce Richardson --- Tested-by: Conor Walsh

Re: [dpdk-dev] [PATCH v6 5/5] usertools/dpdk-telemetry: provide info on available sockets

2021-10-05 Thread Conor Walsh
#x27; Signed-off-by: Bruce Richardson --- Tested-by: Conor Walsh

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-05 Thread Conor Walsh
s with the existing telemetry socket files, these sockets are removed on normal program exit. Signed-off-by: Bruce Richardson --- Legacy telemetry does not prevent multiple v2 sockets anymore. Thanks, Conor. Tested-by: Conor Walsh

Re: [dpdk-dev] [PATCH v6 2/5] telemetry: fix deletion of active sockets

2021-10-05 Thread Conor Walsh
ave a different runtime dir (and therefore socket path) or by disabling telemetry if it not needed. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Reported-by: David Marchand Signed-off-by: Bruce Richardson Acked-by: Ciara Power --- Tested-by: Conor Walsh

[dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes

2021-10-05 Thread Conor Walsh
metry support with in-memory mode") Signed-off-by: Conor Walsh --- usertools/dpdk-telemetry.py | 40 + 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/usertools/dpdk-telemetry.py b/usertools/dpdk-telemetry.py index 7f22e21828..b7a7553f52 10

Re: [dpdk-dev] [PATCH v3 5/8] examples/ioat: add signal-triggered device dumps

2021-09-29 Thread Conor Walsh
On 28/09/2021 17:29, Kevin Laatz wrote: Enable dumping device info via the signal handler. With this change, when a SIGUSR1 is issued, the application will print a dump of all devices being used by the application. Signed-off-by: Kevin Laatz --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 4/8] examples/ioat: add cmd line option to control stats print interval

2021-09-29 Thread Conor Walsh
On 28/09/2021 17:29, Kevin Laatz wrote: Add a command line option to control the interval between stats prints. Signed-off-by: Kevin Laatz --- Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v6 12/12] raw/ioat: deprecate ioat rawdev driver

2021-09-27 Thread Conor Walsh
Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have moved to dmadev. Signed-off-by: Conor Walsh Acked-by: Kevin Laatz Acked-by: Bruce Richardson --- MAINTAINERS | 2 +- doc/guides/rawdevs/ioat.rst | 4 doc/guides/rel_notes/deprecation.rst

[dpdk-dev] [PATCH v6 11/12] devbind: move ioat device IDs to dmadev category

2021-09-27 Thread Conor Walsh
Move Intel IOAT devices from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Bruce Richardson --- usertools/dpdk-devbind.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v6 10/12] dma/ioat: add burst capacity function

2021-09-27 Thread Conor Walsh
Adds the ability to find the remaining space in the IOAT ring. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v6 09/12] dma/ioat: add support for vchan status function

2021-09-27 Thread Conor Walsh
Add support for the rte_dmadev_vchan_status API call. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat

[dpdk-dev] [PATCH v6 08/12] dma/ioat: add statistics

2021-09-27 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v6 07/12] dma/ioat: add data path completion functions

2021-09-27 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- doc/guides/dmadevs/ioat.rst| 33 +++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files

[dpdk-dev] [PATCH v6 06/12] dma/ioat: add data path job submission functions

2021-09-27 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- doc/guides/dmadevs/ioat.rst| 9 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed

[dpdk-dev] [PATCH v6 05/12] dma/ioat: add start and stop functions

2021-09-27 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 95 insertions

[dpdk-dev] [PATCH v6 04/12] dma/ioat: add configuration functions

2021-09-27 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc

[dpdk-dev] [PATCH v6 03/12] dma/ioat: add datapath structures

2021-09-27 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 63 +- drivers/dma/ioat/ioat_hw_defs.h | 215 2 files changed

[dpdk-dev] [PATCH v6 02/12] dma/ioat: create dmadev instances on PCI probe

2021-09-27 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 102

[dpdk-dev] [PATCH v6 01/12] dma/ioat: add device probe and removal functions

2021-09-27 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- MAINTAINERS| 6 +++ doc/guides

[dpdk-dev] [PATCH v6 00/12] dma: add dmadev driver for ioat devices

2021-09-27 Thread Conor Walsh
be run multiple times using the IOAT driver without errors. - Added devbind updates for DMA devices - Removed some logically dead code found by coverity in the Conor Walsh (12): dma/ioat: add device probe and removal functions dma/ioat: create dmadev instances on PCI probe dma/ioat:

Re: [dpdk-dev] [PATCH v6 10/13] dmadev: add flag for error handling support

2021-09-24 Thread Conor Walsh
address. To indicate the availability of safe error handling by a device, we add a capability flag for it. Signed-off-by: Bruce Richardson --- This is very useful for the IOAT driver too, thanks! Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v6 04/13] dma/skeleton: add burst capacity function

2021-09-24 Thread Conor Walsh
On 24/09/2021 11:29, Bruce Richardson wrote: Implement function to return the remaining space for operations. Signed-off-by: Bruce Richardson --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v6 05/13] dmadev: add device iterator

2021-09-24 Thread Conor Walsh
On 24/09/2021 11:29, Bruce Richardson wrote: Add a function and wrapper macro to iterate over all dma devices. Signed-off-by: Bruce Richardson --- Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v5 12/12] raw/ioat: deprecate ioat rawdev driver

2021-09-24 Thread Conor Walsh
Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have moved to dmadev. Signed-off-by: Conor Walsh --- MAINTAINERS | 2 +- doc/guides/rawdevs/ioat.rst | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ccabba9169

[dpdk-dev] [PATCH v5 11/12] devbind: move ioat device IDs to dmadev category

2021-09-24 Thread Conor Walsh
Move Intel IOAT devices from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Bruce Richardson --- usertools/dpdk-devbind.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py

[dpdk-dev] [PATCH v5 10/12] dma/ioat: add burst capacity function

2021-09-24 Thread Conor Walsh
Adds the ability to find the remaining space in the IOAT ring. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v5 09/12] dma/ioat: add support for vchan status function

2021-09-24 Thread Conor Walsh
Add support for the rte_dmadev_vchan_status API call. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat

[dpdk-dev] [PATCH v5 08/12] dma/ioat: add statistics

2021-09-24 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma

[dpdk-dev] [PATCH v5 07/12] dma/ioat: add data path completion functions

2021-09-24 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- doc/guides/dmadevs/ioat.rst| 33 +++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files

[dpdk-dev] [PATCH v5 06/12] dma/ioat: add data path job submission functions

2021-09-24 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- doc/guides/dmadevs/ioat.rst| 9 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed

[dpdk-dev] [PATCH v5 05/12] dma/ioat: add start and stop functions

2021-09-24 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 95 insertions

[dpdk-dev] [PATCH v5 04/12] dma/ioat: add configuration functions

2021-09-24 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc

[dpdk-dev] [PATCH v5 03/12] dma/ioat: add datapath structures

2021-09-24 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 63 +- drivers/dma/ioat/ioat_hw_defs.h | 215 2 files changed

[dpdk-dev] [PATCH v5 02/12] dma/ioat: create dmadev instances on PCI probe

2021-09-24 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 102

[dpdk-dev] [PATCH v5 01/12] dma/ioat: add device probe and removal functions

2021-09-24 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- MAINTAINERS| 6 +++ doc/guides

[dpdk-dev] [PATCH v5 00/12] dma: add dmadev driver for ioat devices

2021-09-24 Thread Conor Walsh
ors. - Added devbind updates for DMA devices - Removed some logically dead code found by coverity in the create function. Conor Walsh (12): dma/ioat: add device probe and removal functions dma/ioat: create dmadev instances on PCI probe dma/ioat: add datapath structures dma/ioat:

Re: [dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-22 Thread Conor Walsh
On 22/09/2021 09:04, fengchengwen wrote: On 2021/9/17 23:42, Conor Walsh wrote: When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh

Re: [dpdk-dev] [PATCH v4 04/11] dma/ioat: add configuration functions

2021-09-22 Thread Conor Walsh
On 22/09/2021 09:08, fengchengwen wrote: On 2021/9/17 23:42, Conor Walsh wrote: Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a

Re: [dpdk-dev] [PATCH v4 06/11] dma/ioat: add data path job submission functions

2021-09-21 Thread Conor Walsh
On 20/09/2021 14:36, Bruce Richardson wrote: On Fri, Sep 17, 2021 at 03:42:22PM +, Conor Walsh wrote: Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 54

Re: [dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

2021-09-21 Thread Conor Walsh
On Fri, Sep 17, 2021 at 03:42:17PM +, Conor Walsh wrote: Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- MAINTAINERS

Re: [dpdk-dev] [PATCH v4 11/11] devbind: move ioat device ID for ICX to dmadev category

2021-09-21 Thread Conor Walsh
On Fri, Sep 17, 2021 at 03:42:27PM +, Conor Walsh wrote: Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- usertools/dpdk-devbind.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a

Re: [dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-21 Thread Conor Walsh
On Fri, Sep 17, 2021 at 03:42:18PM +, Conor Walsh wrote: When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin

Re: [dpdk-dev] [PATCH v2 6/6] examples/ioat: rename application to dmafwd

2021-09-20 Thread Conor Walsh
address of ``rearm_data`` These function names need to be updated for dmadev v22. Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 5/6] examples/ioat: update naming to match change to dmadev

2021-09-20 Thread Conor Walsh
Existing functions, structures, defines etc need to be updated to reflect the change to using the dmadev APIs. Signed-off-by: Kevin Laatz --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 4/6] examples/ioat: port application to dmadev APIs

2021-09-20 Thread Conor Walsh
-by: Kevin Laatz --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 3/6] examples/ioat: add cmd line option to control max frame size

2021-09-20 Thread Conor Walsh
From: Konstantin Ananyev Add command line option for setting the max frame size. Signed-off-by: Konstantin Ananyev --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 2/6] examples/ioat: add cmd-line option to control DMA batch size

2021-09-20 Thread Conor Walsh
From: Konstantin Ananyev Add a commandline options to control the HW copy batch size in the application. Signed-off-by: Konstantin Ananyev --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 1/6] examples/ioat: always use same lcore for both DMA requests enqueue and dequeue

2021-09-20 Thread Conor Walsh
ot;, + dev_id, rte_errno); + rc = 0; + } + return rc; +} Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v4 11/11] devbind: move ioat device ID for ICX to dmadev category

2021-09-17 Thread Conor Walsh
Move Intel IOAT devices on Ice Lake systems from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- usertools/dpdk-devbind.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index

  1   2   3   >