Re: [PATCH v5] doc: add new driver guidelines

On 10/4/2024 5:39 PM, Nandini Persad wrote: > +* Each patch should be organized logically as a new feature. > +* Run test tools per patch (See :ref:`tool_list`:). > ':' after `tool_list` is extra and can be dropped. Rest looks good to me, thanks.

Re: [PATCH 0/8] fix the representor port link status and speed

On 9/5/2024 7:25 AM, Chaoyong He wrote: > This patch series aims to fix some problems in the representor port link > status and speed update logic, also do some refactors to the related > logics. > > Qin Ke (8): > net/nfp: fix incorrect type declaration of some variables > net/nfp: add help fu

Re: [PATCH dpdk v2 04/16] net: use ipv6 structure for header addresses

On 10/1/2024 9:17 AM, Robin Jarry wrote: > @@ -918,12 +918,14 @@ static struct chrte_fparse parseitem[] = { > .fptr = ch_rte_parsetype_ipv6, > .dmask = &(const struct rte_flow_item_ipv6) { > .hdr = { > - .src_addr = > +

Re: [RFC] ethdev: convert string initialization

On 10/4/2024 4:17 PM, Stephen Hemminger wrote: > On Thu, 1 Aug 2024 02:27:22 -0700 > Ferruh Yigit wrote: > >> gcc 15 experimental [1], with -Wextra flag, gives warning in variable >> initialization as string [2]. >> >> The warning has a point when initializ

Re: [PATCH] doc: update TAP device features

On 10/4/2024 8:54 AM, Bruce Richardson wrote: > On Fri, Oct 04, 2024 at 05:09:21AM +0100, Ferruh Yigit wrote: >> On 10/4/2024 3:26 AM, Stephen Hemminger wrote: >>> On Fri, 4 Oct 2024 02:48:21 +0100 >>> Ferruh Yigit wrote: >>> >>>> On 9/4/2024 4:42 P

Re: [PATCH 0/3] support load firmware from flash

On 9/3/2024 6:52 AM, Chaoyong He wrote: > This patch series add the needed logic to support load firmware from the > flash in card. > > Chaoyong He (3): > net/nfp: fix potential problem on certain version BSP > net/nfp: add two APIs of the NSP module > net/nfp: support load firmware from fla

Re: [PATCH] net/nfp: reserve BAR for expansion ROM

On 9/3/2024 3:34 AM, Chaoyong He wrote: > For some platform, the warm restart of host doesn't trigger > the reset of NIC, which causes the initialize process of NIC > not executed with the right expansion ROM mapping. Consequently, > the PXE boot won't work in this case. > > Now reserve BAR 2.0 wh

Re: [RFC PATCH] app/testpmd: display TM parameters when adding nodes

rameters put in the wrong order, print out the > parameters for each command after it is entered. > > Signed-off-by: Bruce Richardson > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH v2 0/3] app/testpmd: improve sse based macswap

1Q 1C1T > 64B: : 45.0 : 45.54 > 128B: : 44.48 : 44.43 > 256B: : 42.0 : 41.99 > + > TEST MACSWAP: 2Q 2C2T > 64B: : 59.5 : 60.55 > 128B: : 56.78 : 58.1 > 256B: : 41.85 : 41.99 > ---- > > Signed-off-by: Vipin Varghese > > Vipin

Re: [PATCH v2 1/3] app/testpmd: add register keyword

On 9/6/2024 2:02 PM, Varghese, Vipin wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > >   >> > > >> --- a/app/test-pmd/macswap_sse.h >> > > >> +++ b/app/test-pmd/macswap_sse.h >> > > >> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t >> nb, >> > > >>    u

Re: [PATCH v2] app/testpmd: show output of commands read from file

; v2: use STDOUT_FILENO in place of hard-coded "1" > --- > After discussion, I think it is OK to have the update in the testpmd (instead of a new function in cmdline), hence; Acked-by: Ferruh Yigit

Re: [PATCH] app/testpmd: show output of commands read from file

On 10/4/2024 5:55 AM, Ferruh Yigit wrote: > On 8/22/2024 11:36 AM, Bruce Richardson wrote: >> Testpmd supports the "--cmdline-file" parameter to read a set of initial >> commands from a file. However, the only indication that this has been >> done successfully on s

Re: [PATCH] app/testpmd: show output of commands read from file

I think it is OK to have the update in the testpmd (instead of a new function in cmdline), hence; Acked-by: Ferruh Yigit

Re: [PATCH] net/gve: always attempt Rx refill on DQ

On 10/2/2024 12:45 AM, Joshua Washington wrote: > Before this patch, gve_rx_refill_dqo() is only called if the number of > packets received in a cycle is non-zero. However, in a > memory-constrained scenario, this doesn't behave well, as this could be > a potential source of lockup, if there is no

Re: [PATCH] net/gve: fix mbuf allocation memory leak for DQ Rx

On 10/2/2024 12:48 AM, Joshua Washington wrote: > Currently, gve_rxq_mbufs_alloc_dqo() allocates RING_SIZE buffers, but > only posts RING_SIZE - 1 of them, inevitably leaking a buffer every > time queues are stopped/started. This could eventually lead to running > out of mbufs if an application sto

Re: [PATCH 0/4] Support new card using NFP 3800 chip

On 9/3/2024 2:41 AM, Chaoyong He wrote: > This patch series add support of a new card which using the NFP 3800 chip. > Because it has different configure BAR size and flow steering rules > limit, we also do some refactor to the related logic. > > Chaoyong He (4): > net/nfp: add a new flag to ind

[PATCH] ethdev: convert string initialization

ot;\xff\xff\xff\xff\xff\xff\xff\xff" | ^~ ../lib/ethdev/rte_flow.h:1135:20: error: initializer-string for array of ‘unsigned char’ is too long [-Werror=unterminated-string-initialization] 1135 | .hdr.vni = "\xff\xff\xff", | ^~ Si

Re: [PATCH] doc: update TAP device features

On 10/4/2024 3:26 AM, Stephen Hemminger wrote: > On Fri, 4 Oct 2024 02:48:21 +0100 > Ferruh Yigit wrote: > >> On 9/4/2024 4:42 PM, Stephen Hemminger wrote: >>> The TAP device does have per-queue stats and handles multi-process. >>> >>> Signed-off-by:

Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

On 9/23/2024 9:41 PM, Akhil Goyal wrote: > Hi Morten, > > Apologies for delayed response. >> Maybe a combination, returning the lowest end of the two versions of the >> list, >> would work... >> >> -- >> Common header file (rte_common.h): >> ---

Re: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

On 9/6/2024 8:45 AM, Akhil Goyal wrote: >>> >>> Here's an idea... >>> >>> We can introduce a generic design pattern where we keep the _LIST_END enum >> value at the end, somehow marking it private (and not part of the API/ABI), >> and >> move the _list_end() function inside the C file, so it uses

Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs

On 9/5/2024 11:14 AM, Akhil Goyal wrote: > Replace *_LIST_END enumerators from asymmetric crypto > lib to avoid ABI breakage for every new addition in > enums with inline APIs. > > Signed-off-by: Akhil Goyal > --- > This patch was discussed in ML long time back. > https://patches.dpdk.org/project

Re: [PATCH] doc: update TAP device features

On 9/4/2024 4:42 PM, Stephen Hemminger wrote: > The TAP device does have per-queue stats and handles multi-process. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/nics/features/tap.ini | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/doc/guides/nics/features/tap.ini > b/doc/

Re: [PATCH] Add bus master enable/disable APIs for CDX devices

On 10/3/2024 11:16 PM, Stephen Hemminger wrote: > On Fri, 27 Oct 2023 17:22:11 +0100 > Ferruh Yigit wrote: > >> From: Shubham Rohila >> >> Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to >> enable or disable bus master functionality for cdx devi

Re: [PATCH] drivers: remove compile-time option for IEEE 1588

On 10/3/2024 8:12 PM, Stephen Hemminger wrote: > On Wed, 17 Apr 2024 14:24:00 +0100 > Ferruh Yigit wrote: > >>> :) remove compile flag in 24.11 LTS. >>> >>> But we may end up in same situation in 24.11, some drivers not being >>> ready, so we shoul

Re: [PATCH v5 00/18] NXP DPAA ETH driver enhancement and fixes

On 10/1/2024 12:03 PM, Hemant Agrawal wrote: > v5: fix individual patch compilation and checkpatch warning > v4: fix clang compilation issues > v3: addressed Ferruh's comments > - dropped Tx rate limit API patch > - added one small bug fix > - fixed removal/add of fman_offline type > > v2: add

Re: [PATCH v4 00/18] NXP DPAA ETH driver enhancement and fixes

On 9/30/2024 1:15 PM, Hemant Agrawal wrote: > v4: fix clan compilation issues > v3: addressed Ferruh's comments > - dropped Tx rate limit API patch > - added one small bug fix > - fixed removal/add of fman_offline type > > v2: address review comments > - improve commit message > - add docume

Re: [PATCH v3 1/1] ethdev: fix int overflow in descriptor count logic

overflow. > > Fixes: 0f67fc3baeb9 ("ethdev: add function to adjust number of descriptors") > > Signed-off-by: Niall Meade > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [PATCH v3 0/3] add frequency adjustment support for PTP

On 9/30/2024 9:42 AM, Mingjin Ye wrote: > [1/3] ethdev: add frequency adjustment API > [2/3] net/ice: add frequency adjustment support for PTP > [3/3] examples/ptpclient: add frequency adjustment support > --- > v2: rte_eth_timesync_adjust_freq marked as experimental. > --- > v3: Add more descripti

Re: [PATCH v3 1/3] ethdev: add frequency adjustment API

On 9/30/2024 9:42 AM, Mingjin Ye wrote: > This patch adds freq adjustment API for PTP high accuracy. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye > Reviewed-by: Ferruh Yigit

Re: [PATCH v3 3/3] examples/ptpclient: add frequency adjustment support

On 9/30/2024 9:42 AM, Mingjin Ye wrote: > This patch adds PI servo algorithm to support frequency > adjustment API for IEEE1588 PTP. > > For example, the command for starting ptpclient with PI algorithm is: > ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 > --controller=p

Re: [RFC 0/4] ethdev: rework config restore

On 9/18/2024 10:21 AM, Dariusz Sosnowski wrote: > Hi all, > > We have been working on optimizing the latency of calls to > rte_eth_dev_start(), > on ports spawned by mlx5 PMD. Most of the work requires changes in the > implementation of > .dev_start() PMD callback, but I also wanted to start a d

Re: [PATCH v4 2/2] app/testpmd: add set dev led on/off command

On 9/18/2024 3:38 AM, Chaoyong He wrote: > From: James Hershaw > > Add command to change the state of a controllable LED on an ethdev port > to on/off. This is for the purpose of identifying which physical port is > associated with an ethdev. > > Usage: > testpmd> set port led > > Signed-of

Re: [PATCH v4 1/2] app/testpmd: add support for setting device EEPROM

On 9/18/2024 3:38 AM, Chaoyong He wrote: > From: James Hershaw > > There is currently no means to test the .set_eeprom function callback of > a given PMD in drivers/net/. This patch adds functionality to allow a > user to set device eeprom from the testpmd cmdline. > > Usage: > testpmd> set po

Re: [PATCH] net/tap: add new macpair option for split MAC address

On 9/17/2024 12:51 PM, Isaac Boukris wrote: > Normally, the MAC address of the kernel interface is the same as in the > interface in dpdk, as they represent the same interface. It is useful > to allow viewing them as separate connected interfaces (like ip's veth). > > This solves a problem I have

Re: [RFC] ethdev: introduce PTP device capability

On 9/29/2024 2:31 AM, lihuisong (C) wrote: > > 在 2024/9/26 4:42, Ferruh Yigit 写道: >> On 9/24/2024 8:24 AM, lihuisong (C) wrote: >>> Hi Ferruh, >>> >>> >>> 在 2024/9/23 6:23, Ferruh Yigit 写道: >>>> On 1/30/2024 3:58 AM, Huisong Li wrote

Re: [PATCH v3] net/nfp: implement the device packet type set interface

On 9/27/2024 4:10 AM, Chaoyong He wrote: > From: Long Wu > > Using the Rx packet offload flag rather than the device > capability to control the packet type offload configuration. > Also implement the device packet type set interface to > let application can set the Rx packet offload flag. > > S

Re: [PATCH v2 1/1] ethdev: fix int overflow in descriptor count logic

On 9/27/2024 2:23 PM, Niall Meade wrote: > Addressed a specific overflow issue in the eth_dev_adjust_nb_desc() > function where the uint16_t variable nb_desc would overflow when its > value was greater than (2^16 - nb_align). This overflow caused nb_desc > to incorrectly wrap around between 0 and n

Re: [PATCH v6 0/2] Add link_speed lanes support

On 9/26/2024 10:43 PM, Damodharam Ammepalli wrote: > This patch series is a continuation of the patch set that supports > configuring speed lanes. > https://patchwork.dpdk.org/project/dpdk/patch/20240708232351.491529-1- > damodharam.ammepa...@broadcom.com/ > > The patchset consists > 1) rtelib/te

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

On 9/27/2024 11:46 AM, Meade, Niall wrote: >> On 9/26/2024 3:03 PM, Meade, Niall wrote: >>>> From: Ferruh Yigit >>>> Sent: Thursday, September 26, 2024 12:16 AM >>>> To: Meade, Niall ; Thomas Monjalon >>>> ; Andrew Rybchenko ; >>>

Re: [PATCH v9 0/8] support dump reigster names and filter

On 9/26/2024 1:42 PM, Jie Hai wrote: > The registers can be dumped through the API rte_eth_dev_get_reg_info. > However, only register values are exported, which is inconvenient for > users to interpret. Therefore, an extension of the structure > "rte_dev_reg_info" and a new API rte_eth_dev_get_reg_

Re: [PATCH v2 0/7] ethdev: jump to table support

On 9/25/2024 7:05 PM, Alexander Kozyrev wrote: > Introduce new Flow API JUMP_TO_TABLE_INDEX action. > It allows bypassing a hierarchy of groups and going directly > to a specified flow table. That gives a user the flexibility > to jump between different priorities in a group and eliminates > the ne

Re: [PATCH v2] net/nfp: implement the device packet type set interface

On 9/26/2024 8:16 AM, Chaoyong He wrote: > From: Long Wu > > Using the Rx packet offload flag rather than the device > capability to control the packet type offload configuration. > Also implement the device packet type set interface to > let application can set the Rx packet offload flag. > > S

Re: [PATCH v6 0/2] Add link_speed lanes support

On 9/26/2024 10:43 PM, Damodharam Ammepalli wrote: > This patch series is a continuation of the patch set that supports > configuring speed lanes. > https://patchwork.dpdk.org/project/dpdk/patch/20240708232351.491529-1- > damodharam.ammepa...@broadcom.com/ > > The patchset consists > 1) rtelib/te

Re: [PATCH v6 1/2] ethdev: Add link_speed lanes support

2 > memory allocation on the socket: 2 > Link status: up > Link speed: 200 Gbps > Active Lanes: 4 > Link duplex: full-duplex > Autoneg status: Off > > Signed-off-by: Damodharam Ammepalli > Reviewed-by: Ferruh Yigit Suggested patch title: ethdev: support link spee

Re: [PATCH v4] doc: add new driver guidelines

On 9/16/2024 5:28 PM, Stephen Hemminger wrote: > From: Nandini Persad > > This document was created to assist contributors in creating DPDK drivers > and provides suggestions and guidelines on how to upstream effectively. > > Co-authored-by: Ferruh Yigit > Co-authore

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

On 9/26/2024 3:03 PM, Meade, Niall wrote: >> From: Ferruh Yigit >> Sent: Thursday, September 26, 2024 12:16 AM >> To: Meade, Niall ; Thomas Monjalon >> ; Andrew Rybchenko ; >> Roman Zhukov >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1] ethdev:

Re: [PATCH v1] ethdev: fix int overflow in descriptor count logic

On 9/23/2024 10:26 AM, Niall Meade wrote: > Addressed a specific overflow issue in the eth_dev_adjust_nb_desc() > function where the uint16_t variable nb_desc would overflow when its > value was greater than (2^16 - nb_align). This overflow caused nb_desc > to incorrectly wrap around between 0 and

Re: [PATCH v4] net/zxdh: Provided zxdh basic init

On 9/10/2024 1:00 PM, Junlong Wang wrote: > provided zxdh initialization of zxdh PMD driver. > include msg channel, np init and etc. > Hi Junlong, It is very hard to review the driver as a single patch, it helps to split driver into multiple patches, please check the suggestion on it: https://pa

Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support

On 9/24/2024 11:59 PM, Damodharam Ammepalli wrote: > On Sun, Sep 22, 2024 at 10:02 AM Ferruh Yigit wrote: >> >> On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: >>> Update the eth_dev_ops structure with new function vectors >>> to get, get capabilities

Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support

On 9/25/2024 4:00 PM, Damodharam Ammepalli wrote: > On Tue, Sep 24, 2024 at 3:59 PM Damodharam Ammepalli > wrote: >> >> On Sun, Sep 22, 2024 at 10:02 AM Ferruh Yigit wrote: >>> >>> On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: >>>> Update the

Re: [RFC] ethdev: introduce PTP device capability

On 9/24/2024 8:24 AM, lihuisong (C) wrote: > Hi Ferruh, > > > 在 2024/9/23 6:23, Ferruh Yigit 写道: >> On 1/30/2024 3:58 AM, Huisong Li wrote: >>> Currently, the PTP feature is a little messy and has some issue. >>> 1> There is different implementation for PTP

Re: [PATCH 1/2] ethdev: add Rx packet type offload control flag

On 9/24/2024 3:03 AM, Chaoyong He wrote: >> On 6/19/2024 11:11 AM, Chaoyong He wrote: >>> From: Long Wu >>> >>> The Rx packet type offload feature may affect the performance, so add >>> a control flag for applications to turn it on or off. >>> >>> Signed-off-by: Long Wu >>> --- >>> lib/ethdev/rt

Re: [PATCH 1/2] ethdev: add Rx packet type offload control flag

On 6/19/2024 11:11 AM, Chaoyong He wrote: > From: Long Wu > > The Rx packet type offload feature may affect the performance, > so add a control flag for applications to turn it on or off. > > Signed-off-by: Long Wu > --- > lib/ethdev/rte_ethdev.h | 1 + > 1 file changed, 1 insertion(+) > > di

Re: [PATCH v6 00/14] Enhance the bond framework to support offload

On 12/26/2023 7:28 AM, Chaoyong He wrote: > This patch series try to enhance the bond framework to support the > offload feature better: > * Add new API to make the member port can access some information of the > bond port which belongs. > * Add new API to get the result of whether bond port is

Re: [RFC] ethdev: introduce PTP device capability

On 1/30/2024 3:58 AM, Huisong Li wrote: > Currently, the PTP feature is a little messy and has some issue. > 1> There is different implementation for PTP. This feature of some >hardware depends on the Rx HW timestamp offload, and use this >offload to detect if enable PTP feature. Others can

Re: [RFC 2/2] ethdev: add data size field to GENEVE option item

On 4/17/2024 8:23 AM, Michael Baum wrote: > The "rte_flow_item_geneve_opt" structure has field for option length. > This field has 2 different usages which might limit each other: > > 1. field to matching with value/mask. > 2. descriptor for data array size. > > This patch adds a new field "dat

Re: [RFC v2] ethdev: an API for cache stashing hints

On 7/26/2024 9:01 PM, Wathsala Wathawana Vithanage wrote: >> rte_eth_X_get_capability() >> > > rte_eth_dev_stashing_hints_discover is somewhat similar. > >> Instead of adding RTE_ETH_DEV_CAPA_ macro and contaminating >> 'rte_eth_dev_info' with this edge use case, what do you think follow above >>

Re: [PATCH v7 0/8] support dump reigser names and filter

On 9/14/2024 8:13 AM, Jie Hai wrote: > The registers can be dumped through the API rte_eth_dev_get_reg_info. > However, only register values are exported, which is inconvenient for > users to interpret. Therefore, an extension of the structure > "rte_dev_reg_info" and a new API rte_eth_dev_get_reg_

Re: [PATCH v7 2/8] ethdev: add telemetry cmd for registers

, > "group_0": { > "Q0_ring_rx_bd_num": "0x0", > "Q0_ring_rx_bd_len": "0x0", > ... > }, > "group_1": { > ... > }, > ... > } > > Signed-off-by: Jie Hai > Reviewed-by: Ferruh Yigit

Re: [PATCH v7 1/8] ethdev: support report register names and filter

ort the names, set them > to "index_XXX", which means the location in the register table. > > Signed-off-by: Jie Hai > Acked-by: Huisong Li > Acked-by: Chengwen Feng > Reviewed-by: Ferruh Yigit

Re: [PATCH v2 0/3] add frequency adjustment support for PTP

On 9/10/2024 10:13 AM, Mingjin Ye wrote: > [1/3] ethdev: add frequency adjustment API > [2/3] net/ice: add frequency adjustment support for PTP > [3/3] examples/ptpclient: add frequency adjustment support > --- > v2: rte_eth_timesync_adjust_freq marked as experimental. > > Mingjin Ye (3): > ethd

Re: [PATCH v2 1/3] ethdev: add frequency adjustment API

On 9/10/2024 10:13 AM, Mingjin Ye wrote: > This patch adds freq adjustment API for PTP high accuracy. > > Signed-off-by: Simei Su > Signed-off-by: Mingjin Ye <...> > diff --git a/doc/guides/rel_notes/release_24_11.rst > b/doc/guides/rel_notes/release_24_11.rst > index 0ff70d9057..10ac35e5c0 1

Re: [PATCH v5 1/2] ethdev: Add link_speed lanes support

On 9/4/2024 6:50 PM, Damodharam Ammepalli wrote: > Update the eth_dev_ops structure with new function vectors > to get, get capabilities and set ethernet link speed lanes. > Update the testpmd to provide required config and information > display infrastructure. > > The supporting ethernet controll

Re: [PATCH 4/4] ethdev: add traffic manager query function

On 8/6/2024 4:24 PM, Bruce Richardson wrote: > +/** > + * Return information about a traffic management node > + * > + * Return information about a hierarchy node, using the same format of > parameters > + * as was passed to the rte_rm_node_add() function. > + * Each of the "out" parameters pointe

Re: [PATCH 3/4] ethdev: make TM shaper parameters constant

arameters passed in via struct pointer. We should >> guarantee this by marking the parameter pointer as const. This allows SW to >> create multiple profiles using the same parameter struct without having to >> reset it each time. >> >> Signed-off-by: Bruce Richardson > > Reviewed-by: Rosen Xu > Acked-by: Ferruh Yigit

Re: [PATCH 2/4] ethdev: make parameters to TM profile add fn constant

le parameters passed in via struct pointer. We should guarantee this >> by marking the parameter pointer as const. This allows SW to create multiple >> profiles using the same parameter struct without having to reset it each >> time. >> >> Signed-off-by: Bruce Richardson > > Reviewed-by: Rosen Xu > Acked-by: Ferruh Yigit

Re: [PATCH 1/4] ethdev: make parameters to TM node add fn constant

vel_id, const struct rte_tm_node_params >> +*params, >> struct rte_tm_error *error) >> { >> struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); diff -- >> /** @internal Traffic manager node delete */ >> -- >> 2.43.0 > > Reviewed-by: Rosen Xu > Acked-by: Ferruh Yigit

Re: [PATCH v2 15/18] bus/dpaa: add OH port mode for dpaa eth

On 8/23/2024 8:32 AM, Hemant Agrawal wrote: > @@ -78,7 +78,7 @@ TAILQ_HEAD(rte_fman_if_list, __fman_if); > > /* Represents the different flavour of network interface */ > enum fman_mac_type { > - fman_offline_internal = 0, > + fman_offline = 0, > fman_mac_1g, > fman_mac_10g,

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

On 9/22/2024 2:27 PM, Ferruh Yigit wrote: > On 9/22/2024 5:40 AM, Hemant Agrawal wrote: >> HI Ferruh, >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Sunday, September 22, 2024 8:44 AM >>> To: Hemant Agrawal ; dev@dpdk.or

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

On 9/22/2024 5:40 AM, Hemant Agrawal wrote: > HI Ferruh, > >> -Original Message----- >> From: Ferruh Yigit >> Sent: Sunday, September 22, 2024 8:44 AM >> To: Hemant Agrawal ; dev@dpdk.org >> Cc: ferruh.yi...@intel.com; Vinod Pullabhatla ; >> Rohit

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

On 9/22/2024 5:40 AM, Hemant Agrawal wrote: > HI Ferruh, > >> -Original Message----- >> From: Ferruh Yigit >> Sent: Sunday, September 22, 2024 8:44 AM >> To: Hemant Agrawal ; dev@dpdk.org >> Cc: ferruh.yi...@intel.com; Vinod Pullabhatla ; >> Rohit

Re: [PATCH v3 0/3] net/enic: support VF and fix minor issues

On 8/9/2024 8:07 AM, Hyong Youb Kim wrote: > This series contains minor updates for net/enic. The first patch > supports SR-IOV VF, which now requires the use of admin channel. The > other patches are not related to VF, but included here to ease review. > > --- > > v3: > * add spdx, doc, rel_note

Re: [PATCH] net/ena: revert redefining memcpy

On 9/12/2024 6:12 AM, Tyler Retzlaff wrote: > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: >> Redefining memcpy as rte_memcpy has no performance gain on >> current compilers, and introduced bugs like this one where >> rte_memcpy() will be detected as referencing past the desti

Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

On 8/23/2024 8:32 AM, Hemant Agrawal wrote: > diff --git a/drivers/net/dpaa/version.map b/drivers/net/dpaa/version.map > index 3fdb63caf3..24a28ce649 100644 > --- a/drivers/net/dpaa/version.map > +++ b/drivers/net/dpaa/version.map > @@ -6,6 +6,13 @@ DPDK_25 { > local: *; > }; > > +EXPERIME

Re: [PATCH v2 00/18] NXP DPAA ETH driver enhancement and fixes

On 8/23/2024 8:32 AM, Hemant Agrawal wrote: > v2: address review comments > - improve commit message > - add documentarion for new functions > - make IEEE1588 config runtime > > This series adds several enhancement to the NXP DPAA Ethernet driver. > > Primarily: > 1. timestamp and IEEE 1588 su

Re: [PATCH v3] net/af_packet: add timestamp offloading support

On 9/20/2024 8:14 AM, Stefan Laesser wrote: > Add the packet timestamp from TPACKET_V2 to the mbuf > dynamic rx timestamp register if offload RTE_ETH_RX_OFFLOAD_TIMESTAMP > is enabled. > > TPACKET_V2 provides the timestamp with nanosecond resolution > and UNIX origo, i.e. time since 1-JAN-1970 UTC

Re: [PATCH] netvsc: optimize stats counters performance

On 9/19/2024 7:06 PM, Long Li wrote: >> Subject: RE: [PATCH] netvsc: optimize stats counters performance >> >>> From: Stephen Hemminger [mailto:step...@networkplumber.org] >>> Sent: Friday, 2 August 2024 19.33 >>> >>> On Fri, 2 Aug 2024 19:28:26 +0200 >>> Morten Brørup wrote: > > Reviewed-by: Lon

Re: [PATCH] net/gve: add ptype parsing to DQ format

On 9/18/2024 9:33 PM, Joshua Washington wrote: > Currently, the packet type is parsed as part of adding the > checksum-related ol_flags for a received packet, but the parsed > information is not added to the mbuf. > > This change adds the parsed ptypes to the mbuf and updates the RX > checksum val

Re: [PATCH v3] ethdev: optimize the activation of fast-path tracepoints

On 9/19/2024 5:37 PM, Jerin Jacob wrote: > On Thu, Sep 19, 2024 at 12:16 AM Adel Belkhiri > wrote: >> >> From: Adel Belkhiri >> >> Split the tracepoints rte_ethdev_trace_rx_burst and >> rte_eth_trace_call_rx_callbacks into two separate ones >> for empty and non-empty calls to avoid saturating >>

Re: [PATCH] net/mana: support rdma-core via pkg-config in meson

On 9/20/2024 6:14 PM, Long Li wrote: >> Subject: [PATCH] net/mana: support rdma-core via pkg-config in meson >> >> Currently building with custom rdma-core installed in /opt/rdma-core after >> setting PKG_CONFIG_PATH=/opt/rdma-core/lib64/pkgconfig/ results in the below >> meson logs: >> Run-time de

Re: [PATCH 0/5] Increase minimum meson version

ures guaranteed available. > > Bruce Richardson (5): > build: increase minimum meson version to 0.57 > build: remove version check on compiler links function > build: remove unnecessary version checks > build: use version file support from meson > build: replace deprecated meson function > Tested-by: Ferruh Yigit

Re: Unable to access DPDK KMODS folder

On 9/13/2024 1:48 PM, Pavithra Raghavendran wrote: > Hi Team > > I have subscribed to the mailer lists. And hence re-adding the request > below. > > As part of DPDK-22.11.2, we were downloading the dpdk-kmods folder from > the following link: http://dpdk.org/git/dpdk-kmods

Re: [PATCH v3] doc: add new driver guidelines

On 9/13/2024 5:19 AM, WanRenyong wrote: > On 2024/9/13 4:26, Stephen Hemminger wrote >> + >> +Finalizing >> +-- >> + >> +Once the driver has been upstreamed, the author has >> +a responsibility to the community to maintain it. >> + >> +This includes the public test report. Authors must send

Re: [PATCH v3] doc: add new driver guidelines

o with whatever you think more convenient. > -------- > *From:* Ferruh Yigit > *Sent:* Thursday, September 12, 2024 1:13:33 AM > *To:* Nandini Persad > *Cc:* dev@dpdk.org ; Thomas Mojalon ; > Stephen Hemminger > *Subject:* Re: [PATCH v3] doc: add new driver guid

Re: [RFC v3 0/3] Import Kernel uAPI header files

On 9/12/2024 1:08 PM, Maxime Coquelin wrote: > Hi Ferruh, > > On 9/12/24 10:30, Ferruh Yigit wrote: >> On 9/11/2024 8:32 PM, Maxime Coquelin wrote: >>> This series enables importing Linux Kernel uAPI headers >>> into the DPDK repository. It aims at solving align

Re: [RFC v3 0/3] Import Kernel uAPI header files

On 9/11/2024 8:32 PM, Maxime Coquelin wrote: > This series enables importing Linux Kernel uAPI headers > into the DPDK repository. It aims at solving alignment > issues between the build system and the system applications > linked ot DPDK libraries are run on. > Hi Maxime, Is the imported Linux

Re: [PATCH] net/ena: revert redefining memcpy

On 9/12/2024 6:12 AM, Tyler Retzlaff wrote: > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote: >> Redefining memcpy as rte_memcpy has no performance gain on >> current compilers, and introduced bugs like this one where >> rte_memcpy() will be detected as referencing past the desti

Re: [PATCH v3] doc: add new driver guidelines

ters in the driver guide - Make device operations struct 'const' - Dynamic logging - SPDX license tags and copyright notice on each file > On Tue, Sep 10, 2024 at 5:16 PM Ferruh Yigit <mailto:ferruh.yi...@amd.com>> wrote: > > On 9/10/2024 3:58 PM, Nandini Persad wrote: &

Re: virtio: RSS support capa

On 9/11/2024 3:59 PM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Wednesday, 11 September 2024 16.02 >> >> On 9/11/2024 2:20 PM, Thomas Monjalon wrote: >>> 11/09/2024 14:17, Morten Brørup: >>>> From: Andrew Ry

Re: virtio: RSS support capa

On 9/11/2024 3:02 PM, Ferruh Yigit wrote: > On 9/11/2024 2:20 PM, Thomas Monjalon wrote: >> 11/09/2024 14:17, Morten Brørup: >>> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] >>>> On 9/7/24 23:55, Morten Brørup wrote: >>>>>> From:

Re: virtio: RSS support capa

On 9/11/2024 2:20 PM, Thomas Monjalon wrote: > 11/09/2024 14:17, Morten Brørup: >> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] >>> On 9/7/24 23:55, Morten Brørup wrote: > From: Morten Brørup [mailto:m...@smartsharesystems.com] > dev_info->rx_offload_capa |= RTE_E

Re: [PATCH v2 00/19] XSC PMD for Yunsilicon NICs

On 9/11/2024 3:07 AM, WanRenyong wrote: > This xsc PMD (**librte_net_xsc**) provides poll mode driver for > Yunsilicon metaScale serials NICs. > > Features: > - > - MTU update > - TSO > - RSS hash > - RSS key update > - RSS reta update > - L3 checksum offload > - L4 checksum offload > - I

Re: ci: version.map check

On 9/11/2024 1:08 AM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Wednesday, 11 September 2024 01.48 >> >> On 9/10/2024 5:56 PM, Morten Brørup wrote: >>> It would be convenient if the CI checked that the symbols in >>

Re: [PATCH v3] doc: add new driver guidelines

On 9/10/2024 3:58 PM, Nandini Persad wrote: > This document was created to assist contributors > in creating DPDK drivers, providing suggestions > and guidelines for how to upstream effectively. > There are minor differences in this v3 and v2, isn't this version on top of v2, can those changes be

Re: ci: version.map check

On 9/10/2024 5:56 PM, Morten Brørup wrote: > It would be convenient if the CI checked that the symbols in version.map > files actually exist in the resulting code. > Is there instances that is not the case?

Re: Crash in tap pmd when using more than 8 rx queues

On 9/10/2024 5:58 PM, Stephen Hemminger wrote: > On Fri, 6 Sep 2024 12:16:47 +0100 > Ferruh Yigit wrote: > >> On 9/5/2024 1:55 PM, Edwin Brossette wrote: >>> Hello, >>> >>> I have recently stumbled into an issue with my DPDK-based application >>

Re: DPDK Summit Montreal - Schedule

On 9/6/2024 3:09 PM, Konstantin Ananyev wrote: > > >>> We will talk about the future of DPDK, the best userland networking >>> libraries >>> having an incredible hardware support from our large community. >>> It will be an opportunity to connect, learn and collaborate with developers >>> from ar

Re: Crash in tap pmd when using more than 8 rx queues

On 9/6/2024 3:04 PM, Edwin Brossette wrote: > Hello, > > I created a Bugzilla PR, just as you requested: > https://bugs.dpdk.org/show_bug.cgi?id=1536 show_bug.cgi?id=1536> > > As for the bug resolution, I have other matters to attend to and I'm > afraid I cannot spend mo

Re: [PATCH 0/3] eal: mark API's as stable

On 9/6/2024 11:04 AM, Morten Brørup wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] >> Sent: Friday, 6 September 2024 10.54 >> >> On 9/5/2024 3:01 PM, Jerin Jacob wrote: >>> On Thu, Sep 5, 2024 at 3:14 PM Morten Brørup >> wrote: >>>

Re: [PATCH 0/3] eal: mark API's as stable

On 9/6/2024 2:11 PM, Jerin Jacob wrote: > On Fri, Sep 6, 2024 at 3:04 PM Ferruh Yigit wrote: >> >> On 9/5/2024 8:58 AM, David Marchand wrote: >>> On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger >>> wrote: >>>> >>>> The API's in

  1   2   3   4   5   6   7   8   9   10   >