Re: [dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-15 Thread Herbert Guan
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Saturday, January 13, 2018 1:04 > To: Herbert Guan > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on

[dpdk-dev] [PATCH] arch/arm: optimization for memcpy on ARM64

2018-01-18 Thread Herbert Guan
s and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan Acked-by: Jerin Jacob --- config/common_armv8a_linuxapp | 12 + .../common/include/arch/arm/rte_memcpy_6

[dpdk-dev] [PATCH v6] arch/arm: optimization for memcpy on ARM64

2018-01-18 Thread Herbert Guan
s and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan Acked-by: Jerin Jacob --- config/common_armv8a_linuxapp | 12 + .../common/include/arch/arm/rte_memcpy_6

[dpdk-dev] 答复: [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-18 Thread Herbert Guan
#x27;m sorry for the disturbance. Best regards, Herbert -邮件原件- 发件人: Thomas Monjalon [mailto:tho...@monjalon.net] 发送时间: 2018年1月19日 7:54 收件人: Herbert Guan 抄送: dev@dpdk.org; jerin.ja...@caviumnetworks.com; nd 主题: Re: [dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on AArch64 Ping

Re: [dpdk-dev] [PATCH v4 2/2] build: add support for detecting march on ARM

2018-01-21 Thread Herbert Guan
aa...@intel.com; Herbert Guan ; > hemant.agra...@nxp.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 2/2] build: add support for detecting march > on ARM > > Added support for detecting march and mcpu by reading midr_el1 register. > The implementer, primary pa

[dpdk-dev] [PATCH] test: provide performance difference ratio and test time

2017-10-25 Thread Herbert Guan
re provided to allow comparation between platforms. Signed-off-by: Herbert Guan --- test/test/test_memcpy_perf.c | 50 +--- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/test/test/test_memcpy_perf.c b/test/test/test_memcpy_perf.c index 91de856..

[dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-11-26 Thread Herbert Guan
forms and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan --- .../common/include/arch/arm/rte_memcpy_64.h| 193 + 1 file changed, 193 insert

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Herbert Guan
Jerin, Thanks a lot for your review and comments. Please find my comments below inline. Best regards, Herbert > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, November 29, 2017 20:32 > To: Herbert Guan > Cc: Jianbo Liu

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Herbert Guan
Pavan, Thanks for review and comments. Please find my comments inline below. Best regards, Herbert > -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Saturday, December 2, 2017 15:33 > To: Herbert Guan ; Jianbo L

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-03 Thread Herbert Guan
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Sunday, December 3, 2017 22:21 > To: Herbert Guan ; Jianbo Liu > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy

[dpdk-dev] [PATCH v2] arch/arm: optimization for memcpy on AArch64

2017-12-04 Thread Herbert Guan
forms and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan --- config/common_armv8a_linuxapp | 6 + .../common/include/arch/arm/rte_memcpy_64.h

Re: [dpdk-dev] [PATCH] arch/arm: optimization for memcpy on AArch64

2017-12-17 Thread Herbert Guan
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, December 15, 2017 12:06 > To: Herbert Guan > Cc: Jianbo Liu ; dev@dpdk.org > Subject: Re: [PATCH] arch/arm: optimization for memcpy on AArch64 > &g

[dpdk-dev] [PATCH v3] arch/arm: optimization for memcpy on AArch64

2017-12-17 Thread Herbert Guan
forms and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan --- config/common_armv8a_linuxapp | 6 + .../common/include/arch/arm/rte_memcpy_64.h

Re: [dpdk-dev] [PATCH v3] arch/arm: optimization for memcpy on AArch64

2017-12-18 Thread Herbert Guan
Jerin, Thanks for review and comments. Please find my feedbacks below inline. > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, December 18, 2017 15:44 > To: Herbert Guan > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] arch

[dpdk-dev] [PATCH v4] arch/arm: optimization for memcpy on AArch64

2017-12-20 Thread Herbert Guan
forms and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan --- config/common_armv8a_linuxapp | 6 + .../common/include/arch/arm/rte_memcpy_64.h

[dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-04 Thread Herbert Guan
forms and with the same code, GCC 7.2.0 compiled binary can provide better performance than GCC 4.8.5. It's suggested to use GCC 5.4.0 or later. Signed-off-by: Herbert Guan Acked-by: Jerin Jacob --- config/common_armv8a_linuxapp | 6 + .../common/include/arch/arm/rte_mem

Re: [dpdk-dev] [PATCH v4] arch/arm: optimization for memcpy on AArch64

2018-01-04 Thread Herbert Guan
To: Herbert Guan > Cc: dev@dpdk.org > Subject: Re: [PATCH v4] arch/arm: optimization for memcpy on AArch64 > > -Original Message- > > Date: Thu, 21 Dec 2017 13:33:47 +0800 > > From: Herbert Guan > > To: dev@dpdk.org, jerin.ja...@caviumnetworks.com > >

[dpdk-dev] [PATCH] build: add more implementers' IDs and PNs for Arm platforms

2018-01-30 Thread Herbert Guan
port 4) Add known implementers' IDs (use generic flags/archs by default) 5) Sync build options with config/common_armv8a_linuxapp Signed-off-by: Herbert Guan --- config/arm/arm64_armv8_linuxapp_gcc | 14 ++ config/arm/meson.build | 99 - 2

[dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms

2018-01-30 Thread Herbert Guan
port 4) Add known implementers' IDs (use generic flags/archs by default) 5) Sync build options with config/common_armv8a_linuxapp Signed-off-by: Herbert Guan --- config/arm/arm64_armv8_linuxapp_gcc | 14 ++ config/arm/meson.build | 99 - 2

Re: [dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms

2018-02-05 Thread Herbert Guan
Hi Pavan, > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, February 5, 2018 17:23 > To: Herbert Guan ; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > bruce.richard...@intel.com; harry.van.haa...@intel.com

[dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.

2017-07-12 Thread Herbert Guan
Fixes: 3c4b4024c2 (arch/arm: add vcopyq_laneq_u32 for old gcc) Signed-off-by: Herbert Guan --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/lib/librte_eal/common/include/arch/arm

[dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-12 Thread Herbert Guan
Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0 Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") Signed-off-by: Herbert Guan --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 7 +++ 1 file changed, 7 insertion

Re: [dpdk-dev] [PATCH] ARMv8: Use built-in data types for unsupported poly64/128 types for GCC version lower than 4.9.0.

2017-07-12 Thread Herbert Guan
Thank, Jerin. I've fixed the git-log warnings and raised a v2 patch just now. Best Regards, Herbert -Original Message- From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] Sent: Thursday, July 13, 2017 1:45 To: Herbert Guan Cc: dev@dpdk.org; jianbo@linaro.org Subjec

[dpdk-dev] [PATCH] test: fix the parameter issue of test case

2017-07-13 Thread Herbert Guan
When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is calling balance_l23_tx_burst(), the ip_addr instead of mac_addr should be toggled according to the test name. Signed-off-by: Herbert Guan --- test/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+),

Re: [dpdk-dev] [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-18 Thread Herbert Guan
nesday, July 19, 2017 0:14 To: Herbert Guan ; dev@dpdk.org; declan.dohe...@intel.com; jianbo@linaro.org Subject: Re: [dpdk-dev] [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test. On 7/10/2017 12:13 PM, Herbert Guan wrote: > Patch V2: fix build warnings by deletin

Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-19 Thread Herbert Guan
asonable. Best regards, Herbert -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, July 18, 2017 22:44 To: Herbert Guan Cc: dev@dpdk.org; jianbo@linaro.org; jerin.ja...@caviumnetworks.com; nelio.laranje...@6wind.com Subject: Re: [dpdk-dev] [PATCH v2] eal/ar

Re: [dpdk-dev] [PATCH v2] eal/armv8: fix poly64/128 compile issue in old GCC(<4.9.0)

2017-07-24 Thread Herbert Guan
s not. For this reason, I think " typedef uint8_t poly128_t __attribute__((vector_size(16), aligned(16)));" is better. Could you comment if having different thoughts or concerns? Thanks, Herbert -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Wednesday, Ju

[dpdk-dev] [PATCH] net/bonding: validate bonded port id before access its data

2017-07-30 Thread Herbert Guan
Fixes: 4c42498d916d ("net/bonding: allow slaves to also be bonded devices") Signed-off-by: Herbert Guan --- drivers/net/bonding/rte_eth_bond_api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/n

[dpdk-dev] [PATCH] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-10 Thread Herbert Guan
ports' tx queue in the clean up function remove_slaves_and_stop_bonded_device() of each test cases. 2) Do not release allocated mbufs for test bursts. These mbufs will be released in remove_slaves_and_stop_bonded_device() when test case exits. Signed-off-by: Herbert Guan --- test

[dpdk-dev] [PATCH v2] test: Fix memory corruption issues which fails the link_bonding test.

2017-07-10 Thread Herbert Guan
exits. Signed-off-by: Herbert Guan --- test/test/test_link_bonding.c | 64 ++- 1 file changed, 9 insertions(+), 55 deletions(-) diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c index aa2a1a2..140d864 100644 --- a/test