RE: [PATCH] crypto/qat: enable asymmetric crypto on gen3 device

2023-01-11 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Wednesday, December 14, 2022 4:34 PM > To: Ji, Kai > Cc: dev@dpdk.org; Kusztal, ArkadiuszX ; > Power, Ciara > Subject: [PATCH] crypto/qat: enable asymmetric crypto on gen3 device > > Thi

RE: [PATCH] crypto/qat: fix build

2023-01-12 Thread Ji, Kai
rrent fix and please cc: sta...@dpdk.org The fully removal of Openssl dependency is already ongoing, I will take a note to fix this properly Regards Kai > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 11, 2023 11:21 PM > To: Ji, Kai ; De Lara Guarch

RE: [PATCH] ipsec: remove unneccessary null check

2023-01-16 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Stephen Hemminger > Sent: Friday, January 13, 2023 6:44 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Ji, Kai > ; De Lara Guarch, Pablo ; > Power, Ciara > Subject: [PATCH] ipsec: remove unneccessary null

RE: [PATCH v2] crypto/qat: fix build

2023-01-18 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, January 18, 2023 11:06 AM > To: gak...@marvell.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org; Ji, Kai > Subject: [PATCH v2] crypto/qat: fix build > >

RE: [PATCH] test/crypto: fix typo in AES test

2023-01-30 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Vikash Poddar > Sent: Monday, January 30, 2023 12:03 PM > To: Thomas Monjalon ; Akhil Goyal > ; Fan Zhang > Cc: dev@dpdk.org; Poddar, Vikash ChandraX > ; shi...@nvidia.com > Subject: [PATCH] test/crypto: fix typo in AES test > > Fix the spe

RE: [External] : [PATCH] crypto/qat: use intel-ipsec-mb for partial hash

2022-05-17 Thread Ji, Kai
Please see v2: http://patchwork.dpdk.org/project/dpdk/list/?series=22973 Regards Kai Does it mean the intel-ipsec-mb would be prerequisite of applying QAT offloading for security application? It this is the case, as I know, the intel-ipsec-mb has no FIPS certification yet. Thus I am thinking

RE: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT

2022-05-17 Thread Ji, Kai
Acked-by: Ji, Kai > -Original Message- > From: Heinrich Schuchardt > Sent: Tuesday, May 10, 2022 4:07 PM > To: Zhang, Roy Fan > Cc: Chandubabu Namburu ; dev@dpdk.org; Heinrich > Schuchardt > Subject: [PATCH 1/1] drivers: define OPENSSL_API_COMPAT > > The

RE: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib

2022-05-18 Thread Ji, Kai
Hi Bruce, We want user to have the ability to choice which lib they want to use, so the original design was to make the build option temporary, and it will get removed after ipsec-mb FIP certified. Will look into the runtime option to avoid top level build option modification. Regards Kai >

RE: [PATCH v2] common/qat: read hw slice configuration

2022-10-16 Thread Ji, Kai
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, October 13, 2022 3:03 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2] common/qat: read hw slice configuration > > Read slice config

RE: [PATCH v3 1/2] common/qat: read hw slice configuration

2022-10-20 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, October 18, 2022 3:02 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v3 1/2] common/qat: read hw slice configuration > >

RE: [PATCH v3 2/2] crypto/qat: read hw slice configuration

2022-10-20 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, October 18, 2022 3:02 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v3 2/2] crypto/qat: read hw slice configuration > >

RE: [PATCH v2 1/4] crypto/qat: make immutable parameters constant

2022-10-20 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, October 20, 2022 4:10 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 1/4] crypto/qat: make immutable parameters constant >

RE: [PATCH v2 2/4] crypto/qat: improve freeing of asym cookies

2022-10-20 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, October 20, 2022 4:10 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 2/4] crypto/qat: improve freeing of asym cookies >

RE: [PATCH v2 3/4] crypto/qat: add ecdh key exchange algorithm

2022-10-24 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, October 20, 2022 4:10 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 3/4] crypto/qat: add ecdh key exchange algorithm >

RE: [PATCH v2 4/4] crypto/qat: add ecdh public key verification

2022-10-24 Thread Ji, Kai
Code may need rebase, otherwise Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, October 20, 2022 4:10 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 4/4] crypto/qat

RE: [PATCH v2 3/6] cryptodev: hide sym session structure

2022-09-22 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 4:03 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; vattun...@marvell.com; > ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > ko

RE: [PATCH v2 5/6] drivers/crypto: support security session get size op

2022-09-22 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 4:03 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; vattun...@marvell.com; > ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > ko

RE: [PATCH v2 2/6] crypto/scheduler: use unified session

2022-09-22 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 4:03 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; vattun...@marvell.com; > ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > ko

RE: [PATCH v2 1/6] cryptodev: rework session framework

2022-09-22 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 21, 2022 4:03 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; vattun...@marvell.com; > ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > ko

RE: [PATCH v4 2/6] crypto/scheduler: use unified session

2022-09-27 Thread Ji, Kai
roadcom.com; > ano...@marvell.com; De Lara Guarch, Pablo > ; ma...@nvidia.com; g.si...@nxp.com; > Yang, Qiming ; Wu, Wenjun1 > ; jianw...@trustnetic.com; Wu, Jingjing > ; Xing, Beilei ; > ndabilpu...@marvell.com; Zhang, Roy Fan ; > Akhil Goyal ; Ji, Kai ; Coyle, David &g

RE: [PATCH v2 2/2] cryptodev: add sm3 hash algorithm

2022-09-28 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, September 28, 2022 2:18 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 2/2] cryptodev: add sm3 hash algorithm >

RE: [PATCH v2 1/2] cryptodev: add sm4 encryption algorithm

2022-09-28 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, September 28, 2022 2:18 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH v2 1/2] cryptodev: add sm4 encryption algorithm > >

RE: [PATCH v4 2/6] crypto/scheduler: use unified session

2022-09-28 Thread Ji, Kai
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, September 28, 2022 1:56 PM > To: Ji, Kai ; dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; Vamsi Krishna Attunuru > ; ferruh.yi...@xilinx.com; > andre

RE: [PATCH 1/2] cryptodev: add option to use ec base point in ecpm

2022-09-28 Thread Ji, Kai
The code changes only update the comment description of rte_crypto_ec_point. Can you update commit message to indicate the comments update on expected behaviour when x.data and y.data equal to NULL. Acked-by: Kai Ji > -Original Message- > From: Arek Kusztal > Sent: Thursday, August 18

RE: [PATCH 2/2] cryptodev: add ec point verification

2022-09-28 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Arek Kusztal > Sent: Thursday, August 18, 2022 8:42 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Kusztal, ArkadiuszX > Subject: [PATCH 2/2] cryptodev: add ec point verification > > This addition complements point verification in ECDH ope

RE: [v1 1/2] cryptodev: add enumeration in EC xform for FPM

2022-09-28 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Tuesday, September 27, 2022 8:31 AM > To: dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > ; Dooley, Brian ; Akhil > Goyal ; jer...@marvell.com; Gowrishankar > Muthukrishnan ; Kiran Kumar K > > Subject: [

RE: [EXT] [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request handler

2022-10-05 Thread Ji, Kai
Please see my comments inline > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 4, 2022 7:13 PM > To: Ji, Kai ; dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request > handler > > > This patch add a fun

RE: [EXT] [dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Ji, Kai
Hi Akhill, Thanks for your reply, please see my comments below. > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 6, 2022 7:49 PM > To: Ji, Kai ; dev@dpdk.org > Cc: Fan Zhang ; Ray Kinsella ; > Burakov, Anatoly ; Mcnamara, John > > Subject: RE:

RE: [PATCH v1] crypto/qat: reallocate on openssl version check

2022-10-07 Thread Ji, Kai
Please rebase Acked-by: Kai Ji > -Original Message- > From: Dooley, Brian > Sent: Monday, October 3, 2022 4:27 PM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; Dooley, Brian > > Subject: [PATCH v1] crypto/qat: reallocate on openssl version check > >

RE: [PATCH v1] crypto/qat: fix reallocate OpenSSL version check

2022-11-01 Thread Ji, Kai
Dooley, Brian > Sent: Monday, October 31, 2022 5:49 PM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Coyle, David > ; O'Sullivan, Kevin ; > Dooley, Brian > Subject: [PATCH v1] crypto/qat: fix reallocate OpenSSL version check > > Move the oss

RE: [PATCH v2] crypto/qat: fix reallocate OpenSSL version check

2022-11-02 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Dooley, Brian > Sent: Wednesday, November 2, 2022 9:54 AM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Coyle, David > ; O'Sullivan, Kevin ; > Dooley, Brian > Subject: [PATCH v2] crypt

RE: [PATCH] crypto/ipsec-mb: fix qp setup for secondary process

2022-11-04 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, November 4, 2022 9:43 AM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; pablo.de.lara.gua...@intel.con; Power, Ciara > > Subject: [PATCH] crypto/ipsec-mb: fix qp setup for s

RE: [PATCH] common/qat: fix undefined initial slice

2022-11-07 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Monday, November 7, 2022 9:24 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Kusztal, ArkadiuszX > > Subject: [PATCH] common/qat: fix undefined initial slice > > This com

RE: [PATCH v3] doc: support IPsec Multi-buffer lib v1.3

2022-11-10 Thread Ji, Kai
Do we need to add the section about chacha-poly PMD ? is that chacha-poly has a better performance in AESNI PMD compare to Chacha PMD ? regards Kai > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, November 10, 2022 11:07 AM > To: Ji, Kai > Cc: d

RE: [PATCH v4] doc: support IPsec Multi-buffer lib v1.3

2022-11-14 Thread Ji, Kai
Original Message- > From: De Lara Guarch, Pablo > Sent: Saturday, November 12, 2022 11:26 AM > To: Ji, Kai > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > Power, Ciara ; Dooley, Brian > Subject: [PATCH v4] doc: support IPsec Multi-buffer lib v1.3 > > Updated AESNI MB an

RE: [PATCH v2] doc: update QAT device support

2022-11-21 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Dooley, Brian > Sent: Friday, November 18, 2022 5:19 PM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: [PATCH v2] doc: update QAT device support > > Update w

RE: [PATCH v2] examples/fips_validation: add parsing for AES GMAC

2022-09-15 Thread Ji, Kai
> -Original Message- > From: Dooley, Brian > Sent: Thursday, September 1, 2022 11:35 AM > To: Zhang, Roy Fan ; Dooley, Brian > > Cc: dev@dpdk.org; gmuthukri...@marvell.com; gak...@marvell.com; Ji, Kai > > Subject: [PATCH v2] examples/fips_validation: add parsing

RE: [PATCH v2] examples/fips_validation: add parsing for AES CTR

2022-09-15 Thread Ji, Kai
Please fix the checkpath issue reported. Acked-by: Ji, Kai > -Original Message- > From: Dooley, Brian > Sent: Monday, August 22, 2022 1:23 PM > To: Zhang, Roy Fan ; Dooley, Brian > > Cc: dev@dpdk.org; gmuthukri...@marvell.com; gak...@marvell.com; Ji, Kai >

RE: [PATCH] crypto/scheduler: fix qp_id in scheduler failover

2022-06-20 Thread Ji, Kai
> -Original Message- > From: Wysocki, JakubX > Sent: Monday, June 20, 2022 6:52 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Zhang, Roy Fan ; > Wysocki, JakubX > Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover > > This commit fixes wrong qp_id valu

RE: [EXT] [dpdk-dev v4 2/4] crypto/openssl: 3.0 EVP update on RSA routine

2022-06-21 Thread Ji, Kai
> -Original Message- > > --- a/drivers/crypto/openssl/rte_openssl_pmd.c > > +++ b/drivers/crypto/openssl/rte_openssl_pmd.c > > @@ -2046,6 +2046,150 @@ process_openssl_modexp_op(struct > rte_crypto_op > > *cop, } > > > > /* process rsa operations */ > > +#if (OPENSSL_VERSION_NUMBER >= 0

RE: [PATCH] test/crypto: fix cipher offset for ZUC tests

2022-06-21 Thread Ji, Kai
> -Original Message- > From: Power, Ciara > Sent: Tuesday, June 21, 2022 12:42 PM > To: Akhil Goyal ; Zhang, Roy Fan > > Cc: dev@dpdk.org; Ji, Kai ; Power, Ciara > ; De Lara Guarch, Pablo > ; sta...@dpdk.org > Subject: [PATCH] test/crypto: fix cipher offset fo

RE: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op

2022-07-05 Thread Ji, Kai
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, July 4, 2022 8:45 PM > To: Ji, Kai > Cc: dev@dpdk.org; gak...@marvell.com > Subject: Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa > op > > 30/06/2022 12:38, Kai Ji:

RE: [PATCH v4 0/1] crypto/openssl: add aes cmac support

2022-07-18 Thread Ji, Kai
Hi Ashwin, There is duplication of OPENSSL_VERSION_NUMBER check in v4, right before process_openssl_auth_mac(). Are you planning to enable CMAC unit test case in cryptodev_openssl_autotest ? Regards Kai > -Original Message- > From: Ashwin Sekhar T K > Sent: Monday, July 18, 2022 1

RE: [PATCH v5 1/1] crypto/openssl: support aes cmac operations

2022-07-18 Thread Ji, Kai
> -Original Message- > From: Ashwin Sekhar T K > Sent: Monday, July 18, 2022 5:25 PM > To: asek...@marvell.com > Cc: ano...@marvell.com; dev@dpdk.org; gak...@marvell.com; > hka...@marvell.com; jer...@marvell.com; kirankum...@marvell.com; > ndabilpu...@marvell.com; pbhagavat...@marvell.c

RE: [EXT] [dpdk-dev v1] crypto/qat: add in libcrypto version check

2022-07-26 Thread Ji, Kai
Thanks akhil, V2 here: http://patchwork.dpdk.org/project/dpdk/patch/20220726115608.84140-1-kai...@intel.com/ Regards Kai > -Original Message- > From: Akhil Goyal > Sent: Tuesday, July 26, 2022 11:14 AM > To: Ji, Kai ; dev@dpdk.org > Cc: Ashwin Sekhar Thalakalath Kotti

RE: [PATCH v4 1/3] cryptodev: move dh type from xform to dh op

2022-05-10 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Arek Kusztal > Sent: Wednesday, April 27, 2022 8:44 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 1/3] cryptodev: move dh type from xform to dh op > > Operation type (PUBLIC_KEY_

RE: [PATCH v4 0/3] cryptodev: move dh type from xform to dh op

2022-05-10 Thread Ji, Kai
Series-acked-by: Kai Ji > -Original Message- > From: Arek Kusztal > Sent: Wednesday, April 27, 2022 8:44 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH v4 0/3] cryptodev: move dh type from xform to dh op > > Operation type (PUBL

RE: [PATCH] crypto/qat: enable asymmetric crypto on gen4 device

2022-05-10 Thread Ji, Kai
Acked-by: Ji, Kai > -Original Message- > From: Arek Kusztal > Sent: Thursday, April 7, 2022 10:47 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: enable asymmetric crypto on gen4 device >

RE: [PATCH] crypto/openssl: fix memory free issue

2023-05-11 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Thursday, May 11, 2023 3:00 PM > To: Ji, Kai > Cc: dev@dpdk.org; O'Donovan, Saoirse ; > sta...@dpdk.org; Power, Ciara > Subject: [PATCH] crypto/openssl: fix memory free issue &g

RE: [PATCH v2 0/8] add AESNI_MB optimisations

2023-05-17 Thread Ji, Kai
Series-acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, May 16, 2023 4:24 PM > To: dev@dpdk.org > Cc: Ji, Kai ; gak...@marvell.com; Power, Ciara > > Subject: [PATCH v2 0/8] add AESNI_MB optimisations > > This patchset adds some opt

RE: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Wednesday, May 17, 2023 4:14 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH] crypto/ipsec_mb: fix allocating mb_mgr in session >

RE: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session

2023-05-17 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Wednesday, May 17, 2023 4:19 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session

RE: [PATCH] crypto/openssl: fix memory leak

2023-05-17 Thread Ji, Kai
...@marvell.com; Akhil Goyal ; Ji, Kai > ; Gowrishankar Muthukrishnan > Subject: [PATCH] crypto/openssl: fix memory leak > > Memory allocated through OPENSSL_malloc should be freed only through > OPENSSL_free. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > dr

Re: [PATCH v3] crypto/qat: default to IPsec MB for pre and post computes

2023-05-23 Thread Ji, Kai
Acked-by: Kai Ji From: Dooley, Brian Sent: Monday, May 22, 2023 15:39 To: Ji, Kai Cc: dev@dpdk.org ; gak...@marvell.com ; Dooley, Brian Subject: [PATCH v3] crypto/qat: default to IPsec MB for pre and post computes Pre and post computations currently use the

Re: [PATCH v2] crypto/qat: support to enable insecure algorithms

2023-05-23 Thread Ji, Kai
Acked-by: Kai Ji From: Poddar, Vikash ChandraX Sent: Tuesday, May 23, 2023 10:14 To: Akhil Goyal ; Fan Zhang ; Ji, Kai Cc: dev@dpdk.org ; Poddar, Vikash ChandraX Subject: [PATCH v2] crypto/qat: support to enable insecure algorithms All the insecure

Re: [PATCH] crypto/qat: fix build when no openssl exists

2023-10-27 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 27 October 2023 15:23 To: dev@dpdk.org Cc: Power, Ciara ; Dooley, Brian ; sta...@dpdk.org ; Ji, Kai Subject: [PATCH] crypto/qat: fix build when no openssl exists Previously some compi

Re: [PATCH] crypto/openssl: fix asym memory leaks

2023-11-06 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 03 November 2023 15:45 To: dev@dpdk.org Cc: Power, Ciara ; Ji, Kai ; gmuthukri...@marvell.com ; sunila.s...@caviumnetworks.com ; sta...@dpdk.org Subject: [PATCH] crypto/openssl: fi

Re: [PATCH 1/2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES CBC

2023-11-06 Thread Ji, Kai
Acked-by: Kai Ji From: Sivaramakrishnan, VenkatX Sent: 03 November 2023 13:30 To: Ji, Kai Cc: dev@dpdk.org ; sta...@dpdk.org ; gak...@marvell.com ; Sivaramakrishnan, VenkatX Subject: [PATCH 1/2] crypto/qat: fix block cipher misalignment for AES CBC and 3DES

Re: [PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment

2023-11-06 Thread Ji, Kai
Acked-by: Kai Ji From: Sivaramakrishnan Venkat Sent: 03 November 2023 13:30 To: Akhil Goyal ; Fan Zhang Cc: dev@dpdk.org ; sta...@dpdk.org ; Sivaramakrishnan, VenkatX Subject: [PATCH 2/2] test/crypto: add negative test cases for cipher buffer alignment add n

Re: [PATCH 2/2] crypto/openssl: remove unnecessary NULL checks before free

2023-11-07 Thread Ji, Kai
Acked-by: Kai Ji From: Stephen Hemminger Sent: 02 November 2023 23:02 To: dev@dpdk.org Cc: Stephen Hemminger ; Ji, Kai Subject: [PATCH 2/2] crypto/openssl: remove unnecessary NULL checks before free Found with nullfree.cocci Signed-off-by: Stephen Hemminger

Re: [PATCH v1] cryptodev: clarify usage of the block ciphers

2023-10-06 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 06 October 2023 14:06 To: dev@dpdk.org Cc: Ji, Kai ; Kusztal, ArkadiuszX ; Power, Ciara ; Akhil Goyal ; Fan Zhang Subject: [PATCH v1] cryptodev: clarify usage of the block ciphers

RE: [PATCH 1/3] examples/ipsec-secgw: fix auth IV length

2023-02-21 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 16, 2023 2:25 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; ano...@marvell.com; > g.si...@nxp.com; hemant.agra...@nxp.com; Ji, Kai ; > ruifeng.w...@arm.com; sunilprakashrao.uttar...

RE: [PATCH 2/3] examples/ipsec-secgw: check capabilities before session create

2023-02-21 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 16, 2023 2:25 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; ano...@marvell.com; > g.si...@nxp.com; hemant.agra...@nxp.com; Ji, Kai ; > ruifeng.w...@arm.com; sunilprakashrao.uttar...

RE: [PATCH 3/3] examples/ipsec-secgw: refactor inline capability check

2023-02-21 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 16, 2023 2:25 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; ano...@marvell.com; > g.si...@nxp.com; hemant.agra...@nxp.com; Ji, Kai ; > ruifeng.w...@arm.com; sunilprakashrao.uttar...

RE: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()

2023-02-28 Thread Ji, Kai
Is there any validation to this changes ? I Can't remember the exact reason why EEXIST returned, somehow we need to handle that case. Regards Kai > -Original Message- > From: Akhil Goyal > Sent: Monday, February 27, 2023 6:27 PM > To: Karas, Krzysztof ; Thoma

RE: [PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL

2023-03-07 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, March 7, 2023 5:18 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara ; > Akhil Goyal ; Fan Zhang > Subject: [PATCH 1/3] test/crypto: fix skip condition for CPU crypto SGL > > Wh

RE: [PATCH 0/3] cryptodev test improvements

2023-03-07 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, March 7, 2023 5:18 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara > Subject: [PATCH 0/3] cryptodev test improvements > > The meson driver-tests suite was missing some QAT and SW P

RE: [PATCH 0/3] cryptodev test improvements

2023-03-07 Thread Ji, Kai
Series-acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Tuesday, March 7, 2023 5:18 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara > Subject: [PATCH 0/3] cryptodev test improvements > > The meson driver-tests suite was missing some QAT a

Re: [PATCH] crypto/openssl: fix SM2 for older openssl version

2023-06-15 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 15 June 2023 09:03 To: dev@dpdk.org Cc: Power, Ciara ; gmuthukri...@marvell.com ; Ji, Kai Subject: [PATCH] crypto/openssl: fix SM2 for older openssl version Currently when configuri

Re: [EXT] [PATCH] crypto/openssl: add aes-xts support

2023-06-15 Thread Ji, Kai
Please take time to address Akhill's comments. Acked-by: Kai Ji mailto:kai...@intel.com>> From: Akhil Goyal Sent: 14 June 2023 19:51 To: Leung, Michael ; dev@dpdk.org ; Ji, Kai Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support ++Kai

Re: [PATCH] crypto/openssl: do not build useless workaround

2023-06-20 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Didier Pallard Sent: 18 April 2023 15:56 To: dev@dpdk.org Cc: sta...@dpdk.org ; Ji, Kai ; Mrzyglod, Daniel T ; Tomasz Kulasek ; Kobylinski, Michal ; De Lara Guarch, Pablo ; Mrozowicz, SlawomirX S

Re: [PATCH] crypto/openssl: fix memory leak in auth processing function

2023-06-20 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> > -Original Message- > From: Didier Pallard > Sent: Tuesday 18 April 2023 15:26 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Ji, Kai ; Akhil Goyal > ; Fan Zhang ; Ashwin > Sekhar T K > Subject: [PATCH] crypto/op

Re: ring name length simplification in ipsec_mb_qp_create_processed_ops_ring

2023-06-20 Thread Ji, Kai
Can you fix the commit messages with signed-off and Fixes Acked-by: Kai Ji mailto:kai...@intel.com>> From: Stephen Hemminger Sent: 31 May 2023 00:34 To: Fan Zhang Cc: dev@dpdk.org Subject: ring name length simplification in ipsec_mb_qp_create_processed_ops_rin

Re: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID

2023-07-04 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 30 June 2023 09:34 To: dev@dpdk.org Cc: Ji, Kai ; Power, Ciara ; De Lara Guarch, Pablo Subject: [PATCH] drivers/ipsec_mb: fix aesni_mb set session ID In the case of multiprocess, when th

Re: [PATCH] cryptodev: fix device socket ID type

2023-07-04 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 29 June 2023 14:21 To: dev@dpdk.org Cc: Ji, Kai ; Power, Ciara ; Matz, Olivier ; Akhil Goyal ; Fan Zhang Subject: [PATCH] cryptodev: fix device socket ID type The socket ID field

Re: [PATCH] crypto/ipsec_mb: fix jobs array used for burst

2023-07-05 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 05 July 2023 11:15 To: dev@dpdk.org Cc: gak...@marvell.com ; De Lara Guarch, Pablo ; Power, Ciara ; Cornu, Marcel D ; Ji, Kai Subject: [PATCH] crypto/ipsec_mb: fix jobs array used for

Re: [PATCH] app/crypto-perf: fix socket ID default value

2023-07-05 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Ciara Power Sent: 05 July 2023 11:30 To: dev@dpdk.org Cc: gak...@marvell.com ; Power, Ciara ; Matz, Olivier ; sta...@dpdk.org Subject: [PATCH] app/crypto-perf: fix socket ID default value Due to recent changes t

Re: [PATCH] crypto/qat: fix legacy sm4 ecb capability

2023-07-05 Thread Ji, Kai
Acked-by: Kai Ji mailto:kai...@intel.com>> From: Power, Ciara Sent: 05 July 2023 14:23 To: dev@dpdk.org Cc: Ji, Kai ; O'Donovan, Saoirse ; Power, Ciara Subject: [PATCH] crypto/qat: fix legacy sm4 ecb capability Following the deprecation of insecure

Re: [PATCH] doc: announce addition of new security IPsec SA option

2023-07-06 Thread Ji, Kai
Acked-by: Kai Ji From: Nithin Dabilpuram Sent: 01 July 2023 08:15 To: gak...@marvell.com Cc: jer...@marvell.com ; dev@dpdk.org ; Nithin Dabilpuram Subject: [PATCH] doc: announce addition of new security IPsec SA option Announce addition of new security IPsec S

Re: [PATCH v2] crypto/qat: fix gen3 legacy capabilities

2023-11-15 Thread Ji, Kai
Acked-by: Kai Ji From: Power, Ciara Sent: 15 November 2023 16:14 To: dev@dpdk.org Cc: Kusztal, ArkadiuszX ; Power, Ciara ; sta...@dpdk.org ; Ji, Kai Subject: [PATCH v2] crypto/qat: fix gen3 legacy capabilities When the legacy capability flag was enabled for

Re: [PATCH] crypto/ipsec_mb: fix getting process ID per job

2023-11-23 Thread Ji, Kai
Acked-by: Kai Ji From: Power, Ciara Sent: 23 November 2023 17:07 To: dev@dpdk.org Cc: tho...@monjalon.net ; Ji, Kai ; De Lara Guarch, Pablo ; Power, Ciara ; sta...@dpdk.org Subject: [PATCH] crypto/ipsec_mb: fix getting process ID per job Currently, when

Re: [PATCH v2] crypto/ipsec_mb: fix getting process ID per job

2023-11-23 Thread Ji, Kai
Acked-by: Kai Ji From: Power, Ciara Sent: 23 November 2023 17:15 To: dev@dpdk.org Cc: tho...@monjalon.net ; Ji, Kai ; De Lara Guarch, Pablo ; Power, Ciara ; sta...@dpdk.org Subject: [PATCH v2] crypto/ipsec_mb: fix getting process ID per job Currently, when

RE: [PATCH] app/crypto-perf: fix test file memory leak

2023-03-13 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, March 10, 2023 1:20 PM > To: dev@dpdk.org > Cc: Ji, Kai ; Power, Ciara ; > sta...@dpdk.org > Subject: [PATCH] app/crypto-perf: fix test file memory leak > > A memory leak was detected

RE: [PATCH v2] crypto/ipsec_mb: expect ENOTSUP

2023-03-14 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Karas, Krzysztof > Sent: Monday, March 13, 2023 12:01 PM > To: Thomas Monjalon ; Ji, Kai ; > De Lara Guarch, Pablo ; Kusztal, > ArkadiuszX > Cc: dev@dpdk.org; Karas, Krzysztof > Subject: [PATCH v2] crypto/

RE: [PATCH] app/compress-perf: fix remaining data for ops

2023-03-15 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, March 10, 2023 4:27 PM > Cc: dev@dpdk.org; Ji, Kai ; Kusztal, ArkadiuszX > ; michae...@nvidia.com; Power, Ciara > > Subject: [PATCH] app/compress-perf: fix remaining data for ops > &

RE: [PATCH v3 1/2] crypto/qat: add cipher-crc offload support to fw interface

2023-03-16 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: O'Sullivan, Kevin > Sent: Monday, March 13, 2023 2:26 PM > To: dev@dpdk.org > Cc: Ji, Kai ; O'Sullivan, Kevin > ; Coyle, David > Subject: [PATCH v3 1/2] crypto/qat: add cipher-crc offload support to fw &

RE: [PATCH v3 2/2] crypto/qat: add cipher-crc offload support

2023-03-16 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: O'Sullivan, Kevin > Sent: Monday, March 13, 2023 2:26 PM > To: dev@dpdk.org > Cc: Ji, Kai ; O'Sullivan, Kevin > ; Coyle, David > Subject: [PATCH v3 2/2] crypto/qat: add cipher-crc offload support > &g

RE: [PATCH 1/2] examples/ipsec-secgw: allow single xform SA

2023-03-16 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Radu Nicolau > Sent: Monday, March 13, 2023 12:30 PM > To: Nicolau, Radu ; Akhil Goyal > > Cc: dev@dpdk.org > Subject: [PATCH 1/2] examples/ipsec-secgw: allow single xform SA > > Update check capabilities before session create to allow sing

RE: [PATCH] crypto/scheduler: fix last element for valid args

2023-04-14 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, April 14, 2023 1:33 PM > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; > fanzhang@gmail.com; sta...@dpdk.org > Subject: [PATCH] crypto/scheduler: fix last element for valid args &

RE: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop

2023-04-14 Thread Ji, Kai
Acked-by: Kai Ji > -Original Message- > From: Power, Ciara > Sent: Friday, April 14, 2023 1:32 PM > To: Ji, Kai > Cc: dev@dpdk.org; Power, Ciara ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix stack buffer overflow in SGL loop > > The cvec pointer was in

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-24 Thread Ji, Kai
> -Original Message- > From: Akhil Goyal > Sent: Thursday, February 24, 2022 7:03 PM > To: Ji, Kai ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym > crypto routine > > > This patch update the symmetric EVP

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Ji, Kai
February 25, 2022 3:56 AM > To: Ji, Kai ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym > crypto routine > > Hi Kai, > > Hi Akhil, > > > > This patch was intend to support Openssl 3.0 on sy

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Ji, Kai
HI Akhil, > > When DPDK is compiled with openssl 3.0. I am seeing these errors in > compilation. > So, compilation is broken and we cannot take this patch as is. > We have few options, > - fix all of these errors, > - add exception in meson.build for ignoring these errors. > - disable/skip compi

RE: [dpdk-dev] crypto/qat: fix process type handling

2022-03-01 Thread Ji, Kai
Hi > This is not supposed to happen after rte_eal_init() is called. > > I have a doubt on Windows init because I can't see where > rte_config.process_type is initialised. > Are you seeing this issue on Windows? > > In any case, the commitlog needs more explanation. > > > -- > David Marchand

RE: [PATCH v2] crypto/ipsec_mb: fix usage of untrusted value

2022-03-09 Thread Ji, Kai
> > -Original Message- > > From: Bronowski, PiotrX > > Sent: Monday, March 7, 2022 3:33 PM > > To: dev@dpdk.org > > Cc: Zhang, Roy Fan ; tho...@monjalon.net; > > gak...@marvell.com; Yigit, Ferruh ; Doherty, > > Declan ; Bronowski, PiotrX > > ; sta...@dpdk.org > > Subject: [PATCH v2] crypto

Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structures

2021-10-11 Thread Ji, Kai
Hi Akhil, Just ran a quick mutli process test against the patch set, unfortunately it failed on the secondary process enqueue or dequeue. USER1: Configuring vector 0, using session 0 USER1: Start enqueuing packets on dev 0 qp 0 USER1: Start dequeuing packets on dev 0 qp 0 USER1: Enqueuing - Dequ

Re: [dpdk-dev] [PATCH v8 9/9] interrupts: extend event list

2021-10-28 Thread Ji, Kai
Hi Harman, This patch is causing QAT failed during interrupt init, the event list does not support interrupt count size zero in QAT case. There is also Bugzilla relate to this issue: https://bugs.dpdk.org/show_bug.cgi?id=843 Regards Kai > -Original Message- > From: dev On Behalf

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/cryptodev: fix incomplete data length

2021-11-08 Thread Ji, Kai
Hi Anoob, Please see my commit inline below. Thanks Kai > -Original Message- > From: Anoob Joseph > Sent: Monday, November 8, 2021 4:32 AM > To: Anoob Joseph ; Ji, Kai ; > dev@dpdk.org; Akhil Goyal > Cc: De Lara Guarch, Pablo ; > adamx.dybkow...@intel.com; Zhan

Re: [dpdk-dev] [PATCH] hash: fix thash gfni implementation

2021-11-09 Thread Ji, Kai
d along with GFNI. > This is done if the code is built on a platform that supports GFNI, but does > not > support AVX512. > > Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation") > Cc: vladimir.medved...@intel.com > > Signed-off-by: Vladimir Medvedkin Acked-by: Ji, Kai

Re: [dpdk-dev] [EXT] [PATCH v3 09/10] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-07 Thread Ji, Kai
Hi Ahkill, The addition chacha20-poly test was added for a more robust test case to cover oop sgl test scenario. Regards Kai > > Any specific reason to add new vectors for chacha poly? > Are the ones already present not enough? > > > +static uint8_t chacha_aad_2[] = { > > +

  1   2   >