Re: [PATCH 2/8] net/ring: build on Windows

2022-12-14 Thread Kadam, Pallavi
Hi Stephen, Thanks for enabling this support. On 11/30/2022 5:44 PM, Stephen Hemminger wrote: This driver builds ok on windows, but need to modify the test meson build to skip the eventdev test on Windows. Signed-off-by: Stephen Hemminger --- There is still a build error with clang compiler

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-11 Thread Kadam, Pallavi
On 8/9/2022 2:15 AM, Dmitry Kozlyuk wrote: 2022-08-08 17:33 (UTC-0700), Kadam, Pallavi: [...] Hi Pallavi, In the first place, it was wrong to always test `prev_bar & PCI_TYPE_64BIT` because only the first BAR slot of a 64-bit BAR contains flags. The current code has a state to track (curr

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-08 Thread Kadam, Pallavi
Hi Dmitry, On 8/6/2022 2:01 PM, Dmitry Kozlyuk wrote: 2022-08-02 12:10 (UTC-0700), Pallavi Kadam: For certain PCIe devices, BAR values are not continuous. This patch maps all the BARs and avoids skipping the next BAR addresses. Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driv

Re: [dpdk-kmods] windows/netuio: fix bar parsing

2022-08-08 Thread Kadam, Pallavi
Hi Dmitry, On 8/6/2022 2:01 PM, Dmitry Kozlyuk wrote: 2022-08-02 12:10 (UTC-0700), Pallavi Kadam: For certain PCIe devices, BAR values are not continuous. This patch maps all the BARs and avoids skipping the next BAR addresses. Fixes: e28aabd88279 ("windows/netuio: introduce NetUIO kernel driv

Re: [PATCH v2 5/6] eal/windows: fix the curly braces mismatch problem

2022-02-07 Thread Kadam, Pallavi
On 2/7/2022 4:37 AM, Weiguo Li wrote: Remove the incomplete cplusplus guard in internal header. Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation") Cc: pallavi.ka...@intel.com Signed-off-by: Weiguo Li --- Acked-by: Pallavi Kadam

Re: [PATCH v11 0/9] app/test: enable subset of tests on Windows

2021-12-03 Thread Kadam, Pallavi
On 12/2/2021 4:06 PM, Jie Zhou wrote: This patchset is to enable a subset of unit tests on windows. It mainly includes: - Replace POSIX specific codes - Add test stubs for not supported ones on Windows - Fix some lib and tests per failures investigation - Replace .sh script with .py script for

Re: [dpdk-dev] [PATCH] eal/windows: fix IOVA mode detection and handling

2021-10-25 Thread Kadam, Pallavi
On 10/25/2021 5:20 AM, Dmitry Kozlyuk wrote: Windows EAL did not detect IOVA mode and worked incorrectly if physical addresses could not be obtained (if virt2phys driver was missing or inaccessible). In this case, rte_mem_virt2iova() reported RTE_BAD_IOVA for any address. Inability to obtain IO

Re: [dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs

2021-10-11 Thread Kadam, Pallavi
Hi William, On 10/11/2021 11:49 AM, William Tu wrote: Add Intel Ethernet e1000 device IDs to netuio inf file. Signed-off-by: William Tu -- DPDK patch at: http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012...@gmail.com/T/#t --- windows/netuio/netuio.inf | 4 1 file changed, 4 insert

Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation

2021-10-11 Thread Kadam, Pallavi
On 10/9/2021 1:20 PM, Dmitry Kozlyuk wrote: 2021-10-09 12:38 (UTC-0700), Kadam, Pallavi: On 10/8/2021 2:11 PM, Dmitry Kozlyuk wrote: [...] +virt2phys +~ -1. From Device Manager, Action menu, select "Add legacy hardware". -2. It will launch the "Add Hardware Wizar

Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation

2021-10-09 Thread Kadam, Pallavi
On 10/8/2021 2:11 PM, Dmitry Kozlyuk wrote: Windows GSG included a section only on virt2phys driver installation, but not on NetUIO. The content of the section duplicated documentation in dpdk-kmods, but contained no links to it, only a reference. Add subsections for virt2phys and NetUIO, expl

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-09 Thread Kadam, Pallavi
On 10/8/2021 5:14 PM, William Tu wrote: On Fri, Oct 8, 2021 at 5:02 PM Kadam, Pallavi wrote: On 10/8/2021 6:53 AM, William Tu wrote: This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Kadam, Pallavi
On 10/8/2021 6:53 AM, William Tu wrote: This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3, verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-b

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Kadam, Pallavi
On 10/8/2021 9:08 AM, Wang, Haiyue wrote: -Original Message- From: William Tu Sent: Friday, October 8, 2021 21:54 To: dev@dpdk.org Cc: Kadam, Pallavi ; david.march...@redhat.com; Wang, Haiyue Subject: [PATCH v2] net/e1000: build on Windows This patch enables building the e1000

Re: [dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-05 Thread Kadam, Pallavi
On 10/5/2021 10:02 AM, William Tu wrote: This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- should we mention the added support in the

Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-30 Thread Kadam, Pallavi
On 9/30/2021 9:46 AM, Thomas Monjalon wrote: 10/09/2021 01:23, Pallavi Kadam: IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. This patch can be the first of this series to respect the dependency order. Fixes: 16f0d03098c

Re: [dpdk-dev] [PATCH 2/2] security: build on Windows

2021-09-29 Thread Kadam, Pallavi
On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman --- Depends-on: patch-98796 ("cryptodev: build on Windows") --- lib/meson.build | 1 + lib/security/version.map | 1 - 2 f

Re: [dpdk-dev] [PATCH v1] windows/netuio: add Intel 82599 10GbE VF device ID

2021-09-24 Thread Kadam, Pallavi
Hi William, On 9/22/2021 2:19 PM, William Tu wrote: Add Intel 82599 10GbE Ethernet adapter VF device IDs to netuio inf file in order to enable them on Windows. Signed-off-by: William Tu --- windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/windows/netuio/netuio

Re: [dpdk-dev] [PATCH] cryptodev: build on Windows

2021-09-23 Thread Kadam, Pallavi
On 9/13/2021 10:16 AM, Tal Shnaiderman wrote: Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman --- Acked-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH v2] net/iavf: enable interrupt polling

2021-09-14 Thread Kadam, Pallavi
On 8/25/2021 1:34 AM, Robin Zhang wrote: For VF hosted by Intel 700 series NICs, internal rx interrupt and adminq interrupt share the same source, that cause a lot cpu cycles be wasted on interrupt handler on rx path. The patch disable pci interrupt and remove the interrupt handler, replace it

Re: [dpdk-dev] [PATCH v2] eal/windows: ensure all enabled CPUs are counted

2021-08-04 Thread Kadam, Pallavi
On 6/29/2021 6:56 PM, Narcisa Ana Maria Vasile wrote: From: Narcisa Vasile rte_cpuset_t describes a set of CPUs by using an array of masks named '_bits'. Each element in the '_bits' array represents a bit mask, with each bit corresponding to a CPU. The maximum number of CPUs is given by 'CPU_

Re: [dpdk-dev] [PATCH 2/3] eal/windows: fix interrupt thread handle leakage

2021-05-12 Thread Kadam, Pallavi
On 5/1/2021 7:33 PM, Dmitry Kozlyuk wrote: Each time a work was scheduled in the interrupt thread, usually an alarm, a handle was opened but not closed. Opening a handle is a system call, which harms alarm precision. Instead of opening and closing a handle each time, open it when interrupt thr

Re: [dpdk-dev] [PATCH v10 00/10] app/testpmd: enable testpmd on Windows

2021-05-04 Thread Kadam, Pallavi
On 5/3/2021 5:33 PM, Jie Zhou wrote: This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name colli

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-03-31 Thread Kadam, Pallavi
On 3/19/2021 9:51 AM, Jie Zhou wrote: From: Jie Zhou This patch is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that TestPMD depends on - Enable building testpmd on Windows - Resolve name collisions with Windows types - Add clock_gettime_monotic for

Re: [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:41 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: Enable IAVF driver to build on Windows as it is required to build ice PMD. Disable all other drivers from common directory. This patch also includes fix for a macro redefinition warning in the IAVF driver. Si

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:58 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: - Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API

Re: [dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package on Windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:53 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: Disable loading of external DDP package as it is not supported on Windows. Should this be documented in driver documentation as Windows support limitation? We have mentioned about it in Windows prerequis

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows

2021-03-27 Thread Kadam, Pallavi
On 3/26/2021 4:51 AM, Ferruh Yigit wrote: On 3/11/2021 1:58 AM, Pallavi Kadam wrote: - Add Intel ice PMD support on Windows. - Remove #include sys/ioctl header file as it is not needed. - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. - Replace POSIX usleep() API

Re: [dpdk-dev] [PATCH v2] bus/pci: fix probing for non-netuio bound devices

2021-03-17 Thread Kadam, Pallavi
On 3/16/2021 4:20 AM, Thomas Monjalon wrote: Implement rte_pci_map_device() to distinguish between the devices bound to netuio and NDIS devices. Only return success for the netuio devices. v2 changes: - Extended the comment to mention about mapping - replaced the return errno

Re: [dpdk-dev] [PATCH 2/4] net/ice: build on Windows

2021-03-08 Thread Kadam, Pallavi
Hi David On 3/4/2021 4:56 AM, David Marchand wrote: On Wed, Mar 3, 2021 at 10:27 PM Pallavi Kadam wrote: Add Intel ice PMD support on Windows. Remove #include sys/ioctl header file as it is not needed. Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types. Replace POSIX

Re: [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package on Windows

2021-03-04 Thread Kadam, Pallavi
Hi Dmitry, On 3/3/2021 3:12 PM, Dmitry Kozlyuk wrote: 2021-03-03 13:59, Pallavi Kadam: Disable loading of private DDP packages in ice PMD on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- drivers/net/ice/ice_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) Are DD

Re: [dpdk-dev] [PATCH 4/4] doc: update ice PMD and 21.05 release notes

2021-03-04 Thread Kadam, Pallavi
On 3/3/2021 3:13 PM, Dmitry Kozlyuk wrote: 2021-03-03 13:59, Pallavi Kadam: Add documentation to support ice PMD on Windows. Update the release notes and features list for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/features/ice.ini | 1 +

Re: [dpdk-dev] [PATCH] bus/pci: fix probing for non-netuio bound devices

2021-02-10 Thread Kadam, Pallavi
On 2/9/2021 10:00 PM, Tal Shnaiderman wrote: Subject: [PATCH] bus/pci: fix probing for non-netuio bound devices External email: Use caution opening links or attachments Implement rte_pci_map_device() to distinguish between the devices bound to netuio and NDIS devices. Only return success for

Re: [dpdk-dev] [PATCH v2] doc: update i40e PMD to support on windows

2021-02-02 Thread Kadam, Pallavi
On 2/2/2021 4:21 AM, Ferruh Yigit wrote: On 1/26/2021 11:03 PM, Pallavi Kadam wrote: Add documentation to support i40e PMD on Windows. Update the release notes and features list for the same. v2 changes: - updated doc/guides/nics/features/i40e.ini file - Replaced the name UIO with Net

Re: [dpdk-dev] [PATCH v3 0/2] fix mingw build error

2021-01-27 Thread Kadam, Pallavi
On 1/27/2021 6:27 AM, Leyi Rong wrote: This patchset fix mingw build error when avx512 is introduced. --- Tested-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH] net/i40e: fix mingw build error

2021-01-26 Thread Kadam, Pallavi
On 1/26/2021 7:38 AM, Leyi Rong wrote: Disable i40e avx512 code path for windows build to avoid the mingw build error. Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path") Signed-off-by: Leyi Rong --- Tested-by: Pallavi Kadam Verified on Windows using MinGW and clang compiler.

Re: [dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

2021-01-22 Thread Kadam, Pallavi
On 1/22/2021 3:16 AM, Thomas Monjalon wrote: 21/01/2021 20:09, Pallavi Kadam: Add documentation to support i40e PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/i40e.rst | 16 ++--

Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

2021-01-20 Thread Kadam, Pallavi
On 1/20/2021 11:21 PM, Ferruh Yigit wrote: On 1/20/2021 10:05 AM, Ali Alnubani wrote: For info, I don't reproduce the compilation issue on my machine. My build system has been upgraded from fc31 to fc32 so I guess this has something to do with it. I can reproduce with (Fedora MinGW 9.2.1-

Re: [dpdk-dev] [PATCH v2 1/2] eal: add rte_random.c file on windows

2020-12-18 Thread Kadam, Pallavi
On 12/18/2020 3:29 AM, Thomas Monjalon wrote: 17/12/2020 23:59, Pallavi Kadam: This file is required to compile and build i40e PMD on Windows. Add rte_rand variable to export file. Redefine _m_prefetchw for Clang toolchain due to following error with respect to conflicting types: FAILED: lib

Re: [dpdk-dev] [PATCH v2 2/2] build: i40e PMD on Windows

2020-12-18 Thread Kadam, Pallavi
Hi Thomas, On 12/18/2020 3:27 AM, Thomas Monjalon wrote: 17/12/2020 23:59, Pallavi Kadam: Adds temp folder mlx5/windows as it is required to build this patch without any build error. This folder will be removed once mlx5 PMD patches are merged. Why is it required? The patch [1] already suppo

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-17 Thread Kadam, Pallavi
On 12/9/2020 12:59 AM, Thomas Monjalon wrote: 09/12/2020 01:21, Kadam, Pallavi: On 12/6/2020 7:49 AM, Thomas Monjalon wrote: 05/12/2020 02:10, Pallavi Kadam: --- a/lib/librte_eal/windows/include/rte_windows.h +++ b/lib/librte_eal/windows/include/rte_windows.h @@ -18,6 +18,11 @@ #define

Re: [dpdk-dev] [PATCH 3/3] config/build: ignore enum forward reference warning

2020-12-17 Thread Kadam, Pallavi
On 12/9/2020 4:53 PM, Narcisa Ana Maria Vasile wrote: On Fri, Dec 04, 2020 at 05:10:20PM -0800, Pallavi Kadam wrote: Warning generated using Clang compiler: ..\drivers\net\i40e\base/i40e_osdep.h:34:14: warning: forward references to 'enum' types are a Microsoft extension [-Wmicrosoft-enum-forw

Re: [dpdk-dev] [PATCH] eal/windows: add interrupt functions stub

2020-12-14 Thread Kadam, Pallavi
Hi Dmitry, On 12/11/2020 1:07 PM, Dmitry Kozlyuk wrote: On Thu, 10 Dec 2020 16:26:07 -0800, Pallavi Kadam wrote: Add some missing interrupt implementations on Windows. Also add respestive functions to export file. Signed-off-by: Tal Shnaiderman Signed-off-by: Pallavi Kadam Reviewed-by: Ranji

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-08 Thread Kadam, Pallavi
On 12/6/2020 7:49 AM, Thomas Monjalon wrote: 05/12/2020 02:10, Pallavi Kadam: --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -1,9 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation -if is_windows - subdir_done() -endif drive

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-08 Thread Kadam, Pallavi
On 12/7/2020 1:14 AM, Bruce Richardson wrote: On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote: 05/12/2020 02:10, Pallavi Kadam: --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -1,9 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Cor

Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

2020-12-08 Thread Kadam, Pallavi
On 12/5/2020 5:52 AM, Dmitry Kozlyuk wrote: On Fri, 4 Dec 2020 17:10:19 -0800, Pallavi Kadam wrote: You could drop "add changes" and "i40e PMD" from subject line, as any commit changes something and topic is "net/i40e" already. Adding build changes to compile i40e PMD on windows. This is r

Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register

2020-12-04 Thread Kadam, Pallavi
On 11/26/2020 12:06 AM, Tal Shnaiderman wrote: interrupt callback register is not implemented in Windows. Add stub with -ENOTSUP return value and export the function. Signed-off-by: Tal Shnaiderman --- Acked-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register

2020-12-04 Thread Kadam, Pallavi
Hi Tal, On 11/26/2020 12:06 AM, Tal Shnaiderman wrote: interrupt callback register is not implemented in Windows. Add stub with -ENOTSUP return value and export the function. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/eal_interru

Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang

2020-12-04 Thread Kadam, Pallavi
Hi Nick, Thanks for this patch. Could not see the deprecated warnings anymore. On 11/29/2020 8:00 AM, Nick Connolly wrote: Microsoft CRT defines Windows-specific secure alternatives to standard library functions and triggers warnings when "insecure" functions are used [1]. However, calling code

Re: [dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang

2020-12-04 Thread Kadam, Pallavi
On 11/29/2020 5:00 AM, Nick Connolly wrote: When building with clang (11.0,--buildtype=debug), eal_lcore.c produces a -Wformat-nonliteral warning from the vfprintf call in log_early. Add __rte_format_printf annotation. Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection") C

Re: [dpdk-dev] [PATCH v2] eal/windows: fix deadlock when setting alarm

2020-10-30 Thread Kadam, Pallavi
On 10/30/2020 11:42 AM, Dmitry Kozlyuk wrote: Windows alarms are both armed and executed from the interrupt thread. rte_eal_alarm_set() dispatched alarm-arming code to that thread and waited for its completion via a spinlock. However, if called from alarm callback (i.e. from the interrupt threa

Re: [dpdk-dev] [PATCH] eal: create a runtime directory on windows

2020-10-26 Thread Kadam, Pallavi
Hi Dmitry, On 10/22/2020 12:05 PM, Dmitry Kozlyuk wrote: /* Detect if we are a primary or a secondary process */ enum rte_proc_type_t eal_proc_type_detect(void) @@ -181,6 +231,13 @@ eal_parse_args(int argc, char **argv) } } + /* create runtime data directory */

Re: [dpdk-dev] [PATCH v6 1/4] rcu: build on Windows

2020-10-22 Thread Kadam, Pallavi
On 10/21/2020 3:50 PM, Dharmik Thakkar wrote: Build the lib for Windows. Signed-off-by: Dharmik Thakkar Tested-by: Dmitry Kozlyuk --- Builds successfully on Windows. Tested-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH v5] bus/pci: netuio interface for windows

2020-10-06 Thread Kadam, Pallavi
On 9/29/2020 1:28 AM, Tal Shnaiderman wrote: Subject: [PATCH v5] bus/pci: netuio interface for windows This patch adds implementations to probe PCI devices bound to netuio with the help of "netuio" class device changes. Now Windows will support both "netuio" and "net" device class and can set

Re: [dpdk-dev] [PATCH] hash: build on Windows

2020-10-01 Thread Kadam, Pallavi
On 10/1/2020 8:30 AM, Tal Shnaiderman wrote: From: Ophir Munk Build the lib for Windows. Export the needed function from eal. Signed-off-by: Ophir Munk Signed-off-by: Tal Shnaiderman --- Tested-by: Pallavi Kadam Acked-by: Pallavi Kadam

Re: [dpdk-dev] [PATCH] eal/windows: use bundled getopt with MinGW

2020-09-28 Thread Kadam, Pallavi
On 9/24/2020 4:17 PM, Dmitry Kozlyuk wrote: Clang builds use getopt.c in librte_eal while MinGW provides implementation as part of the toolchain. Statically linking librte_eal to an application that depends on getopt results in undefined reference errors with MinGW. There are no such errors wit

Re: [dpdk-dev] [PATCH 0/7] cmdline: support Windows

2020-07-30 Thread Kadam, Pallavi
Hi Dmitry, On 6/20/2020 2:05 PM, Dmitry Kozlyuk wrote: This patchset enables librte_cmdline on Windows. To do that, it creates a number of wrappers for OS-dependent terminal handling and I/O. Considered alternative was to revive [1] and use libedit (Unix-only) for terminal handling. However, t

Re: [dpdk-dev] [PATCH v4 0/3] compile librte_net for windows

2020-07-24 Thread Kadam, Pallavi
On 7/23/2020 12:08 AM, Fady Bader wrote: v2: * fixed style issue. v3: * replaced htons with rte_cpu_to_be_16. * rebased to current master. v4: * removed the use of rte_random in librte_net. * replaced htons with RTE_BE16. Fady Bader (3): net: fix s_addr redefinition in Windows

Re: [dpdk-dev] [PATCH v2 0/2] Windows bus/vdev support

2020-07-20 Thread Kadam, Pallavi
On 7/7/2020 1:48 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman This patchset implements the EAL functions needed for probing PMDs using vdev on Windows. --- v2: Added missing exports and includes (NarcisaV) --- Tal Shnaiderman (2): eal/windows: add needed calls to detect vdev PM

Re: [dpdk-dev] [PATCH 0/3] improve MinGW-w64 support

2020-06-22 Thread Kadam, Pallavi
On 6/20/2020 3:35 PM, Dmitry Kozlyuk wrote: Following the discussion on the mailing list [1], clarify MinGW-w64 installation process and stop linking with pthread on Windows. Make Meson cross-file more general along the way. [1]: https://mails.dpdk.org/archives/dev/2020-June/170252.html Dmit

Re: [dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows

2020-06-11 Thread Kadam, Pallavi
On 6/11/2020 9:14 AM, Thomas Monjalon wrote: 29/05/2020 01:14, Pallavi Kadam: Fixed bunch of warnings when compiling using clang on Windows such as the use of an unsafe string function (strerror), [-Wunused-variable], [-Wunused-function] in eal_common_options.c [-Wunused-const-variable] in ge

Re: [dpdk-dev] [PATCH v3 2/2] build: treat warning as an error on Windows

2020-06-11 Thread Kadam, Pallavi
On 6/11/2020 9:12 AM, Thomas Monjalon wrote: 29/05/2020 01:14, Pallavi Kadam: Added -Werror in meson file to consider all the warnings as errors on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- --- a/config/meson.build +++ b/config/meson.build +# add -Werror to treat

Re: [dpdk-dev] [PATCH 0/2] Windows logging

2020-04-30 Thread Kadam, Pallavi
On 4/29/2020 11:48 PM, Thomas Monjalon wrote: 30/04/2020 01:24, Pallavi Kadam: This patchset adds EAL logging support on Windows. Logs will be sent to console output. Pallavi Kadam (2): eal: initialize eal logging on Windows eal: add fnmatch implementation on Windows fnmatch is requi

Re: [dpdk-dev] [PATCH v3 00/10] Windows basic memory management

2020-04-14 Thread Kadam, Pallavi
On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote: Note: no changes in cover letter since v2. This patchset implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * Only 2MB hugepages are supported. * IOVA is always PA, obtained through kernel-mode dri

Re: [dpdk-dev] [PATCH v4 0/7] MinGW-w64 support

2020-03-11 Thread Kadam, Pallavi
On 2/26/2020 8:25 PM, Dmitry Kozlyuk wrote: This patch series add support for building DPDK using MinGW-w64. MinGW-w64 provides GNU toolchain and independent platform SDK on Windows. It also supports cross-compilation to Windows from POSIX systems by providing cross tollchains and libraries [