Python 3.5 subprocess.run() does not have a capture_output
parameter (it is present only in 3.7 and up). Capture output
by using subprocess.PIPE for stdout instead.
Fixes: bb9cd91095b3 ("buildtools: make AVX512 check portable")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
On Thu, Dec 16, 2021 at 12:33 PM Bruce Richardson
wrote:
>
> On Thu, Dec 16, 2021 at 11:34:25AM -0500, Lance Richardson wrote:
> > On Thu, Dec 16, 2021 at 11:20 AM Bruce Richardson
> > wrote:
> > >
> > > On Thu, Dec 16, 2021 at 11:04:54AM -0500, Lanc
On Thu, Dec 16, 2021 at 11:20 AM Bruce Richardson
wrote:
>
> On Thu, Dec 16, 2021 at 11:04:54AM -0500, Lance Richardson wrote:
> > Hi Bruce,
> >
> > I've been looking into using the IOAT PMD, initially with dma_autotest
> > and the dpdk-dma example application.
Hi Bruce,
I've been looking into using the IOAT PMD, initially with dma_autotest
and the dpdk-dma example application. These seem to work fine on
SKX with the current main branch, but when I try the same procedure
on ICX (binding all 8 devices to vfio-pci in both cases), I get the following
output
() in accordance with this
requirement.
Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
drivers/net/bnxt/bnxt_stats.c | 93 +--
1 file changed, 46 insertions(+), 47 deletions(-)
diff --gi
.@dpdk.org
Signed-off-by: Lance Richardson
---
drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c
b/drivers/net/bnxt/bnxt_rxtx_vec_avx2.c
index 54e3af22ac..34bd22edf0 100644
--- a/drivers/net/bnxt/bnxt_rxt
roved by about
3-4% if we ensure that at least one packet can be received
before entering the inner loop.
Fixes: c4e4c18963b0 ("net/bnxt: add AVX2 RX/Tx")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 4
1 file changed, 4 insertions
This series contains two minor performance fixes for the
bnxt AVX2 vecgtorized burst receive function.
Lance Richardson (2):
net/bnxt: avoid unnecessary work in AVX2 Rx path
net/bnxt: remove software prefetches from AVX2 Rx path
drivers/net/bnxt/bnxt_rxtx_vec_avx2.c | 16 +++-
1
Based on the CI build logs, the target architecture was Skylake, which
supports AVX512 but doesn't support GFNI.
On Tue, Nov 9, 2021 at 11:15 AM Thomas Monjalon wrote:
>
> 09/11/2021 17:12, Lance Richardson:
> > Do the machines used for the CentOS 8 CI builds support AVX512?
>
1 at 4:53 PM Lance Richardson
> > wrote:
> > >
> > > 21.11-rc2 builds are failing on CentOS 8.4, apparently because
> > > the intrinsic _mm512_set_epi8() is not defined in the GCC
> > > headers (see example below).
> >
> > Thanks for reporti
Minor corrections and improvements to documentation
for checksum APIs.
Fixes: 6006818cfb26 ("net: new checksum functions")
Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 checksums")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
v2:
- Updates for r
On Tue, Sep 21, 2021 at 6:11 AM Morten Brørup
wrote:
> Ferruh, the description of the return value is technically correct; it
> mentions the IP packet, not the IP header.
> So this change is a clarification only.
>
> However, I agree that the same clarification would also benefit
> 'rte_ipv4_ud
Minor corrections and improvements to documentation
for checksum APIs.
Fixes: 6006818cfb26 ("net: new checksum functions")
Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 checksums")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
lib/net/rte_ip.h
Since the addition of support for runtime queue setup,
receive queues that are started by default no longer
have the correct state. Fix this by setting the state
when a port is started.
Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup")
Signed-off-by: Lance Richardson
R
On Mon, Sep 13, 2021 at 11:51 AM Stephen Hemminger
wrote:
>
> On Mon, 13 Sep 2021 16:43:18 +0100
> Ferruh Yigit wrote:
>
> > On 9/13/2021 5:56 AM, Kamaraj P wrote:
> > > Hello All,
> > >
> > > Would like to understand or if there are any guidelines to allocate the
> > > max
> > > no of mbuf per
On Tue, Jul 13, 2021 at 5:48 AM Kevin Traynor wrote:
>
> On 12/07/2021 18:34, Honnappa Nagarahalli wrote:
> >
> >
> >>
> >> Hi,
> >>
> >> I would like to open a discussion about RHEL 7 support in DPDK.
> >> How long do we want to support it in new DPDK versions?
> >> Can we drop RHEL 7 support st
s: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Khaparde
---
v2:
* Corrected name of the first parameter to bnxt_cpr_cmp_valid() in
comments ('cmp' to 'cmpl').
drivers/net/bnxt/bnxt_cpr.h
On Fri, Jul 9, 2021 at 4:48 AM Thomas Monjalon wrote:
>
> 09/07/2021 00:49, Ajit Khaparde:
> > Fix build failures because of uninitialized variable usage.
>
> You should add the error log here.
> You don't mention the condition of failure.
> Nobody reproduced a failure so far.
Hi Thomas,
This ad
On Fri, Jul 9, 2021 at 2:00 AM Ruifeng Wang wrote:
>
> > +/**
> > + * Check validity of a completion ring entry. If the entry is valid,
> > include a
> > + * C11 __ATOMIC_ACQUIRE fence to ensure that subsequent loads of fields
> > in the
> > + * completion are not hoisted by the compiler or by t
s: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_cpr.h | 36 ---
drivers/net/bnxt/bnxt_ethdev.c| 16 ++--
drivers/net/bnxt/
On Thu, Jul 8, 2021 at 8:09 AM Zhang, Qi Z wrote:
>
>
>
> > -Original Message-
> > From: Joyce Kong
> > Sent: Tuesday, July 6, 2021 2:54 PM
> > To: Xing, Beilei ; Zhang, Qi Z
> > ;
> > ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; Richardson, Bruce
> > ; Zhang, Helin
> > Cc: dev@d
On Tue, May 11, 2021 at 10:42 AM Lance Richardson
wrote:
>
> On Tue, May 11, 2021 at 10:31 AM David Marchand
> wrote:
> >
> > On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
> > wrote:
> > >
> > > Fix two issues found when writing PMD unit tes
Code related to maintaining completion ring "valid" state is
no longer needed, remove it.
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Khaparde
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_cpr.h | 17 -
drivers/net/bnxt/bnxt_hwrm.c
Several fixes for the bnxt PMD:
- Fix NUMA-aware memory allocations.
- Fix transmit descriptor status implementation.
- Fix handling of transmit completions in non-vector path.
- Remove dead code.
Lance Richardson (4):
net/bnxt: fix ring and context memory allocation
net/bnxt: fix
Preserve the raw (unmasked) transmit completion ring
consumer index.
Remove cache prefetches that have no measurable performance
benefit.
Fixes: c7de4195cc4c ("net/bnxt: modify ring index logic")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Khaparde
---
d
("net/bnxt: support Tx batching")
Fixes: 478ed3bb7b9d "(net/bnxt: support Tx descriptor status")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 54 +++---
1 file changed, 31 inserti
ot;)
Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs")
Fixes: f8168ca0e690 ("net/bnxt: support thor controller")
Fixes: bd0a14c99f65 ("net/bnxt: use dedicated CPR for async events")
Fixes: 683e5cf79249 ("net/bnxt: use common NQ ring")
Cc: sta...@dpd
On Mon, May 24, 2021 at 3:00 PM Lance Richardson
wrote:
>
> Implement AVX2 vector PMD.
>
There are CI test failures for this patch series that appear be
unrelated, are these
known/expected failures?
>From http://mails.dpdk.org/archives/test-report/2021-May/196470.html
Ubun
-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_rxr.c | 34 +++--
drivers/net/bnxt/bnxt_rxr.h | 43 ++-
drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 19
drivers/net/bnxt/bnxt_rxtx_vec_sse.c
Implement AVX2 vector PMD.
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Khaparde
---
doc/guides/nics/bnxt.rst | 57 ++-
drivers/net/bnxt/bnxt_ethdev.c| 119 +++--
drivers/net/bnxt/bnxt_rxr.c | 4 +-
drivers/net/bnxt/bnxt_rxr.h | 11 +-
drivers
mode")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 29 +--
drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 29 +--
2 files changed, 46 insertions(+), 12 deletions(-)
diff --gi
Vector mode updates for the bnxt PMD.
Lance Richardson (3):
net/bnxt: refactor HW ptype mapping table
net/bnxt: fix Rx burst size constraint
net/bnxt: add AVX2 vector PMD
doc/guides/nics/bnxt.rst | 57 ++-
drivers/net/bnxt/bnxt_ethdev.c| 119 +++--
drivers/net/bnxt
> v4: Identical to v1, with now included in rte_eal_paging.h
> to (hopefully) make off_t available for Windows builds.
With this version, using off_t is no longer a problem, however based on the
new compilation error it appears that for Windows, off_t is a 32-bit type
while size_t is a 64-b
attempting to run 32-bit Linux dpdk-testpmd
using VFIO driver:
EAL: pci_map_resource(): cannot map resource(63, 0xc001, \
0x20, 0x200): Invalid argument ((nil))
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: sta...@dpdk.org
Signed-off-by: Lance
On Tue, May 11, 2021 at 10:31 AM David Marchand
wrote:
>
> On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
> wrote:
> >
> > Fix two issues found when writing PMD unit tests for HW ptype and
> > L4 checksum offload:
>
> Would those unit tests be interesting to ot
On Tue, May 11, 2021 at 4:18 AM Thomas Monjalon wrote:
>
> 08/05/2021 16:27, Lance Richardson:
> > For 32-bit targets, size_t is normally a 32-bit type and
> > does not have sufficient range to represent 64-bit offsets
> > that can are needed when mapping PCI addresses.
On Mon, May 10, 2021 at 11:55 AM Thomas Monjalon
wrote:
> 10/05/2021 17:31, Burakov, Anatoly:
> > On 10-May-21 1:42 PM, Thomas Monjalon wrote:
> > > +Cc Anatoly
> > >
> > > 08/05/2021 16:27, Lance Richardson:
> > >> For 32-bit targets, size_t is
map resource(63, 0xc001, \
0x20, 0x200): Invalid argument ((nil))
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
v3: Use PRIx64 instead of llx to format offset in log message.
v2: Use uint64_t
map resource(63, 0xc001, \
0x20, 0x200): Invalid argument ((nil))
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
v3: Use PRIx64 instead of llx to format offset in log message.
v2: Use uint64_t
On Fri, May 7, 2021 at 4:51 PM Dmitry Kozlyuk wrote:
>
> 2021-05-07 15:06 (UTC-0400), Lance Richardson:
> [...]
> > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> > index ec7156df96..41a94a7511 100644
> > --- a/lib/eal/unix/eal_unix_memo
map resource(63, 0xc001, \
0x20, 0x200): Invalid argument ((nil))
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
v2: Use uint64_t instead of off_t (off_t is unknown to Windows).
lib/e
> Windows compilation is failing in CI, apparently Windows doesn't
> understand "off_t".
>
> Should we add an "rte_off_t" definition for non-POSIX portability?
On second thought, it's probably better to simply use uint64_t.
On Fri, May 7, 2021 at 2:10 PM Lance Richardson
wrote:
>
> For 32-bit targets, size_t is normally a 32-bit type and
> does not have sufficient range to represent 64-bit offsets
> that can are needed when mapping PCI addresses. Use off_t
> instead, which is usually a 64-bit type whe
attempting to run 32-bit Linux dpdk-testpmd
using VFIO driver:
EAL: pci_map_resource(): cannot map resource(63, 0xc001, \
0x20, 0x200): Invalid argument ((nil))
Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
Cc: sta...@dpdk.org
Signed-off-by: Lance
On Thu, Apr 29, 2021 at 9:43 AM Lance Richardson
wrote:
>
> On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson
> wrote:
> >
> > Initialize filter structure to all zeroes on allocation.
> >
> > Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops"
On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson
wrote:
>
> Initialize filter structure to all zeroes on allocation.
>
> Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
> Cc: sta...@dpdk.org
> Signed-off-by: Lance Richardson
> Reviewed-by: Ajit Kumar Khap
ted.
> * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
> */
> -#define PKT_RX_EIP_CKSUM_BAD PKT_RX_OUTER_IP_CKSUM_BAD
> +#define PKT_RX_EIP_CKSUM_BAD \
> + RTE_DEPRECATED(PKT_RX_EIP_CKSUM_BAD) PKT_RX_OUTER_IP_CKSUM_BAD
>
> /**
> * A vlan has been stripped by the hardware and its tci is saved in
> --
> 2.23.0
>
Acked-by: Lance Richardson
net/bnxt: allow flow creation when RSS is enabled")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt.h | 2 +-
drivers/net/bnxt/bnxt_flow.c | 5 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/
Initialize filter structure to all zeroes on allocation.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Initialize TCP data offset field with TCP header length, this
field is used to derive L4 header length and by hardware to
validate a TCP header.
Fixes: 41f72ec94074 ("test: add packet burst generator functions")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
initialized using host byte
order, which (among other things) resulted in incorrect L4
checksum computation. The payload_len field is now set using
network (big-endian) byte order.
Fixes: 92073ef961ee ("bond: unit tests")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
On Fri, Mar 19, 2021 at 12:07 PM Stephen Hemminger
wrote:
>
> On Fri, 19 Mar 2021 20:13:20 +0800
> "Min Hu (Connor)" wrote:
>
> > Hi, all,
> > DPDK has introduced one offload: DEV_RX_OFFLOAD_KEEP_CRC. It means
> > that
> > the device has the ablility of keeping CRC（four bytes at the end of
ue size without aggregation ring")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_rxr.c | 3 ---
drivers/net/bnxt/bnxt_rxr.h | 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rx
When the mask field of an rte_flow pattern item is NULL,
the default mask for that item type should be used.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
drivers/net/bnxt/bnxt_f
Use correct threshold when selecting "greater than or equal to
2K" length hint.
Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_
On Fri, Mar 5, 2021 at 7:05 PM Dmitry Kozlyuk wrote:
>
> POSIX asprintf() is unavailable on Windows.
AFAIK asprintf() is not a POSIX API, it is a GNU extension that has
also been implemented in some BSDs.
> Add eal_asprintf() wrapper for EAL internal use.
> On Windows it's a function, on Unix it
Avoid copying mbuf pointers to separate array for bulk
mbuf free when handling transmit completions for vector
mode transmit.
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 4 +-
drivers/net/bnxt/bnxt_ring.c| 2
On Tue, Mar 2, 2021 at 9:29 AM Lance Richardson
wrote:
>
> Fix a number of issues in the bnxt receive descriptor status
> function, including:
>- Provide status of receive descriptor instead of completion
> descriptor.
>- Remove invalid comparison of raw ring inde
Remove code for setting consumed mbuf pointers to NULL from the
vector receive functions as a minor performance optimization.
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_rxq.c | 10 ++
drivers/net/bnxt
ring index.
- Correct misuse of completion ring index for mbuf ring (the
two rings have different sizes).
Fixes: 0fe613bb87b2 ("net/bnxt: support Rx descriptor status")
Signed-off-by: Lance Richardson
Cc: sta...@dpdk.org
Reviewed-by: Andy Gospodarek
Reviewed-by: Ajit Kuma
Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and
deprecate the original name. The new name is better aligned
with existing PKT_RX_OUTER_* flags, which should help reduce
confusion about its use.
Suggested-by: Ferruh Yigit
Signed-off-by: Lance Richardson
---
v2:
- Added deprecation
Rename PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD and
deprecate the original name. The new name is better aligned
with existing PKT_RX_OUTER_* flags, which should help reduce
confusion about its purpose.
Suggested-by: Ferruh Yigit
Signed-off-by: Lance Richardson
---
app/test-pmd
> Lance, can you spare some time to make the above mentioned patch?
Sure. Are you looking for something like the changes below, or also including
a search and replace of the deprecated macro name with the new one?
- /** External IP header checksum error. */
+/**
+ * Deprecated.
+ * This flag has
completion types.
Fixes: 34c0ba839bae ("net/bnxt: fix Rx queue count")
Signed-off-by: Lance Richardson
Reviewed-by: Somnath Kotur
Cc: sta...@dpdk.org
---
drivers/net/bnxt/bnxt_cpr.h| 4
drivers/net/bnxt/bnxt_ethdev.c | 38 +-
drivers/net/bnxt/bnxt_rxr
Add support for displaying the count of used (filled by hardware
but not yet processed by the driver) descriptors on a receive
queue in order to allow the rte_eth_dev rx_queue_count() API to
be exercised and tested.
Signed-off-by: Lance Richardson
---
v3:
- Made terminology more consistent
On Fri, Feb 12, 2021 at 6:51 AM Ferruh Yigit wrote:
>
> On 2/11/2021 7:44 PM, Lance Richardson wrote:
> > Add support for querying receive queue count in order to allow
> > the rte_eth_dev rx_queue_count() API to be exercised and tested.
> >
>
> +1 to adding thi
Add support for querying the count of ready descriptors on a
receive queue in order to allow the rte_eth_dev rx_queue_count()
API to be exercised and tested.
Signed-off-by: Lance Richardson
---
app/test-pmd/cmdline.c | 83 +
doc/guides/testpmd_app_ug
Add support for querying receive queue count in order to allow
the rte_eth_dev rx_queue_count() API to be exercised and tested.
Signed-off-by: Lance Richardson
---
app/test-pmd/cmdline.c | 65 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 ++
2
ps by
> time as new offloads added.
>
> Signed-off-by: Ferruh Yigit
> ---
Acked-by: Lance Richardson
TX-dropped: 0 TX-total: 0
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Kalesh Anakkur Purayil
---
app/test-pmd/csumonly.c | 5 +
app/test-pmd/testpmd.c | 11 ++-
app/test-pmd/testpmd.h | 2 ++
3 files changed, 17 insertions(+), 1
("net/bnxt: reduce CQ queue size without aggregation ring")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
v2: Fixed conflict resolution mistake (two missing hunks).
drivers/net/bnxt/bnxt_ethdev.c | 6 +-
drivers/net/bnxt/bnxt_rin
On Fri, Jan 29, 2021 at 12:57 PM Lance Richardson
wrote:
>
> The size of the receive completion ring should be recalculated
> when MTU is increased to a size that requires scattered receive
> or when LRO is enabled. Move logic for this calculation from
> the ring configuration pat
("net/bnxt: reduce CQ queue size without aggregation ring")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 6 +-
drivers/net/bnxt/bnxt_rxr.c| 15 +--
2 files changed, 6 insertions(+), 15
On Tue, Jan 26, 2021 at 6:01 AM Ferruh Yigit wrote:
>
> On 1/26/2021 3:45 AM, Lance Richardson wrote:
> > On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote:
> >>
> >>>> + if (rx_offloads != port->dev_conf.rxmode.offloads
On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote:
>
> >> + if (rx_offloads != port->dev_conf.rxmode.offloads) {
> >> + uint16_t qid;
> >> +
> >> + port->dev_conf.rxmode.offloads = rx_offloads;
> >> +
> >> + /* Apply JUMBO_FRAME offload configuratio
Acked-by: Lance Richardson
Thanks,
Lance
On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote:
>
> On 1/25/2021 7:41 PM, Lance Richardson wrote:
> > On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote:
> >>
> >> From: Steve Yang
> >>
> >> &qu
On Mon, Jan 25, 2021 at 1:15 PM Ferruh Yigit wrote:
>
> From: Steve Yang
>
> "port config all max-pkt-len" command fails because it doesn't set the
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly.
>
> Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload
> flag update from
On Mon, Jan 25, 2021 at 3:35 AM Steve Yang wrote:
>
> Moved the setting of 'DEV_RX_OFFLOAD_JUMBO_FRAME' from
> 'cmd_config_max_pkt_len_parsed()' to 'init_config()' caused fail the case
> where 'max_rx_pkt_len' is changed from the command line via
> "port config all max-pkt-len".
>
> The 'init_conf
The last mbuf in a multi-segment packet needs to be
NULL-terminated.
Fixes: 0958d8b6435d ("net/bnxt: support LRO")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
Reviewed-by: Somnath Kotur
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_rxr.c | 1 +
1 file changed, 1
On Thu, Jan 21, 2021 at 10:27 AM Lance Richardson
wrote:
>
> On Mon, Jan 18, 2021 at 2:08 AM Steve Yang wrote:
> >
> > When the max rx packet length is smaller than the sum of mtu size and
> > ether overhead size, it should be enlarged, otherwise the VLAN pac
On Mon, Jan 18, 2021 at 2:08 AM Steve Yang wrote:
>
> When the max rx packet length is smaller than the sum of mtu size and
> ether overhead size, it should be enlarged, otherwise the VLAN packets
> will be dropped.
>
> Removed the rx_offloads assignment for jumbo frame during command line
> parsi
Fix mask to include all four bits of hardware packet type
field.
Fixes: 97b1db288dd0 ("net/bnxt: use table based packet type translation")
Cc: sta...@dpdk.org
Signed-off-by: Lance Richardson
---
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Thu, Dec 17, 2020 at 9:08 AM Anatoly Burakov
wrote:
>
> From: Liang Ma
>
> Add a simple API to allow getting the monitor conditions for
> power-optimized monitoring of the RX queues from the PMD, as well as
> release notes information.
>
> Signed-off-by: Liang Ma
> Signed-off-by: Anatoly Bura
On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit wrote:
>
> On 12/14/2020 6:53 PM, Lance Richardson wrote:
> > Limit number of representor packets transferred per poll
> > to requested burst size.
> >
>
> Hi Lance,
>
> Can you please describe the impact of the chan
From: Lance Richardson
The setting of the mbuf ol_flags field for tunneled packets
should be different depending upon whether DEV_RX_OFFLOAD_OUTER_*
offloads are enabled. Initialize ol_flags mappings based on
the receive offload configuration when the receive ring is
initialized.
Signed-off-by
From: Lance Richardson
Refactor offload flags mapping table to be dynamic and
per-ring instead of static and global.
Signed-off-by: Lance Richardson
Cc: sta...@dpdk.org
---
drivers/net/bnxt/bnxt_rxr.c | 34 +--
drivers/net/bnxt/bnxt_rxr.h | 12
From: Lance Richardson
Receive checksum offload status flags in the mbuf
ol_flags field should include inner/outer status
only when outer checksum offload is enabled, which
currently isn't the case for the bnxt PMD. Fix by
using a hw-to-ol_flags mapping table that is constructed
bas
From: Lance Richardson
Rx outer UDP checksum offload has been supported for
some time, but this has not been advertised in offload
capability flags. Fix this, and allow vector mode
receive to be enabled when DEV_RX_OFFLOAD_OUTER_UDP_CKSUM
is requested.
Fixes: 04a681426d49 ("net/bnxt: f
From: Lance Richardson
Fixes for fallback mbuf allocation logic.
- Preserve raw (unmasked) producer index.
- Iterate over all processed descriptors (representor and
non-representor) when checking allocation status.
- Invoke fallback allocation logic when an allocation
failure
On Mon, Dec 14, 2020 at 12:41 PM Lance Richardson
wrote:
>
> On Thu, Sep 17, 2020 at 10:05 AM Olivier Matz wrote:
> >
> > Hi Lance,
> >
> > On Mon, Aug 24, 2020 at 04:11:45PM -0400, Lance Richardson wrote:
> > > I was looking for some clarification regardin
("net/bnxt: optimize Rx processing")
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Somnath Kotur
Cc: sta...@dpdk.org
---
v2 - Fixed typo in commit log.
drivers/net/bnxt/bnxt_rxr.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/d
Limit number of representor packets transferred per poll
to requested burst size.
Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Somnath Kotur
Cc: sta...@dpdk.org
---
driver
t;net/bnxt: optimize Rx processing")
Signed-off-by: Lance Richardson
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Somnath Kotur
Cc: sta...@dpdk.org
---
drivers/net/bnxt/bnxt_rxr.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/d
On Thu, Sep 17, 2020 at 10:05 AM Olivier Matz wrote:
>
> Hi Lance,
>
> On Mon, Aug 24, 2020 at 04:11:45PM -0400, Lance Richardson wrote:
> > I was looking for some clarification regarding how rx checksum
> > flags should be set for tunnel packets having both inner and
_03f0] = 2,
> @@ -227,6 +232,7 @@ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ]
> = {
> [BNXT_ULP_CLASS_HID_01b4] = 216
> };
>
> +/* Array for the proto matcher list */
> struct bnxt_ulp_class_match_info ulp_class_match_list[] = {
> [1] = {
> .class_hid = BNXT_ULP_CLASS_HID_0138,
> --
> 2.21.1 (Apple Git-122.3)
>
Acked-by: Lance Richardson
G(ERR,
> - "bnxt_init_one_rx_ring failed!\n");
> + PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring failed!\n");
> bnxt_rx_queue_release_op(rxq);
> rc = -ENOMEM;
> goto err_out;
> --
> 2.21.1 (Apple Git-122.3)
>
Acked-by: Lance Richardson
t bnxt_hwrm_get_dflt_vnic_svif(struct bnxt *bp, uint16_t fid,
> uint16_t *vnic_id, uint16_t *svif);
> int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp);
> --
> 2.21.1 (Apple Git-122.3)
>
Acked-by: Lance Richardson
; + rte_mbuf_raw_free(mbuf);
> }
>
> return 0;
> --
> 2.21.1 (Apple Git-122.3)
>
Acked-by: Lance Richardson
%d, device:%u\n",
> parms->session_id.internal.domain,
> parms->session_id.internal.bus,
> parms->session_id.internal.device);
> --
> 2.21.1 (Apple Git-122.3)
>
Acked-by: Lance Richardson
le to initialize def_cp_lock\n");
> + return err;
> + }
>
> err = pthread_mutex_init(&bp->health_check_lock, NULL);
> if (err)
> --
> 2.21.1 (Apple Git-122.3)
>
Acked-by: Lance Richardson
1 - 100 of 270 matches
Mail list logo
