2016-04-07 13:51 GMT+02:00 Panu Matilainen :
> [ change of subject since this is about ABI policy, not namespacing ]
>
> On 04/07/2016 01:16 PM, Marc Sune wrote:
>
>>
>>
>> 2016-04-07 11:33 GMT+02:00 Panu Matilainen > <mailto:pmatilai at redhat.com>>
2016-04-07 23:52 GMT+02:00 Matthew Hall :
> On Thu, Apr 07, 2016 at 02:51:35PM +0300, Panu Matilainen wrote:
> > LTS releases could help the situation somewhat, but then again
> > people tend to still want those new fancy things backported (you
> > know, have the cake and eat it too) but that can'
2016-04-07 14:50 GMT+02:00 Vivek Gupta :
> Hi
>
> I have binded eth0 and eth1 with DPDK and then tried to run the l2fwd
> example as below
>
> ./build/l2fwd -c f -n 4 -- -q 8 -p 0x11 but each time I get error
> *
> Checking link status..
> Port 0 Link Down
2016-04-07 11:33 GMT+02:00 Panu Matilainen :
> On 04/07/2016 12:18 PM, Thomas Monjalon wrote:
>
>> Thank you everyone for the feedbacks.
>>
>> 2016-04-05 15:56, Thomas Monjalon:
>>
>>> The goal of this email is to get some feedback on how important it is
>>> to fix the DPDK namespace.
>>>
>>
>> Ev
From: Thomas Monjalon
The link speed configuration is now done with bitmaps so 100G speed
requires only a new bit flag.
The actual link speed is a number so its size must be increased from
16-bit to 32-bit.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
Tested-by: Nelio Laranjeiro
It is a helper for the bitmap configuration.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.c | 31 +++
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 1 +
3
autoneg in struct rte_eth_link indicates if link speed was a
result of auto-negociation or was fixed by configuration.
Signed-off-by: Marc Sune
Tested-by: Nelio Laranjeiro
Signed-off-by: Thomas Monjalon
---
app/test-pmd/cmdline.c| 26
doc/guides/rel_notes
-off-by: Marc Sune
---
doc/guides/nics/overview.rst | 1 +
doc/guides/rel_notes/release_16_04.rst | 8
drivers/net/bnx2x/bnx2x_ethdev.c | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 1 +
drivers/net/e1000/em_ethdev.c | 4
drivers/net/e1000/igb_ethdev.c
The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_.
The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used
for bit flags in next patch.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c| 10 +-
app/test/virtual_pmd.c| 2
The code for checking and parsing speed/duplex was duplicated.
The new function is also checking the speed/duplex combination.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 99 --
1 file changed, 47 insertions(+), 52 deletions(-)
diff
Some duplex values are replaced from 0 to half-duplex when link is down.
Some drivers are still using their own constants for duplex modes.
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/e1000/igb_ethdev.c | 2 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 2
From: Thomas Monjalon
Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/testpmd.c | 2 +-
app/test
From: Marc Sune
This series of patches adds the following capabilities:
* speed_capa bitmap in rte_eth_dev_info, which is filled by the PMDs
according to the physical device capabilities.
* refactors link API in ethdev to allow the definition of the advertised
link speeds, fix speed (no
I found that in the current HEAD in master testing it with an I218-LM in
autoneg mode, when link is forced to be renegociated by the peer (e.g. via
ethtool on a peer Linux box) _some_ change events are lost.
It is quite random, but it seems to happen more while changing the speed
than when changin
From: Thomas Monjalon
The link speed configuration is now done with bitmaps so 100G speed
requires only a new bit flag.
The actual link speed is a number so its size must be increased from
16-bit to 32-bit.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
Tested-by: Nelio Laranjeiro
It is a helper for the bitmap configuration.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.c | 31 +++
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 1 +
3
autoneg in struct rte_eth_link indicates if link speed was a
result of auto-negociation or was fixed by configuration.
Signed-off-by: Marc Sune
Tested-by: Nelio Laranjeiro
Signed-off-by: Thomas Monjalon
---
app/test-pmd/cmdline.c| 26
doc/guides/rel_notes
-off-by: Marc Sune
---
doc/guides/nics/overview.rst | 1 +
doc/guides/rel_notes/release_16_04.rst | 8
drivers/net/bnx2x/bnx2x_ethdev.c | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 1 +
drivers/net/e1000/em_ethdev.c | 4
drivers/net/e1000/igb_ethdev.c
The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_.
The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used
for bit flags in next patch.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c| 10 +-
app/test/virtual_pmd.c| 2
The code for checking and parsing speed/duplex was duplicated.
The new function is also checking the speed/duplex combination.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 99 --
1 file changed, 47 insertions(+), 52 deletions(-)
diff
Some duplex values are replaced from 0 to half-duplex when link is down.
Some drivers are still using their own constants for duplex modes.
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/e1000/igb_ethdev.c | 2 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 2
From: Thomas Monjalon
Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/testpmd.c | 2 +-
app/test
d M. Brorup. Fixed spelling
issues.
v2: rebase, converted speed_capa into 32 bits bitmap, fixed alignment
(checkpatch).
Marc Sune (6):
ethdev: use constants for link duplex
app/testpmd: move speed and duplex parsing in a function
ethdev: rename link speed constants
ethdev: add sp
2016-03-01 1:45 GMT+01:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess could be done based on the
> driver's name (driver_name in rt
cmdline_parse_*.h headers use struct cmdline_token_hdr /
cmdline_parse_token_hdr_t which is defined in cmdline_parse.h, but
do not include it, forcing manual inclusion.
This commit includes cmdline_parse.h in all cmdline_parse_*.h.
---
lib/librte_cmdline/cmdline_parse_etheraddr.h | 2 ++
lib/libr
RTE_PMD_DEBUG_TRACE used RTE_FUNC_PTR_OR_ERR_RET was redefined
in rte_cryptodev_pmd.h which produced MACRO redefinition warnings
when including both rte_cryptodev_pmd.h and rte_ethdev.h.
This commit moves MACRO definition to rte_cryptodev.c to prevent
this warning.
---
lib/librte_cryptodev/rte_cr
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/nics/overview.rst | 1 +
doc/guides/rel_notes/release_16_04.rst | 27 +++
2 files changed, 28 insertions(+)
diff --git a/doc/guides
or was fixed
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
* Added rte_eth_speed_to_bm_flag() to version map.
Signed-off-by: Marc Sune
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/cmdline.c| 124
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* bnx2x
* cxgbe
* mlx4
* mlx5
* nfp
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/bnx2x/bnx2x_ethdev.c | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 1 +
drivers/net/e1000/em_ethdev.c| 6 ++
drivers
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 16da821..83ddbb7
rrent HEAD. Reverted numeric speed to 32 bit in struct
rte_eth_link (no atomic link get > 64bit). Fixed mlx5 driver compilation
and link speeds. Moved documentation to release_16_04.rst and fixed several
issues. Upgrade NIC notes with speed capabilities.
Marc Sune (4):
ethde
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_3.rst | 102 +++
1 file changed, 102 insertions(+)
create mode 100644 doc/guides/rel_notes/release_2_3.rst
diff
or was fixed
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
* Added rte_eth_speed_to_bm_flag() to version map.
Signed-off-by: Marc Sune
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/cmdline.c| 124
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* bnx2x
* cxgbe
* mlx4
* mlx5
* nfp
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/bnx2x/bnx2x_ethdev.c | 1 +
drivers/net/cxgbe/cxgbe_ethdev.c | 1 +
drivers/net/e1000/em_ethdev.c| 6 ++
drivers
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 16da821..83ddbb7
based to current HEAD. Modified em driver impl. to not touch base files.
Merged patch 5 into 3 (map file). Changed numeric speed to a 64 bit value.
Filled-in speed capabilities for drivers bnx2x, cxgbe, mlx5 and nfp in
addition to the ones of previous patch sets.
Marc Sune (4):
e
Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ether_version.map | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ether_version.map
b/lib/librte_ether/rte_ether_version.map
index d8db24d..2c14ad7 100644
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_3.rst | 26 ++
1 file changed, 26 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b/doc/guides/rel_notes
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 124 +++--
app/test/virtual_pmd.c | 4 +-
drivers/net/af_packet/rte_eth_af_packet.c
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 4
drivers/net/i40e
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8710dd7..dbc1599
Move link_duplex to be part of bitfield. Fixed i40 autoneg flag link
update code. Added rte_eth_speed_to_bm_flag() to .map file. Fixed other
spelling issues. Rebased to current HEAD.
v7: Rebased to current HEAD. Moved documentation to v2.3. Still needs testing
from PMD maintainers.
Marc
2015-10-25 22:59 GMT+01:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess could be done based on the
> driver's name (driver_name in rt
Hi Thomas,
2015-11-01 23:11 GMT+01:00 Thomas Monjalon :
> 2015-10-25 22:59, Marc Sune:
> > +#define ETH_SPEED_CAP_NOT_PHY(0) /*< No phy media > */
> > +#define ETH_SPEED_CAP_10M_HD (1 << 0) /*< 10 Mbps half-duplex> */
> > +#define ETH_SPEED_CAP_1
Hi Thomas,
2015-11-01 23:16 GMT+01:00 Thomas Monjalon :
> 2015-10-25 22:59, Marc Sune:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of advertised speeds for
> >
15-10-25 22:59 GMT+01:00 Marc Sune :
> This patch redesigns the API to set the link speed/s configure
> for an ethernet port. Specifically:
>
> - it allows to define a set of advertised speeds for
> auto-negociation.
> - it allows to disable link auto-negociation (single fixed sp
Added rte_eth_speed_to_bm_flag() to DPDK2.2 version map.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ether_version.map | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_ether/rte_ether_version.map
b/lib/librte_ether/rte_ether_version.map
index 8345a6c..cbfe0c8 100644
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_2.rst | 23 +++
1 file changed, 23 insertions(+)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/guides/rel_notes
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 124 +++--
app/test/virtual_pmd.c | 4 +-
drivers/net/af_packet/rte_eth_af_packet.c
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..951a423
rt of bitfield. Fixed i40 autoneg flag link
update code. Added rte_eth_speed_to_bm_flag() to .map file. Fixed other
spelling issues. Rebased to current HEAD.
Marc Sune (5):
ethdev: Added ETH_SPEED_CAP bitmap for ports
ethdev: Fill speed capability bitmaps in the PMDs
ethdev: redesign link
During the revision of an application I maintain that is currently using
DPDK v1.7.1 and about to port it to 2.1.0, I realised that 2.1.0rc4 and
above (at least) are broken when compiling applications without C++11
support:
In file included from
/home/marc/personal/xdpd/build/src/xdpd/drivers/gnu_
2015-10-06 15:48 GMT+02:00 N?lio Laranjeiro :
> Hi Marc,
>
> On Sun, Oct 04, 2015 at 11:12:46PM +0200, Marc Sune wrote:
> >[...]
> > /**
> > + * Device supported speeds bitmap flags
> > + */
> > +#define ETH_LINK_SPEED_AUTONEG (0
2015-10-05 12:59 GMT+02:00 Neil Horman :
> On Sun, Oct 04, 2015 at 11:12:46PM +0200, Marc Sune wrote:
> > This patch redesigns the API to set the link speed/s configure
> > for an ethernet port. Specifically:
> >
> > - it allows to define a set of advertised speeds
2015-10-04 23:12 GMT+02:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess could be done based on the
> driver's name (driver_name in rt
Add new features, ABI changes and resolved issues notice for
the refactored link patch.
Signed-off-by: Marc Sune
---
doc/guides/rel_notes/release_2_2.rst | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_2_2.rst
b/doc/guides
by configuration.
* Added utility function to convert numeric speeds to bitmap
fields.
* Adapted testpmd to the new link API.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 124 +++--
app/test/virtual_pmd.c | 4
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 8a8c82b..951a423
ities patch. Fixed MLX4 speed capabilities
(thanks N. Laranjeiro). Refactored link speed API to allow setting
advertised speeds (3/4). Added NO_AUTONEG option to explicitely disable
auto-negociation. Updated 2.2 rel. notes (4/4). Rebased to current HEAD.
Marc Sune (4):
ethdev:
Adrien,
2015-09-15 12:04 GMT+02:00 Adrien Mazarguil :
> Hi Marc,
>
> Adding my thoughts to the discussion, see below.
>
> On Tue, Sep 15, 2015 at 10:48:03AM +0200, Marc Sune wrote:
> > I will answer Morten in another mail, because I got his point on the
> > AUTONE
> >
> > Med venlig hilsen / kind regards
> > - Morten Br?rup
> >
> > Marc Sune on 14. september 2015 23:34 wrote:
> >
> > 2015-09-14 12:52 GMT+02:00 Morten Br?rup :
> > > It is important to consider that a multipath link (bonding etc.) is
> not a ph
bool rte_eth_duplex_from_bm(int val_bm).
Marc
>
> Med venlig hilsen / kind regards
> - Morten Br?rup
>
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: 13. september 2015 23:19
> To: Marc Sune
> Cc: N?lio Laranjeiro; dev at
Thomas,
2015-09-09 15:33 GMT+02:00 Thomas Monjalon :
> 2015-09-09 15:10, N?lio Laranjeiro:
> > I think V2 is better, maybe you can add a function to convert a single
> > bitmap value to the equivalent integer and get rid of ETH_SPEED_XXX
> macros.
> >
> > Thomas what is your opinion?
>
> Your pro
7463 at autoinstall.dev.6wind.com>
>
> Marc,
>
> On Tue, Sep 08, 2015 at 10:24:36PM +0200, Marc Sune wrote:
> > Neilo,
> >
> > 2015-09-08 12:03 GMT+02:00 N?lio Laranjeiro >:
> >
> > On Mon, Sep 07, 2015 at 10:52:53PM +0200, Marc Sune wrote:
Neilo,
2015-09-08 12:03 GMT+02:00 N?lio Laranjeiro :
> On Mon, Sep 07, 2015 at 10:52:53PM +0200, Marc Sune wrote:
> > 2015-08-29 2:16 GMT+02:00 Marc Sune :
> >
> > > The current rte_eth_dev_info abstraction does not provide any
> mechanism to
> > > get
2015-08-29 2:16 GMT+02:00 Marc Sune :
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> get the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an educated guess can be done based on the
> driver's name (driver_name in rt
Stephen, Don,
On Wed, Sep 2, 2015 at 9:00 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Wed, 2 Sep 2015 18:17:40 +
> Don Provan wrote:
>
> > Thomas Monjalon:
> > >Yes but please, do not create an alternative init function.
> > >We just need to replace panic/exit with err
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
adds missing speeds to
ETH_SPEED.
The field speed in the struct rte_eth_conf is now a bitmap and therefore is
renamed to speeds. This allows to specify a list of speeds to be announced
during autonegociation, as suggested by M. Brorup. Drivers do not support (yet)
this capability.
Signed-off-by: Marc
mit 1/2 message. rebased to v2.1.0. v3 was incorrectly based on
~2.1.0-rc1.
Marc Sune (2):
Added ETH_SPEED_ bitmap in rte_eth_dev_info
Filling speed capability bitmaps in the PMDs
app/test-pmd/cmdline.c| 32 +++
app/test/virtual_
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
adds missing speeds to
ETH_SPEED.
The field speed in the struct rte_eth_link is now a bitmap and therefore is
renamed to speeds. This allows to specify a list of speeds to be announced
during autonegociation, as suggested by M. Brorup. Driver do not support yet
this capabilities.
Signed-off-by: Marc
From: Marc Sune
The current rte_eth_dev_info abstraction does not provide any mechanism to
get the supported speed(s) of an ethdev.
For some drivers (e.g. ixgbe), an educated guess can be done based on the
driver's name (driver_name in rte_eth_dev_info), see:
http://dpdk.org/ml/archive
On 04/08/15 23:09, Navneet Rao wrote:
> Hello Experts:
>
>
> How can I configure my NIC setting(s) when loaded with the dpdk:igb_uio
> driver?
> E.g I need to keep the MAC address and the IP address of the NIC the "same as
> before" after switching to a dpdk:igb_uio driver for the NIC.
When
On 09/07/15 08:36, Gopakumar Choorakkot Edakkunni wrote:
> Reading through the KNI module source, doesnt look like there is a way
> to do this. For my requirement, I will make some patch tomorrow to
> have a module option to just keep the KNI data structures around even
> if /dev/kni is closed, l
Prevent double initialization of the KNI subsytem.
v2: added warning trace
Signed-off-by: Marc Sune
---
lib/librte_kni/rte_kni.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index c5a0089..08155db 100644
--- a/lib/librte_kni
On 18/06/15 16:43, Morten Br?rup wrote:
> Regarding the PHY speed ABI:
>
>
>
> 1. The Ethernet PHY ABI for speed, duplex, etc. should be common throughout
> the entire DPDK. It might be confusing if some structures/functions use a
> bitmask to indicate PHY speed/duplex/personality/etc. and o
On 17/06/15 07:28, Stephen Hemminger wrote:
> On Tue, Jun 16, 2015 at 9:36 PM, Matthew Hall
> wrote:
>
>> On Wed, Jun 17, 2015 at 01:29:47AM +0200, Thomas Monjalon wrote:
>>> There were some debates about software statistics disabling.
>>> Should they be always on or possibly disabled when comp
On 11/06/15 11:08, Thomas Monjalon wrote:
> 2015-06-08 10:50, Marc Sune:
>> On 29/05/15 20:23, Thomas Monjalon wrote:
>>> 2015-05-27 11:15, Marc Sune:
>>>> On 27/05/15 06:02, Thomas Monjalon wrote:
>>>>>> +#define ETH_SPEED_CAP_10M_HD(1 &l
On 29/05/15 20:23, Thomas Monjalon wrote:
> 2015-05-27 11:15, Marc Sune:
>> On 27/05/15 06:02, Thomas Monjalon wrote:
>>> Why not starting with lower values? Some new drivers may be interested
>>> by lower speed.
>> Ok, but which values? 1Mbps FD/HD? Even lower
On 05/06/15 17:06, Jay Rolette wrote:
> The past few days I've been trying to chase down why operations over KNI
> are so bloody slow. To give you an idea how bad it is, we did a simple test
> over an NFS mount:
>
> # Mount over a non-KNI interface (eth0 on vanilla Ubuntu 14.04 LTS)
> $ time $(ls
Prevent double initialization of the KNI subsytem.
Signed-off-by: Marc Sune
---
lib/librte_kni/rte_kni.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index c5a0089..df0449f 100644
--- a/lib/librte_kni/rte_kni.c
+++ b/lib/librte_kni
On 28/05/15 18:06, Matt Laswell wrote:
> Hey Kyle,
>
> That's one way you can handle it, though I suspect you'll end up with some
> complexity elsewhere in your code to deal with remembering whether you
> should look at the original data or the copied and modified data. Another
> way is just to
Prevent double initialization of the KNI subsytem.
Signed-off-by: Marc Sune
---
lib/librte_kni/rte_kni.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
index c5a0089..df0449f 100644
--- a/lib/librte_kni/rte_kni.c
+++ b/lib/librte_kni
100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -47,6 +47,8 @@
>*/
>
> #include
> +#include
> +#include
>
> #include
>
A fwd declaration of struct rte_mempool would be sufficient, but
Acked-by: Marc Sune
h
> +++ b/lib/librte_eal/common/include/rte_pci.h
> @@ -74,6 +74,7 @@
> extern "C" {
> #endif
>
> +#include
> #include
> #include
> #include
Acked-by: Marc Sune
On 27/05/15 15:55, Bruce Richardson wrote:
> On Wed, May 27, 2015 at 03:52:34PM +0200, Marc Sune wrote:
>>
>> On 27/05/15 15:47, Bruce Richardson wrote:
>>> When a KNI object is created, a name is assigned to it which is stored
>>> internally. There is also
On 27/05/15 15:47, Bruce Richardson wrote:
> When a KNI object is created, a name is assigned to it which is stored
> internally. There is also an API function to look up a KNI object by
> name, but there is no API to query the current name of an existing
> KNI object. This patch adds just such a
On 27/05/15 06:02, Thomas Monjalon wrote:
> Hi Marc,
>
> 2015-05-26 21:50, Marc Sune:
>> Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
>>
>> Signed-off-by: Marc Sune
> [...]
>> +/**
>> + * Device supported speeds
>>
> Best regards,
> Igor
>
>> 26 ??? 2015 ?., ? 22:50, Marc Sune ???(?):
>>
>> Added speed capabilities to all pmds supporting physical NICs:
>>
>> * e1000
>> * ixgbe
>> * i40
>> * mlx4
>> * fm10k
>>
>> Signed-off-
Added speed capabilities to all pmds supporting physical NICs:
* e1000
* ixgbe
* i40
* mlx4
* fm10k
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c| 6 ++
drivers/net/e1000/igb_ethdev.c | 6 ++
drivers/net/fm10k/fm10k_ethdev.c | 3 +++
drivers/net/i40e/i40e_ethdev.c
Added constants and bitmap to struct rte_eth_dev_info to be used by PMDs.
Signed-off-by: Marc Sune
---
lib/librte_ether/rte_ethdev.h | 24
1 file changed, 24 insertions(+)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 16dbe00..f57676b
g. in i40, distinguish between XL710 and X710).
This small patch adds speed_capa bitmap in rte_eth_dev_info, which is filled
by the PMDs according to the physical device capabilities.
v2: rebase, converted speed_capa into 32 bits bitmap, fixed alignment
(checkpatch).
Marc Sune (2):
Added ETH_SPEE
On 26/05/15 17:03, Stephen Hemminger wrote:
> On Tue, 12 May 2015 01:45:45 +0200
> Marc Sune wrote:
>
>> +/**
>> + * Ethernet device information
>> + */
>> struct rte_eth_dev_info {
>> struct rte_pci_device *pci_dev; /**< Device PCI infor
On 25/05/15 19:46, Stephen Hemminger wrote:
> On Tue, 12 May 2015 01:45:45 +0200
> Marc Sune wrote:
>
>> +/**
>> + * Ethernet device information
>> + */
>> struct rte_eth_dev_info {
>> struct rte_pci_device *pci_dev; /**< Device PCI infor
Any objections to this one? Otherwise I will rebase and propose a formal
patch
marc
On 12/05/15 01:45, Marc Sune wrote:
> The current rte_eth_dev_info abstraction does not provide any mechanism to
> know the supported speed(s) of an ethdev.
>
> For some drivers (e.g. ixgbe), an ed
On 20/05/15 12:28, Neil Horman wrote:
> On Wed, May 20, 2015 at 12:05:00PM +0200, Marc Sune wrote:
>>
>> On 20/05/15 10:31, Thomas Monjalon wrote:
>>> 2015-05-19 12:31, Bruce Richardson:
>>>> On Mon, May 11, 2015 at 05:29:39PM +0100, Bruce Richardson wrot
On 20/05/15 10:31, Thomas Monjalon wrote:
> 2015-05-19 12:31, Bruce Richardson:
>> On Mon, May 11, 2015 at 05:29:39PM +0100, Bruce Richardson wrote:
>>> Hi all,
>>>
>>> after a small amount of offline discussion with Marc Sune, here is an
>>> alte
1 - 100 of 199 matches
Mail list logo
