Hi Tetsuya,
On Tue, Feb 17, 2015 at 9:51 AM, Tetsuya Mukawa wrote:
>
>
> >> +/* get port_id enabled by above procedures */
> >> +if (rte_eth_dev_get_changed_port(devs, &new_port_id))
> >> +goto err2;
> > [...]
> >
> >> /**
> >> + * Uninitilization function called for each dev
Hi Tetsuya,
On Fri, Feb 20, 2015 at 7:39 AM, Tetsuya Mukawa wrote:
> These functions are used for attaching or detaching a port.
[..]
> +
> +static void
> +get_vdev_name(char *vdevargs)
> +{
> + char *sep;
> +
> + if (vdevargs == NULL)
> + return;
> +
> + /* set th
Hi Tetsuya,
Thanks for your comment.
On Fri, Feb 20, 2015 at 11:32 AM, Tetsuya Mukawa wrote:
> On 2015/02/20 19:14, Maxime Leroy wrote:
>> Hi Tetsuya,
[...]
>>
>
> Hi Maxime,
>
> I appreciate for your comment.
>
> When rte_eal_init() is called, if we have
Hi Tetsuya,
On Sat, Feb 21, 2015 at 4:49 AM, Tetsuya Mukawa wrote:
> On 2015/02/21 0:20, Maxime Leroy wrote:
[...]
>> Why you want to add devargs in the devargs_list, if there are no needs
>> to store this information ?
>
> In eal initialization code, virtual device names
Hi Tetsuya,
On Mon, Feb 23, 2015 at 6:09 AM, Tetsuya Mukawa wrote:
> These functions are used for attaching or detaching a port.
[...]
>
> +static int
> +rte_eal_vdev_init(const char *name, const char *args)
> +{
> + struct rte_driver *driver;
> +
> + if (name == NULL)
> +
Hi Tetsuya,
On Tue, Feb 24, 2015 at 5:49 AM, Tetsuya Mukawa wrote:
> These functions are used for attaching or detaching a port.
[...]
> +static int
> +rte_eal_vdev_init(const char *name, const char *args)
> +{
> + struct rte_driver *driver;
> +
> + if (name == NULL)
> +
As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose RSS, DCB
or VMDQ mode to select the rx queues.
But the igb/ixgbe code always select RSS mode with ETH_MQ_RX_NONE. This patch
fixes this incoherence between the api and the source code.
Signed-off-by: Maxime Leroy
---
lib
We should be able to enable RSS with one Rx queue.
RSS hash can be useful independently of the number of queues.
Applications can use RSS hash to identify different flows.
Signed-off-by: Maxime Leroy
---
lib/librte_pmd_e1000/igb_rxtx.c |7 ++-
lib/librte_pmd_ixgbe/ixgbe_rxtx.c |7
pv4_mask = res->ip_dst_mask;
- fdir_masks.src_ipv4_mask = res->ip_src_mask;
+ fdir_masks.dst_ipv4_mask = rte_cpu_to_be_32(res->ip_dst_mask);
+ fdir_masks.dst_ipv4_mask = rte_cpu_to_be_32(res->ip_dst_mask);
Would you like to provide and test a patch to fix this issue, please ?
Thanks. Best Regards,
---
Maxime Leroy
maxime.leroy at 6wind.com
e the command
show_rss_key in the testpmd, this one will display that the RSS is enabled.
(because rss_hf != 0; see port_rss_hash_conf_show function in
app/test-pmd/config.c)
Do you agree with my analyze ?
Thanks.
--
Maxime Leroy
gbe: ETH_MQ_RX_NONE should disable RSS
>
> Signed-off-by: Daniel Kan
Acked-by: Maxime Leroy
Thanks.
Hi Fulvio,
I have been checked few information about the datasheet of the X540 card.
The X540 card is a derivative of the 82599. It's very similar to the 82599 card.
The both cards use the same hardware registers for the flow director.
Thus, the current code of the dpdk for the flow director shou
Thanks
On Mon, Mar 24, 2014 at 10:35 PM, Thomas Monjalon wrote:
> From: Mauro Annarumma
>
> Flow director in X540 uses the same registers as in 82599.
> So it just has to be enabled in the 82599 implementation.
>
> Signed-off-by: Mauro Annarumma
>
> Acked-by: Maxime Leroy
incorrect application behavior if invalid
ol_flags/ptype are set, or memory corruptions if IND_ATTACHED_MBUF is
set in ol_flags.
Fixes: 081f7eae242e ("mlx5: process offload flags only when requested")
Signed-off-by: Maxime Leroy
---
drivers/net/mlx5/mlx5_rxtx.c | 2 ++
1 file
sta...@dpdk.org
Signed-off-by: Maxime Leroy
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 57feb377..9cd5eb65 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/driv
ializing the RSS reta from rte_eth_dev_configure
into rte_eth_dev_start.
To fix the issue, the skip_default_rss_reta is always set to 1 in
rte_eth_dev_rss_reta to avoid reconfigure the rss reta when the device
is started.
Fixes: 63bd16292c3a ("net/mlx5: support RSS on hairpin")
S
Hi Dekel,
First, I don't understand the initial change [1] done on RTE_FLOW API.
Before this change, it was possible to match any packets with or
without vlan encapsulations.
At least, it's not anymore the case with the mlx5 pmd.
For example, if I want to match any ssh packets whatever if it's
en
/ ipv4 / end actions mark id 2 / queue index 0 / end
By setting inner_type mask to 0, it means that we don't care about
inner_type, so inner_type can be any value. Thus it can be 0x8100 for
vlan or 0x800 for ipv4. At the end, this rule matches any ipv4 packets
with at least one vlan header.
Having more_vlan_exist in rte_flow_item_vlan is not useful.
Regards,
Maxime Leroy
>
> /** Default mask for RTE_FLOW_ITEM_TYPE_VLAN. */
> --
> 1.8.3.1
>
Hi Raslan,
Any comment/review on the fix ?
Regards,
Maxime
On Thu, Jul 16, 2020 at 12:43 PM Maxime Leroy wrote:
>
> The following sequences was working fine on mlx5:
>rte_eth_dev_configure(portid, ...);
>
>for (queueid = 0; queueid < nb_txq; queueid++)
> r
Hi Dekel,
On Thu, Oct 1, 2020 at 8:49 PM Dekel Peled wrote:
>
> From: Dekel Peled
>
> This patch implements the change proposes in RFC [1], adding dedicated
> fields to ETH and VLAN items structs, to clearly define the required
> characteristic of a packet, and enable precise match criteria.
>
>
On Mon, Oct 5, 2020 at 11:37 AM Dekel Peled wrote:
>
> Thanks, PSB.
>
> > -Original Message-
> > From: Maxime Leroy
> > Sent: Friday, October 2, 2020 3:39 PM
> > To: Dekel Peled
> > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon
> > ; ferruh.y
This patchset provides several bug fixes for rx queue count calculation for
mlx5 driver.
Didier Pallard (1):
net/mlx5: fix Rx descriptor status returned value
Maxime Leroy (3):
Revert "net/mlx5: fix Rx queue count calculation"
net/mlx5: fixed used initialization in rx_queue_co
e0
There are 2 packets compressed in the first queue. For the first packet,
n is computed correctly.
But for the second, n is not computed properly. Because the zip context
is for the first packet. The second packet is not yet decompressed, so
there are no context.
Signed-off-by: Maxime Leroy
S
the Rx queue count
calculation is same for any rx burts method since CQ handling is the
same for regular, vectorized, and multi-packet Rx queues.
Signed-off-by: Maxime Leroy
---
drivers/net/mlx5/mlx5_rxtx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/
From: Didier Pallard
Two bugs in rx_queue_count function:
- One entry may contain several segments, so 'used' must be multiplied
by number of segments per entry to properly reflect the queue usage.
- rx_queue_count returns the number of entries used in queue, so it ranges
from 0 to max number
| | ... | ...
| . | | cqe8[2] | | | . | | | |
| . | | | | | | | | |
+-+ +-+ +---+ +---+++ +---+
Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API")
Signed-off-by: Maxime Leroy
Signed-off-by: Nelio Lar
This patchset provides several bug fixes for rx queue count calculation for
mlx5 driver.
---
V2:
* squash first patch and second patch
* fix wrong init of used for compressed cqes
Didier Pallard (1):
net/mlx5: fix Rx descriptor status returned value
Maxime Leroy (1):
net/mlx5: fix Rx queue
first CQEs
serie.
Fixes: d2d57605522d ("net/mlx5: fix Rx queue count calculation")
Signed-off-by: Maxime Leroy
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_
From: Didier Pallard
One entry may contain several segments, so 'used' must be multiplied
by number of segments per entry to properly reflect the queue usage.
Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API")
Signed-off-by: Didier Pallard
Signed-
t; I see you wrote the luxury commit messages, and I'm crying with bloody tears
> about what I'm going to ask you for -
> could we squash the series in to single commit? Or at least two - Didier and
> yours?
>
> With best regards, Slava
>
I have just sent a V2 version fixing all these points.
Best regards,
Maxime Leroy
>
>
first CQEs
series.
Fixes: d2d57605522d ("net/mlx5: fix Rx queue count calculation")
Signed-off-by: Maxime Leroy
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_
status returned value
Maxime Leroy (1):
net/mlx5: fix Rx queue count calculation
drivers/net/mlx5/mlx5_rxtx.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
--
2.27.0
atus API")
Signed-off-by: Didier Pallard
Signed-off-by: Maxime Leroy
---
drivers/net/mlx5/mlx5_rxtx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 2733dcd3..2ecf901f 100644
--- a/drivers/net/mlx5/mlx5_
Hi Slava,
On Mon, Nov 16, 2020 at 9:03 PM Slava Ovsiienko wrote:
>
> Hi, Maxime
>
> It seems there are some typos (see below).
> Beside these ones - ACKed.
>
> > -Original Message-
> > From: Maxime Leroy
> > Sent: Monday, November 16, 2020 19:03
):
net/mlx5: fix Rx descriptor status returned value
Maxime Leroy (1):
net/mlx5: fix Rx queue count calculation
drivers/net/mlx5/mlx5_rxtx.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
--
2.27.0
first CQEs
series.
Fixes: d2d57605522d ("net/mlx5: fix Rx queue count calculation")
Signed-off-by: Maxime Leroy
Signed-off-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_rxtx.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_
atus API")
Signed-off-by: Didier Pallard
Signed-off-by: Maxime Leroy
---
drivers/net/mlx5/mlx5_rxtx.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 2733dcd3..2ecf901f 100644
--- a/drivers/net/mlx5/
37 matches
Mail list logo
