Re: [dpdk-dev] [PATCH 2/2] app/test: add net null dev creation in Rx adapter autotest

2020-10-07 Thread Rao, Nikhil
> -Original Message- > From: Jayatheerthan, Jay > Sent: Saturday, October 3, 2020 2:36 PM > To: jer...@marvell.com; tho...@monjalon.net; Rao, Nikhil > > Cc: dev@dpdk.org; sta...@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH 2/2] app/test: add net null de

Re: [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest

2020-10-07 Thread Rao, Nikhil
> -Original Message- > From: Jayatheerthan, Jay > Sent: Saturday, October 3, 2020 2:36 PM > To: jer...@marvell.com; tho...@monjalon.net; Rao, Nikhil > > Cc: dev@dpdk.org; sta...@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH 1/2] app/test: uninit vdevs

Re: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked

2020-08-06 Thread Rao, Nikhil
> -Original Message- > From: wangyunjian > Sent: Monday, July 27, 2020 7:33 PM > To: dev@dpdk.org; Rao, Nikhil > Cc: jerry.lili...@huawei.com; xudin...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] eventdev: fix return value of null

Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled

2020-01-20 Thread Rao, Nikhil
> -Original Message- > From: Thomas Monjalon > Sent: Monday, January 20, 2020 3:20 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rao, Nikhil ; Chas Williams > ; Richardson, Bruce ; > Stephen Hemminger ; Pattan, Reshma > > Subject: Re: [dpdk-dev] [PATCH v5] ap

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-22 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, October 22, 2019 2:15 PM > To: Rao, Nikhil > Cc: Nipun Gupta ; Jerin Jacob ; > dpdk-dev ; Pavan Nikhilesh ; > Sunil Kumar Kori ; Richardson, Bruce > ; Kovacevic, Marko >

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-21 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Thursday, October 3, 2019 3:57 PM > To: Hemant Agrawal > Cc: Rao, Nikhil ; Nipun Gupta ; > Jerin Jacob ; dpdk-dev ; Pavan Nikhilesh > ; Sunil Kumar Kori ; > Richardson, Bruce ; Kova

Re: [dpdk-dev] [PATCH v4] eventdev: flag to identify same destined packets enqueue

2019-10-10 Thread Rao, Nikhil
Richardson, Bruce > ; Kovacevic, Marko > ; or...@mellanox.com; Nicolau, Radu > ; Kantecki, Tomasz ; > Van Haaren, Harry ; Rao, Nikhil > ; Nipun Gupta > Subject: [PATCH v4] eventdev: flag to identify same destined packets enqueue > > This patch introduces a `flag` in the Eth TX adapt

Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined packets enqueue

2019-10-02 Thread Rao, Nikhil
ko > ; Ori Kam ; Nicolau, Radu > ; Kantecki, Tomasz ; > Van Haaren, Harry ; Rao, Nikhil > > Subject: Re: [dpdk-dev] [PATCH] eventdev: flag to identify same destined > packets enqueue > > On Wed, Oct 2, 2019 at 8:38 AM Hemant Agrawal > wrote: > > > > Hi Jerin, &g

Re: [dpdk-dev] [PATCH v2] eventdev: fix doxygen comment

2019-07-02 Thread Rao, Nikhil
> -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Tuesday, July 2, 2019 12:16 PM > To: dev@dpdk.org; Jerin Jacob > Cc: sta...@dpdk.org; Rao, Nikhil > Subject: [dpdk-dev] [PATCH v2] eventdev: fix doxygen comment > > From:

Re: [dpdk-dev] [PATCH] eventdev: fix doxygen comment

2019-06-23 Thread Rao, Nikhil
Hi Jerin, > -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Wednesday, June 19, 2019 1:33 PM > To: dev@dpdk.org; Jerin Jacob > Cc: sta...@dpdk.org; Rao, Nikhil > Subject: [dpdk-dev] [PATCH] eventdev: fix doxygen comment >

Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback and stats structure

2019-06-19 Thread Rao, Nikhil
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rao, Nikhil > Sent: Wednesday, June 19, 2019 1:40 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback > and stats st

Re: [dpdk-dev] [PATCH v2] eventdev: change Rx adapter callback and stats structure

2019-06-19 Thread Rao, Nikhil
Hi Jerin, > -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Monday, June 17, 2019 10:03 AM > To: Rao, Nikhil > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] eventdev: change Rx adapter callback and stats > structure > &

Re: [dpdk-dev] [PATCH] eventdev: optimize Rx adapter event enqueue

2019-06-13 Thread Rao, Nikhil
Hi Jerin, > -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Monday, June 10, 2019 9:50 AM > To: Rao, Nikhil > Cc: dev@dpdk.org > Subject: RE: [PATCH] eventdev: optimize Rx adapter event enqueue > > > -Original Me

Re: [dpdk-dev] [PATCH] eventdev: remove event copy in Rx adapter

2019-06-13 Thread Rao, Nikhil
Hi Jerin, > -Original Message- > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Tuesday, June 11, 2019 4:25 PM > To: Rao, Nikhil ; jer...@marvell.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eventdev: remove event copy in Rx adapter >

Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

2019-05-10 Thread Rao, Nikhil
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, May 10, 2019 12:48 AM > To: Rao, Nikhil > Cc: dev@dpdk.org; jer...@marvell.com; matias@nokia.com > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush log

Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

2019-05-10 Thread Rao, Nikhil
> -Original Message- > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Friday, May 10, 2019 12:52 AM > To: Rao, Nikhil ; jer...@marvell.com > Cc: dev@dpdk.org; matias@nokia.com > Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-09 Thread Rao, Nikhil
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Elo, Matias (Nokia - > FI/Espoo) > Sent: Tuesday, May 7, 2019 5:33 PM > To: Mattias Rönnblom > Cc: Honnappa Nagarahalli ; > dev@dpdk.org; nd > Subject: Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching > >

Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable

2019-04-22 Thread Rao, Nikhil
> -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Friday, April 19, 2019 5:41 PM > To: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Mattias Rönnblom > ; Van Haaren, Harry > ; Gujjar, Abhinandan S > ; Rao, Nikhil ; > Carril

Re: [dpdk-dev] [PATCH v3 2/3] examples/eventdev: start ethdev after eth adapter setup

2019-03-13 Thread Rao, Nikhil
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Wednesday, March 13, 2019 2:11 AM > To: Jerin Jacob Kollanukkaran ; Van Haaren, Harry > ; Rao, Nikhil ; Carrillo, > Erik G ; Gujjar, Abhinandan S > ; Mcnamara, John

Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight

2019-01-09 Thread Rao, Nikhil
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, December 10, 2018 9:31 PM Hi Stephen, > To: Rao, Nikhil > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: sup

Re: [dpdk-dev] [PATCH v7 2/2] mbuf: implement generic format for sched field

2018-12-20 Thread Rao, Nikhil
> -Original Message- > From: Pattan, Reshma > Sent: Thursday, December 20, 2018 5:46 PM > To: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Rao, Nikhil > ; olivier.m...@6wind.com; tho...@monjalon.net; > Singh, Jasvinder ; Dumitrescu, Cristian > ; Ananyev, Konstantin &g

Re: [dpdk-dev] [PATCH v2 1/3] mbuf: implement generic format for sched field

2018-12-13 Thread Rao, Nikhil
Hi Reshma, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Reshma Pattan > Sent: Friday, December 7, 2018 8:02 PM > To: dev@dpdk.org; Dumitrescu, Cristian ; > jerin.ja...@caviumnetworks.com; Singh, Jasvinder > > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight

2018-12-09 Thread Rao, Nikhil
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, November 29, 2018 11:43 AM > To: Rao, Nikhil > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: support doubl

Re: [dpdk-dev] [PATCH] eventdev: fix eth Tx adapter queue count checks

2018-12-02 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Saturday, December 1, 2018 8:09 PM > To: Rao, Nikhil > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] eventdev: fix eth Tx adapter queue count checks > > -Origin

Re: [dpdk-dev] [PATCH] fix static variables

2018-10-05 Thread Rao, Nikhil
On 10/4/2018 9:10 AM, Ferruh Yigit wrote: Make variables static as much as possible. For the ones can't be done static, prefix the variable name with component name. Also some cleanup and fix done related static usage while around. Signed-off-by: Ferruh Yigit --- app/pdump/main.c

Re: [dpdk-dev] [PATCH v2] examples/eventdev_pipeline: add Tx adapter support

2018-10-03 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, September 28, 2018 4:46 PM > To: Rao, Nikhil > Cc: Pavan Nikhilesh ; Van Haaren, > Harry ; anoob.jos...@caviumnetworks.com; > dev@dpdk.org > Subject: Re: [PATCH v2] ex

Re: [dpdk-dev] [PATCH v2] examples/eventdev_pipeline: add Tx adapter support

2018-09-26 Thread Rao, Nikhil
On 9/24/2018 3:42 PM, Pavan Nikhilesh wrote: Redo the worker pipelines and offload transmission to service cores seamlessly through Tx adapter. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Updated enqueue,dequeue depth thresholds. - remove redundant capability checks. Reviewed-by: N

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-21 Thread Rao, Nikhil
On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121 examples/eventdev_pipeline/main.c | 62 ++-- examples/eventdev_pipeline/pipeline_common.h | 31

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-19 Thread Rao, Nikhil
On 9/19/2018 4:12 PM, Pavan Nikhilesh wrote: On Wed, Sep 19, 2018 at 08:24:01AM +0530, Rao, Nikhil wrote: On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-18 Thread Rao, Nikhil
On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121 examples/eventdev_pipeline/main.c | 62 ++-- examples/eventdev_pipeline/pipeline_common.h | 31

Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-05 Thread Rao, Nikhil
On 9/5/2018 2:24 PM, Pavan Nikhilesh wrote: On Wed, Sep 05, 2018 at 12:24:18PM +0530, Rao, Nikhil wrote: On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app

Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-04 Thread Rao, Nikhil
On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 269 --- app/test-eventdev/test_pipeline_common.c |

Re: [dpdk-dev] [PATCH 2/2] app/test-eventdev: add Tx adapter support

2018-09-03 Thread Rao, Nikhil
Hi Pavan, Few comments below. On 8/31/2018 4:10 PM, Pavan Nikhilesh wrote: Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 216 +++- app/test-eve

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-22 Thread Rao, Nikhil
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, August 22, 2018 9:53 PM > To: Rao, Nikhil ; jerin.ja...@caviumnetworks.com; > olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 4/4] eventdev: add

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-22 Thread Rao, Nikhil
On 8/17/2018 5:25 PM, Pavan Nikhilesh wrote: Hi Nikhil, Few comments inline. Nit: Please use --in-reply-to while sending next versions. (https://core.dpdk.org/contribute/) Thanks, Pavan On Fri, Aug 17, 2018 at 09:50:52AM +0530, Nikhil Rao wrote: This patch adds tests for the eth Tx ad

Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-08-22 Thread Rao, Nikhil
On 8/21/2018 2:41 PM, Jerin Jacob wrote: -Original Message- Date: Tue, 21 Aug 2018 14:22:15 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: olivier.m...@6wind.com, dev@dpdk.org, nikhil@intel.com Subject: Re: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks fo

Re: [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-08-21 Thread Rao, Nikhil
On 8/19/2018 4:15 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 17 Aug 2018 09:50:50 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, olivier.m...@6wind.com CC: dev@dpdk.org, Nikhil Rao Subject: [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapt

Re: [dpdk-dev] [PATCH] check-symbol-change: relax rule for identifying a section

2018-08-16 Thread Rao, Nikhil
On 8/16/2018 4:38 PM, Neil Horman wrote: It was reported recently that some patches that add symbols to an existing EXPERIMENTAL section of a version map file generate errors because the check-symbol-change script was identifying the section as "@@" rather than EXPERIMENTAL. This was fairly clea

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-15 Thread Rao, Nikhil
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Wednesday, August 15, 2018 4:19 PM > To: Rao, Nikhil > Cc: dev@dpdk.org; tho...@monjalon.net; Mcnamara, John > ; Richardson, Bruce > ; Yigit, Ferruh ; > step...@networkplumb

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-13 Thread Rao, Nikhil
On 6/27/2018 11:31 PM, Neil Horman wrote: diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh new file mode 100755 index 0..17d123cf4 --- /dev/null +++ b/devtools/check-symbol-change.sh @@ -0,0 +1,159 @@ +#!/bin/sh +# SPDX-License-Identifier: BSD-3-Clause +# Cop

Re: [dpdk-dev] [pbhagavat...@caviumnetworks.com: Re: [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter]

2018-07-16 Thread Rao, Nikhil
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, July 16, 2018 5:03 PM > To: Rao, Nikhil ; > jkollanukka...@caviumnetworks.com; olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: [pbhagavat...@caviumnetwor

Re: [dpdk-dev] [PATCH 1/4] eventdev: add eth Tx adapter APIs

2018-07-16 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, July 10, 2018 5:48 PM > To: Rao, Nikhil > Cc: olivier.m...@6wind.com; dev@dpdk.org; anoob.jos...@cavium.com > Subject: Re: [PATCH 1/4] eventdev: add eth Tx adapter AP

Re: [dpdk-dev] [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-07-15 Thread Rao, Nikhil
On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote: +int __rte_experimental +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps) +{ The caps get API needs to be similar to rx adapter caps get i.e. it needs to have the eth_port_id as a parameter so that the underlying event dev driver can

Re: [dpdk-dev] [PATCH v1 4/4] eventdev: add interrupt driven queues in Rx event adapter

2018-06-18 Thread Rao, Nikhil
On 6/17/2018 7:19 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 8 Jun 2018 23:45:18 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com CC: dev@dpdk.org, Nikhil Rao Subject: [PATCH v1 4/4] eventdev: add interrupt driven queues in Rx event adapter X-Mailer: git-send-emai

Re: [dpdk-dev] [PATCH v1 2/4] eventdev: improve err handling for Rx adapter queue add/del

2018-06-18 Thread Rao, Nikhil
On 6/17/2018 7:01 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 8 Jun 2018 23:45:15 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com CC: dev@dpdk.org, Nikhil Rao Subject: [PATCH v1 2/4] eventdev: improve err handling for Rx adapter queue add/del X-Mailer: git-send-

Re: [dpdk-dev] [RFC v2] eventdev: event tx adapter APIs

2018-06-18 Thread Rao, Nikhil
On 6/17/2018 4:39 PM, Jerin Jacob wrote: -Original Message- Date: Wed, 13 Jun 2018 03:02:43 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, olivier.m...@6wind.com CC: hemant.agra...@nxp.com, dev@dpdk.org, narender.vang...@intel.com, abhinandan.guj...@intel.com, gage.e...@i

Re: [dpdk-dev] [RFC v2] eventdev: event tx adapter APIs

2018-06-14 Thread Rao, Nikhil
Hi Folks, Did you get a chance to review v2 ? Please let me know your feedback so I can proceed towards implementation. Thanks, Nikhil

Re: [dpdk-dev] [RFC] eventdev: event tx adapter APIs

2018-06-05 Thread Rao, Nikhil
On 6/4/2018 10:41 AM, Jerin Jacob wrote: -Original Message- Date: Fri, 1 Jun 2018 23:47:00 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: hemant.agra...@nxp.com, dev@dpdk.org, narender.vang...@intel.com, abhinandan.guj...@intel.com, gage.e...@intel.com, nikhil@intel.c

Re: [dpdk-dev] [dpdk-stable] [PATCH] eventdev: fix eth port in eth Rx adapter internal function

2018-06-03 Thread Rao, Nikhil
On 5/25/2018 2:25 AM, Thomas Monjalon wrote: 23/05/2018 07:51, Jerin Jacob: -Original Message- Date: Wed, 23 May 2018 02:36:42 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com CC: dev@dpdk.org, Nikhil Rao , sta...@dpdk.org Subject: [PATCH] eventdev: fix eth port in eth Rx adap

Re: [dpdk-dev] [RFC] eventdev: event tx adapter APIs

2018-06-01 Thread Rao, Nikhil
Hi Jerin, On 5/30/2018 12:56 PM, Jerin Jacob wrote: -Original Message- Hi Nikhil, I think, it is reasonable to have Tx adapter. Some top level comments to starts with, 1) Slow path API looks fine. The only comment is, How about changing rte_event_eth_tx_adapter_queue_add() instead of

Re: [dpdk-dev] [PATCH] test/eventdev: add multi port test to suite

2018-05-21 Thread Rao, Nikhil
Hi Vipin, Thanks for posting V2. On 5/21/2018 4:30 PM, Varghese, Vipin wrote: Hi Nikhil, Thanks for the inputs, I have shared the V2 with suggested changes. As for** +    adapter_free(); Is it necessary to call adapter_free() above ? With the changes suggested above Acked-by:

Re: [dpdk-dev] [PATCH v2] test/eventdev: add multi port test to suite

2018-05-21 Thread Rao, Nikhil
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Monday, May 21, 2018 4:27 PM > To: dev@dpdk.org; Rao, Nikhil ; Jain, Deepak K > > Cc: Varghese, Vipin > Subject: [PATCH v2] test/eventdev: add multi port test to suite > > Add a new test to enhan

Re: [dpdk-dev] [PATCH] eventdev/eth_rx_adapter: update the note field

2018-05-17 Thread Rao, Nikhil
Hi Vipin, Thanks for the patch, I have a suggestion below. On 5/17/2018 1:49 PM, Vipin Varghese wrote: rte_event_eth_rx_adapter_create allocates eth_devices for currently available eth devices. For dynamically created eth devices a new instance for rx adapter has to be created. Signed-off-by:

Re: [dpdk-dev] [PATCH] test/eventdev: add multi port test to suite

2018-05-17 Thread Rao, Nikhil
Hi Vipin, Thanks for the patch, looks good overall, a few comments below On 5/17/2018 3:47 PM, Vipin Varghese wrote: Add a new test to enhance the test suite, to allow multiple eth ports rx queue to be added to rx bridge adapter. Update the test to allow rx queues from multiple ports to be add

Re: [dpdk-dev] [PATCH] test/eventdev: update the port id to 16 bit

2018-05-15 Thread Rao, Nikhil
On 5/15/2018 9:18 PM, Vipin Varghese wrote: port id in test case is update to unsigned int 16 bit, to prvent compilation faulure when RTE_ETH_MAX port is set more ^^^ ^^^ ^^^ prevent failure RTE_MAX_ETHPORTS than 255. Signed-off-by: Vipin

Re: [dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start

2018-02-02 Thread Rao, Nikhil
> -Original Message- > From: Varghese, Vipin > Sent: Friday, February 2, 2018 1:39 PM > To: Jerin Jacob ; Rao, Nikhil > > Cc: dev@dpdk.org; Jacob, Jerin ; Van > Haaren, Harry ; Hemant Agrawal > ; Jain, Deepak K > Subject: RE: [PATCH] event/rx_adapter: fix i

Re: [dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start

2018-01-30 Thread Rao, Nikhil
Adding eventdev PMD folks for their suggestions on how to handle the return value from rte_event_dev_start() below. > -Original Message- > From: Varghese, Vipin > Sent: Wednesday, January 31, 2018 4:26 AM > To: dev@dpdk.org; Rao, Nikhil > Cc: Jain, Deepak K ;

Re: [dpdk-dev] [PATCH 2/3] event/octeontx: add support for event Rx adapter

2017-10-17 Thread Rao, Nikhil
On 10/17/2017 2:23 PM, Pavan Nikhilesh wrote: Add Rx adapter queue add and delete API for both generic eth_devices as well as HW backed eth_octeontx which supports direct event injection to event device. The HW injected event needs to be converted into mbuf, previously this was done in eth_octeon

Re: [dpdk-dev] [PATCH] eventdev: use new event enqueue in Rx adapter

2017-10-13 Thread Rao, Nikhil
On 10/13/2017 12:15 AM, Pavan Nikhilesh wrote: When event Rx adapter uses software based packet transfer, event op is always RTE_EVENT_OP_NEW. By using rte_event_enqueue_new_burst API the underlying event devices driver can use it as a hint to optimize enqueue operation if possible. Signed-off-b

Re: [dpdk-dev] [PATCH v2 3/4] event/dpaa2: support event eth adapter

2017-10-12 Thread Rao, Nikhil
On 10/12/2017 10:48 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/Makefile | 4 +- drivers/event/dpaa2/Makefile | 2 + drivers/event/dpaa2/dpaa2_eventdev.c | 151 ++- drivers/event/dpaa2/dpaa2_eventdev.h | 8 +

Re: [dpdk-dev] [PATCH 3/4] event/dpaa2: support event eth adapter

2017-10-10 Thread Rao, Nikhil
On 10/10/2017 11:21 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/Makefile | 4 +- drivers/event/dpaa2/Makefile | 2 + drivers/event/dpaa2/dpaa2_eventdev.c | 96 +++- drivers/event/dpaa2/dpaa2_eventdev.h | 8 +++

Re: [dpdk-dev] [PATCH 3/4] event/dpaa2: support event eth adapter

2017-10-10 Thread Rao, Nikhil
On 10/10/2017 11:21 PM, Nipun Gupta wrote: Signed-off-by: Nipun Gupta --- drivers/event/Makefile | 4 +- drivers/event/dpaa2/Makefile | 2 + drivers/event/dpaa2/dpaa2_eventdev.c | 96 +++- drivers/event/dpaa2/dpaa2_eventdev.h | 8 +++

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-05 Thread Rao, Nikhil
On 10/2/2017 4:09 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 2 Oct 2017 15:58:56 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com,

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-05 Thread Rao, Nikhil
On 10/3/2017 7:22 PM, Jerin Jacob wrote: -Original Message- Date: Sun, 24 Sep 2017 23:46:51 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra.

Re: [dpdk-dev] [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-10-04 Thread Rao, Nikhil
On 10/3/2017 5:06 PM, Pavan Nikhilesh Bhagavatula wrote: On Fri, Sep 22, 2017 at 02:47:14AM +0530, Nikhil Rao wrote: Hi Nikhil, Add unit tests for rte_event_eth_rx_adapter_xxx() APIs Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 399

Re: [dpdk-dev] [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-10-04 Thread Rao, Nikhil
On 10/2/2017 4:01 PM, Jerin Jacob wrote: -Original Message- Date: Sun, 24 Sep 2017 23:54:38 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra.

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Rao, Nikhil
On 9/25/2017 8:29 AM, Rao, Nikhil wrote: On 9/24/2017 11:46 PM, Rao, Nikhil wrote: On 9/22/2017 2:40 PM, Jerin Jacob wrote: When we worked on a prototype, we figured out that we need a separate event type for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER? The Reason is: - In the HW

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Rao, Nikhil
On 9/22/2017 11:38 AM, santosh wrote: In general api comment: Fix missing param definition like *service_id* above and pl. remove other unnecessary params description from api above. OK. +static inline int +valid_id(uint8_t id) +{ + return id < RTE_MAX_EVENT_ETH_RX_ADAPTER_INSTANCE

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-24 Thread Rao, Nikhil
On 9/24/2017 11:46 PM, Rao, Nikhil wrote: On 9/22/2017 2:40 PM, Jerin Jacob wrote: When we worked on a prototype, we figured out that we need a separate event type for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER? The Reason is: - In the HW based Rx adapter case, the packet are

Re: [dpdk-dev] [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-09-24 Thread Rao, Nikhil
On 9/22/2017 5:42 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 22 Sep 2017 02:47:14 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-24 Thread Rao, Nikhil
On 9/22/2017 2:40 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 22 Sep 2017 02:47:13 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.

Re: [dpdk-dev] [PATCH v4 1/4] eventdev: Add caps API and PMD callbacks for rte_event_eth_rx_adapter

2017-09-24 Thread Rao, Nikhil
On 9/21/2017 9:16 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 22 Sep 2017 02:47:11 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-23 Thread Rao, Nikhil
On 9/21/2017 9:13 PM, Pavan Nikhilesh Bhagavatula wrote: Hi Nikhil, Few comments Inline + * - 0: Success, statistics reset successfully. Invalid description. Thanks Pavan, for catching these, will fix. + * - <0: Error code on failure, if the adapter doesn't use a rte_service + * f

Re: [dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-19 Thread Rao, Nikhil
On 9/18/2017 9:06 PM, Van Haaren, Harry wrote: From: Rao, Nikhil +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -0,0 +1,1239 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "rte_eventdev.h"

Re: [dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-17 Thread Rao, Nikhil
On 9/15/2017 11:37 AM, Nipun Gupta wrote: -Original Message- From: Nikhil Rao [mailto:nikhil@intel.com] +static inline void +fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter, + uint8_t dev_id, + uint16_t rx_queue_id, + struct rte_mbuf **mbufs, +

Re: [dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-15 Thread Rao, Nikhil
On 9/15/2017 11:40 AM, santosh wrote: Hi Nikhil, On Thursday 14 September 2017 12:23 AM, Nikhil Rao wrote: Add common APIs for configuring packet transfer from ethernet Rx queues to event devices across HW & SW packet transfer mechanisms. A detailed description of the adapter is contained in t

Re: [dpdk-dev] [PATCH v3 2/4] eventdev: Add eth Rx adapter caps callback to SW evdev

2017-09-13 Thread Rao, Nikhil
On 9/13/2017 7:06 PM, Nipun Gupta wrote: -Original Message- From: Nikhil Rao [mailto:nikhil@intel.com] --- lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++ drivers/event/sw/sw_evdev.c| 13 + 2 files changed, 19 insertions(+) diff --git a/lib/librte_e

Re: [dpdk-dev] [PATCH v3 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-13 Thread Rao, Nikhil
On 9/12/2017 9:47 AM, Jerin Jacob wrote: -Original Message- --- a/lib/librte_eventdev/Makefile +++ b/lib/librte_eventdev/Makefile @@ -43,6 +43,7 @@ CFLAGS += $(WERROR_FLAGS) # library source files SRCS-y += rte_eventdev.c SRCS-y += rte_event_ring.c +SRCS-y += rte_event_eth_rx_adap

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-15 Thread Rao, Nikhil
On 8/14/2017 4:41 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 14 Aug 2017 14:18:15 +0530 From: "Rao, Nikhil" To: Jerin Jacob , "Eads, Gage" CC: "dev@dpdk.org" , "tho...@monjalon.net" , "Richardson, Bruce" , "Van

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-14 Thread Rao, Nikhil
On 8/10/2017 10:23 PM, Jerin Jacob wrote: -Original Message- Date: Wed, 9 Aug 2017 19:24:30 + From: "Eads, Gage" Makes sense. Are you thinking the helper function would do stop + reconfig with additional port + start + setup port, or just setup the port with an ID the app supplies

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-10 Thread Rao, Nikhil
On 8/1/2017 10:12 PM, Jerin Jacob wrote: I have had the application specify the name. so that it can call struct rte_service_spec *rte_service_get_by_name(const char *name); OK. I was thinking like there will be fixed name for the rx_adapter service like "eth_rx_adapter_%d"(%d for adapter id)

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-01 Thread Rao, Nikhil
On 7/29/2017 8:42 PM, Jerin Jacob wrote: -Original Message- Date: Thu, 27 Jul 2017 16:28:29 +0530 From: "Rao, Nikhil" To: Jerin Jacob CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, bruce.richard...@intel.com, harry.van.haa...@intel.com, hemant.agra.

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-27 Thread Rao, Nikhil
Hi Jerin and all, There are a few inconsistencies/complexities that I ran into with the implementation of the SW Rx event adapter, I have first summarized this email thread bringing together details scattered across various exchanges then I want to check if there are changes possible that wou

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-12 Thread Rao, Nikhil
On 7/10/2017 4:11 PM, Jerin Jacob wrote: -Original Message- I also think that the application should be able to call create() with > 1 ports. This would allow a single service to poll multiple NICs with WRR priority. Good point. Can we realize the same use case like below? - Instead

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-09 Thread Rao, Nikhil
Hi Jerin, thanks for your feedback, further comments below. On 7/7/2017 9:27 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 7 Jul 2017 20:33:19 +0530 From: Jerin Jacob /* adapter has inbuilt port, no need to create producer port */ #define RTE_EVENT_ETHDEV_CAP_INBUILT_PORT (1U

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-07-06 Thread Rao, Nikhil
On 7/6/2017 7:48 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 7 Jul 2017 03:22:31 +0530 From: Nikhil Rao To: jerin.ja...@caviumnetworks.com CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, bruce.richard...@intel.com, harry.van.haa...@intel.com, hemant.agra...@nxp.

Re: [dpdk-dev] [RFC] eventdev: add event adapter for ethernet Rx queues

2017-06-27 Thread Rao, Nikhil
On 6/26/2017 6:49 PM, Jerin Jacob wrote: Nikhil, Now that Harry send first version of service core patch? Are you planning for new version with above comments? Yes. I will post a new version. Thanks, Nikhil

Re: [dpdk-dev] [RFC] eventdev: add event adapter for ethernet Rx queues

2017-05-23 Thread Rao, Nikhil
Hi Jerin, Comments inline. Also, another function needed is bool rte_event_eth_rx_adapter_multithread_capable(void). This would be used to set the "multithread_capable" service core configuration parameter. Thanks, Nikhil On 5/11/2017 10:08 PM, Jerin Jacob wrote: > -Original Message

[dpdk-dev] [PATCH] eal: fix bug in x86 cmpset

2016-09-29 Thread Rao, Nikhil
On 9/29/2016 6:35 PM, Christian Ehrhardt wrote: > The patch misses a fixed: line which it should get I think. The bug has existed from the day the DPDK was open-sourced, i.e, there wasn't a specific commit that introduced this feature/bug, hence wasn't sure if it needed the fixes tag. > > Bu