Hi,
It looks good to me. I verified on arm platforms and didn't find any problem
currently.
BR,
Richael
> -Original Message-
> From: David Hunt
> Sent: Wednesday, June 23, 2021 8:04 PM
> To: dev@dpdk.org
> Cc: david.h...@intel.com; anatoly.bura...@intel.com; Ric
> -Original Message-
> From: David Hunt
> Sent: Wednesday, July 7, 2021 9:47 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: yux.ji...@intel.com
> Subject: Re: [PATCH v5 1/2] power: add support for cppc cpufreq
>
> Hi Richael,
>
> On 25/6/2021 3:02 AM, Richa
v6:
fix some checkpatch errors and warnings
rebase on Anatoly's patch: http://dpdk.org/patch/94763
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only in CPPC cpufreq
app/test/test_power.c | 3 +-
app/test/test_power_cpufreq.c
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 23 ++-
Thanks so much, I will rework it soon.
Best Regards,
Richael
> -Original Message-
> From: David Marchand
> Sent: Thursday, July 8, 2021 9:30 PM
> To: Richael Zhuang
> Cc: dev ; Yu Jiang ; David Hunt
>
> Subject: Re: [dpdk-dev] [PATCH v6 1/2] power: add support for
v7:
base on new API(open_core_sysfs_file) in http://dpdk.org/patch/95581,
update release note in release_21_08.rst.
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only in CPPC cpufreq
app/test/test_power.c | 3 +-
app/test
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 23 ++-
> -Original Message-
> From: David Marchand
> Sent: Friday, July 9, 2021 5:10 PM
> To: Richael Zhuang
> Cc: dev ; Yu Jiang ; David Hunt
>
> Subject: Re: [dpdk-dev] [PATCH v7 1/2] power: add support for cppc cpufreq
>
> On Fri, Jul 9, 2021 at 5:34
v8:
fix build issue with clang
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only in CPPC cpufreq
app/test/test_power.c | 3 +-
app/test/test_power_cpufreq.c | 26 +-
doc/guides/rel_notes/release_21_08.rst | 4
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
Acked-by: David Hunt
---
app/test/test_power.c
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
Acked-by: David Hunt
---
app/test/test_
> -Original Message-
> From: David Marchand
> Sent: Friday, July 9, 2021 10:07 PM
> To: Richael Zhuang
> Cc: dev ; Yu Jiang ; David Hunt
>
> Subject: Re: [dpdk-dev] [PATCH v8 0/2] power: add support for cppc cpufreq
> driver
>
> On Fri, Jul 9, 2021 at 12
v1:
fix CPU frequency check
Richael Zhuang (1):
test/power: check cpuinfo cur freq before scaling cur freq
app/test/test_power_cpufreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.20.1
cpuinfo_cur_freq before
scaling_cur_freq to make sure it works for all cpufreq drivers.
Fixes: ff6dfb8e492f ("test/power: fix CPU frequency check")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 4 ++--
1 file changed, 2 insert
> -Original Message-
> From: David Hunt
> Sent: Wednesday, July 14, 2021 5:15 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: zhiminx.hu...@intel.com; sta...@dpdk.org
> Subject: Re: [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling
> cur freq
>
&
> -Original Message-
> From: David Hunt
> Sent: Wednesday, July 14, 2021 6:14 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: zhiminx.hu...@intel.com; sta...@dpdk.org; nd
> Subject: Re: [PATCH v1 1/1] test/power: check cpuinfo cur freq before scaling
> cur freq
>
v1:
fix CPU frequency check
v2:
add rounding for pstate driver
Richael Zhuang (1):
test/power: fix CPU frequency check
app/test/test_power_cpufreq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.20.1
here change the
check sequence to make sure it works for all cpufreq drivers.
Besides, add rounding for pstate driver.
Fixes: ff6dfb8e492f ("test/power: fix CPU frequency check")
Cc: david.h...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpu
> -Original Message-
> From: David Hunt
> Sent: Wednesday, July 14, 2021 8:23 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: zhiminx.hu...@intel.com; sta...@dpdk.org
> Subject: Re: [PATCH v2 1/1] test/power: fix CPU frequency check
>
> Hi Richael,
>
>
v1:
adding check for freq count
Richael Zhuang (1):
power: check freq count before filling the freqs array
lib/power/power_cppc_cpufreq.c | 5 +
lib/power/power_pstate_cpufreq.c | 5 +
2 files changed, 10 insertions(+)
--
2.20.1
t byte offset 464.
Coverity issue: 371913
Signed-off-by: Richael Zhuang
---
lib/power/power_cppc_cpufreq.c | 5 +
lib/power/power_pstate_cpufreq.c | 5 +
2 files changed, 10 insertions(+)
diff --git a/lib/power/power_cppc_cpufreq.c b/lib/power/power_cppc_cpufreq.c
index e92973ab54..db63
> -Original Message-
> From: Thomas Monjalon
> Sent: Friday, July 23, 2021 3:43 AM
> To: Richael Zhuang
> Cc: dev@dpdk.org; David Hunt
> Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: check freq count before filling
> the freqs array
>
> 21/07/2021 11:
v1:
add check for freq count
v2:
add "Fixes" tag in commit message
Richael Zhuang (1):
power: check freq count before filling the freqs array
lib/power/power_cppc_cpufreq.c | 5 +
lib/power/power_pstate_cpufreq.c | 5 +
2 files changed, 10 insertions(+)
--
2.20.1
t byte offset 464.
Coverity issue: 371913
Fixes: 82432c45d631 ("power: check freq count before filling")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
lib/power/power_cppc_cpufreq.c | 5 +
lib/power/power_pstate_cpufreq.c | 5 +
2 files
v1:
add check for freq count
v2:
add "Fixes" tag in commit message
v3:
update commit message
Richael Zhuang (1):
power: check freq count before filling the freqs array
lib/power/power_cppc_cpufreq.c | 5 +
lib/power/power_pstate_cpufreq.c | 5 +
2 files changed, 10
t byte offset 464.
Coverity issue: 371913
Fixes: ef1cc88f1837 ("power: support cppc_cpufreq driver")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
lib/power/power_cppc_cpufreq.c | 5 +
lib/power/power_pstate_cpufreq.c | 5 +
2 files changed,
v4:
rebase on Anatoly's patch: http://dpdk.org/patch/94676
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only when using CPPC cpufreq
app/test/test_power.c | 3 +-
app/test/test_power_cpufreq.c | 26 +-
lib/power/meson.
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 23 ++-
avid Hunt
> Sent: Tuesday, June 22, 2021 9:28 PM
> To: dev@dpdk.org
> Cc: anatoly.bura...@intel.com; step...@networkplumber.org; Richael
> Zhuang ; Reshma Pattan
> ; nd
> Subject: Re: [PATCH v5 2/2] power: refactor pstate and acpi code
>
> Adding people to the CC list that
> -Original Message-
> From: David Hunt
> Sent: Wednesday, June 23, 2021 10:10 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: yux.ji...@intel.com
> Subject: Re: [PATCH v4 1/2] power: add support for cppc cpufreq
>
> Hi Richael
>
> On 23/6/2021
v5:
rebase on Anatoly's patch: http://dpdk.org/patch/94763
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only when using CPPC cpufreq
app/test/test_power.c | 3 +-
app/test/test_power_cpufreq.c | 26 +-
lib/power/meson.
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 23 ++-
agement")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Change-Id: I3b0266415a2b655d58294a3f51a6051bc1e5fc7f
CustomizedGitHooks: yes
Jira: ENTWLS-2032
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/app/test/test_powe
es for turbo feature")
Cc: lukaszx.krakow...@intel.com
Cc: sta...@dpdk.org
CustomizedGitHooks: yes
Change-Id: I5702d5c647e941253c556ae2be8c1edeefacb618
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/t
or example, we write "240" to
"/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the
value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@
es for turbo feature")
Cc: lukaszx.krakow...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index c4f4541ac..7
or example, we write "240" to
"/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the
value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@
or example, we write "240" to
"/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the
value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@
or example, we write "240" to
"/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the
value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@
es for turbo feature")
Cc: lukaszx.krakow...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index c4f4541ac..7
This series fixed some bugs in unit tests for power library.
v3:
Break patch into series for individual bug fixes.
Richael Zhuang (3):
test/power: round cpuinfo cur freq value in cpufreq autotest
test/power: fix a bug in cpufreq autotest
test/power: add delay before checking cpuinfo cur
. So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/app/tes
es for turbo feature")
Cc: lukaszx.krakow...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index 1f4d8bb05..c
k.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
index cda74bd8a..7a93bc90a 100644
--- a/app/test/test_power_cpufreq.c
+++ b/app/test/test_power_cpufreq.c
@@ -
Hi,
Thanks for your comments.
My change is to make the check_power_turbo() to continue only when
rte_power_turbo_status(TEST_POWER_LCORE_ID) returns 1 which means turbo is
available.
-Original Message-
From: Burakov, Anatoly
Sent: Wednesday, April 7, 2021 5:59 PM
To: Richael Zhuang
Hi Liang,
> -Original Message-
> From: Liang Ma
> Sent: Wednesday, April 7, 2021 6:15 PM
> To: Richael Zhuang
> Cc: dev@dpdk.org; alan.ca...@intel.com; sta...@dpdk.org; David Hunt
> ; Pablo de Lara
> Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay befo
Hi Liang,
Sorry that last email contains "confidential notice", so I resend it.
> -Original Message-
> From: Liang Ma
> Sent: Wednesday, April 7, 2021 6:15 PM
> To: Richael Zhuang
> Cc: dev@dpdk.org; alan.ca...@intel.com; sta...@dpdk.org; David Hunt
> ;
> -Original Message-
> From: Liang Ma
> Sent: Thursday, April 8, 2021 3:55 PM
> To: Richael Zhuang
> Cc: dev@dpdk.org; alan.ca...@intel.com; sta...@dpdk.org; David Hunt
> ; Pablo de Lara ;
> nd
> Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay b
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, April 8, 2021 10:56 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: lukaszx.krakow...@intel.com; sta...@dpdk.org; David Hunt
>
> Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/power: fix a bug in cpufreq
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, April 8, 2021 10:56 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: lukaszx.krakow...@intel.com; sta...@dpdk.org; David Hunt
>
> Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/power: fix a bug in cpufreq
>
This series fixed some bugs in unit tests for power library.
v4:
abort the patch about checking -ENOTSUP in turbo test.
Richael Zhuang (2):
test/power: round cpuinfo cur freq value in cpufreq autotest
test/power: add delay before checking cpuinfo cur freq
app/test/test_power_cpufreq.c
. So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/app/tes
mum to a maximum frequency. And it's not the
driver/software issue.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 25 ++---
1 file chang
v5:
abort the patch about checking -ENOTSUP in turbo test.
Richael Zhuang (2):
test/power: add delay before checking cpuinfo cur freq
test/power: round cpuinfo cur freq value in cpufreq autotest
app/test/test_power_cpufreq.c | 41 ++-
1 file changed, 36
mum to a maximum frequency. And it's not the
driver/software issue.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 27 ++-
1 file chang
. So need to
round the value.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/app/tes
> -Original Message-
> From: David Hunt
> Sent: Tuesday, April 20, 2021 8:39 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: nd ; alan.ca...@intel.com; sta...@dpdk.org; Pablo de
> Lara
> Subject: Re: [PATCH v5 1/2] test/power: add delay before checking cpuinfo
>
v1:
add support for cppc cpufreq driver
Richael Zhuang (1):
power: add support for cppc cpufreq
app/test/test_power.c | 3 +-
app/test/test_power_cpufreq.c | 3 +-
lib/power/meson.build | 1 +
lib/power/power_cppc_cpufreq.c | 807 +
lib
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, April 22, 2021 5:06 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: nd ; David Hunt
> Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq
>
> On 22-Apr-21 7:15 AM, Richael Zhu
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, April 22, 2021 6:00 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: nd ; David Hunt
> Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq
>
> On 22-Apr-21 10:29
> -Original Message-
> From: Burakov, Anatoly
> Sent: Friday, April 23, 2021 7:38 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: nd ; David Hunt
> Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq
>
> On 22-Apr-21 11:02
> -Original Message-
> From: Anatoly Burakov
> Sent: Friday, April 23, 2021 7:03 PM
> To: dev@dpdk.org
> Cc: step...@networkplumber.org; Richael Zhuang
> ; reshma.pat...@intel.com;
> david.h...@intel.com
> Subject: [21.08 PATCH v4 2/2] power: refac
v2:
rebase on Anatoly's patch: http://dpdk.org/patch/92077;
fix check_cur_freq bug: round cur freq only when using CPPC driver
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only when using CPPC cpufreq
app/test/test_power.c | 3 +-
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhua...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 23 ++-
v3:
rebase on Anatoly's patch: http://dpdk.org/patch/92077;
fix check_cur_freq bug: round cur freq only when using CPPC driver
Richael Zhuang (2):
power: add support for cppc cpufreq
test/power: round cpuinfo cur freq only when using CPPC cpufreq
app/test/test_power.c | 3 +-
Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are
supported, which are both not available on arm64 platforms. Add
support for cppc_cpufreq driver which works on most arm64 platforms.
Signed-off-by: Richael Zhuang
---
app/test/test_power.c | 3 +-
app/test
req can be 2401000 which is equal to freqs[0].It should
not be rounded to 240.
Fixes: 606a234c6d360 ("test/power: round CPU frequency to check")
Cc: richael.zhu...@arm.com
Cc: sta...@dpdk.org
Signed-off-by: Richael Zhuang
---
app/test/test_power_cpufreq.c | 23 ++-
73 matches
Mail list logo
