Re: [kmods PATCH v2] windows/netuio: add Intel device ID

2021-11-24 Thread William Tu
Hi, Can we merge this patch? Thank you! William On Tue, Oct 19, 2021 at 12:02 PM William Tu wrote: > > The patch adds three Intel device IDs, > I350 (0x1521), 82574L (0x10D3), and 82599 (0x10ED). > > Signed-off-by: William Tu > Acked-by: Dmitry Kozlyuk > Acked-by: Pall

[dpdk-dev] [PATCH v4] net/e1000: build on Windows

2021-10-19 Thread William Tu
This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3 (8274L), verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-by: William Tu Acked-by: Haiyue

Re: [dpdk-dev] [PATCH v3] net/e1000: build on Windows

2021-10-19 Thread William Tu
Hi Thomas, Can we apply this patch? Thanks William On Sat, Oct 9, 2021 at 9:32 AM William Tu wrote: > > This patch enables building the e1000 driver for Windows. > I tested using two Windows VM on top of VMware Fusion, > creating two e1000 devices with device ID 0x10D3 (8274L), >

[dpdk-dev] [kmods PATCH v2] windows/netuio: add Intel device ID

2021-10-19 Thread William Tu
The patch adds three Intel device IDs, I350 (0x1521), 82574L (0x10D3), and 82599 (0x10ED). Signed-off-by: William Tu Acked-by: Dmitry Kozlyuk Acked-by: Pallavi Kadam --- v2: * fix the device string suggested by Pallavi * combine this patch with the 82599 ixgbevf --- windows/netuio/netuio.inf

Re: [dpdk-dev] [kmods PATCH] windows/netuio: add interrupt support

2021-10-12 Thread William Tu
On Mon, Oct 11, 2021 at 6:11 PM Dmitry Kozlyuk wrote: > > Add IOCTL for interrupt event delivery to user space. > > * IOCTL_NETUIO_INTR_CONTROL: > Enable/disable the delivery of interrupt events. > This is a software switch to ignore received interrupts. > Programming the HW to stop issuing

[dpdk-dev] [PATCH v1] doc: fix typo of Intel device name

2021-10-11 Thread William Tu
The device name should be 82574L Gigabit Ethernet Controller. Signed-off-by: William Tu Cc: Haiyue Wang --- doc/guides/nics/e1000em.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/e1000em.rst b/doc/guides/nics/e1000em.rst index 041c9a09a3a5..b9249b62f3d6

[dpdk-dev] [kmods PATCH v1] windows/netuio: add Intel e1000 device IDs

2021-10-11 Thread William Tu
Add Intel Ethernet e1000 device IDs to netuio inf file. Signed-off-by: William Tu -- DPDK patch at: http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012...@gmail.com/T/#t --- windows/netuio/netuio.inf | 4 1 file changed, 4 insertions(+) diff --git a/windows/netuio/netuio.inf b/windows

Re: [dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation

2021-10-09 Thread William Tu
On Sat, Oct 9, 2021 at 1:20 PM Dmitry Kozlyuk wrote: snip > > > +Access to physical addresses is provided by a kernel-mode driver, > > > virt2phys. > > > +It is mandatory for allocating physically-contiguous memory which is > > > required > > > +by hardware PMDs. > > > > Should we add specific

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-09 Thread William Tu
> > +Windows Configuration > > +- > > + > > +- Follow the :doc:`guide for Windows <../windows_gsg/run_apps>` > > + to setup the basic DPDK environment. > > + > > +- Identify the Intel\ |reg| Ethernet adapter. > > + > > +- To load NetUIO driver, follow the steps mentioned in `dp

[dpdk-dev] [PATCH v3] net/e1000: build on Windows

2021-10-09 Thread William Tu
This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3 (8274L), verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-by: William Tu Acked-by: Haiyue

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread William Tu
On Fri, Oct 8, 2021 at 5:02 PM Kadam, Pallavi wrote: > > > On 10/8/2021 6:53 AM, William Tu wrote: > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000 devices with device ID

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread William Tu
On Fri, Oct 8, 2021 at 1:35 PM Dmitry Kozlyuk wrote: > > 2021-10-08 06:53 (UTC-0700), William Tu: > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000 devices with device ID 0x1

[dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread William Tu
This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3, verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-by: William Tu Cc: Haiyue Wang --- A short

Re: [dpdk-dev] [PATCH v1] windows/netuio: fix pci resouce translation

2021-10-08 Thread William Tu
On Thu, Oct 7, 2021 at 5:23 PM William Tu wrote: > > When BAR array is filled like this > * Bar[4] = c844000c > * Bar[5] = null > ex: > while ((descriptor->Type != CmResourceTypeMemory) || > !(descriptor->Flags & CM_RESOURCE_MEMORY_

Re: [dpdk-dev] [PATCH] net/e1000: build on Windows

2021-10-08 Thread William Tu
On Thu, Oct 7, 2021 at 11:54 PM David Marchand wrote: > > On Thu, Oct 7, 2021 at 10:25 PM William Tu wrote: > > > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000

[dpdk-dev] [PATCH v1] windows/netuio: fix pci resouce translation

2021-10-07 Thread William Tu
error. So I fix it by setting the status to STATUS_SUCCESS. Signed-off-by: William Tu --- Found the issue when adding the e1000 PMD support. http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012...@gmail.com/T/#u --- windows/netuio/netuio_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[dpdk-dev] [PATCH v2] windows/netuio: add Intel 82599 Virtual Function

2021-10-07 Thread William Tu
Add Intel 82599 10GbE Ethernet adapter VF device IDs (0x10ED) to netuio inf file. Signed-off-by: William Tu --- v2: * use "Intel(R) 82599 Virtual Function" suggested by Pallavi * the dpdk part of the code is on main branch commit 4902f13875e7 ("net/e1000: build on Windows")

[dpdk-dev] [PATCH] net/e1000: build on Windows

2021-10-07 Thread William Tu
This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3, verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-by: William Tu --- Example when running: PS

Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows

2021-10-07 Thread William Tu
On Thu, Oct 7, 2021 at 4:58 AM Thomas Monjalon wrote: > > Hi, > > What is the conclusion for this patch? > > 26/09/2021 05:22, William Tu: > > On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk > > wrote: > > > > > > 2021-09-24 18:08 (UTC+), Wi

[dpdk-dev] [PATCH v5 4/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu Acked-by: Pallavi Kadam Acked-by: Dmitry Kozlyuk --- doc/guides/nics/features/ixgbe.ini

[dpdk-dev] [PATCH v5 3/4] cryptodev: build on Windows

2021-10-06 Thread William Tu
From: Tal Shnaiderman Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/cryptodev/cryptodev_pmd.c | 2 ++ lib/cryptodev/rte_cryptodev.c | 1

[dpdk-dev] [PATCH v5 2/4] security: build on Windows

2021-10-06 Thread William Tu
From: Tal Shnaiderman Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/meson.build | 1 + lib/security/version.map | 3 --- 2 files changed, 1 insertion(+), 3

[dpdk-dev] [PATCH v5 1/4] security: use the net library for IP structs

2021-10-06 Thread William Tu
From: Tal Shnaiderman Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/net/rte_ip.h| 1 + lib/security/meson.build

[dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
Windows William Tu (1): net/ixgbe: build on Windows --- v5: * fix error due to "invalid register for .seh_savexmm" However, I'm not able to reproduce the error on my mingw. I will check the DPDK CI... * add release notes and documentation suggested by Pallavi v4: * fix mingw bu

Re: [dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
Hi David, Thank you for pointing this out. On Wed, Oct 6, 2021 at 5:10 AM David Marchand wrote: > > Hello William, > > {standard input}: Assembler messages: > {standard input}:7067: Error: invalid register for .seh_savexmm > {standard input}:7069: Error: invalid register for .seh_savexmm > {stand

Re: [dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-06 Thread William Tu
On Tue, Oct 5, 2021 at 10:33 PM Kadam, Pallavi wrote: > > > On 10/5/2021 10:02 AM, William Tu wrote: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > I tested on AWS using ixgbe VF

[dpdk-dev] [PATCH v4 4/4] net/ixgbe: build on Windows

2021-10-05 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 + drivers/net/ixgbe/base/ixgbe_osdep.h | 9

[dpdk-dev] [PATCH v4 3/4] cryptodev: build on Windows

2021-10-05 Thread William Tu
From: Tal Shnaiderman Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/cryptodev/cryptodev_pmd.c | 2 ++ lib/cryptodev/rte_cryptodev.c | 1

[dpdk-dev] [PATCH v4 2/4] security: build on Windows

2021-10-05 Thread William Tu
From: Tal Shnaiderman Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/meson.build | 1 + lib/security/version.map | 3 --- 2 files changed, 1 insertion(+), 3

[dpdk-dev] [PATCH v4 1/4] security: use the net library for IP structs

2021-10-05 Thread William Tu
From: Tal Shnaiderman Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman Acked-by: Akhil Goyal Acked-by: William Tu --- lib/net/rte_ip.h| 1 + lib/security/meson.build

[dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-05 Thread William Tu
Windows William Tu (1): net/ixgbe: build on Windows --- v4: * fix mingw build by defining the IPPROTO_SCTP if needed * simplify the meson file * change patch title, rebase to main v3: * I include Tal's patch series due to some fixes. * apply on master, after commit f1f6ebc0eaf6 ("e

[dpdk-dev] [PATCH v3 4/4] net/ixgbe: Add support for Windows

2021-10-01 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 + drivers/net/ixgbe/base/ixgbe_osdep.h | 5

[dpdk-dev] [PATCH v3 3/4] cryptodev: build on Windows

2021-10-01 Thread William Tu
From: Tal Shnaiderman Build the cryptography device library on Windows OS by removing unneeded include and exports blocking the compilation. Signed-off-by: Tal Shnaiderman Acked-by: William Tu --- lib/cryptodev/cryptodev_pmd.c | 2 ++ lib/cryptodev/rte_cryptodev.c | 1 - lib/cryptodev

[dpdk-dev] [PATCH v3 2/4] security: build on Windows

2021-10-01 Thread William Tu
From: Tal Shnaiderman Build the security library on Windows. Remove unneeded export from version file. Signed-off-by: Tal Shnaiderman Acked-by: William Tu --- lib/meson.build | 1 + lib/security/version.map | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v3 1/4] security: use the net library for IP structs

2021-10-01 Thread William Tu
From: Tal Shnaiderman Remove the netinet includes and replaces them with rte_ip.h to support the in_addr/in6_addr structs on all operating systems. Signed-off-by: Tal Shnaiderman Acked-by: William Tu --- lib/net/rte_ip.h| 1 + lib/security/meson.build| 2 +- lib/security

[dpdk-dev] [PATCH v3 0/4] net/ixgbe: Add support for Windows

2021-10-01 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu Tal Shnaiderman (3): security: use the net library for IP structs security: build on

Re: [dpdk-dev] [PATCH 2/2] security: build on Windows

2021-10-01 Thread William Tu
On Wed, Sep 29, 2021 at 12:55 PM Kadam, Pallavi wrote: > > > On 9/15/2021 9:26 AM, Tal Shnaiderman wrote: > > Build the security library on Windows. > > > > Remove unneeded export from version file. > > > > Signed-off-by: Tal Shnaiderman > > --- > > Depends-on: patch-98796 ("cryptodev: build on W

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-09-30 Thread William Tu
On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile wrote: > > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system

Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows

2021-09-25 Thread William Tu
On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk wrote: > > 2021-09-24 18:08 (UTC+0000), William Tu: > > Windows does not support linker option '/-no-whole-archive' > > or '/whole-archive'. The patch removes them under Windows build. > > > > Sign

Re: [dpdk-dev] RTE_REGISTER_BUS does not work on Windows

2021-09-25 Thread William Tu
I've resolved the issue by adding -Wl,/WHOLEARCHIVE at libdpdk.pc Thanks William On Fri, Sep 24, 2021 at 7:41 AM William Tu wrote: > > Hi, > > I continued my experiment and observed below > 1. for dpdk-testpmd.exe which works fine, the functions in driver/bus/pci/* > are

Re: [dpdk-dev] [PATCH v1] windows/netuio: add Intel 82599 10GbE VF device ID

2021-09-25 Thread William Tu
On Fri, Sep 24, 2021 at 3:24 PM Kadam, Pallavi wrote: > > Hi William, > > On 9/22/2021 2:19 PM, William Tu wrote: > > Add Intel 82599 10GbE Ethernet adapter VF device IDs to > netuio inf file in order to enable them on Windows. > > Signed-off-by: William Tu > --- &g

[dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows

2021-09-24 Thread William Tu
Windows does not support linker option '/-no-whole-archive' or '/whole-archive'. The patch removes them under Windows build. Signed-off-by: William Tu --- buildtools/pkg-config/meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/b

Re: [dpdk-dev] RTE_REGISTER_BUS does not work on Windows

2021-09-24 Thread William Tu
On Thu, Sep 23, 2021 at 10:47 AM William Tu wrote: > > Hi, > > I'm trying to run OVS-DPDK on Windows (building OVS binaries and > statically link DPDK windows library), and it doesn't work due to > rte_bus_scan() find no available devices. (However, when using > dp

Re: [dpdk-dev] [PATCH] lib: remove sched.h from public headers

2021-09-23 Thread William Tu
then hit the issue. Verify the patch works correctly and solve my problem. Acked-by: William Tu

[dpdk-dev] RTE_REGISTER_BUS does not work on Windows

2021-09-23 Thread William Tu
Hi, I'm trying to run OVS-DPDK on Windows (building OVS binaries and statically link DPDK windows library), and it doesn't work due to rte_bus_scan() find no available devices. (However, when using dpdk-testpmd.exe, it finds the device successfully) I realized that the PCI bus driver calls RTE_RE

[dpdk-dev] [PATCH v1] windows/netuio: add Intel 82599 10GbE VF device ID

2021-09-22 Thread William Tu
Add Intel 82599 10GbE Ethernet adapter VF device IDs to netuio inf file in order to enable them on Windows. Signed-off-by: William Tu --- windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf index d166868..6b45ab0

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Add support for Windows

2021-09-22 Thread William Tu
I forgot to add the CC list. On Wed, Sep 22, 2021 at 1:58 PM William Tu wrote: > > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. > I tested on AWS using Intel Corporation 82599 Ethernet > Controller Virtual

[dpdk-dev] [PATCH v2] net/ixgbe: Add support for Windows

2021-09-22 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using Intel Corporation 82599 Ethernet Controller Virtual Function [8086:10ed], using dpdk-testpmd. Signed-off-by: William Tu --- Depends-on: series-18880

Re: [dpdk-dev] [PATCH 2/2] security: build on Windows

2021-09-19 Thread William Tu
On Wed, Sep 15, 2021 at 9:27 AM Tal Shnaiderman wrote: > > Build the security library on Windows. > > Remove unneeded export from version file. > > Signed-off-by: Tal Shnaiderman > --- Acked-by: William Tu

Re: [dpdk-dev] [PATCH 1/2] security: use the net library for IP structs

2021-09-19 Thread William Tu
On Wed, Sep 15, 2021 at 9:27 AM Tal Shnaiderman wrote: > > Remove the netinet includes and replaces them > with rte_ip.h to support the in_addr/in6_addr structs > on all operating systems. > > Signed-off-by: Tal Shnaiderman > --- Acked-by: William Tu I sent a similar

Re: [dpdk-dev] [PATCH] cryptodev: build on Windows

2021-09-19 Thread William Tu
On Mon, Sep 13, 2021 at 10:19 AM Tal Shnaiderman wrote: > > Build the cryptography device library on Windows OS > by removing unneeded include and exports blocking the > compilation. > > Signed-off-by: Tal Shnaiderman Acked-by: William Tu I sent similar patch to enable

Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-18 Thread William Tu
On Sat, Sep 18, 2021 at 7:55 AM Dmitry Kozlyuk wrote: > > 2021-09-18 07:24 (UTC-0700), William Tu: > > On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk > > wrote: > > > > > > 2021-09-15 18:44 (UTC+), William Tu: > > > > This patch enables buildi

Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-18 Thread William Tu
On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk wrote: > > 2021-09-15 18:44 (UTC+0000), William Tu: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > Tal Shnaiderman posted patches for cryp

Re: [dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-15 Thread William Tu
On Wed, Sep 15, 2021 at 12:05 PM Dmitry Kozlyuk wrote: > > 2021-09-15 18:44 (UTC+0000), William Tu: > > This patch enables building the ixgbe driver for Windows. > > It also enables its dependencies on security and cryptodev. > > Tal Shnaiderman posted patches for cryp

[dpdk-dev] [PATCH v1] net/ixgbe: Add support for Windows

2021-09-15 Thread William Tu
This patch enables building the ixgbe driver for Windows. It also enables its dependencies on security and cryptodev. I tested on AWS using ixgbe VF device, using dpdk-testpmd. Signed-off-by: William Tu --- drivers/net/ixgbe/base/ixgbe_hv_vf.c | 1 + drivers/net/ixgbe/base/ixgbe_osdep.h | 10

Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix export list

2021-09-01 Thread William Tu
> > Signed-off-by: Dmitry Kozlyuk > --- LGTM, thanks. Acked-by: William Tu

Re: [dpdk-dev] [PATCH 1/2] eal: remove Windows-specific list of common files

2021-09-01 Thread William Tu
y mistake), then excluded from the > export list for no reason other than not being built. Restore it. > > Fixes: df3ff6be2b33 ("eal: simplify meson build of common directory") > Cc: tho...@monjalon.net > > Signed-off-by: Dmitry Kozlyuk > --- LGTM, thanks. Acked-by: William Tu

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-30 Thread William Tu
On Mon, Aug 30, 2021 at 12:12 AM MichaƂ Krawczyk wrote: [...] > Hi William, > > It's great to hear that you're working on ENA support for Windows! > > ENA PMD uses admin interrupt for processing all the commands like > creating the IO queues, setting up the MTU, etc., and also for the > AENQ event

[dpdk-dev] Question about virtio-net device on google cloud engine

2021-08-30 Thread William Tu
Hi, I'm testing DPDK on virtio device using a Linux VM (ubuntu 21.04) from google cloud. But I couldn't get it to work. I wonder 1. Is "no modern virtio pci device found." expected? 2. Should I use vfio-pci, instead uio_pci_generic? 3. maybe on the public cloud, promiscuous mode is not allowed?

Re: [dpdk-dev] DPDK 21.11+ Windows Roadmap

2021-08-26 Thread William Tu
Hi Dmitry, Thanks, I have one question. On Thu, Aug 26, 2021 at 5:19 PM Dmitry Kozlyuk wrote: > > This roadmap has been discussed on Windows community calls Aug 5 and Aug 19 > and it met no principal objections. It extends beyond the nearest release, > but it is useful to have a comprehensive bac

[dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-08-24 Thread William Tu
ggested-by: Nick Connolly Suggested-by: Dmitry Kozliuk Acked-by: Dmitry Kozliuk Signed-off-by: William Tu --- v8-v9: * Acked by Dmitry Kozliuk * remove #ifdef at RTE_TAILQ_FOREACH_SAFE * remove period at title v7-v8: * remove duplicate RTE_TAILQ_FOREACH_SAFE at rte_os.h put the macro at rte_tailq

Re: [dpdk-dev] [PATCH v8] eal: remove sys/queue.h from public headers.

2021-08-24 Thread William Tu
On Mon, Aug 23, 2021 at 12:14 PM Dmitry Kozlyuk wrote: > > 2021-08-23 13:03 (UTC+0000), William Tu: > [...] > > /* This macro permits both remove and free var within the loop safely.*/ > > -#ifndef TAILQ_FOREACH_SAFE > > -#define TAILQ_FOREACH_

[dpdk-dev] [PATCH v8] eal: remove sys/queue.h from public headers.

2021-08-23 Thread William Tu
ed-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v7-v8: * remove duplicate RTE_TAILQ_FOREACH_SAFE at rte_os.h put the macro at rte_tailq.h * remove inline comments * diff https://github.com/williamtu/dpdk/compare/a4144ff11b..6cb7cd8daf v6-v7: * remove some redu

Re: [dpdk-dev] [PATCH v7] eal: remove sys/queue.h from public headers.

2021-08-23 Thread William Tu
Hi Dmitry, Thanks for your feedback. On Thu, Aug 19, 2021 at 4:29 PM Dmitry Kozlyuk wrote: > > 2021-08-18 23:26 (UTC+0000), William Tu: > [...] > > diff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/linux/include/rte_os.h > > index 1618b4df22..ce5b0aed52 100644 > >

Re: [dpdk-dev] [PATCH] build: propagate Windows system dependencies to pkg-config

2021-08-20 Thread William Tu
s: support exit and panic") > Cc: tal...@nvidia.com > Cc: sta...@dpdk.org > > Reported-by: William Tu > Signed-off-by: Dmitry Kozlyuk > --- Thanks for the fix. I've tested on my Windows environment and it works ok. the libdpdk.pc shows the required libraries. Acked-by: William Tu

Re: [dpdk-dev] Windows community call: MoM 2021-08-04

2021-08-19 Thread William Tu
[...] > > Target machine cpu: x86_64 > > Pkg-config binary for MachineChoice.HOST is not cached. > > Pkg-config binary missing from cross or native file, or env var undefined. > > Trying a default Pkg-config fallback at pkg-config > > Found pkg-config: > > C:\ProgramData\chocolatey\lib\pkgconfiglit

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-18 Thread William Tu
On Sat, Aug 14, 2021 at 4:31 AM Dmitry Kozlyuk wrote: > > Hi William, > > 2021-08-14 03:36 (UTC+0000), William Tu: > > I don't have a physical Windows testbed so I want to see if I can > > get virtual nic working, in this case ENA driver on AWS. > > The p

Re: [dpdk-dev] Windows community call: MoM 2021-08-04

2021-08-18 Thread William Tu
On Tue, Aug 17, 2021 at 7:14 AM Bruce Richardson wrote: > > On Fri, Aug 06, 2021 at 04:17:32PM -0700, William Tu wrote: > > On Thu, Aug 5, 2021 at 12:15 PM Dmitry Kozlyuk > > wrote: > > > > > snip > > > > > # Porting OvS build system to meson (W

[dpdk-dev] [PATCH v7] eal: remove sys/queue.h from public headers.

2021-08-18 Thread William Tu
ed-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v6-v7: * remove some redundant "#incldue " * remove extra newline, add comment at rte_os.h for windows use of bundled sys/queue v5-v6: * fix tab/indent issue, fix type and spelling * fix duplicate RTE_TAI

[dpdk-dev] [PATCH RFC] net/virtio: Add virtio support for Windows.

2021-08-15 Thread William Tu
I looked at Dmitry's patch [1] a while ago and found that now it's not much work to enable the virtio support. Pass build, but I haven't tested it yet. I plan to try it on GCP. [1] http://inbox.dpdk.org/dev/20200228060727.192491-1-dmitry.kozl...@gmail.com/ Signed-off-by: William T

Re: [dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD

2021-08-15 Thread William Tu
On Sat, Aug 14, 2021 at 10:01 AM Dmitry Kozlyuk wrote: > > 2021-08-14 08:55 (UTC-0700), William Tu: > > Hi Dmitry, > > > > I'm looking at this patch and have some questions. > > > > On Thu, Feb 27, 2020 at 10:08 PM Dmitry Kozlyuk > > w

Re: [dpdk-dev] [RFC PATCH 5/5] mk/windows: add virtio-net PMD

2021-08-14 Thread William Tu
Hi Dmitry, I'm looking at this patch and have some questions. On Thu, Feb 27, 2020 at 10:08 PM Dmitry Kozlyuk wrote: > > Signed-off-by: Dmitry Kozlyuk > --- > drivers/net/virtio/virtio_ethdev.c| 4 + > kernel/windows/netuio/netuio.inf | 6 + > lib/librte_eal/window

Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-14 Thread William Tu
On Sat, Aug 14, 2021 at 4:31 AM Dmitry Kozlyuk wrote: > > Hi William, > > 2021-08-14 03:36 (UTC+0000), William Tu: > > I don't have a physical Windows testbed so I want to see if I can > > get virtual nic working, in this case ENA driver on AWS. > > The p

[dpdk-dev] [PATCH RFC] net/ena: Add Windows support.

2021-08-13 Thread William Tu
places in ENA driver? I copy some of the pthread code from https://nachtimwald.com/2019/04/05/cross-platform-thread-wrapper/ https://stackoverflow.com/questions/10905892/equivalent-of-gettimeday-for-windows Thanks. Signed-off-by: William Tu --- drivers/net/ena/base/ena_com.c| 4 +- d

[dpdk-dev] [PATCH v6] eal: remove sys/queue.h from public headers.

2021-08-13 Thread William Tu
ed-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v5-v6: * fix tab/indent issue, fix type and spelling * fix duplicate RTE_TAILQ_FOREACH_SAFE * fix build error due to drivers/net/mlx5/mlx5_flow_meter.c --- drivers/bus/auxiliary/private.h| 1 + drive

Re: [dpdk-dev] [PATCHv5] eal: remove sys/queue.h from public headers.

2021-08-13 Thread William Tu
Hi Dmitry, Thanks for your feedback! On Fri, Aug 13, 2021 at 11:59 AM Dmitry Kozlyuk wrote: > > 2021-08-13 03:36 (UTC+0000), William Tu: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/

[dpdk-dev] [PATCHv5] eal: remove sys/queue.h from public headers.

2021-08-12 Thread William Tu
ot;TAILQ_xxx" macros. [1] http://mails.dpdk.org/archives/dev/2021-August/216304.html Suggested-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v4-v5 * fix compile error due to drivers/net/ipn3ke/ipn3ke_flow.c:1234 * run spell check --- drivers/bus/a

Re: [dpdk-dev] [PATCHv4] eal: remove sys/queue.h from public headers.

2021-08-12 Thread William Tu
On Thu, Aug 12, 2021 at 6:11 PM Stephen Hemminger wrote: > > On Fri, 13 Aug 2021 01:02:50 +0000 > William Tu wrote: > > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by Linux/BSD system lib

[dpdk-dev] [PATCHv4] eal: remove sys/queue.h from public headers.

2021-08-12 Thread William Tu
ILQ_xxx" macros. [1] http://mails.dpdk.org/archives/dev/2021-August/216304.html Suggested-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v3-v4: * address comments from Dmitry --- drivers/bus/auxiliary/private.h| 1 + drivers/bus/auxiliary/rte_bus_aux

[dpdk-dev] [PATCHv3] include: fix sys/queue.h.

2021-08-12 Thread William Tu
nclude " or "TAILQ_xxx" macros. Suggested-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v2->v3: * follow the suggestion by Dmitry * run checkpatches, there are some errors but I think either the original file has over 80-char line due to comm

Re: [dpdk-dev] [PATCHv2] include: fix sys/queue.h.

2021-08-11 Thread William Tu
On Wed, Aug 11, 2021 at 8:50 AM Dmitry Kozlyuk wrote: > > Hi William, > > 2021-08-11 20:46 (UTC+0000), William Tu: > > Currently there are a couple of header files include 'sys/queue.h', > > which is a POSIX functionality. When compiling DPDK with OVS on >

Re: [dpdk-dev] [PATCH] eal/windows: add sys/queue.h.

2021-08-11 Thread William Tu
On Wed, Aug 11, 2021 at 1:34 AM Nick Connolly wrote: > > > > What we can do: > > > > 1. Introduce `rte_queue.h` (name can be better) that is env-specific: > > > > 1.1. For Linux and FreeBSD it just includes > > and renames a few macros that are used in headers to RTE_xxx. > > 1.2

[dpdk-dev] [PATCHv2] include: fix sys/queue.h.

2021-08-11 Thread William Tu
IX functionality from the underlying system. There are still a couple of headers using sys/queue.h, ex: rte_bus_pci.h. Since it's not been used in Windows yet, we can fix them later. Suggested-by: Nick Connolly Suggested-by: Dmitry Kozliuk Signed-off-by: William Tu --- v1->v2: - follow

Re: [dpdk-dev] Linker error on rte_dump_stack() on Windows

2021-08-08 Thread William Tu
On Sun, Aug 8, 2021 at 12:52 PM Dmitry Kozlyuk wrote: > > 2021-08-08 10:45 (UTC-0700), William Tu: > > Hi, > > > > While linking OVS to Windows DPDK library, static link to > > librte_eal.a, we hit some error about rte_dump_stack(). > > I don't know

[dpdk-dev] Linker error on rte_dump_stack() on Windows

2021-08-08 Thread William Tu
Hi, While linking OVS to Windows DPDK library, static link to librte_eal.a, we hit some error about rte_dump_stack(). I don't know why other symbols work, but only a couple symbols showed errors here. Any suggestions about how to debug/fix this? Thank you! [5/15] Linking target utilities/ovs-vsct

Re: [dpdk-dev] Windows community call: MoM 2021-08-04

2021-08-06 Thread William Tu
On Thu, Aug 5, 2021 at 12:15 PM Dmitry Kozlyuk wrote: > snip > # Porting OvS build system to meson (William Tu) > > Status: OvS compiles with some features disabled, with a lot of warnings. > Issues: > > * vhost-user is Linux-specific. > [Omar] Microsoft is working

[dpdk-dev] [PATCH] eal/windows: expose symbol rte_version

2021-08-05 Thread William Tu
When OVS inits, it calls rte_version to get the DPDK's version. The patch fixes the error below by exposing rte_version symbol. libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol rte_version referenced in function dpdk_init Signed-off-by: William Tu --- lib/eal/versio

[dpdk-dev] [PATCH] eal/windows: add sys/queue.h.

2021-08-05 Thread William Tu
When compiling OVS, lib/dpdk.c, found the missing header. In file included from ../lib/dpdk.c:27: C:\temp\dpdk\include\rte_log.h:24:10: fatal error: 'sys/queue.h' file not found ^ 1 warning and 1 error generated. Signed-off-by: William Tu --- lib/eal/windows/include/m

Re: [dpdk-dev] DPDK meson build failed on Windows

2021-08-05 Thread William Tu
On Wed, Aug 4, 2021 at 11:45 AM Dmitry Kozlyuk wrote: > > Hi again, > > This is exactly the error with 0.58 that I was talking about. Try 0.57.2. > > On Wed, Aug 4, 2021, 21:32 William Tu wrote: >> >> Hi, >> I got DPDK compiled on Windows, but suddenly I got

[dpdk-dev] DPDK meson build failed on Windows

2021-08-04 Thread William Tu
Hi, I got DPDK compiled on Windows, but suddenly I got this error when compiling DPDK on windows again. (And I don't know why it worked before...) [3/183] "clang" @lib/rte_eal-21.dll.rsp FAILED: lib/rte_eal-21.dll "clang" @lib/rte_eal-21.dll.rsp clang: error: no such file or directory: 'librte_kvar

Re: [dpdk-dev] DPDK vDPA application on Mellanox ConnectX 6Dx

2020-07-25 Thread William Tu
pling started. rx_queue_0_packets: 1,824,640 rx_queue_0_bytes: 109,478,400 Bps = 875.82 Mbps rx_queue_0_kicks: 28,367 Thanks William On Mon, Jul 13, 2020 at 7:29 AM William Tu wrote: > > Hi, > > We are setting up a testbed using mell

Re: [dpdk-dev] [RFC] - Offloading tunnel ports

2020-07-13 Thread William Tu
On Sun, Jul 12, 2020 at 9:52 PM Oz Shlomo wrote: > > Hi William, > > On 7/12/2020 7:34 PM, William Tu wrote: > > Hi Oz, > > snip > >> > >> Openvswitch, for example, uses two flows: > >> 1. classification flow - setting the virtual port represe

[dpdk-dev] DPDK vDPA application on Mellanox ConnectX 6Dx

2020-07-13 Thread William Tu
Hi, We are setting up a testbed using mellanox connectX 6Dx MCX621102AN-ADAT (2x25G) and are playing with vDPA features. We setup two machines (traffic gen and KVM) and connect them back-to-back with two connectX 6Dx. At this moment we don't know which component might be misconfigured (qemu, vdp

Re: [dpdk-dev] [RFC] - Offloading tunnel ports

2020-07-12 Thread William Tu
Hi Oz, I started to learn about this and have a couple of questions below. Thank you in advance. On Tue, Jun 9, 2020 at 8:07 AM Oz Shlomo wrote: > > Rte_flow API provides the building blocks for vendor agnostic flow > classification offloads. The rte_flow match and action primitives are fine >

Re: [dpdk-dev] [PATCH v4 0/7] MinGW-w64 support

2020-03-11 Thread William Tu
lib/librte_eal/windows/eal/include/getopt.h | 4 ++ > lib/librte_eal/windows/eal/include/pthread.h | 2 +- > lib/librte_eal/windows/eal/include/rte_os.h | 6 +- > lib/meson.build | 8 ++- > 14 files changed, 133 insertions(+), 26 deletions(-) > create mode 100644 config/x86/meson_mingw.txt > I reviewed and tested the v4 series and everything works ok. Tested-by: William Tu Thanks

Re: [dpdk-dev] Windows Draft Build

2020-02-27 Thread William Tu
> 3. Patch instruction is a bit involved: > > * Base on windpdk-v18.08-clang. > * Import drivers/net/virtio from v18.08 (not attached due to size). > * Apply windpdk-virtio-1.patch (attached). > * Apply multi-BAR patches (not attached due to not being mine). > * Apply windpdk-virtio-2.patch (attach

Re: [dpdk-dev] Question about vhost user interrupt mode

2020-02-26 Thread William Tu
On Tue, Feb 25, 2020 at 5:51 PM Tiwei Bie wrote: > > On Tue, Feb 25, 2020 at 12:44:48PM -0800, Yifeng Sun wrote: > > > > > > +int rte_vhost_get_kickfd(int vid, uint16_t queue_id) > > Introducing rte_vhost_get_kickfd() may not help much, we already > have rte_vhost_get_vhost_vring() to do that. > >

Re: [dpdk-dev] [PATCH v3 6/7] doc: guide for Windows build using MinGW-w64

2020-02-18 Thread William Tu
On Mon, Feb 17, 2020 at 4:03 PM Dmitry Kozlyuk wrote: > > Instructions for different toolchains presented as options on the > corresponging steps of the guide, so that common parts may be reused. > > Signed-off-by: Dmitry Kozlyuk > --- > doc/guides/windows_gsg/build_dpdk.rst | 63 +++

Re: [dpdk-dev] [PATCH v3 0/7] MinGW-w64 support

2020-02-18 Thread William Tu
brte_eal/windows/eal/include/pthread.h @@ -14,7 +14,7 @@ extern "C" { #endif -#include +#include #define PTHREAD_BARRIER_SERIAL_THREAD TRUE Otherwise, the series look good to me. Acked-by: William Tu Thanks William

Re: [dpdk-dev] [PATCH v2 0/7] MinGW-w64 support

2020-02-07 Thread William Tu
Hi Dmitry, Thanks for your reply. On Fri, Feb 7, 2020 at 2:24 AM Dmitry Kozliuk wrote: > > Hi William, > >> I applied your v2 patch and I did a native build on windows 10. >> Hit an error showing >> ../lib/librte_eal/windows/eal/eal_lcore.c:54:2: error: 'for' loop >> initial declarations are onl

  1   2   >