Re: [dpdk-dev] [PATCH] net/af_xdp: optimisations to improve packet loss

2020-06-16 Thread Ye Xiaolong
Hi, Ciara Thanks for the work, really good improvement. On 06/12, Ciara Loftus wrote: >This commit makes some changes to the AF_XDP PMD in an effort to improve >its packet loss characteristics. > >1. In the case of failed transmission due to inability to reserve a tx >descriptor, the PMD now pull

Re: [dpdk-dev] [PATCH v3 00/53] net/ice: base code update

2020-06-16 Thread Ye Xiaolong
On 06/15, Qi Zhang wrote: >Upgrade base with below main changes > >1. add more protocol support - L2TPv3/ESP/AH/PFCP. >2. Add IPv6 prefix RSS support. >3. support GENEVE and VXLAN rules with VLAN. >4. Add E823L device IDs >5. couple bug fixes and code clean. > >v3: >- fix commit log base on Ferruh'

Re: [dpdk-dev] [PATCH 0/2] add FD support for GTPU with outer IP on PF and VF

2020-06-12 Thread Ye Xiaolong
Hi, junfeng On 06/12, Junfeng Guo wrote: >[PATCH 1/2] add FD support for GTPU with outer IP on PF >[PATCH 2/2] add FD support for GTPU with outer IP on VF > >*** BLURB HERE *** Better to have some description about your patchset in the cover letter other than keeping the auto-generated "*** BLURB

Re: [dpdk-dev] [PATCH v2 00/52] net/ice: base code update

2020-06-10 Thread Ye Xiaolong
On 06/09, Qi Zhang wrote: >Upgrade base with below main changes > >1. add more protocol support - L2TPv3/ESP/AH/PFCP. >2. Add IPv6 prefix RSS support. >3. support GENEVE and VXLAN rules with VLAN. >4. Add E823L device IDs >5. couple bug fixes and code clean. > >v2: >- fix a bug in patch that cause

Re: [dpdk-dev] [PATCH] mbuf: remove unused next member

2020-06-09 Thread Ye Xiaolong
On 06/09, Stephen Hemminger wrote: >On Tue, 9 Jun 2020 15:15:33 +0800 >Ye Xiaolong wrote: > >> On 06/09, Olivier Matz wrote: >> >Hi Xialong, >> > >> >On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote: >> >> TAILQ_EN

Re: [dpdk-dev] [PATCH] mbuf: remove unused next member

2020-06-09 Thread Ye Xiaolong
On 06/09, Olivier Matz wrote: >Hi Xialong, > >On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote: >> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and >> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's >> next field when calling TAILQ_INSERT_TAIL(mbuf_dy

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-06-08 Thread Ye Xiaolong
On 06/09, Jiang Mao wrote: >The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will >be bind to vector 0. > >Signed-off-by: Jiang Mao > >Fixes: 4861cde461 (i40e: new poll mode driver) Fixes tag should be put before SOB line and please cc sta...@dpdk.org. >--- > drivers/ne

Re: [dpdk-dev] [PATCH v1 09/12] net/ice: add queue start and stop for DCF

2020-06-07 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Add queue start and stop in DCF. Support queue enable and disable >through virtual channel. Add support for Rx queue mbufs allocation >and queue reset. There is one i40e patch [1] from qiming to correct the queue behavior as "when one queue fails to sta

Re: [dpdk-dev] [PATCH v1 10/12] net/ice: enable stats for DCF

2020-06-07 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Add support to get and reset Rx/Tx stats in DCF. Query stats >from PF. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_dcf.c| 27 > drivers/net/ice/ice_dcf.h| 4 ++ > drivers/net/ice/ice_dcf_ethdev.c | 102 +++

Re: [dpdk-dev] [PATCH v1 08/12] net/ice: add queue config in DCF

2020-06-07 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Add queues and Rx queue irqs configuration during device start >in DCF. The setup is sent to PF via virtchnl. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_dcf.c| 109 +++ > drivers/net/ice/ice_dcf.h| 6 +

Re: [dpdk-dev] [PATCH v1 07/12] net/ice: init RSS during DCF start

2020-06-05 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Enable RSS initialization during DCF start. Add RSS LUT and >RSS key configuration functions. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_dcf.c| 123 +++ > drivers/net/ice/ice_dcf.h| 1 + > drivers/n

Re: [dpdk-dev] [PATCH v1 03/12] net/ice: complete dev configure in DCF

2020-06-05 Thread Ye Xiaolong
On 06/05, Ting Xu wrote: >From: Qi Zhang > >Enable device configuration function in DCF. > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_dcf_ethdev.c | 9 + > 1 file changed, 9 insertions(+) > >diff --git a/drivers/net/ice/ice_dcf_ethdev.c >b/drivers/net/ice/ice_dcf_ethdev.c >index

Re: [dpdk-dev] [PATCH v1 12/12] doc: enable DCF datapath configuration

2020-06-05 Thread Ye Xiaolong
Hi, Ting On 06/05, Ting Xu wrote: >Add doc for DCF datapath configuration in DPDK 20.08 release note. > It'd be better to also add some document update in ice.rst. Thanks, Xiaolong >Signed-off-by: Ting Xu >--- > doc/guides/rel_notes/release_20_08.rst | 5 + > 1 file changed, 5 insertions(+)

Re: [dpdk-dev] [PATCH v14 2/2] eal: support for VFIO-PCI VF token

2020-05-28 Thread Ye Xiaolong
On 05/28, Haiyue Wang wrote: >The kernel module vfio-pci introduces the VF token to enable SR-IOV >support since 5.7. > >The VF token can be set by a vfio-pci based PF driver and must be known >by the vfio-pci based VF driver in order to gain access to the device. > >Signed-off-by: Haiyue Wang >Ac

Re: [dpdk-dev] [PATCH v1] net/ice: fix PCI DSN to be lowercase values

2020-05-28 Thread Ye Xiaolong
On 05/28, Haiyue Wang wrote: >The PCI DSN (device serial number) to format package file name should be >lowercase values. > >Fixes: d1c91179e952 ("net/ice: check DSN package file firstly") > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent.c | 4 ++-- > 1 file changed, 2 insertions

Re: [dpdk-dev] net/iavf: fix flow uninit issue

2020-05-27 Thread Ye Xiaolong
On 05/27, Jeff Guo wrote: >When closing VF device, the process of shutdown adminq should be after of >the process of uninit the flow, since the VF might be still use the adminq >to uninit flow. > >Fixes: 9e03acd726cf ("net/iavf: fix flow access") >Fixes: ff2d0c345c3b ("net/iavf: support generic flo

Re: [dpdk-dev] [dpdk-dev v2] net/iavf: fix protocol field selector configure

2020-05-24 Thread Ye Xiaolong
On 05/24, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Sunday, May 24, 2020 1:53 PM >> To: Xing, Beilei ; Zhang, Qi Z ; >> Wu, Jingjing >> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia >> >> Subject: [dpdk-d

Re: [dpdk-dev] [PATCH] net/ice: fix switch action number check

2020-05-24 Thread Ye Xiaolong
On 05/21, Wei Zhao wrote: >The action number for switch filter should be 1, any >other such as 0 or more than 1 is invalid. > >Fixes: 3428c6b6ec1f ("net/ice: add action number check for switch") >Cc: sta...@dpdk.org > >Signed-off-by: Wei Zhao >--- > drivers/net/ice/ice_switch_filter.c | 2 +- > 1 f

Re: [dpdk-dev] [PATCH v2] net/i40e: fix flow FDIR enable issue

2020-05-22 Thread Ye Xiaolong
On 05/21, Wei Zhao wrote: >When we flush flow FDIR, all queues are disabled for FDIR. >If FDIR rule is created again, then the flow list is empty, >as it is the first time to create rule after flush fdir filter, >so we need to enable FDIR for all queues. And also, disable FDIR >for queues should be

Re: [dpdk-dev] net/iavf: fix invalid flow access

2020-05-22 Thread Ye Xiaolong
On 05/21, Jeff Guo wrote: >When hash init, the default rss rules would be added, while hash uninit, >the default rss rules should be deleted. Add the missing part in the hash >uninit process. Also add invalid flow checking func in iavf generic flow >to avoid the error of "Cannot access memory at ad

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API

2020-05-22 Thread Ye Xiaolong
On 05/22, Guinan Sun wrote: >The driver type need to be checked in private API. >The patch fixes the issue. > >Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") >Cc: sta...@dpdk.org > >Signed-off-by: Guinan Sun >--- > drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++ > 1 file changed, 6 insertions(

Re: [dpdk-dev] [PATCH] doc: update for ice

2020-05-21 Thread Ye Xiaolong
On 05/20, Xiaolong Ye wrote: >Update the description and limitation about ice PMD according to the >product release strategy. > >Signed-off-by: Xiaolong Ye >--- > doc/guides/nics/ice.rst | 29 + > 1 file changed, 5 insertions(+), 24 deletions(-) > >diff --git a/doc/guide

Re: [dpdk-dev] net/iavf: fix error setting for L2TAG

2020-05-20 Thread Ye Xiaolong
On 05/20, Jeff Guo wrote: >Base on HW, if a packet be split into multiple segments, the L2TAG >should only be valid on the last Rx descriptor. So fix it by setting >L2TAG into mbuf when processing the last split packet. > >Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") > >Signed-off-by: Jeff Guo

Re: [dpdk-dev] net/ice: fix error setting for L2TAG

2020-05-20 Thread Ye Xiaolong
On 05/20, Jeff Guo wrote: >Base on HW, if a packet be split into multiple segments, the L2TAG >should only be valid on the last Rx descriptor. So fix it by setting >L2TAG into mbuf when processing the last split packet. > >Fixes: c68a52b8b38c ("net/ice: support vector SSE in Rx") > >Signed-off-by:

Re: [dpdk-dev] net/i40e: fix error setting for L2TAG

2020-05-20 Thread Ye Xiaolong
On 05/20, Jeff Guo wrote: >Base on HW, if a packet be split into multiple segments, the L2TAG >should only be valid on the last Rx descriptor. So fix it by setting >L2TAG into mbuf when processing the last split packet. > >Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from vector >

Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured

2020-05-20 Thread Ye Xiaolong
On 05/20, Leyi Rong wrote: >FDIR ID parsing will not be handled correctly after queue reconfigured, >enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it. > >Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value") > >Signed-off-by: Leyi Rong >--- > drivers/net/iavf/ia

Re: [dpdk-dev] [PATCH] net/ice: fix tunnel type match word handling

2020-05-19 Thread Ye Xiaolong
On 05/18, Qi Zhang wrote: >Use a common function when selecting the proper word and mask match for >a tunnel type when programming switch rules. > >Store switch recipe field mask as little endian, which avoids needing to >convert back to big endian after reading recipe from FW. > >Obtain word mask

Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled

2020-05-19 Thread Ye Xiaolong
Hi, Maxime & Ferruh This patch is used to fix the regression caused by commit 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") which was introduced in RC2, I think we should get it in this release. Thanks, Xiaolong On 05/19, Ye Xiaolong wrote: >On 05/13

Re: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled

2020-05-18 Thread Ye Xiaolong
On 05/13, Xuan Ding wrote: >This patch fixes the situation where vhost-user cannot start as server with >dequeue_zero_copy enabled. > >Using flag instead of vsocket->is_server to determine whether vhost-user is >in client mode. Because vsocket->is_server is not ready at this time. > >Cc: sta...@dpd

Re: [dpdk-dev] [dpdk-dev v2] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Ye Xiaolong
On 05/19, Jeff Guo wrote: >Since there are some default rss configure in kernel PF/VF but not DPDK >IAVF, if these configurations be modified by VF and then VF reset, this >default rss configurations can not be reset to default by IAVF. So need >to add default rss set in IAVF hash initial process.

Re: [dpdk-dev] [PATCH v2] net/i40e: fix queue related exception handling

2020-05-18 Thread Ye Xiaolong
On 05/18, Qiming Yang wrote: >There should have different behavior in queue start fail and stop fail case. >When queue start fail, all the next actions should be terminated and then >started queues should be cleared. But for queue stop stage, one queue stop >fail should not end other queues stop. T

Re: [dpdk-dev] [PATCH] net/ice: fix RSS for GTPU

2020-05-18 Thread Ye Xiaolong
On 05/13, Qi Zhang wrote: >All supported pattern for GTPU include extend header: >pattern_eth_ipv4_gtpu_eh_ipv4 >pattern_eth_ipv4_gtpu_eh_ipv4_udp >pattern_eth_ipv4_gtpu_eh_ipv4_tcp > >So the RSS rule should only take effect on GTPU packet that contains >extend header. The patch fix above issue and

Re: [dpdk-dev] [PATCH v5] net/i40e: fix the core dump risk of wild pointer operation

2020-05-18 Thread Ye Xiaolong
On 05/18, Wei Zhao wrote: >In i40e PMD code of function i40e_res_pool_free(), if valid_entry >is freed by "rte_free(valid_entry);" in the code, then the following >code for pool update may still use the wild pointer "valid_entry" >for pool info update. It seems has the risk of core dump for >using

Re: [dpdk-dev] net/iavf: fix VF reset issue for hash

2020-05-18 Thread Ye Xiaolong
On 05/18, Jeff Guo wrote: >Since there are some default rss configure in kernel PF/VF but not DPDK >IAVF, if these configurations be modified by VF and then VF reset, this >default rss configurations can not be reset to default by IAVF. So need >to add default rss set in IAVF hash initial process.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

2020-05-18 Thread Ye Xiaolong
Hi, wei On 05/18, Zhao1, Wei wrote: >Hi, xiaolong > >> -Original Message- >> From: dev On Behalf Of Ye Xiaolong >> Sent: Monday, May 18, 2020 9:25 AM >> To: Sun, GuinanX >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [dpdk-sta

Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-17 Thread Ye Xiaolong
Hi, Wei On 05/18, Zhao1, Wei wrote: >HI, Xiaolong & guojia > >> -Original Message----- >> From: Ye, Xiaolong >> Sent: Friday, May 15, 2020 3:28 PM >> To: Guo, Jia >> Cc: Zhao1, Wei ; dev@dpdk.org; sta...@dpdk.org; >> Xing, Beilei >&g

Re: [dpdk-dev] [PATCH v1] net/iavf: fix setting wrong RXDID value for Rx queue

2020-05-17 Thread Ye Xiaolong
On 05/11, Ting Xu wrote: >CVL kernel PF configures all reserved queues for VF, including >Rx queue RXDID. The number of reserved queues is the maximum >between Tx and Rx queues. If the number of the enabled Rx queues >is less than that of reserved queues, required RXDID will only >be set for those

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/e1000: fix defects of macro in VF

2020-05-17 Thread Ye Xiaolong
Hi, guinan On 05/08, Guinan Sun wrote: >The defects in the macros UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT exist. >If latest is less than last, we will get wrong result. >The patch fixes the defect. There was similar patch before, https://patches.dpdk.org/patch/65131/, if I understand it correctly

Re: [dpdk-dev] [PATCH v4] net/i40e: fix queue region issue in RSS flow

2020-05-17 Thread Ye Xiaolong
On 05/15, Shougang Wang wrote: >This patch fixes the issue that the queue region does not >take effect due to incorrectly setting the flow type. > >Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") >Cc: sta...@dpdk.org > >Signed-off-by: Shougang Wang >Reviewed-by: Jeff Guo >Tested-by: Hailin

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-17 Thread Ye Xiaolong
On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") > >Signed-off-by: Simei Su >--- > drivers/net/ice/base/ice_fdir.c | 9 +

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-17 Thread Ye Xiaolong
On 05/15, Su, Simei wrote: >Hi, xiaolong > >> -Original Message----- >> From: Ye, Xiaolong >> Sent: Friday, May 15, 2020 2:50 PM >> To: Su, Simei >> Cc: Zhang, Qi Z ; dev@dpdk.org; Cao, Yahui >> >> Subject: Re: [PATCH] net/ice/base: fix FDIR r

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Ye Xiaolong
On 05/14, Maxime Coquelin wrote: >This patch adds support to enabling and disabling >vrings on a per-vring granularity. > >Signed-off-by: Maxime Coquelin >--- > drivers/vdpa/ifc/base/ifcvf.c | 9 + > drivers/vdpa/ifc/base/ifcvf.h | 4 > drivers/vdpa/ifc/ifcvf_vdpa.c | 23 +

Re: [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation

2020-05-15 Thread Ye Xiaolong
On 05/15, Jeff Guo wrote: >hi, zhaowei > >On 5/12/2020 11:19 PM, Wei Zhao wrote: >> In i40e PMD code of function i40e_res_pool_free(), if valid_entry is >> freed by "rte_free(valid_entry);" in the following code: >> >> if (prev != NULL) { >> >> >> if (insert == 1) {

Re: [dpdk-dev] [PATCH v2] example/vhost_blk: fix buffer not null terminated

2020-05-15 Thread Ye Xiaolong
On 05/15, Jin Yu wrote: >In vhost_blk_bdev_construct: The string buffer may not have >a null terminator if the source string's length is equal to >the buffer size. > >Fixes: 91d3e2d42997 ("examples/vhost_blk: refactor to increase readability") >Cc: jin...@intel.com > >Signed-off-by: Jin Yu >--- >V

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-14 Thread Ye Xiaolong
Hi, simei On 05/08, Simei Su wrote: >This patch adds support for FDIR passthrough mode. When FDIR rule >hits, FDIR just forward this packet to the next stage filter. > >Fixes: 55daca4e45fc ("net/ice/base: change function to static") This commit doesn't make sense to me, it just change the functio

Re: [dpdk-dev] [PATCH v4] net/i40e: fix out of bounds read issue

2020-05-14 Thread Ye Xiaolong
Minor nit: 'issue' doesn't need to be mentioned in the commit title, since the 'fix' implies something is broken. On 05/14, Chenxu Di wrote: >This patch fixes (out-of-bounds read) coverity issue. > >Coverity issue: 357699 >Coverity issue: 357694 >Fixes: feaae285b342 ("net/i40e: support hash config

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix queue related exception handling

2020-05-14 Thread Ye Xiaolong
On 05/13, Qiming Yang wrote: >There should have different behavior in queue start fail and stop fail case. >When queue start fail, all the next actions should be terminated and then >started queues should be cleared. But for queue stop stage, one queue stop >fail should not end other queues stop. T

Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow

2020-05-13 Thread Ye Xiaolong
On 05/07, Shougang Wang wrote: >This patch fixes the issue that failed to create an RSS rule with type >L2-payload. > >Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > >Signed-off-by: Shougang Wang >--- > drivers/net/i40e/i40e_flow.c | 14 ++ > 1 file changed,

Re: [dpdk-dev] [dpdk-dev v2 1/2] common/iavf: fix typo of rss algorithm type

2020-05-13 Thread Ye Xiaolong
On 05/13, Jeff Guo wrote: >A typo need to be fixd for Simple XOR algorithm configuration. > >Signed-off-by: Jeff Guo >--- >v2: fix a typo for xor. >--- > drivers/common/iavf/virtchnl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/common/iavf/virtchnl.h b/drivers/c

Re: [dpdk-dev] [dpdk-dev v2 2/2] net/iavf: fix rss algorithm configure issue

2020-05-13 Thread Ye Xiaolong
On 05/13, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Thursday, May 14, 2020 4:21 AM >> To: Xing, Beilei ; Ye, Xiaolong >> ; Zhang, Qi Z ; Wu, Jingjing >> >> Cc: dev@dpdk.org; Guo, Jia >> Subject: [dpdk-d

Re: [dpdk-dev] [dpdk-dev v2 1/2] common/iavf: fix typo of rss algorithm type

2020-05-13 Thread Ye Xiaolong
On 05/13, Jeff Guo wrote: >A typo need to be fixd for Simple XOR algorithm configuration. > >Signed-off-by: Jeff Guo >--- >v2: fix a typo for xor. >--- > drivers/common/iavf/virtchnl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/common/iavf/virtchnl.h b/drivers/c

Re: [dpdk-dev] [PATCH v2] net/i40e: fix failing to create FDIR flow

2020-05-12 Thread Ye Xiaolong
On 05/13, Shougang Wang wrote: >This patch fixes the issue that the flow which both source MAC mask >and destination MAC mask are all zeros can not be created. > >Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") > >Signed-off-by: Shougang Wang >Tested-by: Hailin Xu

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode

2020-05-12 Thread Ye Xiaolong
On 05/12, Guinan Sun wrote: >The register autoneg can't be updated synchronously >with flow control mode setting in the state of port start >, so NIC statistics error occurs. AUTO_NEG Advt register >should be updated by ixgbe_setup_fc() when enabling flow control. >The patch fixes the issue. > >Fix

Re: [dpdk-dev] [PATCH] doc: fix wrong multicast filter flag

2020-05-11 Thread Ye Xiaolong
On 05/08, Qiming Yang wrote: >Multicast MAC filter flag means device ops set_mc_addr_list support >or not. This patch fixes the wrong flag value in intel driver's document. > >Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files") >Fixes: cb25d4323fbf ("net/avf: enable MAC VLAN and

Re: [dpdk-dev] [PATCH] net/iavf: delete unused value

2020-05-11 Thread Ye Xiaolong
On 05/11, Leyi Rong wrote: >Fix coverity defects of unused value. > >Coverity issue: 357745, 357769 > >Fixes: b8b4c54ef9b0 ("net/iavf: support flexible Rx descriptor in normal path") > >Signed-off-by: Leyi Rong >--- > drivers/net/iavf/iavf_rxtx.c | 4 > 1 file changed, 4 deletions(-) > >diff -

Re: [dpdk-dev] [PATCH v3] net/igc: fix memory illegal accesses

2020-05-11 Thread Ye Xiaolong
On 05/08, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Fix some out-of-bounds memory issues, they may lead to wrong results >or affect application stability. > >Coverity issue: 357759, 357713 >Fixes: bd3fcf0d0fa1 (net/igc: support RSS) >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >--

Re: [dpdk-dev] [PATCH] net/e1000: fix port hotplug for multi-process

2020-05-11 Thread Ye Xiaolong
On 04/29, alvinx.zh...@intel.com wrote: >From: Alvin Zhang Cc: sta...@dpdk.org > >Enable detach device on secondary process. > >Fixes: b9eee2cb8c29 (e1000: support port hotplug) >Cc: bernard.iremon...@intel.com >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >--- > drivers/net/e1000/em_ethdev.

Re: [dpdk-dev] [PATCH] net/ice: fix uninitialized scalar variable

2020-05-10 Thread Ye Xiaolong
On 05/06, Qi Zhang wrote: >Fix coverity defect due to uninitialized scalar variable. > >Coverity issue: 357763 > >Fixes: 47d460d63233 ("net/ice: rework switch filter") >Cc: sta...@dpdk.org > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_switch_filter.c | 1 + > 1 file changed, 1 insertion(+)

Re: [dpdk-dev] [PATCH v2] net/igc: remove some useless log

2020-05-10 Thread Ye Xiaolong
On 05/07, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Some log will always be printed when the device is initialized >and shut down, which will mislead users and should be removed. > >Fixes: 746664d546fb (net/igc: implement flow API) >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >---

Re: [dpdk-dev] [PATCH] net/ice/base: fix pppoe-ipv6 dummy packet error

2020-05-10 Thread Ye Xiaolong
On 05/07, Wei Zhao wrote: >The dummy packet for pppoe-ipv6 has an error, we should >use 0x3b for next header in ipv6 header in the dummy packet, >or some case can not be download, such as: > >"eth / pppoes seid is 3 / pppoe_proto_id is 0x0057 / >end actions vf id 1 / end" > >Fixes: 55d61fb27a5e ("n

Re: [dpdk-dev] [PATCH] net/iavf: fix rte flow error log issue

2020-05-10 Thread Ye Xiaolong
On 05/09, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Saturday, May 9, 2020 4:59 AM >> To: Xing, Beilei ; Ye, Xiaolong >> ; Yang, Qiming ; Wu, >> Jingjing >> Cc: Zhang, Qi Z ; dev@dpdk.org; Lu, Wenzhuo >>

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix link state timing issue on fiber ports

2020-05-10 Thread Ye Xiaolong
On 05/08, Phil Yang wrote: >In ixgbe_dev_link_update_share(), if the media type is fiber and the >link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback >to ixgbe_dev_setup_link_thread_handler() is scheduled which should >try to set up the link and clear the flag afterwards. This fla

Re: [dpdk-dev] [dpdk-dev v2] net/iavf: fix input set for rss hash

2020-05-10 Thread Ye Xiaolong
On 05/09, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Guo, Jia >> Sent: Sunday, May 10, 2020 3:30 AM >> To: Xing, Beilei ; Zhang, Qi Z ; >> Wu, Jingjing >> Cc: Iremonger, Bernard ; Ye, Xiaolong >> ; dev@dpdk.org; Guo, Jia >&

Re: [dpdk-dev] [PATCH] example/vhost_blk: fix buffer not null terminated

2020-05-08 Thread Ye Xiaolong
On 05/08, Jin Yu wrote: >Fix the potential bug. Could you describe more about the potential bug? Fixes tag is needed here. Thanks, Xiaolong > >Signed-off-by: Jin Yu >--- > examples/vhost_blk/vhost_blk.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/examples/vhost_b

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports

2020-05-08 Thread Ye Xiaolong
On 05/08, Phil Yang wrote: >> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber >> ports >> >> With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it >> is possible when a port is started to experience a timing issue >> which prevents the link from ever being

Re: [dpdk-dev] [PATCH v2] net/igc: fix memory illegal accesses

2020-05-08 Thread Ye Xiaolong
On 05/07, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Fix some out-of-bounds memory issues, they may lead to wrong results >or affect application stability. > >Fixes: bd3fcf0d0fa1 (net/igc: support RSS) >Cc: sta...@dpdk.org Please append the coverity number, you can refer to other fixes i

Re: [dpdk-dev] [PATCH v2] net/i40e: fix out of bounds read issue

2020-05-07 Thread Ye Xiaolong
Hi, Qiming On 05/08, Yang, Qiming wrote: >Nacked by: Qiming Yang Could you post the reason why you nack this patch? Thanks, Xiaolong > >> -Original Message- >> From: dev On Behalf Of Chenxu Di >> Sent: Thursday, May 7, 2020 17:50 >> To: dev@dpdk.org >> Cc: Di, ChenxuX >> Subject: [dp

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule completion report value

2020-05-07 Thread Ye Xiaolong
On 05/08, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Su, Simei >> Sent: Friday, May 8, 2020 9:37 AM >> To: Zhang, Qi Z ; Ye, Xiaolong >> Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei >> >> Subject: [PATCH] net/ice/base: fix FDIR rul

Re: [dpdk-dev] [PATCH] doc: remove intel PMD examples in flow bifurcation guide

2020-05-07 Thread Ye Xiaolong
On 04/29, Thomas Monjalon wrote: >29/04/2020 04:29, Xiaolong Ye: >> Now this feature is no longer supported by kernel side, so remove the >> intel PMD examples to avoid confusion. > >Please could you add a link to the commit removing >this support in the kernel code? Currently we are not sure whic

Re: [dpdk-dev] [PATCH] net/igc: remove some useless log

2020-05-06 Thread Ye Xiaolong
On 04/30, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >As title. > >Fixes: 746664d546fb (net/igc: implement flow API) >Cc: sta...@dpdk.org > >Signed-off-by: Alvin Zhang >--- > drivers/net/igc/igc_txrx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/drivers/net/i

Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue

2020-05-06 Thread Ye Xiaolong
On 05/07, Di, ChenxuX wrote: >Hi, xiaolong > >> -Original Message----- >> From: Ye, Xiaolong >> Sent: Thursday, May 7, 2020 1:15 PM >> To: Di, ChenxuX >> Cc: dev@dpdk.org; Xing, Beilei >> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds r

Re: [dpdk-dev] [PATCH] net/i40e: fix out of bounds read issue

2020-05-06 Thread Ye Xiaolong
On 05/07, Chenxu Di wrote: >This patch fixes (out-of-bounds read) coverity issue. > >Coverity issue: 357699 >Coverity issue: 357694 >Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > >Signed-off-by: Chenxu Di >--- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed,

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ice: fix core dumped issue in switch filter

2020-05-06 Thread Ye Xiaolong
On 05/06, Junyu Jiang wrote: >The number of queues in queue group should be checked before >using it. This patch fixed the issue. > >Fixes: 47d460d63233 ("net/ice: rework switch filter") >Cc: sta...@dpdk.org > >Signed-off-by: Junyu Jiang >Tested-by: Qimai Xiao >--- > drivers/net/ice/ice_switch_fi

Re: [dpdk-dev] [PATCH v2] net/ice: support mark only action for FDIR

2020-05-05 Thread Ye Xiaolong
On 04/30, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Su, Simei >> Sent: Tuesday, April 14, 2020 11:11 PM >> To: Zhang, Qi Z ; Ye, Xiaolong >> Cc: dev@dpdk.org; Cao, Yahui ; Su, Simei >> ; sta...@dpdk.org >> Subject: [PATC

Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD

2020-05-05 Thread Ye Xiaolong
On 04/16, zhihongx.p...@intel.com wrote: >From: Peng Zhihong > >DPDK does not implement interrupt mechanism on BSD, >so force NIC status synchronization. > >Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) >Cc: liang-min.w...@intel.com > >Signed-off-by: Peng Zhihong >--- > drivers/

Re: [dpdk-dev] [PATCH v2] net/ice/base: fix bm mask set and find switch recipe method

2020-05-05 Thread Ye Xiaolong
On 04/29, Wei Zhao wrote: >When we download a switch rule for ipv6 with esp payload >"eth / ipv6 / esp spi is 1 / end actions queue index 2 / end" > >if we don't add bm bit set check for tun_type, then a packet of >ipv4 with esp payload > >"sendp([Ether(dst="00:00:00:00:01:00")/IP(proto=50)/ESP(spi

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/iavf: fix link speed

2020-05-05 Thread Ye Xiaolong
On 04/30, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >If the PF driver does not support the new speed reporting capabilities then >use link_event instead of link_event_adv to get the speed. > >Fixes: 48de41ca11f0 (net/iavf: enable link status update) >Cc: jingjing...@intel.com >Cc: sta...@

Re: [dpdk-dev] [PATCH v2] net/ice/base: fix DCF switch rule

2020-04-29 Thread Ye Xiaolong
On 04/23, Qi Zhang wrote: >1. ln_en bit should not be turned on, since we only support Rx VEB. >2. lan_en bit need to be turn on for a DCF switch rule, otherwise > any Tx packet that hit on a rule will be dropped. > >Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe") C

Re: [dpdk-dev] [PATCH] net/iavf: fix VF reset issue for FDIR rule

2020-04-29 Thread Ye Xiaolong
On 04/28, Simei Su wrote: >After VF reset, FDIR rule still takes effect. To solve the issue, >this patch adds to flush all flows before flow uninit. VIRTCHNL >sends message to PF by Admin Queue, so flow flush should be implemented >before Admin Queue shut down. > >Fixes: c6ea8bd9f11f ("net/iavf: su

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 0/3] fix i40e bug for flow filter

2020-04-29 Thread Ye Xiaolong
On 04/29, Xing, Beilei wrote: > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Wednesday, April 29, 2020 10:04 AM >> To: dev@dpdk.org >> Cc: sta...@dpdk.org; Xing, Beilei ; >> maxime.le...@6wind.com >> Subject: [PATCH v4 0/3] fix i40e bug for flow filter >> >> fix i40e bug for flow

Re: [dpdk-dev] [PATCH] net/ice/base: workaround for unexpected rule deletion

2020-04-28 Thread Ye Xiaolong
On 04/24, Zhao1, Wei wrote: >It will be delete after fix in kernel to re-enable vf list feature. > >Reviewed-by: Wei Zhao > >> -Original Message- >> From: dev On Behalf Of Qi Zhang >> Sent: Thursday, April 23, 2020 12:22 PM >> To: Yang, Qiming

Re: [dpdk-dev] [PATCH] net/ice: fix flow redirector issue

2020-04-22 Thread Ye Xiaolong
On 04/22, Beilei Xing wrote: >If there's VF reset, the kernel PF will remove rules >associated with the reset VF no matter the HW VSI ID >is changed or not. So DCF should redirector all rules >associated with the reset VF no matter the HW VSI ID >is changed or not. > >Fixes: f10cde8e8478 ("net/ice:

Re: [dpdk-dev] [PATCH] net/iavf: fix return value of stats get function

2020-04-22 Thread Ye Xiaolong
Hi, Thanks for the fix. On 04/14, cheng.pe...@zte.com.cn wrote: >The iavf_dev_stats_get function should return ret instead of -eio. > Fixes: f4a41a6953af ("net/avf: support stats") Cc: sta...@dpdk.org >Signed-off-by: Peng Cheng >--- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1

Re: [dpdk-dev] [PATCH] net/i40e: enable PPC altivec support for meson builds

2020-04-22 Thread Ye Xiaolong
On 04/09, David Christensen wrote: >The meson build file does not enable i40e vectorization support for >PPC/altivec systems, even though the existing Makefile does enable the >support. Add the required architecture check and sources line. > >Signed-off-by: David Christensen >--- > drivers/net/i40

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-22 Thread Ye Xiaolong
On 04/13, Shougang Wang wrote: >It's a normal behavior to change the link status to up after >resetting the port. So it is unnecessary to set link down before >starting port, and changing the link state(link up/down) frequently >will cause link speed unstable. > >Fixes: c3f2fbff78cf ("net/ixgbe: fi

Re: [dpdk-dev] [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch

2020-04-21 Thread Ye Xiaolong
On 04/20, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Monday, April 20, 2020 1:19 PM >> To: dev@dpdk.org >> Cc: Zhang, Qi Z ; Fu, Qi >> Subject: [PATCH v2 0/3] add support for L2TP AH ESP and NAT-T on switch >> >> This patch set add switch filter support for

Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix resource leak after thread exits normally

2020-04-21 Thread Ye Xiaolong
On 04/22, taox@intel.com wrote: >From: Zhu Tao > >When the thread exits normally, pthread_join() is not called, which can >result in a resource leak. Therefore, the thread is set to separation >mode using function pthread_detach(), so that no program call >pthread_join() is required to recycle

Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix resource leak after thread exits normally

2020-04-21 Thread Ye Xiaolong
On 04/21, taox@intel.com wrote: >From: Zhu Tao > >When the thread exits normally, pthread_join() is not called, which can >result in a resource leak. Therefore, the thread is set to separation >mode using function pthread_detach(), so that no program call >pthread_join() is required to recycle

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix flow director initialisation

2020-04-20 Thread Ye Xiaolong
On 04/07, Bernard Iremonger wrote: >Remove references to struct rte_fdir_conf which is deprecated, >in i40e_flow_parse_fdir_filter(), i40e_flow_destroy() and >i40e_flow_add_del_fdir_filter(). > >Fixes: c3be43817cfb ("net/i40e: fix unexpected skip FDIR setup") >Fixes: 2e67a7fbf3ff ("net/i40e: config

Re: [dpdk-dev] [PATCH v5 0/5] net/iavf: support FDIR capabiltiy

2020-04-20 Thread Ye Xiaolong
On 04/21, Simei Su wrote: >[PATCH v5 1/5] support FDIR common patterns and actions. >[PATCH v5 2/5] support FDIR GTPU pattern. >[PATCH v5 3/5] support FDIR L2TPv3, ESP, AH and NAT-T pattern. >[PATCH v5 4/5] support FDIR PFCP node and session pattern. >[PATCH v5 5/5] support FDIR mark action. > >v5:

Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-20 Thread Ye Xiaolong
On 04/16, Haiyue Wang wrote: >Align the package file search sequence with PF only for DCF mode. Get >the DSN through the virtual channel firstly to check the package file >accessible. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent.c | 30 ++ > 1 file

Re: [dpdk-dev] [PATCH v6 00/11] framework for advanced iAVF PMD

2020-04-20 Thread Ye Xiaolong
On 04/20, Leyi Rong wrote: >This patchset enable framework for advanced iAVF, includes >flexible descriptor support, FDIR mark id and RSS hash support. > >--- >v6: >- Remove some redundant code which may cause ICC build error. > >v5: >- Set rxdid = 0 in iavf_configure_queues() when it's supported a

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix resource leak after thread exits normally

2020-04-20 Thread Ye Xiaolong
On 04/15, taox@intel.com wrote: >From: Zhu Tao > >When the thread exits normally, pthread_join() is not called, which can >result in a resource leak. Therefore, the thread is set to separation >mode using function pthread_detach(), so that no program call >pthread_join() is required to recycle

Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-20 Thread Ye Xiaolong
can reproduce the build error with gcc 7.5.0 via ./devtools/test-build.sh x86_64-native-linux-gcc+next+shared. Thanks, Xiaolong > >Best regards, >Xiaojun > >-Original Message- >From: Ye Xiaolong [mailto:xiaolong...@intel.com] >Sent: Monday, April 20, 2020 12:56 PM &

Re: [dpdk-dev] [PATCH v4 5/5] net/fm10k: add switch management support

2020-04-19 Thread Ye Xiaolong
Hi, Xiaojun On 04/09, Xiaojun Liu wrote: >Split dev init to 2 parts. >First only register the port in switch >management; second init hook will be >called after all the pf are registered >and switch initialization. It will finish >dev init. Also add switch interrupt support. >Add fm10k_mirror_rule

Re: [dpdk-dev] [PATCH v4 0/5] support fm10k switch management

2020-04-19 Thread Ye Xiaolong
On 04/17, Ferruh Yigit wrote: >On 4/9/2020 7:26 AM, Xiaojun Liu wrote: >> V4: >> * Add I2C to control the inside LED and PHY. >> * Add SBUS to communicate with spico. >> * Add registers defination. >> * Add switch management log API. >> * Add switch management structures. >> * Add epl serdes includ

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-18 Thread Ye Xiaolong
irtio device start. Thanks for the explanation, then seems we needs to adjust the comment above accordingly. Thanks, Xiaolong > >Regards, >Marvin > >> -Original Message- >> From: Maxime Coquelin >> Sent: Friday, April 17, 2020 11:18 PM >> To: Liu,

Re: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for split vring used idx

2020-04-16 Thread Ye Xiaolong
On 04/06, Joyce Kong wrote: >In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend >and backend are assumed to be implemented in software, that is they can >run on identical CPUs in an SMP configuration. >Thus a weak form of memory barriers like rte_smp_r/wmb, other than >rte_cio

Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-16 Thread Ye Xiaolong
On 04/16, Haiyue Wang wrote: >Align the package file search sequence with PF only for DCF mode. Get >the DSN through the virtual channel firstly to check the package file >accessible. check the accessibility of the package file? > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent

Re: [dpdk-dev] [PATCH v5 00/11] framework for advanced iAVF PMD

2020-04-16 Thread Ye Xiaolong
On 04/16, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Rong, Leyi >> Sent: Thursday, April 16, 2020 4:10 PM >> To: Wu, Jingjing ; Zhang, Qi Z >> ; Xing, Beilei ; Ye, Xiaolong >> >> Cc: dev@dpdk.org; Rong, Leyi >> Sub

  1   2   3   4   5   6   7   8   >