[dpdk-dev] [PATCH] doc: fix a typo in programmer's guide

2019-01-06 Thread Yong Wang
This patch fixes a typo in programmer's guide. It should be Frequence, not Fequence. Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Yong Wang --- doc/guides/prog_guide/power_man.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[dpdk-dev] [PATCH v2] doc: fix a typo in programmer's guide

2019-01-07 Thread Yong Wang
This patch fixes a typo in programmer's guide. It should be Frequency, not Fequence. Fixes: 450f0791312c ("power: add traffic pattern aware power control") Signed-off-by: Yong Wang --- v2: modify Frequence to Frequency --- doc/guides/prog_guide/power_man.rst | 2 +- 1

[dpdk-dev] [PATCH] doc/testpmd: fix typo in testpmd guide

2018-10-26 Thread Yong Wang
The forwarding mode mac_swap should be macswap in testpmd guide. Signed-off-by: Yong Wang --- doc/guides/testpmd_app_ug/run_app.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 21924c3

[dpdk-dev] [PATCH] doc/linux_gsg: fix numa lib name error

2018-11-05 Thread Yong Wang
The library for handling NUMA is numactl-devel, not libnuma-devel. Signed-off-by: Yong Wang --- doc/guides/linux_gsg/sys_reqs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst index e2230f3..1cb14b5

[dpdk-dev] [PATCH v2] doc/linux_gsg: fix numa lib name error

2018-11-06 Thread Yong Wang
The library for handling NUMA is not libnuma-devel, but numactl-devel in Red Hat/Fedora and libnuma-dev in Debian/Ubuntu. Signed-off-by: Yong Wang --- v2: * Add lib name in Ubuntu. --- doc/guides/linux_gsg/sys_reqs.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a

Re: [dpdk-dev] [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration

2019-04-12 Thread Yong Wang
-Original Message- From: Eduard Serra Miralles Date: Wednesday, April 10, 2019 at 9:44 PM To: Yong Wang Cc: "dev@dpdk.org" , Eduard Serra Miralles Subject: [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration From: Eduard Serra This patch introduces:

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-04-30 Thread Yong Wang
> -Original Message- > From: Louis Luo [mailto:llo...@vmware.com] > Sent: Monday, April 30, 2018 3:21 PM > To: Yong Wang > Cc: dev@dpdk.org; Louis Luo > Subject: [PATCH] net/vmxnet3: convert to new rx offload api > > Ethdev RX offloads API has changed si

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-13 Thread Yong Wang
-Original Message- From: yogev ch Date: Wednesday, August 22, 2018 at 12:38 AM To: Yong Wang Cc: "dev@dpdk.org" , "yo...@cgstowernetworks.com" Subject: [PATCH] vmxnet3: stats_reset implementation Signed-off-by: yogev ch --- Yogev, The change looks fine t

Re: [dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14

2018-09-13 Thread Yong Wang
-Original Message- From: Padam Jeet Singh Date: Sunday, June 17, 2018 at 12:00 PM To: Stephen Hemminger Cc: "dev@dpdk.org" , Yong Wang Subject: Re: [dpdk-dev] vmxnet3 TX TCP/UDP checksum not getting computed with L2_len > 14 >> On 17-Jun-2018, at 10:16 PM

Re: [dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name

2018-09-13 Thread Yong Wang
rin.ja...@caviumnetworks.com" , "maciej.cze...@caviumnetworks.com" , "arybche...@solarflare.com" , "antosh.shu...@caviumnetworks.com" , "ashish.gu...@cavium.com" , Yong Wang , "bruce.richard...@intel.com" , "tho...@monjalon.net" Sub

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-17 Thread Yong Wang
t()', hw stats which always increase reduce > SNAPSHOT stats. That's how we get the "real" stats since the last > 'stats_reset()'. > > Signed-off-by: yogev ch > --- Acked-by: Yong Wang One nit: in the description, it will be good to mention the reas

Re: [dpdk-dev] [PATCH] vmxnet3: stats_reset implementation

2018-09-20 Thread Yong Wang
PSHOT stats. That's how we get the "real" stats since the last 'stats_reset()'. Signed-off-by: yogev ch --- Acked-by: Yong Wang drivers/net/vmxnet3/vmxnet3_ethdev.c | 78 ++-- drivers/net/vmxnet3/vmxnet3_eth

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-12 Thread Yong Wang
Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped. Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH 2/5] vmxnet3: Add VLAN Tx offload

2014-10-12 Thread Yong Wang
Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 986e5e5..0b6363f 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c +++ b/lib

[dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement

2014-10-12 Thread Yong Wang
This patch series include various fixes and improvement to the vmxnet3 pmd driver. Yong Wang (5): vmxnet3: Fix VLAN Rx stripping vmxnet3: Add VLAN Tx offload vmxnet3: Fix dev stop/restart bug vmxnet3: Add rx pkt check offloads vmxnet3: Some perf improvement on the rx path lib

[dpdk-dev] [PATCH 3/5] vmxnet3: Fix dev stop/restart bug

2014-10-12 Thread Yong Wang
: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 78 --- 1 file changed, 73 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 0b6363f..2017d4b 100644 --- a/lib/librte_pmd_vmxnet3

[dpdk-dev] [PATCH 5/5] vmxnet3: Some perf improvement on the rx path

2014-10-12 Thread Yong Wang
Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 242 -- 1 file changed, 116 insertions(+), 126 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index e2fb8a8..4799f4d 100644 --- a/lib

[dpdk-dev] [PATCH 4/5] vmxnet3: Add rx pkt check offloads

2014-10-12 Thread Yong Wang
Only supports IPv4 so far. Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 2017d4b..e2fb8a8 100644

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-13 Thread Yong Wang
14 2:31 AM To: Yong Wang Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping On Sun, 12 Oct 2014 23:23:05 -0700 Yong Wang wrote: > Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped. > > Signed-off-by: Yong Wang Since vlan_tci i

[dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement

2014-10-13 Thread Yong Wang
Yong From: Thomas Monjalon Sent: Monday, October 13, 2014 1:29 PM To: Yong Wang Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement Hi, 2014-10-12 23:23, Yong Wang: > This patch series include various fixes and improvement to the >

[dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement

2014-10-21 Thread Yong Wang
of Yong Wang Sent: Monday, October 13, 2014 2:00 PM To: Thomas Monjalon Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement Only the last one is performance related and it merely tries to give hints to the compiler to hopefully make branch prediction more

[dpdk-dev] [PATCH 0/5] vmxnet3 pmd fixes/improvement

2014-10-28 Thread Yong Wang
NOXSUMSCTP | ETH_TXQ_FLAGS_NOXSUMUDP | ETH_TXQ_FLAGS_NOXSUMTCP) }; Thanks, Yong From: Thomas Monjalon Sent: Tuesday, October 28, 2014 7:40 AM To: Yong Wang Cc: dev at dpdk.org; Cao, Waterman Subject: Re: [dpdk-dev] [PATCH 0/5] vmxn

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-28 Thread Yong Wang
On 10/22/14, 6:39 AM, "Stephen Hemminger" wrote: >On Mon, 13 Oct 2014 18:42:18 +0000 >Yong Wang wrote: > >> Are you referring to the patch as a whole or your comment is about the >>reset of vlan_tci on the "else" (no vlan tags stripped) path? I am n

[dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping

2014-10-29 Thread Yong Wang
promote it to a public API? Just a thought. Yong On 10/29/14, 2:41 AM, "Thomas Monjalon" wrote: >2014-10-29 09:04, Bruce Richardson: >> On Tue, Oct 28, 2014 at 09:57:14PM +, Yong Wang wrote: >> > On 10/22/14, 6:39 AM, "Stephen Hemminger" >> > wrote:

[dpdk-dev] [PATCH] doc: fixed verbatim sections in vmxnet3 docs

2015-04-13 Thread Yong Wang
, specific versions of DPDK and ESXi are used. I understand that vmxnet3 pmd was introduced in 1.6 but I prefer them to be version-agonostic since the same diagram works for 1.7, 1.8, etc and I don?t see much benefits in spelling out 1.6 in this case. Same arguments to the ESXi version.

[dpdk-dev] [PATCH 2/3] vmxnet3: don't clear vf_table on restart

2015-12-09 Thread Yong Wang
Instead, >setup the shadow table once during device initialization and just update >during restart. > >Signed-off-by: Charles (Chas) Williams >Signed-off-by: Stephen Hemminger >--- Acked-by: Yong Wang > drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 --- > 1

[dpdk-dev] [PATCH 3/3] vmxnet3: fix vlan_offload_set

2015-12-09 Thread Yong Wang
On 12/3/15, 5:05 PM, "Stephen Hemminger" wrote: >From: Nachiketa Prachanda > >vmxnet3_dev_vlan_offload_set(dev, mask) was incorrectly treating the >mask parameter as the bitmask for vlan_strip and vlan_filter, whereas >the mask indicates only what has changed - the values for >vlan_stripping an

[dpdk-dev] Vmxnet3 activation of device fails in DPDK1.7

2015-12-10 Thread Yong Wang
On 12/10/15, 2:22 AM, "dev on behalf of Dey, Souvik" wrote: >Hi, >In DPDK 1.7 , while using the vmxnet3 pmd on vmware Esxi 5.5 > update 3 we are seeing that activation of the device fails. > >status = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD); return a non zero status. >Thoug

[dpdk-dev] Vmxnet3 activation of device fails in DPDK1.7

2015-12-14 Thread Yong Wang
; .rx_thresh = { > .pthresh = RX_PTHRESH, > .hthresh = RX_HTHRESH, > .wthresh = RX_WTHRESH, > }, >}; > >Do you suspect anything wrong in this ? > >-Original Message- >From: Yong Wang [mailto:yongwang at vmware.com] >Sent: Friday, Decembe

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-02 Thread Yong Wang
ley ; Adrien > Mazarguil ; Alejandro Lucero > ; Rasesh Mody > ; Jacob, Jerin ; > Yuanhan Liu ; Yong Wang > ; Kulasek, TomaszX > ; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > 2016-11-30 17:42, Ananyev, Konstantin: > > >

[dpdk-dev] VMXNET3 with 3 processes

2014-11-04 Thread Yong Wang
On 11/3/14, 7:49 AM, "Yan Freedland" wrote: >Hi > >I am trying to initialize the environment for 3 processes and 2 ports. >Currently I fail in vmxnet3_dev_start (0). >The exact place is as follows: > > /* Activate device by register write */ > VMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_C

[dpdk-dev] [PATCH v2 2/6] vmxnet3: Add VLAN Tx offload

2014-11-04 Thread Yong Wang
Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 986e5e5..0b6363f 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c +++ b/lib

[dpdk-dev] [PATCH v2 3/6] vmxnet3: Fix dev stop/restart bug

2014-11-04 Thread Yong Wang
: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 78 --- 1 file changed, 73 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 0b6363f..2017d4b 100644 --- a/lib/librte_pmd_vmxnet3

[dpdk-dev] [PATCH v2 5/6] vmxnet3: Perf improvement on the rx path

2014-11-04 Thread Yong Wang
GHzx2) shown below. CPU usage is collected factoring out the idle loop cost. - Before the patch, ~900K PPS with 65% CPU of a core used for DPDK. - After the patch, only 45% of a core used, while maintaining the same packet rate. Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH v2 6/6] vmxnet3: Leverage data_ring on tx path

2014-11-04 Thread Yong Wang
l be beneficial. Performance results show that this patch significantly boosts vmxnet3 64B tx performance (pkt rate) for l2fwd application on a Ivy Bridge server by >20% at which point we start to hit some bottleneck on the rx side. Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.

[dpdk-dev] [PATCH v2 1/6] vmxnet3: Fix VLAN Rx stripping

2014-11-04 Thread Yong Wang
Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped. Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH v2 0/6] vmxnet3 pmd fixes/improvement

2014-11-04 Thread Yong Wang
This patch series include various fixes and improvement to the vmxnet3 pmd driver. V2: - Add more commit descriptions - Add a new patch that improve tx performance for small packet Yong Wang (6): vmxnet3: Fix VLAN Rx stripping vmxnet3: Add VLAN Tx offload vmxnet3: Fix dev stop/restart bug

[dpdk-dev] [PATCH v2 4/6] vmxnet3: Add rx pkt check offloads

2014-11-04 Thread Yong Wang
Only supports IPv4 so far. Signed-off-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 2017d4b..e2fb8a8 100644

[dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-07 Thread Yong Wang
>> As to HW TX checksum offload, do you have special requirement for >> implementing TSO? > Yes. TSO implies TX TCP and IP checksum offload. Is this a general requirement or something specific to ixgbe/i40e? FWIW, vmxnet3 device does not support tx IP checksum offload but doe support TSO. In

[dpdk-dev] FW: [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload

2014-11-11 Thread Yong Wang
On 11/7/14, 9:16 AM, "Olivier MATZ" wrote: >Hello Yong, > >On 11/07/2014 01:43 AM, Yong Wang wrote: >>>> As to HW TX checksum offload, do you have special requirement for >>>>implementing TSO? >> >>> Yes. TSO implies TX TCP and I

[dpdk-dev] [PATCH 6/7] vmxnet3: support RSS and refactor offload

2015-03-05 Thread Yong Wang
I believe I have ACKed v1 of this commit but I didn't see ACKed-by in v2. Or is there any changes from v1? If that?s the case, can you explain the changes in the changelog? On 2/25/15, 6:32 PM, "Stephen Hemminger" wrote: >Refactor the logic to compute receive offload flags to a simpler >functi

[dpdk-dev] [PATCH 4/7] vmxnet3: add support for multi-segment transmit

2015-03-05 Thread Yong Wang
A quick glance over v2 shows that it only made the change for max segment check. I am not sure if all the other comments on v1 of this patch are missed or ignored? If it?s the latter, can you explain your reasoning why they are not addressed? On 2/25/15, 6:31 PM, "Stephen Hemminger" wrote: >C

[dpdk-dev] [PATCH 3/7] vmxnet3: cleanup txq stats

2015-03-05 Thread Yong Wang
On 2/25/15, 6:31 PM, "Stephen Hemminger" wrote: >There are several stats here which are never set, and have no way >to be displayed. Assume in future xstats could be used. > >Signed-off-by: Stephen Hemminger Acked-by: Yong Wang >--- > lib/librte_pmd

[dpdk-dev] [PATCH v3 02/10] vmxnet3: enable VLAN filtering

2015-03-06 Thread Yong Wang
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote: >From: Stephen Hemminger > >Support the VLAN filter functionality of the VMXNET3 interface. > >Signed-off-by: Stephen Hemminger Acked-by: Yong Wang >--- > lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 105 >

[dpdk-dev] [PATCH v3 08/10] vmxnet3: get rid of DEBUG ifdefs

2015-03-06 Thread Yong Wang
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote: >By defining macro as a stub it is possible to get rid of #ifdef's >in the actual code. Always evaluate the argument (even in the stub) >so that there are no extra unused variable errors. > >Signed-off-by: Stephen H

[dpdk-dev] [PATCH v3 09/10] vmxnet3: add check for jumbo segment

2015-03-06 Thread Yong Wang
n Hemminger One minor comment below. Otherwise looks good to me. Acked-by: Yong Wang >--- > lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 1 + > lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 18 ++ > 2 files changed, 19 insertions(+) > >diff --git a/lib/librte_pmd

[dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining

2015-03-06 Thread Yong Wang
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote: >From: Stephen Hemminger > >No reason to inline large functions. Compiler will decide already >based on optimization level. > >Also register array should be const. > >Signed-off-by: Stephen Hemminger One c

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

2015-03-09 Thread Yong Wang
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote: >From: Stephen Hemminger > >Add support for linking multi-segment buffers together to >handle Jumbo packets. > >Signed-off-by: Stephen Hemminger >--- > lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +- > lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 2 +

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

2015-03-09 Thread Yong Wang
On 3/9/15, 4:28 PM, "Yong Wang" wrote: >On 3/5/15, 4:10 PM, "Stephen Hemminger" >wrote: > >>From: Stephen Hemminger >> >>Add support for linking multi-segment buffers together to >>handle Jumbo packets. >> >>Signed-off-by: St

[dpdk-dev] [PATCH v3 07/10] vmxnet3: support jumbo frames

2015-03-11 Thread Yong Wang
On 3/10/15, 11:35 AM, "Stephen Hemminger" wrote: >On Mon, 9 Mar 2015 23:32:48 +0000 >Yong Wang wrote: > >> > >> >I didn?t see where mtu is used to calculate how many rx descriptors >>will >> >be needed for each packet. Furthermore, as p

[dpdk-dev] [PATCH v3 0/8] vmxnet3: driver updates

2015-07-09 Thread Yong Wang
>++- > 4 files changed, 266 insertions(+), 205 deletions(-) > >-- >2.1.4 Assuming this series is a simple rebase of the previous patchset, which I already acked (I didn?t see the Acked-by updated though in the new version): Series Acked-by: Yong Wang

Re: [PATCH v2 1/8] net/vmxnet3: add V5 support

2022-05-04 Thread Yong Wang
Pankaj, Can you add reviewed-by info? Also, you need to add info of what has changed since the last version. Yong > On May 4, 2022, at 2:23 PM, Pankaj Gupta wrote: > > Add VMXNET3 v5 support > > Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. > > Signed-off-by:

Re: [PATCH] maintainers: update for vmxnet3 driver

2022-05-06 Thread Yong Wang
> On May 6, 2022, at 1:07 PM, Jochen Behrens wrote: > > Make Jochen Behrens the maintainer of the net/vmxnet3 device > driver as Yong Wang is not working on vmxnet3 any more. > > Signed-off-by: Jochen Behrens > --- Acked-by: yongw...@vmware.com > MAINTAINERS |

[dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-18 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang Reviewed-By: Shreyansh Jain --- v3: * Rebase on master and modify agai

[dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-18 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang Reviewed-By: Shreyansh Jain --- v3: * Rebase on master and modify agai

[dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-18 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang --- v3: * Rebase on master and modify again. v2: * Fix code style wa

[dpdk-dev] [PATCH v3 1/3] net/i40e: add null point check and fix mem leak

2018-01-22 Thread Yong Wang
Signed-off-by: Yong Wang --- v2: * Fix code style warning. --- drivers/net/i40e/i40e_ethdev.c | 32 drivers/net/i40e/i40e_fdir.c | 7 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index

[dpdk-dev] [PATCH v3 3/3] crypto/qat: add null point check and fix mem leak

2018-01-22 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang --- v3: * Rebase on master and modify again. v2: * Fix code style wa

[dpdk-dev] [PATCH v3 2/3] net/e1000: add null point check for rte_zmalloc

2018-01-22 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/e1000/igb_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index d98bdc8..a142759 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c

[dpdk-dev] [PATCH v4] crypto/qat: add null point check and fix mem leak

2018-01-24 Thread Yong Wang
quot;crypto/qat: add SGL capability") Signed-off-by: Yong Wang --- v4: * Cover errors that happen after the rte_mempool_create. * Add fix information. v3: * Rebase on master and modify again. v2: * Fix code style warning. --- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 10 ++ dr

[dpdk-dev] [PATCH v4] net/e1000: add null point check for rte_zmalloc

2018-01-25 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. Fix it by adding null point check. Fixes: 22bb13410cb2 ("net/igb: create consistent filter") Signed-off-by: Yong Wang --- v4: * Add description and fix information. v3: * Rebas

[dpdk-dev] [PATCH v4] net/i40e: add null point check and fix mem leak

2018-01-25 Thread Yong Wang
t/i40e: store tunnel filter") Fixes: c50474f31efe ("net/i40e: support tunnel filter to VF") Fixes: 5c53c82c8174 ("net/i40e: store flow director filter") Signed-off-by: Yong Wang --- v4: * Add description and fix information. v3: * Rebase on master and modify again. v2: *

[dpdk-dev] [PATCH v2] net/i40e: fix uninitialized variable

2017-10-10 Thread Yong Wang
In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in func call i40evf_dev_atomic_write_link_status(), but is uninitialized. Fixes: 2a73125b7041 ("i40evf: fix link info update") Cc: sta...@dpdk.org Signed-off-by: Yong Wang --- v2 change: set it by che

Re: [dpdk-dev] vmxnet3 RX VLAN Strip offload incorrect behaviour

2018-04-06 Thread Yong Wang
Padam, As far as I know, this feature works. What DPDK version did you use? Is there any port reconfiguration (stop/start/mtu change, etc) that could lose your vlan offload settings (a dump of the port config at runtime will be able to confirm this)? Can you also post a snippet of packet cap

Re: [dpdk-dev] vmxnet3 RX VLAN Strip offload incorrect behaviour

2018-04-09 Thread Yong Wang
018, at 11:12 PM, Yong Wang wrote: > > Padam, > > As far as I know, this feature works. What DPDK version did you use? DPDK Version 17.05 > Is there any port reconfiguration (stop/start/mtu change, etc) that could lose your vlan offload setting

Re: [dpdk-dev] [PATCH] vmxnet3: fill in imissed stat with pktsRxOutOfBuf

2018-04-10 Thread Yong Wang
rx_nombuf field. Signed-off-by: Jon DeVree --- Acked-by: Yong Wang drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c index 4260087

Re: [dpdk-dev] [PATCH] net/vmxnet3: change the SPDX tag style

2018-04-12 Thread Yong Wang
On 4/9/18, 2:00 AM, "dev on behalf of Hemant Agrawal" wrote: Cc: skh...@vmware.com Signed-off-by: Hemant Agrawal --- Acked-by: Yong Wang drivers/net/vmxnet3/base/upt1_defs.h| 7 ++- drivers/net/vmxnet3/base/vmxnet3_defs.h | 7 ++- 2 files

Re: [dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues

2018-04-12 Thread Yong Wang
On 3/28/18, 8:44 AM, "dev on behalf of Didier Pallard" wrote: This patchset fixes several issues found in vmxnet3 driver when enabling LRO offload support: - Rx offload information are not correctly gathered in multisegmented packets, leading to inconsistent packet type an

Re: [dpdk-dev] [PATCH 2/8] net/vmxnet3: return unknown IPv4 extension len ptype

2018-04-16 Thread Yong Wang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Didier Pallard > Sent: Wednesday, March 28, 2018 8:44 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/8] net/vmxnet3: return unknown IPv4 > extension len ptype > > Rather than parsing IP header to get proper p

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-04-18 Thread Yong Wang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, April 17, 2018 1:24 PM > To: Ferruh Yigit > Cc: Chas Williams <3ch...@gmail.com>; Chas Williams ; > dev@dpdk.org; skh...@vmware.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-

Re: [dpdk-dev] [PATCH] net/vmxnet3: increase rx data ring descriptor size

2018-04-19 Thread Yong Wang
> -Original Message- > From: Shraddha Joshi [mailto:jshrad...@vmware.com] > Sent: Thursday, April 19, 2018 11:19 AM > To: Yong Wang > Cc: dev@dpdk.org; Shraddha Joshi > Subject: [PATCH] net/vmxnet3: increase rx data ring descriptor size > > Vmxnet3 driver suppor

Re: [dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues

2018-04-20 Thread Yong Wang
rte_net/rte_net_version.map | 1 + > 9 files changed, 238 insertions(+), 43 deletions(-) > > -- > 2.11.0 For this series, Acked-by: Yong Wang

[dpdk-dev] [PATCH] maintainers: claim responsibility for vmxnet3 pmd

2018-03-30 Thread Yong Wang
Signed-off-by: Yong Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 75d3e92c8..7bc370cf4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -552,7 +552,7 @@ F: doc/guides/nics/sfc_efx.rst F: doc/guides/nics/features/sfc_efx.ini

[dpdk-dev] [PATCH] net/e1000: fix memcpy length error

2017-09-12 Thread Yong Wang
The size of "flex_filter.filter_info.mask" and "filter->mask" is 16 bytes, but the length of memcpy--"RTE_ALIGN(filter->len, sizeof(char)) / sizeof(char)" may reach 128 bytes which may cause array access out of bound. Fix it by replacing "sizeof(char)&

[dpdk-dev] [PATCH] net/ark:add null point check

2017-09-14 Thread Yong Wang
In function ark_config_device(), there are several malloc without null point check. Fix it by adding null point check. Signed-off-by: Yong Wang --- drivers/net/ark/ark_ethdev.c | 6 ++ drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktdir.c | 4 drivers/net/ark

[dpdk-dev] [PATCH] net/ark:add null point check

2017-09-14 Thread Yong Wang
In function ark_config_device(), there are several malloc without null point check. Fix it by adding null point check. Signed-off-by: Yong Wang --- drivers/net/ark/ark_ethdev.c | 6 ++ drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktdir.c | 4 drivers/net/ark

[dpdk-dev] [PATCH v2] net/ark:add null point check

2017-09-14 Thread Yong Wang
In function ark_config_device(), there are several malloc without null point check. Fix it by adding null point check. v2: * Fix compile error. Signed-off-by: Yong Wang --- drivers/net/ark/ark_ethdev.c | 6 ++ drivers/net/ark/ark_pktchkr.c | 4 drivers/net/ark/ark_pktdir.c | 5

[dpdk-dev] [PATCH] net/liquidio: fix uninitialized variable

2017-09-14 Thread Yong Wang
In func lio_dev_link_update(), "link.link_autoneg" is used in func call lio_dev_atomic_write_link_status(), but is uninitialized. Signed-off-by: Yong Wang --- drivers/net/liquidio/lio_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/liquidio/lio_ethdev.c b/d

[dpdk-dev] [PATCH] buildtools: add null point check for calloc

2017-09-15 Thread Yong Wang
In func locate_pmd_entries(), pointer 'new' returned from call to func 'calloc' may be NULL. It is dereferenced without null point check. Signed-off-by: Yong Wang --- buildtools/pmdinfogen/pmdinfogen.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) dif

[dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable

2017-09-15 Thread Yong Wang
In func lio_dev_link_update(), "link.link_autoneg" is used in func call lio_dev_atomic_write_link_status(), but is uninitialized. v2: * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED' to 'ETH_LINK_AUTONEG'. Signed-off-by: Yong Wang

[dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable

2017-09-18 Thread Yong Wang
In func ixgbe_dev_link_update(), "link.link_autoneg" is used in func call rte_ixgbe_dev_atomic_write_link_status(), but is uninitialized. Signed-off-by: Yong Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c

[dpdk-dev] [PATCH] linuxapp/eal: fix memory leak

2017-09-20 Thread Yong Wang
In func rte_eal_init(), dynamic memory stored in 'logid' allocated through func 'strdup' is lost when return. Fix it by freeing the memory before return. Signed-off-by: Yong Wang --- lib/librte_eal/linuxapp/eal/eal.c | 19 ++- 1 file changed, 18 inser

[dpdk-dev] [PATCH] net/i40e: fix uninitialized variable

2017-09-22 Thread Yong Wang
In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in func call i40evf_dev_atomic_write_link_status(), but is uninitialized. Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethd

[dpdk-dev] [PATCH] doc/failsafe: fix typos in nics guide

2017-08-18 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/nics/fail_safe.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/fail_safe.rst b/doc/guides/nics/fail_safe.rst index 34ecae2..c4e3d2e 100644 --- a/doc/guides/nics/fail_safe.rst +++ b/doc/guides/nics/fail_safe.rst

[dpdk-dev] [PATCH 3/4] net/e1000: add null point check for rte_zmalloc

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/e1000/igb_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index 22bad26..057579b 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c

[dpdk-dev] [PATCH 4/4] crypto/qat: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 10 ++ drivers/crypto/qat/qat_qp.c | 8 +++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat

[dpdk-dev] [PATCH 1/4] net/dpaa: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/dpaa/dpaa_ethdev.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index cf5a2ec..06d680c 100644 --- a/drivers/net/dpaa

[dpdk-dev] [PATCH 2/4] net/i40e: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev.c | 32 drivers/net/i40e/i40e_fdir.c | 7 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 811cc9f..8101e10 100644 --- a

[dpdk-dev] [PATCH v2 4/4] crypto/qat: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 10 ++ drivers/crypto/qat/qat_qp.c | 8 +++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_adf/qat_algs_build_desc.c b/drivers/crypto/qat

[dpdk-dev] [PATCH v2 3/4] net/e1000: add null point check for rte_zmalloc

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/e1000/igb_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index 22bad26..057579b 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c

[dpdk-dev] [PATCH v2 1/4] net/dpaa: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- drivers/net/dpaa/dpaa_ethdev.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index cf5a2ec..06d680c 100644 --- a/drivers/net/dpaa

[dpdk-dev] [PATCH v2 2/4] net/i40e: add null point check and fix mem leak

2017-12-20 Thread Yong Wang
Signed-off-by: Yong Wang --- v2: * Fix code style warning. --- drivers/net/i40e/i40e_ethdev.c | 32 drivers/net/i40e/i40e_fdir.c | 7 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index

[dpdk-dev] [PATCH] net/virtio: fix the wrong comment

2017-06-22 Thread Yong Wang
Since "rte_eal_dev_init()" has been removed, the comment referred to it should be modified simultaneously. Signed-off-by: Yong Wang --- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_user_ethdev.c

[dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error

2017-06-23 Thread Yong Wang
o 1 just as func i40e_vsi_update_queue_mapping() does. Signed-off-by: Yong Wang --- drivers/net/i40e/i40e_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4ee1113..0f54d09 100644 --- a/

[dpdk-dev] [PATCH] doc/metrics: fix variable undefined error

2017-07-18 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/prog_guide/metrics_lib.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/prog_guide/metrics_lib.rst b/doc/guides/prog_guide/metrics_lib.rst index 702c29d..d52204f 100644 --- a/doc/guides/prog_guide/metrics_lib.rst +++ b/doc/guides

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Yong Wang
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Sunday, December 4, 2016 4:11 AM > To: Yong Wang ; Thomas Monjalon > > Cc: Harish Patil ; dev@dpdk.org; Rahul Lakkireddy > ; Stephen Hurd > ; Jan Medala ; Jakub > Pa

[dpdk-dev] [PATCH] doc: fix mistakes in contribution guide

2016-12-07 Thread Yong Wang
Signed-off-by: Yong Wang --- doc/guides/contributing/documentation.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst index 5ec0675..5f16a0c 100644 --- a/doc/guides/contributing

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-08 Thread Yong Wang
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, December 7, 2016 2:03 AM > To: Yigit, Ferruh ; Yong Wang > ; Thomas Monjalon > > Cc: Harish Patil ; dev@dpdk.org; Rahul Lakkireddy > ; Stephen Hurd > ; J

Re: [dpdk-dev] Does DPDK 1.7.1 support jumboframes for VMXNET3

2016-12-08 Thread Yong Wang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kanika Singhal > Sent: Wednesday, December 7, 2016 12:18 AM > To: dev@dpdk.org > Subject: [dpdk-dev] Does DPDK 1.7.1 support jumboframes for VMXNET3 > > Hi, > > I am a new to DPDK. > > My product is using DPDK 1.

[dpdk-dev] [PATCH v2] doc: fix mistakes in contribution guide

2016-12-09 Thread Yong Wang
Signed-off-by: Yong Wang --- v2: * modify some redundant descriptions. --- doc/guides/contributing/documentation.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst index 5ec0675

  1   2   3   >