lt;alejandro.luc...@netronome.com>; Rasesh Mody
> <rasesh.m...@qlogic.com>; Jacob, Jerin <jerin.ja...@cavium.com>;
> Yuanhan Liu <yuanhan@linux.intel.com>; Yong Wang
> <yongw...@vmware.com>; Kulasek, TomaszX
> <tomaszx.kula...@intel.com>; olivier.m...@6w
Current code does not close 'fd' on function exit, leaking resources.
Signed-off-by: Yong Wang
---
drivers/net/qede/qede_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index ab22409..b666e1c 100644
--- a/drivers/net/qede
> -Original Message-
> From: Stefan Puiu [mailto:stefan.puiu at gmail.com]
> Sent: Monday, November 14, 2016 2:46 AM
> To: dev at dpdk.org
> Cc: mac_leehk at yahoo.com.hk; Yong Wang ;
> Stefan Puiu
> Subject: [PATCH] vmxnet3: fix Rx deadlock
>
> Our use
Signed-off-by: Yong Wang
---
lib/librte_mempool/rte_mempool.h | 2 +-
lib/librte_ring/rte_ring.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 440f3b1..c221333 100644
--- a/lib/librte_mempool
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, October 10, 2016 6:20 AM
> To: dev at dpdk.org
> Cc: Ferruh Yigit
> Subject: [dpdk-dev] [PATCH v3] net/kni: add KNI PMD
>
> Add KNI PMD which wraps librte_kni for ease of use.
>
>
is done in the rx routine)
and the mbuf should always be a single-segment one when populated.
For tx, we can use the existing way as mbuf, if any, will be a
valid one stashed in the eop.
Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver
implementation")
Signed-off-by:
The current implementation of jumbo frame rx can be used for
LRO directly without changes. This change enables device
LRO if requested.
Note that since jumbo frame uses both ring0 and ring1, it
cannot be enabled in UPT (VMDirectPath) mode.
Signed-off-by: Yong Wang
Acked-by: Stephen Hemminger
Signed-off-by: Yong Wang
Acked-by: Stephen Hemminger
---
doc/guides/nics/vmxnet3.rst | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/doc/guides/nics/vmxnet3.rst b/doc/guides/nics/vmxnet3.rst
index e919088..bf84594 100644
--- a/doc/guides/nics/vmxnet3.rst
+++ b
Signed-off-by: Yong Wang
Acked-by: Stephen Hemminger
---
doc/guides/nics/features/vmxnet3.ini | 21 +
1 file changed, 21 insertions(+)
diff --git a/doc/guides/nics/features/vmxnet3.ini
b/doc/guides/nics/features/vmxnet3.ini
index 20a4c32..c5c75ad 100644
--- a/doc/guides
one.
Signed-off-by: Yong Wang
Reviewed-by: Guolin Yang
Reviewed-by: Daniele Di Proietto
Tested-by: Daniele Di Proietto
Acked-by: Stephen Hemminger
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers
Signed-off-by: Yong Wang
Acked-by: Stephen Hemminger
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 69 ++--
drivers/net/vmxnet3/vmxnet3_ethdev.h | 32 -
drivers/net/vmxnet3/vmxnet3_ring.h | 22 ++--
drivers/net/vmxnet3/vmxnet3_rxtx.c | 59
Signed-off-by: Yong Wang
Acked-by: Stephen Hemminger
Reviewed-by: Juho Snellman
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
.
* the driver will now report error if the rx queue number is
not a power of two, instead of waiting for the activation
to fail.
* Instead of returning -1 (which is interpreted as -EPERM) on
device activation failure, -EINVAL is returned now.
* Enabled LRO if requested.
Yong Wang (6
The current implementation of jumbo frame rx can be used for
LRO directly without changes. This change enables device
LRO if requested.
Note that since jumbo frame uses both ring0 and ring1, it
cannot be enabled in UPT (VMDirectPath) mode.
Signed-off-by: Yong Wang
---
doc/guides/nics/features
Signed-off-by: Yong Wang
---
doc/guides/nics/vmxnet3.rst | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/doc/guides/nics/vmxnet3.rst b/doc/guides/nics/vmxnet3.rst
index e919088..bf84594 100644
--- a/doc/guides/nics/vmxnet3.rst
+++ b/doc/guides/nics/vmxnet3.rst
Signed-off-by: Yong Wang
---
doc/guides/nics/features/vmxnet3.ini | 21 +
1 file changed, 21 insertions(+)
diff --git a/doc/guides/nics/features/vmxnet3.ini
b/doc/guides/nics/features/vmxnet3.ini
index 20a4c32..c5c75ad 100644
--- a/doc/guides/nics/features/vmxnet3.ini
+++ b
one.
Signed-off-by: Yong Wang
Reviewed-by: Guolin Yang
Reviewed-by: Daniele Di Proietto
Tested-by: Daniele Di Proietto
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 69 ++--
drivers/net/vmxnet3/vmxnet3_ethdev.h | 32 -
drivers/net/vmxnet3/vmxnet3_ring.h | 22 ++--
drivers/net/vmxnet3/vmxnet3_rxtx.c | 59
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 5874215..f5035bb 100644
--- a/drivers/net/vmxnet3
queue number is
not a power of two, instead of waiting for the activation
to fail.
* Instead of returning -1 (which is interpreted as -EPERM) on
device activation failure, -EINVAL is returned now.
* Enabled LRO if requested.
Yong Wang (6):
net/vmxnet3: improve error checks and return
The current implementation of jumbo frame rx can be used for
LRO directly without changes. This change enables device
LRO if requested.
Note that since jumbo frame uses both ring0 and ring1, it
cannot be enabled in UPT (VMDirectPath) mode.
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3
one.
Signed-off-by: Yong Wang
Reviewed-by: Guolin Yang
Reviewed-by: Daniele Di Proietto
Tested-by: Daniele Di Proietto
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 69 ++--
drivers/net/vmxnet3/vmxnet3_ethdev.h | 32 -
drivers/net/vmxnet3/vmxnet3_ring.h | 22 ++--
drivers/net/vmxnet3/vmxnet3_rxtx.c | 59
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 5874215..f5035bb 100644
--- a/drivers/net/vmxnet3
to fail. Instead of returning -1 (which is interpreted as
-EPERM) on device activation failure, -EINVAL is returned
to avoid confusion.
(3) enables LRO if requested.
Yong Wang (4):
net/vmxnet3: improve error checks and return values
net/vmxnet3: coding style changes
net/vmxnet3
Z|00032|coverage|INFO|cmap_expand
>>>>> 0.0/sec 0.000/sec0./sec total: 22
>>>>> 2016-07-21T09:33:36Z|00033|coverage|INFO|cmap_shrink
>>>>> 0.0/sec 0.000/sec0./sec total: 7
>>>>> 2016-07-21T09:33:36Z|00034|cover
instead of rxq
interrupt in such cases and currently there is no easy way to achieve that. Or
is there any particular reason such a preference is chosen?
>>
>> On 7/15/2016 8:36 AM, Yong Wang wrote:
>>> When binding a device to igb_uio with intr_conf.rxq set to 1, nb_efd
>&g
When binding a device to igb_uio with intr_conf.rxq set to 1, nb_efd
is 1 (for link event) but rte_intr_dp_is_en() will still return true.
rte_intr_dp_is_en() should also consider intr_handle type in addition
to nb_efd.
Signed-off-by: Yong Wang
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c
BARs with MSI-X tables")
Signed-off-by: Yong Wang
Signed-off-by: Ronghua Zhang
---
v2:
* Addressed review comment from Dan
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
b/lib/
Signed-off-by: Yong Wang
---
lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
index 3729c35..6492216 100644
--- a/lib/librte_eal/linuxapp
The offset of the 2nd mmap when mapping the region after msix_bar
needs to take region address into consideration. This is exposed
when using vfio-pci to manage vmxnet3 pmd.
Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
Signed-off-by: Yong Wang
Signed-off-b
> On Jun 23, 2016, at 3:52 AM, Ferruh Yigit wrote:
>
> To prevent double 0x in logs
>
> Signed-off-by: Ferruh Yigit
> ?
Acked-by: Yong Wang
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/driv
On 6/16/16, 10:40 AM, "dev on behalf of Yong Wang" wrote:
>On 5/16/16, 5:27 AM, "dev on behalf of Olivier Matz" on behalf of olivier.matz at 6wind.com> wrote:
>
>>Hi Beilei,
>>
>>On 05/13/2016 10:15 AM, Beilei Xing wrote:
>>> This patch
On 5/16/16, 5:27 AM, "dev on behalf of Olivier Matz" wrote:
>Hi Beilei,
>
>On 05/13/2016 10:15 AM, Beilei Xing wrote:
>> This patch enables configuring MTU for i40e.
>> Since changing MTU needs to reconfigure queue, stop port first
>> before configuring MTU.
>>
>> Signed-off-by: Beilei Xing
>>
ms0=qucd32eb66O4TLIXrrV-znC7i8UqlSsNVl12u64zFxI=P5mdk_qNVscagTjvA2DK44y4vfbI0yN2M8XDlBirX5M=
> for more details. Thanks
Please add the sign-off and fixes info as Thomas suggested.
Acked-by: Yong Wang
On 3/30/16, 2:38 PM, "Stephen Hemminger" wrote:
>These asserts are only for debugging and never fired during
>any testing, but they confuse coverity's null tracking.
>
>Signed-off-by: Stephen Hemminger
>---
Acked-by: Yong Wang
> drivers/net/vmxnet3/vmxnet3_rx
Reported-by: Heng Ding
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 3 +--
drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index f2b6b9
On 3/23/16, 8:55 AM, "Thomas Monjalon" wrote:
>2016-03-23 05:57, Yong Wang:
>> From: Ding, HengX
>> > Testpmd will fail to start up with vmxnet3 port.
>[...]
>> Currently vmxnet3?s default_txconf.txq_flags is set to the following, which
>> is used b
w step 1-4.
6. Compile dpdk, bind vmxnet3 port to igb_uio and run testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 -- -i
Here is the bisect result:
f598fd063bb17eba9310ff48164014d09f40c759 is the first bad commit
commit f598fd063bb17eba9310ff48164014d09f40c759
Author: Yong Wan
w step 1-4.
6. Compile dpdk, bind vmxnet3 port to igb_uio and run testpmd:
./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4 -- -i
Here is the bisect result:
f598fd063bb17eba9310ff48164014d09f40c759 is the first bad commit
commit f598fd063bb17eba9310ff48164014d09f40c759
Author: Yong Wan
On 3/4/16, 7:25 AM, "Remy Horton" wrote:
>Implements driver support for setting of MAC address.
>
>Signed-off-by: Remy Horton
Acked-by: Yong Wang
mac_hi is not initialized so the upper 16bits are random when calling
VMXNET3_WRITE_BAR1_REG(). The handler of the mac chang
On 1/28/16, 12:48 AM, "Remy Horton" wrote:
>Implements driver support for fetching Tx and Rx queue information, and
>setting of MAC address.
>
>Signed-off-by: Remy Horton
>---
> doc/guides/rel_notes/release_2_3.rst | 5 +++
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 60
On 1/5/16, 4:52 PM, "Stephen Hemminger" wrote:
>On Tue, 5 Jan 2016 16:12:58 -0800
>Yong Wang wrote:
>
>>
>> /* return 0 means link status changed, -1 means not changed */
>> @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev,
On 1/5/16, 4:51 PM, "Stephen Hemminger" wrote:
>On Tue, 5 Jan 2016 16:12:56 -0800
>Yong Wang wrote:
>
>> -if (txq->shared->ctrl.txNumDeferred >= txq->shared->ctrl.txThreshold) {
>> +PMD_TX_LOG(DEBUG, "vmxnet3 txThresho
On 1/5/16, 4:48 PM, "Stephen Hemminger" wrote:
>On Tue, 5 Jan 2016 16:12:55 -0800
>Yong Wang wrote:
>
>> @@ -365,6 +366,14 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf
>> **tx_pkts,
>> break;
>> }
>&
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index d90e62f..8a40127 100644
--- a/drivers/net/vmxnet3
This commit adds vmxnet3 TSO support.
Verified with test-pmd (set fwd csum) that both tso and
non-tso pkts can be successfully transmitted and all
segmentes for a tso pkt are correct on the receiver side.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +
drivers/net
Support TCP/UDP checksum offload.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 26 +++---
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b/doc/guides
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c
b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 4ccab0e..f3af2f2 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b
-did the same test on a different setup (Haswell
processor, ~2.3GHz clock rate) on top of the master
and still observed ~17% performance gains.
Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 5 +
d
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/base/includeCheck.h | 39 -
drivers/net/vmxnet3/base/vmxnet3_defs.h | 9 +---
drivers/net/vmxnet3/vmxnet3_ethdev.c| 2 +-
drivers/net/vmxnet3/vmxnet3_ring.h | 13 ---
drivers/net/vmxnet3
()
This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
One of the use cases is to support STT. It also restores the tx
data ring feature that was removed from a previous patch.
Yong Wang (6):
vmxnet3: fix typos and remove unused struct
vmxnet3: restore tx data ring support
On 1/4/16, 9:15 PM, "Stephen Hemminger" wrote:
>On Mon, 4 Jan 2016 18:28:18 -0800
>Yong Wang wrote:
>
>> +/* The number of descriptors that are needed for a packet. */
>> +static unsigned
>> +txd_estimate(const struct rte_mbuf *m)
>> +{
>>
On 1/4/16, 9:14 PM, "Stephen Hemminger" wrote:
>On Mon, 4 Jan 2016 18:28:18 -0800
>Yong Wang wrote:
>
>> +mbuf = txq->cmd_ring.buf_info[eop_idx].m;
>> +if (unlikely(mbuf == NULL))
>> +rte_panic("EOP desc does not point to
On 1/4/16, 9:16 PM, "Stephen Hemminger" wrote:
>On Mon, 4 Jan 2016 18:28:16 -0800
>Yong Wang wrote:
>
>> Tx data ring support was removed in a previous change
>> to add multi-seg transmit. This change adds it back.
>>
>> Fixes: 7ba5de417e3
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index c363bf6..8a40127 100644
--- a/drivers/net/vmxnet3
This commit adds vmxnet3 TSO support.
Verified with test-pmd (set fwd csum) that both tso and
non-tso pkts can be successfully transmitted and all
segmentes for a tso pkt are correct on the receiver side.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +
drivers/net
Support TCP/UDP checksum offload.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 39 +++-
2 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b
the same test on a different setup (Haswell
processor, ~2.3GHz clock rate) on top of the master
and still observed ~17% performance gains.
Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 5 +
d
for these features is to support STT. It also
restores the tx data ring feature that was removed from a previous
patch.
Yong Wang (4):
vmxnet3: restore tx data ring support
vmxnet3: add tx l4 cksum offload
vmxnet3: add TSO support
vmxnet3: announce device offload capability
doc/guides/rel_notes
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index c363bf6..8a40127 100644
--- a/drivers/net/vmxnet3
This commit adds vmxnet3 TSO support.
Verified with test-pmd (set fwd csum) that both tso and non-tso
pkts can be successfully transmitted and all segmentes for a tso
pkt are correct on the receiver side.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +
drivers/net
Support TCP/UDP checksum offload.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 39 +++-
2 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b
Tx data ring support was removed in a previous change
to add multi-seg transmit. This change adds it back.
Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 5 +
drivers/net/vmxnet3/vmxnet3_rxt
that was removed from a previous
patch.
Yong Wang (4):
vmxnet3: restore tx data ring support
vmxnet3: add tx l4 cksum offload
vmxnet3: add TSO support
vmxnet3: announce device offload capability
doc/guides/rel_notes/release_2_3.rst | 11 +++
drivers/net/vmxnet3/vmxnet3_ethdev.c | 16
Signed-off-by: Yong Wang
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index c363bf6..8a40127 100644
--- a/drivers/net/vmxnet3
This commit adds vmxnet3 TSO support.
Verified with test-pmd (set fwd csum) that both tso and non-tso
pkts can be successfully transmitted and all segmentes for a tso
pkt are correct on the receiver side.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +
drivers/net
Support TCP/UDP checksum offload.
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 3 +++
drivers/net/vmxnet3/vmxnet3_rxtx.c | 35 ---
2 files changed, 31 insertions(+), 7 deletions(-)
diff --git a/doc/guides/rel_notes/release_2_3.rst
b
Tx data ring support was removed in a previous change
to add multi-seg transmit. This change adds it back.
Fixes: 7ba5de417e3c ("vmxnet3: support multi-segment transmit")
Signed-off-by: Yong Wang
---
doc/guides/rel_notes/release_2_3.rst | 5 +
drivers/net/vmxnet3/vmxnet3_rxt
This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
It also restores the tx data ring feature that was removed from a
previous patch and fixes offload capability announcement.
Yong Wang (4):
vmxnet3: restore tx data ring support
vmxnet3: add tx l4 cksum offload
vmxnet3: add
On 7/23/15, 5:53 PM, "dev on behalf of Marco Lee" wrote:
>The RX of VMXNET3 PMD will have deadlock when a lot of traffic coming in.
>The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs()
>and there is no error handling when it is called from vmxnet3_recv_pkts().
>The RXD will
any fixes from vmware which fixes this issue ?
>
>-Original Message-
>From: Yong Wang [mailto:yongwang at vmware.com]
>Sent: Monday, December 14, 2015 11:57 AM
>To: Dey, Souvik ; dev at dpdk.org
>Subject: Re: [dpdk-dev] Vmxnet3 activation of device fails in DPDK1.7
>
On 12/3/15, 5:05 PM, "Stephen Hemminger" wrote:
>From: Stephen Hemminger
>
>The vmxnet3 interface specification supports having multiple
>receive rings. The first ring has buffers of BTYPE_HEAD which
>are used for the start of the packet, the second ring has buffers
>of type BTYPE_BODY which
; .rx_thresh = {
> .pthresh = RX_PTHRESH,
> .hthresh = RX_HTHRESH,
> .wthresh = RX_WTHRESH,
> },
>};
>
>Do you suspect anything wrong in this ?
>
>-Original Message-
>From: Yong Wang [mailto:yongwang at vmware.com]
>Sent: Friday, Decembe
On 12/10/15, 2:22 AM, "dev on behalf of Dey, Souvik" wrote:
>Hi,
>In DPDK 1.7 , while using the vmxnet3 pmd on vmware Esxi 5.5
> update 3 we are seeing that activation of the device fails.
>
>status = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD); return a non zero status.
On 12/3/15, 5:05 PM, "Stephen Hemminger" wrote:
>From: Nachiketa Prachanda
>
>vmxnet3_dev_vlan_offload_set(dev, mask) was incorrectly treating the
>mask parameter as the bitmask for vlan_strip and vlan_filter, whereas
>the mask indicates only what has changed - the values for
>vlan_stripping
Instead,
>setup the shadow table once during device initialization and just update
>during restart.
>
>Signed-off-by: Charles (Chas) Williams
>Signed-off-by: Stephen Hemminger
>---
Acked-by: Yong Wang
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 23 ---
>
On 10/22/15, 8:54 PM, "Bin Zhang" wrote:
>Hi,
>
>I got this issue in recent update esxi 5.5
Can you share more info on the specific version of ESXi you upgrade from/to and
the configs you used to initialize vmxnet3 pmd?
If this is 5.5U3, by any chance you are using a rx ring size that?s
On 10/27/15, 5:51 AM, "Konstantin Ananyev"
wrote:
>Signed-off-by: Konstantin Ananyev
>---
Acked-by: Yong Wang
Do you plan to implement rxq_info_get and txq_info_get for vmxnet3 in
subsequent patches?
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 12
> 1 file
On 10/30/15, 8:08 AM, "Bernard Iremonger"
wrote:
>Signed-off-by: Bernard Iremonger
>Acked-by: Bruce Richardson
>---
Acked-by: Yong Wang
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/vmxnet3/v
On 10/22/15, 7:28 AM, "Bernard Iremonger"
wrote:
>Signed-off-by: Bernard Iremonger
Acked-by: Yong Wang
Any specific reason you changed assignment of adapter_stopped from TRUE/FALSE
to 1/0?
I saw mixed uses of TRUE/FALSE, true/false and 1/0 all over the DPDK code base.
>
>++-
> 4 files changed, 266 insertions(+), 205 deletions(-)
>
>--
>2.1.4
Assuming this series is a simple rebase of the previous patchset, which I
already acked (I didn?t see the Acked-by updated though in the new
version):
Series Acked-by: Yong Wang
On 6/10/15, 9:09 AM, "Stephen Hemminger"
wrote:
>From: Stephen Hemminger
>
>Fix spelling errors in strings and comments.
>
>Signed-off-by: Stephen Hemminger
Acked-by: Yong Wang
>---
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 10 +-
> 1 file cha
, specific versions of
DPDK and ESXi are used. I understand that vmxnet3 pmd was introduced in
1.6 but I prefer them to be version-agonostic since the same diagram works
for 1.7, 1.8, etc and I don?t see much benefits in spelling out 1.6 in
this case. Same arguments to the ESXi version.
On 3/10/15, 11:35 AM, "Stephen Hemminger"
wrote:
>On Mon, 9 Mar 2015 23:32:48 +0000
>Yong Wang wrote:
>
>> >
>> >I didn?t see where mtu is used to calculate how many rx descriptors
>>will
>> >be needed for each packet. Furthermore,
On 3/9/15, 4:28 PM, "Yong Wang" wrote:
>On 3/5/15, 4:10 PM, "Stephen Hemminger"
>wrote:
>
>>From: Stephen Hemminger
>>
>>Add support for linking multi-segment buffers together to
>>handle Jumbo packets.
>>
>>Signed-off-by: St
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote:
>From: Stephen Hemminger
>
>Add support for linking multi-segment buffers together to
>handle Jumbo packets.
>
>Signed-off-by: Stephen Hemminger
>---
> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +-
> lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 2
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote:
>From: Stephen Hemminger
>
>No reason to inline large functions. Compiler will decide already
>based on optimization level.
>
>Also register array should be const.
>
>Signed-off-by: Stephen Hemminger
One c
n Hemminger
One minor comment below. Otherwise looks good to me.
Acked-by: Yong Wang
>---
> lib/librte_pmd_vmxnet3/vmxnet3_ring.h | 1 +
> lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 18 ++
> 2 files changed, 19 insertions(+)
>
>diff --git a/lib/librte_pmd
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote:
>By defining macro as a stub it is possible to get rid of #ifdef's
>in the actual code. Always evaluate the argument (even in the stub)
>so that there are no extra unused variable errors.
>
>Signed-off-by: Stephen Hemmin
On 3/5/15, 4:10 PM, "Stephen Hemminger" wrote:
>From: Stephen Hemminger
>
>Support the VLAN filter functionality of the VMXNET3 interface.
>
>Signed-off-by: Stephen Hemminger
Acked-by: Yong Wang
>---
> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 105
>
On 2/25/15, 6:31 PM, "Stephen Hemminger"
wrote:
>There are several stats here which are never set, and have no way
>to be displayed. Assume in future xstats could be used.
>
>Signed-off-by: Stephen Hemminger
Acked-by: Yong Wang
>---
> lib/librte_pmd
A quick glance over v2 shows that it only made the change for max segment
check. I am not sure if all the other comments on v1 of this patch are
missed or ignored? If it?s the latter, can you explain your reasoning why
they are not addressed?
On 2/25/15, 6:31 PM, "Stephen Hemminger"
wrote:
I believe I have ACKed v1 of this commit but I didn't see ACKed-by in v2.
Or is there any changes from v1? If that?s the case, can you explain the
changes in the changelog?
On 2/25/15, 6:32 PM, "Stephen Hemminger"
wrote:
>Refactor the logic to compute receive offload flags to a simpler
On 12/16/14, 9:13 PM, "Stephen Hemminger"
wrote:
>From: Stephen Hemminger
>
>VMXNET3 supports configuring filter table in host.
>
>Signed-off-by: Stephen Hemminger
>---
> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 107
>+---
> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h |
On 12/16/14, 9:13 PM, "Stephen Hemminger"
wrote:
>From: Stephen Hemminger
>
>Change sending loop to support multi-segment mbufs.
>The VMXNET3 api has start-of-packet and end-packet flags, so it
>is not hard to send multi-segment mbuf's.
>
>Also, update descriptor in 32 bit value rather than
correct value to indicate state change.
>
>Signed-off-by: Stephen Hemminger
>---
Acked-by: Yong Wang
One nit below:
> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 53
>+++--
> 1 file changed, 38 insertions(+), 15 deletions(-)
>
>diff
On 2/8/15, 10:40 PM, "Helin Zhang" wrote:
>To unify packet types among all PMDs, bit masks of packet type for
>ol_flags are replaced by unified packet type.
>
>Signed-off-by: Helin Zhang
>---
Acked-by: Yong Wang
> lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++--
&g
On 12/16/14, 9:13 PM, "Stephen Hemminger"
wrote:
>From: Stephen Hemminger
>
>Refactor the logic to compute receive offload flags to a simpler
>function. Andd add support for putting RSS flow hash into packet.
>
>Signed-off-by: Stephen Hemminger
>Signed-off-by:
On 12/16/14, 9:13 PM, "Stephen Hemminger"
wrote:
>From: Stephen Hemminger
>
>By defining macro as a stub it is possible to get rid of #ifdef's
>in the actual code.
>
>Signed-off-by: Stephen Hemminger
>---
> lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 6 --
>
1 - 100 of 123 matches
Mail list logo
