Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread Mattias Rönnblom
On 2024-09-09 14:25, David Marchand wrote: On Mon, Sep 9, 2024 at 2:05 PM Mattias Rönnblom wrote: Mattias, there are issues reported by the CI (compilation on Ubuntu 22.04 in GHA, and unit test failure in UNH), please have a look. Standard practice in DPDK header files is the following: --

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread David Marchand
On Mon, Sep 9, 2024 at 2:05 PM Mattias Rönnblom wrote: > > Mattias, there are issues reported by the CI (compilation on Ubuntu > > 22.04 in GHA, and unit test failure in UNH), please have a look. > > > > > > Standard practice in DPDK header files is the following: > > -- > /* rte_bar.h */ > #ifdef

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread Thomas Monjalon
09/09/2024 14:04, Mattias Rönnblom: > What one should do is to have extern "C" linkage only on functions which > the include file in question (e.g., rte_foo.h) itself declares. > > -- > /* rte_bar.h */ > #include > > #ifdef __cplusplus > extern "C" { > #endif > > void > rte_foo_do(void); > >

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-09 Thread Mattias Rönnblom
On 2024-09-05 10:10, David Marchand wrote: Hello, On Tue, Aug 20, 2024 at 7:05 PM Mattias Rönnblom wrote: On 2024-08-12 14:49, Mattias Rönnblom wrote: This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits.

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-09-05 Thread David Marchand
Hello, On Tue, Aug 20, 2024 at 7:05 PM Mattias Rönnblom wrote: > > On 2024-08-12 14:49, Mattias Rönnblom wrote: > > This patch set represent an attempt to improve and extend the RTE > > bitops API, in particular for functions that operate on individual > > bits. > > > > Is there anyone else that

Re: [PATCH v3 0/5] Improve EAL bit operations API

2024-08-20 Thread Mattias Rönnblom
On 2024-08-12 14:49, Mattias Rönnblom wrote: This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. Is there anyone else that has any opinion on this patch set? Details, or big picture.

[PATCH v3 0/5] Improve EAL bit operations API

2024-08-12 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun