Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-10-24 Thread Yoan Picchi
On 10/24/23 07:39, Juraj Linkeš wrote: On Mon, Oct 23, 2023 at 1:52 PM Yoan Picchi wrote: On 10/23/23 07:44, Juraj Linkeš wrote: My only nitpick comment would be on the name of the file common.py that only contain the MesonArgs class. Looks good otherwise Could you elaborate a bit more,

Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-10-23 Thread Juraj Linkeš
On Mon, Oct 23, 2023 at 1:52 PM Yoan Picchi wrote: > > On 10/23/23 07:44, Juraj Linkeš wrote: > > > > > >> > >> My only nitpick comment would be on the name of the file common.py that > >> only contain the MesonArgs class. Looks good otherwise > > > > Could you elaborate a bit more, Yoan? The com

Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-10-23 Thread Yoan Picchi
On 10/23/23 07:44, Juraj Linkeš wrote: My only nitpick comment would be on the name of the file common.py that only contain the MesonArgs class. Looks good otherwise Could you elaborate a bit more, Yoan? The common.py module is supposed to be extended with code common to all other modules i

Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-10-22 Thread Juraj Linkeš
> > My only nitpick comment would be on the name of the file common.py that > only contain the MesonArgs class. Looks good otherwise Could you elaborate a bit more, Yoan? The common.py module is supposed to be extended with code common to all other modules in the testbed_model package. Right now

Re: [RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-10-22 Thread Yoan Picchi
On 8/31/23 11:04, Juraj Linkeš wrote: sphinx-build only imports the Python modules when building the documentation; it doesn't run DTS. This requires changes that make the code importable without running it. This means: * properly guarding argument parsing in the if __name__ == '__main__' bloc

[RFC PATCH v4 1/4] dts: code adjustments for sphinx

2023-08-31 Thread Juraj Linkeš
sphinx-build only imports the Python modules when building the documentation; it doesn't run DTS. This requires changes that make the code importable without running it. This means: * properly guarding argument parsing in the if __name__ == '__main__' block. * the logger used by DTS runner underw