Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Nithin Dabilpuram
Hi Olivier, On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > External Email > > -- > Hi, > > On Fri, May 01, 2020 at 04:48:21PM +0530, Jerin Jacob wrote: > > On Fri, Apr 17, 2020 at 12:53 PM Nithin Dabilpuram > >

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Olivier Matz
On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > Hi Olivier, > > On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > > External Email > > > > -- > > Hi, > > > > On Fri, May 01, 2020 at 04:48:21PM

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Nithin Dabilpuram
On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > > Hi Olivier, > > > > On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > > > External Email > > > > > > ---

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Olivier Matz
On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > > On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > > > Hi Olivier, > > > > > > On Mon, May 04, 2020 at 10:06:34AM +0200, Olivier Matz wrote: > >

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-04 Thread Nithin Dabilpuram
On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > > > On Mon, May 04, 2020 at 01:57:06PM +0530, Nithin Dabilpuram wrote: > > > > Hi Olivier, > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-13 Thread Nithin Dabilpuram
Hi Olivier, Any thoughts on this ? On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-14 Thread Olivier Matz
Hi Nithin, On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > > On Mon, May 04, 2020 at 11:16:40AM +0200, Olivier Matz wrote: > > > > On Mon, M

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > Hi Nithin, > > On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > > > On Mo

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Ananyev, Konstantin
> On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > Hi Nithin, > > > > On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > > > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote:

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Thomas Monjalon
15/05/2020 12:08, Nithin Dabilpuram: > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > I don't see any better approach than having a mbuf flag. However, I'm > > still not fully convinced that a dynamic flag won't do the job. Taking > > 3 additional flags (among 18 remaing) for thi

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > 15/05/2020 12:08, Nithin Dabilpuram: > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > I don't see any better approach than having a mbuf flag. However, I'm > > > still not fully convinced that a dynamic flag w

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Fri, May 15, 2020 at 10:30:30AM +, Ananyev, Konstantin wrote: > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > Hi Nithin, > > > > > > On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > > > > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wr

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Thomas Monjalon
15/05/2020 15:44, Nithin Dabilpuram: > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > 15/05/2020 12:08, Nithin Dabilpuram: > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > > I don't see any better approach than having a mbuf flag. However, I'm > > > >

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Jerin Jacob
On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > 15/05/2020 15:44, Nithin Dabilpuram: > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > 15/05/2020 12:08, Nithin Dabilpuram: > > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > > > I don't se

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Thomas Monjalon
15/05/2020 18:26, Jerin Jacob: > On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > 15/05/2020 15:44, Nithin Dabilpuram: > > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > > 15/05/2020 12:08, Nithin Dabilpuram: > > > > > On Thu, May 14, 2020 at 10:29:31PM +0200, O

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Jerin Jacob
On Fri, May 15, 2020 at 10:22 PM Thomas Monjalon wrote: > > 15/05/2020 18:26, Jerin Jacob: > > On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > > 15/05/2020 15:44, Nithin Dabilpuram: > > > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > > > 15/05/2020 12:08, Nit

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Fri, May 15, 2020 at 06:52:23PM +0200, Thomas Monjalon wrote: > 15/05/2020 18:26, Jerin Jacob: > > On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > > 15/05/2020 15:44, Nithin Dabilpuram: > > > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > > > 15/05/2020 12:0

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-28 Thread Nithin Dabilpuram
Hi Olivier, On Fri, May 15, 2020 at 07:27:46PM +0530, Nithin Dabilpuram wrote: > On Fri, May 15, 2020 at 10:30:30AM +, Ananyev, Konstantin wrote: > > > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > > Hi Nithin, > > > > > > > > On Tue, May 05, 2020 at 11:49:20AM +0530

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-30 Thread Jerin Jacob
> > > I also share Olivier's concern about consuming 3 bits in ol_flags for > > > that feature. > > > Can it probably be squeezed somehow? > > > Let say we reserve one flag that this information is present or not, and > > > re-use one of rx-only fields for store additional information > > > (pack

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-02 Thread Ananyev, Konstantin
Hi Jerin, > > > > I also share Olivier's concern about consuming 3 bits in ol_flags for > > > > that feature. > > > > Can it probably be squeezed somehow? > > > > Let say we reserve one flag that this information is present or not, and > > > > re-use one of rx-only fields for store additional inf

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-02 Thread Nithin Dabilpuram
On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrote: > Hi Jerin, > > > > > > I also share Olivier's concern about consuming 3 bits in ol_flags for > > > > > that feature. > > > > > Can it probably be squeezed somehow? > > > > > Let say we reserve one flag that this information is

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Olivier Matz
Hi, On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrote: > > Hi Jerin, > > > > > > > > I also share Olivier's concern about consuming 3 bits in ol_flags > > > > > > for that feature. > > > > > > Can it probably

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Ananyev, Konstantin
> > > > > > I also share Olivier's concern about consuming 3 bits in ol_flags > > > > > > for that feature. > > > > > > Can it probably be squeezed somehow? > > > > > > Let say we reserve one flag that this information is present or > > > > > > not, and > > > > > > re-use one of rx-only fields fo

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Nithin Dabilpuram
On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > Hi, > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrote: > > > Hi Jerin, > > > > > > > > > > I also share Olivier's concern about consuming 3

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Olivier Matz
Hi Nithin, On Wed, Jun 03, 2020 at 04:14:14PM +0530, Nithin Dabilpuram wrote: > On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > > Hi, > > > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > > > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrot

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Nithin Dabilpuram
On Wed, Jun 03, 2020 at 01:38:22PM +0200, Olivier Matz wrote: > Hi Nithin, > > On Wed, Jun 03, 2020 at 04:14:14PM +0530, Nithin Dabilpuram wrote: > > On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > > > Hi, > > > > > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wro

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Thomas Monjalon
03/06/2020 13:38, Olivier Matz: > On Wed, Jun 03, 2020 at 04:14:14PM +0530, Nithin Dabilpuram wrote: > > On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > > > > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev,

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Slava Ovsiienko
henko > ; Ori Kam ; Burakov, > Anatoly ; Mcnamara, John > ; Kovacevic, Marko > ; dpdk-dev ; Jerin Jacob > ; Krzysztof Kanas ; > techbo...@dpdk.org > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for > packet marking > > On Wed, Jun 03, 20

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-08 Thread Nithin Dabilpuram
cu, Cristian > > ; Nithin Dabilpuram > > ; Thomas Monjalon ; > > Yigit, Ferruh ; Andrew Rybchenko > > ; Ori Kam ; Burakov, > > Anatoly ; Mcnamara, John > > ; Kovacevic, Marko > > ; dpdk-dev ; Jerin Jacob > > ; Krzysztof Kanas ; > > techbo...@dpdk.