Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-09-28 Thread Trahe, Fiona
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 22, 2020 8:18 PM > To: Kusztal, ArkadiuszX ; Doherty, Declan > ; > dev@dpdk.org > Cc: Trahe, Fiona ; ano...@marvell.com; > shal...@marvell.com; Zhang, Roy Fan > ; Ananyev, Konstantin > Subject: RE: [PATCH] [R

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-09-22 Thread Akhil Goyal
Hi Arek, > > Hi Akhil, > > @Akhil: Is there a chance getting this change into 20.11? > > Any more comments or anyone see any potential issues with this approach? > I am ok to take this patch in 20.11 release. Could you please send a new version With complete patch, removing all references of

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-09-01 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 29, 2020 3:22 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > ano...@marvell.com; shal...@marvell.com; Doherty, Declan > ; Zhang, Roy Fan ; > Ananyev, Konstantin ; Kusztal, ArkadiuszX > > Subject: [

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-08-04 Thread Kusztal, ArkadiuszX
Hi Akhil, @Akhil: Is there a chance getting this change into 20.11? Any more comments or anyone see any potential issues with this approach? Regards, Arek -Original Message- From: Doherty, Declan Sent: piÄ…tek, 31 lipca 2020 16:34 To: Kusztal, ArkadiuszX ; dev@dpdk.org Cc: akhil.go...@

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-31 Thread Doherty, Declan
On 29/07/2020 3:22 PM, Arek Kusztal wrote: This is proposal to move AES-GMAC algorithm to AEAD set of algorithms. It is however not 100% conformant GMAC as instead of aad pointer data to be authenticated is passed normally and aead.data.length field is used to specify length of data to be authen

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-29 Thread Trahe, Fiona
Hi Arek, Small typo below. > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 29, 2020 3:22 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > ano...@marvell.com; > shal...@marvell.com; Doherty, Declan ; Zhang, Roy > Fan > ; Ananyev, Konstantin > ;

Re: [dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-29 Thread Kusztal, ArkadiuszX
Hi All, I would give bit more introduction to this change: Right now AES-GMAC is auth only algorithm (previously it was cipher+auth -> GCM + GMAC), but since it is variant of AES-GCM implementation it should probably be AEAD right now (people often wondering why at all it is auth instead of AEAD

[dpdk-dev] [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms

2020-07-29 Thread Arek Kusztal
This is proposal to move AES-GMAC algorithm to AEAD set of algorithms. It is however not 100% conformant GMAC as instead of aad pointer data to be authenticated is passed normally and aead.data.length field is used to specify length of data to be authenticated. Reason behind this move is that GMAC