Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-16 Thread Adrien Mazarguil
Hi Kirill, On Tue, Jan 16, 2018 at 05:23:05PM +, Rybalchenko, Kirill wrote: > Hi Adrien, > after some discussion we found that change I've done > in Mellanox PMD is not really necessary: size of array > flow_types_mask[] is still 1 and the loop in patch > > for (i = 0; i < RTE_FLOW_MASK_AR

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-16 Thread Rybalchenko, Kirill
Hi Adrien, after some discussion we found that change I've done in Mellanox PMD is not really necessary: size of array flow_types_mask[] is still 1 and the loop in patch for (i = 0; i < RTE_FLOW_MASK_ARRAY_SIZE; i++) info->flow_types_mask[i] = 0ULL; will work exactly in the same way a

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-16 Thread Adrien Mazarguil
On Tue, Jan 09, 2018 at 03:16:13PM +, Rybalchenko, Kirill wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Monday 4 December 2017 17:43 > > To: Rybalchenko, Kirill > > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > ; johnd...@cis

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-10 Thread Thomas Monjalon
Hi, 09/01/2018 16:16, Rybalchenko, Kirill: > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > On Mon, Nov 27, 2017 at 12:29:47PM +, Kirill Rybalchenko wrote: > > > Increase the internal limit for flow types from 32 to 64 to support > > > future flow type extensions. > > > Change

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-09 Thread Xing, Beilei
> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, November 27, 2017 8:30 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; johnd...@cisco.com; neesc...@cisco.com; > adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com; > ys...@mellanox.com; Lu, Wenzhuo ; Ananyev

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-09 Thread Rybalchenko, Kirill
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday 4 December 2017 17:43 > To: Rybalchenko, Kirill > Cc: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; johnd...@cisco.com; neesc...@cisco.com; > nelio.laranje...@6wind.com; ys...@mellanox.com; L

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2018-01-09 Thread Zhang, Helin
@mellanox.com; Lu, Wenzhuo; Ananyev, Konstantin; Rybalchenko, Kirill; > Chilikin, Andrey > Subject: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64 > > Increase the internal limit for flow types from 32 to 64 to support future > flow > type extensions. > Chang

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2017-12-04 Thread Adrien Mazarguil
Hi Kirill, On Mon, Nov 27, 2017 at 12:29:47PM +, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_globa

[dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2017-11-27 Thread Kirill Rybalchenko
Increase the internal limit for flow types from 32 to 64 to support future flow type extensions. Change type of variables from uint32_t[] to uint64_t[]: rte_eth_fdir_info.flow_types_mask rte_eth_hash_global_conf.sym_hash_enable_mask rte_eth_hash_global_conf.valid_bit_mask This modification a