Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-06-24 Thread Thomas Monjalon
26/05/2020 12:08, guohongzhi: > From: Hongzhi Guo > > 0x is invalid for IPv4 checksum(RFC1624) > > Fixes: 6006818cfb26 ("net: new checksum functions") > Cc: sta...@dpdk.org > > Reviewed-By: Morten Brørup > Acked-by: Olivier Matz > > Signed-off-by: Hongzhi Guo The Signed-off should be i

[dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-05-26 Thread guohongzhi
From: Hongzhi Guo 0x is invalid for IPv4 checksum(RFC1624) Fixes: 6006818cfb26 ("net: new checksum functions") Cc: sta...@dpdk.org Reviewed-By: Morten Brørup Acked-by: Olivier Matz Signed-off-by: Hongzhi Guo --- lib/librte_net/rte_ip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-05-26 Thread Morten Brørup
guohongzhi, You must use your real name in the Signed-off-by line. The signoff must be a real name and not an alias or nickname. For further details, please refer to: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1 Med venlig hilsen

[dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-05-26 Thread guohongzhi
0x is invalid for IPv4 checksum(RFC1624) Fixes: 6006818cfb26 ("net: new checksum functions") Reviewed-By: Morten Brørup Acked-by: Olivier Matz Signed-off-by: guohongzhi --- lib/librte_net/rte_ip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ip.h

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-05-24 Thread Thomas Monjalon
14/05/2020 03:27, guohongzhi: > The function of rte_ipv4_cksum for calculating the > checksum of IPv4 header is incorrect. > This function will return checksum value like 0x. > This value, however, is considered an illegal checksum on some switches(like > Trident3). > > RFC 1624 specifies the

[dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-05-13 Thread guohongzhi
The function of rte_ipv4_cksum for calculating the checksum of IPv4 header is incorrect. This function will return checksum value like 0x. This value, however, is considered an illegal checksum on some switches(like Trident3). RFC 1624 specifies the IPv4 checksum as follows: https://tools.iet