Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Fri, 19 Mar 2021 10:34:02 -0400 Aaron Conole wrote: > > The check is evaluated first when configuring as normal user and not > > reevaluated when running the tests as root in Travis/GHA, so the tests > > are started with no hugepage. > > > > Then, in Travis and GHA, we can see (sigbus o_O) cra

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Fri, Apr 9, 2021 at 5:33 PM Thomas Monjalon wrote: > > > This seems to me like the test binary itself should be checking the > > > presence of hugepages, and reporting skips if necessary. It's not just > > > when > > > run through ninja that this functionality would be useful. > > > > Either w

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Fri, Apr 09, 2021 at 11:06:20AM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: > >> Bruce Richardson writes: > >> > >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: > >> >> Thomas Monjalon writes: >

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

09/04/2021 17:06, Aaron Conole: > Bruce Richardson writes: > > > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: > >> Bruce Richardson writes: > >> > >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: > >> >> Thomas Monjalon writes: > >> >> > >> >> > 17/03/2021 1

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

Bruce Richardson writes: > On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: >> Bruce Richardson writes: >> >> > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: >> >> Thomas Monjalon writes: >> >> >> >> > 17/03/2021 15:44, Aaron Conole: >> >> >> The hugepage test rea

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Tue, Apr 06, 2021 at 10:20:37AM -0400, Aaron Conole wrote: > Bruce Richardson writes: > > > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: > >> Thomas Monjalon writes: > >> > >> > 17/03/2021 15:44, Aaron Conole: > >> >> The hugepage test really needs to check multiple things o

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

Bruce Richardson writes: > On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: >> Thomas Monjalon writes: >> >> > 17/03/2021 15:44, Aaron Conole: >> >> The hugepage test really needs to check multiple things on Linux: >> >> >> >> 1. Are hugepages reserved in the system? >> >> >> >>

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Tue, Apr 06, 2021 at 08:33:07AM -0400, Aaron Conole wrote: > Thomas Monjalon writes: > > > 17/03/2021 15:44, Aaron Conole: > >> The hugepage test really needs to check multiple things on Linux: > >> > >> 1. Are hugepages reserved in the system? > >> > >> 2. Is the hugepage mountpoint availab

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

Thomas Monjalon writes: > 17/03/2021 15:44, Aaron Conole: >> The hugepage test really needs to check multiple things on Linux: >> >> 1. Are hugepages reserved in the system? >> >> 2. Is the hugepage mountpoint available so that we can allocate them? >> >> 3. Do we have permissions to write int

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

David Marchand writes: > On Wed, Mar 17, 2021 at 3:44 PM Aaron Conole wrote: >> diff --git a/app/test/has-hugepage.sh b/app/test/has-hugepage.sh >> index d600fad319..1c3cfb665a 100755 >> --- a/app/test/has-hugepage.sh >> +++ b/app/test/has-hugepage.sh >> @@ -3,7 +3,17 @@ >> # Copyright 2020 Mel

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

On Wed, Mar 17, 2021 at 3:44 PM Aaron Conole wrote: > diff --git a/app/test/has-hugepage.sh b/app/test/has-hugepage.sh > index d600fad319..1c3cfb665a 100755 > --- a/app/test/has-hugepage.sh > +++ b/app/test/has-hugepage.sh > @@ -3,7 +3,17 @@ > # Copyright 2020 Mellanox Technologies, Ltd > > if [

Re: [dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

17/03/2021 15:44, Aaron Conole: > The hugepage test really needs to check multiple things on Linux: > > 1. Are hugepages reserved in the system? > > 2. Is the hugepage mountpoint available so that we can allocate them? > > 3. Do we have permissions to write into the hugepage mountpoint? > > The

[dpdk-dev] [PATCH] test: make hugepage check more robust under Linux

The hugepage test really needs to check multiple things on Linux: 1. Are hugepages reserved in the system? 2. Is the hugepage mountpoint available so that we can allocate them? 3. Do we have permissions to write into the hugepage mountpoint? The existing hugepage check only verifies the first.