[dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-18 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-04 Thread Matan Azrad
Hi Cristian From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Monday, March 29, 2021 9:44 PM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko ; Shahaf > > Shuler ; lir...@marvell.com; Singh, Jasvinder

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-23 Thread Dumitrescu, Cristian
Hi Li and Matan, Thank you for your proposal, some comments below. I am also adding Jerin and Hemant to this thread, as they also participated in the definition of the rte_mtr API in 2017. Also Ajit expressed some interest in a previous email. > -Original Message- > From: Li Zhang > S

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-24 Thread Matan Azrad
Hi Cristian Thank you for your important review! I agree with all your comments except one, please see inline. From: Dumitrescu, Cristian > Hi Li and Matan, > > Thank you for your proposal, some comments below. > > I am also adding Jerin and Hemant to this thread, as they also participated in >

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Ori Kam
Hi All, > -Original Message- > From: Matan Azrad > Subject: RE: [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API > > Hi Cristian > > Thank you for your important review! > I agree with all your comments except one, please see inline. > > From: Dumitrescu, Cristian > > Hi Li

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Jerin Jacob
On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very limited. > In addition, the policy cannot be pre-defined. > > Due to the growing in flow actions offload abilities th

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Thursday, March 25, 2021 6:57 AM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andr

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Dumitrescu, Cristian
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Monday, March 29, 2021 10:23 AM > To: Matan Azrad ; Dumitrescu, Cristian > ; Li Zhang ; Dekel Peled > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andrew

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Matan Azrad
Hi Jerin Thanks for the review. PSB From: Jerin Jacob > On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > > > Currently, the flow meter policy does not support multiple actions per > > color; also the allowed action types per color are very limited. > > In addition, the policy cannot be pre-de

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-29 Thread Matan Azrad
From: Dumitrescu, Cristian > Hi Matan, > > > -Original Message- > > From: Matan Azrad > > Sent: Thursday, March 25, 2021 6:57 AM > > To: Dumitrescu, Cristian ; Li Zhang > > ; Dekel Peled ; Ori Kam > > ; Slava Ovsiienko ; Shahaf > > Shuler ; lir...@marvell.com; Singh, Jasvinder > > ; NBU

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-31 Thread Jerin Jacob
On Tue, Mar 30, 2021 at 2:01 AM Matan Azrad wrote: > > Hi Jerin > > Thanks for the review. > PSB > > From: Jerin Jacob > > On Thu, Mar 18, 2021 at 2:28 PM Li Zhang wrote: > > > > > > Currently, the flow meter policy does not support multiple actions per > > > color; also the allowed action types

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-31 Thread Dumitrescu, Cristian
Hi Matan, > -Original Message- > From: Matan Azrad > Sent: Monday, March 29, 2021 9:44 PM > To: Dumitrescu, Cristian ; Li Zhang > ; Dekel Peled ; Ori Kam > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andrew

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-01 Thread Ori Kam
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Hi Ori, > > > -Original Message- > > From: Ori Kam > > Hi All, > > > > > -Original Message- > > > From: Matan Azrad > > > Subject: RE: [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API > > > > >

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-01 Thread Dumitrescu, Cristian
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Thursday, April 1, 2021 2:14 PM > To: Dumitrescu, Cristian ; Matan Azrad > ; Li Zhang ; Dekel Peled > ; Slava Ovsiienko ; Shahaf > Shuler ; lir...@marvell.com; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Ferruh ; Andrew

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-01 Thread Ori Kam
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > > Hi Ori, > > > -Original Message- > > From: Ori Kam > > Hi Cristian, > > > > > -Original Message- > > > From: Dumitrescu, Cristian > > > Hi Ori, > > > > > > > -Original Message- > > > > From: Or

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-20 Thread Stephen Hemminger
On Thu, 18 Mar 2021 10:58:14 +0200 Li Zhang wrote: > + > + /** > + * Color the packet to reflect the meter color result. > + * > + * See struct rte_flow_action_color. > + */ > + RTE_FLOW_ACTION_TYPE_COlOR, Why the odd use of lower case here? Shouldn't it be RTE_FLOW_A

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-20 Thread Li Zhang
Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler ; lir...@marvell.com; > jasvinder.si...@intel.com; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Cristian Dumitrescu > ; dev@dpdk.org; Raslan Darawsheh > ; Roni Bar Yanai > Subject: Re: [dpdk-