Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-05-01 Thread Burakov, Anatoly
On 30-Apr-20 6:38 PM, David Christensen wrote: Why is this needed? It's hardware specific to the PPC64 platform.  I don't know of a situation where the IOMMU would be present on other hardware.  Even running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1 IOMMU which isn't support

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread David Christensen
Why is this needed? It's hardware specific to the PPC64 platform.  I don't know of a situation where the IOMMU would be present on other hardware.  Even running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1 IOMMU which isn't supported in DPDK. Dave Yes, but generally #ifdef's

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread Burakov, Anatoly
On 30-Apr-20 5:22 PM, David Christensen wrote: Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- Why is this needed? It's hardware specific to the PPC64 platform.  I don't know of a situation where the IOMMU would be present on other hardware.  Ev

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread David Christensen
Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- Why is this needed? It's hardware specific to the PPC64 platform. I don't know of a situation where the IOMMU would be present on other hardware. Even running a VM in KVM/QEMU on a PPC64 platform

Re: [dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-30 Thread Burakov, Anatoly
On 30-Apr-20 12:29 AM, David Christensen wrote: Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- Why is this needed? -- Thanks, Anatoly

[dpdk-dev] [PATCH 1/2] vfio: use ifdef's for ppc64 spapr code

2020-04-29 Thread David Christensen
Enclose ppc64 specific SPAPR VFIO support with ifdef's. Signed-off-by: David Christensen --- lib/librte_eal/linux/eal_vfio.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c index d26e1649a..953397984 10