Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-16 Thread Adrian Moreno
On 7/16/20 10:18 AM, David Marchand wrote: > On Thu, Jul 16, 2020 at 9:53 AM Adrian Moreno wrote: +if (ret > UINT8_MAX) { +PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS response 0x%" PRIx64 "\n", ret); >>> >>> There's a coding style issue here: >>> CHECK:CAMELC

Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-16 Thread David Marchand
On Thu, Jul 16, 2020 at 9:53 AM Adrian Moreno wrote: > >> +if (ret > UINT8_MAX) { > >> +PMD_INIT_LOG(ERR, "Invalid VHOST_USER_GET_STATUS > >> response 0x%" PRIx64 "\n", ret); > > > > There's a coding style issue here: > > CHECK:CAMELCASE: Avoid CamelCase: > > Could you fix this? >

Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-16 Thread Adrian Moreno
On 7/16/20 5:31 AM, Xia, Chenbo wrote: > Hi Adrian, > >> -Original Message- >> From: Adrian Moreno >> Sent: Thursday, July 16, 2020 1:18 AM >> To: dev@dpdk.org >> Cc: maxime.coque...@redhat.com; Wang, Zhihong ; >> amore...@redhat.com; Xia, Chenbo >> Subject: [PATCH 4/5] net/virtio: ad

Re: [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-15 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: Adrian Moreno > Sent: Thursday, July 16, 2020 1:18 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > amore...@redhat.com; Xia, Chenbo > Subject: [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user > > This patch a

[dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user

2020-07-15 Thread Adrian Moreno
This patch adds support for VHOST_USER_GET_STATUS request. Only vhost-user backed is supported for now Signed-off-by: Adrian Moreno --- drivers/net/virtio/virtio_user/vhost_user.c | 2 + .../net/virtio/virtio_user/virtio_user_dev.c | 39 +++ .../net/virtio/virtio_user/virtio