Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread Thomas Monjalon
07/07/2021 12:40, David Marchand: > On Wed, Jul 7, 2021 at 11:59 AM Thomas Monjalon wrote: > > > This is problematic, as the following rule does not work: > > > > > > +; Ignore bitfields added in rte_eth_dev_data hole > > > +[suppress_type] > > > +name = rte_eth_dev_data > > > +has

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread David Marchand
On Wed, Jul 7, 2021 at 11:59 AM Thomas Monjalon wrote: > > This is problematic, as the following rule does not work: > > > > +; Ignore bitfields added in rte_eth_dev_data hole > > +[suppress_type] > > +name = rte_eth_dev_data > > +has_data_member_inserted_between = {offset_after(lr

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread Thomas Monjalon
07/07/2021 11:36, David Marchand: > On Wed, Jul 7, 2021 at 10:23 AM Andrew Rybchenko > wrote: > > > > On 7/7/21 10:39 AM, David Marchand wrote: > > > On Tue, Jul 6, 2021 at 10:36 AM Andrew Rybchenko > > > wrote: > > >> > > >> @David, could you take a look at the ABI breakage warnings for > > >> t

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread David Marchand
On Wed, Jul 7, 2021 at 10:23 AM Andrew Rybchenko wrote: > > On 7/7/21 10:39 AM, David Marchand wrote: > > On Tue, Jul 6, 2021 at 10:36 AM Andrew Rybchenko > > wrote: > >> > >> @David, could you take a look at the ABI breakage warnings for > >> the patch. May we ignore it since ABI looks backward

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread Huisong Li
在 2021/7/7 16:25, Andrew Rybchenko 写道: On 7/7/21 5:55 AM, Huisong Li wrote: 在 2021/7/6 16:36, Andrew Rybchenko 写道: @David, could you take a look at the ABI breakage warnings for the patch. May we ignore it since ABI looks backward compatible? Or should be marked as a minor change ABI which is

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread Andrew Rybchenko
On 7/7/21 5:55 AM, Huisong Li wrote: > > 在 2021/7/6 16:36, Andrew Rybchenko 写道: >> @David, could you take a look at the ABI breakage warnings for >> the patch. May we ignore it since ABI looks backward >> compatible? Or should be marked as a minor change ABI >> which is backward compatible with DP

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread Andrew Rybchenko
On 7/7/21 10:39 AM, David Marchand wrote: > On Tue, Jul 6, 2021 at 10:36 AM Andrew Rybchenko > wrote: >> >> @David, could you take a look at the ABI breakage warnings for >> the patch. May we ignore it since ABI looks backward >> compatible? Or should be marked as a minor change ABI >> which is ba

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread David Marchand
On Tue, Jul 6, 2021 at 10:36 AM Andrew Rybchenko wrote: > > @David, could you take a look at the ABI breakage warnings for > the patch. May we ignore it since ABI looks backward > compatible? Or should be marked as a minor change ABI > which is backward compatible with DPDK_21? The whole eth_dev_

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-06 Thread Huisong Li
在 2021/7/6 16:36, Andrew Rybchenko 写道: @David, could you take a look at the ABI breakage warnings for the patch. May we ignore it since ABI looks backward compatible? Or should be marked as a minor change ABI which is backward compatible with DPDK_21? On 7/6/21 7:10 AM, Huisong Li wrote: Curr

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-06 Thread Ananyev, Konstantin
> Currently, if dev_configure is not called or fails to be called, users > can still call dev_start successfully. So it is necessary to have a flag > which indicates whether the device is configured, to control whether > dev_start can be called and eliminate dependency on user invocation order. >

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-06 Thread Andrew Rybchenko
@David, could you take a look at the ABI breakage warnings for the patch. May we ignore it since ABI looks backward compatible? Or should be marked as a minor change ABI which is backward compatible with DPDK_21? On 7/6/21 7:10 AM, Huisong Li wrote: > Currently, if dev_configure is not called or f

[dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
Currently, if dev_configure is not called or fails to be called, users can still call dev_start successfully. So it is necessary to have a flag which indicates whether the device is configured, to control whether dev_start can be called and eliminate dependency on user invocation order. The flag s