[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

2014-01-14 Thread Thomas Monjalon
14/01/2014 11:57, Daniel Kan : > On Jan 14, 2014, at 9:42 AM, Maxime Leroy wrote: > > An other issue about not enabling RSS with 1 queue, when you use the > > command show_rss_key in the testpmd, this one will display that the RSS > > is enabled. (because rss_hf != 0; see port_rss_hash_conf_show f

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

2014-01-14 Thread Maxime Leroy
Hello, Thanks for your patch fixing the regression introduced by my commit (igb/ixgbe: ETH_MQ_RX_NONE should disable RSS). I have one comment about your fix. I don't think there are any reasons to not enable RSS with only one RX queue in testpmd. RSS is mainly used in testpmd to spread traffic o

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

2014-01-14 Thread Daniel Kan
Maxime, Thanks for your comment. If we want testpmd to have RSS always enabled out of box (note that rxq=1), then your suggestion makes sense. I?m new to dpdk so I was trying to preserve the current behavior. Now looking back, I guess that?s why we have an explicit disable-rss option. If I don?t

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

2014-01-13 Thread Daniel Kan
The mq_mode was not set when rxq is > 1; it's defaulted to ETH_MQ_RX_NONE. As a result, RSS remains inactive. The fix is to set mq_mode to ETH_MQ_RX_RSS when rxq is > 1 and hf is non-zero. This bug was introduced by commit 243db2ddee3094a2cb39fdd4b17e26df4e7735e1 igb/ixgbe: ETH_MQ_RX_NONE should d