[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-20 Thread H. Peter Anvin
On 03/20/2014 04:27 AM, Neil Horman wrote: >> > So, I answered my own question, sort of. The __i386__ is clear: x86_64 uses > RIP > relative addressing, making the saving of ebx not needed - thats perfectly > clear. > > Whats a bit less clear to me is why it matters. Ideally moving ebx and > re

[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-20 Thread Neil Horman
On Thu, Mar 20, 2014 at 07:03:23AM -0400, Neil Horman wrote: > On Wed, Mar 19, 2014 at 09:22:03PM -0700, H. Peter Anvin wrote: > > On 03/19/2014 05:40 PM, Neil Horman wrote: > > > So after some discussion with hpa, I need to self NAK this again, > > > apologies for > > > the noise. Theres some cl

[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-20 Thread Neil Horman
On Wed, Mar 19, 2014 at 09:22:03PM -0700, H. Peter Anvin wrote: > On 03/19/2014 05:40 PM, Neil Horman wrote: > > So after some discussion with hpa, I need to self NAK this again, apologies > > for > > the noise. Theres some clean up to be done in this area, and I'm still > > getting > > a segfau

[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-19 Thread H. Peter Anvin
On 03/19/2014 05:40 PM, Neil Horman wrote: > So after some discussion with hpa, I need to self NAK this again, apologies > for > the noise. Theres some clean up to be done in this area, and I'm still > getting > a segfault that is in some way related to this code, but I need to dig deeper > to

[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-19 Thread Neil Horman
On Wed, Mar 19, 2014 at 08:44:46AM -0700, H. Peter Anvin wrote: > On 03/19/2014 07:48 AM, Neil Horman wrote: > > The recent conversion to build dpdk as a DSO has an error in > > rte_cpu_get_features. When being build with -fpie, %ebx gets clobbered by > > the > > cpuid instruction which is also t

[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-19 Thread Neil Horman
The recent conversion to build dpdk as a DSO has an error in rte_cpu_get_features. When being build with -fpie, %ebx gets clobbered by the cpuid instruction which is also the pic register. Therefore the inline asm tries to save off %ebx, but does so incorrectly. It starts by loading params.ebx t

[dpdk-dev] [PATCH v2] eal: fix up bad asm in rte_cpu_get_features

2014-03-19 Thread H. Peter Anvin
On 03/19/2014 07:48 AM, Neil Horman wrote: > The recent conversion to build dpdk as a DSO has an error in > rte_cpu_get_features. When being build with -fpie, %ebx gets clobbered by the > cpuid instruction which is also the pic register. Therefore the inline asm > tries to save off %ebx, but does