25/02/2019 18:52, Jerin Jacob Kollanukkaran:
> On Tue, 2019-02-12 at 15:01 +0800, Ruifeng Wang wrote:
> > Implemented signature compare function based on neon intrinsic.
> > Hash bulk lookup had 3% - 6% performance gain after optimization.
> >
> > Signed-off-by: Ruifeng Wang
> > Reviewed-by: Gavi
On Tue, 2019-02-12 at 15:01 +0800, Ruifeng Wang wrote:
> ---
> ---
> Implemented signature compare function based on neon intrinsic.
> Hash bulk lookup had 3% - 6% performance gain after optimization.
>
> Signed-off-by: Ruifeng Wang
Hi Yipeng,
Thanks for your review and acknowledgement.
I did think about braces on separate lines. One concern is, in this way, extra
indent will be needed and
make it hard to keep code lines within 80 characters. So I made the style
compromise.
Regards,
/Ruifeng
> -Original Message-
Hi, Ruifeng,
I don't have an ARM Platform at hand to test but I gone through the code
against a NEON instruction manual,
and the logic looks good to me. One small comment is the coding style for
switch case, I think it is more common
to leave the braces on their own lines.
Otherwise:
Acked-by:
Implemented signature compare function based on neon intrinsic.
Hash bulk lookup had 3% - 6% performance gain after optimization.
Signed-off-by: Ruifeng Wang
Reviewed-by: Gavin Hu
---
v2:
* Use 'rte_vect.h' instead of 'arm_neon.h'.
* Moved down variable declaration to avoid extra #ifdef.
lib/l
5 matches
Mail list logo
