Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-09 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 08 May 2018 20:14 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: Doherty, Declan ; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; >dev@dpdk.org; Sahu, Sunila ; >Gupta, Ashish >Subject: RE: [P

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-08 Thread De Lara Guarch, Pablo
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, May 8, 2018 11:58 AM > To: Trahe, Fiona ; De Lara Guarch, Pablo > > Cc: Doherty, Declan ; Athreya, Narayana Prasad > ; Sahu, Sunila > ; Gupta, Ashish ; > dev@dpdk.org; Sahu, Sunila ; Gu

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-08 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, April 5, 2018 12:25 PM > To: De Lara Guarch, Pablo > Cc: Doherty, Declan ; Trahe, Fiona > ; > pathr...@caviumnetworks.com; ss...@caviumnetworks.com; > agu...@caviumnetworks.c

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-08 Thread Verma, Shally
Hi Fiona >-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 08 May 2018 16:22 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: Doherty, Declan ; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; >dev@dpdk.org; Sahu, Sunila ; >Gupta, Ashish ; Trahe,

Re: [dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-05-08 Thread Trahe, Fiona
Hi Shally, Reviewing the asymm v2 patch - quick comment: > List of TBDs: > - change PMD ops session_get_size, session_configure, session_clear > to sym_session_* APIs > - change external get_session_private_size to sym_get_session_* > - per-service stats update [Fiona] You'll need to send a de

[dpdk-dev] [PATCH v2 2/6] lib/cryptodev: add asym op support in cryptodev

2018-04-05 Thread Shally Verma
Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op pool create/alloc APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its qps. If PMD support b