Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-09 Thread Thomas Monjalon
09/04/2021 10:31, Gabriel Ganne: > Hi Thomas, > > Thanks for the review. > > The use case that made me see this is that I configured the dpdk using meson > option "-- default_library=static" in conjunction with buildroot which is > patching > meson to prefer static libraries in this case. > This

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-09 Thread Gabriel Ganne
Hi Thomas, Thanks for the review. The use case that made me see this is that I configured the dpdk using meson option "-- default_library=static" in conjunction with buildroot which is patching meson to prefer static libraries in this case. This causes the link line generated from the dependency(

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-08 Thread Thomas Monjalon
Thank you, the fix looks good. I would like to improve the explanation. If I understand the issue, the title should be "build: remove redundant libpcap link" 26/03/2021 09:22, Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correc

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-04-03 Thread Dmitry Kozlyuk
2021-03-26 09:22 (UTC+0100), Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > It also has the side effect of messing with the meson link line: dpdk > link will be d

Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-03-26 Thread Thomas Monjalon
26/03/2021 09:22, Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > It also has the side effect of messing with the meson link line: dpdk > link will be declared twi

[dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap

2021-03-26 Thread Gabriel Ganne
libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. It also has the side effect of messing with the meson link line: dpdk link will be declared twice: manually and then through pkg-config. If